Description
I noticed that I was getting some incorrect lyrics for certain songs. If I understand correctly, the query constructed by the MPRIS source (and perhaps others as well, I didn't check those) is <artist> <title>. I would like to suggest <artist> - <album> - <title> instead (if != "" like now, of course).
If you agree to this conceptually, I'd be willing to open a pull request if desired. My Go experience is very limited, but this change looks simple enough.
Motivation
The current query does not seem to sufficiently narrow down results. For example, I noticed issues with the Exegenesis tracks from Muse's album The Resistance (some others as well but these are the ones I experimented with more in-depth). The last 3 tracks of the album are:
- Exogenesis: Symphony Part 1 (Overture)
- Exogenesis: Symphony Part 2 (Cross-Polination)
- Exogenesis: Symphony Part 3 (Redemption)
When I try the current query (e.g. curl -G "https://lyricsapi.vercel.app/api/lyrics?lrc=1" --data-urlencode "name=Muse Exogenesis: Symphony Part 1 (Overture)" for the first one), it returns the lyrics for the track "Hysteria" from the album "Absolution" (also by Muse) instead, for each of the three songs. When I try my suggested query (e.g. curl -G "https://lyricsapi.vercel.app/api/lyrics?lrc=1" --data-urlencode "name=Muse - The Resistance - Exogenesis: Symphony Part 1 (Overture)") it gives the correct lyrics.
For reference, the - seem to be required for disambiguation: if I leave them out, the first two tracks resolve correctly but the third one still returns the lyrics for "Hysteria".
PS: thanks for the amazing application, I only recently discovered it but I'm loving it already.
Description
I noticed that I was getting some incorrect lyrics for certain songs. If I understand correctly, the query constructed by the MPRIS source (and perhaps others as well, I didn't check those) is
<artist> <title>. I would like to suggest<artist> - <album> - <title>instead (if!= ""like now, of course).If you agree to this conceptually, I'd be willing to open a pull request if desired. My Go experience is very limited, but this change looks simple enough.
Motivation
The current query does not seem to sufficiently narrow down results. For example, I noticed issues with the Exegenesis tracks from Muse's album The Resistance (some others as well but these are the ones I experimented with more in-depth). The last 3 tracks of the album are:
When I try the current query (e.g.
curl -G "https://lyricsapi.vercel.app/api/lyrics?lrc=1" --data-urlencode "name=Muse Exogenesis: Symphony Part 1 (Overture)"for the first one), it returns the lyrics for the track "Hysteria" from the album "Absolution" (also by Muse) instead, for each of the three songs. When I try my suggested query (e.g.curl -G "https://lyricsapi.vercel.app/api/lyrics?lrc=1" --data-urlencode "name=Muse - The Resistance - Exogenesis: Symphony Part 1 (Overture)") it gives the correct lyrics.For reference, the
-seem to be required for disambiguation: if I leave them out, the first two tracks resolve correctly but the third one still returns the lyrics for "Hysteria".PS: thanks for the amazing application, I only recently discovered it but I'm loving it already.