test: resolveClientCommand codex/claude test is environment-dependent (fails when codex/claude live in /usr/bin)

[ranxianglei]

来源: 分析 #641（PR review）时发现

Problem

tests/launcher.test.ts:1069 — resolveClientCommand: codex/claude resolve to themselves asserts the not-on-PATH fallback:

assert.deepEqual(resolveClientCommand("codex", { PATH: "/usr/bin" }), {
    command: "codex",
    prefixArgs: [],
});
assert.deepEqual(resolveClientCommand("claude", { PATH: "/usr/bin" }), {
    command: "claude",
    prefixArgs: [],
});

It hard-codes /usr/bin as a PATH that does NOT contain codex/claude. On any machine where codex or claude is installed in /usr/bin (common for this project's target users — developers who run these CLIs), the test fails:

AssertionError: Expected values to be strictly deep-equal:
  {
+   command: '/usr/bin/codex',
-   command: 'codex',
  }

Impact

• npm test is red on any dev machine with codex/claude in /usr/bin (observed: sandbox with /usr/bin/codex installed → 1 failure out of 1252; pre-existing on master, not PR-specific).
• CI stays green (GitHub ubuntu runners don't ship codex/claude), so the breakage is only visible locally.
• No product impact — resolveOnPath (src/launcher.ts) itself is correct; only the test's environment assumption is wrong.

Suggested fix

Make the test hermetic, following the pattern of the codebuddy tests in #641:

• not-on-PATH case: pass a PATH pointing at an empty temp dir.
• on-PATH case: create a fake codex/claude executable in a temp bin dir and assert the absolute path is returned.

Minor severity — test hygiene only.

[ranxianglei]

🤖 Powered by ework · qwen3.8-27b

[bot] 🏷 Fixed — PR: #643

Triage (审核结论):

1. 复现/查证 — 问题属实。本沙箱恰好装有 /usr/bin/codex 和 /usr/bin/claude，在 master 上直接复现了 issue 中贴的 AssertionError（command: '/usr/bin/codex' vs 'codex'）。确认是 pre-existing 于 master 的环境依赖问题，非 PR 引入。
2. 层次判断 — 与 issue 一致：resolveOnPath（src/launcher.ts:1620）行为正确，问题仅在测试把 /usr/bin 硬编码为"不含 codex/claude 的 PATH"这一错误环境假设。无产品影响。
3. 方案 — 采用 issue 建议的 hermetic 方案，并对照了 feat: add codebuddy client support (bili codebuddy) #641 中 codebuddy 测试的实际写法（PR 尚未合入，已拉取其 diff 对齐模式），同时与文件内既有 pi 测试（pi on PATH resolves to full path，temp dir + 假可执行文件）保持一致。

改动（仅 tests/launcher.test.ts，单测拆分）:

• resolveClientCommand: codex/claude not on PATH fall back to bare name — PATH 指向空 temp dir，断言回落到裸名 codex / claude
• resolveClientCommand: codex/claude on PATH resolve to full path — temp bin dir 里创建假 codex / claude 可执行文件（0o755），断言返回绝对路径

Pre-flight:

• npm run typecheck — 通过
• npm test — 1241/1241 通过（本沙箱上修复前 1 fail / 修复后 0 fail）
• npm run build — 成功

注：文件中其余 /usr/bin 用法（build*Env 系列测试）只断言 PATH 原样透传、不探测二进制，无此问题，未改动。