Skip to content

ensure ci/run_* scripts are actually used #269

@jameslamb

Description

@jameslamb

Description

In many RAPIDS repos, you'll see a layout similar to this:

$ tree -L 2 ci/
├── build_cpp.sh
├── build_docs.sh
├── build_python.sh
├── build_wheel_cuml.sh
├── build_wheel_libcuml.sh
├── build_wheel.sh
├── check_style.sh
├── release
│   └── update-version.sh
├── run_clang_tidy.sh
├── run_ctests.sh
├── run_cuml_dask_pytests.sh
├── run_cuml_integration_pytests.sh
├── run_cuml_singlegpu_accel_pytests.sh
├── run_cuml_singlegpu_pytests.sh
├── test_cpp.sh
├── test_notebooks.sh
├── test_python_common.sh
├── test_python_cuml_accel_upstream.sh
├── test_python_dask.sh
├── test_python_integration.sh
├── test_python_scikit_learn_tests.sh
├── test_python_singlegpu.sh
├── test_wheel_dask.sh
├── test_wheel_integrations.sh
├── test_wheel.sh
└── validate_wheel.sh

Those run_* scripts are intended to be limited to selecting and running tests.

The test-* scripts are intended to do other work like installing dependencies, downloading datasets, uploading coverage artifacts, etc. and should re-use the run_* scripts for actual test-running.

We've been inconsistent about this across RAPIDS... this issue tracks the work of auditing the repos and enforcing this convention.

Benefits of this work

Ensures the run_* scripts stay up to date with changes to the repos.

Those scripts are useful for other development using RAPIDS repos, like:

Acceptance Criteria

  • every RAPIDS repos follows this run_* vs. test_* convention, and test_* scripts invoke run_* scripts
  • run_* scripts do not use anything from https://github.com/rapidsai/gha-tools (not guaranteed to be present in all test environments)

Approach

Look through the repos one-by-one and enforce this.

Notes

Would be a good candidate to pair with #249

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions