-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathcrypt_test.go
More file actions
513 lines (419 loc) · 14.2 KB
/
crypt_test.go
File metadata and controls
513 lines (419 loc) · 14.2 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
package crypt
import (
"bytes"
"crypto/aes"
"crypto/cipher"
"crypto/rand"
"encoding/base64"
"encoding/json"
"errors"
"io"
"strings"
"testing"
)
func setTestAppKey(t *testing.T) {
t.Helper()
key, err := GenerateAppKey()
if err != nil {
t.Fatalf("GenerateAppKey failed: %v", err)
}
t.Setenv("APP_KEY", key)
}
func generateKeyPair(t *testing.T) ([]byte, string) {
t.Helper()
keyStr, err := GenerateAppKey()
if err != nil {
t.Fatalf("GenerateAppKey failed: %v", err)
}
key, err := ReadAppKey(keyStr)
if err != nil {
t.Fatalf("ReadAppKey failed: %v", err)
}
return key, keyStr
}
func generateKeyWithSize(t *testing.T, size int) (key []byte, keyStr string) {
t.Helper()
raw := make([]byte, size)
if _, err := rand.Read(raw); err != nil {
t.Fatalf("rand.Read failed: %v", err)
}
keyStr = "base64:" + base64.StdEncoding.EncodeToString(raw)
var err error
key, err = ReadAppKey(keyStr)
if err != nil {
t.Fatalf("ReadAppKey failed: %v", err)
}
return key, keyStr
}
func TestGenerateAndReadAppKey(t *testing.T) {
setTestAppKey(t)
key, err := GetAppKey()
if err != nil {
t.Fatalf("GetAppKey failed: %v", err)
}
if len(key) != 32 {
t.Errorf("Expected 32-byte key, got %d bytes", len(key))
}
}
func TestReadAppKeySupports128And256(t *testing.T) {
key128, key128Str := generateKeyWithSize(t, 16)
key256, key256Str := generateKeyWithSize(t, 32)
if len(key128) != 16 {
t.Fatalf("Expected 16 bytes, got %d", len(key128))
}
if len(key256) != 32 {
t.Fatalf("Expected 32 bytes, got %d", len(key256))
}
parsed128, err := ReadAppKey(key128Str)
if err != nil {
t.Fatalf("ReadAppKey failed for 128-bit key: %v", err)
}
if len(parsed128) != 16 {
t.Fatalf("Parsed key should be 16 bytes")
}
parsed256, err := ReadAppKey(key256Str)
if err != nil {
t.Fatalf("ReadAppKey failed for 256-bit key: %v", err)
}
if len(parsed256) != 32 {
t.Fatalf("Parsed key should be 32 bytes")
}
if _, err := ReadAppKey("base64:" + base64.StdEncoding.EncodeToString(make([]byte, 24))); err == nil {
t.Fatalf("Expected error for 24-byte key but got none")
}
}
func TestReadAppKeyErrorsOnPrefix(t *testing.T) {
if _, err := ReadAppKey("invalidprefix"); err == nil {
t.Fatalf("Expected prefix error")
}
}
func TestReadAppKeyBase64Error(t *testing.T) {
if _, err := ReadAppKey("base64:not-valid"); err == nil {
t.Fatalf("expected base64 decode error")
}
}
func TestReadAppKeyInvalidKeySize(t *testing.T) {
raw := base64.StdEncoding.EncodeToString(make([]byte, 8))
if _, err := ReadAppKey("base64:" + raw); err == nil {
t.Fatalf("expected invalid size error")
}
}
func TestEncryptAndDecrypt(t *testing.T) {
setTestAppKey(t)
plaintext := "This is a secret message."
encrypted, err := Encrypt(plaintext)
if err != nil {
t.Fatalf("Encrypt failed: %v", err)
}
if encrypted == "" {
t.Fatal("Encrypted result is empty")
}
decrypted, err := Decrypt(encrypted)
if err != nil {
t.Fatalf("Decrypt failed: %v", err)
}
if decrypted != plaintext {
t.Errorf("Expected decrypted to equal original. Got: %s", decrypted)
}
}
func TestDecryptTamperedPayloadFails(t *testing.T) {
setTestAppKey(t)
plaintext := "safe data"
encrypted, err := Encrypt(plaintext)
if err != nil {
t.Fatalf("Encrypt failed: %v", err)
}
jsonRaw, err := base64.StdEncoding.DecodeString(encrypted)
if err != nil {
t.Fatalf("base64 decode failed: %v", err)
}
var payload EncryptedPayload
if err := json.Unmarshal(jsonRaw, &payload); err != nil {
t.Fatalf("json unmarshal failed: %v", err)
}
macBytes, err := base64.StdEncoding.DecodeString(payload.MAC)
if err != nil {
t.Fatalf("mac decode failed: %v", err)
}
macBytes[0] ^= 0xFF
payload.MAC = base64.StdEncoding.EncodeToString(macBytes)
modifiedJSON, err := json.Marshal(payload)
if err != nil {
t.Fatalf("json marshal failed: %v", err)
}
tampered := base64.StdEncoding.EncodeToString(modifiedJSON)
_, err = Decrypt(tampered)
if err == nil || !strings.Contains(err.Error(), "HMAC validation failed") {
t.Errorf("Expected HMAC validation to fail, got: %v", err)
}
}
func TestDecryptBase64DecodeError(t *testing.T) {
setTestAppKey(t)
if _, err := Decrypt("!not-base64"); err == nil || !strings.Contains(err.Error(), "base64 decode failed") {
t.Fatalf("expected base64 error, got %v", err)
}
}
func TestDecryptMissingAppKey(t *testing.T) {
t.Setenv("APP_KEY", "")
if _, err := Decrypt("anything"); err == nil {
t.Fatalf("expected error when APP_KEY missing")
}
}
func TestDecryptFallsBackToPreviousKey(t *testing.T) {
currentKey, currentKeyStr := generateKeyPair(t)
previousKey, previousKeyStr := generateKeyPair(t)
t.Setenv("APP_KEY", currentKeyStr)
t.Setenv("APP_PREVIOUS_KEYS", previousKeyStr)
oldCiphertext, err := encryptWithKey(previousKey, "rotated secret")
if err != nil {
t.Fatalf("encryptWithKey failed: %v", err)
}
decrypted, err := Decrypt(oldCiphertext)
if err != nil {
t.Fatalf("Decrypt failed with previous key: %v", err)
}
if decrypted != "rotated secret" {
t.Fatalf("Expected decrypted text to match, got %q", decrypted)
}
newCiphertext, err := Encrypt("fresh secret")
if err != nil {
t.Fatalf("Encrypt failed: %v", err)
}
if _, err := decryptWithKey(previousKey, newCiphertext); err == nil {
t.Fatalf("Expected decryption with previous key to fail for newly encrypted payload")
}
if decryptedCurrent, err := decryptWithKey(currentKey, newCiphertext); err != nil || decryptedCurrent != "fresh secret" {
t.Fatalf("Decrypt with current key failed, got value %q and err %v", decryptedCurrent, err)
}
}
func TestDecryptFailsWhenNoKeysMatch(t *testing.T) {
_, currentKeyStr := generateKeyPair(t)
wrongKey, _ := generateKeyPair(t)
t.Setenv("APP_KEY", currentKeyStr)
t.Setenv("APP_PREVIOUS_KEYS", "")
ciphertext, err := encryptWithKey(wrongKey, "unrecoverable")
if err != nil {
t.Fatalf("encryptWithKey failed: %v", err)
}
if _, err := Decrypt(ciphertext); err == nil {
t.Fatal("Expected decrypt to fail when no keys match")
}
ciphertext, err = Encrypt("recoverable")
if err != nil {
t.Fatalf("Encrypt failed: %v", err)
}
if decrypted, err := Decrypt(ciphertext); err != nil || decrypted != "recoverable" {
t.Fatalf("Decrypt with current key failed, got %q and err %v", decrypted, err)
}
}
func TestDecryptFailsOnInvalidJson(t *testing.T) {
_, keyStr := generateKeyPair(t)
t.Setenv("APP_KEY", keyStr)
badJSON := base64.StdEncoding.EncodeToString([]byte("{"))
if _, err := Decrypt(badJSON); err == nil || !strings.Contains(err.Error(), "json decode failed") {
t.Fatalf("expected json decode error, got %v", err)
}
}
func TestDecryptErrorsOnDecodeFailures(t *testing.T) {
_, keyStr := generateKeyPair(t)
t.Setenv("APP_KEY", keyStr)
buildPayload := func(iv, val, mac string) string {
p := EncryptedPayload{IV: iv, Value: val, MAC: mac}
b, _ := json.Marshal(p)
return base64.StdEncoding.EncodeToString(b)
}
// iv decode error
if _, err := Decrypt(buildPayload("?", "dmFsdWU=", "bWFj")); err == nil || !strings.Contains(err.Error(), "iv decode failed") {
t.Fatalf("expected iv decode failure")
}
// value decode error
if _, err := Decrypt(buildPayload(base64.StdEncoding.EncodeToString(make([]byte, aes.BlockSize)), "?", "bWFj")); err == nil || !strings.Contains(err.Error(), "value decode failed") {
t.Fatalf("expected value decode failure")
}
// mac decode error
if _, err := Decrypt(buildPayload(base64.StdEncoding.EncodeToString(make([]byte, aes.BlockSize)), base64.StdEncoding.EncodeToString(make([]byte, aes.BlockSize)), "?")); err == nil || !strings.Contains(err.Error(), "mac decode failed") {
t.Fatalf("expected mac decode failure")
}
}
func TestDecryptErrorsOnBlockSize(t *testing.T) {
key, keyStr := generateKeyPair(t)
t.Setenv("APP_KEY", keyStr)
iv := base64.StdEncoding.EncodeToString(make([]byte, aes.BlockSize))
val := base64.StdEncoding.EncodeToString([]byte{1, 2, 3}) // not multiple of block size
mac := base64.StdEncoding.EncodeToString(computeHMACSHA256(append(make([]byte, aes.BlockSize), []byte{1, 2, 3}...), key))
payload := EncryptedPayload{IV: iv, Value: val, MAC: mac}
raw, _ := json.Marshal(payload)
enc := base64.StdEncoding.EncodeToString(raw)
if _, err := Decrypt(enc); err == nil || !strings.Contains(err.Error(), "multiple of the block size") {
t.Fatalf("expected block size error, got %v", err)
}
}
func TestEncryptFailsWithoutAppKey(t *testing.T) {
t.Setenv("APP_KEY", "")
if _, err := Encrypt("secret"); err == nil {
t.Fatalf("expected error when APP_KEY missing")
}
}
func TestGetAppKeyErrorWhenMissing(t *testing.T) {
t.Setenv("APP_KEY", "")
if _, err := GetAppKey(); err == nil {
t.Fatalf("expected error when APP_KEY missing")
}
}
func TestEncryptWithKeyInvalidSize(t *testing.T) {
if _, err := encryptWithKey([]byte{1, 2, 3}, "data"); err == nil {
t.Fatalf("expected invalid key size error")
}
}
func TestEncryptWithKeyRandError(t *testing.T) {
key, _ := generateKeyPair(t)
orig := rand.Reader
rand.Reader = failingReader{}
defer func() { rand.Reader = orig }()
if _, err := encryptWithKey(key, "data"); err == nil {
t.Fatalf("expected rand failure")
}
}
func TestDecryptFailsOnInvalidPreviousKeys(t *testing.T) {
_, currentKeyStr := generateKeyPair(t)
t.Setenv("APP_KEY", currentKeyStr)
t.Setenv("APP_PREVIOUS_KEYS", "invalid-key")
ciphertext, err := Encrypt("data")
if err != nil {
t.Fatalf("Encrypt failed: %v", err)
}
if _, err := Decrypt(ciphertext); err == nil || !strings.Contains(err.Error(), "failed to parse APP_PREVIOUS_KEYS") {
t.Fatalf("Expected parse error for previous keys, got %v", err)
}
}
func TestGetPreviousAppKeysTrimsWhitespaceAndSkipsEmpty(t *testing.T) {
firstKey, firstKeyStr := generateKeyPair(t)
secondKey, secondKeyStr := generateKeyPair(t)
t.Setenv("APP_PREVIOUS_KEYS", " "+firstKeyStr+" , , "+secondKeyStr+" , ")
keys, err := GetPreviousAppKeys()
if err != nil {
t.Fatalf("GetPreviousAppKeys failed: %v", err)
}
if len(keys) != 2 {
t.Fatalf("Expected 2 keys, got %d", len(keys))
}
if !bytes.Equal(keys[0], firstKey) || !bytes.Equal(keys[1], secondKey) {
t.Fatalf("Keys did not match input order")
}
}
func TestDecryptWithMixedKeyLengths(t *testing.T) {
currentKey, currentKeyStr := generateKeyWithSize(t, 32)
previousKey, previousKeyStr := generateKeyWithSize(t, 16)
t.Setenv("APP_KEY", currentKeyStr)
t.Setenv("APP_PREVIOUS_KEYS", previousKeyStr)
ciphertext, err := encryptWithKey(previousKey, "legacy aes-128")
if err != nil {
t.Fatalf("encryptWithKey failed: %v", err)
}
plaintext, err := Decrypt(ciphertext)
if err != nil {
t.Fatalf("Decrypt failed: %v", err)
}
if plaintext != "legacy aes-128" {
t.Fatalf("Expected plaintext to match, got %q", plaintext)
}
ciphertext, err = Encrypt("current aes-256")
if err != nil {
t.Fatalf("Encrypt failed: %v", err)
}
plaintext, err = decryptWithKey(currentKey, ciphertext)
if err != nil || plaintext != "current aes-256" {
t.Fatalf("Expected decrypt with current key to succeed; got plaintext %q, err %v", plaintext, err)
}
if _, err := decryptWithKey(previousKey, ciphertext); err == nil {
t.Fatalf("Expected previous AES-128 key to fail decrypting AES-256 ciphertext")
}
}
func TestPkcs7UnpadErrors(t *testing.T) {
if _, err := pkcs7Unpad([]byte{}); err == nil {
t.Fatalf("expected error on empty input")
}
if _, err := pkcs7Unpad([]byte{1, 2, 0}); err == nil {
t.Fatalf("expected error on zero padding")
}
if _, err := pkcs7Unpad([]byte{1, 2, 3, 2}); err == nil {
t.Fatalf("expected error on invalid pattern")
}
}
type failingReader struct{}
func (f failingReader) Read(p []byte) (int, error) {
return 0, io.ErrUnexpectedEOF
}
func TestGenerateAppKeyRandError(t *testing.T) {
orig := rand.Reader
rand.Reader = failingReader{}
defer func() { rand.Reader = orig }()
if _, err := GenerateAppKey(); err == nil {
t.Fatalf("expected error when rand fails")
}
}
func TestDecryptWithKeyBase64Failure(t *testing.T) {
if _, err := decryptWithKey(make([]byte, 16), "???"); err == nil || !strings.Contains(err.Error(), "base64 decode failed") {
t.Fatalf("expected base64 decode failure")
}
}
func TestDecryptWithKeyPaddingError(t *testing.T) {
key, keyStr := generateKeyPair(t)
t.Setenv("APP_KEY", keyStr)
iv := make([]byte, aes.BlockSize)
plaintext := make([]byte, aes.BlockSize)
plaintext[len(plaintext)-1] = 0 // invalid padding byte
block, err := aes.NewCipher(key)
if err != nil {
t.Fatalf("cipher init: %v", err)
}
ct := make([]byte, len(plaintext))
mode := cipher.NewCBCEncrypter(block, iv)
mode.CryptBlocks(ct, plaintext)
payload := EncryptedPayload{
IV: base64.StdEncoding.EncodeToString(iv),
Value: base64.StdEncoding.EncodeToString(ct),
MAC: base64.StdEncoding.EncodeToString(computeHMACSHA256(append(iv, ct...), key)),
}
raw, _ := json.Marshal(payload)
enc := base64.StdEncoding.EncodeToString(raw)
if _, err := decryptWithKey(key, enc); err == nil || !strings.Contains(err.Error(), "invalid padding") {
t.Fatalf("expected padding error, got %v", err)
}
}
func TestDecryptWithKeyInvalidKeySize(t *testing.T) {
_, keyStr := generateKeyPair(t)
t.Setenv("APP_KEY", keyStr)
ciphertext, err := Encrypt("data")
if err != nil {
t.Fatalf("Encrypt failed: %v", err)
}
// 17-byte key
badKey := make([]byte, 17)
// rebuild payload with MAC generated from the bad key so HMAC passes and cipher init fails
raw, _ := base64.StdEncoding.DecodeString(ciphertext)
var payload EncryptedPayload
_ = json.Unmarshal(raw, &payload)
ivBytes, _ := base64.StdEncoding.DecodeString(payload.IV)
ctBytes, _ := base64.StdEncoding.DecodeString(payload.Value)
payload.MAC = base64.StdEncoding.EncodeToString(computeHMACSHA256(append(ivBytes, ctBytes...), badKey))
modified, _ := json.Marshal(payload)
enc := base64.StdEncoding.EncodeToString(modified)
if _, err := decryptWithKey(badKey, enc); err == nil || !strings.Contains(err.Error(), "invalid key size") {
t.Fatalf("expected invalid key size error, got %v", err)
}
}
func TestEncryptMarshalError(t *testing.T) {
orig := jsonMarshal
defer func() { jsonMarshal = orig }()
jsonMarshal = func(v any) ([]byte, error) {
return nil, errors.New("marshal boom")
}
key, _ := generateKeyPair(t)
if _, err := encryptWithKey(key, "data"); err == nil || !strings.Contains(err.Error(), "marshal boom") {
t.Fatalf("expected marshal error, got %v", err)
}
}
func TestDumpExample(t *testing.T) {
dumpExample("a", 1)
}