Fix SonarQube MINOR issues in the global-header workspace

[christoph-jerolimov]

Fix the following issues in the global-header workspace:

Rule	Message	File
javascript:S7726	The arrow function should be named.	workspaces/global-header/eslint.frontend-shared.cjs:39

[fullsend-ai-triage]

🤖 Finished Triage · ✅ Success · Started 7:59 PM UTC · Completed 8:01 PM UTC
Commit: 82225ba · View workflow run →

[fullsend-ai-triage]

Triage Summary

Severity: Low · Category: Code quality (SonarQube)

Problem

SonarQube rule javascript:S7726 flags the anonymous arrow function on line 39 of workspaces/global-header/eslint.frontend-shared.cjs. The current code exports an unnamed arrow function, which makes stack traces less readable.

Root Cause

The module export uses an anonymous arrow function:

module.exports = packageDir =>
  require('@backstage/cli/config/eslint-factory')(
    packageDir,
    materialUiMigrationEslintConfig,
  );

Recommended Fix

Assign the arrow function to a named variable before exporting:

const createEslintConfig = packageDir =>
  require('@backstage/cli/config/eslint-factory')(
    packageDir,
    materialUiMigrationEslintConfig,
  );

module.exports = createEslintConfig;

Proposed Test Case

1. Import the module and call it with a valid packageDir path.
2. Confirm it returns the expected ESLint configuration object (same as before the change).
3. Re-run SonarQube analysis to verify rule S7726 no longer triggers.

This is a minimal, low-risk change suitable for a quick fix.

---

Labels: Issue targets the global-header workspace and is a minor lint fix suitable for newcomers.

[christoph-jerolimov]

/fs-code

[fullsend-ai-coder]

🤖 Finished Code · ✅ Success · Started 10:45 PM UTC · Completed 10:57 PM UTC
Commit: 0634d54 · View workflow run →