setting coordinatesyes == 3 causes segfault

[lyguy]

When last two lines of input.dat are:

%******* 18.) OUTPUT STAKES **************************************
3     %1=stake locations given in local coordinates (x,y), 2=as 1 but center, 3=row/col  coordinatesyes
   102 125

degree.o exits with

segmentation fault 11.

We find with gbd that:

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_INVALID_ADDRESS at address: 0x018b1c70
0x00012028 in startoutascii () at initial.c:990
990 fprintf(outgrid[i],"%s elevation = %5.0f m slope = %5.1f aspect = %5.1f",
(gdb) p stnrow[i]
$1 = 537687
(gdb) p stncol[i]
$2 = 6473500
(gdb) p griddgm[stnrow[i]][stncol[i]]
Cannot access memory at address 0x18b1c70

Looks like strnrow and strncol are being assigned incorrect values somewhere.

Compare:
input.dat:

%******* 18.) OUTPUT STAKES **************************************
1     %1=stake locations given in local coordinates (x,y), 2=as 1 but center, 3=row/col  coordinatesyes
   537687 6473500

Breakpoint 1, startoutascii () at initial.c:990
990 fprintf(outgrid[i],"%s elevation = %5.0f m slope = %5.1f aspect = %5.1f",
(gdb) p stncol[i]
$1 = 101
(gdb) p stnrow[i]
$2 = 80

[lyguy]

Regine pointed out that these are the values for outgridnumber in input.dat.
Converting those to row x column works to fix the problem in runtime.
An error should be put into the parser to prevent this from happening.

[lyguy]

Consider 7e50c42.
This change should get merged into dev.

[lyguy]

Merged into dev here 5ae0df8.

[lyguy]

5ae0df8 initializes the values, but doesn't fix the underlying cause: out-of-bounds indices.
The seg fault now occurs in writeout.c:writemeltstakes() when the melt at the stakes is accessed.

Add a check to input.c to fix this.