Skip to content

Redesign flow.Sink interface #14

@andrewhare

Description

@andrewhare

Currently, flow.Sink is just an io.WriteCloser which is convenient but not ideal for a lot of use cases because the Close method doesn't accept a context.Context.

Most sinks (GCS and S3Compat come to mind) write their contents when they are closed but we have no way of signaling/canceling these operations.

Do we want to:

  • Make our own interface that accepts a context on close?
  • Redesign the sinks to not write their data on close?
  • Something else I haven't thought of?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions