From cd0d07f88ca1dbfa4f0b036ae7dffad789891ad4 Mon Sep 17 00:00:00 2001 From: "Rick Farina (Zero_Chaos)" Date: Thu, 23 Jul 2026 19:48:29 -0400 Subject: [PATCH 1/5] update ci so wav-format-check passes When a required check is conditional and the conditional is not met it blocks the ci pipeline. Converting this check to always run but bail out successfully quickly if there are no changes. --- .github/workflows/wav-format-check.yaml | 15 ++++++++++++--- qa/wav-format-check | 2 ++ 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/.github/workflows/wav-format-check.yaml b/.github/workflows/wav-format-check.yaml index 15f1cd2..7692bd9 100644 --- a/.github/workflows/wav-format-check.yaml +++ b/.github/workflows/wav-format-check.yaml @@ -4,8 +4,7 @@ on: pull_request: branches: - master - paths: - - 'flags-archive/**' + jobs: wav-format-check: runs-on: ubuntu-latest @@ -20,5 +19,15 @@ jobs: - name: WAV format check run: | + # Capture the modified files matching the directory path + CHANGED_FILES=$(git diff-tree --no-commit-id --name-only -r ${{ github.sha }} | grep -E '^(flags-archive/)') + + # If the variable is empty, skip execution and pass cleanly + if [ -z "$CHANGED_FILES" ]; then + echo "No files modified in flags-archive/. Skipping validation check." + exit 0 + fi + + # Otherwise, proceed with the original installation and test suite sudo apt-get install --no-install-recommends libimage-exiftool-perl -y - ./qa/wav-format-check $(git diff-tree --no-commit-id --name-only -r ${{ github.sha }} | grep -E '^(flags-archive/)') + ./qa/wav-format-check $CHANGED_FILES diff --git a/qa/wav-format-check b/qa/wav-format-check index 0c58e4a..6b562a8 100755 --- a/qa/wav-format-check +++ b/qa/wav-format-check @@ -1,5 +1,7 @@ #!/bin/bash +## This tests all the wav files in flags-archive/ + if [ ! -x "$(command -v exiftool 2>&1)" ]; then printf 'Please install exiftool\n' exit 1 From 630717e84eb66618f95c9e18397240f2418ac036 Mon Sep 17 00:00:00 2001 From: "Rick Farina (Zero_Chaos)" Date: Thu, 23 Jul 2026 19:51:10 -0400 Subject: [PATCH 2/5] remove comments --- .github/workflows/wav-format-check.yaml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/wav-format-check.yaml b/.github/workflows/wav-format-check.yaml index 7692bd9..19eca10 100644 --- a/.github/workflows/wav-format-check.yaml +++ b/.github/workflows/wav-format-check.yaml @@ -19,15 +19,12 @@ jobs: - name: WAV format check run: | - # Capture the modified files matching the directory path CHANGED_FILES=$(git diff-tree --no-commit-id --name-only -r ${{ github.sha }} | grep -E '^(flags-archive/)') - # If the variable is empty, skip execution and pass cleanly if [ -z "$CHANGED_FILES" ]; then echo "No files modified in flags-archive/. Skipping validation check." exit 0 fi - # Otherwise, proceed with the original installation and test suite sudo apt-get install --no-install-recommends libimage-exiftool-perl -y ./qa/wav-format-check $CHANGED_FILES From 913d0590140e55f921fe5ad3a5bb8d51364909cd Mon Sep 17 00:00:00 2001 From: "Rick Farina (Zero_Chaos)" Date: Thu, 23 Jul 2026 19:52:39 -0400 Subject: [PATCH 3/5] no newlines? --- .github/workflows/wav-format-check.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/wav-format-check.yaml b/.github/workflows/wav-format-check.yaml index 19eca10..bc87777 100644 --- a/.github/workflows/wav-format-check.yaml +++ b/.github/workflows/wav-format-check.yaml @@ -20,11 +20,9 @@ jobs: - name: WAV format check run: | CHANGED_FILES=$(git diff-tree --no-commit-id --name-only -r ${{ github.sha }} | grep -E '^(flags-archive/)') - if [ -z "$CHANGED_FILES" ]; then echo "No files modified in flags-archive/. Skipping validation check." exit 0 fi - sudo apt-get install --no-install-recommends libimage-exiftool-perl -y ./qa/wav-format-check $CHANGED_FILES From baade2befeb36ce989cd5080fb6686aebdd18f72 Mon Sep 17 00:00:00 2001 From: "Rick Farina (Zero_Chaos)" Date: Thu, 23 Jul 2026 19:56:43 -0400 Subject: [PATCH 4/5] why don't you work --- .github/workflows/wav-format-check.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/wav-format-check.yaml b/.github/workflows/wav-format-check.yaml index bc87777..f2fccb0 100644 --- a/.github/workflows/wav-format-check.yaml +++ b/.github/workflows/wav-format-check.yaml @@ -19,8 +19,8 @@ jobs: - name: WAV format check run: | - CHANGED_FILES=$(git diff-tree --no-commit-id --name-only -r ${{ github.sha }} | grep -E '^(flags-archive/)') - if [ -z "$CHANGED_FILES" ]; then + CHANGED_FILES="$(git diff-tree --no-commit-id --name-only -r ${{ github.sha }} | grep -E '^(flags-archive/)')" + if [ -z "${CHANGED_FILES}" ]; then echo "No files modified in flags-archive/. Skipping validation check." exit 0 fi From ba9ac5b8092475d8b178664c2e1e9aa1d4eb62d1 Mon Sep 17 00:00:00 2001 From: "Rick Farina (Zero_Chaos)" Date: Thu, 23 Jul 2026 20:08:06 -0400 Subject: [PATCH 5/5] be true to yourself --- .github/workflows/wav-format-check.yaml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/wav-format-check.yaml b/.github/workflows/wav-format-check.yaml index f2fccb0..b67bcbc 100644 --- a/.github/workflows/wav-format-check.yaml +++ b/.github/workflows/wav-format-check.yaml @@ -19,10 +19,15 @@ jobs: - name: WAV format check run: | - CHANGED_FILES="$(git diff-tree --no-commit-id --name-only -r ${{ github.sha }} | grep -E '^(flags-archive/)')" + CHANGED_FILES="$(git diff --name-only origin/${{ github.base_ref }}...origin/${{ github.head_ref }} | grep -E '^(flags-archive/)' || true)" + if [ -z "${CHANGED_FILES}" ]; then echo "No files modified in flags-archive/. Skipping validation check." exit 0 fi + + echo "Files to check:" + echo "${CHANGED_FILES}" + sudo apt-get install --no-install-recommends libimage-exiftool-perl -y ./qa/wav-format-check $CHANGED_FILES