checkWatch networkReadMillis < cacheWatchSeconds ?

[ecolinet]

Hi,

I don't understand why the networkReadTimeout is enforced to be higher than the cacheWatch value. Shouldn't it be the opposite ?

consul-client/src/main/java/com/orbitz/consul/cache/ConsulCache.java

Lines 411 to 416 in b0c56fc

	protected static void checkWatch(int networkReadMillis, int cacheWatchSeconds) {
	if (networkReadMillis <= TimeUnit.SECONDS.toMillis(cacheWatchSeconds)) {
	throw new IllegalArgumentException("Cache watchInterval="+ cacheWatchSeconds + "sec >= networkClientReadTimeout="
	+ networkReadMillis + "ms. It can cause issues");
	}
	}

Thanks,
Eric

[ElfoLiNk]

I think #453 will address this