From 17b0864c00d57333528fb9f03166eb88f479c15e Mon Sep 17 00:00:00 2001 From: Robert Bogos Date: Thu, 30 Jan 2025 10:06:34 +0200 Subject: [PATCH 1/2] test-code-cov --- libs/blocks/section-metadata/sticky-section.js | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/libs/blocks/section-metadata/sticky-section.js b/libs/blocks/section-metadata/sticky-section.js index 9ffe20953cf..663bb23857a 100644 --- a/libs/blocks/section-metadata/sticky-section.js +++ b/libs/blocks/section-metadata/sticky-section.js @@ -25,11 +25,19 @@ function promoIntersectObserve(el, stickySectionEl, options = {}) { } const abovePromoStart = (entry.target === stickySectionEl && entry.isIntersecting) - || stickySectionEl?.getBoundingClientRect().y > 0; + || stickySectionEl?.getBoundingClientRect().y > 0; if (entry.target === document.querySelector('footer')) { - el.classList.toggle('fill-sticky-section', entry.isIntersecting); - } else el.classList.toggle('hide-sticky-section', abovePromoStart); + if (entry.isIntersecting) { + el.classList.add('fill-sticky-section'); + } else { + el.classList.remove('fill-sticky-section'); + } + } else if (abovePromoStart) { + el.classList.remove('hide-sticky-section'); + } else { + el.classList.add('hide-sticky-section'); + } }); }, options); return io; From 0a3e245cd6ec9bb2d2cf55db6a4ef53b9b300b0f Mon Sep 17 00:00:00 2001 From: Robert Bogos Date: Thu, 30 Jan 2025 10:18:33 +0200 Subject: [PATCH 2/2] added not covered line --- .../blocks/section-metadata/sticky-section.js | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/libs/blocks/section-metadata/sticky-section.js b/libs/blocks/section-metadata/sticky-section.js index 663bb23857a..3346c8e407e 100644 --- a/libs/blocks/section-metadata/sticky-section.js +++ b/libs/blocks/section-metadata/sticky-section.js @@ -24,20 +24,17 @@ function promoIntersectObserve(el, stickySectionEl, options = {}) { return; } + // Unlikely condition for code coverage + if (el.classList.contains('unlikely-class-name')) { + el.classList.add('unlikely-class-name'); + } + const abovePromoStart = (entry.target === stickySectionEl && entry.isIntersecting) - || stickySectionEl?.getBoundingClientRect().y > 0; + || stickySectionEl?.getBoundingClientRect().y > 0; if (entry.target === document.querySelector('footer')) { - if (entry.isIntersecting) { - el.classList.add('fill-sticky-section'); - } else { - el.classList.remove('fill-sticky-section'); - } - } else if (abovePromoStart) { - el.classList.remove('hide-sticky-section'); - } else { - el.classList.add('hide-sticky-section'); - } + el.classList.toggle('fill-sticky-section', entry.isIntersecting); + } else el.classList.toggle('hide-sticky-section', abovePromoStart); }); }, options); return io;