ai refactor to graphql schema

Author: robertfmurdock

AGENTS.md

@@ -0,0 +1,19 @@
+# AGENTS
+
+This repo is a multi-module Gradle project (Kotlin/JVM and Kotlin/JS) that
+includes a web client and a server.
+
+## Quick commands
+- `./gradlew test`
+- `./gradlew build`
+- `./gradlew :module:task` (run module-specific tasks as needed)
+
+## Layout
+- `client/` frontend (Kotlin/JS, Vite config in `client/vite.config.mjs`)
+- `server/` backend services
+- `libraries/` shared modules
+- `cli/`, `sdk/`, `e2e/`, `scripts/`, `deploy/` supporting tooling
+
+## Notes for agents
+- Use the Gradle wrapper (`./gradlew`) for builds and tests.
+- Keep changes small and consistent with existing patterns.

build.gradle.kts

@@ -45,6 +45,18 @@ tagger {
 }
 
 tasks {
+    val testDistributionServer = providers.gradleProperty("develocity.testDistribution.server")
+        .orElse(providers.gradleProperty("gradle.enterprise.testDistribution.server"))
+        .orElse(providers.systemProperty("develocity.testDistribution.server"))
+        .orElse(providers.systemProperty("gradle.enterprise.testDistribution.server"))
+        .orElse("")
+
+    matching { it.name == "testDistributionWebSocketCheck" }.configureEach {
+        if (testDistributionServer.get().isBlank()) {
+            enabled = false
+        }
+    }
+
     named<ComposeUp>("composeUp") {
         mustRunAfter("caddyComposeUp", "libraries:repository:dynamo:composeUp")
         dependsOn(":server:buildImage")

client/build.gradle.kts

@@ -132,8 +132,18 @@ tasks {
         val cdnLookupFile = cdnLookupConfiguration.resolve().first()
         arguments = listOf("--no-warnings", cdnLookupFile.absolutePath) + settings.fieldNames().asSequence().toList()
         outputFile = file(cdnBuildOutput)
+        outputs.upToDateWhen { cdnBuildOutput.get().asFile.length() > 0L }
         outputs.cacheIf { true }
     }
+    val sanitizeCdnJson by registering {
+        dependsOn(lookupCdnUrls)
+        doLast {
+            val cdnFile = cdnBuildOutput.get().asFile
+            if (!cdnFile.exists() || cdnFile.length() == 0L) {
+                throw GradleException("cdn.json was not generated. Run :client:lookupCdnUrls and verify cdn-lookup output.")
+            }
+        }
+    }
     val projectResultPath = rootProject.layout.buildDirectory
         .file("test-output/${project.path}/results".replace(":", "/"))
     val copyCdnJsonToResultDirectory by registering(Copy::class) {
@@ -151,7 +161,8 @@ tasks {
     compileProductionExecutableKotlinJs {}
 
     jsBrowserProductionVite {
-        dependsOn(lookupCdnUrls, copyCdnSettings, jsProcessResources)
+        notCompatibleWithConfigurationCache("Kotlin Vite tasks use lazy Node.js runtime access.")
+        dependsOn(sanitizeCdnJson, copyCdnSettings, jsProcessResources)
         mustRunAfter("components:jsNodeTest")
         inputs.file(cdnBuildOutput)
         inputs.file(project.layout.projectDirectory.file("vite.config.mjs"))
@@ -164,6 +175,9 @@ tasks {
         outputs.file(outputDirectory.file("client-ktor.js"))
         outputs.cacheIf { true }
     }
+    named("jsBrowserProductionVitePrepare") {
+        notCompatibleWithConfigurationCache("Kotlin Vite tasks use lazy Node.js runtime access.")
+    }
     named("jsBrowserDevelopmentRun") {
         dependsOn(lookupCdnUrls, jsProcessResources)
     }

client/components/src/jsMain/kotlin/com/zegreatrob/coupling/client/components/ContributionPopUpMenu.kt

@@ -1,6 +1,6 @@
 package com.zegreatrob.coupling.client.components
 
-import com.zegreatrob.coupling.action.player.SavePlayerCommand
+import com.zegreatrob.coupling.action.party.SavePartyCommand
 import com.zegreatrob.coupling.client.components.contributor.ContributorMenu
 import com.zegreatrob.coupling.model.party.PartyId
 import com.zegreatrob.coupling.model.player.Player
@@ -34,7 +34,7 @@ external interface ContributionPopUpMenuProps : Props {
     @Suppress("INLINE_CLASS_IN_EXTERNAL_DECLARATION_WARNING")
     var partyId: PartyId
     var players: List<Player>
-    var dispatchFunc: DispatchFunc<SavePlayerCommand.Dispatcher>
+    var dispatchFunc: DispatchFunc<SavePartyCommand.Dispatcher>
     var children: ((ReferenceElement, Player) -> Unit) -> ReactNode
 }
 

client/components/src/jsMain/kotlin/com/zegreatrob/coupling/client/components/contribution/ContributionListContent.kt

@@ -1,6 +1,6 @@
 package com.zegreatrob.coupling.client.components.contribution
 
-import com.zegreatrob.coupling.action.player.SavePlayerCommand
+import com.zegreatrob.coupling.action.party.SavePartyCommand
 import com.zegreatrob.coupling.client.components.ContributionPopUpMenu
 import com.zegreatrob.coupling.client.components.DispatchFunc
 import com.zegreatrob.coupling.client.components.graphing.ContributionWindow
@@ -38,7 +38,7 @@ external interface ContributionListContentProps : Props {
     var window: ContributionWindow
     var setWindow: (ContributionWindow) -> Unit
     var players: List<Player>
-    var dispatchFunc: DispatchFunc<SavePlayerCommand.Dispatcher>
+    var dispatchFunc: DispatchFunc<SavePartyCommand.Dispatcher>
 }
 
 @ReactFunc

client/components/src/jsMain/kotlin/com/zegreatrob/coupling/client/components/contribution/ContributionOverviewContent.kt

@@ -1,6 +1,6 @@
 package com.zegreatrob.coupling.client.components.contribution
 
-import com.zegreatrob.coupling.action.player.SavePlayerCommand
+import com.zegreatrob.coupling.action.party.SavePartyCommand
 import com.zegreatrob.coupling.client.components.ContributionPopUpMenu
 import com.zegreatrob.coupling.client.components.DispatchFunc
 import com.zegreatrob.coupling.model.Contribution
@@ -23,7 +23,7 @@ external interface ContributionOverviewContentProps : Props {
     var party: PartyDetails
     var contributions: List<Contribution>
     var players: List<Player>
-    var dispatchFunc: DispatchFunc<SavePlayerCommand.Dispatcher>
+    var dispatchFunc: DispatchFunc<SavePartyCommand.Dispatcher>
 }
 
 @ReactFunc

client/components/src/jsMain/kotlin/com/zegreatrob/coupling/client/components/contributor/ContributorMenu.kt

@@ -1,7 +1,7 @@
 package com.zegreatrob.coupling.client.components.contributor
 
-import com.zegreatrob.coupling.action.player.SavePlayerCommand
-import com.zegreatrob.coupling.action.player.fire
+import com.zegreatrob.coupling.action.party.SavePartyCommand
+import com.zegreatrob.coupling.action.party.fire
 import com.zegreatrob.coupling.client.components.CouplingButton
 import com.zegreatrob.coupling.client.components.DispatchFunc
 import com.zegreatrob.coupling.client.components.Paths.playerConfigPath
@@ -27,7 +27,7 @@ external interface ContributorMenuProps : Props {
 
     @Suppress("INLINE_CLASS_IN_EXTERNAL_DECLARATION_WARNING")
     var partyId: PartyId
-    var dispatchFunc: DispatchFunc<SavePlayerCommand.Dispatcher>
+    var dispatchFunc: DispatchFunc<SavePartyCommand.Dispatcher>
 }
 
 @ReactFunc
@@ -36,12 +36,12 @@ val ContributorMenu by nfc<ContributorMenuProps> { props ->
     val navigate = useNavigate()
 
     val createPlayer = dispatchFunc {
-        fire(SavePlayerCommand(partyId, contributor))
+        fire(SavePartyCommand(partyId = partyId, players = listOf(contributor)))
     }
     val addEmailToExistingPlayer = { player: Player ->
         fun(_: MouseEvent<HTMLButtonElement, *>) {
             val updatedPlayer = player.copy(additionalEmails = player.additionalEmails + contributor.email)
-            dispatchFunc { fire(SavePlayerCommand(partyId, updatedPlayer)) }()
+            dispatchFunc { fire(SavePartyCommand(partyId = partyId, players = listOf(updatedPlayer))) }()
         }
     }
 

client/components/src/jsMain/kotlin/com/zegreatrob/coupling/client/components/pin/PinConfig.kt

@@ -1,7 +1,8 @@
 package com.zegreatrob.coupling.client.components.pin
 
+import com.zegreatrob.coupling.action.party.SavePartyCommand
+import com.zegreatrob.coupling.action.party.fire
 import com.zegreatrob.coupling.action.pin.DeletePinCommand
-import com.zegreatrob.coupling.action.pin.SavePinCommand
 import com.zegreatrob.coupling.action.pin.fire
 import com.zegreatrob.coupling.client.components.DispatchFunc
 import com.zegreatrob.coupling.client.components.Paths.pinListPath
@@ -24,7 +25,7 @@ import react.router.dom.usePrompt
 import react.useState
 import kotlin.js.Json
 
-external interface PinConfigProps<D> : Props where D : DeletePinCommand.Dispatcher, D : SavePinCommand.Dispatcher {
+external interface PinConfigProps<D> : Props where D : DeletePinCommand.Dispatcher, D : SavePartyCommand.Dispatcher {
     var party: PartyDetails
     var boost: Boost?
     var pin: Pin
@@ -41,7 +42,7 @@ val PinConfig by nfc<PinConfigProps<*>> { props ->
     val updatedPin = values.fromJsonDynamic<GqlPinSnapshot>().toModel()
     val (redirectUrl, setRedirectUrl) = useState<String?>(null)
     val onSubmit = dispatchFunc {
-        fire(SavePinCommand(party.id, updatedPin))
+        fire(SavePartyCommand(partyId = party.id, pins = listOf(updatedPin)))
         reload()
     }
     val onRemove = if (!pinList.contains(pin)) {

client/components/src/jsMain/kotlin/com/zegreatrob/coupling/client/components/player/PlayerConfig.kt

@@ -1,7 +1,8 @@
 package com.zegreatrob.coupling.client.components.player
 
+import com.zegreatrob.coupling.action.party.SavePartyCommand
+import com.zegreatrob.coupling.action.party.fire
 import com.zegreatrob.coupling.action.player.DeletePlayerCommand
-import com.zegreatrob.coupling.action.player.SavePlayerCommand
 import com.zegreatrob.coupling.action.player.fire
 import com.zegreatrob.coupling.client.components.DispatchFunc
 import com.zegreatrob.coupling.client.components.Paths.currentPairsPath
@@ -26,7 +27,7 @@ import react.useState
 import kotlin.js.Json
 
 external interface PlayerConfigProps<P> : Props
-    where P : SavePlayerCommand.Dispatcher, P : DeletePlayerCommand.Dispatcher {
+    where P : SavePartyCommand.Dispatcher, P : DeletePlayerCommand.Dispatcher {
     var party: PartyDetails
     var boost: Boost?
     var player: Player
@@ -51,10 +52,12 @@ val PlayerConfig by nfc<PlayerConfigProps<*>> { props ->
     )
     val onSubmit = dispatchFunc {
         fire(
-            SavePlayerCommand(
+            SavePartyCommand(
                 partyId = party.id,
-                player = updatedPlayer.copy(
-                    additionalEmails = updatedPlayer.additionalEmails.filterNot(String::isBlank).toSet(),
+                players = listOf(
+                    updatedPlayer.copy(
+                        additionalEmails = updatedPlayer.additionalEmails.filterNot(String::isBlank).toSet(),
+                    ),
                 ),
             ),
         )

client/components/src/jsMain/kotlin/com/zegreatrob/coupling/client/components/player/UpdatingPlayerList.kt

@@ -1,7 +1,7 @@
 package com.zegreatrob.coupling.client.components.player
 
 import com.zegreatrob.coupling.action.VoidResult
-import com.zegreatrob.coupling.action.player.SavePlayerCommand
+import com.zegreatrob.coupling.action.party.SavePartyCommand
 import com.zegreatrob.coupling.client.components.DispatchFunc
 import com.zegreatrob.coupling.model.player.Player
 import com.zegreatrob.minreact.ReactFunc
@@ -13,7 +13,7 @@ import react.Props
 import react.ReactNode
 import react.useState
 
-external interface UpdatingPlayerListProps<D> : Props where D : SavePlayerCommand.Dispatcher {
+external interface UpdatingPlayerListProps<D> : Props where D : SavePartyCommand.Dispatcher {
     var players: List<Player>
     var dispatchFunc: DispatchFunc<D>
     var children: (List<Player>, DispatchFunc<D>) -> ReactNode
@@ -62,8 +62,8 @@ private class SecretCannon(
     ) {
         val unwrappedAction = action.unwrap()
         @Suppress("USELESS_IS_CHECK")
-        if (unwrappedAction is SavePlayerCommand && result == VoidResult.Accepted) {
-            addPlayer(unwrappedAction.player)
+        if (unwrappedAction is SavePartyCommand && result == VoidResult.Accepted) {
+            unwrappedAction.players.forEach(addPlayer)
         }
     }
 }