stores the check_update_interval as a .env variable#31
Open
AngeloBonini wants to merge 1 commit intorodbecc:mainfrom
Open
stores the check_update_interval as a .env variable#31AngeloBonini wants to merge 1 commit intorodbecc:mainfrom
AngeloBonini wants to merge 1 commit intorodbecc:mainfrom
Conversation
vvasc
requested changes
May 1, 2022
Collaborator
vvasc
left a comment
vvasc
left a comment
There was a problem hiding this comment.
Looks good. I think you should add some lines in readme to explain how to use it
| @@ -0,0 +1,17 @@ | |||
| import { spy } from 'mock'; | |||
Collaborator
There was a problem hiding this comment.
you can remove it and add the tests in a new PR
| @@ -0,0 +1 @@ | |||
| CHECK_UPDATE_INTERVAL= No newline at end of file | |||
| @@ -1 +1,2 @@ | |||
| last_check_update.txt No newline at end of file | |||
| last_check_update.txt | |||
Collaborator
There was a problem hiding this comment.
shouldn't be better if we use the same .env file do get this too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.