Skip to content

Inconsistent behaviour between lestrade and sherlock #19

Description

@Torvaney

highlight::sherlock returns a new function, whereas highlight::lestrade returns data(?).

This behavour is inconsistent (and also means the sherlock example in README.md is incorrect):

# Works
highlight::highlight(file = "test.R", detective = highlight::lestrade)

# Doesn't work
highlight::highlight(file = "test.R", detective = highlight::sherlock)
#> Error in UseMethod("filter_") : 
#>   no applicable method for 'filter_' applied to an object of class "function"

# Works
highlight::highlight(file = "test.R", detective = highlight::sherlock())

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions