fix: review round — 11 findings fixed (event propagation, race condition, i18n, types)

HIGH: DropdownMenuItem handlers prevent Link navigation via stopPropagation
MEDIUM: Create & Run Now uses useRef to avoid stale closure race
MEDIUM: Resume Combobox uses r.id as value + keywords prop for dedup safety
MEDIUM: AddContactInfo i18n — 12 hardcoded English strings replaced (16 new keys, 4 locales)
MEDIUM: Detail page as-any casts replaced with proper typing
LOW: Removed getLocationCodes wrapper, cn() for LocationBadge, added comments

69 suites, 1481 tests

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: rorar

src/actions/automation.actions.ts

@@ -74,7 +74,11 @@ export async function getAutomationsList(
       prisma.automation.count({ where: { userId: user.id } }),
     ]);
 
-    // Soft warning when automation count exceeds user's configured threshold
+    // Soft warning when automation count exceeds user's configured threshold.
+    // Convention: result.message is overloaded — a "performanceWarning:<count>" prefix
+    // signals a non-error warning to the UI layer, which checks for the prefix in
+    // AutomationWizard.onSubmit to show a separate toast. This avoids adding a
+    // dedicated "warnings" field to ActionResult for a single use case.
     let warning: string | undefined;
     const automationSettings = await getAutomationSettingsForUser(user.id);
     if (
@@ -199,7 +203,8 @@ export async function createAutomation(
       },
     });
 
-    // Soft warning when automation count exceeds user's configured threshold
+    // Soft warning when automation count exceeds user's configured threshold.
+    // See getAutomationsList for the "performanceWarning:" prefix convention.
     let warning: string | undefined;
     const automationCount = await prisma.automation.count({ where: { userId: user.id } });
     const automationSettings = await getAutomationSettingsForUser(user.id);

src/app/dashboard/automations/[id]/page.tsx

@@ -38,6 +38,7 @@ import type {
   AutomationRun,
   DiscoveredJob,
 } from "@/models/automation.model";
+import type { Resume } from "@/models/profile.model";
 import type { JobMatchResponse } from "@/models/ai.schemas";
 import { DiscoveredJobsList } from "@/components/automations/DiscoveredJobsList";
 import { DiscoveredJobDetail } from "@/components/automations/DiscoveredJobDetail";
@@ -55,9 +56,9 @@ export default function AutomationDetailPage() {
   const { locale } = useTranslations();
   const automationId = params.id as string;
 
-  const [automation, setAutomation] = useState<AutomationWithResume | null>(
-    null,
-  );
+  const [automation, setAutomation] = useState<
+    (AutomationWithResume & { runs?: AutomationRun[] }) | null
+  >(null);
   const [runs, setRuns] = useState<AutomationRun[]>([]);
   const [jobs, setJobs] = useState<DiscoveredJob[]>([]);
   const [loading, setLoading] = useState(true);
@@ -82,8 +83,8 @@ export default function AutomationDetailPage() {
       ]);
 
       if (automationResult.success && automationResult.data) {
-        setAutomation(automationResult.data as any);
-        setRuns((automationResult.data as any).runs || []);
+        setAutomation(automationResult.data);
+        setRuns(automationResult.data.runs || []);
       } else {
         toast({
           title: "Error",
@@ -95,15 +96,16 @@ export default function AutomationDetailPage() {
       }
 
       if (runsResult.success && runsResult.data) {
-        setRuns(runsResult.data as any);
+        setRuns(runsResult.data);
       }
 
       if (jobsResult.success && jobsResult.data) {
-        setJobs(jobsResult.data as any);
+        // StagedVacancyWithAutomation is structurally compatible with DiscoveredJob at runtime
+        setJobs(jobsResult.data as unknown as DiscoveredJob[]);
       }
 
       if (resumeResult.success && resumeResult.data) {
-        setResumes(resumeResult.data.map((r: any) => ({ id: r.id, title: r.title })));
+        setResumes(resumeResult.data.map((r: Resume) => ({ id: r.id, title: r.title })));
       }
     } catch (error) {
       toast({
@@ -184,9 +186,10 @@ export default function AutomationDetailPage() {
   const handleViewJobDetails = async (job: DiscoveredJob) => {
     const result = await getDiscoveredJobById(job.id);
     if (result.success && result.data) {
-      setSelectedJob(result.data as any);
+      // StagedVacancyWithAutomation is structurally compatible with DiscoveredJob at runtime
+      setSelectedJob(result.data as unknown as DiscoveredJob);
       setSelectedJobMatchData(
-        (result.data as any).parsedMatchData as JobMatchResponse | null,
+        result.data.parsedMatchData as JobMatchResponse | null,
       );
       setDetailOpen(true);
     } else {

src/components/automations/AutomationList.tsx

@@ -66,12 +66,6 @@ const PAUSE_REASON_KEYS: Record<AutomationPauseReason, string> = {
   cb_escalation: "automations.pauseReasonCbEscalation",
 };
 
-/** Parse location string into raw codes for LocationBadge rendering */
-function getLocationCodes(location: string): string[] {
-  if (!location) return [];
-  return parseLocations(location);
-}
-
 export function AutomationList({
   automations,
   onEdit,
@@ -157,7 +151,7 @@ export function AutomationList({
           const isLoading = loadingAction === automation.id;
           const resumeMissing = !automation.resume;
           const keywordChips = parseKeywords(automation.keywords);
-          const locationCodes = getLocationCodes(automation.location);
+          const locationCodes = parseLocations(automation.location);
           const isEures = automation.jobBoard === "eures" || automation.jobBoard === "arbeitsagentur";
 
           return (
@@ -268,27 +262,27 @@ export function AutomationList({
                   </DropdownMenuTrigger>
                   <DropdownMenuContent align="end">
                     {automation.status === "active" ? (
-                      <DropdownMenuItem onClick={() => handlePause(automation.id)}>
+                      <DropdownMenuItem onClick={(e) => { e.preventDefault(); e.stopPropagation(); handlePause(automation.id); }}>
                         <Pause className="h-4 w-4 mr-2" />
                         {t("automations.pause")}
                       </DropdownMenuItem>
                     ) : (
                       <DropdownMenuItem
-                        onClick={() => handleResume(automation.id)}
+                        onClick={(e) => { e.preventDefault(); e.stopPropagation(); handleResume(automation.id); }}
                         disabled={resumeMissing}
                       >
                         <Play className="h-4 w-4 mr-2" />
                         {t("automations.resume")}
                       </DropdownMenuItem>
                     )}
-                    <DropdownMenuItem onClick={() => onEdit(automation)}>
+                    <DropdownMenuItem onClick={(e) => { e.preventDefault(); e.stopPropagation(); onEdit(automation); }}>
                       <Pencil className="h-4 w-4 mr-2" />
                       {t("automations.edit")}
                     </DropdownMenuItem>
                     <DropdownMenuSeparator />
                     <DropdownMenuItem
                       className="text-destructive"
-                      onClick={() => setDeleteId(automation.id)}
+                      onClick={(e) => { e.preventDefault(); e.stopPropagation(); setDeleteId(automation.id); }}
                     >
                       <Trash2 className="h-4 w-4 mr-2" />
                       {t("automations.delete")}

src/components/automations/AutomationWizard.tsx

@@ -1,6 +1,6 @@
 "use client";
 
-import { useState, useEffect } from "react";
+import { useState, useEffect, useRef } from "react";
 import { useForm } from "react-hook-form";
 import { zodResolver } from "@hookform/resolvers/zod";
 import {
@@ -123,6 +123,7 @@ export function AutomationWizard({
   const [scheduleFrequency, setScheduleFrequency] = useState<ScheduleFrequency>("daily");
   const [resumePopoverOpen, setResumePopoverOpen] = useState(false);
   const [runAfterCreate, setRunAfterCreate] = useState(false);
+  const runAfterCreateRef = useRef(false);
 
   const form = useForm<CreateAutomationInput>({
     resolver: zodResolver(CreateAutomationSchema),
@@ -258,7 +259,9 @@ export function AutomationWizard({
   const onSubmit = async (data: CreateAutomationInput) => {
     setIsSubmitting(true);
     try {
-      // Ensure schedule frequency is in connectorParams before submit
+      // Ensure schedule frequency is in connectorParams before submit.
+      // Only persist non-daily frequencies: "daily" is the server-side default,
+      // so omitting it keeps connectorParams lean for the common case.
       const currentParams = tryParseConnectorParams(data.connectorParams) ?? {};
       if (scheduleFrequency !== "daily") {
         data.connectorParams = JSON.stringify({ ...currentParams, scheduleFrequency });
@@ -269,13 +272,15 @@ export function AutomationWizard({
         : await createAutomation(data);
 
       if (result.success) {
-        // If "Create & Run Now" was clicked, trigger a manual run
-        if (runAfterCreate && result.data?.id) {
+        // If "Create & Run Now" was clicked, trigger a manual run.
+        // Read from ref to avoid stale closure over state set just before handleSubmit.
+        if (runAfterCreateRef.current && result.data?.id) {
           try {
             await fetch(`/api/automations/${result.data.id}/run`, { method: "POST" });
           } catch {
             // Non-blocking — automation was created, run is best-effort
           }
+          runAfterCreateRef.current = false;
           setRunAfterCreate(false);
         }
 
@@ -572,20 +577,16 @@ export function AutomationWizard({
                     </FormControl>
                   </PopoverTrigger>
                   <PopoverContent className="w-[--radix-popover-trigger-width] p-0" align="start">
-                    <Command filter={(value, search) => {
-                      // Custom filter: cmdk strips special chars by default.
-                      // We need exact substring match for titles like "[MOCK_DATA] Jane Smith"
-                      if (!search) return 1;
-                      return value.toLowerCase().includes(search.toLowerCase()) ? 1 : 0;
-                    }}>
+                    <Command>
                       <CommandInput placeholder={t("automations.searchResume")} />
                       <CommandList>
                         <CommandEmpty>{t("automations.noResumeFound")}</CommandEmpty>
                         <CommandGroup>
                           {resumes.map((r) => (
                             <CommandItem
                               key={r.id}
-                              value={r.title}
+                              value={r.id}
+                              keywords={[r.title]}
                               onSelect={() => {
                                 field.onChange(r.id);
                                 setResumePopoverOpen(false);
@@ -847,6 +848,7 @@ export function AutomationWizard({
                       type="button"
                       disabled={isSubmitting}
                       onClick={async () => {
+                        runAfterCreateRef.current = true;
                         setRunAfterCreate(true);
                         form.handleSubmit(onSubmit)();
                       }}

src/components/profile/AddContactInfo.tsx

@@ -46,8 +46,8 @@ function AddContactInfo({
   const { t } = useTranslations();
 
   const pageTitle = contactInfoToEdit
-    ? "Edit Contact Info"
-    : "Add Contact Info";
+    ? t("profile.editContactInfo")
+    : t("profile.addContactInfo");
 
   const form = useForm<z.infer<typeof AddContactInfoFormSchema>>({
     resolver: zodResolver(AddContactInfoFormSchema),
@@ -119,9 +119,9 @@ function AddContactInfo({
         setDialogOpen(false);
         toast({
           variant: "success",
-          description: `Contact Info has been ${
-            contactInfoToEdit ? "updated" : "created"
-          } successfully`,
+          description: contactInfoToEdit
+            ? t("profile.contactInfoUpdated")
+            : t("profile.contactInfoCreated"),
         });
       }
     });
@@ -135,7 +135,7 @@ function AddContactInfo({
         <DialogHeader>
           <DialogTitle>{pageTitle}</DialogTitle>
           <DialogDescription className="sr-only">
-            {contactInfoToEdit ? "Edit contact information" : "Add contact information"}
+            {contactInfoToEdit ? t("profile.editContactInfo") : t("profile.addContactInfo")}
           </DialogDescription>
         </DialogHeader>
         <Form {...form}>
@@ -150,9 +150,9 @@ function AddContactInfo({
                 name="firstName"
                 render={({ field }) => (
                   <FormItem>
-                    <FormLabel>First Name</FormLabel>
+                    <FormLabel>{t("profile.firstName")}</FormLabel>
                     <FormControl>
-                      <Input placeholder="e.g. John" {...field} />
+                      <Input placeholder={t("profile.firstNamePlaceholder")} {...field} />
                     </FormControl>
                     <FormMessage />
                   </FormItem>
@@ -167,9 +167,9 @@ function AddContactInfo({
                 name="lastName"
                 render={({ field }) => (
                   <FormItem>
-                    <FormLabel>Last Name</FormLabel>
+                    <FormLabel>{t("profile.lastName")}</FormLabel>
                     <FormControl>
-                      <Input placeholder="e.g. Doe" {...field} />
+                      <Input placeholder={t("profile.lastNamePlaceholder")} {...field} />
                     </FormControl>
                     <FormMessage />
                   </FormItem>
@@ -184,9 +184,9 @@ function AddContactInfo({
                 name="headline"
                 render={({ field }) => (
                   <FormItem>
-                    <FormLabel>Headline</FormLabel>
+                    <FormLabel>{t("profile.headline")}</FormLabel>
                     <FormControl>
-                      <Input placeholder="e.g. Senior Software Engineer" {...field} />
+                      <Input placeholder={t("profile.headlinePlaceholder")} {...field} />
                     </FormControl>
                     <FormMessage />
                   </FormItem>
@@ -201,9 +201,9 @@ function AddContactInfo({
                 name="email"
                 render={({ field }) => (
                   <FormItem>
-                    <FormLabel>Email</FormLabel>
+                    <FormLabel>{t("profile.email")}</FormLabel>
                     <FormControl>
-                      <Input placeholder="e.g. john@example.com" {...field} />
+                      <Input placeholder={t("profile.emailPlaceholder")} {...field} />
                     </FormControl>
                     <FormMessage />
                   </FormItem>
@@ -218,9 +218,9 @@ function AddContactInfo({
                 name="phone"
                 render={({ field }) => (
                   <FormItem>
-                    <FormLabel>Phone</FormLabel>
+                    <FormLabel>{t("profile.phone")}</FormLabel>
                     <FormControl>
-                      <Input placeholder="e.g. +49 123 456789" {...field} />
+                      <Input placeholder={t("profile.phonePlaceholder")} {...field} />
                     </FormControl>
                     <FormMessage />
                   </FormItem>
@@ -235,9 +235,9 @@ function AddContactInfo({
                 name="address"
                 render={({ field }) => (
                   <FormItem>
-                    <FormLabel>Address</FormLabel>
+                    <FormLabel>{t("profile.address")}</FormLabel>
                     <FormControl>
-                      <Input placeholder="e.g. Berlin, Germany" {...field} value={field.value ?? ""} />
+                      <Input placeholder={t("profile.addressPlaceholder")} {...field} value={field.value ?? ""} />
                     </FormControl>
                     <FormMessage />
                   </FormItem>
@@ -255,11 +255,11 @@ function AddContactInfo({
                     className="mt-2 md:mt-0 w-full"
                     onClick={closeDialog}
                   >
-                    Cancel
+                    {t("common.cancel")}
                   </Button>
                 </div>
                 <Button type="submit" disabled={!formState.isDirty}>
-                  Save
+                  {t("common.save")}
                   {isPending && <Loader className="h-4 w-4 shrink-0 spinner" />}
                 </Button>
               </DialogFooter>

src/components/ui/location-badge.tsx

@@ -2,6 +2,7 @@
 
 import Image from "next/image";
 import { Badge } from "@/components/ui/badge";
+import { cn } from "@/lib/utils";
 import { getLocationLabel, getCountryCode } from "@/lib/connector/job-discovery/modules/eures/countries";
 
 interface LocationBadgeProps {
@@ -20,7 +21,7 @@ export function LocationBadge({ code, resolve = true, className }: LocationBadge
   const countryCode = getCountryCode(code);
 
   return (
-    <Badge variant="secondary" className={`text-xs gap-1 ${className ?? ""}`}>
+    <Badge variant="secondary" className={cn("text-xs gap-1", className)}>
       {countryCode && (
         <Image
           src={`/flags/${countryCode.toLowerCase()}.svg`}