Skip to content

Commit fcfb2bf

Browse files
traiansfwkolowski
andauthored
Apply suggestions from code review
Co-authored-by: Wojciech Kołowski <wkolowski@protonmail.com>
1 parent 69c618a commit fcfb2bf

3 files changed

Lines changed: 11 additions & 21 deletions

File tree

theories/VLSM/Core/ByzantineTraces/FixedSetByzantineTraces.v

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ Lemma fixed_non_byzantine_projection_incl_preloaded
300300
Proof.
301301
apply basic_VLSM_strong_incl.
302302
- intros is. apply fixed_non_byzantine_projection_initial_state_preservation.
303-
- intros m Hm. exact I.
303+
- intros m Hm. compute. trivial.
304304
- intros l s om Hv.
305305
split; [|exact I].
306306
revert Hv.

theories/VLSM/Core/SubProjectionTraces.v

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -390,14 +390,12 @@ Lemma induced_sub_projection_preloaded_free_incl
390390
: VLSM_incl induced_sub_projection (pre_loaded_with_all_messages_vlsm (free_composite_vlsm sub_IM)).
391391
Proof.
392392
apply basic_VLSM_strong_incl.
393-
2: cbv; intuition.
394393
- intros s (sX & <- & HsX) sub_i.
395394
destruct_dec_sig sub_i i Hi Heqsub_i.
396-
subst.
397-
apply (HsX i).
395+
subst. apply HsX.
396+
- cbv; intuition.
398397
- intros (sub_i, li) s om Hv.
399-
split; [|exact I].
400-
cbn.
398+
split; [cbn |exact I].
401399
destruct_dec_sig sub_i i Hi Heqsub_i; subst.
402400
apply induced_sub_projection_valid_projection_strong.
403401
assumption.

theories/VLSM/Lib/ListExtras.v

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -4,19 +4,16 @@ From VLSM Require Import Lib.Preamble.
44

55
(** * Utility lemmas about lists *)
66

7-
Lemma map_composed
7+
Lemma map_comp
88
[A B C : Type]
99
(f : A -> B)
1010
(g : B -> C)
1111
: map (g ∘ f) = map g ∘ map f.
1212
Proof.
1313
extensionality l.
14-
induction l; [reflexivity|]; cbn.
15-
rewrite IHl.
16-
reflexivity.
14+
induction l; cbn; rewrite ?IHl; reflexivity.
1715
Qed.
1816

19-
2017
(** A list is empty if it has no members *)
2118
Lemma empty_nil [X:Type] (l:list X) :
2219
(forall v, ~In v l) -> l = [].
@@ -1281,20 +1278,15 @@ Definition map_option
12811278
)
12821279
[].
12831280

1284-
Lemma map_option_composed_right
1285-
[A B C : Type]
1286-
(f : A -> B)
1287-
(g : B -> option C)
1288-
: map_option (g ∘ f) = map_option g ∘ map f.
1281+
Lemma map_option_comp_r
1282+
[A B C : Type] (f : A -> B) (g : B -> option C) :
1283+
map_option (g ∘ f) = map_option g ∘ map f.
12891284
Proof.
12901285
extensionality l.
1291-
induction l; [reflexivity|].
1292-
cbn.
1293-
rewrite IHl.
1294-
reflexivity.
1286+
induction l; cbn; rewrite ?IHl; reflexivity.
12951287
Qed.
12961288

1297-
Lemma map_option_composed_left
1289+
Lemma map_option_comp_l
12981290
[A B C : Type]
12991291
(f : A -> option B)
13001292
(g : B -> C)

0 commit comments

Comments
 (0)