Merge pull request #46 from jorisvanandel/fix/link-booking-to-financial-mutation-request-returns-status-code

Author: sandervanhooft

src/Api/FinancialMutations/FinancialMutationsEndpoint.php

@@ -4,6 +4,7 @@
 
 namespace Sandorian\Moneybird\Api\FinancialMutations;
 
+use Saloon\Http\Response;
 use Saloon\PaginationPlugin\Paginator;
 use Sandorian\Moneybird\Api\Support\BaseEndpoint;
 use Sandorian\Moneybird\Api\Support\IdVersion;
@@ -72,10 +73,10 @@ public function update(string $financialMutationId, array $body): FinancialMutat
     /**
      * @param  array<string, mixed>  $body
      */
-    public function linkBooking(string $financialMutationId, array $body): FinancialMutation
+    public function linkBooking(string $financialMutationId, array $body): Response
     {
         $request = new LinkBookingToFinancialMutationRequest($financialMutationId, $body);
 
-        return $this->client->send($request)->dtoOrFail();
+        return $this->client->send($request);
     }
 }

src/Api/FinancialMutations/LinkBookingToFinancialMutationRequest.php

@@ -4,7 +4,6 @@
 
 namespace Sandorian\Moneybird\Api\FinancialMutations;
 
-use Saloon\Http\Response;
 use Sandorian\Moneybird\Api\Support\BaseJsonPatchRequest;
 use Sandorian\Moneybird\Api\Support\EncapsulatesData;
 
@@ -27,11 +26,6 @@ public function resolveEndpoint(): string
         return 'financial_mutations/'.$this->financialMutationId.'/link_booking';
     }
 
-    public function createDtoFromResponse(Response $response): FinancialMutation
-    {
-        return FinancialMutation::createFromResponseData($response->json());
-    }
-
     protected function defaultBody(): array
     {
         return $this->data;

tests/Api/FinancialMutations/FinancialMutationsEndpointTest.php

@@ -5,6 +5,7 @@
 namespace Sandorian\Moneybird\Tests\Api\FinancialMutations;
 
 use Saloon\Http\Faking\MockResponse;
+use Saloon\Http\Response;
 use Sandorian\Moneybird\Api\FinancialMutations\FinancialMutation;
 use Sandorian\Moneybird\Api\FinancialMutations\GetFinancialMutationRequest;
 use Sandorian\Moneybird\Api\FinancialMutations\GetFinancialMutationsRequest;
@@ -30,7 +31,7 @@ protected function setUp(): void
             PostFinancialMutationsSynchronizationRequest::class => MockResponse::make(FinancialMutationsResponseStub::getAll(), 200),
             GetFinancialMutationRequest::class => MockResponse::make(FinancialMutationsResponseStub::get(), 200),
             UpdateFinancialMutationRequest::class => MockResponse::make(FinancialMutationsResponseStub::update(), 200),
-            LinkBookingToFinancialMutationRequest::class => MockResponse::make(FinancialMutationsResponseStub::linkBooking(), 200),
+            LinkBookingToFinancialMutationRequest::class => MockResponse::make([], 200),
         ]);
     }
 
@@ -86,15 +87,12 @@ public function test_it_can_update_a_financial_mutation(): void
 
     public function test_it_can_link_booking_to_financial_mutation(): void
     {
-        $financialMutation = $this->client->financialMutations()->linkBooking('123456789', [
+        $response = $this->client->financialMutations()->linkBooking('123456789', [
             'booking_type' => 'LedgerAccountBooking',
             'booking_id' => '123456',
             'price' => '100.00',
         ]);
 
-        $this->assertInstanceOf(FinancialMutation::class, $financialMutation);
-        $this->assertSame('123456789', $financialMutation->id);
-        $this->assertCount(1, $financialMutation->ledger_account_bookings);
-        $this->assertSame('123456', $financialMutation->ledger_account_bookings[0]['id']);
+        $this->assertInstanceOf(Response::class, $response);
     }
 }

tests/Api/FinancialMutations/FinancialMutationsResponseStub.php

@@ -109,37 +109,4 @@ public static function update(): string
             "payments": []
         }';
     }
-
-    public static function linkBooking(): string
-    {
-        return '{
-            "id": "123456789",
-            "administration_id": "123",
-            "financial_account_id": "456789123",
-            "type": "debit",
-            "amount": "100.00",
-            "code": "TRTP",
-            "date": "2023-01-01",
-            "message": "Payment for invoice",
-            "contra_account_name": "Client Company",
-            "contra_account_number": "NL01BANK9876543210",
-            "batch_reference": "BATCH123",
-            "offset_id": null,
-            "sepa_fields": null,
-            "created_at": "2023-01-01T12:00:00.000Z",
-            "updated_at": "2023-01-03T12:00:00.000Z",
-            "ledger_account_bookings": [
-                {
-                    "id": "123456",
-                    "administration_id": "123",
-                    "ledger_account_id": "789456",
-                    "description": "Booking for invoice payment",
-                    "price": "100.00",
-                    "created_at": "2023-01-03T12:00:00.000Z",
-                    "updated_at": "2023-01-03T12:00:00.000Z"
-                }
-            ],
-            "payments": []
-        }';
-    }
 }