Skip to content

Commit e5d9dd0

Browse files
Fix Administrations endpoint URLs to use absolute paths
The Administrations endpoint requires absolute URLs to bypass the connector's base URL which includes the administration ID. This fixes 404 errors when calling administrations()->all() or administrations()->get().
1 parent 91c267a commit e5d9dd0

2 files changed

Lines changed: 10 additions & 12 deletions

File tree

src/Api/Administrations/GetAdministrationRequest.php

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,13 @@ public function __construct(
1515
//
1616
}
1717

18+
/**
19+
* Returns the full URL to bypass the connector's base URL.
20+
* The Administrations endpoint does not use an administration ID in the path.
21+
*/
1822
public function resolveEndpoint(): string
1923
{
20-
return '/administrations/'.$this->id;
21-
}
22-
23-
public function resolveBaseUrl(): string
24-
{
25-
return 'https://moneybird.com/api/v2';
24+
return 'https://moneybird.com/api/v2/administrations/'.$this->id;
2625
}
2726

2827
public function createDtoFromResponse(Response $response): Administration

src/Api/Administrations/GetAdministrationsRequest.php

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,13 @@
99

1010
class GetAdministrationsRequest extends BaseJsonGetRequest
1111
{
12+
/**
13+
* Returns the full URL to bypass the connector's base URL.
14+
* The Administrations endpoint does not use an administration ID in the path.
15+
*/
1216
public function resolveEndpoint(): string
1317
{
14-
return '/administrations';
15-
}
16-
17-
public function resolveBaseUrl(): string
18-
{
19-
return 'https://moneybird.com/api/v2';
18+
return 'https://moneybird.com/api/v2/administrations';
2019
}
2120

2221
public function createDtoFromResponse(Response $response): Administration

0 commit comments

Comments
 (0)