From af8d255fd3f2a6681e26ce52419602a115fc949a Mon Sep 17 00:00:00 2001 From: Andrew Sparkes Date: Tue, 24 Mar 2026 13:16:35 +0000 Subject: [PATCH 01/29] added wafer size to ultima requests and pipeline --- app/models/bulk_submission.rb | 6 ++-- app/models/ultima_sequencing_pipeline.rb | 9 ++++++ app/models/ultima_sequencing_request.rb | 5 ++- app/validators/ultima_validator.rb | 10 +++++- app/views/bulk_submissions/_guidance.html.erb | 1 + config/bulk_submission_excel/columns.yml | 19 +++++++++++ config/bulk_submission_excel/ranges.yml | 5 +++ .../003_ultima_request_information_types.yml | 7 ++++ config/locales/metadata/en.yml | 3 ++ ...2536_add_wafer_size_to_request_metadata.rb | 10 ++++++ db/schema.rb | 3 +- spec/data/bulk_submission_excel/columns.yml | 19 +++++++++++ spec/data/bulk_submission_excel/ranges.yml | 5 +++ spec/factories/request_factories.rb | 3 +- .../models/ultima_sequencing_pipeline_spec.rb | 29 +++++++++++++++++ spec/models/ultima_sequencing_request_spec.rb | 8 +++++ spec/validators/ultima_validator_spec.rb | 32 +++++++++++++++++++ 17 files changed, 168 insertions(+), 6 deletions(-) create mode 100644 db/migrate/20260324112536_add_wafer_size_to_request_metadata.rb diff --git a/app/models/bulk_submission.rb b/app/models/bulk_submission.rb index 170ca24bc5..0f29773072 100644 --- a/app/models/bulk_submission.rb +++ b/app/models/bulk_submission.rb @@ -253,7 +253,8 @@ def process # rubocop:todo Metrics/CyclomaticComplexity 'scrna core cells per chip well', '% phix requested', 'low diversity', - 'ot recipe' + 'ot recipe', + 'wafer size' ].freeze ALIAS_FIELDS = { 'plate barcode' => 'barcode', 'tube barcode' => 'barcode' }.freeze @@ -360,7 +361,8 @@ def extract_request_options(details) ['scrna core cells per chip well', 'cells_per_chip_well'], ['% phix requested', 'percent_phix_requested'], ['low diversity', 'low_diversity'], - ['ot recipe', 'ot_recipe'] + ['ot recipe', 'ot_recipe'], + ['wafer size', 'wafer_size'] ].each do |source_key, target_key| assign_value_if_source_present(details, source_key, request_options, target_key) end diff --git a/app/models/ultima_sequencing_pipeline.rb b/app/models/ultima_sequencing_pipeline.rb index 3a28998d3b..7b0b90e847 100644 --- a/app/models/ultima_sequencing_pipeline.rb +++ b/app/models/ultima_sequencing_pipeline.rb @@ -11,6 +11,15 @@ def ot_recipe_consistent_for_batch?(batch) (ot_recipe_list.uniq.size == 1) end + def wafer_size_consistent_for_batch?(batch) + wafer_size_list = batch.requests.filter_map { |request| request.request_metadata.wafer_size } + + # There are some requests that don't have the wafer_size attribute + return false if wafer_size_list.size != batch.requests.size + + (wafer_size_list.uniq.size == 1) + end + def post_release_batch(batch, _user) # Same logic as the superclass, but with a different Messenger root and template batch.assets.compact.uniq.each(&:index_aliquots) diff --git a/app/models/ultima_sequencing_request.rb b/app/models/ultima_sequencing_request.rb index 63be2fae7b..11026d6389 100644 --- a/app/models/ultima_sequencing_request.rb +++ b/app/models/ultima_sequencing_request.rb @@ -6,6 +6,7 @@ class UltimaSequencingRequest < SequencingRequest FREE = 'Free' FLEX = 'Flex' OT_RECIPE_OPTIONS = [FREE, FLEX].freeze + WAFER_SIZE_OPTIONS = %w[5TB 10TB 20TB].freeze has_metadata as: Request do # Defining the sequencing request metadata here again, as 'has_metadata' @@ -25,11 +26,13 @@ class UltimaSequencingRequest < SequencingRequest custom_attribute(:ot_recipe, default: FREE, in: OT_RECIPE_OPTIONS, required: true) enum :ot_recipe, { Free: 0, Flex: 1 } + custom_attribute(:wafer_size, default: '10TB', in: WAFER_SIZE_OPTIONS, required: true) + enum :wafer_size, { '5TB': 0, '10TB': 1, '20TB': 2 } end # Delegate to request_metadata so the attributes are visible to the validator in the RSpec tests. # This delegation has no real effect outside of the tests. - delegate :ot_recipe, to: :request_metadata + delegate :ot_recipe, :wafer_size, to: :request_metadata # Generates unique wafer ID, concatenation of batch_for_opentrons, # id_pool_lims, and request_order. diff --git a/app/validators/ultima_validator.rb b/app/validators/ultima_validator.rb index bc69826792..302e4a5829 100644 --- a/app/validators/ultima_validator.rb +++ b/app/validators/ultima_validator.rb @@ -2,16 +2,18 @@ class UltimaValidator < ActiveModel::Validator TWO_REQUESTS_MSG = 'Batches must contain exactly two requests.' OT_RECIPE_CONSISTENT_MSG = 'OT Recipe must be the same for both requests.' + WAFER_SIZE_CONSISTENT_MSG = 'Wafer size must be the same for both requests.' # Used in _pipeline_limit.html to display custom validation warnings def self.validation_info - 'OT Recipe must be the same for both requests.' + 'OT Recipe and Wafer Size must be the same for both requests.' end # Validates that a batch contains the two requests. def validate(record) validate_exactly_two_requests(record) requests_have_same_ot_recipe(record) + requests_have_same_wafer_size(record) end private @@ -27,4 +29,10 @@ def requests_have_same_ot_recipe(record) record.errors.add(:base, OT_RECIPE_CONSISTENT_MSG) end + + def requests_have_same_wafer_size(record) + return if record.pipeline.wafer_size_consistent_for_batch?(record) + + record.errors.add(:base, WAFER_SIZE_CONSISTENT_MSG) + end end diff --git a/app/views/bulk_submissions/_guidance.html.erb b/app/views/bulk_submissions/_guidance.html.erb index 6532b2d383..4706dfc832 100644 --- a/app/views/bulk_submissions/_guidance.html.erb +++ b/app/views/bulk_submissions/_guidance.html.erb @@ -47,4 +47,5 @@ used to split a submission up into orders, and as a result must have the same re
% PhiX requested
Required percentage of PhiX needed.
Low Diversity
Low Diversity value being "Yes" or "No"
OT Recipe
OT (OpenTron liquid handler) Recipe value being "Free" or "Flex"
+
Wafer Size
Wafer size value being "5TB", "10TB" or "20TB"
diff --git a/config/bulk_submission_excel/columns.yml b/config/bulk_submission_excel/columns.yml index 02de62cb55..8e265391cb 100644 --- a/config/bulk_submission_excel/columns.yml +++ b/config/bulk_submission_excel/columns.yml @@ -367,3 +367,22 @@ ot_recipe: range_name: :ot_recipe conditional_formattings: empty_cell: +wafer_size: + heading: "Wafer Size" + unlocked: true + attribute: :wafer_size + validation: + options: + type: :list + formula1: "$A$1:$A$2" + allowBlank: false + showInputMessage: true + showErrorMessage: true + errorStyle: :stop + errorTitle: "Wafer Size" + error: "You must enter a value from the list provided." + promptTitle: "Wafer Size" + prompt: "Select a value type from the approved list" + range_name: :wafer_size + conditional_formattings: + empty_cell: diff --git a/config/bulk_submission_excel/ranges.yml b/config/bulk_submission_excel/ranges.yml index a1c091015a..b211a116cb 100644 --- a/config/bulk_submission_excel/ranges.yml +++ b/config/bulk_submission_excel/ranges.yml @@ -27,3 +27,8 @@ ot_recipe: options: - "Free" - "Flex" +wafer_size: + options: + - "5TB" + - "10TB" + - "20TB" diff --git a/config/default_records/request_information_types/003_ultima_request_information_types.yml b/config/default_records/request_information_types/003_ultima_request_information_types.yml index 39cabd99c3..6fa20cb84e 100644 --- a/config/default_records/request_information_types/003_ultima_request_information_types.yml +++ b/config/default_records/request_information_types/003_ultima_request_information_types.yml @@ -6,6 +6,13 @@ ot_recipe: width: 5 hide_in_inbox: 0 +wafer_size: + name: Wafer size + key: wafer_size + label: Wafer size + width: 5 + hide_in_inbox: 0 + fragment_size_required_from: name: Fragment size required (from) key: fragment_size_required_from diff --git a/config/locales/metadata/en.yml b/config/locales/metadata/en.yml index 08f1fbd67e..1cee050a2e 100644 --- a/config/locales/metadata/en.yml +++ b/config/locales/metadata/en.yml @@ -79,6 +79,9 @@ en: ot_recipe: label: OT Recipe + wafer_size: + label: Wafer Size + library_creation_request: <<: *REQUEST sequencing_request: diff --git a/db/migrate/20260324112536_add_wafer_size_to_request_metadata.rb b/db/migrate/20260324112536_add_wafer_size_to_request_metadata.rb new file mode 100644 index 0000000000..60f9adc656 --- /dev/null +++ b/db/migrate/20260324112536_add_wafer_size_to_request_metadata.rb @@ -0,0 +1,10 @@ +# frozen_string_literal: true + +# This migration adds a wafer_size column to the request_metadata table, which is used to store +# the wafer size for Ultima sequencing requests. This is stored as an integer enum, with possible +# values of 5TB, 10TB, and 20TB at time of writing. +class AddWaferSizeToRequestMetadata < ActiveRecord::Migration[7.1] + def change + add_column :request_metadata, :wafer_size, :integer + end +end diff --git a/db/schema.rb b/db/schema.rb index 34cce1cefe..44a678a359 100644 --- a/db/schema.rb +++ b/db/schema.rb @@ -10,7 +10,7 @@ # # It's strongly recommended that you check this file into your version control system. -ActiveRecord::Schema[7.2].define(version: 2026_03_17_142326) do +ActiveRecord::Schema[7.2].define(version: 2026_03_24_112536) do create_table "accession_sample_statuses", charset: "utf8mb4", collation: "utf8mb4_unicode_ci", force: :cascade do |t| t.integer "sample_id", null: false t.string "status", null: false @@ -1191,6 +1191,7 @@ t.boolean "low_diversity" t.integer "percent_phix_requested" t.integer "ot_recipe" + t.integer "wafer_size" t.index ["request_id"], name: "index_request_metadata_on_request_id" end diff --git a/spec/data/bulk_submission_excel/columns.yml b/spec/data/bulk_submission_excel/columns.yml index 03280783ee..ab5bd8739e 100644 --- a/spec/data/bulk_submission_excel/columns.yml +++ b/spec/data/bulk_submission_excel/columns.yml @@ -315,3 +315,22 @@ ot_recipe: range_name: :ot_recipe conditional_formattings: empty_cell: +wafer_size: + heading: "Wafer Size" + unlocked: true + attribute: :wafer_size + validation: + options: + type: :list + formula1: "$A$1:$A$2" + allowBlank: false + showInputMessage: true + showErrorMessage: true + errorStyle: :stop + errorTitle: "Wafer Size" + error: "You must enter a value from the list provided." + promptTitle: "Wafer Size" + prompt: "Select a value type from the approved list" + range_name: :wafer_size + conditional_formattings: + empty_cell: diff --git a/spec/data/bulk_submission_excel/ranges.yml b/spec/data/bulk_submission_excel/ranges.yml index a1c091015a..b211a116cb 100644 --- a/spec/data/bulk_submission_excel/ranges.yml +++ b/spec/data/bulk_submission_excel/ranges.yml @@ -27,3 +27,8 @@ ot_recipe: options: - "Free" - "Flex" +wafer_size: + options: + - "5TB" + - "10TB" + - "20TB" diff --git a/spec/factories/request_factories.rb b/spec/factories/request_factories.rb index 5a012985fc..570208fd28 100644 --- a/spec/factories/request_factories.rb +++ b/spec/factories/request_factories.rb @@ -109,7 +109,8 @@ { fragment_size_required_from: 150, fragment_size_required_to: 400, - ot_recipe: 'Free' + ot_recipe: 'Free', + wafer_size: '10TB' } end diff --git a/spec/models/ultima_sequencing_pipeline_spec.rb b/spec/models/ultima_sequencing_pipeline_spec.rb index 9e55c1018e..99cd6dca05 100644 --- a/spec/models/ultima_sequencing_pipeline_spec.rb +++ b/spec/models/ultima_sequencing_pipeline_spec.rb @@ -38,6 +38,35 @@ end end + describe '#wafer_size_consistent_for_batch?' do + it 'returns true when all requests have the same wafer_size' do + batch = pipeline.batches.build + r1 = create(:ultima_sequencing_request, request_metadata_attributes: { wafer_size: '10TB' }) + r2 = create(:ultima_sequencing_request, request_metadata_attributes: { wafer_size: '10TB' }) + batch.requests << [r1, r2] + + expect(pipeline.wafer_size_consistent_for_batch?(batch)).to be true + end + + it 'returns false when requests have different wafer_sizes' do + batch = pipeline.batches.build + req1 = create(:ultima_sequencing_request, request_metadata_attributes: { wafer_size: '5TB' }) + req2 = create(:ultima_sequencing_request, request_metadata_attributes: { wafer_size: '10TB' }) + batch.requests << [req1, req2] + + expect(pipeline.wafer_size_consistent_for_batch?(batch)).to be false + end + + it 'returns false when some requests are missing wafer_size' do + batch = pipeline.batches.build + r1 = create(:sequencing_request, request_metadata_attributes: { wafer_size: '10TB' }) + r2 = create(:sequencing_request, request_metadata_attributes: {}) # no wafer_size + batch.requests << [r1, r2] + + expect(pipeline.wafer_size_consistent_for_batch?(batch)).to be false + end + end + describe '#post_release_batch' do let(:batch) { create(:batch) } diff --git a/spec/models/ultima_sequencing_request_spec.rb b/spec/models/ultima_sequencing_request_spec.rb index d152679b4e..b990cbb89d 100644 --- a/spec/models/ultima_sequencing_request_spec.rb +++ b/spec/models/ultima_sequencing_request_spec.rb @@ -39,5 +39,13 @@ expect(request.errors[:'request_metadata.ot_recipe']).to include("can't be blank") end end + + context 'when wafer_size value is not assigned' do + it 'is invalid and displays required wafer size error message' do + request.request_metadata.wafer_size = nil + request.validate + expect(request.errors[:'request_metadata.wafer_size']).to include("can't be blank") + end + end end end diff --git a/spec/validators/ultima_validator_spec.rb b/spec/validators/ultima_validator_spec.rb index c651ef2695..1c1ad66aa5 100644 --- a/spec/validators/ultima_validator_spec.rb +++ b/spec/validators/ultima_validator_spec.rb @@ -37,6 +37,38 @@ end end + context 'when batch contains two requests with the same Wafer Size' do + let(:pipeline) { UltimaSequencingPipeline.new } + let(:batch) { create(:batch, pipeline:) } + let(:request1) { create(:ultima_sequencing_request, request_metadata_attributes: { wafer_size: '10TB' }) } + let(:request2) { create(:ultima_sequencing_request, request_metadata_attributes: { wafer_size: '10TB' }) } + + before do + batch.requests << [request1, request2] + end + + it 'is valid' do + validator.validate(batch) + expect(batch.errors[:base]).to be_empty + end + end + + context 'when batch contains two requests with different wafer_size' do + let(:pipeline) { UltimaSequencingPipeline.new } + let(:batch) { create(:batch, pipeline:) } + let(:request1) { create(:ultima_sequencing_request, request_metadata_attributes: { wafer_size: '5TB' }) } + let(:request2) { create(:ultima_sequencing_request, request_metadata_attributes: { wafer_size: '10TB' }) } + + before do + batch.requests << [request1, request2] + end + + it 'is invalid due to wafer_size mismatch' do + validator.validate(batch) + expect(batch.errors[:base]).to include(described_class::WAFER_SIZE_CONSISTENT_MSG) + end + end + context 'when batch contains a single request' do let(:pipeline) { UltimaSequencingPipeline.new } let(:batch) { create(:batch, pipeline:) } From ede2885d58298cb3d8ddf8f8b86e40587ebfb499 Mon Sep 17 00:00:00 2001 From: Andrew Sparkes Date: Wed, 25 Mar 2026 10:01:02 +0000 Subject: [PATCH 02/29] adding ug200 request type --- app/models/ultima_sequencing_request.rb | 5 +- .../ultima_u_g_200_sequencing_request.rb | 61 +++++++++++++++++++ .../003_ultima_request_type_validators.yml | 15 +++++ .../026_ultima_ug200_request_types.yml | 11 ++++ .../021_ultima_ug200_submission_templates.yml | 10 +++ ...2536_add_wafer_size_to_request_metadata.rb | 4 +- db/schema.rb | 3 +- spec/factories/request_factories.rb | 17 +++++- spec/factories/request_type_factories.rb | 5 ++ .../ultima_ug200_sequencing_request_spec.rb | 51 ++++++++++++++++ 10 files changed, 172 insertions(+), 10 deletions(-) create mode 100644 app/models/ultima_u_g_200_sequencing_request.rb create mode 100644 config/default_records/request_type_validators/003_ultima_request_type_validators.yml create mode 100644 config/default_records/request_types/026_ultima_ug200_request_types.yml create mode 100644 config/default_records/submission_templates/021_ultima_ug200_submission_templates.yml create mode 100644 spec/models/ultima_ug200_sequencing_request_spec.rb diff --git a/app/models/ultima_sequencing_request.rb b/app/models/ultima_sequencing_request.rb index 11026d6389..63be2fae7b 100644 --- a/app/models/ultima_sequencing_request.rb +++ b/app/models/ultima_sequencing_request.rb @@ -6,7 +6,6 @@ class UltimaSequencingRequest < SequencingRequest FREE = 'Free' FLEX = 'Flex' OT_RECIPE_OPTIONS = [FREE, FLEX].freeze - WAFER_SIZE_OPTIONS = %w[5TB 10TB 20TB].freeze has_metadata as: Request do # Defining the sequencing request metadata here again, as 'has_metadata' @@ -26,13 +25,11 @@ class UltimaSequencingRequest < SequencingRequest custom_attribute(:ot_recipe, default: FREE, in: OT_RECIPE_OPTIONS, required: true) enum :ot_recipe, { Free: 0, Flex: 1 } - custom_attribute(:wafer_size, default: '10TB', in: WAFER_SIZE_OPTIONS, required: true) - enum :wafer_size, { '5TB': 0, '10TB': 1, '20TB': 2 } end # Delegate to request_metadata so the attributes are visible to the validator in the RSpec tests. # This delegation has no real effect outside of the tests. - delegate :ot_recipe, :wafer_size, to: :request_metadata + delegate :ot_recipe, to: :request_metadata # Generates unique wafer ID, concatenation of batch_for_opentrons, # id_pool_lims, and request_order. diff --git a/app/models/ultima_u_g_200_sequencing_request.rb b/app/models/ultima_u_g_200_sequencing_request.rb new file mode 100644 index 0000000000..ad505477a0 --- /dev/null +++ b/app/models/ultima_u_g_200_sequencing_request.rb @@ -0,0 +1,61 @@ +# frozen_string_literal: true + +# Request class specific to the Ultima UG200 sequencing platform. +# Includes specific validation for wafer combination with read type. +class UltimaUG200SequencingRequest < SequencingRequest + include Api::Messages::UseqWaferIo::LaneExtensions + + WAFER_SIZE_OPTIONS = %w[5TB 10TB 20TB].freeze + + has_metadata as: Request do + # Defining the sequencing request metadata here again, as 'has_metadata' + # does not automatically append these custom attributes to the request. + # + # The has_metadata call dynamically defines an inner Metadata class and + # takes the attributes from the block and adds them to the Metadata class. + # There is an assumption that the inner Metadata class is available in a + # sequencing request class defintion. Calling has_metadata again does not + # inherit the attributes given in the block supplied in the superclass. + # They need to be supplied again for this class for a proper inner Metadata + # class definition. In a future refactoring these attributes can be moved a + # class attribute and subclasses can merge its own attibutes to that. A + # common method can set up the inner Metadata class in the subclasses. + custom_attribute(:fragment_size_required_from, integer: true, minimum: 1) + custom_attribute(:fragment_size_required_to, integer: true, minimum: 1) + + # TODO: the defaults set here do NOT work on the option lists in screens for some reason. + custom_attribute(:wafer_size, default: '10TB', in: WAFER_SIZE_OPTIONS, required: true) + enum :wafer_size, { '5TB': 0, '10TB': 1, '20TB': 2 } + custom_attribute(:read_length, default: 300, integer: true, validator: true, required: true, selection: true) + end + + # Delegate to request_metadata so the attributes are visible to the validator in the RSpec tests. + # This delegation has no real effect outside of the tests. + delegate :wafer_size, :read_length, to: :request_metadata + + class UltimaUG200RequestOptionsValidator < DelegateValidation::Validator + delegate :wafer_size, :read_length, :request_types, to: :target + + validate :validate_read_length_by_wafer_size + + def validate_read_length_by_wafer_size + puts "Wafer Size: #{wafer_size}, Read Length: #{read_length}" + binding.pry + return if wafer_size == '10TB' && read_length.to_i == 300 + + errors.add(:read_length, + 'The user can only select a Read Length of 300 with the 10TB wafer type for Ultima UG200 requests') + end + end + + def self.delegate_validator + UltimaUG200SequencingRequest::UltimaUG200RequestOptionsValidator + end + + # Generates unique wafer ID, concatenation of batch_for_opentrons, + # id_pool_lims, and request_order. + # @return [String] unique wafer ID for LIMS + def id_wafer_lims + "#{batch.id}_#{source_labware.human_barcode}_#{position}" + end +end diff --git a/config/default_records/request_type_validators/003_ultima_request_type_validators.yml b/config/default_records/request_type_validators/003_ultima_request_type_validators.yml new file mode 100644 index 0000000000..8226313081 --- /dev/null +++ b/config/default_records/request_type_validators/003_ultima_request_type_validators.yml @@ -0,0 +1,15 @@ +--- +WaferSizeRequestedUltimaUG200Sequencing: + request_type_key: ultima_u_g_200_sequencing + request_option: wafer_size + valid_options: + - 5TB + - 10TB + - 20TB +ReadLengthRequestedUltimaUG200Sequencing: + request_type_key: ultima_u_g_200_sequencing + request_option: read_length + valid_options: + - 150 + - 200 + - 300 diff --git a/config/default_records/request_types/026_ultima_ug200_request_types.yml b/config/default_records/request_types/026_ultima_ug200_request_types.yml new file mode 100644 index 0000000000..35581520fd --- /dev/null +++ b/config/default_records/request_types/026_ultima_ug200_request_types.yml @@ -0,0 +1,11 @@ +# Request types for Ultima UG200 sequencing platform. +--- +ultima_u_g_200_sequencing: + name: Ultima UG200 sequencing + asset_type: LibraryTube + order: 2 + initial_state: pending + billable: true + product_line_name: Ultima + request_class_name: UltimaUG200SequencingRequest + request_purpose: standard diff --git a/config/default_records/submission_templates/021_ultima_ug200_submission_templates.yml b/config/default_records/submission_templates/021_ultima_ug200_submission_templates.yml new file mode 100644 index 0000000000..27b6a6a6b7 --- /dev/null +++ b/config/default_records/submission_templates/021_ultima_ug200_submission_templates.yml @@ -0,0 +1,10 @@ +# This submission template is associated with the Ultima PCR Free Library preparation pipeline +# and the Ultima UG200 sequencing platform. +--- +Limber-Htp - Ultima PCR Free - Ultima UG200 sequencing: + submission_class_name: "LinearSubmission" + related_records: + request_type_keys: ["limber_ultima_htp_pcr_free", "limber_multiplexing_ultima", "ultima_u_g_200_sequencing"] + order_role: PCR Free + product_line_name: Ultima + product_catalogue_name: GenericNoPCR diff --git a/db/migrate/20260324112536_add_wafer_size_to_request_metadata.rb b/db/migrate/20260324112536_add_wafer_size_to_request_metadata.rb index 60f9adc656..f1e811d8f0 100644 --- a/db/migrate/20260324112536_add_wafer_size_to_request_metadata.rb +++ b/db/migrate/20260324112536_add_wafer_size_to_request_metadata.rb @@ -1,10 +1,10 @@ # frozen_string_literal: true # This migration adds a wafer_size column to the request_metadata table, which is used to store -# the wafer size for Ultima sequencing requests. This is stored as an integer enum, with possible +# the wafer size for Ultima sequencing requests. This is stored as a string, with possible # values of 5TB, 10TB, and 20TB at time of writing. class AddWaferSizeToRequestMetadata < ActiveRecord::Migration[7.1] def change - add_column :request_metadata, :wafer_size, :integer + add_column :request_metadata, :wafer_size, :string end end diff --git a/db/schema.rb b/db/schema.rb index 44a678a359..34cce1cefe 100644 --- a/db/schema.rb +++ b/db/schema.rb @@ -10,7 +10,7 @@ # # It's strongly recommended that you check this file into your version control system. -ActiveRecord::Schema[7.2].define(version: 2026_03_24_112536) do +ActiveRecord::Schema[7.2].define(version: 2026_03_17_142326) do create_table "accession_sample_statuses", charset: "utf8mb4", collation: "utf8mb4_unicode_ci", force: :cascade do |t| t.integer "sample_id", null: false t.string "status", null: false @@ -1191,7 +1191,6 @@ t.boolean "low_diversity" t.integer "percent_phix_requested" t.integer "ot_recipe" - t.integer "wafer_size" t.index ["request_id"], name: "index_request_metadata_on_request_id" end diff --git a/spec/factories/request_factories.rb b/spec/factories/request_factories.rb index 570208fd28..fcb9e714a8 100644 --- a/spec/factories/request_factories.rb +++ b/spec/factories/request_factories.rb @@ -109,8 +109,7 @@ { fragment_size_required_from: 150, fragment_size_required_to: 400, - ot_recipe: 'Free', - wafer_size: '10TB' + ot_recipe: 'Free' } end @@ -125,6 +124,20 @@ end end + factory(:ultima_u_g_200_sequencing_request) do + request_type factory: %i[ultima_u_g_200_sequencing] + request_purpose { :standard } + sti_type { 'UltimaUG200SequencingRequest' } + request_metadata_attributes do + { + fragment_size_required_from: 150, + fragment_size_required_to: 400, + read_length: 300, + wafer_size: '10TB' + } + end + end + factory(:library_creation_request, parent: :request, class: 'LibraryCreationRequest') do asset factory: %i[sample_tube] request_type factory: %i[library_creation_request_type] diff --git a/spec/factories/request_type_factories.rb b/spec/factories/request_type_factories.rb index 4d18e1eb3d..536c7ad123 100644 --- a/spec/factories/request_type_factories.rb +++ b/spec/factories/request_type_factories.rb @@ -139,6 +139,11 @@ request_class { UltimaSequencingRequest } end + factory :ultima_u_g_200_sequencing do + asset_type { 'LibraryTube' } + request_class { UltimaUG200SequencingRequest } + end + factory :miseq_sequencing_request_type do request_class { MiSeqSequencingRequest } asset_type { 'LibraryTube' } diff --git a/spec/models/ultima_ug200_sequencing_request_spec.rb b/spec/models/ultima_ug200_sequencing_request_spec.rb new file mode 100644 index 0000000000..424e4020cb --- /dev/null +++ b/spec/models/ultima_ug200_sequencing_request_spec.rb @@ -0,0 +1,51 @@ +# frozen_string_literal: true + +require 'rails_helper' + +RSpec.describe UltimaUG200SequencingRequest do + let(:request) { create(:ultima_u_g_200_sequencing_request) } + + describe 'Validations' do + context 'when all attributes are valid' do + it 'is valid' do + expect(request).to be_valid + end + end + + context 'when fragment_size_required_from is less than 1' do + it 'is invalid and displays fragment size from error message' do + request.request_metadata.fragment_size_required_from = 0 + request.validate + expect(request.errors[:'request_metadata.fragment_size_required_from']).to include( + 'must be greater than or equal to 1' + ) + end + end + + context 'when fragment_size_required_to is less than 1' do + it 'is invalid and displays fragment size to error message' do + request.request_metadata.fragment_size_required_to = 0 + request.validate + expect(request.errors[:'request_metadata.fragment_size_required_to']).to include( + 'must be greater than or equal to 1' + ) + end + end + + context 'when ot_recipe value is not assigned' do + it 'is invalid and displays required percent phix requested error message' do + request.request_metadata.ot_recipe = nil + request.validate + expect(request.errors[:'request_metadata.ot_recipe']).to include("can't be blank") + end + end + + context 'when wafer_size value is not assigned' do + it 'is invalid and displays required wafer size error message' do + request.request_metadata.wafer_size = nil + request.validate + expect(request.errors[:'request_metadata.wafer_size']).to include("can't be blank") + end + end + end +end From 5ab4f98dc574786e4f83509710db02aeb14320f4 Mon Sep 17 00:00:00 2001 From: Andrew Sparkes Date: Wed, 25 Mar 2026 10:03:11 +0000 Subject: [PATCH 03/29] change to schema --- db/schema.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/db/schema.rb b/db/schema.rb index 34cce1cefe..4f5e30ff8a 100644 --- a/db/schema.rb +++ b/db/schema.rb @@ -10,7 +10,7 @@ # # It's strongly recommended that you check this file into your version control system. -ActiveRecord::Schema[7.2].define(version: 2026_03_17_142326) do +ActiveRecord::Schema[7.2].define(version: 2026_03_24_112536) do create_table "accession_sample_statuses", charset: "utf8mb4", collation: "utf8mb4_unicode_ci", force: :cascade do |t| t.integer "sample_id", null: false t.string "status", null: false @@ -1191,6 +1191,7 @@ t.boolean "low_diversity" t.integer "percent_phix_requested" t.integer "ot_recipe" + t.string "wafer_size" t.index ["request_id"], name: "index_request_metadata_on_request_id" end From 9b576426369c8c9582b16c43888fa01e2626d666 Mon Sep 17 00:00:00 2001 From: Andrew Sparkes Date: Wed, 25 Mar 2026 13:04:45 +0000 Subject: [PATCH 04/29] Added inflection for UG200 Various config refactoring --- app/models/ultima_sequencing_pipeline.rb | 11 +-------- .../ultima_ug200_sequencing_pipeline.rb | 13 +++++++++++ ....rb => ultima_ug200_sequencing_request.rb} | 10 +++----- app/validators/ultima_ug200_validator.rb | 23 +++++++++++++++++++ app/validators/ultima_validator.rb | 10 +------- ...200_pipeline_request_information_types.yml | 17 ++++++++++++++ .../pipelines/004_ultima_ug200_pipelines.yml | 17 ++++++++++++++ .../003_ultima_request_information_types.yml | 7 ------ ...ultima_ug200_request_information_types.yml | 7 ++++++ ..._ultima_ug200_request_type_validators.yml} | 4 ++-- .../026_ultima_ug200_request_types.yml | 3 ++- .../021_ultima_ug200_submission_templates.yml | 10 +++++++- config/initializers/inflections.rb | 1 + config/locales/metadata/en.yml | 3 +++ spec/factories/request_factories.rb | 4 ++-- spec/factories/request_type_factories.rb | 2 +- .../ultima_ug200_sequencing_request_spec.rb | 2 +- 17 files changed, 103 insertions(+), 41 deletions(-) create mode 100644 app/models/ultima_ug200_sequencing_pipeline.rb rename app/models/{ultima_u_g_200_sequencing_request.rb => ultima_ug200_sequencing_request.rb} (89%) create mode 100644 app/validators/ultima_ug200_validator.rb create mode 100644 config/default_records/pipeline_request_information_types/004_ultima_ug200_pipeline_request_information_types.yml create mode 100644 config/default_records/pipelines/004_ultima_ug200_pipelines.yml create mode 100644 config/default_records/request_information_types/004_ultima_ug200_request_information_types.yml rename config/default_records/request_type_validators/{003_ultima_request_type_validators.yml => 003_ultima_ug200_request_type_validators.yml} (72%) diff --git a/app/models/ultima_sequencing_pipeline.rb b/app/models/ultima_sequencing_pipeline.rb index 7b0b90e847..639c7ee349 100644 --- a/app/models/ultima_sequencing_pipeline.rb +++ b/app/models/ultima_sequencing_pipeline.rb @@ -1,6 +1,6 @@ # frozen_string_literal: true -# Specialized sequencing pipeline for Ultima +# Specialized sequencing pipeline for Ultima UG100 class UltimaSequencingPipeline < SequencingPipeline def ot_recipe_consistent_for_batch?(batch) ot_recipe_list = batch.requests.filter_map { |request| request.request_metadata.ot_recipe } @@ -11,15 +11,6 @@ def ot_recipe_consistent_for_batch?(batch) (ot_recipe_list.uniq.size == 1) end - def wafer_size_consistent_for_batch?(batch) - wafer_size_list = batch.requests.filter_map { |request| request.request_metadata.wafer_size } - - # There are some requests that don't have the wafer_size attribute - return false if wafer_size_list.size != batch.requests.size - - (wafer_size_list.uniq.size == 1) - end - def post_release_batch(batch, _user) # Same logic as the superclass, but with a different Messenger root and template batch.assets.compact.uniq.each(&:index_aliquots) diff --git a/app/models/ultima_ug200_sequencing_pipeline.rb b/app/models/ultima_ug200_sequencing_pipeline.rb new file mode 100644 index 0000000000..896f4e7696 --- /dev/null +++ b/app/models/ultima_ug200_sequencing_pipeline.rb @@ -0,0 +1,13 @@ +# frozen_string_literal: true + +# Specialized sequencing pipeline for Ultima UG200 +class UltimaUG200SequencingPipeline < UltimaSequencingPipeline + def wafer_size_consistent_for_batch?(batch) + wafer_size_list = batch.requests.filter_map { |request| request.request_metadata.wafer_size } + + # There are some requests that don't have the wafer_size attribute + return false if wafer_size_list.size != batch.requests.size + + (wafer_size_list.uniq.size == 1) + end +end diff --git a/app/models/ultima_u_g_200_sequencing_request.rb b/app/models/ultima_ug200_sequencing_request.rb similarity index 89% rename from app/models/ultima_u_g_200_sequencing_request.rb rename to app/models/ultima_ug200_sequencing_request.rb index ad505477a0..2f7b569f91 100644 --- a/app/models/ultima_u_g_200_sequencing_request.rb +++ b/app/models/ultima_ug200_sequencing_request.rb @@ -5,8 +5,6 @@ class UltimaUG200SequencingRequest < SequencingRequest include Api::Messages::UseqWaferIo::LaneExtensions - WAFER_SIZE_OPTIONS = %w[5TB 10TB 20TB].freeze - has_metadata as: Request do # Defining the sequencing request metadata here again, as 'has_metadata' # does not automatically append these custom attributes to the request. @@ -23,9 +21,9 @@ class UltimaUG200SequencingRequest < SequencingRequest custom_attribute(:fragment_size_required_from, integer: true, minimum: 1) custom_attribute(:fragment_size_required_to, integer: true, minimum: 1) - # TODO: the defaults set here do NOT work on the option lists in screens for some reason. - custom_attribute(:wafer_size, default: '10TB', in: WAFER_SIZE_OPTIONS, required: true) - enum :wafer_size, { '5TB': 0, '10TB': 1, '20TB': 2 } + # TODO: the defaults set here do NOT work on the option lists in the bulk submission screen, + # but do work on the request additional sequencing screen for some reason. + custom_attribute(:wafer_size, default: '10TB', validator: true, required: true, selection: true) custom_attribute(:read_length, default: 300, integer: true, validator: true, required: true, selection: true) end @@ -39,8 +37,6 @@ class UltimaUG200RequestOptionsValidator < DelegateValidation::Validator validate :validate_read_length_by_wafer_size def validate_read_length_by_wafer_size - puts "Wafer Size: #{wafer_size}, Read Length: #{read_length}" - binding.pry return if wafer_size == '10TB' && read_length.to_i == 300 errors.add(:read_length, diff --git a/app/validators/ultima_ug200_validator.rb b/app/validators/ultima_ug200_validator.rb new file mode 100644 index 0000000000..ed2b32eb9d --- /dev/null +++ b/app/validators/ultima_ug200_validator.rb @@ -0,0 +1,23 @@ +# frozen_string_literal: true +class UltimaUG200Validator < UltimaValidator + WAFER_SIZE_CONSISTENT_MSG = 'Wafer size must be the same for both requests.' + + # Used in _pipeline_limit.html to display custom validation warnings + def self.validation_info + 'Wafer Size must be the same for both requests.' + end + + # Validates that a batch contains the two requests. + def validate(record) + validate_exactly_two_requests(record) + requests_have_same_wafer_size(record) + end + + private + + def requests_have_same_wafer_size(record) + return if record.pipeline.wafer_size_consistent_for_batch?(record) + + record.errors.add(:base, WAFER_SIZE_CONSISTENT_MSG) + end +end diff --git a/app/validators/ultima_validator.rb b/app/validators/ultima_validator.rb index 302e4a5829..bc69826792 100644 --- a/app/validators/ultima_validator.rb +++ b/app/validators/ultima_validator.rb @@ -2,18 +2,16 @@ class UltimaValidator < ActiveModel::Validator TWO_REQUESTS_MSG = 'Batches must contain exactly two requests.' OT_RECIPE_CONSISTENT_MSG = 'OT Recipe must be the same for both requests.' - WAFER_SIZE_CONSISTENT_MSG = 'Wafer size must be the same for both requests.' # Used in _pipeline_limit.html to display custom validation warnings def self.validation_info - 'OT Recipe and Wafer Size must be the same for both requests.' + 'OT Recipe must be the same for both requests.' end # Validates that a batch contains the two requests. def validate(record) validate_exactly_two_requests(record) requests_have_same_ot_recipe(record) - requests_have_same_wafer_size(record) end private @@ -29,10 +27,4 @@ def requests_have_same_ot_recipe(record) record.errors.add(:base, OT_RECIPE_CONSISTENT_MSG) end - - def requests_have_same_wafer_size(record) - return if record.pipeline.wafer_size_consistent_for_batch?(record) - - record.errors.add(:base, WAFER_SIZE_CONSISTENT_MSG) - end end diff --git a/config/default_records/pipeline_request_information_types/004_ultima_ug200_pipeline_request_information_types.yml b/config/default_records/pipeline_request_information_types/004_ultima_ug200_pipeline_request_information_types.yml new file mode 100644 index 0000000000..ca846cb34c --- /dev/null +++ b/config/default_records/pipeline_request_information_types/004_ultima_ug200_pipeline_request_information_types.yml @@ -0,0 +1,17 @@ +--- +FragmentSizeRequiredFromInformationTypeForUltimaUG200: + pipeline_name: Ultima UG200 + request_information_type_key: fragment_size_required_from + +FragmentSizeRequiredToInformationTypeForUltimaUG200: + pipeline_name: Ultima UG200 + request_information_type_key: fragment_size_required_to + +WaferSizeInformationTypeForUltimaUG200: + pipeline_name: Ultima UG200 + request_information_type_key: wafer_size + +# TODO: does readlength need to be here +ReadLengthInformationTypeForUltimaUG200: + pipeline_name: Ultima UG200 + request_information_type_key: read_length diff --git a/config/default_records/pipelines/004_ultima_ug200_pipelines.yml b/config/default_records/pipelines/004_ultima_ug200_pipelines.yml new file mode 100644 index 0000000000..21b128df05 --- /dev/null +++ b/config/default_records/pipelines/004_ultima_ug200_pipelines.yml @@ -0,0 +1,17 @@ +--- +Ultima UG200: + name: Ultima UG200 Sequencing + sti_type: UltimaUG200SequencingPipeline + validator_class_name: UltimaUG200Validator + sorter: 10 + max_size: 2 + summary: 1 + externally_managed: 0 + group_name: Sequencing + control_request_type_id: 0 + min_size: 1 + request_type_keys: + - ultima_ug200_sequencing + workflow: + name: Ultima UG200 + item_limit: 2 diff --git a/config/default_records/request_information_types/003_ultima_request_information_types.yml b/config/default_records/request_information_types/003_ultima_request_information_types.yml index 6fa20cb84e..39cabd99c3 100644 --- a/config/default_records/request_information_types/003_ultima_request_information_types.yml +++ b/config/default_records/request_information_types/003_ultima_request_information_types.yml @@ -6,13 +6,6 @@ ot_recipe: width: 5 hide_in_inbox: 0 -wafer_size: - name: Wafer size - key: wafer_size - label: Wafer size - width: 5 - hide_in_inbox: 0 - fragment_size_required_from: name: Fragment size required (from) key: fragment_size_required_from diff --git a/config/default_records/request_information_types/004_ultima_ug200_request_information_types.yml b/config/default_records/request_information_types/004_ultima_ug200_request_information_types.yml new file mode 100644 index 0000000000..bde23fdb31 --- /dev/null +++ b/config/default_records/request_information_types/004_ultima_ug200_request_information_types.yml @@ -0,0 +1,7 @@ +--- +wafer_size: + name: Wafer size + key: wafer_size + label: Wafer size + width: 5 + hide_in_inbox: 0 diff --git a/config/default_records/request_type_validators/003_ultima_request_type_validators.yml b/config/default_records/request_type_validators/003_ultima_ug200_request_type_validators.yml similarity index 72% rename from config/default_records/request_type_validators/003_ultima_request_type_validators.yml rename to config/default_records/request_type_validators/003_ultima_ug200_request_type_validators.yml index 8226313081..cf37fb6f84 100644 --- a/config/default_records/request_type_validators/003_ultima_request_type_validators.yml +++ b/config/default_records/request_type_validators/003_ultima_ug200_request_type_validators.yml @@ -1,13 +1,13 @@ --- WaferSizeRequestedUltimaUG200Sequencing: - request_type_key: ultima_u_g_200_sequencing + request_type_key: ultima_ug200_sequencing request_option: wafer_size valid_options: - 5TB - 10TB - 20TB ReadLengthRequestedUltimaUG200Sequencing: - request_type_key: ultima_u_g_200_sequencing + request_type_key: ultima_ug200_sequencing request_option: read_length valid_options: - 150 diff --git a/config/default_records/request_types/026_ultima_ug200_request_types.yml b/config/default_records/request_types/026_ultima_ug200_request_types.yml index 35581520fd..99dbf035b3 100644 --- a/config/default_records/request_types/026_ultima_ug200_request_types.yml +++ b/config/default_records/request_types/026_ultima_ug200_request_types.yml @@ -1,11 +1,12 @@ # Request types for Ultima UG200 sequencing platform. --- -ultima_u_g_200_sequencing: +ultima_ug200_sequencing: name: Ultima UG200 sequencing asset_type: LibraryTube order: 2 initial_state: pending billable: true + # Using same product line name as Ultima UG100 product_line_name: Ultima request_class_name: UltimaUG200SequencingRequest request_purpose: standard diff --git a/config/default_records/submission_templates/021_ultima_ug200_submission_templates.yml b/config/default_records/submission_templates/021_ultima_ug200_submission_templates.yml index 27b6a6a6b7..cec0787649 100644 --- a/config/default_records/submission_templates/021_ultima_ug200_submission_templates.yml +++ b/config/default_records/submission_templates/021_ultima_ug200_submission_templates.yml @@ -4,7 +4,15 @@ Limber-Htp - Ultima PCR Free - Ultima UG200 sequencing: submission_class_name: "LinearSubmission" related_records: - request_type_keys: ["limber_ultima_htp_pcr_free", "limber_multiplexing_ultima", "ultima_u_g_200_sequencing"] + request_type_keys: ["limber_ultima_htp_pcr_free", "limber_multiplexing_ultima", "ultima_ug200_sequencing"] + order_role: PCR Free + product_line_name: Ultima + product_catalogue_name: GenericNoPCR +# TODO: assumption that we need automated version for UG200, but is this the case? +Limber-Htp - Ultima PCR Free - Ultima UG200 sequencing Automated: + submission_class_name: "LinearSubmission" + related_records: + request_type_keys: ["ultima_ug200_sequencing"] order_role: PCR Free product_line_name: Ultima product_catalogue_name: GenericNoPCR diff --git a/config/initializers/inflections.rb b/config/initializers/inflections.rb index 55a6a2b9bd..984e1a1a24 100644 --- a/config/initializers/inflections.rb +++ b/config/initializers/inflections.rb @@ -18,6 +18,7 @@ inflect.acronym 'ENA' # European Nucleotide Archive inflect.acronym 'HTTP' # HyperText Transfer Protocol inflect.acronym 'EBI' # European Bioinformatics Institute + inflect.acronym 'UG200' # Ultima UG200 end # These inflection rules are supported but not enabled by default: diff --git a/config/locales/metadata/en.yml b/config/locales/metadata/en.yml index 1cee050a2e..da8fa0683b 100644 --- a/config/locales/metadata/en.yml +++ b/config/locales/metadata/en.yml @@ -110,6 +110,9 @@ en: ultima_sequencing_request: <<: *REQUEST + ultima_ug200_sequencing_request: + <<: *REQUEST + pulldown: requests: wgs_library_request: diff --git a/spec/factories/request_factories.rb b/spec/factories/request_factories.rb index fcb9e714a8..622aa97d85 100644 --- a/spec/factories/request_factories.rb +++ b/spec/factories/request_factories.rb @@ -124,8 +124,8 @@ end end - factory(:ultima_u_g_200_sequencing_request) do - request_type factory: %i[ultima_u_g_200_sequencing] + factory(:ultima_ug200_sequencing_request) do + request_type factory: %i[ultima_ug200_sequencing] request_purpose { :standard } sti_type { 'UltimaUG200SequencingRequest' } request_metadata_attributes do diff --git a/spec/factories/request_type_factories.rb b/spec/factories/request_type_factories.rb index 536c7ad123..87b2fecfd4 100644 --- a/spec/factories/request_type_factories.rb +++ b/spec/factories/request_type_factories.rb @@ -139,7 +139,7 @@ request_class { UltimaSequencingRequest } end - factory :ultima_u_g_200_sequencing do + factory :ultima_ug200_sequencing do asset_type { 'LibraryTube' } request_class { UltimaUG200SequencingRequest } end diff --git a/spec/models/ultima_ug200_sequencing_request_spec.rb b/spec/models/ultima_ug200_sequencing_request_spec.rb index 424e4020cb..d1163868ee 100644 --- a/spec/models/ultima_ug200_sequencing_request_spec.rb +++ b/spec/models/ultima_ug200_sequencing_request_spec.rb @@ -3,7 +3,7 @@ require 'rails_helper' RSpec.describe UltimaUG200SequencingRequest do - let(:request) { create(:ultima_u_g_200_sequencing_request) } + let(:request) { create(:ultima_ug200_sequencing_request) } describe 'Validations' do context 'when all attributes are valid' do From 2d737b3aff173e3e88d3675f19acae11f7bca4c3 Mon Sep 17 00:00:00 2001 From: Andrew Sparkes Date: Wed, 25 Mar 2026 14:58:53 +0000 Subject: [PATCH 05/29] added UG200 task descriptors (draft may change) --- .../005_ultima_ug200_descriptors.yml | 85 +++++++++++++++++++ .../tasks/005_ultima_ug200_tasks.yml | 13 +++ 2 files changed, 98 insertions(+) create mode 100644 config/default_records/descriptors/005_ultima_ug200_descriptors.yml create mode 100644 config/default_records/tasks/005_ultima_ug200_tasks.yml diff --git a/config/default_records/descriptors/005_ultima_ug200_descriptors.yml b/config/default_records/descriptors/005_ultima_ug200_descriptors.yml new file mode 100644 index 0000000000..d5c77bcb3e --- /dev/null +++ b/config/default_records/descriptors/005_ultima_ug200_descriptors.yml @@ -0,0 +1,85 @@ +--- +"OTR carrier Lot #": + name: "OTR carrier Lot #" + task: Opentrons + workflow: Ultima UG200 + kind: Text + required: false + sorter: 0 +OTR carrier expiry: + name: OTR carrier expiry + task: Opentrons + workflow: Ultima UG200 + kind: Date + required: false + sorter: 1 +"Reaction Mix 7 Lot #": + name: "Reaction Mix 7 Lot #" + task: Opentrons + workflow: Ultima UG200 + kind: Text + required: false + sorter: 2 +Reaction Mix 7 expiry: + name: Reaction Mix 7 expiry + task: Opentrons + workflow: Ultima UG200 + kind: Date + required: false + sorter: 3 +"NFW Lot #": + name: "NFW Lot #" + task: Opentrons + workflow: Ultima UG200 + kind: Text + required: false + sorter: 4 +NFW expiry: + name: NFW expiry + task: Opentrons + workflow: Ultima UG200 + kind: Date + required: false + sorter: 5 +"Oil Lot #": + name: "Oil Lot #" + task: Opentrons + workflow: Ultima UG200 + kind: Text + required: false + sorter: 6 +Oil expiry: + name: Oil expiry + task: Opentrons + workflow: Ultima UG200 + kind: Date + required: false + sorter: 7 +Pipette carousel: + name: Pipette carousel + task: Opentrons + workflow: Ultima UG200 + kind: Text + required: false + sorter: 8 +Opentrons Inst. Name: + name: Opentrons Inst. Name + task: Opentrons + workflow: Ultima UG200 + kind: Text + required: true + sorter: 9 +Assign Control Bead Tube: + name: Assign Control Bead Tube + task: Amp + workflow: Ultima UG200 + kind: Text + required: false + sorter: 0 +UG AMP Inst. Name: + name: UG AMP Inst. Name + task: Amp + workflow: Ultima UG200 + kind: Text + required: true + sorter: 1 diff --git a/config/default_records/tasks/005_ultima_ug200_tasks.yml b/config/default_records/tasks/005_ultima_ug200_tasks.yml new file mode 100644 index 0000000000..c031066648 --- /dev/null +++ b/config/default_records/tasks/005_ultima_ug200_tasks.yml @@ -0,0 +1,13 @@ +--- +Opentrons: + name: Opentrons + workflow: Ultima UG200 + sorted: 0 + lab_activity: true + sti_type: SetDescriptorsTask +Amp: + name: Amp + workflow: Ultima UG200 + sorted: 1 + lab_activity: true + sti_type: SetDescriptorsTask From 4a746a7f82eea621959b1744a670ade19e2895aa Mon Sep 17 00:00:00 2001 From: Andrew Sparkes Date: Wed, 25 Mar 2026 15:27:58 +0000 Subject: [PATCH 06/29] fixed tests --- spec/models/ultima_sequencing_request_spec.rb | 8 -------- .../ultima_ug200_sequencing_request_spec.rb | 16 ++++++++-------- 2 files changed, 8 insertions(+), 16 deletions(-) diff --git a/spec/models/ultima_sequencing_request_spec.rb b/spec/models/ultima_sequencing_request_spec.rb index b990cbb89d..d152679b4e 100644 --- a/spec/models/ultima_sequencing_request_spec.rb +++ b/spec/models/ultima_sequencing_request_spec.rb @@ -39,13 +39,5 @@ expect(request.errors[:'request_metadata.ot_recipe']).to include("can't be blank") end end - - context 'when wafer_size value is not assigned' do - it 'is invalid and displays required wafer size error message' do - request.request_metadata.wafer_size = nil - request.validate - expect(request.errors[:'request_metadata.wafer_size']).to include("can't be blank") - end - end end end diff --git a/spec/models/ultima_ug200_sequencing_request_spec.rb b/spec/models/ultima_ug200_sequencing_request_spec.rb index d1163868ee..b0b2696b46 100644 --- a/spec/models/ultima_ug200_sequencing_request_spec.rb +++ b/spec/models/ultima_ug200_sequencing_request_spec.rb @@ -32,14 +32,6 @@ end end - context 'when ot_recipe value is not assigned' do - it 'is invalid and displays required percent phix requested error message' do - request.request_metadata.ot_recipe = nil - request.validate - expect(request.errors[:'request_metadata.ot_recipe']).to include("can't be blank") - end - end - context 'when wafer_size value is not assigned' do it 'is invalid and displays required wafer size error message' do request.request_metadata.wafer_size = nil @@ -47,5 +39,13 @@ expect(request.errors[:'request_metadata.wafer_size']).to include("can't be blank") end end + + context 'when read_length value is not assigned' do + it 'is invalid and displays required read length error message' do + request.request_metadata.read_length = nil + request.validate + expect(request.errors[:'request_metadata.read_length']).to include("can't be blank") + end + end end end From 16e939c4367e114876495c4ef2e8d03cdd5980c1 Mon Sep 17 00:00:00 2001 From: Andrew Sparkes Date: Wed, 25 Mar 2026 16:32:16 +0000 Subject: [PATCH 07/29] fixed tests --- .../models/ultima_sequencing_pipeline_spec.rb | 29 ------------ .../ultima_ug200_sequencing_pipeline_spec.rb | 46 +++++++++++++++++++ 2 files changed, 46 insertions(+), 29 deletions(-) create mode 100644 spec/models/ultima_ug200_sequencing_pipeline_spec.rb diff --git a/spec/models/ultima_sequencing_pipeline_spec.rb b/spec/models/ultima_sequencing_pipeline_spec.rb index 99cd6dca05..9e55c1018e 100644 --- a/spec/models/ultima_sequencing_pipeline_spec.rb +++ b/spec/models/ultima_sequencing_pipeline_spec.rb @@ -38,35 +38,6 @@ end end - describe '#wafer_size_consistent_for_batch?' do - it 'returns true when all requests have the same wafer_size' do - batch = pipeline.batches.build - r1 = create(:ultima_sequencing_request, request_metadata_attributes: { wafer_size: '10TB' }) - r2 = create(:ultima_sequencing_request, request_metadata_attributes: { wafer_size: '10TB' }) - batch.requests << [r1, r2] - - expect(pipeline.wafer_size_consistent_for_batch?(batch)).to be true - end - - it 'returns false when requests have different wafer_sizes' do - batch = pipeline.batches.build - req1 = create(:ultima_sequencing_request, request_metadata_attributes: { wafer_size: '5TB' }) - req2 = create(:ultima_sequencing_request, request_metadata_attributes: { wafer_size: '10TB' }) - batch.requests << [req1, req2] - - expect(pipeline.wafer_size_consistent_for_batch?(batch)).to be false - end - - it 'returns false when some requests are missing wafer_size' do - batch = pipeline.batches.build - r1 = create(:sequencing_request, request_metadata_attributes: { wafer_size: '10TB' }) - r2 = create(:sequencing_request, request_metadata_attributes: {}) # no wafer_size - batch.requests << [r1, r2] - - expect(pipeline.wafer_size_consistent_for_batch?(batch)).to be false - end - end - describe '#post_release_batch' do let(:batch) { create(:batch) } diff --git a/spec/models/ultima_ug200_sequencing_pipeline_spec.rb b/spec/models/ultima_ug200_sequencing_pipeline_spec.rb new file mode 100644 index 0000000000..1f792086cd --- /dev/null +++ b/spec/models/ultima_ug200_sequencing_pipeline_spec.rb @@ -0,0 +1,46 @@ +# frozen_string_literal: true +require 'rails_helper' + +RSpec.describe UltimaUG200SequencingPipeline do + let(:pipeline) do + described_class.new( + workflow: Workflow.new, + request_types: [create(:ultima_ug200_sequencing)] + ) + end + + describe '#wafer_size_consistent_for_batch?' do + it 'returns true when all requests have the same wafer_size' do + batch = pipeline.batches.build + r1 = create(:ultima_ug200_sequencing_request, request_metadata_attributes: { wafer_size: '10TB' }) + r2 = create(:ultima_ug200_sequencing_request, request_metadata_attributes: { wafer_size: '10TB' }) + batch.requests << [r1, r2] + + expect(pipeline.wafer_size_consistent_for_batch?(batch)).to be true + end + + it 'returns false when requests have different wafer_sizes' do + batch = pipeline.batches.build + req1 = create(:ultima_ug200_sequencing_request, request_metadata_attributes: { wafer_size: '5TB' }) + req2 = create(:ultima_ug200_sequencing_request, request_metadata_attributes: { wafer_size: '10TB' }) + batch.requests << [req1, req2] + + expect(pipeline.wafer_size_consistent_for_batch?(batch)).to be false + end + + # NB. Wafer size is a required field, so cannot be missing. Tested in the request spec. + end + + describe '#post_release_batch' do + let(:batch) { create(:batch) } + + it 'calls Messenger with UseqWaferIo template and useq_wafer root' do + allow(Messenger).to receive(:create!) + pipeline.post_release_batch(batch, create(:user)) + + expect(Messenger).to have_received(:create!).with( + hash_including(target: batch, template: 'UseqWaferIo', root: 'useq_wafer') + ) + end + end +end From a988ce72f10710ad0e69745a6cc9cbefe2c0826a Mon Sep 17 00:00:00 2001 From: Andrew Sparkes Date: Fri, 27 Mar 2026 14:37:10 +0000 Subject: [PATCH 08/29] modified ug200 sequencing request to remove read length and add ot recipe --- app/models/ultima_ug200_sequencing_request.rb | 28 +++++------------- ...200_pipeline_request_information_types.yml | 7 ++--- ...3_ultima_ug200_request_type_validators.yml | 7 ----- spec/factories/request_factories.rb | 2 +- .../ultima_ug200_sequencing_pipeline_spec.rb | 29 +++++++++++++++++++ 5 files changed, 41 insertions(+), 32 deletions(-) diff --git a/app/models/ultima_ug200_sequencing_request.rb b/app/models/ultima_ug200_sequencing_request.rb index 2f7b569f91..0587f149dc 100644 --- a/app/models/ultima_ug200_sequencing_request.rb +++ b/app/models/ultima_ug200_sequencing_request.rb @@ -1,10 +1,14 @@ # frozen_string_literal: true # Request class specific to the Ultima UG200 sequencing platform. -# Includes specific validation for wafer combination with read type. +# Includes wafer size and OT recipe. class UltimaUG200SequencingRequest < SequencingRequest include Api::Messages::UseqWaferIo::LaneExtensions + FREE = 'Free' + FLEX = 'Flex' + OT_RECIPE_OPTIONS = [FREE, FLEX].freeze + has_metadata as: Request do # Defining the sequencing request metadata here again, as 'has_metadata' # does not automatically append these custom attributes to the request. @@ -23,30 +27,14 @@ class UltimaUG200SequencingRequest < SequencingRequest # TODO: the defaults set here do NOT work on the option lists in the bulk submission screen, # but do work on the request additional sequencing screen for some reason. + custom_attribute(:ot_recipe, default: FREE, in: OT_RECIPE_OPTIONS, required: true) + enum :ot_recipe, { Free: 0, Flex: 1 } custom_attribute(:wafer_size, default: '10TB', validator: true, required: true, selection: true) - custom_attribute(:read_length, default: 300, integer: true, validator: true, required: true, selection: true) end # Delegate to request_metadata so the attributes are visible to the validator in the RSpec tests. # This delegation has no real effect outside of the tests. - delegate :wafer_size, :read_length, to: :request_metadata - - class UltimaUG200RequestOptionsValidator < DelegateValidation::Validator - delegate :wafer_size, :read_length, :request_types, to: :target - - validate :validate_read_length_by_wafer_size - - def validate_read_length_by_wafer_size - return if wafer_size == '10TB' && read_length.to_i == 300 - - errors.add(:read_length, - 'The user can only select a Read Length of 300 with the 10TB wafer type for Ultima UG200 requests') - end - end - - def self.delegate_validator - UltimaUG200SequencingRequest::UltimaUG200RequestOptionsValidator - end + delegate :wafer_size, :ot_recipe, to: :request_metadata # Generates unique wafer ID, concatenation of batch_for_opentrons, # id_pool_lims, and request_order. diff --git a/config/default_records/pipeline_request_information_types/004_ultima_ug200_pipeline_request_information_types.yml b/config/default_records/pipeline_request_information_types/004_ultima_ug200_pipeline_request_information_types.yml index ca846cb34c..e39f735c93 100644 --- a/config/default_records/pipeline_request_information_types/004_ultima_ug200_pipeline_request_information_types.yml +++ b/config/default_records/pipeline_request_information_types/004_ultima_ug200_pipeline_request_information_types.yml @@ -11,7 +11,6 @@ WaferSizeInformationTypeForUltimaUG200: pipeline_name: Ultima UG200 request_information_type_key: wafer_size -# TODO: does readlength need to be here -ReadLengthInformationTypeForUltimaUG200: - pipeline_name: Ultima UG200 - request_information_type_key: read_length +OTRecipeInformationTypeForUltima: + pipeline_name: Ultima + request_information_type_key: ot_recipe diff --git a/config/default_records/request_type_validators/003_ultima_ug200_request_type_validators.yml b/config/default_records/request_type_validators/003_ultima_ug200_request_type_validators.yml index cf37fb6f84..028e593253 100644 --- a/config/default_records/request_type_validators/003_ultima_ug200_request_type_validators.yml +++ b/config/default_records/request_type_validators/003_ultima_ug200_request_type_validators.yml @@ -6,10 +6,3 @@ WaferSizeRequestedUltimaUG200Sequencing: - 5TB - 10TB - 20TB -ReadLengthRequestedUltimaUG200Sequencing: - request_type_key: ultima_ug200_sequencing - request_option: read_length - valid_options: - - 150 - - 200 - - 300 diff --git a/spec/factories/request_factories.rb b/spec/factories/request_factories.rb index 622aa97d85..ad180e5d76 100644 --- a/spec/factories/request_factories.rb +++ b/spec/factories/request_factories.rb @@ -132,7 +132,7 @@ { fragment_size_required_from: 150, fragment_size_required_to: 400, - read_length: 300, + ot_recipe: 'Free', wafer_size: '10TB' } end diff --git a/spec/models/ultima_ug200_sequencing_pipeline_spec.rb b/spec/models/ultima_ug200_sequencing_pipeline_spec.rb index 1f792086cd..361bce75a5 100644 --- a/spec/models/ultima_ug200_sequencing_pipeline_spec.rb +++ b/spec/models/ultima_ug200_sequencing_pipeline_spec.rb @@ -9,6 +9,35 @@ ) end + describe '#ot_recipe_consistent_for_batch?' do + it 'returns true when all requests have the same ot_recipe' do + batch = pipeline.batches.build + r1 = create(:ultima_ug200_sequencing_request, request_metadata_attributes: { ot_recipe: 'Free' }) + r2 = create(:ultima_ug200_sequencing_request, request_metadata_attributes: { ot_recipe: 'Free' }) + batch.requests << [r1, r2] + + expect(pipeline.ot_recipe_consistent_for_batch?(batch)).to be true + end + + it 'returns false when requests have different ot_recipes' do + batch = pipeline.batches.build + req1 = create(:ultima_ug200_sequencing_request, request_metadata_attributes: { ot_recipe: 'Free' }) + req2 = create(:ultima_ug200_sequencing_request, request_metadata_attributes: { ot_recipe: 'Flex' }) + batch.requests << [req1, req2] + + expect(pipeline.ot_recipe_consistent_for_batch?(batch)).to be false + end + + it 'returns false when some requests are missing ot_recipe' do + batch = pipeline.batches.build + r1 = create(:sequencing_request, request_metadata_attributes: { ot_recipe: 'Free' }) + r2 = create(:sequencing_request, request_metadata_attributes: {}) # no ot_recipe + batch.requests << [r1, r2] + + expect(pipeline.ot_recipe_consistent_for_batch?(batch)).to be false + end + end + describe '#wafer_size_consistent_for_batch?' do it 'returns true when all requests have the same wafer_size' do batch = pipeline.batches.build From 72a640df53b92856116cf4408cfc85934a469cb4 Mon Sep 17 00:00:00 2001 From: Andrew Sparkes Date: Fri, 27 Mar 2026 14:42:09 +0000 Subject: [PATCH 09/29] wip the submission template yml --- ...mplates.yml => 021_ultima_ug200_submission_templates.wip.yml} | 1 - 1 file changed, 1 deletion(-) rename config/default_records/submission_templates/{021_ultima_ug200_submission_templates.yml => 021_ultima_ug200_submission_templates.wip.yml} (89%) diff --git a/config/default_records/submission_templates/021_ultima_ug200_submission_templates.yml b/config/default_records/submission_templates/021_ultima_ug200_submission_templates.wip.yml similarity index 89% rename from config/default_records/submission_templates/021_ultima_ug200_submission_templates.yml rename to config/default_records/submission_templates/021_ultima_ug200_submission_templates.wip.yml index cec0787649..e5b5363585 100644 --- a/config/default_records/submission_templates/021_ultima_ug200_submission_templates.yml +++ b/config/default_records/submission_templates/021_ultima_ug200_submission_templates.wip.yml @@ -8,7 +8,6 @@ Limber-Htp - Ultima PCR Free - Ultima UG200 sequencing: order_role: PCR Free product_line_name: Ultima product_catalogue_name: GenericNoPCR -# TODO: assumption that we need automated version for UG200, but is this the case? Limber-Htp - Ultima PCR Free - Ultima UG200 sequencing Automated: submission_class_name: "LinearSubmission" related_records: From ac9574d42fb0d3b52e2e22feab308f667783d710 Mon Sep 17 00:00:00 2001 From: Andrew Sparkes Date: Fri, 27 Mar 2026 17:01:50 +0000 Subject: [PATCH 10/29] for ug200 changed readlength for ot recipe --- app/validators/ultima_ug200_validator.rb | 10 +++++++++- spec/models/ultima_ug200_sequencing_request_spec.rb | 8 ++++---- 2 files changed, 13 insertions(+), 5 deletions(-) diff --git a/app/validators/ultima_ug200_validator.rb b/app/validators/ultima_ug200_validator.rb index ed2b32eb9d..1dc5c9889e 100644 --- a/app/validators/ultima_ug200_validator.rb +++ b/app/validators/ultima_ug200_validator.rb @@ -1,15 +1,17 @@ # frozen_string_literal: true class UltimaUG200Validator < UltimaValidator WAFER_SIZE_CONSISTENT_MSG = 'Wafer size must be the same for both requests.' + OT_RECIPE_CONSISTENT_MSG = 'OT Recipe must be the same for both requests.' # Used in _pipeline_limit.html to display custom validation warnings def self.validation_info - 'Wafer Size must be the same for both requests.' + 'Wafer Size and OT Recipe must be the same for both requests.' end # Validates that a batch contains the two requests. def validate(record) validate_exactly_two_requests(record) + requests_have_same_ot_recipe(record) requests_have_same_wafer_size(record) end @@ -20,4 +22,10 @@ def requests_have_same_wafer_size(record) record.errors.add(:base, WAFER_SIZE_CONSISTENT_MSG) end + + def requests_have_same_ot_recipe(record) + return if record.pipeline.ot_recipe_consistent_for_batch?(record) + + record.errors.add(:base, OT_RECIPE_CONSISTENT_MSG) + end end diff --git a/spec/models/ultima_ug200_sequencing_request_spec.rb b/spec/models/ultima_ug200_sequencing_request_spec.rb index b0b2696b46..a87bc38fd2 100644 --- a/spec/models/ultima_ug200_sequencing_request_spec.rb +++ b/spec/models/ultima_ug200_sequencing_request_spec.rb @@ -40,11 +40,11 @@ end end - context 'when read_length value is not assigned' do - it 'is invalid and displays required read length error message' do - request.request_metadata.read_length = nil + context 'when ot_recipe value is not assigned' do + it 'is invalid and displays required OT recipe error message' do + request.request_metadata.ot_recipe = nil request.validate - expect(request.errors[:'request_metadata.read_length']).to include("can't be blank") + expect(request.errors[:'request_metadata.ot_recipe']).to include("can't be blank") end end end From 573135fa76790fcebbf04ce93b2382d06ced4633 Mon Sep 17 00:00:00 2001 From: Andrew Sparkes Date: Fri, 27 Mar 2026 17:05:19 +0000 Subject: [PATCH 11/29] fixed incorrect it text --- spec/models/ultima_sequencing_request_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/models/ultima_sequencing_request_spec.rb b/spec/models/ultima_sequencing_request_spec.rb index d152679b4e..3cbaa4864f 100644 --- a/spec/models/ultima_sequencing_request_spec.rb +++ b/spec/models/ultima_sequencing_request_spec.rb @@ -33,7 +33,7 @@ end context 'when ot_recipe value is not assigned' do - it 'is invalid and displays required percent phix requested error message' do + it 'is invalid and displays required OT recipe error message' do request.request_metadata.ot_recipe = nil request.validate expect(request.errors[:'request_metadata.ot_recipe']).to include("can't be blank") From 5dbd4a929eba9cea768464a7e8adb751f8bd4cd4 Mon Sep 17 00:00:00 2001 From: yoldas Date: Tue, 7 Apr 2026 13:23:30 +0100 Subject: [PATCH 12/29] test(validators): split UG200 checks into dedicated ultima_ug200 validator spec --- .../validators/ultima_ug200_validator_spec.rb | 61 +++++++++++++++++++ spec/validators/ultima_validator_spec.rb | 32 ---------- 2 files changed, 61 insertions(+), 32 deletions(-) create mode 100644 spec/validators/ultima_ug200_validator_spec.rb diff --git a/spec/validators/ultima_ug200_validator_spec.rb b/spec/validators/ultima_ug200_validator_spec.rb new file mode 100644 index 0000000000..34082981cb --- /dev/null +++ b/spec/validators/ultima_ug200_validator_spec.rb @@ -0,0 +1,61 @@ +# frozen_string_literal: true +require 'rails_helper' + +describe UltimaUG200Validator do + describe '#validate' do + subject(:validator) { described_class.new } + + let(:pipeline) { UltimaUG200SequencingPipeline.new } + let(:batch) { create(:batch, pipeline:) } + let(:requests) { [request1, request2] } + let(:request1_metadata) { { ot_recipe: 'Free', wafer_size: '10TB' } } + let(:request2_metadata) { { ot_recipe: 'Free', wafer_size: '10TB' } } + let(:request1) { create(:ultima_sequencing_request, request_metadata_attributes: request1_metadata) } + let(:request2) { create(:ultima_sequencing_request, request_metadata_attributes: request2_metadata) } + + before do + batch.requests << requests + end + + context 'when batch contains two requests with the same OT Recipe' do + it 'is valid' do + validator.validate(batch) + expect(batch.errors[:base]).to be_empty + end + end + + context 'when batch contains two requests with different ot_recipe' do + let(:request2_metadata) { { ot_recipe: 'Flex', wafer_size: '10TB' } } + + it 'is invalid due to ot_recipe mismatch' do + validator.validate(batch) + expect(batch.errors[:base]).to include(described_class::OT_RECIPE_CONSISTENT_MSG) + end + end + + context 'when batch contains two requests with the same Wafer Size' do + it 'is valid' do + validator.validate(batch) + expect(batch.errors[:base]).not_to include(described_class::WAFER_SIZE_CONSISTENT_MSG) + end + end + + context 'when batch contains two requests with different wafer_size' do + let(:request1_metadata) { { ot_recipe: 'Free', wafer_size: '5TB' } } + + it 'is invalid due to wafer_size mismatch' do + validator.validate(batch) + expect(batch.errors[:base]).to include(described_class::WAFER_SIZE_CONSISTENT_MSG) + end + end + + context 'when batch contains a single request' do + let(:requests) { [request1] } + + it 'is invalid' do + validator.validate(batch) + expect(batch.errors[:base]).to include(described_class::TWO_REQUESTS_MSG) + end + end + end +end diff --git a/spec/validators/ultima_validator_spec.rb b/spec/validators/ultima_validator_spec.rb index 1c1ad66aa5..c651ef2695 100644 --- a/spec/validators/ultima_validator_spec.rb +++ b/spec/validators/ultima_validator_spec.rb @@ -37,38 +37,6 @@ end end - context 'when batch contains two requests with the same Wafer Size' do - let(:pipeline) { UltimaSequencingPipeline.new } - let(:batch) { create(:batch, pipeline:) } - let(:request1) { create(:ultima_sequencing_request, request_metadata_attributes: { wafer_size: '10TB' }) } - let(:request2) { create(:ultima_sequencing_request, request_metadata_attributes: { wafer_size: '10TB' }) } - - before do - batch.requests << [request1, request2] - end - - it 'is valid' do - validator.validate(batch) - expect(batch.errors[:base]).to be_empty - end - end - - context 'when batch contains two requests with different wafer_size' do - let(:pipeline) { UltimaSequencingPipeline.new } - let(:batch) { create(:batch, pipeline:) } - let(:request1) { create(:ultima_sequencing_request, request_metadata_attributes: { wafer_size: '5TB' }) } - let(:request2) { create(:ultima_sequencing_request, request_metadata_attributes: { wafer_size: '10TB' }) } - - before do - batch.requests << [request1, request2] - end - - it 'is invalid due to wafer_size mismatch' do - validator.validate(batch) - expect(batch.errors[:base]).to include(described_class::WAFER_SIZE_CONSISTENT_MSG) - end - end - context 'when batch contains a single request' do let(:pipeline) { UltimaSequencingPipeline.new } let(:batch) { create(:batch, pipeline:) } From e8b64f2f24a36922c2f375a841576e269a814332 Mon Sep 17 00:00:00 2001 From: yoldas Date: Tue, 7 Apr 2026 13:53:43 +0100 Subject: [PATCH 13/29] fix(submissions): apply selection defaults for blank values --- app/helpers/submissions_helper.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/helpers/submissions_helper.rb b/app/helpers/submissions_helper.rb index 7e12703c8e..49bcc6e0b8 100644 --- a/app/helpers/submissions_helper.rb +++ b/app/helpers/submissions_helper.rb @@ -139,7 +139,8 @@ def submission_link(submission, options) def field_selection_tag(request_options, field_info, name_format, enforce_required) select_tag( name_format % field_info.key, - options_for_select(field_info.selection.map(&:to_s), request_options[field_info.key]), + options_for_select(field_info.selection.map(&:to_s), + request_options[field_info.key].presence || field_info.default_value), class: 'custom-select', required: enforce_required && field_info.required, read_only: field_info.selection.size == 1 From fcbcd9cefe078c76e6eb4c9c81ab9fa35352ed60 Mon Sep 17 00:00:00 2001 From: yoldas Date: Tue, 7 Apr 2026 13:55:13 +0100 Subject: [PATCH 14/29] docs(remove todo commit about selection defaults) --- app/models/ultima_ug200_sequencing_request.rb | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/models/ultima_ug200_sequencing_request.rb b/app/models/ultima_ug200_sequencing_request.rb index 0587f149dc..0bed36c602 100644 --- a/app/models/ultima_ug200_sequencing_request.rb +++ b/app/models/ultima_ug200_sequencing_request.rb @@ -25,8 +25,6 @@ class UltimaUG200SequencingRequest < SequencingRequest custom_attribute(:fragment_size_required_from, integer: true, minimum: 1) custom_attribute(:fragment_size_required_to, integer: true, minimum: 1) - # TODO: the defaults set here do NOT work on the option lists in the bulk submission screen, - # but do work on the request additional sequencing screen for some reason. custom_attribute(:ot_recipe, default: FREE, in: OT_RECIPE_OPTIONS, required: true) enum :ot_recipe, { Free: 0, Flex: 1 } custom_attribute(:wafer_size, default: '10TB', validator: true, required: true, selection: true) From bd33b3a680191dfa7007fbbf94d0197a6e6fde31 Mon Sep 17 00:00:00 2001 From: yoldas Date: Tue, 7 Apr 2026 13:55:49 +0100 Subject: [PATCH 15/29] test(submissions): apply selection defaults for blank values --- spec/helpers/submissions_helper_spec.rb | 47 +++++++++++++++++++++++++ 1 file changed, 47 insertions(+) create mode 100644 spec/helpers/submissions_helper_spec.rb diff --git a/spec/helpers/submissions_helper_spec.rb b/spec/helpers/submissions_helper_spec.rb new file mode 100644 index 0000000000..5e5101c42c --- /dev/null +++ b/spec/helpers/submissions_helper_spec.rb @@ -0,0 +1,47 @@ +# frozen_string_literal: true + +require 'rails_helper' + +describe SubmissionsHelper do + describe '#field_input_tag' do + let(:field_info) do + double( + kind: 'Selection', + key: :ot_recipe, + selection: %w[Free Flex], + default_value: 'Free', + required: true + ) + end + + let(:wafer_size_field_info) do + double( + kind: 'Selection', + key: :wafer_size, + selection: %w[5TB 10TB], + default_value: '10TB', + required: true + ) + end + + it 'uses the default value for selection fields when no request option is set' do + html = helper.field_input_tag(field_info, values: {}, name_format: 'submission[order_params][%s]') + + expect(html).to include('') + end + + it 'uses the default value for selection fields when request option is blank' do + html = helper.field_input_tag(field_info, values: { ot_recipe: '' }, name_format: 'submission[order_params][%s]') + + expect(html).to include('') + end + + it 'uses the default wafer_size when request option is blank' do + html = helper.field_input_tag(wafer_size_field_info, + values: { wafer_size: '' }, + name_format: 'submission[order_params][%s]') + + expect(html).to include('') + end + end +end From ac0602bc4d83ccb05b469b5dc300dd2681457443 Mon Sep 17 00:00:00 2001 From: yoldas Date: Tue, 7 Apr 2026 14:03:30 +0100 Subject: [PATCH 16/29] fix(records): correct OTRecipeInformationTypeForUltimaUG200 association --- .../004_ultima_ug200_pipeline_request_information_types.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/config/default_records/pipeline_request_information_types/004_ultima_ug200_pipeline_request_information_types.yml b/config/default_records/pipeline_request_information_types/004_ultima_ug200_pipeline_request_information_types.yml index e39f735c93..76a81c2576 100644 --- a/config/default_records/pipeline_request_information_types/004_ultima_ug200_pipeline_request_information_types.yml +++ b/config/default_records/pipeline_request_information_types/004_ultima_ug200_pipeline_request_information_types.yml @@ -11,6 +11,6 @@ WaferSizeInformationTypeForUltimaUG200: pipeline_name: Ultima UG200 request_information_type_key: wafer_size -OTRecipeInformationTypeForUltima: - pipeline_name: Ultima +OTRecipeInformationTypeForUltimaUG200: + pipeline_name: Ultima UG200 request_information_type_key: ot_recipe From 7a2d52d348acd09c540d6dd4ae9bfde10bff9953 Mon Sep 17 00:00:00 2001 From: yoldas Date: Tue, 7 Apr 2026 16:30:14 +0100 Subject: [PATCH 17/29] chore(records): rename ultima_ug200 files to wip --- ...ug200_descriptors.yml => 005_ultima_ug200_descriptors.wip.yml} | 0 ...> 004_ultima_ug200_pipeline_request_information_types.wip.yml} | 0 ...ima_ug200_pipelines.yml => 004_ultima_ug200_pipelines.wip.yml} | 0 ...pes.yml => 004_ultima_ug200_request_information_types.wip.yml} | 0 ...ators.yml => 003_ultima_ug200_request_type_validators.wip.yml} | 0 ...0_request_types.yml => 026_ultima_ug200_request_types.wip.yml} | 0 ...{005_ultima_ug200_tasks.yml => 005_ultima_ug200_tasks.wip.yml} | 0 7 files changed, 0 insertions(+), 0 deletions(-) rename config/default_records/descriptors/{005_ultima_ug200_descriptors.yml => 005_ultima_ug200_descriptors.wip.yml} (100%) rename config/default_records/pipeline_request_information_types/{004_ultima_ug200_pipeline_request_information_types.yml => 004_ultima_ug200_pipeline_request_information_types.wip.yml} (100%) rename config/default_records/pipelines/{004_ultima_ug200_pipelines.yml => 004_ultima_ug200_pipelines.wip.yml} (100%) rename config/default_records/request_information_types/{004_ultima_ug200_request_information_types.yml => 004_ultima_ug200_request_information_types.wip.yml} (100%) rename config/default_records/request_type_validators/{003_ultima_ug200_request_type_validators.yml => 003_ultima_ug200_request_type_validators.wip.yml} (100%) rename config/default_records/request_types/{026_ultima_ug200_request_types.yml => 026_ultima_ug200_request_types.wip.yml} (100%) rename config/default_records/tasks/{005_ultima_ug200_tasks.yml => 005_ultima_ug200_tasks.wip.yml} (100%) diff --git a/config/default_records/descriptors/005_ultima_ug200_descriptors.yml b/config/default_records/descriptors/005_ultima_ug200_descriptors.wip.yml similarity index 100% rename from config/default_records/descriptors/005_ultima_ug200_descriptors.yml rename to config/default_records/descriptors/005_ultima_ug200_descriptors.wip.yml diff --git a/config/default_records/pipeline_request_information_types/004_ultima_ug200_pipeline_request_information_types.yml b/config/default_records/pipeline_request_information_types/004_ultima_ug200_pipeline_request_information_types.wip.yml similarity index 100% rename from config/default_records/pipeline_request_information_types/004_ultima_ug200_pipeline_request_information_types.yml rename to config/default_records/pipeline_request_information_types/004_ultima_ug200_pipeline_request_information_types.wip.yml diff --git a/config/default_records/pipelines/004_ultima_ug200_pipelines.yml b/config/default_records/pipelines/004_ultima_ug200_pipelines.wip.yml similarity index 100% rename from config/default_records/pipelines/004_ultima_ug200_pipelines.yml rename to config/default_records/pipelines/004_ultima_ug200_pipelines.wip.yml diff --git a/config/default_records/request_information_types/004_ultima_ug200_request_information_types.yml b/config/default_records/request_information_types/004_ultima_ug200_request_information_types.wip.yml similarity index 100% rename from config/default_records/request_information_types/004_ultima_ug200_request_information_types.yml rename to config/default_records/request_information_types/004_ultima_ug200_request_information_types.wip.yml diff --git a/config/default_records/request_type_validators/003_ultima_ug200_request_type_validators.yml b/config/default_records/request_type_validators/003_ultima_ug200_request_type_validators.wip.yml similarity index 100% rename from config/default_records/request_type_validators/003_ultima_ug200_request_type_validators.yml rename to config/default_records/request_type_validators/003_ultima_ug200_request_type_validators.wip.yml diff --git a/config/default_records/request_types/026_ultima_ug200_request_types.yml b/config/default_records/request_types/026_ultima_ug200_request_types.wip.yml similarity index 100% rename from config/default_records/request_types/026_ultima_ug200_request_types.yml rename to config/default_records/request_types/026_ultima_ug200_request_types.wip.yml diff --git a/config/default_records/tasks/005_ultima_ug200_tasks.yml b/config/default_records/tasks/005_ultima_ug200_tasks.wip.yml similarity index 100% rename from config/default_records/tasks/005_ultima_ug200_tasks.yml rename to config/default_records/tasks/005_ultima_ug200_tasks.wip.yml From 9e6b11ef305feab2de1278481679e8ad960259ef Mon Sep 17 00:00:00 2001 From: yoldas Date: Tue, 7 Apr 2026 17:12:38 +0100 Subject: [PATCH 18/29] fix(records): make task section names unique insider record loader folder --- config/default_records/tasks/005_ultima_ug200_tasks.wip.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/config/default_records/tasks/005_ultima_ug200_tasks.wip.yml b/config/default_records/tasks/005_ultima_ug200_tasks.wip.yml index c031066648..a72c05029d 100644 --- a/config/default_records/tasks/005_ultima_ug200_tasks.wip.yml +++ b/config/default_records/tasks/005_ultima_ug200_tasks.wip.yml @@ -1,11 +1,12 @@ --- -Opentrons: +# Section names must be unique inside the record loader folder. +Opentrons UG200: name: Opentrons workflow: Ultima UG200 sorted: 0 lab_activity: true sti_type: SetDescriptorsTask -Amp: +Amp UG200: name: Amp workflow: Ultima UG200 sorted: 1 From db7c961e7b675fd3390aebea261b44bb974ebb41 Mon Sep 17 00:00:00 2001 From: yoldas Date: Tue, 7 Apr 2026 17:14:37 +0100 Subject: [PATCH 19/29] fix(records): make descriptor section names unique within the record loader folder --- .../005_ultima_ug200_descriptors.wip.yml | 25 ++++++++++--------- 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/config/default_records/descriptors/005_ultima_ug200_descriptors.wip.yml b/config/default_records/descriptors/005_ultima_ug200_descriptors.wip.yml index d5c77bcb3e..df4f31fa60 100644 --- a/config/default_records/descriptors/005_ultima_ug200_descriptors.wip.yml +++ b/config/default_records/descriptors/005_ultima_ug200_descriptors.wip.yml @@ -1,82 +1,83 @@ --- -"OTR carrier Lot #": +# Section names must be unique inside the record loader folder. +"OTR carrier Lot # UG200": name: "OTR carrier Lot #" task: Opentrons workflow: Ultima UG200 kind: Text required: false sorter: 0 -OTR carrier expiry: +OTR carrier expiry UG200: name: OTR carrier expiry task: Opentrons workflow: Ultima UG200 kind: Date required: false sorter: 1 -"Reaction Mix 7 Lot #": +"Reaction Mix 7 Lot # UG200": name: "Reaction Mix 7 Lot #" task: Opentrons workflow: Ultima UG200 kind: Text required: false sorter: 2 -Reaction Mix 7 expiry: +Reaction Mix 7 expiry UG200: name: Reaction Mix 7 expiry task: Opentrons workflow: Ultima UG200 kind: Date required: false sorter: 3 -"NFW Lot #": +"NFW Lot # UG200": name: "NFW Lot #" task: Opentrons workflow: Ultima UG200 kind: Text required: false sorter: 4 -NFW expiry: +NFW expiry UG200: name: NFW expiry task: Opentrons workflow: Ultima UG200 kind: Date required: false sorter: 5 -"Oil Lot #": +"Oil Lot # UG200": name: "Oil Lot #" task: Opentrons workflow: Ultima UG200 kind: Text required: false sorter: 6 -Oil expiry: +Oil expiry UG200: name: Oil expiry task: Opentrons workflow: Ultima UG200 kind: Date required: false sorter: 7 -Pipette carousel: +Pipette carousel UG200: name: Pipette carousel task: Opentrons workflow: Ultima UG200 kind: Text required: false sorter: 8 -Opentrons Inst. Name: +Opentrons Inst. Name UG200: name: Opentrons Inst. Name task: Opentrons workflow: Ultima UG200 kind: Text required: true sorter: 9 -Assign Control Bead Tube: +Assign Control Bead Tube UG200: name: Assign Control Bead Tube task: Amp workflow: Ultima UG200 kind: Text required: false sorter: 0 -UG AMP Inst. Name: +UG AMP Inst. Name UG200: name: UG AMP Inst. Name task: Amp workflow: Ultima UG200 From 42f363d494b7a771818b33ede50cec7002c3b9d4 Mon Sep 17 00:00:00 2001 From: yoldas Date: Tue, 7 Apr 2026 17:49:48 +0100 Subject: [PATCH 20/29] feat(config): add UG200 specific request types because of purpose dependencies --- .../026_ultima_ug200_request_types.wip.yml | 22 ++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/config/default_records/request_types/026_ultima_ug200_request_types.wip.yml b/config/default_records/request_types/026_ultima_ug200_request_types.wip.yml index 99dbf035b3..81b0d39c15 100644 --- a/config/default_records/request_types/026_ultima_ug200_request_types.wip.yml +++ b/config/default_records/request_types/026_ultima_ug200_request_types.wip.yml @@ -1,5 +1,25 @@ # Request types for Ultima UG200 sequencing platform. --- +limber_ultima_ug200_htp_pcr_free: + name: Limber Ultima UG200 HTP PCR Free + order: 1 + request_class_name: IlluminaHtp::Requests::StdLibraryRequest + asset_type: Well + for_multiplexing: false + billable: true + product_line_name: Ultima # same as UG100 + acceptable_purposes: + - UPF2 Cherrypicked + library_types: + - Ultima High Throughput PCR Free 96 # same as UG100 +limber_multiplexing_ultima_ug200: + name: Limber Multiplexing Ultima UG200 + asset_type: Well + order: 2 + request_class_name: Request::Multiplexing + for_multiplexing: true + product_line_name: Ultima # same as UG100 + target_purpose_name: UPF2 EqVol Norm ultima_ug200_sequencing: name: Ultima UG200 sequencing asset_type: LibraryTube @@ -7,6 +27,6 @@ ultima_ug200_sequencing: initial_state: pending billable: true # Using same product line name as Ultima UG100 - product_line_name: Ultima + product_line_name: Ultima # same as UG100 request_class_name: UltimaUG200SequencingRequest request_purpose: standard From 9e1df9005506886bf21cf3ad767d24d88b829a38 Mon Sep 17 00:00:00 2001 From: yoldas Date: Tue, 7 Apr 2026 17:51:22 +0100 Subject: [PATCH 21/29] feat(config): update request type keys of the Limber-Htp - Ultima PCR Free - Ultima UG200 sequencing submission template --- .../021_ultima_ug200_submission_templates.wip.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/config/default_records/submission_templates/021_ultima_ug200_submission_templates.wip.yml b/config/default_records/submission_templates/021_ultima_ug200_submission_templates.wip.yml index e5b5363585..9d9ee62579 100644 --- a/config/default_records/submission_templates/021_ultima_ug200_submission_templates.wip.yml +++ b/config/default_records/submission_templates/021_ultima_ug200_submission_templates.wip.yml @@ -4,14 +4,14 @@ Limber-Htp - Ultima PCR Free - Ultima UG200 sequencing: submission_class_name: "LinearSubmission" related_records: - request_type_keys: ["limber_ultima_htp_pcr_free", "limber_multiplexing_ultima", "ultima_ug200_sequencing"] + request_type_keys: ["limber_ultima_ug200_htp_pcr_free", "limber_multiplexing_ultima_ug200", "ultima_ug200_sequencing"] order_role: PCR Free - product_line_name: Ultima + product_line_name: Ultima # same as UG100 product_catalogue_name: GenericNoPCR Limber-Htp - Ultima PCR Free - Ultima UG200 sequencing Automated: submission_class_name: "LinearSubmission" related_records: request_type_keys: ["ultima_ug200_sequencing"] order_role: PCR Free - product_line_name: Ultima + product_line_name: Ultima # same as UG100 product_catalogue_name: GenericNoPCR From 82926a0fb65a18faf4368e3b793dc822acda3c1d Mon Sep 17 00:00:00 2001 From: yoldas Date: Tue, 7 Apr 2026 17:56:43 +0100 Subject: [PATCH 22/29] style(config): prettier format spacing and indentation --- .../request_types/026_ultima_ug200_request_types.wip.yml | 2 +- .../021_ultima_ug200_submission_templates.wip.yml | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/config/default_records/request_types/026_ultima_ug200_request_types.wip.yml b/config/default_records/request_types/026_ultima_ug200_request_types.wip.yml index 81b0d39c15..bde1c5fc6e 100644 --- a/config/default_records/request_types/026_ultima_ug200_request_types.wip.yml +++ b/config/default_records/request_types/026_ultima_ug200_request_types.wip.yml @@ -11,7 +11,7 @@ limber_ultima_ug200_htp_pcr_free: acceptable_purposes: - UPF2 Cherrypicked library_types: - - Ultima High Throughput PCR Free 96 # same as UG100 + - Ultima High Throughput PCR Free 96 # same as UG100 limber_multiplexing_ultima_ug200: name: Limber Multiplexing Ultima UG200 asset_type: Well diff --git a/config/default_records/submission_templates/021_ultima_ug200_submission_templates.wip.yml b/config/default_records/submission_templates/021_ultima_ug200_submission_templates.wip.yml index 9d9ee62579..29f30ede36 100644 --- a/config/default_records/submission_templates/021_ultima_ug200_submission_templates.wip.yml +++ b/config/default_records/submission_templates/021_ultima_ug200_submission_templates.wip.yml @@ -4,7 +4,8 @@ Limber-Htp - Ultima PCR Free - Ultima UG200 sequencing: submission_class_name: "LinearSubmission" related_records: - request_type_keys: ["limber_ultima_ug200_htp_pcr_free", "limber_multiplexing_ultima_ug200", "ultima_ug200_sequencing"] + request_type_keys: + ["limber_ultima_ug200_htp_pcr_free", "limber_multiplexing_ultima_ug200", "ultima_ug200_sequencing"] order_role: PCR Free product_line_name: Ultima # same as UG100 product_catalogue_name: GenericNoPCR From 83e3f306a333005681ed35df3ac12886521139bd Mon Sep 17 00:00:00 2001 From: yoldas Date: Tue, 7 Apr 2026 17:59:30 +0100 Subject: [PATCH 23/29] feat(config): add UPF2 Cherrypicked purpose required by Limber Ultima UG200 HTP PCR Free request type --- .../plate_purposes/017_ultima_ug200_purposes.wip.yml | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 config/default_records/plate_purposes/017_ultima_ug200_purposes.wip.yml diff --git a/config/default_records/plate_purposes/017_ultima_ug200_purposes.wip.yml b/config/default_records/plate_purposes/017_ultima_ug200_purposes.wip.yml new file mode 100644 index 0000000000..682ce88e23 --- /dev/null +++ b/config/default_records/plate_purposes/017_ultima_ug200_purposes.wip.yml @@ -0,0 +1,9 @@ +--- +# 96 well input plates +UPF2 Cherrypicked: + type: PlatePurpose::Input + stock_plate: true + default_state: passed + cherrypickable_target: true + target_type: Plate + size: 96 From 7c271196917dd9cd5a2430efbaf51ccd90ee5ed8 Mon Sep 17 00:00:00 2001 From: yoldas Date: Tue, 7 Apr 2026 20:24:15 +0100 Subject: [PATCH 24/29] feat(config): add ultima ug200 tube purposes --- .../011_ultima_ug200_tube_purposes.wip.yml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 config/default_records/tube_purposes/011_ultima_ug200_tube_purposes.wip.yml diff --git a/config/default_records/tube_purposes/011_ultima_ug200_tube_purposes.wip.yml b/config/default_records/tube_purposes/011_ultima_ug200_tube_purposes.wip.yml new file mode 100644 index 0000000000..dd484cbd91 --- /dev/null +++ b/config/default_records/tube_purposes/011_ultima_ug200_tube_purposes.wip.yml @@ -0,0 +1,14 @@ +--- +UPF2 EqVol Norm: + # Even though this is Ultima, not Illumina, the MX tube has the same behaviour + type: IlluminaHtp::MxTubePurpose + target_type: MultiplexedLibraryTube + stock_plate: false +UPF2 Balanced Pool: + type: IlluminaHtp::InitialStockTubePurpose + target_type: LibraryTube + stock_plate: false +UPF2 Balanced Norm: + type: IlluminaHtp::MxTubePurpose + target_type: MultiplexedLibraryTube + stock_plate: false From 3a8b09ad53f35fcb03ff5405526f9e37c294bac6 Mon Sep 17 00:00:00 2001 From: yoldas Date: Tue, 7 Apr 2026 22:47:12 +0100 Subject: [PATCH 25/29] test(ci): fix flaky tests and add missing assertions --- test/controllers/batches_controller_test.rb | 3 +++ test/lib/label_printer/plate_to_tube_test.rb | 7 ++++++- test/unit/batch_test.rb | 2 +- test/unit/event_test.rb | 4 ++-- test/unit/request_factory_test.rb | 2 +- test/unit/sequencing_qc_batch_test.rb | 3 +++ test/unit/tasks/plate_transfer_task_test.rb | 1 + test/unit/user_test.rb | 2 +- 8 files changed, 18 insertions(+), 6 deletions(-) diff --git a/test/controllers/batches_controller_test.rb b/test/controllers/batches_controller_test.rb index a109e47d21..a7810bbefd 100644 --- a/test/controllers/batches_controller_test.rb +++ b/test/controllers/batches_controller_test.rb @@ -257,6 +257,9 @@ class BatchesControllerTest < ActionController::TestCase "request_group_#{@plate.id}_#{@submission.id}_size": '1', commit: 'Submit' } + + assert_redirected_to batch_path(assigns(:batch)) + assert_predicate assigns(:batch), :persisted? end end diff --git a/test/lib/label_printer/plate_to_tube_test.rb b/test/lib/label_printer/plate_to_tube_test.rb index 49bb24fbb4..6a289237cc 100644 --- a/test/lib/label_printer/plate_to_tube_test.rb +++ b/test/lib/label_printer/plate_to_tube_test.rb @@ -13,7 +13,12 @@ def setup # rubocop:todo Metrics/AbcSize @barcode1 = '1111' @asset_name = 'tube name' @tube1 = create(:sample_tube, :tube_barcode, barcode: barcode1, prefix: prefix, name: asset_name) - @sample_tubes = create_list(:sample_tube, 4, :tube_barcode) + @sample_tubes = [ + create(:sample_tube, :tube_barcode, barcode: '2222', prefix: prefix), + create(:sample_tube, :tube_barcode, barcode: '3333', prefix: prefix), + create(:sample_tube, :tube_barcode, barcode: '4444', prefix: prefix), + create(:sample_tube, :tube_barcode, barcode: '5555', prefix: prefix) + ] sample_tubes.unshift(tube1) options = { sample_tubes: } @tube_label = LabelPrinter::Label::PlateToTubes.new(options) diff --git a/test/unit/batch_test.rb b/test/unit/batch_test.rb index abfc223aef..e9d8ae10a5 100644 --- a/test/unit/batch_test.rb +++ b/test/unit/batch_test.rb @@ -647,7 +647,7 @@ class BatchTest < ActiveSupport::TestCase end should 'check that with the pipeline that the batch is valid' do - @batch.complete!(@user) + assert_nothing_raised { @batch.complete!(@user) } end end diff --git a/test/unit/event_test.rb b/test/unit/event_test.rb index 67e6a550e7..68fe62686c 100644 --- a/test/unit/event_test.rb +++ b/test/unit/event_test.rb @@ -18,7 +18,7 @@ class EventTest < ActiveSupport::TestCase setup { @event = Event.create(descriptor_key: '') } should 'be valid' do - @event.valid? + assert_predicate @event, :valid? end end end @@ -28,7 +28,7 @@ class EventTest < ActiveSupport::TestCase setup { @event = Event.create } should 'be valid' do - @event.valid? + assert_predicate @event, :valid? end end end diff --git a/test/unit/request_factory_test.rb b/test/unit/request_factory_test.rb index 5339e13433..538b6eaacc 100644 --- a/test/unit/request_factory_test.rb +++ b/test/unit/request_factory_test.rb @@ -42,7 +42,7 @@ class RequestcreateTest < ActiveSupport::TestCase setup { @project.update!(enforce_quotas: true) } should 'not fail' do - RequestFactory.copy_request(@request) + assert_nothing_raised { RequestFactory.copy_request(@request) } end end end diff --git a/test/unit/sequencing_qc_batch_test.rb b/test/unit/sequencing_qc_batch_test.rb index 89a123a9bb..eda3f8a081 100644 --- a/test/unit/sequencing_qc_batch_test.rb +++ b/test/unit/sequencing_qc_batch_test.rb @@ -38,6 +38,7 @@ class SequencingQcBatchTest < ActiveSupport::TestCase should 'do nothing if the next state is nil' do @batch.stubs(:qc_next_state).returns(nil) + @batch.expects(:update_attribute).never # no state update when there is no next state @batch.qc_submitted end end @@ -51,6 +52,7 @@ class SequencingQcBatchTest < ActiveSupport::TestCase should 'do nothing if the next state is nil' do @batch.stubs(:qc_next_state).returns(nil) + @batch.expects(:update_attribute).never # no state update when there is no next state @batch.qc_criteria_received end end @@ -64,6 +66,7 @@ class SequencingQcBatchTest < ActiveSupport::TestCase should 'do nothing if the next state is nil' do @batch.stubs(:qc_next_state).returns(nil) + @batch.expects(:update_attribute).never # no state update when there is no next state @batch.qc_complete end end diff --git a/test/unit/tasks/plate_transfer_task_test.rb b/test/unit/tasks/plate_transfer_task_test.rb index 9ed5ba55f8..669a0df93d 100644 --- a/test/unit/tasks/plate_transfer_task_test.rb +++ b/test/unit/tasks/plate_transfer_task_test.rb @@ -100,6 +100,7 @@ class PlateTransferTaskTest < ActiveSupport::TestCase end should 'find the existing plate' do + assert_equal 1, Plate.count - @plate_count end end diff --git a/test/unit/user_test.rb b/test/unit/user_test.rb index 126e8414d0..081be0ac56 100644 --- a/test/unit/user_test.rb +++ b/test/unit/user_test.rb @@ -123,7 +123,7 @@ class UserTest < ActiveSupport::TestCase should 'be able to have one assigned' do code = 'code' - @user.swipecard_code = code + assert_nothing_raised { @user.swipecard_code = code } end end From f8397ad45e310b6c3ec11a330b618c630da94b7d Mon Sep 17 00:00:00 2001 From: yoldas Date: Thu, 9 Apr 2026 15:29:52 +0100 Subject: [PATCH 26/29] Update config/default_records/request_types/026_ultima_ug200_request_types.wip.yml Co-authored-by: KatyTaylor --- .../request_types/026_ultima_ug200_request_types.wip.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/config/default_records/request_types/026_ultima_ug200_request_types.wip.yml b/config/default_records/request_types/026_ultima_ug200_request_types.wip.yml index bde1c5fc6e..bc5977f439 100644 --- a/config/default_records/request_types/026_ultima_ug200_request_types.wip.yml +++ b/config/default_records/request_types/026_ultima_ug200_request_types.wip.yml @@ -26,7 +26,6 @@ ultima_ug200_sequencing: order: 2 initial_state: pending billable: true - # Using same product line name as Ultima UG100 product_line_name: Ultima # same as UG100 request_class_name: UltimaUG200SequencingRequest request_purpose: standard From e429b9895c39a88689d8c0f1991b4ca8a0d66171 Mon Sep 17 00:00:00 2001 From: yoldas Date: Thu, 9 Apr 2026 15:58:29 +0100 Subject: [PATCH 27/29] refactor: remove redundant method and constant from UltimaUG200Validator --- app/validators/ultima_ug200_validator.rb | 7 ------- 1 file changed, 7 deletions(-) diff --git a/app/validators/ultima_ug200_validator.rb b/app/validators/ultima_ug200_validator.rb index 1dc5c9889e..ae66f898ad 100644 --- a/app/validators/ultima_ug200_validator.rb +++ b/app/validators/ultima_ug200_validator.rb @@ -1,7 +1,6 @@ # frozen_string_literal: true class UltimaUG200Validator < UltimaValidator WAFER_SIZE_CONSISTENT_MSG = 'Wafer size must be the same for both requests.' - OT_RECIPE_CONSISTENT_MSG = 'OT Recipe must be the same for both requests.' # Used in _pipeline_limit.html to display custom validation warnings def self.validation_info @@ -22,10 +21,4 @@ def requests_have_same_wafer_size(record) record.errors.add(:base, WAFER_SIZE_CONSISTENT_MSG) end - - def requests_have_same_ot_recipe(record) - return if record.pipeline.ot_recipe_consistent_for_batch?(record) - - record.errors.add(:base, OT_RECIPE_CONSISTENT_MSG) - end end From 2d2137b204d264f804e0ed7a2176ebcdbe2bedc2 Mon Sep 17 00:00:00 2001 From: yoldas Date: Mon, 13 Apr 2026 13:26:21 +0100 Subject: [PATCH 28/29] remove UPF2 Balanced Pool and UPF2 Balanced Norm from sequencescape it is defined in Limber --- .../tube_purposes/011_ultima_ug200_tube_purposes.wip.yml | 8 -------- 1 file changed, 8 deletions(-) diff --git a/config/default_records/tube_purposes/011_ultima_ug200_tube_purposes.wip.yml b/config/default_records/tube_purposes/011_ultima_ug200_tube_purposes.wip.yml index dd484cbd91..3cb41b6b30 100644 --- a/config/default_records/tube_purposes/011_ultima_ug200_tube_purposes.wip.yml +++ b/config/default_records/tube_purposes/011_ultima_ug200_tube_purposes.wip.yml @@ -4,11 +4,3 @@ UPF2 EqVol Norm: type: IlluminaHtp::MxTubePurpose target_type: MultiplexedLibraryTube stock_plate: false -UPF2 Balanced Pool: - type: IlluminaHtp::InitialStockTubePurpose - target_type: LibraryTube - stock_plate: false -UPF2 Balanced Norm: - type: IlluminaHtp::MxTubePurpose - target_type: MultiplexedLibraryTube - stock_plate: false From b5e7c9cfe810b0ab7cc6f7647e98342c4e0602a3 Mon Sep 17 00:00:00 2001 From: yoldas Date: Mon, 13 Apr 2026 13:45:31 +0100 Subject: [PATCH 29/29] add UG200 to the submission template names --- .../021_ultima_ug200_submission_templates.wip.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/config/default_records/submission_templates/021_ultima_ug200_submission_templates.wip.yml b/config/default_records/submission_templates/021_ultima_ug200_submission_templates.wip.yml index 29f30ede36..5c534184d0 100644 --- a/config/default_records/submission_templates/021_ultima_ug200_submission_templates.wip.yml +++ b/config/default_records/submission_templates/021_ultima_ug200_submission_templates.wip.yml @@ -1,7 +1,7 @@ # This submission template is associated with the Ultima PCR Free Library preparation pipeline # and the Ultima UG200 sequencing platform. --- -Limber-Htp - Ultima PCR Free - Ultima UG200 sequencing: +Limber-Htp - Ultima UG200 PCR Free - Ultima UG200 sequencing: submission_class_name: "LinearSubmission" related_records: request_type_keys: @@ -9,7 +9,7 @@ Limber-Htp - Ultima PCR Free - Ultima UG200 sequencing: order_role: PCR Free product_line_name: Ultima # same as UG100 product_catalogue_name: GenericNoPCR -Limber-Htp - Ultima PCR Free - Ultima UG200 sequencing Automated: +Limber-Htp - Ultima UG200 PCR Free - Ultima UG200 sequencing Automated: submission_class_name: "LinearSubmission" related_records: request_type_keys: ["ultima_ug200_sequencing"]