diff --git a/.env.example b/.env.example index 7244df9..e847ffa 100644 --- a/.env.example +++ b/.env.example @@ -1,172 +1,262 @@ # =========================================== -# Chronarr Configuration - CORRECTED VERSION +# Chronarr Configuration # =========================================== -# Main configuration file - safe to share for debugging -# Sensitive data (API keys, passwords) are in .env.secrets +# Copy this file to .env and fill in your values. +# Sensitive values (API keys, passwords) belong in .env.secrets — keep that file out of git. +# +# WEBHOOK URLS for your Radarr/Sonarr instances: +# Single instance (default): http://chronarr:8080/radarr/webhook +# http://chronarr:8080/sonarr/webhook +# Named instances: http://chronarr:8080/radarr_4k/webhook +# http://chronarr:8080/sonarr_4k/webhook +# (Webhook URLs are built automatically from instance names in this file) # =========================================== -# MEDIA PATHS (REQUIRED) - FIXED +# CHRONARR DATABASE # =========================================== -# Container paths (what Chronarr sees inside container) -MOVIE_PATHS=/media/Movies/movies,/media/Movies/movies6 -TV_PATHS=/media/TV/tv,/media/TV/tv6 +# Internal Chronarr database — stores your media dates and metadata. +# PostgreSQL is strongly recommended for production. -# Radarr paths (what Radarr sees on the host system) -RADARR_ROOT_FOLDERS=/mnt/unionfs/Media/Movies/movies,/mnt/unionfs/Media/Movies/movies6 - -# Sonarr paths (what Sonarr sees on the host system) - FIXED VARIABLE NAME AND PATHS -SONARR_ROOT_FOLDERS=/mnt/unionfs/Media/TV/tv,/mnt/unionfs/Media/TV/tv6 +DB_TYPE=postgresql +DB_HOST=chronarr-db +DB_PORT=5432 +DB_NAME=chronarr +DB_USER=chronarr +# DB_PASSWORD= → set in .env.secrets -# Download detection paths (for identifying downloads vs existing files) -DOWNLOAD_PATH_INDICATORS=/downloads/,/nzbget/,/completed/,/sabnzbd/,/torrents/ +# SQLite alternative (not recommended for production): +# DB_TYPE=sqlite +# DB_PATH=/app/data/media_dates.db # =========================================== # SERVER CONFIGURATION # =========================================== -# Timezone for container logging and timestamps TZ=America/New_York -# Chronarr Core API (webhooks, processing, database management) +# Core API — handles webhooks and processing +# This is the interface Chronarr's own core container listens ON. Leave it +# at 0.0.0.0 unless you have a specific reason to change it — setting this +# to a hostname will stop core listening on the addresses Docker healthchecks +# and the web container's other internal calls use, breaking both. CORE_API_HOST=0.0.0.0 CORE_API_PORT=8080 -# Chronarr Web Interface (dashboard, series/movie management) -WEB_API_HOST=0.0.0.0 -WEB_API_PORT=8081 - -# External port where web interface is accessible (for dynamic port reference) +# Where the WEB container reaches CORE internally — a different setting from +# the pair above. Only needed if the default hostname "chronarr" is +# ambiguous, e.g. running more than one Chronarr deployment on the same +# Docker network (a production stack and a local-test stack, say) — point +# this at your core container's actual name/service in that situation. +# CORE_INTERNAL_HOST=chronarr +# CORE_INTERNAL_PORT=8080 + +# Web dashboard +WEB_HOST=0.0.0.0 +WEB_PORT=8081 +WEB_WORKERS=1 WEB_EXTERNAL_PORT=8081 # =========================================== -# DATABASE CONFIGURATION +# RADARR — MAIN INSTANCE # =========================================== -# Chronarr Database Configuration (PostgreSQL - v2.6+) -# NOTE: For new installations, PostgreSQL is strongly recommended -# Set these values in .env.secrets for security: -# - DB_PASSWORD=your_secure_password -# - DB_USER=chronarr (default) - -# PostgreSQL Database Settings -DB_TYPE=postgresql -DB_HOST=chronarr-db # Container name from docker-compose -DB_PORT=5432 -DB_NAME=chronarr -DB_USER=chronarr - -# Legacy SQLite Configuration (Deprecated in v2.6+) -# Only use for existing SQLite installations -# DB_PATH=/app/data/media_dates.db +# Paths: RADARR_ROOT_FOLDERS is what Radarr sees on the host (or UNC path on Windows). +# RADARR_MOVIE_PATHS is what Chronarr sees inside the container. +# Both are comma-separated. +# +# IMPORTANT — multi-instance users: +# Define paths per-instance (RADARR_MOVIE_PATHS, RADARR_4K_MOVIE_PATHS, etc.) +# Do NOT use the global MOVIE_PATHS key when running multiple instances — +# if it appears more than once in your env file, Docker only keeps the last +# definition and silently drops the others. -# Log file directory -LOG_DIR=/app/data/logs +RADARR_URL=http://radarr:7878 +# RADARR_API_KEY= → set in .env.secrets +# RADARR_WEBHOOK_SECRET= → set in .env.secrets (optional, for webhook validation) +RADARR_ROOT_FOLDERS=/mnt/unionfs/Media/Movies/movies +RADARR_MOVIE_PATHS=/media/movies -# =========================================== -# RADARR DATABASE CONNECTION (RECOMMENDED) -# =========================================== -# Direct database access for better performance +# Radarr database (direct DB access — faster than API for large libraries) RADARR_DB_TYPE=postgresql -RADARR_DB_HOST=192.168.255.50 +RADARR_DB_HOST=your-radarr-db-host RADARR_DB_PORT=5432 RADARR_DB_NAME=radarr-main RADARR_DB_USER=postgres +# RADARR_DB_PASSWORD= → set in .env.secrets -# Alternative: SQLite (if Radarr uses SQLite) +# SQLite alternative: # RADARR_DB_TYPE=sqlite # RADARR_DB_PATH=/path/to/radarr.db # =========================================== -# SONARR DATABASE CONNECTION (RECOMMENDED) +# RADARR — ADDITIONAL INSTANCES (OPTIONAL) +# =========================================== +# Add a block per extra Radarr instance. The name between RADARR_ and _URL +# becomes part of the webhook URL: RADARR_4K_URL → /radarr_4k/webhook +# Names must be uppercase letters, digits, and underscores only — no hyphens +# (a shell/env-var limitation). RADARR_4K and RADARR_STRM_BOX are fine; +# RADARR-4K is not. The URL *value* has no such restriction — it can contain +# hyphens and a full domain name, e.g. RADARR_STRM_URL=http://radarr-strm.yourdomain.com:7878 +# +# Each instance defines ALL of its own settings here — URL, API key, paths, +# and database access. Do NOT set MOVIE_PATHS again in this block; use +# RADARR_4K_MOVIE_PATHS instead. If MOVIE_PATHS appears twice in your env +# file, Docker only keeps the last value and silently drops the first. +# +# After configuring instances, visit http://your-server:8081/setup +# for the exact webhook URLs to paste into each Radarr instance. + +# RADARR_4K_URL=http://radarr4k:7878 +# RADARR_4K_API_KEY= → set in .env.secrets +# RADARR_4K_WEBHOOK_SECRET= → set in .env.secrets (optional) +# RADARR_4K_ROOT_FOLDERS=/mnt/unionfs/Media/Movies/movies4k +# RADARR_4K_MOVIE_PATHS=/media/movies4k ← per-instance paths, NOT MOVIE_PATHS +# RADARR_4K_DB_TYPE=postgresql +# RADARR_4K_DB_HOST=your-radarr-4k-db-host +# RADARR_4K_DB_PORT=5432 +# RADARR_4K_DB_NAME=radarr-4k +# RADARR_4K_DB_USER=postgres +# RADARR_4K_DB_PASSWORD= → set in .env.secrets +# SQLite: RADARR_4K_DB_TYPE=sqlite / RADARR_4K_DB_PATH=/radarr-4k-data/radarr.db + +# =========================================== +# SONARR — MAIN INSTANCE # =========================================== -# Direct database access for better performance -# Phase 7: High-performance TV episode import date detection +# Same paths rule as Radarr: use SONARR_TV_PATHS here, not the global TV_PATHS, +# so each instance's paths stay self-contained. +SONARR_URL=http://sonarr:8989 +# SONARR_API_KEY= → set in .env.secrets +# SONARR_WEBHOOK_SECRET= → set in .env.secrets (optional) +SONARR_ROOT_FOLDERS=/mnt/unionfs/Media/TV/tv +SONARR_TV_PATHS=/media/tv + +# Sonarr database SONARR_DB_TYPE=postgresql -SONARR_DB_HOST=192.168.255.50 +SONARR_DB_HOST=your-sonarr-db-host SONARR_DB_PORT=5432 SONARR_DB_NAME=sonarr-main SONARR_DB_USER=postgres +# SONARR_DB_PASSWORD= → set in .env.secrets -# Alternative: SQLite (if Sonarr uses SQLite) +# SQLite alternative: # SONARR_DB_TYPE=sqlite # SONARR_DB_PATH=/path/to/sonarr.db # =========================================== -# API CONNECTIONS (OPTIONAL) +# SONARR — ADDITIONAL INSTANCES (OPTIONAL) # =========================================== -# API keys are stored in .env.secrets for security -RADARR_URL=http://radarr:7878 -SONARR_URL=http://sonarr:8989 +# Same rule: use SONARR_4K_TV_PATHS, NOT TV_PATHS, in additional instance blocks. +# SONARR_4K_URL=http://sonarr4k:8989 +# SONARR_4K_API_KEY= → set in .env.secrets +# SONARR_4K_WEBHOOK_SECRET= → set in .env.secrets (optional) +# SONARR_4K_ROOT_FOLDERS=/mnt/unionfs/Media/TV/tv4k +# SONARR_4K_TV_PATHS=/media/tv4k ← per-instance paths, NOT TV_PATHS +# SONARR_4K_DB_TYPE=postgresql +# SONARR_4K_DB_HOST=your-sonarr-4k-db-host +# SONARR_4K_DB_PORT=5432 +# SONARR_4K_DB_NAME=sonarr-4k +# SONARR_4K_DB_USER=postgres +# SONARR_4K_DB_PASSWORD= → set in .env.secrets + +# =========================================== +# EXTERNAL APIs (OPTIONAL) +# =========================================== +# Jellyseerr — for request tracking +# JELLYSEERR_URL=http://jellyseerr:5055 +# JELLYSEERR_API_KEY= → set in .env.secrets + +# TMDB — for release date and metadata lookup +# TMDB_API_KEY= → set in .env.secrets +TMDB_COUNTRY=US +# TMDB_TYPE_PRIORITY=movie,tv + +# TVDB — for TV episode air dates +# TVDB_API_KEY= → set in .env.secrets +# DISABLE_TVDB=false + +# OMDB — fallback metadata source +# OMDB_API_KEY= → set in .env.secrets # =========================================== -# RELEASE DATE PROCESSING +# MOVIE PROCESSING # =========================================== -# Priority order for release date fallbacks (digital, physical, theatrical) +# Priority for determining which date to use +# Options: import_then_digital, digital_only, theatrical_only +MOVIE_PRIORITY=import_then_digital + +# Order to check release date types RELEASE_DATE_PRIORITY=digital,physical,theatrical -#RELEASE_DATE_PRIORITY=digital,theatrical,physical -ENABLE_SMART_DATE_VALIDATION=true -MAX_RELEASE_DATE_GAP_YEARS=10 -# Prefer API release dates over file modification dates for manual imports +# Prefer API release dates over file modification dates PREFER_RELEASE_DATES_OVER_FILE_DATES=true -# Disable file date fallback completely (recommended for clean imports) +# Allow file modification date as a last-resort fallback ALLOW_FILE_DATE_FALLBACK=false -# TMDB country for regional release date preferences -TMDB_COUNTRY=US +# How to handle existing dates in the database +# Options: backfill_only (fill missing), overwrite (always update) +MOVIE_DATE_UPDATE_MODE=backfill_only +# When to poll for movie date data +# Options: always, missing_only, never +MOVIE_POLL_MODE=always + +# Smart date validation — rejects dates that seem implausible +ENABLE_SMART_DATE_VALIDATION=true +MAX_RELEASE_DATE_GAP_YEARS=10 + +# Remove movies from DB that have been missing for N days (0 = disabled) +PURGE_MISSING_MOVIES_DAYS=0 # =========================================== -# PROCESSING BEHAVIOR +# TV PROCESSING # =========================================== -# Movie date update strategy -MOVIE_DATE_UPDATE_MODE=overwrite -MOVIE_PRESERVE_EXISTING=false - -# When to update existing dates (always, missing_only, never) -UPDATE_MODE=always +TV_WEBHOOK_PROCESSING_MODE=targeted -# File modification time behavior (update, leave_alone) -MTIME_BEHAVIOR=update +# Season directory naming — must match your actual folder names +TV_SEASON_DIR_FORMAT=Season {season:02d} +TV_SEASON_DIR_PATTERN=season -# Manual scan priority: use existing NFO dates for speed vs check APIs for accuracy -# false (default) = Check external APIs first, use NFO as fallback (slower but accurate) -# true = Use NFO dates immediately without API checks (faster but may use wrong dates) -MANUAL_SCAN_PRIORITIZE_NFO=false +# Remove TV shows from DB that have been missing for N days (0 = disabled) +PURGE_MISSING_TV_DAYS=0 # =========================================== # PERFORMANCE & BATCHING # =========================================== -# Delay before processing batched events (seconds) BATCH_DELAY=5.0 - -# Maximum concurrent series processing MAX_CONCURRENT_SERIES=3 - -# Sequential processing delay for bulk downloads (seconds) -# When multiple episodes are downloaded at once, process them one by one with this delay -# Set to 0 to disable sequential processing (parallel mode) SEQUENTIAL_DELAY=20.0 - -# API timeout in seconds TIMEOUT_SECONDS=45 +# =========================================== +# WEB INTERFACE +# =========================================== +WEB_AUTH_ENABLED=false +# WEB_AUTH_USERNAME=admin +# WEB_AUTH_PASSWORD= → set in .env.secrets +WEB_AUTH_SESSION_TIMEOUT=3600 + +# Dashboard display +# APP_TITLE=Chronarr +# APP_SUBTITLE=Database Management & Reporting +PAGINATION_LIMIT=50 +REFRESH_INTERVAL=30 + # =========================================== # DEBUGGING # =========================================== -# Enable verbose logging (true/false) DEBUG=false - -# Enable path mapping debug output (true/false) PATH_DEBUG=false - -# Suppress TVDB API warnings (true/false) - TVDB failures are common and non-critical -SUPPRESS_TVDB_WARNINGS=true +LOG_DIR=/app/data/logs # =========================================== -# WEB INTERFACE AUTHENTICATION +# LEGACY — PENDING REMOVAL # =========================================== -# Enable web interface authentication (default: false) -WEB_AUTH_ENABLED=false - -# Session timeout in seconds (default: 3600 = 1 hour) -WEB_AUTH_SESSION_TIMEOUT=3600 \ No newline at end of file +# These settings controlled NFO file writing, which was the original mechanism +# for pushing dates into Emby/Jellyfin. The Emby/Jellyfin plugins now read +# directly from Chronarr's database, making this code path obsolete. +# These vars and the code behind them will be removed in a future release. +# Changing these values currently has no meaningful effect. +# +# MANAGE_NFO=true +# FIX_DIR_MTIMES=true +# LOCK_METADATA=true +# MANUAL_SCAN_PRIORITIZE_NFO=false diff --git a/.env.secrets.example b/.env.secrets.example index 5fd86e1..098b5f1 100644 --- a/.env.secrets.example +++ b/.env.secrets.example @@ -6,16 +6,21 @@ # =========================================== # CHRONARR DATABASE CREDENTIALS (REQUIRED) # =========================================== -# Chronarr PostgreSQL database password (REQUIRED for v2.6+) +# Chronarr PostgreSQL database password (required) DB_PASSWORD=your_secure_chronarr_password # Optional: Override default database user (defaults to 'chronarr') # DB_USER=chronarr # =========================================== -# RADARR DATABASE CREDENTIALS (OPTIONAL) +# RADARR / SONARR DATABASE CREDENTIALS # =========================================== -# Database password for external Radarr PostgreSQL connection (optional optimization) +# Database passwords for direct Radarr/Sonarr PostgreSQL access (optional, recommended) RADARR_DB_PASSWORD=your_radarr_db_password +SONARR_DB_PASSWORD=your_sonarr_db_password + +# Named instance passwords (uncomment if using additional instances) +# RADARR_4K_DB_PASSWORD=your_radarr_4k_db_password +# SONARR_4K_DB_PASSWORD=your_sonarr_4k_db_password # =========================================== # API KEYS (SENSITIVE DATA) @@ -29,15 +34,18 @@ OMDB_API_KEY=your_omdb_api_key # Radarr API key (optional - for fallback only) RADARR_API_KEY=your_radarr_api_key -# Sonarr API key (REQUIRED for v0.6.0+ Enhanced TV NFO Generation) +# Sonarr API key (required for series lookups and TV episode metadata) SONARR_API_KEY=your_sonarr_api_key +# Named instance API keys (uncomment if using additional instances) +# RADARR_4K_API_KEY=your_radarr_4k_api_key +# SONARR_4K_API_KEY=your_sonarr_4k_api_key + # Jellyseerr API key (optional) JELLYSEERR_API_KEY=your_jellyseerr_api_key -# TVDB API key (RECOMMENDED for v0.6.1+ Emby TV NFO Compatibility) -# Required to convert IMDB IDs to TVDB IDs for proper Emby metadata loading -# Get free API key at: https://thetvdb.com/api-information +# TVDB API key (optional — used for TV episode air date lookups) +# Get a free API key at: https://thetvdb.com/api-information TVDB_API_KEY=your_tvdb_api_key # =========================================== diff --git a/.github/workflows/v3.yml b/.github/workflows/v3.yml new file mode 100644 index 0000000..47da256 --- /dev/null +++ b/.github/workflows/v3.yml @@ -0,0 +1,60 @@ +name: Build & Push V3 to DockerHub + +on: + push: + branches: [ feature/v3 ] + +permissions: + contents: read + +jobs: + docker: + runs-on: ubuntu-latest + + steps: + - name: Checkout + uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 + + - name: Read VERSION + run: | + if [[ ! -f VERSION ]]; then echo "VERSION file missing"; exit 1; fi + RAW=$(tr -d ' \n' < VERSION) + if [[ -z "$RAW" ]]; then echo "VERSION empty"; exit 1; fi + if [[ "$RAW" =~ ^v ]]; then NUM="${RAW#v}"; else NUM="$RAW"; fi + REPO_NAME=$(echo "${GITHUB_REPOSITORY}" | cut -d'/' -f2) + echo "DOCKER_REPO=${{ secrets.DOCKER_HUB_USERNAME }}/${REPO_NAME}" >> $GITHUB_ENV + echo "VERSION_NUM=$NUM" >> $GITHUB_ENV + + - name: Set up QEMU + uses: docker/setup-qemu-action@96fe6ef7f33517b61c61be40b68a1882f3264fb8 # v4.2.0 + + - name: Set up Buildx + uses: docker/setup-buildx-action@bb05f3f5519dd87d3ba754cc423b652a5edd6d2c # v4.2.0 + + - name: Log in to DockerHub + uses: docker/login-action@abd2ef45e78c5afb21d64d4ca52ee8550d9572c7 # v4.5.1 + with: + username: ${{ secrets.DOCKER_HUB_USERNAME }} + password: ${{ secrets.DOCKER_HUB_TOKEN }} + + - name: Build & push + uses: docker/build-push-action@53b7df96c91f9c12dcc8a07bcb9ccacbed38856a # v7.3.0 + with: + context: . + file: ./Dockerfile + platforms: linux/amd64,linux/arm64 + push: true + tags: ${{ env.DOCKER_REPO }}:v3 + build-args: | + APP_VERSION=${{ env.VERSION_NUM }}-v3 + cache-from: type=gha + cache-to: type=gha,mode=max + provenance: false + + - name: Summary + run: | + echo "✅ V3 image pushed!" + echo "Tag: ${{ env.DOCKER_REPO }}:v3" + echo "" + echo "To test, update docker-compose.yml:" + echo " image: ${{ env.DOCKER_REPO }}:v3" diff --git a/CHANGELOG.md b/CHANGELOG.md index 301a14b..b3f7b8f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,4 +1,20 @@ -# Chronarr Plugin Changelog +# Chronarr Changelog + +## Core App + +### v3.0.0 + +- **Multi-instance support** — Configure multiple Radarr and/or Sonarr instances using a `NAME` segment in the env var (e.g., `RADARR_4K_URL`). Each instance is discovered automatically and tracked independently in the database +- **Sidebar navigation** — Replaced the horizontal tab bar with a collapsible dark sidebar; Movies and TV Shows expand to show per-instance sub-items with colored dots +- **Instance badges** — Table rows display a colored pill badge identifying which instance the record belongs to; colors are consistent between the sidebar dots and the table badges +- **Instance-aware edit and smart-fix** — Date edits, smart-fix actions, and skipped-item updates are scoped to the correct instance, preventing cross-instance updates in multi-instance setups +- **Cold-start populate fix** — Database population triggered at startup now loops all configured Radarr and Sonarr instances instead of only the first +- **Delete series** — New API endpoint (`DELETE /api/series/{imdb_id}?instance=sonarr`) and UI button to remove an entire TV series and all its episode records in one operation +- **Series title cleanup** — Series titles sourced from folder paths no longer include media-manager ID suffixes such as `[imdb-tt1234567]` + +--- + +## Emby and Jellyfin Plugin Full version history for the Emby and Jellyfin plugins. The config page inside each plugin shows the latest 5 entries only. diff --git a/Emby-DLL/CHANGELOG.md b/Emby-DLL/CHANGELOG.md new file mode 100644 index 0000000..a3a86fe --- /dev/null +++ b/Emby-DLL/CHANGELOG.md @@ -0,0 +1,41 @@ +# Chronarr Emby Plugin — Changelog + +## v2.0.22 — License Checksum Fix (same DLL version, no code bump needed) +- Fixed license validation silently failing for every license issued since the Chronarr rebrand — the plugin's local license format check only recognized the legacy `NFOG-` key prefix; the license server has been issuing `CHRO-` prefixed keys for a while now, so a perfectly valid, server-verified license would still fail this local check and disable all sync. Both prefixes are now accepted. + +## v2.0.22 — Library Exclusions Fix +- Fixed library exclusions not actually excluding anything — Emby's virtual-folder API exposes three different ID fields for a library (`Guid`, `ItemId`, `Id`), and the config page was capturing the wrong one (`Id`, a short legacy numeric string on some Emby versions, not a GUID at all). That never matched what the real-time sync and scheduled task compare against, so a checked-off library still got scanned regardless of which library it was. Now reads the library's actual `Guid` field — **re-check and re-save Library Exclusions after updating** so the corrected IDs get stored. + +## v2.0.20 — Server Name & Admin Pre-fill +- Server name field is now read-only and sourced automatically from Emby's configured server name +- Admin username is pre-filled from the first Emby administrator account at startup +- Registration and validation payloads now include structured server and user blocks for improved license server tracking + +## v2.0.19 — Movie Date Sync Fix +- Movies now resolve their IMDb ID from Emby's own metadata instead of requiring it in the folder name — standard naming (Movie (Year)) is fully supported for real-time sync and scheduled task + +## v2.0.18 — TV Episode Date Sync +- Real-time sync and scheduled task now resolve the series IMDb ID from Emby's own metadata instead of requiring it to be embedded in the folder name — standard Radarr/Sonarr naming (Series (Year)) is fully supported + +## v2.0.17 — Registration Error Handling +- Invalid or disposable email addresses now show a clear message in the plugin configuration page instead of a misleading network error after the offline grace period expires + +## v2.0.16 — Database-Direct Sync + License Self-Heal +- License validation retries every hour when invalid — self-heals after transient server outages without waiting 23 hours +- Removed NFO file dependency — date lookups go directly to the Chronarr database; real-time sync no longer silently skips items without a sidecar NFO file +- Movies without an IMDb ID in the filename fall back to reading the ID from movie.nfo content if present + +## v2.0.14 — Removed TLS Certificate Pinning +- Removed cert pinning from the license client — the pinned hash expired every 90 days on Let's Encrypt renewal, breaking check-ins for all users +- License responses are already protected by RSA signature verification; standard TLS CA validation is now used instead + +## v2.0.13 — Platform Reporting +- License check-ins now identify the media server platform (Emby) so the admin panel can distinguish Emby from Jellyfin installs + +## v2.0.12 — Security: Grace Period Hardening +- Offline grace period no longer bypasses an expired license — blocking the server after expiry is denied immediately +- Last server-validated expiry is stored in a signed state file; signature verified on every offline check + +## v2.0.11 — Library Exclusions +- New: exclude specific Emby libraries from processing — config page shows checkboxes for each library +- Exclusions apply to both scheduled task and real-time sync diff --git a/Emby-DLL/Chronarr.Emby.Plugin.dll b/Emby-DLL/Chronarr.Emby.Plugin.dll index ca6e95a..7661ae2 100644 Binary files a/Emby-DLL/Chronarr.Emby.Plugin.dll and b/Emby-DLL/Chronarr.Emby.Plugin.dll differ diff --git a/QUICKSTART.md b/QUICKSTART.md index eb833bb..40d8d44 100644 --- a/QUICKSTART.md +++ b/QUICKSTART.md @@ -89,7 +89,7 @@ docker-compose restart ### 4. Populate Database 1. Open web interface: `http://your-server:8081` -2. Click **Admin** tab +2. Click **Tools** in the sidebar 3. Click **Populate Database** 4. Select **Movies** and/or **TV Shows** 5. Click **Start Population** @@ -121,14 +121,14 @@ docker-compose restart 1. Go to **Settings → Connect** 2. Add **Webhook** connection: - Name: `Chronarr` - - URL: `http://chronarr-core:8080/webhook/radarr` + - URL: `http://chronarr-core:8080/radarr/webhook` - Triggers: On Import, On Upgrade, On Rename ### Sonarr 1. Go to **Settings → Connect** 2. Add **Webhook** connection: - Name: `Chronarr` - - URL: `http://chronarr-core:8080/webhook/sonarr` + - URL: `http://chronarr-core:8080/sonarr/webhook` - Triggers: On Import, On Upgrade, On Rename, On Episode File Delete ## Useful Commands @@ -210,6 +210,40 @@ SONARR_DB_PASSWORD=sonarr_password # Add to .env.secrets **Why does Radarr require database access?** The Radarr API doesn't expose all import history data needed for accurate date tracking. Direct database access allows Chronarr to query import timestamps, detect upgrades vs new imports, and handle complex scenarios. +### Multi-Instance Setup (Multiple Radarr/Sonarr) + +Running a standard + 4K library split (or any other multi-instance setup)? Add a +`NAME` segment between the prefix and variable suffix — e.g. `RADARR_4K_URL`. Each +named instance is fully self-contained: it needs its own `_URL`, `_API_KEY`, +`_ROOT_FOLDERS`, its own paths variable (`RADARR_4K_MOVIE_PATHS`, not the global +`MOVIE_PATHS`), and — if using SQLite — its own `_DB_TYPE`/`_DB_PATH` **and its own +volume mount**, distinct from the main instance's: + +```yaml +# docker-compose.yml — one mount per SQLite instance +chronarr: + volumes: + - /path/to/radarr/config:/radarr-data:ro # RADARR_DB_PATH=/radarr-data/radarr.db + - /path/to/radarr-4k/config:/radarr-4k-data:ro # RADARR_4K_DB_PATH=/radarr-4k-data/radarr.db +``` + +```bash +# ./config/.env +RADARR_4K_URL=http://radarr-4k:7878 +RADARR_4K_API_KEY=your_4k_api_key # → set in .env.secrets +RADARR_4K_ROOT_FOLDERS=/mnt/unionfs/Media/Movies/movies4k +RADARR_4K_MOVIE_PATHS=/media/movies4k +RADARR_4K_DB_TYPE=sqlite +RADARR_4K_DB_PATH=/radarr-4k-data/radarr.db +``` + +Reusing the main instance's mount point or `_DB_PATH` for a second instance is the +most common cause of a "connected but returns no data" instance — each one needs +its own distinct container path. See the README's Multi-Instance Configuration +section and `docker-compose.yml.example` for the full annotated reference, and +visit `/setup` after restarting to confirm each instance's webhook URL and +connection status. + ### Emby Plugin Deployment To auto-deploy the Chronarr Emby plugin: diff --git a/README.md b/README.md index 5160908..461bd16 100644 --- a/README.md +++ b/README.md @@ -44,7 +44,8 @@ Chronarr tracks and manages "dateadded" timestamps for all your movies and TV ep - **Direct Database Access** - Required for Radarr, optional for Sonarr (PostgreSQL & SQLite support) - **API Integration** - Sonarr API support for metadata and series lookups - **Webhook Support** - Real-time updates on import, upgrade, and rename events -- **Bulk Import** - One-click population of entire Radarr/Sonarr libraries +- **Multi-Instance Support** - Run multiple Radarr instances (e.g., standard + 4K) and/or multiple Sonarr instances, each tracked independently with per-instance badges and filtering +- **Bulk Import** - One-click population of entire Radarr/Sonarr libraries across all instances - **Path Mapping** - Intelligent path translation for Docker/remote setups ### **Jellyfin Plugin** @@ -200,13 +201,12 @@ SONARR_DB_PATH=/sonarr-config/sonarr.db ```bash # Apply configuration changes docker-compose restart - -# Access web interface -open http://your-server:8081 ``` +Browse to `http://your-server:8081` + Then in the web interface: -1. Click **Admin** tab +1. Open the sidebar and click **Tools** 2. Click **Populate Database** 3. Select **Movies** and/or **TV Shows** 4. Click **Start Population** @@ -335,35 +335,92 @@ SONARR_DB_PASSWORD=sonarr_pass # Sonarr database password (.env.secrets) # See docker-compose.yml.example for volume mount configuration ``` -**SQLite Docker Configuration:** +**Multi-Instance Configuration (v3.0+):** + +Add additional Radarr or Sonarr instances using a `NAME` segment between the prefix and the variable suffix. The name becomes the instance identifier in Chronarr's UI and database. + +The `NAME` segment must be letters, digits, and underscores only — no hyphens (`RADARR_4K` works, `RADARR-4K` doesn't; this is a shell/env-var limitation, not a Chronarr restriction). The *value* you assign to the URL variable has no such restriction and can freely contain hyphens or a full domain name, e.g. `SONARR_STRM_URL=http://sonarr-strm.yourdomain.com:8989`. + +Each instance block is fully self-contained — define all settings including paths directly within it. **Do not use the global `MOVIE_PATHS` or `TV_PATHS` keys in additional instance blocks.** If those keys appear more than once in your env file, Docker only keeps the last value and silently drops the rest, corrupting path matching for every instance. + +```bash +# Main Radarr instance — use RADARR_MOVIE_PATHS, not MOVIE_PATHS +RADARR_URL=http://radarr:7878 +RADARR_API_KEY=your_api_key # (.env.secrets) +RADARR_ROOT_FOLDERS=/mnt/nas/Movies +RADARR_MOVIE_PATHS=/media/movies +RADARR_DB_TYPE=sqlite +RADARR_DB_PATH=/radarr-data/radarr.db + +# Second Radarr instance (e.g., 4K library) +RADARR_4K_URL=http://radarr-4k:7878 +RADARR_4K_API_KEY=your_4k_api_key # (.env.secrets) +RADARR_4K_ROOT_FOLDERS=/mnt/nas/Movies-4K +RADARR_4K_MOVIE_PATHS=/media/movies-4k # ← per-instance, NOT MOVIE_PATHS +RADARR_4K_DB_TYPE=sqlite +RADARR_4K_DB_PATH=/radarr-4k-data/radarr.db + +# Main Sonarr instance — use SONARR_TV_PATHS, not TV_PATHS +SONARR_URL=http://sonarr:8989 +SONARR_API_KEY=your_sonarr_key # (.env.secrets) +SONARR_ROOT_FOLDERS=/mnt/nas/TV +SONARR_TV_PATHS=/media/tv +SONARR_DB_TYPE=sqlite +SONARR_DB_PATH=/sonarr-data/sonarr.db + +# Second Sonarr instance (e.g., anime library) +SONARR_ANIME_URL=http://sonarr-anime:8989 +SONARR_ANIME_API_KEY=your_anime_key # (.env.secrets) +SONARR_ANIME_ROOT_FOLDERS=/mnt/nas/Anime +SONARR_ANIME_TV_PATHS=/media/anime # ← per-instance, NOT TV_PATHS +SONARR_ANIME_DB_TYPE=sqlite +SONARR_ANIME_DB_PATH=/sonarr-anime-data/sonarr.db +``` + +Each named instance gets its own webhook endpoint (`/radarr_4k/webhook`, `/sonarr_anime/webhook`) and appears as a separate entry in the sidebar. An "All" view aggregates across all instances with colored instance badges on each row. + +**SQLite Docker Configuration (multi-instance):** -When using SQLite databases with Docker, you must mount the database directories as read-only volumes. See the Quick Start guide (step 3) or check `docker-compose.yml.example` for detailed examples. +Each SQLite database needs its own volume mount in `docker-compose.yml`. The container path you choose must match the `_DB_PATH` value in your `.env`: + +```yaml +# In docker-compose.yml, under chronarr-core volumes: +- /host/path/to/radarr/config:/radarr-data:ro # → RADARR_DB_PATH=/radarr-data/radarr.db +- /host/path/to/radarr-4k/config:/radarr-4k-data:ro # → RADARR_4K_DB_PATH=/radarr-4k-data/radarr.db +- /host/path/to/sonarr/config:/sonarr-data:ro # → SONARR_DB_PATH=/sonarr-data/sonarr.db +``` + +The `radarr.db` file is usually at the top level of Radarr's config directory. If the database fails to open, browse that directory on your host to find the actual filename and depth, then adjust `DB_PATH` accordingly. See `docker-compose.yml.example` for a complete annotated example. ## Web Interface +The web interface uses a dark sidebar for navigation. Sections expand to show per-instance sub-items; clicking an instance filters the view to that instance only. An "All" sub-item shows the full library with colored instance badges on each row. + ### Dashboard - **Statistics** - Total movies, episodes, dates populated, missing dates - **Source Distribution** - Pie charts showing date source breakdown - **Recent Activity** - Last 7 days of processing history - **Skipped Items** - Items without valid dates -### Movies Tab +### Movies - **Search & Filter** - By title, path, IMDb ID, date status, source +- **Instance Filter** - Click an instance in the sidebar or view all with badges - **Bulk Actions** - Delete, edit dates, update IMDb IDs - **Smart Sorting** - By date added, release date, title - **Debug Tools** - Raw database inspection for troubleshooting -### TV Shows Tab +### TV Shows - **Series Management** - View all series with episode counts and progress - **Episode Browsing** - Detailed episode lists with dates and sources - **Season Filtering** - Filter episodes by season +- **Delete Series** - Remove an entire series and all its episode records +- **Instance Filter** - Click an instance in the sidebar or view all with badges - **Batch Updates** - Update multiple episodes at once -### Admin Tab -- **Database Population** - One-click import from Radarr/Sonarr +### Tools +- **Database Population** - One-click import from Radarr/Sonarr across all instances - **Progress Tracking** - Real-time progress bars and statistics - **Validation** - Pre-population checks for connectivity and permissions -- **Manual Scans** - Trigger ad-hoc scans (future feature) ## API Endpoints @@ -376,7 +433,8 @@ When using SQLite databases with Docker, you must mount the database directories - `POST /api/movies/{imdb_id}/migrate-imdb` - Migrate placeholder IMDb ID to real ID ### TV Shows -- `GET /api/series` - List all series with episode counts +- `GET /api/series` - List all series with episode counts (`?instance=sonarr` to filter) +- `DELETE /api/series/{imdb_id}` - Delete an entire series and all its episodes (`?instance=sonarr`) - `GET /api/series/{imdb_id}/episodes` - Get episodes for series - `GET /api/episodes/{imdb_id}/{season}/{episode}` - Get specific episode - `PUT /api/episodes/{imdb_id}/{season}/{episode}` - Update episode date @@ -384,30 +442,36 @@ When using SQLite databases with Docker, you must mount the database directories - `POST /api/series/{imdb_id}/migrate-imdb` - Migrate series IMDb ID ### Administration -- `POST /admin/populate-database` - Trigger database population +- `POST /admin/populate-database` - Trigger database population across all configured instances - `GET /api/dashboard` - Get dashboard statistics - `GET /health` - Health check endpoint ## Webhook Configuration +Each Radarr/Sonarr instance gets its own webhook endpoint. The URL path matches the instance name derived from the environment variable: `RADARR_URL` → `/radarr/webhook`, `RADARR_4K_URL` → `/radarr_4k/webhook`. + ### Radarr 1. Go to **Settings → Connect** 2. Add **Webhook** connection 3. Configure: - **Name**: Chronarr - - **URL**: `http://chronarr-core:8080/webhook/radarr` + - **URL**: `http://chronarr-core:8080/radarr/webhook` (default instance) - **Triggers**: On Import, On Upgrade, On Rename - **Tags**: (optional, leave blank for all movies) +For a second instance (e.g., `RADARR_4K_URL`), use `http://chronarr-core:8080/radarr_4k/webhook`. + ### Sonarr 1. Go to **Settings → Connect** 2. Add **Webhook** connection 3. Configure: - **Name**: Chronarr - - **URL**: `http://chronarr-core:8080/webhook/sonarr` + - **URL**: `http://chronarr-core:8080/sonarr/webhook` (default instance) - **Triggers**: On Import, On Upgrade, On Rename, On Episode File Delete - **Tags**: (optional, leave blank for all series) +For a second instance (e.g., `SONARR_ANIME_URL`), use `http://chronarr-core:8080/sonarr_anime/webhook`. + ## Jellyfin Integration Chronarr includes a Jellyfin plugin that automatically syncs episode and movie dates to Jellyfin, ensuring your media library displays the correct import dates from Chronarr instead of scan dates. @@ -472,7 +536,7 @@ docker exec -it chronarr-core psql -h radarr-db -U radarr -d radarr-main ### Missing Dates - Check **Dashboard** → **Skipped Items** section -- Review **Source** column in Movies/TV tabs +- Review **Source** column in the Movies or TV Shows sections - Use **Debug** button to inspect raw database data - Verify Radarr/Sonarr have import history data @@ -486,15 +550,16 @@ docker exec -it chronarr-core psql -h radarr-db -U radarr -d radarr-main ### Project Structure ``` chronarr/ -├── api/ # API route handlers +├── api/ # Core API route handlers ├── clients/ # Radarr/Sonarr API clients ├── config/ # Configuration management ├── core/ # Core database and logic -├── chronarr-web/ # Web interface container -│ ├── static/ # HTML, CSS, JavaScript -│ └── api/ # Web-specific API routes -├── processors/ # Webhook processors (legacy) -├── utils/ # Utility functions +├── chronarr-web/ # Web interface container +│ ├── static/ # HTML, CSS, JavaScript (served by web container) +│ └── api/ # Web-specific API routes (web_routes.py) +├── static/ # Shared static assets +├── processors/ # Webhook processors +├── utils/ # Utility functions └── docker-compose.yml.example # Docker Compose configuration template ``` @@ -507,8 +572,9 @@ cd chronarr # Build Docker image docker build -t chronarr:dev . -# Run with development settings -docker-compose -f docker-compose.dev.yml up -d +# Run with the example compose file +cp docker-compose.yml.example docker-compose.yml +docker-compose up -d ``` ## FAQ @@ -529,11 +595,11 @@ A: Yes, Chronarr can read from both SQLite and PostgreSQL databases for both Rad Chronarr's core application does not collect personal data. It reads only from your local Radarr and Sonarr databases and stores date information in your own PostgreSQL instance. -The **Emby plugin** collects the following information during license registration: +The **Emby and Jellyfin plugins** collect the following information during license registration: - **Name** — used to identify your license - **Email address** — used to deliver your license key and send license status notifications -- **Server name** — used to associate a license with a specific Emby installation +- **Server name** — used to associate a license with a specific media server installation This data is transmitted to the Chronarr license server and is used solely for license management. It is never sold, shared with third parties, or used for any purpose other than validating and managing your license. @@ -554,8 +620,33 @@ This project is licensed under the MIT License - see the LICENSE file for detail - **GitHub Issues**: [https://github.com/sbcrumb/chronarr/issues](https://github.com/sbcrumb/chronarr/issues) +## Upgrading from v2 to v3 + +v3 is a drop-in upgrade for single-instance setups. Pull the new image and restart — no config changes are required. + +**What you'll notice immediately:** +- The horizontal tab bar is replaced by a collapsible sidebar. Dashboard, Movies, TV Shows, Reports, and Tools are all still there. +- The "Admin" tab is now **Tools** in the sidebar. + +**Webhooks:** The old `/webhook/radarr` and `/webhook/sonarr` URLs still work — they're kept as aliases. The new canonical format is `/radarr/webhook` and `/sonarr/webhook`, and you can update your Radarr/Sonarr connections at any time, but there's no urgency. + +**Database:** Schema migrations run automatically on startup. Existing movie and episode records are preserved and tagged with the default instance name (`radarr` / `sonarr`). + +**Multi-instance (optional):** If you run a second Radarr (e.g., 4K) or second Sonarr, see the [Multi-Instance Configuration](#multi-instance-configuration-v30) block in the Configuration section. Each extra instance just needs a `RADARR_{NAME}_URL` block in your `.env` and its own webhook connection in Radarr/Sonarr. + +--- + ## Changelog +### v3.0.0 +- 🏠 **Sidebar navigation** - Replaced horizontal tab bar with a collapsible dark sidebar; instance sub-items expand under Movies and TV Shows +- 🔀 **Multi-instance support** - Configure multiple Radarr and/or Sonarr instances; each is tracked separately and shown with colored badges in the UI +- 🏷️ **Instance badges** - Every row in the Movies and TV tables shows a colored badge identifying its instance; badge colors are consistent between the sidebar and the table +- 🚀 **Cold-start populate fix** - Database population on startup now iterates all configured instances, not just the first +- 🗑️ **Delete series** - Remove an entire TV series and all its episode records from the database in one click +- 🔧 **Instance-aware edit** - Date edits, smart fixes, and skipped-item updates are now scoped to the correct instance +- 🧹 **Series title cleanup** - Series titles derived from folder paths no longer include media-manager ID suffixes (e.g., `[imdb-tt1234567]`) + ### v2.0.0 (2025-11-05) - 🎉 **Initial release** - Comprehensive date and chronology management for Radarr and Sonarr - 🎯 **Smart date tracking** - Multiple sources with intelligent fallback hierarchy diff --git a/api/models.py b/api/models.py index 148aa88..38394f4 100644 --- a/api/models.py +++ b/api/models.py @@ -49,7 +49,8 @@ class HealthResponse(BaseModel): version: str uptime: str database_status: str - radarr_database: Optional[Dict[str, Any]] = None + radarr_database: Optional[Dict[str, Any]] = None # legacy — default Radarr instance only, kept for back-compat + instances: Optional[Dict[str, Dict[str, Any]]] = None # {"radarr": {name: {connected, method}}, "sonarr": {...}} — every configured instance class TVSeasonRequest(BaseModel): @@ -251,4 +252,78 @@ class CleanupExecutionResponse(BaseModel): execution_time_seconds: Optional[int] error_message: Optional[str] report_json: Optional[str] - triggered_by: Optional[str] \ No newline at end of file + triggered_by: Optional[str] + + +class WizardConnectionTestRequest(BaseModel): + """Setup wizard: test a Radarr/Sonarr URL+API key or a direct DB connection. + + Send either url+api_key, or a db_type block, or both — whatever the + form has filled in so far. Doesn't touch any files. + """ + media_type: str # "radarr" or "sonarr" + name: Optional[str] = None # not validated here — just used to label log lines during the test + url: Optional[str] = None + api_key: Optional[str] = None + db_type: Optional[str] = None # "sqlite" or "postgresql" + db_host: Optional[str] = None + db_port: Optional[int] = None + db_name: Optional[str] = None + db_user: Optional[str] = None + db_password: Optional[str] = None + db_path: Optional[str] = None + + +class WizardSaveInstanceRequest(BaseModel): + """Setup wizard: write a Radarr/Sonarr instance to .env / .env.secrets. + + `name` is the user-typed instance name (e.g. "4k" or "strm") — leave it + empty to configure the default instance. `force` skips the connection + test failing being a hard stop, for someone who knows the service is + just down right now and wants to save the config anyway. `edit_existing` + flips the name check: normally a name must NOT already exist (adding a + new instance); with edit_existing=True it must ALREADY exist instead — + editing something that was never configured isn't a valid request either. + """ + media_type: str # "radarr" or "sonarr" + name: str = "" + url: str + api_key: str + root_folders: Optional[List[str]] = None + movie_paths: Optional[List[str]] = None # radarr instances only + tv_paths: Optional[List[str]] = None # sonarr instances only + db_type: Optional[str] = None + db_host: Optional[str] = None + db_port: Optional[int] = None + db_name: Optional[str] = None + db_user: Optional[str] = None + db_password: Optional[str] = None + db_path: Optional[str] = None + force: bool = False + edit_existing: bool = False + + +class WizardDeleteInstanceRequest(BaseModel): + """Setup wizard: remove a Radarr/Sonarr instance from .env / .env.secrets. + + Removes every env var this instance's name segment owns. Same automatic + pre-write snapshot every other wizard write already takes. + """ + media_type: str # "radarr" or "sonarr" + name: str = "" # "" targets the default (unprefixed) instance + + +class WizardEnvRestoreRequest(BaseModel): + """Setup wizard: restore .env / .env.secrets from a backup file's contents. + + `env` and `env_secrets` are the raw file text, exactly as + GET /api/wizard/env-backup produced them — this overwrites both files + verbatim, not a merge. `chronarr_version`/`exported_at` are informational + only, from the backup's own header; nothing currently rejects a restore + over a version mismatch, but they're captured in case that's worth + warning about later. + """ + env: str + env_secrets: str + chronarr_version: Optional[str] = None + exported_at: Optional[str] = None \ No newline at end of file diff --git a/api/routes.py b/api/routes.py index d1d3352..17122f1 100644 --- a/api/routes.py +++ b/api/routes.py @@ -2,11 +2,16 @@ FastAPI routes for Chronarr - extracted from main chronarr.py for modular architecture """ import os +import re import hmac import hashlib import json +import uuid import requests import asyncio +import tempfile +import multiprocessing +from collections import deque from pathlib import Path from datetime import datetime, timezone from fastapi import HTTPException, BackgroundTasks, Request, Response @@ -16,7 +21,8 @@ from api.models import ( SonarrWebhook, RadarrWebhook, MaintainarrWebhook, HealthResponse, TVSeasonRequest, TVEpisodeRequest, MovieUpdateRequest, EpisodeUpdateRequest, BulkUpdateRequest, OrphanedCleanupRequest, - CreateScheduledCleanupRequest, UpdateScheduledCleanupRequest, ScheduledCleanupResponse, CleanupExecutionResponse + CreateScheduledCleanupRequest, UpdateScheduledCleanupRequest, ScheduledCleanupResponse, CleanupExecutionResponse, + WizardConnectionTestRequest, WizardSaveInstanceRequest, WizardEnvRestoreRequest, WizardDeleteInstanceRequest ) # Import logging utility from utils.logging import _log @@ -80,8 +86,8 @@ async def _verify_webhook_signature(request: Request, body: bytes, secret: str, # Route Handlers # --------------------------- -async def sonarr_webhook(request: Request, background_tasks: BackgroundTasks, dependencies: dict): - """Handle Sonarr webhooks""" +async def sonarr_webhook(request: Request, background_tasks: BackgroundTasks, dependencies: dict, instance: str = "sonarr"): + """Handle Sonarr webhooks — instance name comes from the URL path.""" tv_processor = dependencies["tv_processor"] batcher = dependencies["batcher"] config = dependencies["config"] @@ -94,7 +100,13 @@ async def sonarr_webhook(request: Request, background_tasks: BackgroundTasks, de raise HTTPException(status_code=422, detail="Empty Sonarr payload") webhook = SonarrWebhook(**payload) - _log("INFO", f"Received Sonarr webhook: {webhook.eventType}") + # Short id so related log lines across the async receive -> batch -> + # background-thread processing hop can be told apart from other + # webhooks landing around the same time, without needing to thread it + # through every internal call — see it again at the batch/process + # boundaries in webhooks/webhook_batcher.py. + req_id = uuid.uuid4().hex[:6] + _log("INFO", f"[{instance}:{req_id}] Received Sonarr webhook: {webhook.eventType}") if webhook.eventType not in ["Download", "Upgrade", "Rename"]: return {"status": "ignored", "reason": f"Event type {webhook.eventType} not processed"} @@ -110,24 +122,25 @@ async def sonarr_webhook(request: Request, background_tasks: BackgroundTasks, de sonarr_path = series_info.get("path", "") if not imdb_id: - _log("ERROR", f"No IMDb ID for series: {series_title}") + _log("ERROR", f"[{instance}:{req_id}] No IMDb ID for series: {series_title}") return {"status": "error", "reason": "No IMDb ID"} - - # Find series path - series_path = tv_processor.find_series_path(series_title, imdb_id, sonarr_path) + + # Find series path — instance-aware so a named instance's own root + # folder mapping is used, not always the default instance's. + series_path = tv_processor.find_series_path(series_title, imdb_id, sonarr_path, instance=instance) if not series_path: - print(f"ERROR: Could not find series directory: {series_title} ({imdb_id})") + _log("ERROR", f"[{instance}:{req_id}] Could not find series directory: {series_title} ({imdb_id})") return {"status": "error", "reason": "Series directory not found"} - + # Extract episode data for targeted processing episodes_data = webhook.episodes or [] - _log("DEBUG", f"Initial episodes_data from webhook.episodes: {len(episodes_data)} episodes") + _log("DEBUG", f"[{instance}:{req_id}] Initial episodes_data from webhook.episodes: {len(episodes_data)} episodes") # For all webhook events, if no episodes in webhook.episodes, try to extract from episodeFile # This ensures targeted processing for single episode operations (Download, Rename, Upgrade) - _log("DEBUG", f"webhook.episodeFile present: {webhook.episodeFile is not None}") + _log("DEBUG", f"[{instance}:{req_id}] webhook.episodeFile present: {webhook.episodeFile is not None}") if webhook.episodeFile: - _log("DEBUG", f"episodeFile content: {webhook.episodeFile}") + _log("DEBUG", f"[{instance}:{req_id}] episodeFile content: {webhook.episodeFile}") if not episodes_data and webhook.episodeFile: episode_file = webhook.episodeFile @@ -141,17 +154,17 @@ async def sonarr_webhook(request: Request, background_tasks: BackgroundTasks, de # Try relativePath first, then path file_path = episode_file.get("relativePath") or episode_file.get("path", "") - _log("DEBUG", f"Parsing episode info from path: {file_path}") + _log("DEBUG", f"[{instance}:{req_id}] Parsing episode info from path: {file_path}") episode_info = extract_episode_info_from_filename(file_path) if episode_info: season_num = episode_info["season"] episode_num = episode_info["episode"] - _log("DEBUG", f"Extracted from filename - Season: {season_num}, Episode: {episode_num}") + _log("DEBUG", f"[{instance}:{req_id}] Extracted from filename - Season: {season_num}, Episode: {episode_num}") else: - _log("DEBUG", f"Could not extract season/episode from filename: {file_path}") + _log("DEBUG", f"[{instance}:{req_id}] Could not extract season/episode from filename: {file_path}") - _log("DEBUG", f"episodeFile seasonNumber: {season_num}, episodeNumber: {episode_num}") + _log("DEBUG", f"[{instance}:{req_id}] episodeFile seasonNumber: {season_num}, episodeNumber: {episode_num}") if season_num and episode_num: # Create episode data structure that matches what process_webhook_episodes expects episodes_data = [{ @@ -161,37 +174,37 @@ async def sonarr_webhook(request: Request, background_tasks: BackgroundTasks, de "title": episode_file.get("title") # Note: Not including dateAdded - we use database-first approach with Sonarr fallback }] - _log("INFO", f"Extracted episode info from episodeFile for {webhook.eventType}: S{season_num:02d}E{episode_num:02d}") + _log("INFO", f"[{instance}:{req_id}] Extracted episode info from episodeFile for {webhook.eventType}: S{season_num:02d}E{episode_num:02d}") else: - _log("DEBUG", f"Missing season/episode numbers in episodeFile for {webhook.eventType}") + _log("DEBUG", f"[{instance}:{req_id}] Missing season/episode numbers in episodeFile for {webhook.eventType}") # Special handling for Rename events - Sonarr doesn't include episodeFile for renames # Try to find recently renamed episodes using Sonarr history API if not episodes_data and webhook.eventType == "Rename": - _log("DEBUG", f"Attempting to find recently renamed episode for series {imdb_id}") + _log("DEBUG", f"[{instance}:{req_id}] Attempting to find recently renamed episode for series {imdb_id}") try: # Get series info from Sonarr to find series ID series_lookup_url = f"{config.sonarr_url}/api/v3/series/lookup?term=imdbid:{imdb_id}" - _log("DEBUG", f"Sonarr lookup for rename: {series_lookup_url}") + _log("DEBUG", f"[{instance}:{req_id}] Sonarr lookup for rename: {series_lookup_url}") response = requests.get(series_lookup_url, headers={"X-Api-Key": os.environ.get("SONARR_API_KEY", "")}, timeout=10) if response.status_code == 200: series_results = response.json() if series_results: series_id = series_results[0].get("id") - _log("DEBUG", f"Found series ID {series_id} for rename lookup") + _log("DEBUG", f"[{instance}:{req_id}] Found series ID {series_id} for rename lookup") # Get recent history for the series and filter for rename events from datetime import datetime, timedelta since_date = (datetime.utcnow() - timedelta(hours=1)).strftime('%Y-%m-%dT%H:%M:%SZ') history_url = f"{config.sonarr_url}/api/v3/history?seriesId={series_id}&sortKey=date&sortDir=desc&page=1&pageSize=50" - _log("DEBUG", f"Checking recent rename history: {history_url}") + _log("DEBUG", f"[{instance}:{req_id}] Checking recent rename history: {history_url}") history_response = requests.get(history_url, headers={"X-Api-Key": os.environ.get("SONARR_API_KEY", "")}, timeout=10) if history_response.status_code == 200: history_data = history_response.json() all_records = history_data.get("records", []) - _log("DEBUG", f"Got {len(all_records)} total history records") + _log("DEBUG", f"[{instance}:{req_id}] Got {len(all_records)} total history records") # Filter for recent rename events since_timestamp = datetime.utcnow() - timedelta(hours=1) @@ -211,16 +224,16 @@ async def sonarr_webhook(request: Request, background_tasks: BackgroundTasks, de # If datetime parsing fails, include it anyway recent_renames.append(record) - _log("DEBUG", f"Found {len(recent_renames)} recent rename events") + _log("DEBUG", f"[{instance}:{req_id}] Found {len(recent_renames)} recent rename events") if recent_renames: # Take the most recent rename event latest_rename = recent_renames[0] - _log("DEBUG", f"Processing latest rename event") + _log("DEBUG", f"[{instance}:{req_id}] Processing latest rename event") # Extract episodeId directly from the rename event episode_id = latest_rename.get("episodeId") - _log("DEBUG", f"Found episodeId {episode_id} in rename event") + _log("DEBUG", f"[{instance}:{req_id}] Found episodeId {episode_id} in rename event") if episode_id: # Fetch episode details using the episodeId @@ -233,7 +246,7 @@ async def sonarr_webhook(request: Request, background_tasks: BackgroundTasks, de episode_num = episode_detail.get("episodeNumber") episode_title = episode_detail.get("title") - _log("DEBUG", f"Episode details - Season: {season_num}, Episode: {episode_num}, Title: {episode_title}") + _log("DEBUG", f"[{instance}:{req_id}] Episode details - Season: {season_num}, Episode: {episode_num}, Title: {episode_title}") if season_num is not None and episode_num is not None: episodes_data = [{ @@ -242,52 +255,54 @@ async def sonarr_webhook(request: Request, background_tasks: BackgroundTasks, de "id": episode_id, "title": episode_title }] - print(f"INFO: Successfully identified renamed episode: S{season_num:02d}E{episode_num:02d} - {episode_title}") + _log("INFO", f"[{instance}:{req_id}] Successfully identified renamed episode: S{season_num:02d}E{episode_num:02d} - {episode_title}") else: - _log("DEBUG", f"Episode details missing season/episode numbers") + _log("DEBUG", f"[{instance}:{req_id}] Episode details missing season/episode numbers") else: - _log("DEBUG", f"Failed to fetch episode details: {episode_response.status_code}") + _log("DEBUG", f"[{instance}:{req_id}] Failed to fetch episode details: {episode_response.status_code}") else: - _log("DEBUG", f"No episodeId found in rename event") + _log("DEBUG", f"[{instance}:{req_id}] No episodeId found in rename event") else: - _log("DEBUG", f"No recent rename events found in last hour") + _log("DEBUG", f"[{instance}:{req_id}] No recent rename events found in last hour") else: - _log("DEBUG", f"Failed to get rename history: {history_response.status_code}") + _log("DEBUG", f"[{instance}:{req_id}] Failed to get rename history: {history_response.status_code}") else: - _log("DEBUG", f"No series found for IMDb {imdb_id}") + _log("DEBUG", f"[{instance}:{req_id}] No series found for IMDb {imdb_id}") else: - _log("DEBUG", f"Series lookup failed: {response.status_code}") + _log("DEBUG", f"[{instance}:{req_id}] Series lookup failed: {response.status_code}") except Exception as e: - _log("DEBUG", f"Error finding renamed episode: {e}") + _log("DEBUG", f"[{instance}:{req_id}] Error finding renamed episode: {e}") # Continue with series processing as fallback # Force targeted mode for single-episode webhooks to prevent full series processing processing_mode = config.tv_webhook_processing_mode if episodes_data and len(episodes_data) <= 3: # Single episode or small batch processing_mode = "targeted" - _log("INFO", f"Forcing targeted mode for {len(episodes_data)} episode(s)") + _log("INFO", f"[{instance}:{req_id}] Forcing targeted mode for {len(episodes_data)} episode(s)") - # Add to batch queue with TV-prefixed key to avoid movie conflicts tv_batch_key = f"tv:{imdb_id}" webhook_dict = { 'path': str(series_path), 'series_info': series_info, 'event_type': webhook.eventType, - 'episodes': episodes_data, # Include enhanced episode data for targeted processing - 'processing_mode': processing_mode # Use forced targeted mode when appropriate + 'episodes': episodes_data, + 'processing_mode': processing_mode, + 'instance': instance, + 'req_id': req_id, } batcher.add_webhook(tv_batch_key, webhook_dict, 'tv') return {"status": "accepted", "message": f"Sonarr webhook queued for {tv_batch_key}"} - + except Exception as e: - _log("ERROR", f"Sonarr webhook error: {e}") + _log("ERROR", f"[{instance}:{req_id}] Sonarr webhook error: {e}") raise HTTPException(status_code=422, detail=f"Invalid webhook: {e}") -async def radarr_webhook(request: Request, background_tasks: BackgroundTasks, dependencies: dict): - """Handle Radarr webhooks""" - path_mapper = dependencies["path_mapper"] +async def radarr_webhook(request: Request, background_tasks: BackgroundTasks, dependencies: dict, instance: str = "radarr"): + """Handle Radarr webhooks — instance name comes from the URL path.""" + registry = dependencies.get("registry") + path_mapper = registry.radarr_mapper(instance) if registry else dependencies.get("path_mapper") batcher = dependencies["batcher"] config = dependencies["config"] @@ -295,9 +310,25 @@ async def radarr_webhook(request: Request, background_tasks: BackgroundTasks, de body = await request.body() await _verify_webhook_signature(request, body, config.radarr_webhook_secret, "X-Radarr-Signature") payload = await _read_payload(request) - _log("INFO", f"Received Radarr webhook: {payload.get('eventType', 'Unknown')}") - _log("DEBUG", f"Full Radarr webhook payload: {payload}") - + # Short id so related log lines across the async receive -> batch -> + # background-thread processing hop can be told apart from other + # webhooks landing around the same time — see it again at the + # batch/process boundaries in webhooks/webhook_batcher.py. + req_id = uuid.uuid4().hex[:6] + _log("INFO", f"[{instance}:{req_id}] Received Radarr webhook: {payload.get('eventType', 'Unknown')}") + # A compact summary by default — the full payload is a multi-KB blob that + # drowns out everything around it. Set LOG_RAW_WEBHOOK_PAYLOADS=true for + # the old full-dump behavior when deep-debugging a specific webhook. + _movie = payload.get('movie', {}) or {} + _movie_file = payload.get('movieFile', {}) or {} + _log("DEBUG", ( + f"[{instance}:{req_id}] Radarr webhook summary: title={_movie.get('title')!r} " + f"imdb={_movie.get('imdbId')} year={_movie.get('year')} " + f"path={_movie_file.get('path') or _movie.get('folderPath')}" + )) + if os.environ.get("LOG_RAW_WEBHOOK_PAYLOADS", "false").lower() == "true": + _log("DEBUG", f"[{instance}:{req_id}] Full Radarr webhook payload: {payload}") + # Filter supported event types (same as Sonarr: Download, Upgrade, Rename) event_type = payload.get('eventType', '') if event_type not in ["Download", "Upgrade", "Rename"]: @@ -306,50 +337,50 @@ async def radarr_webhook(request: Request, background_tasks: BackgroundTasks, de # Extract movie info movie_data = payload.get("movie", {}) if not movie_data: - _log("WARNING", "No movie data in Radarr webhook") + _log("WARNING", f"[{instance}:{req_id}] No movie data in Radarr webhook") return {"status": "error", "message": "No movie data"} # Get IMDb ID for batching key imdb_id = movie_data.get("imdbId", "").lower() if not imdb_id: - _log("WARNING", "No IMDb ID in Radarr webhook movie data") + _log("WARNING", f"[{instance}:{req_id}] No IMDb ID in Radarr webhook movie data") return {"status": "error", "message": "No IMDb ID"} # Get movie path and map it movie_path = movie_data.get("folderPath") or movie_data.get("path", "") if not movie_path: - _log("ERROR", "No movie path in Radarr webhook") + _log("ERROR", f"[{instance}:{req_id}] No movie path in Radarr webhook") return {"status": "error", "message": "No movie path provided"} # Map the path to container path container_path = path_mapper.radarr_path_to_container_path(movie_path) - _log("DEBUG", f"Mapped Radarr path {movie_path} -> {container_path}") + _log("DEBUG", f"[{instance}:{req_id}] Mapped Radarr path {movie_path} -> {container_path}") # CRITICAL: Verify the mapped path actually exists if not Path(container_path).exists(): - _log("ERROR", f"RADARR WEBHOOK REJECTED: Mapped path does not exist: {container_path}") - _log("ERROR", "This prevents processing wrong movies due to path mapping issues") + _log("ERROR", f"[{instance}:{req_id}] RADARR WEBHOOK REJECTED: Mapped path does not exist: {container_path}") + _log("ERROR", f"[{instance}:{req_id}] This prevents processing wrong movies due to path mapping issues") return {"status": "error", "message": f"Mapped movie path does not exist: {container_path}"} # IMDb ID won't be in the path for standard Radarr folder naming — omit the check - # Create movie-specific webhook data with proper path validation movie_webhook_data = { - 'path': container_path, # Use verified container path + 'path': container_path, 'movie_info': movie_data, 'event_type': payload.get('eventType'), - 'original_payload': payload + 'original_payload': payload, + 'instance': instance, + 'req_id': req_id, } - - # Add to batch queue with movie-prefixed key to avoid TV conflicts + movie_batch_key = f"movie:{imdb_id}" - _log("DEBUG", f"Adding Radarr webhook to batch: key={movie_batch_key}, movie_title={movie_data.get('title', 'Unknown')}") + _log("DEBUG", f"[{instance}:{req_id}] Adding Radarr webhook to batch: key={movie_batch_key}, movie_title={movie_data.get('title', 'Unknown')}, instance={instance}") batcher.add_webhook(movie_batch_key, movie_webhook_data, "movie") return {"status": "success", "message": f"Radarr webhook queued for {movie_batch_key}"} except Exception as e: - _log("ERROR", f"Radarr webhook error: {e}") + _log("ERROR", f"[{instance}:{req_id}] Radarr webhook error: {e}") return {"status": "error", "message": str(e)} @@ -568,13 +599,27 @@ async def health(dependencies: dict) -> HealthResponse: except Exception as e: # If movie processor isn't available, skip database health check _log("DEBUG", f"Skipping Radarr database health check: {e}") - + + # Per-instance status for every configured Radarr/Sonarr — not just the + # default instance the block above checks. This is what /setup already + # shows as connected/disconnected badges; /health was never updated to + # report the same thing when multi-instance landed, so a dual-instance + # user had no way to see a second instance's connection state from here. + registry = dependencies.get("registry") + instances = None + if registry: + instances = { + "radarr": registry.all_radarr_statuses(), + "sonarr": registry.all_sonarr_statuses(), + } + return HealthResponse( status=overall_status, version=version, uptime=str(uptime), database_status=db_status, - radarr_database=radarr_db_health + radarr_database=radarr_db_health, + instances=instances, ) @@ -818,7 +863,7 @@ async def run_scan(): sonarr_path_index = {} def _unc_basename(p): - """Return the last path component of p, handling both POSIX and + r"""Return the last path component of p, handling both POSIX and Windows/UNC paths (pathlib on Linux treats backslash as a literal character, so Path(r'\\NAS\share\Movie (2013)').name returns the whole string rather than 'Movie (2013)').""" @@ -1635,24 +1680,29 @@ async def cleanup_orphaned_records_hybrid(request: OrphanedCleanupRequest, depen from utils.orphaned_cleanup import OrphanedRecordCleaner db = dependencies["db"] - radarr_db_client = dependencies.get("radarr_db_client") - sonarr_db_client = dependencies.get("sonarr_db_client") + registry = dependencies.get("registry") try: - # Initialize the cleaner with available database clients + # Initialize the cleaner — registry lets it resolve the right + # Radarr/Sonarr client per row's own instance instead of a single + # fixed client (the old radarr_db_client/sonarr_db_client keys were + # never actually populated in dependencies, so check_database was + # silently inert before this). cleaner = OrphanedRecordCleaner( chronarr_db=db, - radarr_db_client=radarr_db_client, - sonarr_db_client=sonarr_db_client + registry=registry ) # Validate that we can perform the requested checks warnings = [] if request.check_database: - if request.check_movies and not radarr_db_client: - warnings.append("Radarr database client not configured - movie database validation disabled") - if request.check_series and not sonarr_db_client: - warnings.append("Sonarr database client not configured - series database validation disabled") + if not registry: + warnings.append("Instance registry not available - database validation disabled") + else: + if request.check_movies and not registry.radarr_names: + warnings.append("No Radarr instances configured - movie database validation disabled") + if request.check_series and not registry.sonarr_names: + warnings.append("No Sonarr instances configured - series database validation disabled") _log("INFO", f"Starting hybrid orphaned record cleanup (dry_run={request.dry_run})") @@ -2569,44 +2619,67 @@ async def update_episode_nfo(imdb_id: str, season: int, episode: int, request: R # Emby Plugin Lookup Functions # --------------------------- -async def lookup_episode(imdb_id: str, season: int, episode: int, dependencies: dict): +async def lookup_episode(imdb_id: str, season: int, episode: int, dependencies: dict, instance: str = None): """ Lookup episode dateadded from Chronarr database for Emby plugin integration - + Returns dateadded information if found, or null if not available. Used by Emby plugin to populate missing dateadded elements in NFO files. + + The plugin's request has no concept of instance (it predates multi-instance + support) — when instance isn't given, search across every instance sharing + this imdb_id/season/episode instead of silently defaulting to 'sonarr' only, + which would miss any row that exists solely under a named instance. """ try: - _log("DEBUG", f"Episode lookup called for {imdb_id} S{season:02d}E{episode:02d}") - + _log("DEBUG", f"Episode lookup called for {imdb_id} S{season:02d}E{episode:02d} (instance: {instance or 'any'})") + db = dependencies.get("db") if not db: print(f"ERROR: Database not available in dependencies") raise HTTPException(status_code=500, detail="Database not available") - + # Normalize IMDb ID (ensure tt prefix) if not imdb_id.startswith('tt'): imdb_id = f"tt{imdb_id}" - + _log("DEBUG", f"Querying database for episode {imdb_id} S{season:02d}E{episode:02d}") - + # Query database for episode - result = db.get_episode_date(imdb_id, season, episode) - + if instance: + result = db.get_episode_date(imdb_id, season, episode, instance) + else: + result = db.get_episode_date_any_instance(imdb_id, season, episode) + _log("DEBUG", f"Database query result: {result}") if result and result.get('dateadded'): # Format response for Emby plugin dateadded = result['dateadded'] - + # Convert datetime to ISO string if needed if hasattr(dateadded, 'isoformat'): dateadded_str = dateadded.isoformat() else: dateadded_str = str(dateadded) - + # NOTE: Auto-fix functionality removed - just return database data - + + # One INFO line per lookup — same convention as the webhook + # handlers ("Received Sonarr webhook..."). The DEBUG lines above + # are silent by default now (LOG_LEVEL=INFO), so without this, + # a plugin scan (scheduled full-library or single-item) never + # showed up on Chronarr's side at all, only in Emby/Jellyfin's + # own log — there was no INFO-level line on a normal lookup, + # only on an outright error. Title comes from the series row + # (episodes has no title column of its own); clearing the miss + # record here means a show that resolves later drops off the + # Unresolved Lookups page on its own. + series_title = db.get_series_title_any_instance(imdb_id) + db.clear_lookup_miss(imdb_id, 'episode', season, episode) + title_part = f'"{series_title}" ' if series_title else '' + _log("INFO", f"Plugin lookup: episode {title_part}({imdb_id}) S{season:02d}E{episode:02d} -> found (source={result.get('source', 'database')})") + return { "found": True, "imdb_id": imdb_id, @@ -2615,10 +2688,26 @@ async def lookup_episode(imdb_id: str, season: int, episode: int, dependencies: "dateadded": dateadded_str, "source": result.get('source', 'database'), "air_date": result.get('air_date') if result.get('air_date') else None, + "instance": result.get('instance'), "auto_fixed": False # Auto-fix functionality disabled } else: - # Not found in database + # Not found — see lookup_movie() for why this distinguishes "no + # episode row at all" from "row exists, no resolved date yet". + # A series row can exist (with a title) even when this + # particular episode row doesn't, so the title lookup is + # independent of whether `result` itself is set. + series_title = db.get_series_title_any_instance(imdb_id) + reason, reason_desc = ('no_resolved_date', 'in DB, no resolved date yet') if result \ + else ('no_db_record', 'no episode record' if series_title else 'no DB record') + + db.record_lookup_miss( + imdb_id, 'episode', reason, instance=instance, title=series_title, + season=season, episode=episode + ) + + title_part = f'"{series_title}" ' if series_title else '' + _log("INFO", f"Plugin lookup: episode {title_part}({imdb_id}) S{season:02d}E{episode:02d} -> not found ({reason_desc})") return { "found": False, "imdb_id": imdb_id, @@ -2628,7 +2717,7 @@ async def lookup_episode(imdb_id: str, season: int, episode: int, dependencies: "source": None, "air_date": None } - + except Exception as e: _log("ERROR", f"Episode lookup failed for {imdb_id} S{season:02d}E{episode:02d}: {e}") raise HTTPException(status_code=500, detail=f"Episode lookup failed: {str(e)}") @@ -2812,28 +2901,52 @@ async def lookup_movie_by_title(title: str, year: str, dependencies: dict): raise HTTPException(status_code=500, detail=f"Movie title lookup failed: {str(e)}") -async def lookup_movie(imdb_id: str, dependencies: dict): +def _movie_title_from_result(result: Optional[dict]) -> Optional[str]: + """Best-effort title for a movies-table row for plugin-lookup logging. + + movies.title is only ever set once a title has come back from the + date-resolution pipeline (upsert_movie_dates) — a row created by the + bare upsert_movie() path (e.g. still waiting on a date) can have a real + path but a NULL title. Same situation as episodes/series — fall back to + parsing it out of the directory name rather than showing nothing. + """ + if not result: + return None + title = result.get('title') + if title: + return title + path = result.get('path') + if not path or path == 'unknown': + return None + from utils.file_utils import extract_title_from_directory_name + return extract_title_from_directory_name(Path(path).name) + + +async def lookup_movie(imdb_id: str, dependencies: dict, instance: str = None): """ Lookup movie dateadded from Chronarr database for Emby plugin integration - - Returns dateadded information if found, or null if not available. + + Returns dateadded information if found, or null if not available. Used by Emby plugin to populate missing dateadded elements in NFO files. + + See lookup_episode() for why instance is optional and how it's resolved + when the caller (the plugin, which predates multi-instance) doesn't send one. """ try: db = dependencies.get("db") if not db: raise HTTPException(status_code=500, detail="Database not available") - - _log("DEBUG", f"Movie lookup called for IMDb ID: {imdb_id}") - + + _log("DEBUG", f"Movie lookup called for IMDb ID: {imdb_id} (instance: {instance or 'any'})") + # Normalize IMDb ID (ensure tt prefix) if not imdb_id.startswith('tt'): imdb_id = f"tt{imdb_id}" - + _log("DEBUG", f"Normalized IMDb ID: {imdb_id}") - + # Query database for movie - result = db.get_movie_dates(imdb_id) + result = db.get_movie_dates(imdb_id, instance) if instance else db.get_movie_dates_any_instance(imdb_id) _log("DEBUG", f"Movie lookup for {imdb_id}: database result = {result}") # If not found, let's see what movies we DO have in the database @@ -2848,25 +2961,54 @@ async def lookup_movie(imdb_id: str, dependencies: dict): if result and result.get('dateadded'): # Format response for Emby plugin dateadded = result['dateadded'] - + # Convert datetime to ISO string if needed if hasattr(dateadded, 'isoformat'): dateadded_str = dateadded.isoformat() else: dateadded_str = str(dateadded) - + # NOTE: Auto-fix functionality removed - just return database data - + + # One INFO line per lookup — see lookup_episode() for why this is + # needed: the DEBUG lines above are silent by default now + # (LOG_LEVEL=INFO), so a plugin scan never showed up on + # Chronarr's side at all, only in Emby/Jellyfin's own log. + # Title makes the line useful without cross-referencing the ID + # by hand; clearing any stale miss record means a title that + # later resolves drops off the Unresolved Lookups page on its + # own instead of sitting there claiming it's still broken. + movie_title = _movie_title_from_result(result) + db.clear_lookup_miss(imdb_id, 'movie') + title_part = f'"{movie_title}" ' if movie_title else '' + _log("INFO", f"Plugin lookup: movie {title_part}({imdb_id}) -> found (source={result.get('source', 'database')})") + return { "found": True, "imdb_id": imdb_id, "dateadded": dateadded_str, "source": result.get('source', 'database'), "released": result.get('released') if result.get('released') else None, + "instance": result.get('instance'), "auto_fixed": False # Auto-fix functionality disabled } else: - # Not found in database + # Not found — but "not found" means two very different things, and + # collapsing them into one log line made it impossible to tell + # which one you're looking at without going and checking the DB + # by hand. `result` is the movie row (if any) from the + # get_movie_dates* call above, just without a usable dateadded. + if result: + reason, reason_desc = 'no_resolved_date', 'in DB, no resolved date yet' + movie_title = _movie_title_from_result(result) + else: + reason, reason_desc = 'no_db_record', 'no DB record' + movie_title = None + + db.record_lookup_miss(imdb_id, 'movie', reason, instance=instance, title=movie_title) + + title_part = f'"{movie_title}" ' if movie_title else '' + _log("INFO", f"Plugin lookup: movie {title_part}({imdb_id}) -> not found ({reason_desc})") return { "found": False, "imdb_id": imdb_id, @@ -2874,43 +3016,223 @@ async def lookup_movie(imdb_id: str, dependencies: dict): "source": None, "released": None } - + except Exception as e: _log("ERROR", f"Movie lookup failed for {imdb_id}: {e}") raise HTTPException(status_code=500, detail=f"Movie lookup failed: {str(e)}") -async def populate_database(background_tasks: BackgroundTasks, media_type: str = "both", dependencies: dict = None): +# Populate Database — runs in a separate OS process (not an asyncio background +# task) so a large populate doesn't block this container's event loop, and +# writes its status to a file both this process and the worker process can +# see. Moved here from chronarr-web (2026-09-15): it was previously running +# entirely inside the web container, which has no LOG_DIR volume mount, so +# every _log() call DatabasePopulator makes went to a path invisible on the +# host and lost on restart — docker logs showed it live (print() doesn't care +# about mounts) but chronarr.log itself never got it. This container is the +# one with the log volume, so this is where the actual work belongs; web now +# proxies to here the same way it already does for /manual/scan. +POPULATE_STATUS_FILE = os.path.join(tempfile.gettempdir(), "chronarr_populate_status.json") +_populate_process = None + + +def _populate_worker_process(media_type: str, status_file: str, instance: str = "all"): + """ + Worker process that runs database population in complete isolation. + Runs in a separate process - keeps this container's API responsive. + """ + import os + import sys + import json + from datetime import datetime + + # Add parent directory to path for imports + sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__)))) + + def update_status(status_data): + """Write status to file for main process to read""" + try: + with open(status_file, 'w') as f: + json.dump(status_data, f) + except Exception as e: + print(f"ERROR: Failed to update status file: {e}") + + # Initialize status + status = { + "running": True, + "media_type": media_type, + "instance": instance, + "start_time": datetime.now().isoformat(), + "movies": {"status": "pending", "stats": None}, + "tv": {"status": "pending", "stats": None}, + "completed": False, + "error": None + } + update_status(status) + + try: + # Import here (inside process) to avoid pickling issues + from core.database import ChronarrDatabase + from core.database_populator import DatabasePopulator + from config.settings import config + + db = ChronarrDatabase(config) + + def _merge_movie_stats(all_stats): + merged = {'total': 0, 'added': 0, 'updated': 0, 'skipped': 0, 'errors': 0, + 'duration': 0.0, 'skipped_items': [], 'added_items': []} + for inst_name, s in all_stats: + for k in ('total', 'added', 'updated', 'skipped', 'errors'): + merged[k] += s.get(k, 0) + merged['duration'] += s.get('duration', 0.0) + merged['skipped_items'].extend(s.get('skipped_items', [])) + merged['added_items'].extend(s.get('added_items', [])) + return merged + + def _merge_tv_stats(all_stats): + merged = {'total_series': 0, 'total_episodes': 0, 'added': 0, 'updated': 0, + 'skipped': 0, 'errors': 0, 'duration': 0.0, 'skipped_items': [], 'added_items': []} + for inst_name, s in all_stats: + for k in ('total_series', 'total_episodes', 'added', 'updated', 'skipped', 'errors'): + merged[k] += s.get(k, 0) + merged['duration'] += s.get('duration', 0.0) + merged['skipped_items'].extend(s.get('skipped_items', [])) + merged['added_items'].extend(s.get('added_items', [])) + return merged + + print(f"INFO: [Worker Process] Starting database population: {media_type} (instance: {instance})") + radarr_instances = config.radarr_instances + sonarr_instances = config.sonarr_instances + + # A specific instance narrows the run to just that one, regardless of + # which media_type was picked — the instance's own type (it can only + # be a Radarr or a Sonarr instance) decides what actually runs. "all" + # (the default) keeps the original behavior: every configured + # instance of whichever media_type was selected. + if instance and instance != "all": + matched_radarr = [i for i in radarr_instances if i.name == instance] + matched_sonarr = [i for i in sonarr_instances if i.name == instance] + if not matched_radarr and not matched_sonarr: + known = [i.name for i in radarr_instances] + [i.name for i in sonarr_instances] + raise ValueError(f"Instance '{instance}' not found. Configured instances: {known}") + radarr_instances = matched_radarr + sonarr_instances = matched_sonarr + # The instance's own type is authoritative — a Radarr instance can + # only ever mean movies, a Sonarr instance only TV. Override + # whatever media_type the caller sent so a stale/mismatched value + # (e.g. the UI's Media Type dropdown left on the wrong setting) + # can't silently produce a no-op run: without this, an instance + # narrowed to (say) only Sonarr combined with media_type="movies" + # would iterate an empty radarr_instances list, skip the tv block + # entirely, and finish "successfully" having populated nothing. + effective_media_type = "movies" if matched_radarr else "tv" + if effective_media_type != media_type: + print(f"INFO: [Worker Process] media_type '{media_type}' overridden to '{effective_media_type}' — instance '{instance}' determines its own type") + media_type = effective_media_type + status["media_type"] = media_type + print(f"INFO: [Worker Process] Narrowed to instance '{instance}'") + + print(f"INFO: [Worker Process] Radarr instances: {[i.name for i in radarr_instances]}") + print(f"INFO: [Worker Process] Sonarr instances: {[i.name for i in sonarr_instances]}") + + # Run population based on media type + if media_type in ["movies", "both"]: + all_movie_stats = [] + for inst in radarr_instances: + status["movies"]["status"] = f"running ({inst.name})" + update_status(status) + print(f"INFO: [Worker Process] Populating movies for instance '{inst.name}'") + + try: + pop = DatabasePopulator.from_radarr_instance(inst, db) + inst_stats = pop.populate_movies(instance=inst.name) + except Exception as e: + print(f"ERROR: [Worker Process] Movies failed for instance '{inst.name}': {e}") + inst_stats = {'total': 0, 'added': 0, 'updated': 0, 'skipped': 0, 'errors': 1, + 'duration': 0.0, + 'skipped_items': [f"Instance '{inst.name}' failed: {e}"]} + all_movie_stats.append((inst.name, inst_stats)) + print(f"INFO: [Worker Process] Movies done for '{inst.name}': {inst_stats}") + + movie_stats = _merge_movie_stats(all_movie_stats) + status["movies"]["status"] = "completed" + status["movies"]["stats"] = movie_stats + update_status(status) + print(f"INFO: [Worker Process] All movie population complete: {movie_stats}") + + if media_type in ["tv", "both"]: + all_tv_stats = [] + for inst in sonarr_instances: + status["tv"]["status"] = f"running ({inst.name})" + update_status(status) + print(f"INFO: [Worker Process] Populating TV for instance '{inst.name}'") + + try: + pop = DatabasePopulator.from_sonarr_instance(inst, db) + inst_stats = pop.populate_tv_episodes(instance=inst.name) + except Exception as e: + print(f"ERROR: [Worker Process] TV failed for instance '{inst.name}': {e}") + inst_stats = {'total_series': 0, 'total_episodes': 0, 'added': 0, 'updated': 0, + 'skipped': 0, 'errors': 1, 'duration': 0.0, + 'skipped_items': [f"Instance '{inst.name}' failed: {e}"]} + all_tv_stats.append((inst.name, inst_stats)) + print(f"INFO: [Worker Process] TV done for '{inst.name}': {inst_stats}") + + tv_stats = _merge_tv_stats(all_tv_stats) + status["tv"]["status"] = "completed" + status["tv"]["stats"] = tv_stats + update_status(status) + print(f"INFO: [Worker Process] All TV population complete: {tv_stats}") + + # Mark as completed + status["completed"] = True + status["running"] = False + update_status(status) + print("INFO: [Worker Process] Database population completed successfully") + + except Exception as e: + print(f"ERROR: [Worker Process] Database population failed: {e}") + import traceback + traceback.print_exc() + + status["error"] = str(e) + status["running"] = False + status["completed"] = True + update_status(status) + + +async def populate_database(background_tasks: BackgroundTasks, media_type: str = "both", dependencies: dict = None, instance: str = "all"): """ - Populate Chronarr database from Radarr/Sonarr sources + Populate Chronarr database from Radarr/Sonarr sources in a separate process. + This keeps this container's API responsive during population. Args: - background_tasks: FastAPI background tasks + background_tasks: FastAPI background tasks (not used - kept for compatibility) media_type: Type of media to populate ("movies", "tv", or "both") - dependencies: Dictionary with db, radarr_client, sonarr_client + dependencies: Dictionary with dependencies (not used in multiprocessing mode) + instance: Specific instance name to populate (e.g. "sonarr_4k"), or "all" + (default) for every configured instance of the given media_type Returns: Status message indicating population has started """ - from core.database_populator import DatabasePopulator - - db = dependencies["db"] - config = dependencies["config"] - - # Get Radarr and Sonarr clients - from clients.radarr_client import RadarrClient - from clients.sonarr_client import SonarrClient - - radarr_client = RadarrClient(config) - sonarr_client = SonarrClient(config) + global _populate_process if media_type not in ["both", "movies", "tv"]: raise HTTPException(status_code=400, detail="media_type must be 'both', 'movies', or 'tv'") - # Create global status tracking - populate_status = { + # Check if process is already running + if _populate_process and _populate_process.is_alive(): + return { + "status": "already_running", + "message": "Database population is already in progress" + } + + # Initialize status file + initial_status = { "running": True, "media_type": media_type, + "instance": instance, "start_time": datetime.now().isoformat(), "movies": {"status": "pending", "stats": None}, "tv": {"status": "pending", "stats": None}, @@ -2918,111 +3240,608 @@ async def populate_database(background_tasks: BackgroundTasks, media_type: str = "error": None } - # Store status globally so it can be queried - global _populate_status - _populate_status = populate_status - - async def run_population(): - """Background task to populate the database""" - try: - populator = DatabasePopulator(db, radarr_client, sonarr_client) - - _log("INFO", f"Starting database population: {media_type}") - - if media_type == "movies": - populate_status["movies"]["status"] = "running" - movie_stats = populator.populate_movies() - populate_status["movies"]["status"] = "completed" - populate_status["movies"]["stats"] = movie_stats - _log("INFO", f"Movie population completed: {movie_stats}") - - elif media_type == "tv": - populate_status["tv"]["status"] = "running" - tv_stats = populator.populate_tv_episodes() - populate_status["tv"]["status"] = "completed" - populate_status["tv"]["stats"] = tv_stats - _log("INFO", f"TV population completed: {tv_stats}") - - elif media_type == "both": - populate_status["movies"]["status"] = "running" - movie_stats = populator.populate_movies() - populate_status["movies"]["status"] = "completed" - populate_status["movies"]["stats"] = movie_stats - _log("INFO", f"Movie population completed: {movie_stats}") - - populate_status["tv"]["status"] = "running" - tv_stats = populator.populate_tv_episodes() - populate_status["tv"]["status"] = "completed" - populate_status["tv"]["stats"] = tv_stats - _log("INFO", f"TV population completed: {tv_stats}") - - populate_status["completed"] = True - populate_status["running"] = False - _log("INFO", "Database population completed successfully") - - except Exception as e: - _log("ERROR", f"Database population failed: {e}") - populate_status["error"] = str(e) - populate_status["running"] = False - populate_status["completed"] = True - - # Add task to background - background_tasks.add_task(run_population) + try: + with open(POPULATE_STATUS_FILE, 'w') as f: + json.dump(initial_status, f) + except Exception as e: + print(f"ERROR: Failed to initialize status file: {e}") + raise HTTPException(status_code=500, detail=f"Failed to initialize status tracking: {e}") + + # Start population in separate process + _populate_process = multiprocessing.Process( + target=_populate_worker_process, + args=(media_type, POPULATE_STATUS_FILE, instance), + daemon=False # Keep process alive even if parent exits + ) + _populate_process.start() - _log("INFO", f"Database population started for: {media_type}") + _log("INFO", f"Database population process started for: {media_type} (instance: {instance})") return { "status": "started", "media_type": media_type, - "message": f"Database population started for {media_type}" + "instance": instance, + "message": f"Database population started for {media_type}" + (f" ({instance})" if instance != "all" else "") } async def get_populate_status(): - """Get the current status of database population""" - global _populate_status - if '_populate_status' not in globals(): + """Get the current status of database population from status file""" + global _populate_process + + # Check if status file exists + if not os.path.exists(POPULATE_STATUS_FILE): return {"running": False, "completed": False} - return _populate_status + # Read status from file + try: + with open(POPULATE_STATUS_FILE, 'r') as f: + status = json.load(f) -# Initialize global populate status -_populate_status = {"running": False, "completed": False} + # Check if process is still alive + if _populate_process: + status["process_alive"] = _populate_process.is_alive() + if not _populate_process.is_alive() and status.get("running"): + # Process died unexpectedly + status["running"] = False + status["completed"] = True + if not status.get("error"): + status["error"] = "Process terminated unexpectedly" + return status -def register_routes(app, dependencies: dict): + except Exception as e: + print(f"ERROR: Failed to read status file: {e}") + return { + "running": False, + "completed": True, + "error": f"Failed to read status: {e}" + } + +# Instance names the wizard has written to .env this process, but that aren't +# live yet because chronarr-core hasn't been restarted to pick them up. The +# InstanceRegistry alone can't catch "save the same new instance twice" — +# from its point of view neither save happened. This resets naturally on the +# next real restart, which is exactly when it should, since by then the +# registry knows about them for real. +_pending_wizard_instances: set = set() + + +def _wizard_test_api(url: str, api_key: str) -> dict: + """Hit Radarr/Sonarr's system status endpoint to check the URL+key work. + + Both apps expose the same path, so one function covers either. Returns + {"success": True} or {"success": False, "error": "..."} — never raises, + the wizard endpoints turn a failure into an HTTP error themselves. """ - Register all routes with the FastAPI app - - Args: - app: FastAPI application instance - dependencies: Dictionary containing: - - db: ChronarrDatabase instance - - nfo_manager: NFOManager instance - - path_mapper: PathMapper instance - - tv_processor: TVProcessor instance - - movie_processor: MovieProcessor instance - - batcher: WebhookBatcher instance - - start_time: Application start time - - config: ChronarrConfig instance - - version: Application version string + try: + base = url.rstrip("/") + resp = requests.get(f"{base}/api/v3/system/status", headers={"X-Api-Key": api_key}, timeout=10) + resp.raise_for_status() + return {"success": True} + except Exception as e: + return {"success": False, "error": str(e)} + + +def _wizard_fetch_root_folders(url: str, api_key: str) -> list: + """Ask Radarr/Sonarr for its configured root folders. + + Both apps expose the same path. Only called once the API test above has + already passed, so a failure here is worth logging but not worth + failing the whole test over — the user typed a working URL+key, root + folders are a convenience on top of that, not a requirement. """ - + try: + base = url.rstrip("/") + resp = requests.get(f"{base}/api/v3/rootfolder", headers={"X-Api-Key": api_key}, timeout=10) + resp.raise_for_status() + return [rf["path"] for rf in resp.json() if rf.get("path")] + except Exception as e: + _log("WARNING", f"Setup wizard: could not fetch root folders from {url}: {e}") + return [] + + +def _wizard_test_db(media_type, db_type, db_host, db_port, db_name, db_user, db_password, db_path, label="") -> dict: + """Try building a direct DB client — its constructor tests the connection itself. + + Same {"success": ...} shape as _wizard_test_api(). The client is thrown + away either way; this only exists to find out if it *would* connect. + `label` (e.g. "sonarr_strm (testing)") is just for the log lines this + produces — the instance doesn't exist yet, so there's nothing to look up. + """ + try: + if media_type == "radarr": + from clients.radarr_db_client import RadarrDbClient as DbClient + else: + from clients.sonarr_db_client import SonarrDbClient as DbClient + + if db_type == "sqlite": + DbClient(db_type="sqlite", db_path=db_path, instance_name=label) + else: + DbClient( + db_type=db_type, + db_host=db_host, + db_port=db_port or 5432, + db_name=db_name, + db_user=db_user, + db_password=db_password, + instance_name=label, + ) + return {"success": True} + except Exception as e: + return {"success": False, "error": str(e)} + + +def register_routes(app, dependencies: dict): + """Register all routes. Webhook routes are registered per-instance dynamically.""" + + # Backward-compat aliases for single-instance users: /webhook/sonarr, /webhook/radarr @app.post("/webhook/sonarr") - async def _sonarr_webhook(request: Request, background_tasks: BackgroundTasks): - return await sonarr_webhook(request, background_tasks, dependencies) + async def _sonarr_webhook_default(request: Request, background_tasks: BackgroundTasks): + return await sonarr_webhook(request, background_tasks, dependencies, instance="sonarr") + + @app.post("/webhook/radarr") + async def _radarr_webhook_default(request: Request, background_tasks: BackgroundTasks): + return await radarr_webhook(request, background_tasks, dependencies, instance="radarr") + + # Per-instance webhook routes derived from discovered instance names. + # Each instance named "radarr_4k" gets /radarr_4k/webhook; the default "radarr" + # instance gets /radarr/webhook in addition to the /webhook/radarr alias above. + registry = dependencies.get("registry") + if registry: + for name in registry.radarr_names: + _inst = name # capture for closure + + async def _radarr_instance_handler(request: Request, background_tasks: BackgroundTasks, _n=_inst): + return await radarr_webhook(request, background_tasks, dependencies, instance=_n) + + app.add_api_route( + f"/{name}/webhook", + _radarr_instance_handler, + methods=["POST"], + name=f"radarr_webhook_{name}", + ) - @app.post("/webhook/radarr") - async def _radarr_webhook(request: Request, background_tasks: BackgroundTasks): - return await radarr_webhook(request, background_tasks, dependencies) + for name in registry.sonarr_names: + _inst = name + + async def _sonarr_instance_handler(request: Request, background_tasks: BackgroundTasks, _n=_inst): + return await sonarr_webhook(request, background_tasks, dependencies, instance=_n) + + app.add_api_route( + f"/{name}/webhook", + _sonarr_instance_handler, + methods=["POST"], + name=f"sonarr_webhook_{name}", + ) @app.post("/webhook/maintainarr") async def _maintainarr_webhook(request: Request, background_tasks: BackgroundTasks): return await maintainarr_webhook(request, background_tasks, dependencies) + @app.get("/api/instances") + async def _api_instances(): + """Return all configured instances with their webhook paths and connection status.""" + registry = dependencies.get("registry") + cfg = dependencies.get("config") + if not registry or not cfg: + raise HTTPException(status_code=503, detail="Registry not initialised") + + radarr_list = [ + { + "name": inst.name, + "webhook_path": f"/{inst.name}/webhook", + "connected": registry.radarr_status(inst.name).get("connected", False), + "method": registry.radarr_status(inst.name).get("method"), + } + for inst in cfg.radarr_instances + ] + sonarr_list = [ + { + "name": inst.name, + "webhook_path": f"/{inst.name}/webhook", + "connected": registry.sonarr_status(inst.name).get("connected", False), + "method": registry.sonarr_status(inst.name).get("method"), + } + for inst in cfg.sonarr_instances + ] + return {"radarr": radarr_list, "sonarr": sonarr_list} + + @app.get("/api/wizard/instance-details") + async def _wizard_instance_details(media_type: str, name: str = ""): + """Look up one instance's full config, for pre-filling the wizard's Edit form. + + Returns the same fields the wizard form collects (url, api_key, + root_folders, paths, DB block) straight from the live config object + — no need to re-read or re-parse the env files, config already has + it resolved. Includes the API key and DB password: this endpoint + exists specifically so Edit doesn't make someone retype secrets + they've already set, and they're already visible to anyone who can + reach /api/wizard/env-backup anyway. + """ + cfg = dependencies.get("config") + if not cfg: + raise HTTPException(status_code=503, detail="Config not initialised") + + if media_type not in ("radarr", "sonarr"): + raise HTTPException(status_code=400, detail="media_type must be 'radarr' or 'sonarr'") + + instance_name = f"{media_type}_{name.lower()}" if name else media_type + instances = cfg.radarr_instances if media_type == "radarr" else cfg.sonarr_instances + match = next((i for i in instances if i.name == instance_name), None) + if not match: + raise HTTPException(status_code=404, detail=f"No instance named '{instance_name}' found") + + return { + "media_type": media_type, + "name": name, + "url": match.url, + "api_key": match.api_key, + "root_folders": match.root_folders, + "movie_paths": getattr(match, "movie_paths", None), + "tv_paths": getattr(match, "tv_paths", None), + "db_type": match.db_type or None, + "db_host": match.db_host or None, + "db_port": match.db_port or None, + "db_name": match.db_name or None, + "db_user": match.db_user or None, + "db_password": match.db_password or None, + "db_path": match.db_path or None, + } + + @app.post("/api/wizard/test-connection") + async def _wizard_test_connection(payload: WizardConnectionTestRequest): + """Setup wizard: try connecting with whatever the user has typed so far. + + Doesn't write anything or touch the registry — just reports whether + the API URL+key and/or the DB block actually work, so the wizard + can show a real pass/fail before the user hits Save. + """ + label = f"{payload.media_type}_{payload.name.lower()} (testing)" if payload.name else f"{payload.media_type} (testing)" + result = {} + if payload.url and payload.api_key: + result["api"] = _wizard_test_api(payload.url, payload.api_key) + if result["api"]["success"]: + result["api"]["root_folders"] = _wizard_fetch_root_folders(payload.url, payload.api_key) + if payload.db_type: + result["db"] = _wizard_test_db( + payload.media_type, payload.db_type, payload.db_host, payload.db_port, + payload.db_name, payload.db_user, payload.db_password, payload.db_path, + label=label, + ) + return result + + @app.post("/api/wizard/save-instance") + async def _wizard_save_instance(payload: WizardSaveInstanceRequest): + """Setup wizard: validate, then write one instance to .env / .env.secrets. + + Either every check below passes and both files get written, or + nothing gets written at all — no half-applied instance sitting in + the config. Restarting chronarr-core is still required to actually + pick the new instance up; that limitation is explained in the docs + rather than hidden from the caller. + """ + from config.env_writer import ( + build_env_updates, upsert_env_file, validate_name_segment, InstanceNameError, backup_env_files, + ) + + registry = dependencies.get("registry") + if not registry: + raise HTTPException(status_code=503, detail="Registry not initialised") + + if payload.media_type not in ("radarr", "sonarr"): + raise HTTPException(status_code=400, detail="media_type must be 'radarr' or 'sonarr'") + + # Check against what's actually running, not just what's in the file — + # someone may have hand-edited .env since the last restart. + existing_names = set(registry.radarr_names) | set(registry.sonarr_names) + + if payload.name: + try: + name_segment = validate_name_segment( + payload.name, existing_names, payload.media_type, require_exists=payload.edit_existing + ) + except InstanceNameError as e: + raise HTTPException(status_code=400, detail=str(e)) + else: + # Empty name means "the default instance" — still needs the same + # existence check as a named one, just inline since there's no + # segment to run through validate_name_segment for. + name_segment = "" + default_exists = payload.media_type in existing_names + if payload.edit_existing and not default_exists: + raise HTTPException( + status_code=400, + detail=f"No default {payload.media_type} instance exists to edit.", + ) + if not payload.edit_existing and default_exists: + raise HTTPException( + status_code=400, + detail=( + f"The default {payload.media_type} instance is already configured. " + "Give this one a name to add it as an additional instance instead." + ), + ) + + instance_name = f"{payload.media_type}_{name_segment.lower()}" if name_segment else payload.media_type + # The pending-instance guard only matters for adds — it exists to + # stop the same brand-new name being saved twice before a restart. + # Editing an already-live instance repeatedly before restarting is + # the normal workflow (fix a typo, test again), not a collision. + if not payload.edit_existing and instance_name in _pending_wizard_instances: + raise HTTPException( + status_code=400, + detail=( + f"'{instance_name}' was already saved by the wizard this session but hasn't " + "gone live yet — restart chronarr-core to pick it up before adding it again." + ), + ) + + if payload.db_type == "sqlite" and payload.db_path and not Path(payload.db_path).exists(): + raise HTTPException( + status_code=400, + detail=f"SQLite path '{payload.db_path}' doesn't exist in this container — check the volume mount", + ) + + if not payload.force: + api_result = _wizard_test_api(payload.url, payload.api_key) + if not api_result["success"]: + raise HTTPException( + status_code=400, + detail=f"Connection test failed: {api_result['error']}. Save again with force=true to skip this check.", + ) + if payload.db_type: + db_result = _wizard_test_db( + payload.media_type, payload.db_type, payload.db_host, payload.db_port, + payload.db_name, payload.db_user, payload.db_password, payload.db_path, + label=f"{instance_name} (pre-save test)", + ) + if not db_result["success"]: + raise HTTPException( + status_code=400, + detail=f"Database connection test failed: {db_result['error']}. Save again with force=true to skip this check.", + ) + + fields = payload.dict(exclude={"media_type", "name", "force", "edit_existing"}) + env_updates, secret_updates = build_env_updates(payload.media_type, name_segment, fields) + + # Cheap insurance — every wizard write gets a snapshot of what the + # files looked like just before, so a bad save is never a dead end. + # Same format /api/wizard/env-backup produces, restorable the same way. + backup_env_files(Path(".env"), Path(".env.secrets"), Path("backups")) + + env_changed = upsert_env_file(Path(".env"), env_updates, instance_label=instance_name) + secrets_changed = upsert_env_file(Path(".env.secrets"), secret_updates, instance_label=instance_name) + _pending_wizard_instances.add(instance_name) + + _log("INFO", f"Setup wizard: wrote instance '{instance_name}' to .env/.env.secrets — restart required to apply") + + return { + "instance_name": instance_name, + "webhook_path": f"/{instance_name}/webhook", + "env_changed": env_changed, + "secrets_changed": secrets_changed, + "restart_required": True, + "restart_reason": ( + "chronarr-core builds its instance registry once at startup — " + "restart it to pick up this instance." + ), + } + + @app.post("/api/wizard/delete-instance") + async def _wizard_delete_instance(payload: WizardDeleteInstanceRequest): + """Setup wizard: remove one instance's env vars from .env / .env.secrets. + + Same "must exist" name validation as editing, same automatic + pre-write snapshot as every other wizard write. Removing the vars + doesn't remove the instance from Docker's own baked-in environment + (if it was there before, e.g. present when the container was + created) — restart_reason says so explicitly rather than implying + a restart alone is always enough. + """ + from config.env_writer import ( + remove_instance_keys, validate_name_segment, InstanceNameError, backup_env_files, + ) + + registry = dependencies.get("registry") + if not registry: + raise HTTPException(status_code=503, detail="Registry not initialised") + + if payload.media_type not in ("radarr", "sonarr"): + raise HTTPException(status_code=400, detail="media_type must be 'radarr' or 'sonarr'") + + existing_names = set(registry.radarr_names) | set(registry.sonarr_names) + + if payload.name: + try: + name_segment = validate_name_segment(payload.name, existing_names, payload.media_type, require_exists=True) + except InstanceNameError as e: + raise HTTPException(status_code=400, detail=str(e)) + else: + name_segment = "" + if payload.media_type not in existing_names: + raise HTTPException( + status_code=400, + detail=f"No default {payload.media_type} instance exists to delete.", + ) + + instance_name = f"{payload.media_type}_{name_segment.lower()}" if name_segment else payload.media_type + prefix = f"{payload.media_type.upper()}_{name_segment}_" if name_segment else f"{payload.media_type.upper()}_" + + backup_env_files(Path(".env"), Path(".env.secrets"), Path("backups")) + + env_changed = remove_instance_keys(Path(".env"), prefix, instance_label=instance_name) + secrets_changed = remove_instance_keys(Path(".env.secrets"), prefix, instance_label=instance_name) + _pending_wizard_instances.discard(instance_name) + + _log("INFO", f"Setup wizard: removed instance '{instance_name}' from .env/.env.secrets — restart required to apply") + + return { + "instance_name": instance_name, + "env_changed": env_changed, + "secrets_changed": secrets_changed, + "restart_required": True, + "restart_reason": ( + "chronarr-core builds its instance registry once at startup. A plain restart " + "isn't always enough — if this instance's env vars were present when the " + "container was first created, Docker's own env_file injection baked them into " + "the container and a restart alone won't drop them. Recreate the container " + "(docker compose up -d --force-recreate, or down + up) to be sure they're gone." + ), + } + + @app.get("/api/wizard/env-backup") + async def _wizard_env_backup(): + """Download the current .env + .env.secrets as one backup file. + + A literal snapshot of both files' raw text, comments and all — + restoring it writes them back byte-for-byte. This file contains real + API keys and database passwords in plain text, same as .env.secrets + itself does; store it somewhere as secure as that file. + """ + from config.env_writer import read_env_files + from version_utils import get_version + + content = read_env_files(Path(".env"), Path(".env.secrets")) + payload = { + "chronarr_version": get_version(), + "exported_at": datetime.now(timezone.utc).isoformat(), + **content, + } + filename = f"chronarr-env-backup-{datetime.now(timezone.utc).strftime('%Y%m%d-%H%M%S')}.json" + return Response( + content=json.dumps(payload, indent=2), + media_type="application/json", + headers={"Content-Disposition": f'attachment; filename="{filename}"'}, + ) + + @app.post("/api/wizard/env-restore") + async def _wizard_env_restore(payload: WizardEnvRestoreRequest): + """Restore .env + .env.secrets from a backup produced by /api/wizard/env-backup. + + The current files are snapshotted first, the same as every wizard + save already does — restoring the wrong file, or one from an + incompatible version, isn't a dead end either. + """ + from config.env_writer import write_env_files, backup_env_files + + pre_restore_backup = backup_env_files(Path(".env"), Path(".env.secrets"), Path("backups")) + write_env_files(Path(".env"), Path(".env.secrets"), payload.env, payload.env_secrets) + + _log("INFO", f"Setup wizard: restored .env/.env.secrets from an uploaded backup (pre-restore snapshot: {pre_restore_backup})") + + # --------------------------- + # Log file endpoints + # --------------------------- + # Only chronarr.log (current) and its rotated backups (chronarr.log.1/.2/.3) + # ever exist in LOG_DIR — validate every filename against this before + # touching the filesystem so a request can't read/download anything else. + _LOG_FILENAME_RE = re.compile(r"^chronarr\.log(\.\d+)?$") + + def _log_dir() -> Path: + return Path(os.environ.get("LOG_DIR", "/app/data/logs")) + + def _validated_log_path(filename: str) -> Path: + if not _LOG_FILENAME_RE.match(filename): + raise HTTPException(status_code=404, detail="Log file not found") + path = _log_dir() / filename + if not path.is_file(): + raise HTTPException(status_code=404, detail="Log file not found") + return path + + @app.get("/api/logs") + async def _list_logs(): + """List the current log file and any rotated backups, newest first.""" + log_dir = _log_dir() + files = [] + if log_dir.is_dir(): + for path in log_dir.iterdir(): + if _LOG_FILENAME_RE.match(path.name): + stat = path.stat() + files.append({ + "filename": path.name, + "size_bytes": stat.st_size, + "modified_at": datetime.fromtimestamp(stat.st_mtime, tz=timezone.utc).isoformat(), + "is_current": path.name == "chronarr.log", + }) + # Current log first, then rotated backups oldest-suffix-last (.1 before .2, etc.) + files.sort(key=lambda f: (not f["is_current"], f["filename"])) + return {"files": files} + + @app.get("/api/logs/{filename}/tail") + async def _tail_log(filename: str, lines: int = 200): + """Return the last N lines of a log file as JSON, for the in-browser viewer. + + Reads the whole file to get an accurate tail (these files cap at 50MB + per the rotation policy — fast enough for occasional viewing) rather + than an approximate byte-offset seek. + """ + lines = max(1, min(lines, 5000)) # keep the response itself reasonable + path = _validated_log_path(filename) + try: + with open(path, "r", encoding="utf-8", errors="replace") as f: + tail = list(deque(f, maxlen=lines)) + except OSError as e: + raise HTTPException(status_code=500, detail=f"Failed to read log file: {e}") + return { + "filename": filename, + "lines": [line.rstrip("\n") for line in tail], + "returned_count": len(tail), + } + + @app.get("/api/logs/{filename}/download") + async def _download_log(filename: str): + """Download a log file as-is.""" + from fastapi.responses import FileResponse + path = _validated_log_path(filename) + return FileResponse(path, media_type="text/plain", filename=filename) + + # --------------------------- + # Unresolved plugin lookups + # --------------------------- + # /api/lookup/movie and /api/lookup/episode record a row here every time + # they answer "not found" — see lookup_movie()/lookup_episode() above. + # These two endpoints let the web UI show and clear that list instead of + # it only existing as a line in chronarr.log. + + @app.get("/api/unresolved-lookups") + async def _list_unresolved_lookups(include_dismissed: bool = False): + db = dependencies.get("db") + if not db: + raise HTTPException(status_code=500, detail="Database not available") + rows = db.get_unresolved_lookups(include_dismissed=include_dismissed) + return {"lookups": [dict(row) for row in rows]} + + @app.post("/api/unresolved-lookups/{lookup_id}/dismiss") + async def _dismiss_unresolved_lookup(lookup_id: int): + db = dependencies.get("db") + if not db: + raise HTTPException(status_code=500, detail="Database not available") + dismissed = db.dismiss_unresolved_lookup(lookup_id) + if not dismissed: + raise HTTPException(status_code=404, detail="Unresolved lookup not found") + return {"dismissed": True, "id": lookup_id} + + @app.post("/api/unresolved-lookups/dismiss-all") + async def _dismiss_all_unresolved_lookups(): + db = dependencies.get("db") + if not db: + raise HTTPException(status_code=500, detail="Database not available") + count = db.dismiss_all_unresolved_lookups() + return {"dismissed_count": count} + + return { + "restored": True, + "pre_restore_backup": str(pre_restore_backup) if pre_restore_backup else None, + "restart_required": True, + "restart_reason": ( + "Restored files only take effect after chronarr-core restarts and reloads its environment." + ), + } + @app.get("/health") async def _health() -> HealthResponse: return await health(dependencies) - + @app.get("/health/simple") async def _health_simple(): """Simple health check for Docker without external dependencies""" @@ -3126,8 +3945,8 @@ async def _scan_status(): return await get_scan_status() @app.post("/admin/populate-database") - async def _populate_database(background_tasks: BackgroundTasks, media_type: str = "both"): - return await populate_database(background_tasks, media_type, dependencies) + async def _populate_database(background_tasks: BackgroundTasks, media_type: str = "both", instance: str = "all"): + return await populate_database(background_tasks, media_type, dependencies, instance) @app.get("/api/populate/status") async def _populate_status(): @@ -3166,12 +3985,12 @@ async def _debug_tmdb_lookup(imdb_id: str): # --------------------------- @app.get("/api/lookup/episode/{imdb_id}/{season}/{episode}") - async def _lookup_episode(imdb_id: str, season: int, episode: int): - return await lookup_episode(imdb_id, season, episode, dependencies) - + async def _lookup_episode(imdb_id: str, season: int, episode: int, instance: str = None): + return await lookup_episode(imdb_id, season, episode, dependencies, instance) + @app.get("/api/lookup/movie/{imdb_id}") - async def _lookup_movie(imdb_id: str): - return await lookup_movie(imdb_id, dependencies) + async def _lookup_movie(imdb_id: str, instance: str = None): + return await lookup_movie(imdb_id, dependencies, instance) @app.get("/api/lookup/movie/title/{title}") async def _lookup_movie_by_title(title: str, year: str = None): @@ -4008,10 +4827,27 @@ async def get_missing_imdb(): "message": f"Failed to retrieve missing IMDb items: {str(e)}" } + # --------------------------- + # Emby Plugin Support + # --------------------------- + + @app.get("/emby/changelog") + async def _emby_changelog(): + """Serve the Emby plugin changelog from the bundled CHANGELOG.md.""" + import os + from fastapi.responses import PlainTextResponse + changelog_path = os.path.join( + os.path.dirname(os.path.dirname(__file__)), "Emby-DLL", "CHANGELOG.md" + ) + if os.path.exists(changelog_path): + with open(changelog_path, "r", encoding="utf-8") as f: + return PlainTextResponse(f.read(), media_type="text/markdown; charset=utf-8") + return PlainTextResponse("Changelog not found.", status_code=404) + # --------------------------- # Core API - No Web Interface # --------------------------- - + @app.get("/") async def _core_info(): """Core container API information - Web interface on separate container""" diff --git a/api/web_routes.py b/api/web_routes.py index 5858750..0e8ae06 100644 --- a/api/web_routes.py +++ b/api/web_routes.py @@ -4,8 +4,7 @@ """ import json import os -import tempfile -import multiprocessing +import re from datetime import datetime, timezone from typing import List, Optional, Dict, Any from fastapi import HTTPException, Query, BackgroundTasks @@ -14,14 +13,12 @@ from api.models import * from utils.logging import _log +# Strip [imdb-tt...] or [tmdb-...] suffixes that media managers append to folder names +_FOLDER_ID_SUFFIX = re.compile(r'\s*\[[a-z]+-[^\]]+\]', re.IGNORECASE) -# Status file for cross-process communication -# Use /tmp which is writable in both core and web containers (unlike /app/data, -# which can be mounted read-only) -POPULATE_STATUS_FILE = os.path.join(tempfile.gettempdir(), "chronarr_populate_status.json") - -# Process tracking -_populate_process = None +def _clean_folder_title(raw: str) -> str: + """Remove media-manager ID suffixes from a folder name used as a display title.""" + return _FOLDER_ID_SUFFIX.sub('', raw).strip() def map_source_to_description(source: str) -> str: @@ -58,9 +55,22 @@ def map_source_to_description(source: str) -> str: elif "omdb:" in source_lower: return "OMDb Release" - # Sonarr sources - elif "sonarr:" in source_lower: + # Sonarr sources — same granularity as Radarr above. This used to be a + # single catch-all ("Sonarr API") for every sonarr: source regardless of + # whether it actually came from direct DB history, the aired-date + # fallback, or a file date — genuinely misleading once instances started + # using direct DB access, since a DB-sourced date would still display + # as "Sonarr API". + elif "sonarr:db.history.import" in source_lower or "sonarr:db.bulk.import" in source_lower: + return "Sonarr Import History" + elif "sonarr:db.file.dateadded" in source_lower: + return "Sonarr File Date" + elif "sonarr:aired_fallback" in source_lower: + return "Sonarr Air Date" + elif "sonarr:api.import_history" in source_lower: return "Sonarr API" + elif "sonarr:" in source_lower: + return "Sonarr" # Manual and other sources elif "manual" in source_lower: @@ -91,13 +101,14 @@ async def get_movies_list(dependencies: dict, source_filter: Optional[str] = Query(None), search: Optional[str] = Query(None), imdb_search: Optional[str] = Query(None), - skipped: Optional[bool] = Query(None)): + skipped: Optional[bool] = Query(None), + instance_filter: Optional[str] = Query(None)): """Get paginated list of movies with filtering options""" db = dependencies["db"] - + with db.get_connection() as conn: cursor = conn.cursor() - + # Build dynamic query where_conditions = [] params = [] @@ -110,10 +121,8 @@ async def get_movies_list(dependencies: dict, if has_date is not None: if has_date: - # PostgreSQL - NULL handling where_conditions.append("dateadded IS NOT NULL") else: - # PostgreSQL - NULL handling where_conditions.append("dateadded IS NULL") if source_filter: @@ -127,17 +136,21 @@ async def get_movies_list(dependencies: dict, if imdb_search: where_conditions.append("imdb_id ILIKE %s") params.append(f"%{imdb_search}%") - + + if instance_filter: + where_conditions.append("instance = %s") + params.append(instance_filter) + where_clause = " AND ".join(where_conditions) if where_conditions else "1=1" - + # Get total count count_query = f"SELECT COUNT(*) FROM movies WHERE {where_clause}" cursor.execute(count_query, params) total_count = db._get_first_value(cursor.fetchone()) - - # Get paginated results - PostgreSQL + + # Get paginated results query = f""" - SELECT imdb_id, title, year, path, released, dateadded, source, has_video_file, last_updated, skipped, skip_reason + SELECT imdb_id, instance, title, year, path, released, dateadded, source, has_video_file, last_updated, skipped, skip_reason FROM movies WHERE {where_clause} ORDER BY last_updated DESC @@ -169,12 +182,13 @@ async def get_movies_list(dependencies: dict, async def get_tv_series_list(dependencies: dict, - skip: int = Query(0, ge=0), + skip: int = Query(0, ge=0), limit: int = Query(50, le=500), search: Optional[str] = Query(None), imdb_search: Optional[str] = Query(None), date_filter: Optional[str] = Query(None), - source_filter: Optional[str] = Query(None)): + source_filter: Optional[str] = Query(None), + instance_filter: Optional[str] = Query(None)): """Get paginated list of TV series with episode counts""" db = dependencies["db"] @@ -199,10 +213,13 @@ async def get_tv_series_list(dependencies: dict, params.append(f"%{imdb_search}%") if source_filter: - # Need to check episodes for source filter where_conditions.append("e.source = %s") params.append(source_filter) - + + if instance_filter: + where_conditions.append("s.instance = %s") + params.append(instance_filter) + if date_filter: if date_filter == "complete": # All episodes have dates @@ -225,14 +242,13 @@ async def get_tv_series_list(dependencies: dict, # Get total count with same filtering logic as main query if having_clause or needs_episode_join: - # When using HAVING clause or filtering by episode fields, need to count filtered results with JOIN count_query = f""" SELECT COUNT(*) FROM ( - SELECT s.imdb_id + SELECT s.imdb_id, s.instance FROM series s - LEFT JOIN episodes e ON s.imdb_id = e.imdb_id + LEFT JOIN episodes e ON s.imdb_id = e.imdb_id AND s.instance = e.instance WHERE {where_clause} - GROUP BY s.imdb_id + GROUP BY s.imdb_id, s.instance {('HAVING ' + having_clause) if having_clause else ''} ) filtered_series """ @@ -245,10 +261,10 @@ async def get_tv_series_list(dependencies: dict, # Get series with episode statistics having_part = f" HAVING {having_clause}" if having_clause else "" - # PostgreSQL query query = f""" SELECT s.imdb_id, + s.instance, s.path, s.last_updated, COUNT(e.episode) as total_episodes, @@ -256,9 +272,9 @@ async def get_tv_series_list(dependencies: dict, COUNT(CASE WHEN e.has_video_file = TRUE THEN 1 END) as episodes_with_video, COUNT(CASE WHEN e.skipped = TRUE THEN 1 END) as episodes_skipped FROM series s - LEFT JOIN episodes e ON s.imdb_id = e.imdb_id + LEFT JOIN episodes e ON s.imdb_id = e.imdb_id AND s.instance = e.instance WHERE {where_clause} - GROUP BY s.imdb_id, s.path, s.last_updated{having_part} + GROUP BY s.imdb_id, s.instance, s.path, s.last_updated{having_part} ORDER BY s.last_updated DESC LIMIT %s OFFSET %s """ @@ -269,7 +285,7 @@ async def get_tv_series_list(dependencies: dict, series_data = dict(row) # Extract title from path try: - series_data['title'] = Path(series_data['path']).name if series_data['path'] else series_data['imdb_id'] + series_data['title'] = _clean_folder_title(Path(series_data['path']).name) if series_data['path'] else series_data['imdb_id'] except: series_data['title'] = series_data['imdb_id'] series.append(series_data) @@ -362,32 +378,41 @@ async def debug_series_date_distribution(dependencies: dict): } -async def get_series_episodes(dependencies: dict, imdb_id: str): - """Get all episodes for a specific TV series""" +async def get_series_episodes(dependencies: dict, imdb_id: str, instance: str = 'sonarr'): + """Get all episodes for a specific TV series, scoped to one instance. + + A given IMDb ID can exist independently under multiple Sonarr instances + (e.g. a full back-catalog under the default `sonarr` and a separate, + smaller pickup under a named instance like `sonarr_strm`) — each is its + own series/episodes rows, keyed by (imdb_id, instance). Not filtering by + instance here pulled every instance's episodes into one merged list, so + a series row that's genuinely only 15 episodes under one instance would + show all 175 from every instance sharing the IMDb ID. + """ db = dependencies["db"] - + with db.get_connection() as conn: cursor = conn.cursor() - + # Get series info - PostgreSQL - cursor.execute("SELECT * FROM series WHERE imdb_id = %s", (imdb_id,)) + cursor.execute("SELECT * FROM series WHERE imdb_id = %s AND instance = %s", (imdb_id, instance)) series_row = cursor.fetchone() if not series_row: raise HTTPException(status_code=404, detail="Series not found") - + series_info = dict(series_row) try: - series_info['title'] = Path(series_info['path']).name if series_info['path'] else imdb_id + series_info['title'] = _clean_folder_title(Path(series_info['path']).name) if series_info['path'] else imdb_id except: series_info['title'] = imdb_id - + # Get episodes - PostgreSQL cursor.execute(""" - SELECT season, episode, aired, dateadded, source, has_video_file, last_updated - FROM episodes - WHERE imdb_id = %s + SELECT season, episode, instance, aired, dateadded, source, has_video_file, last_updated + FROM episodes + WHERE imdb_id = %s AND instance = %s ORDER BY season, episode - """, (imdb_id,)) + """, (imdb_id, instance)) episodes = [] for row in cursor.fetchall(): @@ -411,8 +436,8 @@ async def get_missing_dates_report(dependencies: dict): # Movies without dates - PostgreSQL cursor.execute(""" - SELECT imdb_id, path, released, source, last_updated - FROM movies + SELECT imdb_id, instance, path, released, source, last_updated + FROM movies WHERE dateadded IS NULL OR source = 'no_valid_date_source' ORDER BY last_updated DESC """) @@ -429,9 +454,9 @@ async def get_missing_dates_report(dependencies: dict): # Episodes without dates - PostgreSQL cursor.execute(""" - SELECT e.imdb_id, e.season, e.episode, e.aired, e.source, e.last_updated, s.path + SELECT e.imdb_id, e.instance, e.season, e.episode, e.aired, e.source, e.last_updated, s.path FROM episodes e - JOIN series s ON e.imdb_id = s.imdb_id + JOIN series s ON e.imdb_id = s.imdb_id AND s.instance = e.instance WHERE e.dateadded IS NULL OR e.source = 'no_valid_date_source' ORDER BY e.last_updated DESC """) @@ -439,7 +464,7 @@ async def get_missing_dates_report(dependencies: dict): for row in cursor.fetchall(): episode = dict(row) try: - episode['series_title'] = Path(episode['path']).name if episode['path'] else episode['imdb_id'] + episode['series_title'] = _clean_folder_title(Path(episode['path']).name) if episode['path'] else episode['imdb_id'] except: episode['series_title'] = episode['imdb_id'] # Map source to user-friendly description @@ -566,7 +591,7 @@ async def get_dashboard_stats(dependencies: dict): # Database Modification Endpoints # --------------------------- -async def update_movie_date(dependencies: dict, imdb_id: str, dateadded: Optional[str], source: str): +async def update_movie_date(dependencies: dict, imdb_id: str, dateadded: Optional[str], source: str, instance: str = 'radarr'): """Update dateadded for a specific movie""" db = dependencies["db"] @@ -594,26 +619,27 @@ async def update_movie_date(dependencies: dict, imdb_id: str, dateadded: Optiona raise HTTPException(status_code=422, detail=f"Invalid date format: {dateadded}") # Validate movie exists - movie = db.get_movie_dates(imdb_id) + movie = db.get_movie_dates(imdb_id, instance) if not movie: raise HTTPException(status_code=404, detail="Movie not found") - + # Update the date db.upsert_movie_dates( imdb_id=imdb_id, released=movie.get('released'), dateadded=dateadded, source=source, - has_video_file=movie.get('has_video_file', False) + has_video_file=movie.get('has_video_file', False), + instance=instance ) - + # Add to processing history try: db.add_processing_history( imdb_id=imdb_id, media_type="movie", event_type="manual_date_update", - details={"old_source": movie.get('source'), "new_source": source, "dateadded": dateadded} + details={"old_source": movie.get('source'), "new_source": source, "dateadded": dateadded, "instance": instance} ) except Exception as e: print(f"⚠️ Failed to add processing history: {e}") @@ -623,15 +649,15 @@ async def update_movie_date(dependencies: dict, imdb_id: str, dateadded: Optiona return {"status": "success", "message": f"Updated movie {imdb_id}"} -async def update_episode_date(dependencies: dict, imdb_id: str, season: int, episode: int, - dateadded: Optional[str], source: str): +async def update_episode_date(dependencies: dict, imdb_id: str, season: int, episode: int, + dateadded: Optional[str], source: str, instance: str = 'sonarr'): """Update dateadded for a specific episode""" db = dependencies["db"] _log("DEBUG", f"update_episode_date called with dateadded={repr(dateadded)}, source={repr(source)}") # Get existing episode - episode_data = db.get_episode_date(imdb_id, season, episode) + episode_data = db.get_episode_date(imdb_id, season, episode, instance) if not episode_data: raise HTTPException(status_code=404, detail="Episode not found") @@ -655,7 +681,8 @@ async def update_episode_date(dependencies: dict, imdb_id: str, season: int, epi aired=episode_data.get('aired'), dateadded=dateadded, source=source, - has_video_file=episode_data.get('has_video_file', False) + has_video_file=episode_data.get('has_video_file', False), + instance=instance ) # Trigger NFO file update via core container @@ -665,10 +692,18 @@ async def update_episode_date(dependencies: dict, imdb_id: str, season: int, epi import json import os - # Get core container connection details - core_host = os.environ.get("CORE_API_HOST", "chronarr") - core_port = os.environ.get("CORE_API_PORT", "8080") - + # Where THIS (web) container reaches core — deliberately not named + # CORE_API_HOST/CORE_API_PORT, which are a different pre-existing + # pair that control what interface core's own uvicorn binds to + # (config/settings.py, main.py). Those two settings look like they + # should be the same thing and aren't — setting CORE_API_HOST to a + # specific hostname to fix cross-stack DNS collisions (two chronarr + # deployments sharing a Docker network) breaks core's own healthcheck + # instead, since it stops binding to 0.0.0.0. Learned this the hard + # way once already; keep these names distinct. + core_host = os.environ.get("CORE_INTERNAL_HOST", "chronarr") + core_port = os.environ.get("CORE_INTERNAL_PORT", "8080") + # Call core container to update NFO file nfo_update_url = f"http://{core_host}:{core_port}/api/episodes/{imdb_id}/{season}/{episode}/update-nfo" @@ -766,12 +801,12 @@ async def bulk_update_source(dependencies: dict, media_type: str, old_source: st } -async def get_movie_date_options(dependencies: dict, imdb_id: str): +async def get_movie_date_options(dependencies: dict, imdb_id: str, instance: str = 'radarr'): """Get available date options for a movie (Radarr import, digital release, etc.)""" db = dependencies["db"] # Get current movie data - movie = db.get_movie_dates(imdb_id) + movie = db.get_movie_dates(imdb_id, instance) if not movie: raise HTTPException(status_code=404, detail="Movie not found") @@ -942,9 +977,9 @@ async def get_movie_date_options(dependencies: dict, imdb_id: str): } -async def get_episode_date_options(dependencies: dict, imdb_id: str, season: int, episode: int): +async def get_episode_date_options(dependencies: dict, imdb_id: str, season: int, episode: int, instance: str = 'sonarr'): """Get available date options for an episode""" - _log("DEBUG", f"get_episode_date_options called with imdb_id={imdb_id}, season={season}, episode={episode}") + _log("DEBUG", f"get_episode_date_options called with imdb_id={imdb_id}, season={season}, episode={episode}, instance={instance}") db = dependencies["db"] # Validate parameters with enhanced checking @@ -969,7 +1004,7 @@ async def get_episode_date_options(dependencies: dict, imdb_id: str, season: int raise HTTPException(status_code=422, detail=f"Invalid parameter types: {e}") # Get current episode data - episode_data = db.get_episode_date(imdb_id, season, episode) + episode_data = db.get_episode_date(imdb_id, season, episode, instance) _log("DEBUG", f"Episode data from DB: {episode_data}") if not episode_data: print(f"❌ Episode not found in database: {imdb_id} S{season:02d}E{episode:02d}") @@ -1280,193 +1315,16 @@ async def get_episode_date_options(dependencies: dict, imdb_id: str, season: int } -def _populate_worker_process(media_type: str, status_file: str): - """ - Worker process that runs database population in complete isolation. - Runs in separate process - keeps web interface responsive. - """ - import os - import sys - import json - from datetime import datetime - - # Add parent directory to path for imports - sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__)))) - - def update_status(status_data): - """Write status to file for main process to read""" - try: - with open(status_file, 'w') as f: - json.dump(status_data, f) - except Exception as e: - print(f"ERROR: Failed to update status file: {e}") - - # Initialize status - status = { - "running": True, - "media_type": media_type, - "start_time": datetime.now().isoformat(), - "movies": {"status": "pending", "stats": None}, - "tv": {"status": "pending", "stats": None}, - "completed": False, - "error": None - } - update_status(status) - - try: - # Import here (inside process) to avoid pickling issues - from core.database import ChronarrDatabase - from core.database_populator import DatabasePopulator - from clients.radarr_client import RadarrClient - from clients.sonarr_client import SonarrClient - from config.settings import config - - # Initialize components - db = ChronarrDatabase(config) - radarr_client = RadarrClient( - os.environ.get("RADARR_URL", ""), - os.environ.get("RADARR_API_KEY", "") - ) - sonarr_client = SonarrClient( - os.environ.get("SONARR_URL", ""), - os.environ.get("SONARR_API_KEY", "") - ) - - populator = DatabasePopulator(db, radarr_client, sonarr_client) - - print(f"INFO: [Worker Process] Starting database population: {media_type}") - - # Run population based on media type - if media_type in ["movies", "both"]: - status["movies"]["status"] = "running" - update_status(status) - - movie_stats = populator.populate_movies() - - status["movies"]["status"] = "completed" - status["movies"]["stats"] = movie_stats - update_status(status) - print(f"INFO: [Worker Process] Movie population completed: {movie_stats}") - - if media_type in ["tv", "both"]: - status["tv"]["status"] = "running" - update_status(status) - - tv_stats = populator.populate_tv_episodes() - - status["tv"]["status"] = "completed" - status["tv"]["stats"] = tv_stats - update_status(status) - print(f"INFO: [Worker Process] TV population completed: {tv_stats}") - - # Mark as completed - status["completed"] = True - status["running"] = False - update_status(status) - print("INFO: [Worker Process] Database population completed successfully") - - except Exception as e: - print(f"ERROR: [Worker Process] Database population failed: {e}") - import traceback - traceback.print_exc() - - status["error"] = str(e) - status["running"] = False - status["completed"] = True - update_status(status) - - -async def populate_database(background_tasks: BackgroundTasks, media_type: str = "both", dependencies: dict = None): - """ - Populate Chronarr database from Radarr/Sonarr sources in separate process. - This keeps the web interface responsive during population. - - Args: - background_tasks: FastAPI background tasks (not used - kept for compatibility) - media_type: Type of media to populate ("movies", "tv", or "both") - dependencies: Dictionary with dependencies (not used in multiprocessing mode) - - Returns: - Status message indicating population has started - """ - global _populate_process - - if media_type not in ["both", "movies", "tv"]: - raise HTTPException(status_code=400, detail="media_type must be 'both', 'movies', or 'tv'") - - # Check if process is already running - if _populate_process and _populate_process.is_alive(): - return { - "status": "already_running", - "message": "Database population is already in progress" - } - - # Initialize status file - initial_status = { - "running": True, - "media_type": media_type, - "start_time": datetime.now().isoformat(), - "movies": {"status": "pending", "stats": None}, - "tv": {"status": "pending", "stats": None}, - "completed": False, - "error": None - } - - try: - with open(POPULATE_STATUS_FILE, 'w') as f: - json.dump(initial_status, f) - except Exception as e: - print(f"ERROR: Failed to initialize status file: {e}") - raise HTTPException(status_code=500, detail=f"Failed to initialize status tracking: {e}") - - # Start population in separate process - _populate_process = multiprocessing.Process( - target=_populate_worker_process, - args=(media_type, POPULATE_STATUS_FILE), - daemon=False # Keep process alive even if parent exits - ) - _populate_process.start() - - _log("INFO", f"Database population process started for: {media_type}") - return { - "status": "started", - "media_type": media_type, - "message": f"Database population started for {media_type}" - } - - -async def get_populate_status(): - """Get the current status of database population from status file""" - global _populate_process - - # Check if status file exists - if not os.path.exists(POPULATE_STATUS_FILE): - return {"running": False, "completed": False} - - # Read status from file - try: - with open(POPULATE_STATUS_FILE, 'r') as f: - status = json.load(f) - - # Check if process is still alive - if _populate_process: - status["process_alive"] = _populate_process.is_alive() - if not _populate_process.is_alive() and status.get("running"): - # Process died unexpectedly - status["running"] = False - status["completed"] = True - if not status.get("error"): - status["error"] = "Process terminated unexpectedly" - - return status - - except Exception as e: - print(f"ERROR: Failed to read status file: {e}") - return { - "running": False, - "completed": True, - "error": f"Failed to read status: {e}" - } +# Database population used to run its worker process directly in this +# container (multiprocessing.Process + a status file), the same way +# /manual/scan and /manual/cleanup-orphaned already proxy to chronarr-core +# below. Moved to chronarr-core (2026-09-15): this container has no LOG_DIR +# volume mount, so every _log() call DatabasePopulator made was writing to a +# path invisible on the host and lost on restart — docker logs showed it +# live (print() doesn't care about mounts) but the persisted chronarr.log +# never got it. See api/routes.py for the real implementation; the +# /admin/populate-database and /api/populate/status handlers below now just +# proxy to it. def register_web_routes(app, dependencies): @@ -1486,8 +1344,8 @@ async def api_dashboard_stats(): @app.get("/api/movies") async def api_movies_list(skip: int = 0, limit: int = 100, has_date: bool = None, source_filter: str = None, search: str = None, imdb_search: str = None, - skipped: bool = None): - return await get_movies_list(dependencies, skip, limit, has_date, source_filter, search, imdb_search, skipped) + skipped: bool = None, instance: str = None): + return await get_movies_list(dependencies, skip, limit, has_date, source_filter, search, imdb_search, skipped, instance) @app.post("/api/movies/{imdb_id}/update-date") async def api_update_movie_date(imdb_id: str, dateadded: str = None, source: str = "manual"): @@ -1500,28 +1358,30 @@ async def api_update_movie(imdb_id: str, request: Request): data = await request.json() dateadded = data.get('dateadded') source = data.get('source', 'manual') + instance = data.get('instance', 'radarr') _log("DEBUG", f"API PUT /api/movies/{imdb_id} - Received JSON:") print(f" - Raw data: {data}") print(f" - dateadded: {dateadded}") print(f" - source: {source}") + print(f" - instance: {instance}") - return await update_movie_date(dependencies, imdb_id, dateadded, source) + return await update_movie_date(dependencies, imdb_id, dateadded, source, instance) except Exception as e: print(f"❌ Error parsing request body: {e}") raise HTTPException(status_code=400, detail=f"Invalid request body: {str(e)}") @app.get("/api/movies/{imdb_id}/date-options") - async def api_movie_date_options(imdb_id: str): - return await get_movie_date_options(dependencies, imdb_id) + async def api_movie_date_options(imdb_id: str, instance: str = 'radarr'): + return await get_movie_date_options(dependencies, imdb_id, instance) @app.get("/api/debug/movie/{imdb_id}/raw") - async def api_debug_movie_raw(imdb_id: str): + async def api_debug_movie_raw(imdb_id: str, instance: str = 'radarr'): """Get raw database data for a movie for debugging""" db = dependencies["db"] try: - movie = db.get_movie_dates(imdb_id) + movie = db.get_movie_dates(imdb_id, instance) if not movie: raise HTTPException(status_code=404, detail="Movie not found") @@ -1538,13 +1398,13 @@ async def api_debug_movie_raw(imdb_id: str): raise HTTPException(status_code=500, detail=f"Failed to get debug data: {str(e)}") @app.delete("/api/movies/{imdb_id}") - async def api_delete_movie(imdb_id: str): + async def api_delete_movie(imdb_id: str, instance: str = 'radarr'): """Delete a movie from the database""" db = dependencies["db"] - + try: # Use the existing database method - deleted = db.delete_movie(imdb_id) + deleted = db.delete_movie(imdb_id, instance) if deleted: return { @@ -1599,13 +1459,14 @@ async def api_migrate_movie_imdb(old_imdb_id: str, request: Request): # TV series endpoints @app.get("/api/series") - async def api_series_list(skip: int = 0, limit: int = 50, search: str = None, - imdb_search: str = None, date_filter: str = None, source_filter: str = None): - return await get_tv_series_list(dependencies, skip, limit, search, imdb_search, date_filter, source_filter) + async def api_series_list(skip: int = 0, limit: int = 50, search: str = None, + imdb_search: str = None, date_filter: str = None, + source_filter: str = None, instance: str = None): + return await get_tv_series_list(dependencies, skip, limit, search, imdb_search, date_filter, source_filter, instance) @app.get("/api/series/{imdb_id}/episodes") - async def api_series_episodes(imdb_id: str): - return await get_series_episodes(dependencies, imdb_id) + async def api_series_episodes(imdb_id: str, instance: str = 'sonarr'): + return await get_series_episodes(dependencies, imdb_id, instance) @app.get("/api/series/sources") async def api_series_sources(): @@ -1650,6 +1511,32 @@ async def api_migrate_series_imdb(old_imdb_id: str, request: Request): print(f"❌ Error migrating series IMDb ID: {e}") raise HTTPException(status_code=500, detail=f"Failed to migrate IMDb ID: {str(e)}") + @app.delete("/api/series/{imdb_id}") + async def api_delete_series(imdb_id: str, instance: str = 'sonarr'): + """Delete a series and all its episodes from the database""" + db = dependencies["db"] + + try: + episodes_deleted = db.delete_series_episodes(imdb_id, instance) + series_deleted = db.delete_series(imdb_id, instance) + + if series_deleted or episodes_deleted > 0: + return { + "success": True, + "status": "success", + "message": f"Deleted series {imdb_id} and {episodes_deleted} episode(s)", + "imdb_id": imdb_id, + "episodes_deleted": episodes_deleted + } + else: + raise HTTPException(status_code=404, detail="Series not found") + + except HTTPException: + raise + except Exception as e: + print(f"❌ Error deleting series: {e}") + raise HTTPException(status_code=500, detail=f"Failed to delete series: {str(e)}") + # Episode endpoints @app.post("/api/episodes/{imdb_id}/{season}/{episode}/update-date") async def api_update_episode_date(imdb_id: str, season: int, episode: int, @@ -1663,23 +1550,24 @@ async def api_update_episode(imdb_id: str, season: int, episode: int, request: R data = await request.json() dateadded = data.get('dateadded') source = data.get('source', 'manual') - return await update_episode_date(dependencies, imdb_id, season, episode, dateadded, source) + instance = data.get('instance', 'sonarr') + return await update_episode_date(dependencies, imdb_id, season, episode, dateadded, source, instance) except Exception as e: print(f"❌ Error parsing episode update request: {e}") raise HTTPException(status_code=400, detail=f"Invalid request format: {str(e)}") @app.get("/api/episodes/{imdb_id}/{season}/{episode}/date-options") - async def api_episode_date_options(imdb_id: str, season: int, episode: int): - return await get_episode_date_options(dependencies, imdb_id, season, episode) + async def api_episode_date_options(imdb_id: str, season: int, episode: int, instance: str = 'sonarr'): + return await get_episode_date_options(dependencies, imdb_id, season, episode, instance) @app.delete("/api/episodes/{imdb_id}/{season}/{episode}") - async def api_delete_episode(imdb_id: str, season: int, episode: int): + async def api_delete_episode(imdb_id: str, season: int, episode: int, instance: str = 'sonarr'): """Delete an episode from the database""" db = dependencies["db"] - + try: # Use the existing database method - deleted = db.delete_episode(imdb_id, season, episode) + deleted = db.delete_episode(imdb_id, season, episode, instance) if deleted: return { @@ -1826,8 +1714,8 @@ async def api_manual_scan(request: Request): import socket # Get core container URL - core_host = os.environ.get("CORE_API_HOST", "chronarr") - core_port = os.environ.get("CORE_API_PORT", "8080") + core_host = os.environ.get("CORE_INTERNAL_HOST", "chronarr") + core_port = os.environ.get("CORE_INTERNAL_PORT", "8080") # Forward query parameters from the request query_string = str(request.url.query) if request.url.query else "" @@ -1863,8 +1751,8 @@ async def api_manual_cleanup(request: Request): import socket # Get core container URL - core_host = os.environ.get("CORE_API_HOST", "chronarr") - core_port = os.environ.get("CORE_API_PORT", "8080") + core_host = os.environ.get("CORE_INTERNAL_HOST", "chronarr") + core_port = os.environ.get("CORE_INTERNAL_PORT", "8080") core_url = f"http://{core_host}:{core_port}/manual/cleanup-orphaned" try: @@ -1983,8 +1871,8 @@ async def api_scan_status(): import socket # Get core container connection details - core_host = os.environ.get("CORE_API_HOST", "chronarr") - core_port = os.environ.get("CORE_API_PORT", "8080") + core_host = os.environ.get("CORE_INTERNAL_HOST", "chronarr") + core_port = os.environ.get("CORE_INTERNAL_PORT", "8080") try: # Call core container's detailed scan status endpoint @@ -2412,27 +2300,320 @@ async def api_get_schedule_executions(schedule_id: int = None): """Get schedule execution history""" return await get_schedule_executions(dependencies, schedule_id) - # Database population endpoints - _log("DEBUG", "Registering /admin/populate-database endpoint...") - + # Database population endpoints (proxy to core container — see the note + # above register_web_routes() for why this doesn't run locally anymore) @app.post("/admin/populate-database") - async def api_populate_database(request: Request, background_tasks: BackgroundTasks): - """Populate database from Radarr/Sonarr""" - _log("DEBUG", "populate-database endpoint called!") + async def api_populate_database(request: Request): + """Proxy populate-database requests to core container""" + import urllib.request + import urllib.parse + import urllib.error + import socket + try: data = await request.json() media_type = data.get("media_type", "both") + instance = data.get("instance", "all") except Exception: - # Fallback to query parameter if JSON parsing fails + # Fallback to query parameters if JSON parsing fails media_type = request.query_params.get("media_type", "both") - return await populate_database(background_tasks, media_type, dependencies) + instance = request.query_params.get("instance", "all") + + core_host = os.environ.get("CORE_INTERNAL_HOST", "chronarr") + core_port = os.environ.get("CORE_INTERNAL_PORT", "8080") + query_string = urllib.parse.urlencode({"media_type": media_type, "instance": instance}) + core_url = f"http://{core_host}:{core_port}/admin/populate-database?{query_string}" - _log("DEBUG", "/admin/populate-database registered") + try: + req = urllib.request.Request(core_url, method='POST') + with urllib.request.urlopen(req, timeout=30) as response: + return json.loads(response.read().decode('utf-8')) + except urllib.error.HTTPError as e: + raise HTTPException(status_code=e.code, detail=f"Core container HTTP error: {e.reason}") + except urllib.error.URLError as e: + raise HTTPException(status_code=503, detail=f"Could not connect to core container: {str(e)}") + except socket.timeout: + raise HTTPException(status_code=504, detail="Core container request timed out") + except Exception as e: + raise HTTPException(status_code=500, detail=f"Populate database request failed: {str(e)}") @app.get("/api/populate/status") async def api_populate_status(): - """Get database population status""" - return await get_populate_status() + """Proxy populate status requests to core container""" + import urllib.request + import urllib.error + import socket + + core_host = os.environ.get("CORE_INTERNAL_HOST", "chronarr") + core_port = os.environ.get("CORE_INTERNAL_PORT", "8080") + core_url = f"http://{core_host}:{core_port}/api/populate/status" + + try: + req = urllib.request.Request(core_url, method='GET') + with urllib.request.urlopen(req, timeout=30) as response: + return json.loads(response.read().decode('utf-8')) + except urllib.error.HTTPError as e: + raise HTTPException(status_code=e.code, detail=f"Core container HTTP error: {e.reason}") + except urllib.error.URLError as e: + raise HTTPException(status_code=503, detail=f"Could not connect to core container: {str(e)}") + except socket.timeout: + raise HTTPException(status_code=504, detail="Core container request timed out") + except Exception as e: + raise HTTPException(status_code=500, detail=f"Populate status request failed: {str(e)}") + + # /setup page and its data endpoint — proxy /api/instances to the core + @app.get("/api/instances") + async def api_instances(request: Request): + """Proxy instance list and connection status from the core container.""" + import urllib.request + import urllib.error + import json + import os + import socket + + core_host = os.environ.get("CORE_INTERNAL_HOST", "chronarr") + core_port = os.environ.get("CORE_INTERNAL_PORT", "8080") + core_url = f"http://{core_host}:{core_port}/api/instances" + + try: + req = urllib.request.Request(core_url) + with urllib.request.urlopen(req, timeout=5) as resp: + return json.loads(resp.read().decode("utf-8")) + except urllib.error.HTTPError as e: + raise HTTPException(status_code=e.code, detail=f"Core API error: {e.reason}") + except (urllib.error.URLError, socket.timeout) as e: + raise HTTPException(status_code=503, detail=f"Could not reach core container: {e}") + + @app.get("/api/wizard/instance-details") + async def wizard_instance_details(request: Request): + """Proxy an instance's full config (for pre-filling Edit) from the core container.""" + import urllib.request + import urllib.error + import json + import os + import socket + + core_host = os.environ.get("CORE_INTERNAL_HOST", "chronarr") + core_port = os.environ.get("CORE_INTERNAL_PORT", "8080") + query = request.url.query + core_url = f"http://{core_host}:{core_port}/api/wizard/instance-details" + (f"?{query}" if query else "") + + try: + req = urllib.request.Request(core_url) + with urllib.request.urlopen(req, timeout=5) as resp: + return json.loads(resp.read().decode("utf-8")) + except urllib.error.HTTPError as e: + detail = e.read().decode("utf-8") + try: + detail = json.loads(detail).get("detail", detail) + except ValueError: + pass + raise HTTPException(status_code=e.code, detail=detail) + except (urllib.error.URLError, socket.timeout) as e: + raise HTTPException(status_code=503, detail=f"Could not reach core container: {e}") + + async def _proxy_post_to_core(path: str, body: dict): + """Forward a wizard POST to the core container and hand back its response as-is. + + Same host/port lookup and error handling as the /api/instances GET + proxy above — core owns the InstanceRegistry and the env files, so + every wizard write goes through it rather than the web container + touching config directly. + """ + import urllib.request + import urllib.error + import json as _json + import os as _os + import socket + + core_host = _os.environ.get("CORE_INTERNAL_HOST", "chronarr") + core_port = _os.environ.get("CORE_INTERNAL_PORT", "8080") + core_url = f"http://{core_host}:{core_port}{path}" + + data = _json.dumps(body).encode("utf-8") + req = urllib.request.Request(core_url, data=data, headers={"Content-Type": "application/json"}, method="POST") + try: + with urllib.request.urlopen(req, timeout=15) as resp: + return _json.loads(resp.read().decode("utf-8")) + except urllib.error.HTTPError as e: + # Core sends back a real error detail (bad name, failed test, etc.) — + # pass it through instead of flattening everything to a generic 500. + detail = e.read().decode("utf-8") + try: + detail = _json.loads(detail).get("detail", detail) + except ValueError: + pass + raise HTTPException(status_code=e.code, detail=detail) + except (urllib.error.URLError, socket.timeout) as e: + raise HTTPException(status_code=503, detail=f"Could not reach core container: {e}") + + @app.post("/api/wizard/test-connection") + async def wizard_test_connection(request: Request): + """Proxy the wizard's connection test to the core container.""" + return await _proxy_post_to_core("/api/wizard/test-connection", await request.json()) + + @app.post("/api/wizard/save-instance") + async def wizard_save_instance(request: Request): + """Proxy the wizard's save (writes .env/.env.secrets) to the core container.""" + return await _proxy_post_to_core("/api/wizard/save-instance", await request.json()) + + @app.post("/api/wizard/delete-instance") + async def wizard_delete_instance(request: Request): + """Proxy the wizard's delete (removes .env/.env.secrets entries) to the core container.""" + return await _proxy_post_to_core("/api/wizard/delete-instance", await request.json()) + + @app.get("/api/wizard/env-backup") + async def wizard_env_backup(): + """Proxy the .env/.env.secrets backup download from the core container. + + Passed through as raw bytes with the same Content-Disposition header + core set, rather than re-parsed as JSON — this is a file download, + not a data endpoint. + """ + import urllib.request + import urllib.error + import os as _os + import socket + + core_host = _os.environ.get("CORE_INTERNAL_HOST", "chronarr") + core_port = _os.environ.get("CORE_INTERNAL_PORT", "8080") + core_url = f"http://{core_host}:{core_port}/api/wizard/env-backup" + + try: + req = urllib.request.Request(core_url) + with urllib.request.urlopen(req, timeout=15) as resp: + body = resp.read() + disposition = resp.headers.get("Content-Disposition", "attachment; filename=chronarr-env-backup.json") + return Response(content=body, media_type="application/json", headers={"Content-Disposition": disposition}) + except urllib.error.HTTPError as e: + raise HTTPException(status_code=e.code, detail=e.reason) + except (urllib.error.URLError, socket.timeout) as e: + raise HTTPException(status_code=503, detail=f"Could not reach core container: {e}") + + @app.post("/api/wizard/env-restore") + async def wizard_env_restore(request: Request): + """Proxy the wizard's env-file restore (overwrites .env/.env.secrets) to core.""" + return await _proxy_post_to_core("/api/wizard/env-restore", await request.json()) + + @app.get("/api/logs") + async def logs_list(): + """Proxy the log file listing from the core container (only core has LOG_DIR mounted).""" + import urllib.request + import urllib.error + import json + import os + import socket + + core_host = os.environ.get("CORE_INTERNAL_HOST", "chronarr") + core_port = os.environ.get("CORE_INTERNAL_PORT", "8080") + core_url = f"http://{core_host}:{core_port}/api/logs" + + try: + req = urllib.request.Request(core_url) + with urllib.request.urlopen(req, timeout=10) as resp: + return json.loads(resp.read().decode("utf-8")) + except urllib.error.HTTPError as e: + raise HTTPException(status_code=e.code, detail=f"Core API error: {e.reason}") + except (urllib.error.URLError, socket.timeout) as e: + raise HTTPException(status_code=503, detail=f"Could not reach core container: {e}") + + @app.get("/api/logs/{filename}/tail") + async def logs_tail(filename: str, request: Request): + """Proxy the log tail (last N lines, as JSON) from the core container.""" + import urllib.request + import urllib.error + import json + import os + import socket + + core_host = os.environ.get("CORE_INTERNAL_HOST", "chronarr") + core_port = os.environ.get("CORE_INTERNAL_PORT", "8080") + query = request.url.query + core_url = f"http://{core_host}:{core_port}/api/logs/{filename}/tail" + (f"?{query}" if query else "") + + try: + req = urllib.request.Request(core_url) + with urllib.request.urlopen(req, timeout=15) as resp: + return json.loads(resp.read().decode("utf-8")) + except urllib.error.HTTPError as e: + detail = e.read().decode("utf-8") + try: + detail = json.loads(detail).get("detail", detail) + except (ValueError, AttributeError): + pass + raise HTTPException(status_code=e.code, detail=detail) + except (urllib.error.URLError, socket.timeout) as e: + raise HTTPException(status_code=503, detail=f"Could not reach core container: {e}") + + @app.get("/api/logs/{filename}/download") + async def logs_download(filename: str): + """Proxy a log file download from the core container. + + Passed through as raw bytes with the same Content-Disposition/media + type core set, rather than re-parsed — this is a file download. + """ + import urllib.request + import urllib.error + import os + import socket + + core_host = os.environ.get("CORE_INTERNAL_HOST", "chronarr") + core_port = os.environ.get("CORE_INTERNAL_PORT", "8080") + core_url = f"http://{core_host}:{core_port}/api/logs/{filename}/download" + + try: + req = urllib.request.Request(core_url) + with urllib.request.urlopen(req, timeout=30) as resp: + body = resp.read() + disposition = resp.headers.get("Content-Disposition", f'attachment; filename="{filename}"') + return Response(content=body, media_type="text/plain", headers={"Content-Disposition": disposition}) + except urllib.error.HTTPError as e: + raise HTTPException(status_code=e.code, detail=e.reason) + except (urllib.error.URLError, socket.timeout) as e: + raise HTTPException(status_code=503, detail=f"Could not reach core container: {e}") + + @app.get("/api/unresolved-lookups") + async def unresolved_lookups_list(request: Request): + """Proxy the unresolved plugin-lookups list from the core container.""" + import urllib.request + import urllib.error + import json + import os + import socket + + core_host = os.environ.get("CORE_INTERNAL_HOST", "chronarr") + core_port = os.environ.get("CORE_INTERNAL_PORT", "8080") + query = request.url.query + core_url = f"http://{core_host}:{core_port}/api/unresolved-lookups" + (f"?{query}" if query else "") + + try: + req = urllib.request.Request(core_url) + with urllib.request.urlopen(req, timeout=10) as resp: + return json.loads(resp.read().decode("utf-8")) + except urllib.error.HTTPError as e: + raise HTTPException(status_code=e.code, detail=f"Core API error: {e.reason}") + except (urllib.error.URLError, socket.timeout) as e: + raise HTTPException(status_code=503, detail=f"Could not reach core container: {e}") + + @app.post("/api/unresolved-lookups/{lookup_id}/dismiss") + async def unresolved_lookups_dismiss(lookup_id: int): + """Proxy dismissing an unresolved plugin lookup to the core container.""" + return await _proxy_post_to_core(f"/api/unresolved-lookups/{lookup_id}/dismiss", {}) + + @app.post("/api/unresolved-lookups/dismiss-all") + async def unresolved_lookups_dismiss_all(): + """Proxy dismissing every active unresolved plugin lookup to the core container.""" + return await _proxy_post_to_core("/api/unresolved-lookups/dismiss-all", {}) + + @app.get("/setup") + async def setup_page(): + """Serve the instance setup / webhook URL reference page.""" + import os + setup_file = os.path.join(os.path.dirname(__file__), "..", "static", "setup.html") + from fastapi.responses import FileResponse + if os.path.exists(setup_file): + return FileResponse(os.path.normpath(setup_file)) + raise HTTPException(status_code=404, detail="Setup page not found") # Scheduled Scans Functions diff --git a/chronarr-web/static/css/styles.css b/chronarr-web/static/css/styles.css index ab59410..5dbd73d 100644 --- a/chronarr-web/static/css/styles.css +++ b/chronarr-web/static/css/styles.css @@ -1,101 +1,53 @@ -/* ── CSS Variables ───────────────────────────────────────── */ +/* Chronarr Web Interface Styles */ :root { - --bg: #f0f4f8; - --surface: #ffffff; - --surface-2: #f7f9fc; - --border: #e2e8f0; - --text: #1a202c; - --text-muted: #718096; - --accent: #0096c7; - --accent-hover: #007aab; - --accent-subtle: rgba(0, 150, 199, 0.08); - --sidebar-bg: #ffffff; - --sidebar-border: #e2e8f0; - --sidebar-text: #4a5568; - --sidebar-icon: #a0aec0; - --sidebar-active-bg: rgba(0, 150, 199, 0.1); - --sidebar-active-text: #0096c7; - --shadow: 0 1px 3px rgba(0, 0, 0, 0.08); - --shadow-lg: 0 4px 16px rgba(0, 0, 0, 0.10); - --success: #38a169; - --warning-color: #d69e2e; - --danger: #e53e3e; - --badge-success-bg: #c6f6d5; --badge-success-text: #276749; - --badge-warning-bg: #fefcbf; --badge-warning-text: #744210; - --badge-danger-bg: #fed7d7; --badge-danger-text: #9b2c2c; - --badge-info-bg: #bee3f8; --badge-info-text: #2c5282; - --badge-secondary-bg: #e2e8f0; --badge-secondary-text: #4a5568; - --progress-bg: #e2e8f0; - --code-bg: #edf2f7; - --input-bg: #ffffff; - --modal-overlay: rgba(0, 0, 0, 0.45); -} - -@media (prefers-color-scheme: dark) { - :root { - --bg: #0d0f1a; - --surface: #161927; - --surface-2: #1e2235; - --border: #2a2f4a; - --text: #e2e8f0; - --text-muted: #718096; - --accent: #00b4d8; - --accent-hover: #0096c7; - --accent-subtle: rgba(0, 180, 216, 0.12); - --sidebar-bg: #111425; - --sidebar-border: #1e2235; - --sidebar-text: #8892b0; - --sidebar-icon: #4a5568; - --sidebar-active-bg: rgba(0, 180, 216, 0.15); - --sidebar-active-text: #00b4d8; - --shadow: 0 1px 3px rgba(0, 0, 0, 0.3); - --shadow-lg: 0 4px 20px rgba(0, 0, 0, 0.45); - --success: #68d391; - --warning-color: #f6e05e; - --danger: #fc8181; - --badge-success-bg: #22543d; --badge-success-text: #9ae6b4; - --badge-warning-bg: #5f370e; --badge-warning-text: #fefcbf; - --badge-danger-bg: #742a2a; --badge-danger-text: #fed7d7; - --badge-info-bg: #2a4365; --badge-info-text: #bee3f8; - --badge-secondary-bg: #2d3748; --badge-secondary-text: #a0aec0; - --progress-bg: #2d3748; - --code-bg: #1e2235; - --input-bg: #1e2235; - --modal-overlay: rgba(0, 0, 0, 0.65); - } + --primary-color: #007bff; + --secondary-color: #6c757d; + --success-color: #28a745; + --warning-color: #ffc107; + --danger-color: #dc3545; + --dark-color: #343a40; + --light-color: #f8f9fa; + --border-color: #dee2e6; + --text-muted: #6c757d; + --shadow: 0 0.125rem 0.25rem rgba(0, 0, 0, 0.075); + --shadow-lg: 0 0.5rem 1rem rgba(0, 0, 0, 0.15); +} + +* { + margin: 0; + padding: 0; + box-sizing: border-box; } -/* ── Reset ───────────────────────────────────────────────── */ -*, *::before, *::after { margin: 0; padding: 0; box-sizing: border-box; } -html, body { height: 100%; } - body { font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Helvetica Neue", Arial, sans-serif; font-size: 14px; line-height: 1.5; - color: var(--text); - background: var(--bg); + color: var(--dark-color); + background-color: #f5f5f5; } -/* ── App Layout ──────────────────────────────────────────── */ -.app-layout { - display: flex; +.app-container { min-height: 100vh; + display: flex; + flex-direction: row; + align-items: stretch; } -/* ── Sidebar ─────────────────────────────────────────────── */ +/* Sidebar */ .sidebar { width: 220px; - flex-shrink: 0; - background: var(--sidebar-bg); - border-right: 1px solid var(--sidebar-border); + min-width: 220px; + background: #1a1d23; + color: #8b95a1; display: flex; flex-direction: column; + min-height: 100vh; position: sticky; top: 0; height: 100vh; overflow-y: auto; - z-index: 100; + flex-shrink: 0; } .sidebar-brand { @@ -103,264 +55,381 @@ body { display: flex; align-items: center; gap: 0.625rem; - border-bottom: 1px solid var(--sidebar-border); - flex-shrink: 0; + color: #ffffff; + font-size: 1.1rem; + font-weight: 600; + border-bottom: 1px solid #2d3139; + text-decoration: none; } -.sidebar-brand img { - width: 32px; - height: 32px; - border-radius: 6px; - flex-shrink: 0; - object-fit: cover; +.sidebar-brand i { + color: #0096c7; + font-size: 1.2rem; } -.sidebar-brand-text h1 { - font-size: 1.05rem; - font-weight: 700; - color: var(--text); - line-height: 1.2; +/* Auth block in sidebar */ +.sidebar-auth { + padding: 0.625rem 1rem; + border-bottom: 1px solid #2d3139; + display: flex; + flex-direction: column; + gap: 0.375rem; + font-size: 0.8rem; + color: #8b95a1; } -.sidebar-brand-text small { - font-size: 0.7rem; - color: var(--text-muted); +.auth-user { + display: flex; + align-items: center; + gap: 0.375rem; + opacity: 0.85; } -.sidebar-nav { - flex: 1; - padding: 0.625rem 0; - overflow-y: auto; +.auth-logout { + background: rgba(255, 255, 255, 0.08); + color: #8b95a1; + border: 1px solid #3a3f4a; + padding: 0.3rem 0.625rem; + border-radius: 0.25rem; + cursor: pointer; + font-size: 0.775rem; + display: flex; + align-items: center; + gap: 0.375rem; + transition: all 0.2s ease; + width: fit-content; } -.nav-section { - margin-bottom: 0.125rem; +.auth-logout:hover { + background: rgba(255, 255, 255, 0.14); + color: #c9d1d9; +} + +/* Sidebar nav */ +.sidebar-nav { + flex: 1; + padding: 0.5rem 0 1rem; + display: flex; + flex-direction: column; } .nav-section-label { - padding: 0.625rem 1rem 0.25rem; + padding: 0.875rem 1rem 0.25rem; font-size: 0.65rem; font-weight: 700; - text-transform: uppercase; letter-spacing: 0.08em; - color: var(--text-muted); -} - -.nav-divider { - height: 1px; - background: var(--sidebar-border); - margin: 0.375rem 1rem; + text-transform: uppercase; + color: #4a5260; } -.nav-item { +.sidebar-item { display: flex; align-items: center; gap: 0.625rem; - width: 100%; - padding: 0.6rem 1rem; + padding: 0.45rem 0.75rem; + margin: 0.1rem 0.5rem; + width: calc(100% - 1rem); background: none; border: none; + color: #8b95a1; cursor: pointer; - color: var(--sidebar-text); font-size: 0.875rem; text-align: left; + text-decoration: none; + border-radius: 0.375rem; transition: background 0.15s, color 0.15s; + font-family: inherit; } -.nav-item i { - width: 16px; +.sidebar-item i { + width: 1.1rem; text-align: center; + font-size: 0.85rem; flex-shrink: 0; - color: var(--sidebar-icon); - transition: color 0.15s; - font-size: 0.875rem; } -.nav-item:hover { - background: var(--accent-subtle); - color: var(--text); +.sidebar-item:hover { + background: #252930; + color: #c9d1d9; } -.nav-item:hover i { color: var(--accent); } +.sidebar-item.active { + background: rgba(0, 150, 199, 0.14); + color: #0096c7; +} -.nav-item.active { - background: var(--sidebar-active-bg); - color: var(--sidebar-active-text); - font-weight: 600; +/* Expandable group */ +.sidebar-group { + margin: 0.1rem 0; } -.nav-item.active i { color: var(--sidebar-active-text); } +.sidebar-group-toggle { + display: flex; + align-items: center; + justify-content: space-between; + padding: 0.45rem 0.75rem; + margin: 0 0.5rem; + width: calc(100% - 1rem); + background: none; + border: none; + color: #8b95a1; + cursor: pointer; + font-size: 0.875rem; + border-radius: 0.375rem; + transition: background 0.15s, color 0.15s; + font-family: inherit; +} -.sidebar-footer { - padding: 0.75rem 1rem; - border-top: 1px solid var(--sidebar-border); - flex-shrink: 0; +.sidebar-group-toggle:hover { + background: #252930; + color: #c9d1d9; } -.auth-user { +.toggle-content { display: flex; align-items: center; - gap: 0.5rem; - color: var(--text-muted); - font-size: 0.8rem; - margin-bottom: 0.5rem; + gap: 0.625rem; } -.auth-logout { - width: 100%; - background: none; - border: 1px solid var(--border); - color: var(--text-muted); - padding: 0.375rem 0.75rem; - border-radius: 0.375rem; - cursor: pointer; - font-size: 0.8rem; +.toggle-content i { + width: 1.1rem; + text-align: center; + font-size: 0.85rem; +} + +.toggle-chevron { + font-size: 0.65rem; + transition: transform 0.2s ease; + opacity: 0.5; +} + +.sidebar-group-toggle[aria-expanded="true"] .toggle-chevron { + transform: rotate(180deg); +} + +/* Sub-items (collapsed by default, expand via .expanded) */ +.sidebar-sub-items { + overflow: hidden; + max-height: 0; + transition: max-height 0.2s ease; +} + +.sidebar-sub-items.expanded { + max-height: 400px; +} + +.sidebar-sub-item { display: flex; align-items: center; gap: 0.5rem; - transition: all 0.15s; + padding: 0.35rem 0.75rem 0.35rem 2.5rem; + width: 100%; + background: none; + border: none; + color: #626c7a; + cursor: pointer; + font-size: 0.825rem; + text-align: left; + transition: color 0.15s, background 0.15s; + font-family: inherit; } -.auth-logout:hover { - background: var(--accent-subtle); - color: var(--accent); - border-color: var(--accent); +.sidebar-sub-item:hover { + color: #c9d1d9; + background: #202328; } -/* ── Main area ───────────────────────────────────────────── */ -.main-wrapper { - flex: 1; - min-width: 0; - display: flex; - flex-direction: column; +.sidebar-sub-item.active { + color: #0096c7; } +.instance-dot { + width: 6px; + height: 6px; + border-radius: 50%; + flex-shrink: 0; + display: inline-block; +} + +.sidebar-divider { + height: 1px; + background: #2d3139; + margin: 0.625rem 0.75rem; +} + +/* Instance badge in table cells */ +.instance-badge { + padding: 0.2rem 0.5rem; + border-radius: 0.25rem; + font-size: 0.75rem; + font-weight: 500; + border: 1px solid transparent; + display: inline-block; + white-space: nowrap; +} + +/* badge-primary (used in source type display) */ +.badge-primary { + background-color: #cfe2ff; + color: #084298; +} + +/* Main Content */ .main-content { flex: 1; - padding: 1.75rem; - width: 100%; - max-width: 1400px; + padding: 1.75rem 2rem; + overflow-y: auto; + min-height: 100vh; + background: #f5f5f5; +} + +.tab-content { + display: none; } -.tab-content { display: none; } -.tab-content.active { display: block; } +.tab-content.active { + display: block; +} -/* ── Dashboard ───────────────────────────────────────────── */ +/* Dashboard */ .dashboard-grid { display: grid; - grid-template-columns: repeat(auto-fit, minmax(220px, 1fr)); - gap: 1.25rem; - margin-bottom: 1.5rem; + grid-template-columns: repeat(auto-fit, minmax(250px, 1fr)); + gap: 1.5rem; + margin-bottom: 2rem; } .stat-card { - background: var(--surface); - border-radius: 0.625rem; - padding: 1.25rem; + background: white; + border-radius: 0.5rem; + padding: 1.5rem; box-shadow: var(--shadow); - border: 1px solid var(--border); display: flex; align-items: center; gap: 1rem; } .stat-icon { - width: 52px; - height: 52px; - border-radius: 0.5rem; + width: 60px; + height: 60px; + border-radius: 50%; display: flex; align-items: center; justify-content: center; - font-size: 1.25rem; + font-size: 1.5rem; color: white; - flex-shrink: 0; } -.stat-icon.movies { background: linear-gradient(135deg, #0096c7, #0077b6); } -.stat-icon.tv { background: linear-gradient(135deg, #6c63ff, #4f46e5); } -.stat-icon.missing { background: linear-gradient(135deg, #f59e0b, #d97706); } -.stat-icon.activity{ background: linear-gradient(135deg, #10b981, #059669); } +.stat-icon.movies { background: linear-gradient(135deg, #667eea, #764ba2); } +.stat-icon.tv { background: linear-gradient(135deg, #f093fb, #f5576c); } +.stat-icon.missing { background: linear-gradient(135deg, #ffecd2, #fcb69f); } +.stat-icon.activity { background: linear-gradient(135deg, #a8edea, #fed6e3); } +.stat-icon.skipped { background: linear-gradient(135deg, #f7971e, #ffd200); } .stat-info h3 { - font-size: 1.75rem; + font-size: 2rem; font-weight: 700; - color: var(--text); - line-height: 1; margin-bottom: 0.25rem; } .stat-info p { font-weight: 500; - color: var(--text); - font-size: 0.875rem; - margin-bottom: 0.125rem; + margin-bottom: 0.25rem; } -.stat-info small { color: var(--text-muted); font-size: 0.8rem; } +.stat-info small { + color: var(--text-muted); + font-size: 0.85rem; +} .dashboard-charts { display: grid; - grid-template-columns: repeat(auto-fit, minmax(280px, 1fr)); - gap: 1.25rem; + grid-template-columns: repeat(auto-fit, minmax(300px, 1fr)); + gap: 1.5rem; } .chart-card { - background: var(--surface); - border-radius: 0.625rem; - padding: 1.25rem; + background: white; + border-radius: 0.5rem; + padding: 1.5rem; box-shadow: var(--shadow); - border: 1px solid var(--border); } .chart-card h3 { margin-bottom: 1rem; - color: var(--text); - font-size: 0.9375rem; - font-weight: 600; + color: var(--dark-color); } .chart-container { - min-height: 180px; + min-height: 200px; display: flex; align-items: center; justify-content: center; - padding: 0.5rem 0; + background: var(--light-color); + border-radius: 0.25rem; color: var(--text-muted); } -/* ── Content header ──────────────────────────────────────── */ -.content-header { +.simple-chart { + width: 100%; + display: flex; + flex-direction: column; + gap: 0.4rem; + padding: 0.75rem; +} + +.chart-item { display: flex; justify-content: space-between; align-items: center; - margin-bottom: 1.25rem; - flex-wrap: wrap; - gap: 0.75rem; + padding: 0.4rem 0.75rem; + border-radius: 0.25rem; + font-size: 0.875rem; } -.content-header h2 { - color: var(--text); - font-weight: 700; - font-size: 1.25rem; +.chart-label { + font-weight: 500; + color: var(--dark-color); +} + +.chart-value { + color: var(--text-muted); + font-variant-numeric: tabular-nums; +} + +/* Content Header */ +.content-header { display: flex; + justify-content: space-between; align-items: center; - gap: 0.5rem; + margin-bottom: 1.5rem; + flex-wrap: wrap; + gap: 1rem; } -.content-header h2 i { color: var(--accent); } +.content-header h2 { + color: var(--dark-color); + font-weight: 600; +} .content-controls { display: flex; - gap: 0.75rem; + gap: 1rem; align-items: center; flex-wrap: wrap; } -.search-controls, .filter-controls { +.search-controls { display: flex; gap: 0.5rem; flex-wrap: wrap; +} + +.filter-controls { + display: flex; + gap: 0.5rem; align-items: center; + flex-wrap: wrap; } .search-box { @@ -371,99 +440,94 @@ body { .search-box i { position: absolute; - left: 0.625rem; + left: 0.75rem; color: var(--text-muted); - font-size: 0.8rem; - pointer-events: none; } .search-box input { - padding: 0.5rem 0.75rem 0.5rem 2.125rem; - border: 1px solid var(--border); - border-radius: 0.375rem; - font-size: 0.875rem; - width: 220px; - background: var(--input-bg); - color: var(--text); - transition: border-color 0.15s, box-shadow 0.15s; + padding: 0.5rem 0.75rem 0.5rem 2.5rem; + border: 1px solid var(--border-color); + border-radius: 0.25rem; + font-size: 0.9rem; + width: 250px; } .search-box input:focus { outline: none; - border-color: var(--accent); - box-shadow: 0 0 0 3px var(--accent-subtle); + border-color: var(--primary-color); + box-shadow: 0 0 0 0.2rem rgba(0, 123, 255, 0.25); } -.search-box input::placeholder { color: var(--text-muted); } - -/* ── Buttons ─────────────────────────────────────────────── */ +/* Buttons */ .btn { padding: 0.5rem 1rem; border: none; - border-radius: 0.375rem; + border-radius: 0.25rem; cursor: pointer; - font-size: 0.875rem; - font-weight: 500; - transition: all 0.15s; + font-size: 0.9rem; + transition: all 0.2s ease; display: inline-flex; align-items: center; - gap: 0.375rem; + gap: 0.5rem; text-decoration: none; - white-space: nowrap; } -.btn-primary { background: var(--accent); color: #fff; } -.btn-primary:hover { background: var(--accent-hover); transform: translateY(-1px); } +.btn-primary { + background-color: var(--primary-color); + color: white; +} -.btn-secondary { background: var(--surface-2); color: var(--text); border: 1px solid var(--border); } -.btn-secondary:hover { background: var(--border); } +.btn-primary:hover { + background-color: #0056b3; + transform: translateY(-1px); +} -.btn-success { background: var(--success); color: #fff; } -.btn-success:hover { filter: brightness(1.1); } +.btn-secondary { + background-color: var(--secondary-color); + color: white; +} -.btn-warning { background: #d97706; color: #fff; } -.btn-warning:hover { background: #b45309; } +.btn-secondary:hover { + background-color: #545b62; +} -.btn-danger { background: var(--danger); color: #fff; } -.btn-danger:hover { filter: brightness(1.1); } +.btn-success { + background-color: var(--success-color); + color: white; +} -.btn-outline { - background: none; - border: 1px solid var(--border); - color: var(--text-muted); +.btn-success:hover { + background-color: #1e7e34; } -.btn-outline:hover { - border-color: var(--accent); - color: var(--accent); - background: var(--accent-subtle); + +.btn-warning { + background-color: var(--warning-color); + color: var(--dark-color); } -.btn-sm { padding: 0.3rem 0.625rem; font-size: 0.8125rem; } +.btn-warning:hover { + background-color: #e0a800; +} -/* ── Select / inputs ─────────────────────────────────────── */ -select { - padding: 0.5rem 0.75rem; - border: 1px solid var(--border); - border-radius: 0.375rem; - font-size: 0.875rem; - background: var(--input-bg); - color: var(--text); - transition: border-color 0.15s; - cursor: pointer; +.btn-danger { + background-color: var(--danger-color); + color: white; } -select:focus { - outline: none; - border-color: var(--accent); - box-shadow: 0 0 0 3px var(--accent-subtle); +.btn-danger:hover { + background-color: #c82333; +} + +.btn-sm { + padding: 0.25rem 0.5rem; + font-size: 0.8rem; } -/* ── Tables ──────────────────────────────────────────────── */ +/* Tables */ .table-container { - background: var(--surface); - border-radius: 0.625rem; + background: white; + border-radius: 0.5rem; box-shadow: var(--shadow); - border: 1px solid var(--border); overflow: hidden; margin-bottom: 1rem; } @@ -475,101 +539,104 @@ select:focus { .data-table th, .data-table td { - padding: 0.75rem 1rem; + padding: 0.75rem; text-align: left; - border-bottom: 1px solid var(--border); + border-bottom: 1px solid var(--border-color); } .data-table th { - background: var(--surface-2); + background-color: var(--light-color); font-weight: 600; - font-size: 0.8125rem; - text-transform: uppercase; - letter-spacing: 0.04em; - color: var(--text-muted); - white-space: nowrap; + color: var(--dark-color); position: sticky; top: 0; - z-index: 1; } -.data-table th.sortable { cursor: pointer; user-select: none; } -.data-table th.sortable:hover { color: var(--accent); } - -.data-table tbody tr:last-child td { border-bottom: none; } - -.data-table tbody tr:hover { background: var(--accent-subtle); } +.data-table tr:hover { + background-color: rgba(0, 123, 255, 0.05); +} .data-table .loading { text-align: center; color: var(--text-muted); - padding: 2.5rem; - font-size: 0.9rem; + font-style: italic; + padding: 2rem; } -/* ── Badges ──────────────────────────────────────────────── */ +/* Status badges */ .badge { - padding: 0.2rem 0.5rem; + padding: 0.25rem 0.5rem; border-radius: 0.25rem; - font-size: 0.7rem; - font-weight: 700; + font-size: 0.75rem; + font-weight: 600; text-transform: uppercase; - letter-spacing: 0.04em; - white-space: nowrap; } -.badge-success { background: var(--badge-success-bg); color: var(--badge-success-text); } -.badge-warning { background: var(--badge-warning-bg); color: var(--badge-warning-text); } -.badge-danger { background: var(--badge-danger-bg); color: var(--badge-danger-text); } -.badge-info { background: var(--badge-info-bg); color: var(--badge-info-text); } -.badge-secondary { background: var(--badge-secondary-bg); color: var(--badge-secondary-text); } +.badge-success { + background-color: #d4edda; + color: #155724; +} + +.badge-warning { + background-color: #fff3cd; + color: #856404; +} + +.badge-danger { + background-color: #f8d7da; + color: #721c24; +} + +.badge-secondary { + background-color: #e9ecef; + color: #495057; +} -/* ── Pagination ──────────────────────────────────────────── */ +/* Pagination */ .pagination { display: flex; justify-content: center; align-items: center; - gap: 0.375rem; + gap: 0.5rem; margin-top: 1rem; - flex-wrap: wrap; } -.pagination .btn { padding: 0.4rem 0.75rem; min-width: 2.25rem; justify-content: center; } -.pagination .page-info { color: var(--text-muted); font-size: 0.875rem; padding: 0 0.5rem; } +.pagination .btn { + padding: 0.5rem 0.75rem; +} + +.pagination .page-info { + margin: 0 1rem; + color: var(--text-muted); +} -/* ── Forms ───────────────────────────────────────────────── */ -.form-group { margin-bottom: 1rem; } +/* Forms */ +.form-group { + margin-bottom: 1rem; +} .form-group label { display: block; - margin-bottom: 0.3rem; + margin-bottom: 0.25rem; font-weight: 500; - font-size: 0.875rem; - color: var(--text); } .form-group input, .form-group select, .form-group textarea { width: 100%; - padding: 0.5rem 0.75rem; - border: 1px solid var(--border); - border-radius: 0.375rem; - font-size: 0.875rem; - background: var(--input-bg); - color: var(--text); - transition: border-color 0.15s, box-shadow 0.15s; + padding: 0.5rem; + border: 1px solid var(--border-color); + border-radius: 0.25rem; + font-size: 0.9rem; } -.form-group input::placeholder, -.form-group textarea::placeholder { color: var(--text-muted); } - .form-group input:focus, .form-group select:focus, .form-group textarea:focus { outline: none; - border-color: var(--accent); - box-shadow: 0 0 0 3px var(--accent-subtle); + border-color: var(--primary-color); + box-shadow: 0 0 0 0.2rem rgba(0, 123, 255, 0.25); } .form-group small { @@ -579,501 +646,441 @@ select:focus { font-size: 0.8rem; } -.form-group small.help-text { color: var(--text-muted); } - -.form-row { - display: grid; - grid-template-columns: 1fr 1fr; - gap: 1rem; -} - .form-actions { display: flex; gap: 0.5rem; justify-content: flex-end; margin-top: 1.5rem; - padding-top: 1rem; - border-top: 1px solid var(--border); -} - -.checkbox-label { - display: flex; - align-items: center; - gap: 0.5rem; - cursor: pointer; - font-weight: 400 !important; } -.checkbox-label input[type="checkbox"] { - width: 16px; - height: 16px; - cursor: pointer; - accent-color: var(--accent); -} - -/* ── Modals ──────────────────────────────────────────────── */ +/* Modal */ .modal { display: none; position: fixed; z-index: 1000; - inset: 0; - background: var(--modal-overlay); - backdrop-filter: blur(2px); + left: 0; + top: 0; + width: 100%; + height: 100%; + background-color: rgba(0, 0, 0, 0.5); } .modal.active { display: flex; align-items: center; justify-content: center; - padding: 1rem; } .modal-content { - background: var(--surface); - border: 1px solid var(--border); - border-radius: 0.75rem; - max-width: 520px; - width: 100%; + background: white; + border-radius: 0.5rem; + max-width: 500px; + width: 90%; max-height: 90vh; overflow-y: auto; box-shadow: var(--shadow-lg); } .modal-header { - padding: 1rem 1.25rem; - border-bottom: 1px solid var(--border); + padding: 1rem 1.5rem; + border-bottom: 1px solid var(--border-color); display: flex; justify-content: space-between; align-items: center; - position: sticky; - top: 0; - background: var(--surface); - z-index: 1; } -.modal-header h3 { font-size: 1rem; font-weight: 600; color: var(--text); } +.modal-header h3 { + margin: 0; +} .modal-close { background: none; border: none; - font-size: 1.25rem; + font-size: 1.5rem; cursor: pointer; color: var(--text-muted); - line-height: 1; - padding: 0.125rem 0.25rem; - border-radius: 0.25rem; - transition: color 0.15s, background 0.15s; } -.modal-close:hover { color: var(--text); background: var(--surface-2); } - -.modal-body { padding: 1.25rem; } - -#edit-modal, #smart-fix-modal { z-index: 1100; } - -/* ── Section cards ───────────────────────────────────────── */ -.section-card { - background: var(--surface); - border-radius: 0.625rem; - padding: 1.25rem; - border: 1px solid var(--border); - box-shadow: var(--shadow); - margin-bottom: 1.5rem; +.modal-close:hover { + color: var(--dark-color); } -.section-card h3 { - font-size: 0.9375rem; - font-weight: 600; - color: var(--text); - margin-bottom: 1rem; - display: flex; - align-items: center; - gap: 0.5rem; +.modal-body { + padding: 1.5rem; } -.section-card h3 i { color: var(--accent); } +/* Higher z-index for edit modals that appear on top of other modals */ +#edit-modal, #smart-fix-modal { + z-index: 1100 !important; +} -/* ── Reports ─────────────────────────────────────────────── */ +/* Reports */ .report-summary { display: grid; grid-template-columns: repeat(auto-fit, minmax(200px, 1fr)); gap: 1rem; - margin-bottom: 1.5rem; + margin-bottom: 2rem; } .summary-card { - background: var(--surface); - padding: 1.25rem; - border-radius: 0.625rem; + background: white; + padding: 1.5rem; + border-radius: 0.5rem; box-shadow: var(--shadow); - border: 1px solid var(--border); text-align: center; } -.summary-card h3 { margin-bottom: 0.75rem; color: var(--text); font-size: 0.9375rem; } -.summary-card p { margin-bottom: 0.375rem; font-size: 1rem; color: var(--text); } -.summary-card span { font-weight: 700; color: var(--accent); } +.summary-card h3 { + margin-bottom: 1rem; + color: var(--dark-color); +} -.report-section { margin-bottom: 2rem; } +.summary-card p { + margin-bottom: 0.5rem; + font-size: 1.1rem; +} -.report-section h3 { - margin-bottom: 0.75rem; - color: var(--text); - font-size: 0.9375rem; - font-weight: 600; - display: flex; - align-items: center; - gap: 0.5rem; +.summary-card span { + font-weight: 700; + color: var(--primary-color); } -/* ── Tools ───────────────────────────────────────────────── */ -.tools-grid { - display: grid; - grid-template-columns: repeat(auto-fit, minmax(300px, 1fr)); - gap: 1.25rem; +.report-section { + margin-bottom: 2rem; } -.tool-card { - background: var(--surface); - border-radius: 0.625rem; - padding: 1.25rem; - box-shadow: var(--shadow); - border: 1px solid var(--border); +.report-section h3 { + margin-bottom: 1rem; + color: var(--dark-color); } -.tool-card h3 { - margin-bottom: 0.375rem; - color: var(--text); - font-size: 0.9375rem; - font-weight: 600; - display: flex; - align-items: center; - gap: 0.5rem; +/* Tools — each tool is its own full page now (sidebar dropdown), not a + shared grid of cards, so a five-line form and a full log viewer don't + have to fight each other for space. */ +.tool-page { + background: white; + border-radius: 0.5rem; + padding: 1.5rem; + box-shadow: var(--shadow); + max-width: 640px; } -.tool-card h3 i { color: var(--accent); } +.tool-page.tool-page-wide { + max-width: none; +} -.tool-card > p { - margin-bottom: 1.25rem; +.tool-page-desc { + margin-bottom: 1.5rem; color: var(--text-muted); - font-size: 0.875rem; } .stats-display { - background: var(--surface-2); - border: 1px solid var(--border); + background: var(--light-color); padding: 1rem; - border-radius: 0.375rem; + border-radius: 0.25rem; margin-bottom: 1rem; - min-height: 80px; - color: var(--text); - font-size: 0.875rem; + min-height: 100px; } -/* ── Toast notifications ─────────────────────────────────── */ +/* Toast notifications */ .toast-container { position: fixed; - top: 1.25rem; - right: 1.25rem; - z-index: 2000; - display: flex; - flex-direction: column; - gap: 0.5rem; - pointer-events: none; + top: 20px; + right: 20px; + z-index: 1050; } .toast { - background: var(--surface); - border: 1px solid var(--border); - border-radius: 0.5rem; + background: white; + border-radius: 0.25rem; box-shadow: var(--shadow-lg); + margin-bottom: 0.5rem; padding: 0.75rem 1rem; - min-width: 280px; - max-width: 360px; - border-left: 3px solid var(--accent); - animation: toastIn 0.25s ease; - pointer-events: all; - color: var(--text); - font-size: 0.875rem; -} - -.toast.success { border-left-color: var(--success); } -.toast.warning { border-left-color: #d97706; } -.toast.error { border-left-color: var(--danger); } - -@keyframes toastIn { - from { transform: translateX(110%); opacity: 0; } - to { transform: translateX(0); opacity: 1; } + min-width: 300px; + border-left: 4px solid var(--primary-color); + animation: slideIn 0.3s ease; } -/* ── Scan / progress ─────────────────────────────────────── */ -.scan-status { - margin-top: 1rem; - padding: 1rem; - background: var(--surface-2); - border: 1px solid var(--border); - border-radius: 0.5rem; +.toast.success { + border-left-color: var(--success-color); } -.progress-bar { - width: 100%; - height: 6px; - background: var(--progress-bg); - border-radius: 999px; - overflow: hidden; - margin-bottom: 0.5rem; +.toast.warning { + border-left-color: var(--warning-color); } -.progress-fill { - height: 100%; - background: linear-gradient(90deg, var(--accent), var(--success)); - border-radius: 999px; - transition: width 0.3s ease; - width: 0%; +.toast.error { + border-left-color: var(--danger-color); } -.scan-info { - display: flex; - justify-content: space-between; - font-size: 0.8125rem; - color: var(--text-muted); +@keyframes slideIn { + from { + transform: translateX(100%); + opacity: 0; + } + to { + transform: translateX(0); + opacity: 1; + } } -.scan-info span:last-child { color: var(--accent); font-weight: 600; } - -/* ── Smart Fix / Date option cards ───────────────────────── */ -.smart-fix-options, .date-options { +/* Smart Fix Modal */ +.smart-fix-options { display: flex; flex-direction: column; - gap: 0.625rem; + gap: 1rem; margin-bottom: 1rem; } -.option-card, .date-option-card { - border: 1px solid var(--border); +.option-card { + border: 2px solid var(--border-color); border-radius: 0.5rem; - transition: border-color 0.15s, box-shadow 0.15s; - background: var(--surface); + transition: all 0.2s ease; } -.option-card:hover, .date-option-card:hover { - border-color: var(--accent); - box-shadow: 0 0 0 2px var(--accent-subtle); +.option-card:hover { + border-color: var(--primary-color); + box-shadow: var(--shadow); } -.option-label, .date-option-label { - display: flex; - align-items: flex-start; - gap: 0.625rem; - padding: 0.875rem; +.option-label { + display: block; + padding: 1rem; cursor: pointer; margin: 0; } -.option-label input[type="radio"], -.date-option-label input[type="radio"] { - margin-top: 0.125rem; +.option-label input[type="radio"] { + margin-right: 0.75rem; + margin-top: 0.1rem; width: auto; - flex-shrink: 0; - accent-color: var(--accent); } -.option-content h4, .date-option-content h4 { - margin: 0 0 0.25rem; - font-size: 0.9rem; - font-weight: 600; - color: var(--text); +.option-content h4 { + margin: 0 0 0.5rem 0; + color: var(--dark-color); + font-size: 1rem; } -.option-content p, .date-option-content p { - margin: 0 0 0.25rem; +.option-content p { + margin: 0 0 0.5rem 0; color: var(--text-muted); - font-size: 0.8rem; + font-size: 0.9rem; } -.option-content small, .date-option-content small { +.option-content small { color: var(--text-muted); - font-size: 0.775rem; + font-size: 0.8rem; } -.option-card:has(input[type="radio"]:checked), -.date-option-card:has(input[type="radio"]:checked) { - border-color: var(--accent); - background: var(--accent-subtle); +.manual-date-input { + width: 100% !important; + margin-top: 0.5rem !important; } -.option-card:has(input[type="radio"]:checked) .option-content h4, -.date-option-card:has(input[type="radio"]:checked) .date-option-content h4 { - color: var(--accent); +.option-card input[type="radio"]:checked + .option-content { + color: var(--primary-color); } -/* ── Cron builder ────────────────────────────────────────── */ -.cron-input-container { - display: flex; - gap: 0.5rem; - align-items: center; +.option-card:has(input[type="radio"]:checked) { + border-color: var(--primary-color); + background-color: rgba(0, 123, 255, 0.05); } -.cron-input-container input { flex: 1; } - -.cron-presets { margin-bottom: 1.25rem; } -.cron-presets h4 { margin-bottom: 0.625rem; font-size: 0.875rem; color: var(--text); } - -.preset-buttons { display: flex; flex-wrap: wrap; gap: 0.375rem; } - -.cron-fields { margin-bottom: 1.25rem; } -.cron-fields h4 { margin-bottom: 0.75rem; font-size: 0.875rem; color: var(--text); } +/* Additional badge styles */ +.badge-info { + background-color: #d1ecf1; + color: #0c5460; +} -.field-group { +/* Enhanced Edit Modal Date Options */ +.date-options { display: flex; - align-items: center; + flex-direction: column; gap: 0.75rem; - margin-bottom: 0.5rem; + margin-bottom: 1rem; } -.field-group label { - width: 160px; - flex-shrink: 0; - font-size: 0.875rem; - color: var(--text-muted); - margin: 0; +.date-option-card { + border: 1px solid var(--border-color); + border-radius: 0.375rem; + transition: all 0.2s ease; } -.field-group input { - width: 100px; - padding: 0.375rem 0.625rem; - border: 1px solid var(--border); - border-radius: 0.375rem; - background: var(--input-bg); - color: var(--text); - font-size: 0.875rem; +.date-option-card:hover { + border-color: var(--primary-color); + box-shadow: 0 0 0 2px rgba(0, 123, 255, 0.1); } -.cron-preview { margin-bottom: 1rem; } -.cron-preview h4 { margin-bottom: 0.5rem; font-size: 0.875rem; color: var(--text); } +.date-option-label { + display: block; + padding: 0.75rem; + cursor: pointer; + margin: 0; +} -.cron-expression { - background: var(--code-bg); - border: 1px solid var(--border); - border-radius: 0.375rem; - padding: 0.625rem 0.875rem; - margin-bottom: 0.5rem; +.date-option-label input[type="radio"] { + margin-right: 0.5rem; + margin-top: 0.1rem; + width: auto; } -.cron-expression code { font-family: monospace; font-size: 1rem; color: var(--accent); } -.cron-description { font-size: 0.875rem; color: var(--text-muted); } +.date-option-content h4 { + margin: 0 0 0.25rem 0; + color: var(--dark-color); + font-size: 0.9rem; + font-weight: 600; +} -/* ── Inline checkbox groups (Tools tab) ──────────────────── */ -.checkbox-group { - display: flex; - flex-direction: column; - gap: 0.375rem; - margin-top: 0.375rem; +.date-option-content p { + margin: 0 0 0.25rem 0; + color: var(--text-muted); + font-size: 0.8rem; } -.checkbox-group label { - display: flex; - align-items: center; - gap: 0.5rem; - cursor: pointer; - font-weight: 400; - color: var(--text); +.date-option-content small { + color: var(--primary-color); + font-size: 0.75rem; + font-weight: 500; } -.checkbox-group label input[type="checkbox"] { - width: 15px; - height: 15px; - accent-color: var(--accent); - cursor: pointer; +.date-option-card input[type="radio"]:checked + .date-option-content h4 { + color: var(--primary-color); } -/* ── Utility ─────────────────────────────────────────────── */ -.text-center { text-align: center; } -.text-muted { color: var(--text-muted); } -.mb-0 { margin-bottom: 0; } -.mb-1 { margin-bottom: 0.5rem; } -.mb-2 { margin-bottom: 1rem; } -.mt-1 { margin-top: 0.5rem; } -.mt-2 { margin-top: 1rem; } -.d-none { display: none; } -.d-block { display: block; } -.d-flex { display: flex; } -.justify-content-between { justify-content: space-between; } -.align-items-center { align-items: center; } +.date-option-card:has(input[type="radio"]:checked) { + border-color: var(--primary-color); + background-color: rgba(0, 123, 255, 0.03); +} -code { - font-family: monospace; - background: var(--code-bg); - padding: 0.1em 0.35em; - border-radius: 0.2em; - font-size: 0.875em; - color: var(--accent); +/* Responsive */ +@media (max-width: 900px) { + .sidebar { + width: 180px; + min-width: 180px; + } } -/* ── Mobile ──────────────────────────────────────────────── */ -@media (max-width: 768px) { +@media (max-width: 640px) { + .app-container { + flex-direction: column; + } + .sidebar { - position: fixed; - left: -220px; - top: 0; - height: 100vh; - transition: left 0.25s ease; - z-index: 200; + width: 100%; + min-width: unset; + height: auto; + min-height: unset; + position: static; + } + + .sidebar-sub-items.expanded { + max-height: 600px; + } + + .main-content { + min-height: unset; + padding: 1rem; + } + + .content-header { + flex-direction: column; + align-items: stretch; } - .sidebar.open { left: 0; } - - .mobile-header { - display: flex; - align-items: center; - gap: 0.75rem; - padding: 0.875rem 1rem; - background: var(--surface); - border-bottom: 1px solid var(--border); - position: sticky; - top: 0; - z-index: 150; + .content-controls { + justify-content: center; } - .mobile-menu-btn { - background: none; - border: none; - color: var(--text); - font-size: 1.125rem; - cursor: pointer; - padding: 0.25rem; + .search-box input { + width: 200px; } - .mobile-title { - font-weight: 700; - color: var(--text); - font-size: 1rem; + .data-table { + font-size: 0.8rem; } - .sidebar-overlay { - display: none; - position: fixed; - inset: 0; - background: var(--modal-overlay); - z-index: 199; + .data-table th, + .data-table td { + padding: 0.5rem 0.25rem; } - .sidebar-overlay.active { display: block; } + .dashboard-grid { + grid-template-columns: 1fr; + } + + .tool-page { + max-width: none; + } +} + +/* Utility classes */ +.text-center { text-align: center; } +.text-muted { color: var(--text-muted); } +.mb-0 { margin-bottom: 0; } +.mb-1 { margin-bottom: 0.5rem; } +.mb-2 { margin-bottom: 1rem; } +.mt-1 { margin-top: 0.5rem; } +.mt-2 { margin-top: 1rem; } +.d-none { display: none; } +.d-block { display: block; } +.d-flex { display: flex; } +.justify-content-between { justify-content: space-between; } +.align-items-center { align-items: center; } + +/* Manual Scan Styles */ +.scan-status { + margin-top: 1rem; + padding: 1rem; + background-color: var(--light-color); + border: 1px solid var(--border-color); + border-radius: 0.375rem; +} + +.scan-progress { + margin-bottom: 1rem; +} + +.progress-bar { + width: 100%; + height: 1.5rem; + background-color: #e9ecef; + border-radius: 0.375rem; + overflow: hidden; + margin-bottom: 0.5rem; +} - .main-content { padding: 1rem; } +.progress-fill { + height: 100%; + background: linear-gradient(90deg, var(--primary-color), var(--success-color)); + transition: width 0.3s ease; + width: 0%; +} - .content-header { flex-direction: column; align-items: stretch; } - .content-controls { justify-content: flex-start; } - .search-box input { width: 100%; } +.scan-info { + display: flex; + justify-content: space-between; + align-items: center; + font-size: 0.875rem; +} - .dashboard-grid { grid-template-columns: 1fr 1fr; } - .tools-grid { grid-template-columns: 1fr; } - .form-row { grid-template-columns: 1fr; } +.scan-info span:first-child { + color: var(--text-muted); +} - .data-table { font-size: 0.8125rem; } - .data-table th, .data-table td { padding: 0.5rem 0.625rem; } +.scan-info span:last-child { + font-weight: 600; + color: var(--primary-color); } -@media (max-width: 480px) { - .dashboard-grid { grid-template-columns: 1fr; } +.form-group small { + display: block; + margin-top: 0.25rem; + color: var(--text-muted); + font-size: 0.875rem; } + +.btn-sm { + padding: 0.375rem 0.75rem; + font-size: 0.875rem; +} \ No newline at end of file diff --git a/chronarr-web/static/index.html b/chronarr-web/static/index.html index a47adde..76ae1b3 100644 --- a/chronarr-web/static/index.html +++ b/chronarr-web/static/index.html @@ -4,93 +4,107 @@ Chronarr - Database Management - + - -
- +
- - -
+ +
@@ -104,7 +118,7 @@

-

- with dates
- +
@@ -115,7 +129,7 @@

-

- episodes
- +
@@ -126,7 +140,7 @@

-

- no valid source
- +
@@ -139,7 +153,7 @@

-

-
+
@@ -182,7 +196,6 @@

Movies Database

- + + + + +
+
+ + +
+
+ + +
+ +
- -
+ +
-

Scheduled Cleanups

- +

Manual Scan

- - -
-

Active Cleanup Schedules

-
- - - - - - - - - - - - - - - - -
NameValidationScheduleLast RunNext RunItems RemovedStatusActions
+
+

Scan specific folders or perform full library scans

+
+
+ + +
+
+ + +
+
+ + + Leave empty to scan entire library +
+ +
+
+
- -
-

Recent Cleanup Executions

-
- - - - - - - - - - - - - - - - -
ScheduleStartedDurationStatusMovies RemovedSeries RemovedEpisodes RemovedActions
+ +
+
+

Database Statistics

+
+
+

View detailed database information

+
+

Click refresh to load detailed statistics

+
- -
+ +
-

Database Tools

+

Populate Database

- -
-
-

Bulk Source Update

-

Change source for multiple items at once

-
-
- - -
-
- - -
-
- - -
- -
-
- -
-

Manual Scan

-

Scan specific folders or perform full library scans

-
-
- - -
-
- - -
-
- - - Leave empty to scan entire library -
- -
- -
-
-
+ + - - - - - - - - -
- - - + - \ No newline at end of file + diff --git a/chronarr-web/static/js/app.js b/chronarr-web/static/js/app.js index 4b13330..1b61b82 100644 --- a/chronarr-web/static/js/app.js +++ b/chronarr-web/static/js/app.js @@ -5,142 +5,159 @@ let currentTab = 'dashboard'; let currentMoviesPage = 1; let currentSeriesPage = 1; let dashboardData = null; +let currentMovieInstance = ''; +let currentTvInstance = ''; -// Initialize app -document.addEventListener('DOMContentLoaded', function() { - // Populate sidebar version from the backend — stays in sync with VERSION file - fetch('/health') - .then(function(r) { return r.json(); }) - .then(function(d) { - var el = document.getElementById('app-version'); - if (el && d.version) el.textContent = 'v' + d.version; - }) - .catch(function() { /* leave as-is on failure */ }); - - try { - initializeTabs(); - } catch (error) { - console.error('Error initializing tabs:', error); - } - - try { - initializeEventListeners(); - } catch (error) { - console.error('Error initializing event listeners:', error); - } +// Instance badge color palette — assigned in order as instances are discovered +const instanceColorMap = {}; +const instanceColors = ['#3b82f6', '#8b5cf6', '#10b981', '#f59e0b', '#ef4444']; +let instanceColorIndex = 0; - try { - checkAuthStatus(); // Check authentication status on page load - } catch (error) { - console.error('Error checking auth status:', error); +function getInstanceColor(name) { + if (!name) return '#6b7280'; + if (!instanceColorMap[name]) { + instanceColorMap[name] = instanceColors[instanceColorIndex++ % instanceColors.length]; } + return instanceColorMap[name]; +} - try { - loadDashboard(); - } catch (error) { - console.error('Error loading dashboard:', error); - } +function instanceBadge(name) { + if (!name) return '-'; + const c = getInstanceColor(name); + return `${escapeHtml(name)}`; +} - try { - loadSeriesSources(); - } catch (error) { - console.error('Error loading series sources:', error); - } +// Initialize app +document.addEventListener('DOMContentLoaded', function() { + initializeEventListeners(); + checkAuthStatus(); + loadDashboard(); + loadSeriesSources(); + buildSidebarInstances(); }); // Tab management -function initializeTabs() { - const tabButtons = document.querySelectorAll('.nav-item'); - const tabContents = document.querySelectorAll('.tab-content'); - - tabButtons.forEach(button => { - button.addEventListener('click', function() { - const tabName = this.dataset.tab; - if (tabName) switchTab(tabName); - // Close sidebar on mobile after nav - if (window.innerWidth <= 768 && typeof closeSidebar === 'function') closeSidebar(); - }); - }); -} - function switchTab(tabName) { - // Update button states - document.querySelectorAll('.nav-item').forEach(btn => btn.classList.remove('active')); - document.querySelector(`[data-tab="${tabName}"]`).classList.add('active'); - + // Update sidebar item active states + document.querySelectorAll('.sidebar-item[data-tab]').forEach(btn => btn.classList.remove('active')); + const activeBtn = document.querySelector(`.sidebar-item[data-tab="${tabName}"]`); + if (activeBtn) activeBtn.classList.add('active'); + // Update content document.querySelectorAll('.tab-content').forEach(content => content.classList.remove('active')); document.getElementById(tabName).classList.add('active'); - + currentTab = tabName; - - // Load tab-specific data + + if (tabName !== 'tool-logs') { + // Don't keep polling the log tail in the background once the user + // has navigated away from the page that shows it. + stopLogTailAutoRefresh(); + } + switch(tabName) { - case 'dashboard': - loadDashboard(); - break; - case 'movies': - loadMovies(); - break; - case 'tv': - loadSeries(); - break; - case 'reports': - loadReport(); - break; - case 'tools': - loadDetailedStats(); - break; + case 'dashboard': loadDashboard(); break; + case 'movies': loadMovies(); break; + case 'tv': loadSeries(); break; + case 'reports': loadReport(); break; + case 'tool-stats': loadDetailedStats(); break; + case 'tool-populate': loadPopulateInstanceOptions(); break; + case 'tool-logs': loadLogFiles(); break; + case 'tool-unresolved': loadUnresolvedLookups(); break; + } +} + +// Sidebar instance navigation +function toggleSidebarGroup(subId, tabName) { + const sub = document.getElementById(subId); + const isExpanded = sub.classList.toggle('expanded'); + const toggle = sub.closest('.sidebar-group').querySelector('.sidebar-group-toggle'); + toggle.setAttribute('aria-expanded', isExpanded ? 'true' : 'false'); + if (tabName) switchTab(tabName); +} + +function selectToolsPage(page) { + document.querySelectorAll('#tools-sub .sidebar-sub-item').forEach(btn => btn.classList.remove('active')); + const target = document.getElementById(`sub-${page}`); + if (target) target.classList.add('active'); + switchTab(page); +} + +function selectMovieInstance(name) { + currentMovieInstance = name; + currentMoviesPage = 1; + document.querySelectorAll('#movies-sub .sidebar-sub-item').forEach(btn => btn.classList.remove('active')); + const target = document.getElementById(name ? `sub-movies-${name}` : 'sub-movies-all'); + if (target) target.classList.add('active'); + switchTab('movies'); +} + +function selectTvInstance(name) { + currentTvInstance = name; + currentSeriesPage = 1; + document.querySelectorAll('#tv-sub .sidebar-sub-item').forEach(btn => btn.classList.remove('active')); + const target = document.getElementById(name ? `sub-tv-${name}` : 'sub-tv-all'); + if (target) target.classList.add('active'); + switchTab('tv'); +} + +async function buildSidebarInstances() { + try { + const data = await apiCall('/api/instances'); + const radarrNames = (data.radarr || []).map(i => i.name); + const sonarrNames = (data.sonarr || []).map(i => i.name); + + // Pre-assign colors so badges match sidebar dots + [...radarrNames, ...sonarrNames].forEach(n => getInstanceColor(n)); + + const moviesSub = document.getElementById('movies-sub'); + radarrNames.forEach(name => { + const color = getInstanceColor(name); + const btn = document.createElement('button'); + btn.className = 'sidebar-sub-item'; + btn.id = `sub-movies-${name}`; + btn.onclick = () => selectMovieInstance(name); + btn.innerHTML = `${escapeHtml(name)}`; + moviesSub.appendChild(btn); + }); + + const tvSub = document.getElementById('tv-sub'); + sonarrNames.forEach(name => { + const color = getInstanceColor(name); + const btn = document.createElement('button'); + btn.className = 'sidebar-sub-item'; + btn.id = `sub-tv-${name}`; + btn.onclick = () => selectTvInstance(name); + btn.innerHTML = `${escapeHtml(name)}`; + tvSub.appendChild(btn); + }); + } catch (error) { + console.error('Failed to build sidebar instances:', error); } } // Event listeners function initializeEventListeners() { // Search inputs - const moviesSearch = document.getElementById('movies-search'); - const moviesImdbSearch = document.getElementById('movies-imdb-search'); - const seriesSearch = document.getElementById('series-search'); - const seriesImdbSearch = document.getElementById('series-imdb-search'); - - if (moviesSearch) moviesSearch.addEventListener('input', debounce(loadMovies, 500)); - if (moviesImdbSearch) moviesImdbSearch.addEventListener('input', debounce(loadMovies, 500)); - if (seriesSearch) seriesSearch.addEventListener('input', debounce(loadSeries, 500)); - if (seriesImdbSearch) seriesImdbSearch.addEventListener('input', debounce(loadSeries, 500)); - + document.getElementById('movies-search').addEventListener('input', debounce(loadMovies, 500)); + document.getElementById('movies-imdb-search').addEventListener('input', debounce(loadMovies, 500)); + document.getElementById('series-search').addEventListener('input', debounce(loadSeries, 500)); + document.getElementById('series-imdb-search').addEventListener('input', debounce(loadSeries, 500)); + // Filter dropdowns - const moviesFilterDate = document.getElementById('movies-filter-date'); - const moviesFilterSource = document.getElementById('movies-filter-source'); - const seriesFilterDate = document.getElementById('series-filter-date'); - const seriesFilterSource = document.getElementById('series-filter-source'); - - if (moviesFilterDate) moviesFilterDate.addEventListener('change', loadMovies); - if (moviesFilterSource) moviesFilterSource.addEventListener('change', loadMovies); - if (seriesFilterDate) seriesFilterDate.addEventListener('change', loadSeries); - if (seriesFilterSource) seriesFilterSource.addEventListener('change', loadSeries); - + document.getElementById('movies-filter-date').addEventListener('change', loadMovies); + document.getElementById('movies-filter-source').addEventListener('change', loadMovies); + document.getElementById('series-filter-date').addEventListener('change', loadSeries); + document.getElementById('series-filter-source').addEventListener('change', loadSeries); + // Forms - const editForm = document.getElementById('edit-form'); - const bulkUpdateForm = document.getElementById('bulk-update-form'); - const manualScanForm = document.getElementById('manual-scan-form'); - const manualCleanupForm = document.getElementById('manual-cleanup-form'); - const populateForm = document.getElementById('populate-form'); - const librarySyncForm = document.getElementById('library-sync-form'); - - if (editForm) editForm.addEventListener('submit', handleEditSubmit); - if (bulkUpdateForm) bulkUpdateForm.addEventListener('submit', handleBulkUpdate); - if (manualScanForm) manualScanForm.addEventListener('submit', handleManualScan); - if (manualCleanupForm) manualCleanupForm.addEventListener('submit', handleManualCleanup); - if (populateForm) populateForm.addEventListener('submit', handlePopulateDatabase); - if (librarySyncForm) { - librarySyncForm.addEventListener('submit', handleLibrarySync); - const dryRunCb = document.getElementById('sync-dry-run'); - const immediateGroup = document.getElementById('sync-immediate-group'); - if (dryRunCb && immediateGroup) { - dryRunCb.addEventListener('change', () => { - immediateGroup.style.display = dryRunCb.checked ? 'none' : 'block'; - }); - } - loadSyncSettings(); + document.getElementById('edit-form').addEventListener('submit', handleEditSubmit); + document.getElementById('bulk-update-form').addEventListener('submit', handleBulkUpdate); + document.getElementById('manual-scan-form').addEventListener('submit', handleManualScan); + document.getElementById('populate-form').addEventListener('submit', handlePopulateDatabase); + const populateInstanceSelect = document.getElementById('populate-instance'); + if (populateInstanceSelect) { + populateInstanceSelect.addEventListener('change', syncPopulateMediaTypeToInstance); } } @@ -206,111 +223,54 @@ function updateDashboardStats() { document.getElementById('recent-activity').textContent = dashboardData.recent_activity_count || 0; - // Skipped items - const skippedMovies = dashboardData.movies_skipped || 0; - const skippedEpisodes = dashboardData.episodes_skipped || 0; - const skippedTotal = dashboardData.total_skipped || (skippedMovies + skippedEpisodes); - document.getElementById('skipped-total').textContent = skippedTotal; - document.getElementById('skipped-breakdown').textContent = `${skippedMovies} movies, ${skippedEpisodes} episodes`; -} - -function showSkippedItems() { - // Switch to Movies tab and filter to show only skipped items - switchTab('movies'); - // Set the filter dropdown to "skipped" - const moviesFilter = document.getElementById('movies-filter-date'); - if (moviesFilter) { - moviesFilter.value = 'skipped'; - refreshMovies(); - } -} - -// Chart instances — kept so we can destroy before re-rendering on refresh -const _chartInstances = {}; - -const CHART_COLORS = [ - '#00b4d8', '#6c63ff', '#10b981', '#f59e0b', - '#f43f5e', '#8b5cf6', '#06b6d4', '#84cc16' -]; - -function _isDark() { - return window.matchMedia && window.matchMedia('(prefers-color-scheme: dark)').matches; -} - -function _chartTextColor() { - return _isDark() ? '#8892b0' : '#718096'; + const moviesSkipped = dashboardData.movies_skipped || 0; + const episodesSkipped = dashboardData.episodes_skipped || 0; + document.getElementById('skipped-total').textContent = dashboardData.total_skipped || (moviesSkipped + episodesSkipped); + document.getElementById('skipped-breakdown').textContent = `${moviesSkipped} movies, ${episodesSkipped} episodes`; } function updateDashboardCharts() { if (!dashboardData) return; - renderDonutChart('movie-sources-chart', dashboardData.movie_sources); - renderDonutChart('episode-sources-chart', dashboardData.episode_sources); -} - -function renderDonutChart(containerId, data) { - const container = document.getElementById(containerId); - if (!container) return; - - // Destroy previous instance if it exists - if (_chartInstances[containerId]) { - _chartInstances[containerId].destroy(); - delete _chartInstances[containerId]; + + // Movie sources chart + const movieChart = document.getElementById('movie-sources-chart'); + if (dashboardData.movie_sources && dashboardData.movie_sources.length > 0) { + movieChart.innerHTML = createSimpleChart(dashboardData.movie_sources); + } else { + movieChart.innerHTML = '

No movie source data available

'; } - - if (!data || data.length === 0) { - container.innerHTML = '

No data available

'; - return; + + // Episode sources chart + const episodeChart = document.getElementById('episode-sources-chart'); + if (dashboardData.episode_sources && dashboardData.episode_sources.length > 0) { + episodeChart.innerHTML = createSimpleChart(dashboardData.episode_sources); + } else { + episodeChart.innerHTML = '

No episode source data available

'; } +} - // Build canvas + legend wrapper - container.innerHTML = ` -
-
- +function createSimpleChart(data) { + const total = data.reduce((sum, item) => sum + item.count, 0); + let html = '
'; + + data.forEach((item, index) => { + const percentage = ((item.count / total) * 100).toFixed(1); + const color = getChartColor(index); + html += ` +
+ ${item.source} + ${item.count} (${percentage}%)
-
-
`; - - const total = data.reduce((sum, i) => sum + i.count, 0); - const labels = data.map(i => i.source); - const counts = data.map(i => i.count); - const colors = data.map((_, idx) => CHART_COLORS[idx % CHART_COLORS.length]); - - const ctx = document.getElementById(`${containerId}-canvas`).getContext('2d'); - _chartInstances[containerId] = new Chart(ctx, { - type: 'doughnut', - data: { labels, datasets: [{ data: counts, backgroundColor: colors, borderWidth: 0, hoverOffset: 4 }] }, - options: { - cutout: '68%', - animation: { duration: 400 }, - plugins: { - legend: { display: false }, - tooltip: { - callbacks: { - label: ctx => ` ${ctx.parsed.toLocaleString()} (${((ctx.parsed / total) * 100).toFixed(1)}%)` - }, - backgroundColor: _isDark() ? '#1e2235' : '#fff', - titleColor: _isDark() ? '#e2e8f0' : '#1a202c', - bodyColor: _isDark() ? '#8892b0' : '#718096', - borderColor: _isDark() ? '#2a2f4a' : '#e2e8f0', - borderWidth: 1, - } - } - } + `; }); + + html += '
'; + return html; +} - // Custom legend - const legend = document.getElementById(`${containerId}-legend`); - data.forEach((item, idx) => { - const pct = ((item.count / total) * 100).toFixed(1); - const el = document.createElement('div'); - el.style.cssText = 'display:flex;align-items:center;gap:0.5rem;min-width:0;'; - el.innerHTML = ` - - ${item.source} - ${pct}%`; - legend.appendChild(el); - }); +function getChartColor(index) { + const colors = ['#007bff', '#28a745', '#ffc107', '#dc3545', '#6c757d', '#17a2b8', '#6f42c1']; + return colors[index % colors.length]; } // Movies @@ -322,8 +282,9 @@ async function loadMovies(page = 1) { const search = document.getElementById('movies-search').value; const imdbSearch = document.getElementById('movies-imdb-search').value; - const dateFilter = document.getElementById('movies-filter-date').value; + const hasDate = document.getElementById('movies-filter-date').value; const sourceFilter = document.getElementById('movies-filter-source').value; + const instanceFilter = currentMovieInstance; const skip = (page - 1) * 100; console.log(`DEBUG: loadMovies called with page=${page}, calculated skip=${skip}`); @@ -335,15 +296,9 @@ async function loadMovies(page = 1) { if (search) params.append('search', search); if (imdbSearch) params.append('imdb_search', imdbSearch); - - // Handle different filter values - if (dateFilter === 'skipped') { - params.append('skipped', 'true'); - } else if (dateFilter) { - params.append('has_date', dateFilter); - } - + if (hasDate) params.append('has_date', hasDate); if (sourceFilter) params.append('source_filter', sourceFilter); + if (instanceFilter) params.append('instance', instanceFilter); try { const data = await apiCall(`/api/movies?${params}`); @@ -360,7 +315,7 @@ function updateMoviesTable(data) { const tbody = document.getElementById('movies-tbody'); if (!data.movies || data.movies.length === 0) { - tbody.innerHTML = 'No movies found'; + tbody.innerHTML = 'No movies found'; return; } @@ -409,36 +364,24 @@ function updateMoviesTable(data) { dateTypeBadge = 'badge-warning'; } - // Check if skipped and if IMDb ID is placeholder - const isSkipped = movie.skipped === true; - const isPlaceholder = movie.imdb_id && movie.imdb_id.startsWith('missing-'); - const skipReasonBadge = isSkipped ? `
Skipped` : ''; - - // Add Update IMDb ID button for placeholder IDs - const updateImdbButton = isPlaceholder ? ` - - ` : ''; - return ` ${escapeHtml(movie.title)} - ${movie.imdb_id}${skipReasonBadge} + ${movie.imdb_id} ${movie.released || '-'} ${dateadded || '-'} ${movie.source_description || movie.source || 'Unknown'} ${dateType} ${hasVideoBadge} + ${instanceBadge(movie.instance)} - - - ${updateImdbButton} - @@ -506,6 +449,7 @@ async function loadSeriesSources() { } } + function refreshMovies() { loadMovies(isNaN(currentMoviesPage) ? 1 : currentMoviesPage); } @@ -521,19 +465,21 @@ async function loadSeries(page = 1) { const imdbSearch = document.getElementById('series-imdb-search').value; const dateFilter = document.getElementById('series-filter-date').value; const sourceFilter = document.getElementById('series-filter-source').value; - + const instanceFilter = currentTvInstance; + const skip = (page - 1) * 50; console.log(`DEBUG: loadSeries called with page=${page}, calculated skip=${skip}`); - + const params = new URLSearchParams({ skip: skip, limit: 50 }); - + if (search) params.append('search', search); if (imdbSearch) params.append('imdb_search', imdbSearch); if (dateFilter) params.append('date_filter', dateFilter); if (sourceFilter) params.append('source_filter', sourceFilter); + if (instanceFilter) params.append('instance', instanceFilter); try { const data = await apiCall(`/api/series?${params}`); @@ -552,21 +498,11 @@ function updateSeriesTable(data) { tbody.innerHTML = 'No series found'; return; } - + tbody.innerHTML = data.series.map(series => { const progressPercent = series.total_episodes > 0 ? ((series.episodes_with_dates / series.total_episodes) * 100).toFixed(1) : 0; - // Check if IMDb ID is placeholder - const isPlaceholder = series.imdb_id && series.imdb_id.startsWith('missing-'); - - // Add Update IMDb ID button for placeholder IDs - const updateImdbButton = isPlaceholder ? ` - - ` : ''; - return ` ${escapeHtml(series.title)} @@ -577,12 +513,14 @@ function updateSeriesTable(data) { (${progressPercent}%) ${series.episodes_with_video} - ${series.episodes_skipped || 0} + ${instanceBadge(series.instance)} - - ${updateImdbButton} + `; @@ -620,9 +558,9 @@ function refreshSeries() { loadSeries(isNaN(currentSeriesPage) ? 1 : currentSeriesPage); } -async function viewSeriesEpisodes(imdbId) { +async function viewSeriesEpisodes(imdbId, instance = 'sonarr') { try { - const data = await apiCall(`/api/series/${imdbId}/episodes`); + const data = await apiCall(`/api/series/${imdbId}/episodes?instance=${encodeURIComponent(instance)}`); showEpisodesModal(data); } catch (error) { console.error('Failed to load episodes:', error); @@ -667,66 +605,22 @@ function showEpisodesModal(data) { -
- - -
- +
- - - - - + + + + + @@ -744,7 +638,7 @@ function showEpisodesModal(data) { ``; return ` - + @@ -754,10 +648,10 @@ function showEpisodesModal(data) { @@ -837,7 +731,7 @@ function updateReportTables(data) { @@ -858,7 +752,7 @@ function updateReportTables(data) { @@ -872,36 +766,39 @@ function refreshReport() { } // Smart fix functions -async function smartFixMovie(imdbId) { +async function smartFixMovie(imdbId, instance) { + instance = instance || 'radarr'; try { - console.log('🔍 SMART FIX: Loading options for movie', imdbId); - const options = await apiCall(`/api/movies/${imdbId}/date-options`); + console.log('🔍 SMART FIX: Loading options for movie', imdbId, 'instance', instance); + const options = await apiCall(`/api/movies/${imdbId}/date-options?instance=${encodeURIComponent(instance)}`); console.log('🔍 SMART FIX: Received options:', options); - showSmartFixModal('movie', options); + showSmartFixModal('movie', options, instance); } catch (error) { console.error('Failed to load movie options:', error); showToast('Failed to load movie options', 'error'); } } -async function smartFixEpisode(imdbId, season, episode) { +async function smartFixEpisode(imdbId, season, episode, instance) { // Validate parameters if (!imdbId || season === undefined || season === null || episode === undefined || episode === null) { console.error('smartFixEpisode: Invalid parameters:', {imdbId, season, episode}); showToast('Invalid episode parameters', 'error'); return; } - + + instance = instance || 'sonarr'; try { - const options = await apiCall(`/api/episodes/${imdbId}/${season}/${episode}/date-options`); - showSmartFixModal('episode', options); + const options = await apiCall(`/api/episodes/${imdbId}/${season}/${episode}/date-options?instance=${encodeURIComponent(instance)}`); + showSmartFixModal('episode', options, instance); } catch (error) { console.error('Failed to load episode options:', error); showToast('Failed to load episode options', 'error'); } } -function showSmartFixModal(mediaType, options) { +function showSmartFixModal(mediaType, options, instance) { + instance = instance || (mediaType === 'movie' ? 'radarr' : 'sonarr'); console.log('🔍 SMART FIX: Showing modal for', mediaType, 'with options:', options); const modal = document.getElementById('smart-fix-modal'); @@ -953,7 +850,7 @@ function showSmartFixModal(mediaType, options) { optionsHtml += `
-
@@ -967,7 +864,8 @@ function closeSmartFixModal() { document.getElementById('smart-fix-modal').classList.remove('active'); } -async function applySmartFix(mediaType, options) { +async function applySmartFix(mediaType, options, instance) { + instance = instance || (mediaType === 'movie' ? 'radarr' : 'sonarr'); const selectedRadio = document.querySelector('input[name="date-option"]:checked'); if (!selectedRadio) { showToast('Please select a date option', 'warning'); @@ -1029,9 +927,9 @@ async function applySmartFix(mediaType, options) { try { if (mediaType === 'movie') { - await updateMovieDate(options.imdb_id, dateadded, source); + await updateMovieDate(options.imdb_id, dateadded, source, instance); } else { - await updateEpisodeDate(options.imdb_id, options.season, options.episode, dateadded, source); + await updateEpisodeDate(options.imdb_id, options.season, options.episode, dateadded, source, instance); } closeSmartFixModal(); } catch (error) { @@ -1118,23 +1016,25 @@ async function handleBulkUpdate(event) { } // Edit modal functions -async function editMovie(imdbId, dateadded, source) { +async function editMovie(imdbId, dateadded, source, instance) { + instance = instance || 'radarr'; try { // Load movie options to populate available dates - const options = await apiCall(`/api/movies/${imdbId}/date-options`); - showEnhancedEditModal('movie', options, dateadded, source); + const options = await apiCall(`/api/movies/${imdbId}/date-options?instance=${encodeURIComponent(instance)}`); + showEnhancedEditModal('movie', options, dateadded, source, instance); } catch (error) { console.error('Failed to load movie options for edit:', error); // Fallback to basic edit modal - showBasicEditModal('movie', imdbId, dateadded, source); + showBasicEditModal('movie', imdbId, dateadded, source, null, null, instance); } } -function showEnhancedEditModal(mediaType, options, currentDateadded, currentSource) { +function showEnhancedEditModal(mediaType, options, currentDateadded, currentSource, instance) { + instance = instance || (mediaType === 'movie' ? 'radarr' : 'sonarr'); const modal = document.getElementById('edit-modal'); const title = document.getElementById('modal-title'); const modalBody = document.querySelector('#edit-modal .modal-body'); - + if (mediaType === 'movie') { title.textContent = `Edit Movie: ${options.imdb_id}`; } else { @@ -1143,12 +1043,12 @@ function showEnhancedEditModal(mediaType, options, currentDateadded, currentSour const episode = options.episode || 0; title.textContent = `Edit Episode: ${options.imdb_id} S${season.toString().padStart(2, '0')}E${episode.toString().padStart(2, '0')}`; } - + // Build enhanced edit form with date options let formHtml = ` - + ${mediaType === 'episode' ? ` @@ -1156,21 +1056,21 @@ function showEnhancedEditModal(mediaType, options, currentDateadded, currentSour `} - +
`; - + // Add available date options options.options.forEach((option, index) => { const isSelected = option.source === currentSource ? 'checked' : ''; const optionId = `date-option-${index}`; - + formHtml += `
- +
Adjust the date/time as needed
- +
- +
- +
- `; - + modalBody.innerHTML = formHtml; - - + + // Set current values if (currentDateadded && currentDateadded !== '-') { try { @@ -1223,20 +1122,22 @@ function showEnhancedEditModal(mediaType, options, currentDateadded, currentSour document.getElementById('edit-dateadded').value = ''; } } - + document.getElementById('edit-source').value = currentSource || 'manual'; - + // Store options for later use modal.dataset.options = JSON.stringify(options); - + modal.classList.add('active'); } -function showBasicEditModal(mediaType, imdbId, dateadded, source) { +function showBasicEditModal(mediaType, imdbId, dateadded, source, season, episode, instance) { // Fallback to original basic edit modal + instance = instance || (mediaType === 'movie' ? 'radarr' : 'sonarr'); document.getElementById('modal-title').textContent = `Edit ${mediaType}: ${imdbId}`; document.getElementById('edit-imdb-id').value = imdbId; document.getElementById('edit-media-type').value = mediaType; + document.getElementById('edit-instance').value = instance; if (dateadded && dateadded !== '-') { try { @@ -1291,48 +1192,33 @@ function updateEditDateFromOption(optionIndex, option) { async function handleEnhancedEditSubmit(event) { event.preventDefault(); - console.log('🔍 Enhanced Edit Submit called'); - const modal = document.getElementById('edit-modal'); const options = JSON.parse(modal.dataset.options); const imdbId = options.imdb_id; const mediaType = document.getElementById('edit-media-type').value; + const instance = document.getElementById('edit-instance')?.value || (mediaType === 'movie' ? 'radarr' : 'sonarr'); const dateadded = document.getElementById('edit-dateadded').value; const source = document.getElementById('edit-source').value; - - console.log('🔍 Form values:', { - imdbId, - mediaType, - dateadded, - dateaddedType: typeof dateadded, - dateaddedLength: dateadded ? dateadded.length : 0, - source - }); - + if (!dateadded) { - console.log('❌ Date field is empty!'); showToast('Please enter a date', 'warning'); return; } - + // Convert datetime-local to ISO string with error handling let isoDateadded = null; try { isoDateadded = new Date(dateadded).toISOString(); - console.log('✅ Converted to ISO:', isoDateadded); } catch (e) { - console.error('❌ Date conversion error:', e); showToast('Invalid date format', 'error'); return; } - + try { if (mediaType === 'movie') { - console.log('📤 Calling updateMovieDate with:', { imdbId, isoDateadded, source }); - await updateMovieDate(imdbId, isoDateadded, source); + await updateMovieDate(imdbId, isoDateadded, source, instance); } else { - console.log('📤 Calling updateEpisodeDate with:', { imdbId, season: options.season, episode: options.episode, isoDateadded, source }); - await updateEpisodeDate(imdbId, options.season, options.episode, isoDateadded, source); + await updateEpisodeDate(imdbId, options.season, options.episode, isoDateadded, source, instance); } closeModal(); @@ -1342,22 +1228,23 @@ async function handleEnhancedEditSubmit(event) { } } -async function editEpisode(imdbId, season, episode, dateadded, source) { +async function editEpisode(imdbId, season, episode, dateadded, source, instance) { // Validate parameters if (!imdbId || season === undefined || season === null || episode === undefined || episode === null) { console.error('editEpisode: Invalid parameters:', {imdbId, season, episode}); showToast('Invalid episode parameters', 'error'); return; } - + + instance = instance || 'sonarr'; try { // Load episode options to populate available dates - const options = await apiCall(`/api/episodes/${imdbId}/${season}/${episode}/date-options`); - showEnhancedEditModal('episode', options, dateadded, source); + const options = await apiCall(`/api/episodes/${imdbId}/${season}/${episode}/date-options?instance=${encodeURIComponent(instance)}`); + showEnhancedEditModal('episode', options, dateadded, source, instance); } catch (error) { console.error('Failed to load episode options for edit:', error); // Fallback to basic edit modal - showBasicEditModal('episode', imdbId, dateadded, source, season, episode); + showBasicEditModal('episode', imdbId, dateadded, source, season, episode, instance); } } @@ -1368,36 +1255,22 @@ function closeModal() { async function handleEditSubmit(event) { event.preventDefault(); - console.log('🔍 Basic Edit Submit called (OLD HANDLER)'); - const imdbId = document.getElementById('edit-imdb-id').value; const mediaType = document.getElementById('edit-media-type').value; + const instance = document.getElementById('edit-instance')?.value || (mediaType === 'movie' ? 'radarr' : 'sonarr'); const season = document.getElementById('edit-season').value; const episode = document.getElementById('edit-episode').value; const dateadded = document.getElementById('edit-dateadded').value; const source = document.getElementById('edit-source').value; - console.log('🔍 OLD Form values:', { - imdbId, - mediaType, - dateadded, - dateaddedType: typeof dateadded, - dateaddedLength: dateadded ? dateadded.length : 0, - source - }); - // Convert datetime-local to ISO string const isoDateadded = dateadded ? new Date(dateadded).toISOString() : null; - console.log('🔍 OLD isoDateadded:', isoDateadded); - try { if (mediaType === 'movie') { - console.log('📤 OLD calling updateMovieDate with:', { imdbId, isoDateadded, source }); - await updateMovieDate(imdbId, isoDateadded, source); + await updateMovieDate(imdbId, isoDateadded, source, instance); } else { - console.log('📤 OLD calling updateEpisodeDate'); - await updateEpisodeDate(imdbId, parseInt(season), parseInt(episode), isoDateadded, source); + await updateEpisodeDate(imdbId, parseInt(season), parseInt(episode), isoDateadded, source, instance); } closeModal(); @@ -1407,49 +1280,39 @@ async function handleEditSubmit(event) { } // Update functions -async function updateMovieDate(imdbId, dateadded, source) { - console.log('🔍 updateMovieDate called with:', { - imdbId, - dateadded, - dateaddedType: typeof dateadded, - dateaddedValue: dateadded, - source - }); - +async function updateMovieDate(imdbId, dateadded, source, instance) { + instance = instance || 'radarr'; try { - const payload = { - dateadded: dateadded, - source: source - }; - - console.log('📤 Sending API request with payload:', JSON.stringify(payload)); - const result = await apiCall(`/api/movies/${imdbId}`, { method: 'PUT', - body: JSON.stringify(payload) + body: JSON.stringify({ + dateadded: dateadded, + source: source, + instance: instance + }) }); - - console.log('✅ API response:', result); - + showToast(result.message, 'success'); - + // Refresh current view if (currentTab === 'movies') loadMovies(currentMoviesPage); if (currentTab === 'reports') loadReport(); if (currentTab === 'dashboard') loadDashboard(); - + } catch (error) { console.error('Movie update failed:', error); } } -async function updateEpisodeDate(imdbId, season, episode, dateadded, source) { +async function updateEpisodeDate(imdbId, season, episode, dateadded, source, instance) { + instance = instance || 'sonarr'; try { const result = await apiCall(`/api/episodes/${imdbId}/${season}/${episode}`, { method: 'PUT', body: JSON.stringify({ dateadded: dateadded, - source: source + source: source, + instance: instance }) }); @@ -1464,7 +1327,7 @@ async function updateEpisodeDate(imdbId, season, episode, dateadded, source) { const episodesModal = document.getElementById('episodes-modal'); if (episodesModal) { closeEpisodesModal(); - setTimeout(() => viewSeriesEpisodes(imdbId), 100); + setTimeout(() => viewSeriesEpisodes(imdbId, instance), 100); } } catch (error) { @@ -1528,9 +1391,9 @@ function showToast(message, type = 'info') { } // Debug function -async function debugMovie(imdbId) { +async function debugMovie(imdbId, instance = 'radarr') { try { - const data = await apiCall(`/api/debug/movie/${imdbId}/raw`); + const data = await apiCall(`/api/debug/movie/${imdbId}/raw?instance=${encodeURIComponent(instance)}`); const debugInfo = ` DEBUG INFO for ${imdbId}: @@ -1560,23 +1423,23 @@ Analysis: } // Episode deletion functionality -async function deleteEpisode(imdbId, season, episode) { +async function deleteEpisode(imdbId, season, episode, instance = 'sonarr') { // Validate parameters if (!imdbId || season === undefined || season === null || episode === undefined || episode === null) { console.error('deleteEpisode: Invalid parameters:', {imdbId, season, episode}); showToast('Invalid episode parameters', 'error'); return; } - + const episodeStr = `S${season.toString().padStart(2, '0')}E${episode.toString().padStart(2, '0')}`; - + // Confirmation dialog if (!confirm(`⚠️ Delete Episode ${episodeStr}?\n\nThis will permanently remove the episode from the database.\n\nAre you sure you want to continue?`)) { return; } - + try { - const response = await fetch(`/api/episodes/${imdbId}/${season}/${episode}`, { + const response = await fetch(`/api/episodes/${imdbId}/${season}/${episode}?instance=${encodeURIComponent(instance)}`, { method: 'DELETE', headers: { 'Content-Type': 'application/json' @@ -1612,14 +1475,14 @@ async function deleteEpisode(imdbId, season, episode) { } // Movie deletion functionality -async function deleteMovie(imdbId) { +async function deleteMovie(imdbId, instance = 'radarr') { // Confirmation dialog if (!confirm(`⚠️ Delete Movie?\n\nThis will permanently remove the movie (${imdbId}) from the database.\n\nAre you sure you want to continue?`)) { return; } - + try { - const response = await fetch(`/api/movies/${imdbId}`, { + const response = await fetch(`/api/movies/${imdbId}?instance=${encodeURIComponent(instance)}`, { method: 'DELETE', headers: { 'Content-Type': 'application/json' @@ -1645,89 +1508,30 @@ async function deleteMovie(imdbId) { } } -async function updateMovieImdbId(oldImdbId) { - // Prompt for new IMDb ID - const newImdbId = prompt(`Update IMDb ID\n\nCurrent: ${oldImdbId}\n\nEnter the correct IMDb ID (with or without 'tt' prefix):`); - - if (!newImdbId || newImdbId.trim() === '') { - return; - } - - const cleanImdbId = newImdbId.trim(); - - // Confirmation - if (!confirm(`Update IMDb ID?\n\nOld: ${oldImdbId}\nNew: ${cleanImdbId}\n\nThis will migrate the movie record to the new IMDb ID. Continue?`)) { - return; - } - - try { - const response = await fetch(`/api/movies/${oldImdbId}/migrate-imdb`, { - method: 'POST', - headers: { - 'Content-Type': 'application/json' - }, - body: JSON.stringify({ new_imdb_id: cleanImdbId }) - }); - - const result = await response.json(); - - if (response.ok && result.success) { - showToast(`✅ IMDb ID updated successfully to ${result.new_imdb_id}`, 'success'); - - // Refresh the movies table - loadMovies(currentMoviesPage); - - } else { - const errorMsg = result.message || result.detail || 'Unknown error'; - showToast(`❌ Failed to update IMDb ID: ${errorMsg}`, 'error'); - } - - } catch (error) { - console.error('Update IMDb ID failed:', error); - showToast(`❌ Update failed: ${error.message}`, 'error'); - } -} - -async function updateSeriesImdbId(oldImdbId) { - // Prompt for new IMDb ID - const newImdbId = prompt(`Update Series IMDb ID\n\nCurrent: ${oldImdbId}\n\nEnter the correct IMDb ID (with or without 'tt' prefix):`); - - if (!newImdbId || newImdbId.trim() === '') { - return; - } - - const cleanImdbId = newImdbId.trim(); - - // Confirmation - if (!confirm(`Update Series IMDb ID?\n\nOld: ${oldImdbId}\nNew: ${cleanImdbId}\n\nThis will migrate the series and ALL its episodes to the new IMDb ID. Continue?`)) { +async function deleteSeries(imdbId, instance, title) { + if (!confirm(`⚠️ Delete Series?\n\n"${title}"\n\nThis will permanently remove the series and ALL its episodes from the database.\n\nAre you sure you want to continue?`)) { return; } try { - const response = await fetch(`/api/series/${oldImdbId}/migrate-imdb`, { - method: 'POST', - headers: { - 'Content-Type': 'application/json' - }, - body: JSON.stringify({ new_imdb_id: cleanImdbId }) + const response = await fetch(`/api/series/${imdbId}?instance=${encodeURIComponent(instance)}`, { + method: 'DELETE', + headers: { 'Content-Type': 'application/json' } }); const result = await response.json(); if (response.ok && result.success) { - showToast(`✅ Series IMDb ID updated successfully to ${result.new_imdb_id}`, 'success'); - - // Refresh the series table + showToast(`✅ Series deleted (${result.episodes_deleted} episode(s) removed)`, 'success'); loadSeries(currentSeriesPage); - } else { - const errorMsg = result.message || result.detail || 'Unknown error'; - showToast(`❌ Failed to update IMDb ID: ${errorMsg}`, 'error'); + const errorMsg = result.message || result.detail || result.error || 'Unknown error'; + showToast(`❌ Failed to delete series: ${errorMsg}`, 'error'); } } catch (error) { - console.error('Update series IMDb ID failed:', error); - showToast(`❌ Update failed: ${error.message}`, 'error'); + console.error('Delete series failed:', error); + showToast(`❌ Delete failed: ${error.message}`, 'error'); } } @@ -1950,342 +1754,25 @@ function updateScanProgress(status) { } } -// Manual Cleanup Functions -async function handleManualCleanup(event) { - event.preventDefault(); - - const checkMovies = document.getElementById('cleanup-movies').checked; - const checkSeries = document.getElementById('cleanup-series').checked; - const checkFilesystem = document.getElementById('cleanup-filesystem').checked; - const checkDatabase = document.getElementById('cleanup-database').checked; - const dryRun = document.getElementById('cleanup-dry-run').checked; - - // Validate at least one media type is selected - if (!checkMovies && !checkSeries) { - showToast('❌ Please select at least one media type to check', 'error'); - return; - } - - // Validate at least one validation method is selected - if (!checkFilesystem && !checkDatabase) { - showToast('❌ Please select at least one validation method', 'error'); +async function logout() { + if (!confirm('Are you sure you want to logout?')) { return; } - + try { - // Show cleanup status - showCleanupStatus(); - - // Start the cleanup - const mode = dryRun ? 'Preview' : 'Cleanup'; - showToast(`🧹 Starting ${mode.toLowerCase()}...`, 'info'); - - const response = await fetch('/manual/cleanup-orphaned', { + const response = await fetch('/api/auth/logout', { method: 'POST', - headers: { 'Content-Type': 'application/json' }, - credentials: 'include', - body: JSON.stringify({ - check_movies: checkMovies, - check_series: checkSeries, - check_filesystem: checkFilesystem, - check_database: checkDatabase, - dry_run: dryRun - }) + credentials: 'same-origin' }); - - if (!response.ok) { - throw new Error(`HTTP ${response.status}: ${response.statusText}`); - } - - const result = await response.json(); - - if (result.success) { - showToast(`✅ ${mode} completed successfully`, 'success'); - displayCleanupResults(result.report, dryRun); + + if (response.ok) { + showToast('✅ Logged out successfully', 'success'); + // Reload page to trigger authentication prompt + setTimeout(() => { + window.location.reload(); + }, 1500); } else { - showToast(`❌ ${mode} failed: ${result.message || 'Unknown error'}`, 'error'); - hideCleanupStatus(); - } - - } catch (error) { - console.error('Manual cleanup failed:', error); - showToast(`❌ Cleanup failed: ${error.message}`, 'error'); - hideCleanupStatus(); - } -} - -function showCleanupStatus() { - const cleanupStatus = document.getElementById('cleanup-status'); - const cleanupResults = document.getElementById('cleanup-results'); - - // Reset and show - cleanupResults.innerHTML = '

Running cleanup...

'; - cleanupStatus.style.display = 'block'; -} - -function hideCleanupStatus() { - document.getElementById('cleanup-status').style.display = 'none'; -} - -function displayCleanupResults(report, dryRun) { - const cleanupResults = document.getElementById('cleanup-results'); - const accentColor = dryRun ? 'var(--warning-color,#d69e2e)' : 'var(--danger,#e53e3e)'; - - function statRow(label, value, highlight) { - const style = highlight ? `font-weight:700;color:${accentColor}` : 'color:var(--text-muted,#718096)'; - return `
- ${label}${value} -
`; - } - - // titles = removed_titles array from backend - function itemList(titles, label) { - if (!titles || titles.length === 0) return ''; - return `
- - ${label} (${titles.length}) - -
    - ${titles.map(t => `
  • ${escapeHtml(t)}
    • `).join('')} -
-
`; - } - - const moviesRemoved = report.movies?.removed || 0; - const seriesRemoved = report.series?.removed || 0; - const episodesRemoved = report.series?.removed_episodes || 0; - - let html = `
-
- - ${dryRun ? 'Preview Results' : 'Cleanup Results'} -
`; - - if (report.movies) { - html += `
-
- Movies -
- ${statRow('Orphaned found', report.movies.orphaned || 0)} - ${statRow(dryRun ? 'Would be removed' : 'Removed', moviesRemoved, moviesRemoved > 0)} - ${itemList(report.movies.removed_titles, dryRun ? 'View movies to remove' : 'View removed movies')} -
`; - } - - if (report.series) { - html += `
-
- TV Series -
- ${statRow('Orphaned found', report.series.orphaned || 0)} - ${statRow(dryRun ? 'Series would be removed' : 'Series removed', seriesRemoved, seriesRemoved > 0)} - ${episodesRemoved > 0 ? statRow(dryRun ? 'Episodes would be removed' : 'Episodes removed', episodesRemoved, true) : ''} - ${itemList(report.series.removed_titles, dryRun ? 'View series to remove' : 'View removed series')} -
`; - } - - const totalItems = moviesRemoved + seriesRemoved; - const summaryParts = []; - if (moviesRemoved > 0) summaryParts.push(`${moviesRemoved} movie${moviesRemoved !== 1 ? 's' : ''}`); - if (seriesRemoved > 0) summaryParts.push(`${seriesRemoved} series`); - if (episodesRemoved > 0) summaryParts.push(`${episodesRemoved} episode${episodesRemoved !== 1 ? 's' : ''}`); - const summaryText = summaryParts.length ? summaryParts.join(', ') : 'nothing'; - - html += `
- ${dryRun ? 'Would remove' : 'Removed'}: - ${summaryText} -
`; - - if (dryRun && totalItems > 0) { - html += `
- Dry run — no changes made. Uncheck Dry Run to apply. -
`; - } else if (!dryRun && totalItems === 0) { - html += `
- Nothing to remove — database is clean. -
`; - } - - html += `
`; - cleanupResults.innerHTML = html; -} - -// ── Library Sync ───────────────────────────────────────────────────────────── - -async function handleLibrarySync(event) { - event.preventDefault(); - const mediaType = document.getElementById('sync-media-type').value; - const dryRun = document.getElementById('sync-dry-run').checked; - const removeImmediately = !dryRun && (document.getElementById('sync-remove-immediately')?.checked || false); - - if (!dryRun && !confirm( - removeImmediately - ? 'This will permanently delete items from Chronarr that are no longer in Radarr/Sonarr. Continue?' - : 'This will mark items missing from Radarr/Sonarr (they will be auto-purged after your configured grace period). Continue?' - )) return; - - const statusEl = document.getElementById('sync-status'); - const resultsEl = document.getElementById('sync-results'); - statusEl.style.display = 'block'; - resultsEl.innerHTML = '

Running sync check…

'; - - try { - const response = await fetch('/api/cleanup/library-sync', { - method: 'POST', - headers: { 'Content-Type': 'application/json' }, - body: JSON.stringify({ media_type: mediaType, dry_run: dryRun, remove_immediately: removeImmediately }) - }); - if (!response.ok) { - const err = await response.json().catch(() => ({ detail: response.statusText })); - throw new Error(err.detail || 'Request failed'); - } - const data = await response.json(); - renderSyncResults(data, dryRun); - } catch (err) { - resultsEl.innerHTML = `

Error: ${err.message}

`; - } -} - -function renderSyncResults(data, dryRun) { - const resultsEl = document.getElementById('sync-results'); - const movies = data.movies_not_in_radarr || []; - const series = data.series_not_in_sonarr || []; - - let html = `
`; - - if (!data.radarr_available && !data.sonarr_available) { - html += `

Neither Radarr nor Sonarr DB is available. Check your DB connection settings.

`; - html += `
`; - resultsEl.innerHTML = html; - return; - } - - if (dryRun) { - html += `
- Dry run — no changes made. Uncheck "Dry Run" to apply. -
`; - } - - // Movies - if (data.radarr_available) { - html += `
- Movies not in Radarr: ${movies.length}`; - if (movies.length) { - html += `
    `; - movies.forEach(m => { - const since = m.missing_since ? ` (missing since ${new Date(m.missing_since).toLocaleDateString()})` : ''; - html += `
  • ${escapeHtml(m.title || m.imdb_id)}${since}
    • `; - }); - html += `
`; - } - html += `
`; - } else { - html += `

Radarr DB not available — skipped movies.

`; - } - - // Series - if (data.sonarr_available) { - html += `
- Series not in Sonarr: ${series.length}`; - if (series.length) { - html += `
    `; - series.forEach(s => { - const since = s.missing_since ? ` (missing since ${new Date(s.missing_since).toLocaleDateString()})` : ''; - html += `
  • ${escapeHtml(s.title || s.imdb_id)}${since}
    • `; - }); - html += `
`; - } - html += `
`; - } else { - html += `

Sonarr DB not available — skipped series.

`; - } - - // Deletion summary - if (!dryRun) { - const deleted = (data.movies_deleted || 0) + (data.series_deleted || 0); - if (deleted > 0) { - html += `
- Deleted ${data.movies_deleted || 0} movie(s) and ${data.series_deleted || 0} series from Chronarr. -
`; - } else if (movies.length || series.length) { - html += `
- Items marked as missing from source. They will be auto-purged after your configured grace period. -
`; - } - } - - if (movies.length === 0 && series.length === 0 && (data.radarr_available || data.sonarr_available)) { - html += `

Chronarr is in sync — no items to remove.

`; - } - - html += `
`; - resultsEl.innerHTML = html; -} - -function hideSyncStatus() { - document.getElementById('sync-status').style.display = 'none'; -} - -async function loadSyncSettings() { - try { - const res = await fetch('/api/settings/library-sync'); - if (!res.ok) return; - const s = await res.json(); - const movieEl = document.getElementById('sync-purge-movies-days'); - const tvEl = document.getElementById('sync-purge-tv-days'); - if (movieEl) movieEl.value = s.purge_missing_movies_days ?? 0; - if (tvEl) tvEl.value = s.purge_missing_tv_days ?? 0; - } catch (_) {} -} - -async function saveSyncSettings() { - const movieDays = parseInt(document.getElementById('sync-purge-movies-days')?.value || '0', 10); - const tvDays = parseInt(document.getElementById('sync-purge-tv-days')?.value || '0', 10); - const statusEl = document.getElementById('sync-settings-status'); - - try { - const res = await fetch('/api/settings/library-sync', { - method: 'PUT', - headers: { 'Content-Type': 'application/json' }, - body: JSON.stringify({ purge_missing_movies_days: movieDays, purge_missing_tv_days: tvDays }) - }); - if (!res.ok) throw new Error('Save failed'); - if (statusEl) { - statusEl.style.color = 'var(--success)'; - statusEl.textContent = movieDays === 0 && tvDays === 0 - ? '✓ Auto-purge disabled' - : `✓ Saved — movies: ${movieDays === 0 ? 'never' : movieDays + 'd'}, TV: ${tvDays === 0 ? 'never' : tvDays + 'd'}`; - setTimeout(() => { statusEl.textContent = ''; }, 4000); - } - } catch (err) { - if (statusEl) { - statusEl.style.color = 'var(--danger)'; - statusEl.textContent = '✗ Failed to save settings'; - } - } -} - -// ── End Library Sync ────────────────────────────────────────────────────────── - -async function logout() { - if (!confirm('Are you sure you want to logout?')) { - return; - } - - try { - const response = await fetch('/api/auth/logout', { - method: 'POST', - credentials: 'same-origin' - }); - - if (response.ok) { - showToast('✅ Logged out successfully', 'success'); - // Reload page to trigger authentication prompt - setTimeout(() => { - window.location.reload(); - }, 1500); - } else { - showToast('❌ Logout failed', 'error'); + showToast('❌ Logout failed', 'error'); } } catch (error) { @@ -2312,26 +1799,16 @@ function updateBulkDeleteButton() { const selectedCheckboxes = document.querySelectorAll('.episode-checkbox:checked'); const selectedCount = selectedCheckboxes.length; const bulkDeleteButton = document.getElementById('bulk-delete-selected'); - const bulkUpdateButton = document.getElementById('bulk-update-dates'); const selectedCountSpan = document.getElementById('selected-count'); - const updateCountSpan = document.getElementById('update-count'); - + if (selectedCountSpan) { selectedCountSpan.textContent = selectedCount; } - - if (updateCountSpan) { - updateCountSpan.textContent = selectedCount; - } - + if (bulkDeleteButton) { bulkDeleteButton.disabled = selectedCount === 0; } - - if (bulkUpdateButton) { - bulkUpdateButton.disabled = selectedCount === 0; - } - + // Update select all checkbox state const selectAllCheckbox = document.getElementById('select-all-checkbox'); const allCheckboxes = document.querySelectorAll('.episode-checkbox'); @@ -2368,9 +1845,10 @@ async function bulkDeleteSelected() { const imdbId = row.getAttribute('data-imdb'); const season = parseInt(row.getAttribute('data-season')); const episode = parseInt(row.getAttribute('data-episode')); - + const instance = row.getAttribute('data-instance') || 'sonarr'; + try { - const response = await apiCall(`/api/episodes/${imdbId}/${season}/${episode}`, { + const response = await apiCall(`/api/episodes/${imdbId}/${season}/${episode}?instance=${encodeURIComponent(instance)}`, { method: 'DELETE' }); @@ -2391,11 +1869,11 @@ async function bulkDeleteSelected() { // Update UI updateEpisodeModalCounts(); updateBulkDeleteButton(); - + // Reset button bulkDeleteButton.innerHTML = originalText; bulkDeleteButton.disabled = true; - + // Show results if (successCount > 0 && failCount === 0) { showToast(`✅ Successfully deleted ${successCount} episode(s)`, 'success'); @@ -2406,439 +1884,486 @@ async function bulkDeleteSelected() { } } -// Bulk update dates functions -function showBulkUpdateModal() { - const selectedCheckboxes = document.querySelectorAll('.episode-checkbox:checked'); - const selectedCount = selectedCheckboxes.length; +// --------------------------- +// Database Population Functions +// --------------------------- - if (selectedCount === 0) { - showToast('❌ No episodes selected', 'error'); - return; - } +// Fills the Instance dropdown on the Populate Database card from the same +// /api/instances data the sidebar already uses — "All Instances" plus one +// entry per configured Radarr/Sonarr instance, grouped by type so it's +// obvious which is which once there's more than a couple. +async function loadPopulateInstanceOptions() { + const select = document.getElementById('populate-instance'); + if (!select) return; - const modal = document.getElementById('bulk-update-modal'); - const modalSelectedCount = document.getElementById('modal-selected-count'); - const dateSourceSelect = document.getElementById('bulk-date-source'); - const customDateInput = document.getElementById('custom-date-input'); + try { + const data = await apiCall('/api/instances'); + const radarrNames = (data.radarr || []).map(i => i.name); + const sonarrNames = (data.sonarr || []).map(i => i.name); + + // Keep "All Instances", drop everything else and rebuild — this + // gets called every time the Tools tab is opened, so it has to be + // safe to run repeatedly without piling up duplicate options. + select.innerHTML = ''; + + if (radarrNames.length) { + const group = document.createElement('optgroup'); + group.label = 'Radarr'; + radarrNames.forEach(name => { + const opt = document.createElement('option'); + opt.value = name; + opt.textContent = name; + opt.dataset.mediaType = 'movies'; + group.appendChild(opt); + }); + select.appendChild(group); + } - if (modalSelectedCount) { - modalSelectedCount.textContent = selectedCount; - } + if (sonarrNames.length) { + const group = document.createElement('optgroup'); + group.label = 'Sonarr'; + sonarrNames.forEach(name => { + const opt = document.createElement('option'); + opt.value = name; + opt.textContent = name; + opt.dataset.mediaType = 'tv'; + group.appendChild(opt); + }); + select.appendChild(group); + } - // Show/hide custom date input based on selection - if (dateSourceSelect) { - dateSourceSelect.onchange = function() { - if (customDateInput) { - customDateInput.style.display = this.value === 'custom' ? 'block' : 'none'; - } - }; + // Reset in case the last selection here no longer exists (e.g. an + // instance was deleted since this was last loaded). + syncPopulateMediaTypeToInstance(); + } catch (error) { + console.error('Failed to load instances for populate dropdown:', error); + // Leave just "All Instances" — populate still works, just without + // the ability to target a single instance until this loads. } +} - if (modal) { - modal.style.display = 'flex'; +function syncPopulateMediaTypeToInstance() { + const instanceSelect = document.getElementById('populate-instance'); + const mediaTypeSelect = document.getElementById('populate-media-type'); + if (!instanceSelect || !mediaTypeSelect) return; + + const selectedOption = instanceSelect.options[instanceSelect.selectedIndex]; + const mediaType = selectedOption ? selectedOption.dataset.mediaType : null; + + if (instanceSelect.value !== 'all' && mediaType) { + // A specific instance can only ever be one media type — a Radarr + // instance is movies, a Sonarr instance is TV. Lock the Media Type + // dropdown to match instead of making the user keep the two in sync + // by hand (picking the wrong one used to silently populate nothing). + mediaTypeSelect.value = mediaType; + mediaTypeSelect.disabled = true; + } else { + mediaTypeSelect.disabled = false; } } -function closeBulkUpdateModal() { - const modal = document.getElementById('bulk-update-modal'); - if (modal) { - modal.style.display = 'none'; - } +// --- Log Files (Tools tab) --- +let logTailAutoRefreshTimer = null; + +function formatBytes(bytes) { + if (!bytes) return '0 B'; + const units = ['B', 'KB', 'MB', 'GB']; + const i = Math.min(units.length - 1, Math.floor(Math.log(bytes) / Math.log(1024))); + return `${(bytes / Math.pow(1024, i)).toFixed(i === 0 ? 0 : 1)} ${units[i]}`; } -async function executeBulkUpdate() { - const selectedCheckboxes = document.querySelectorAll('.episode-checkbox:checked'); - const selectedCount = selectedCheckboxes.length; - const dateSource = document.getElementById('bulk-date-source').value; - const customDate = document.getElementById('bulk-custom-date').value; +async function loadLogFiles() { + const listEl = document.getElementById('log-files-list'); + const fileSelect = document.getElementById('log-tail-file'); + if (!listEl || !fileSelect) return; - if (selectedCount === 0) { - showToast('❌ No episodes selected', 'error'); - return; + try { + const data = await apiCall('/api/logs'); + const files = data.files || []; + + if (files.length === 0) { + listEl.innerHTML = '

No log files found.

'; + fileSelect.innerHTML = ''; + return; + } + + listEl.innerHTML = ` +
- Episode - - Aired - - Date Added - - Source - - Video - EpisodeAiredDate AddedSourceVideo Actions
${dateadded}
${episode.source_description || episode.source || 'Unknown'} ${hasVideoBadge} - - ${movie.released || '-'} ${movie.source_description || movie.source || 'Unknown'} - ${episode.aired || '-'} ${episode.source_description || episode.source || 'Unknown'} -
+ + + + + ${files.map(f => ` + + + + + + + `).join('')} + +
FileSizeModifiedActions
${escapeHtml(f.filename)}${f.is_current ? ' current' : ''}${formatBytes(f.size_bytes)}${formatDateTime(f.modified_at)} + + Download + +
+ `; + + // Preserve the current tail-file selection across refreshes (this is + // called every time the Tools tab is opened) if it still exists. + const previousSelection = fileSelect.value; + fileSelect.innerHTML = files.map(f => + `` + ).join(''); + if (files.some(f => f.filename === previousSelection)) { + fileSelect.value = previousSelection; + } + } catch (error) { + listEl.innerHTML = '

Failed to load log files.

'; } +} - if (dateSource === 'custom' && !customDate) { - showToast('❌ Please enter a custom date', 'error'); - return; +async function refreshLogTail() { + const fileSelect = document.getElementById('log-tail-file'); + const linesSelect = document.getElementById('log-tail-lines'); + const output = document.getElementById('log-tail-output'); + if (!fileSelect || !fileSelect.value || !output) return; + + // Only follow to the bottom if the viewer was already there (or close to + // it) before this refresh. Otherwise every 5s auto-refresh yanks anyone + // who scrolled up to read older lines straight back down again. + const nearBottomTolerancePx = 24; + const wasNearBottom = output.scrollHeight - output.clientHeight - output.scrollTop <= nearBottomTolerancePx; + + try { + const data = await apiCall(`/api/logs/${encodeURIComponent(fileSelect.value)}/tail?lines=${linesSelect.value}`); + output.textContent = (data.lines || []).join('\n') || '(empty)'; + if (wasNearBottom) { + output.scrollTop = output.scrollHeight; + } + } catch (error) { + output.textContent = 'Failed to load log tail.'; } +} - // Close modal - closeBulkUpdateModal(); +function stopLogTailAutoRefresh() { + if (logTailAutoRefreshTimer) { + clearInterval(logTailAutoRefreshTimer); + logTailAutoRefreshTimer = null; + } + const checkbox = document.getElementById('log-tail-auto-refresh'); + if (checkbox) checkbox.checked = false; +} - // Collect selected episodes - const episodes = []; - selectedCheckboxes.forEach(checkbox => { - const row = checkbox.closest('tr'); - episodes.push({ - imdb_id: row.getAttribute('data-imdb'), - season: parseInt(row.getAttribute('data-season')), - episode: parseInt(row.getAttribute('data-episode')) - }); - }); +function toggleLogTailAutoRefresh() { + const checkbox = document.getElementById('log-tail-auto-refresh'); + if (logTailAutoRefreshTimer) { + clearInterval(logTailAutoRefreshTimer); + logTailAutoRefreshTimer = null; + } + if (checkbox && checkbox.checked) { + refreshLogTail(); + logTailAutoRefreshTimer = setInterval(refreshLogTail, 5000); + } +} - // Show progress - showToast(`⏳ Updating ${selectedCount} episode(s)...`, 'info'); +// --- Unresolved Lookups (Tools tab) --- - try { - const response = await apiCall('/api/episodes/bulk-update-dates', { - method: 'POST', - headers: { - 'Content-Type': 'application/json' - }, - body: JSON.stringify({ - episodes: episodes, - date_source: dateSource, - custom_date: customDate || null - }) - }); +const UNRESOLVED_REASON_LABELS = { + no_db_record: 'No DB record', + no_resolved_date: 'In DB, no date yet' +}; - if (response.success) { - showToast(`✅ Successfully updated ${response.updated || selectedCount} episode(s)`, 'success'); +async function loadUnresolvedLookups() { + const listEl = document.getElementById('unresolved-lookups-list'); + const showDismissed = document.getElementById('unresolved-show-dismissed'); + if (!listEl) return; - // Reload the current series to show updated dates - const currentImdbId = currentTVSeries; - if (currentImdbId) { - loadEpisodes(currentImdbId); - } + try { + const includeDismissed = showDismissed && showDismissed.checked; + const data = await apiCall(`/api/unresolved-lookups?include_dismissed=${includeDismissed ? 'true' : 'false'}`); + const lookups = data.lookups || []; - // Clear selections - selectedCheckboxes.forEach(checkbox => checkbox.checked = false); - updateBulkDeleteButton(); - } else { - showToast(`❌ ${response.message || 'Failed to update episodes'}`, 'error'); + if (lookups.length === 0) { + listEl.innerHTML = '

Nothing unresolved right now.

'; + return; } + + listEl.innerHTML = ` + + + + + + + + + + + + + + + ${lookups.map(l => { + const isEpisode = l.media_type === 'episode'; + const episodeTag = isEpisode ? ` S${String(l.season).padStart(2, '0')}E${String(l.episode).padStart(2, '0')}` : ''; + return ` + + + + + + + + + + + `; + }).join('')} + +
TypeTitleIMDb IDReasonInstanceMissesLast SeenActions
${isEpisode ? 'Episode' : 'Movie'}${l.title ? escapeHtml(l.title) + episodeTag : 'unknown'}${escapeHtml(l.imdb_id)}${escapeHtml(UNRESOLVED_REASON_LABELS[l.reason] || l.reason)}${escapeHtml(l.instance || '')}${l.miss_count}${formatDateTime(l.last_seen)} + ${l.dismissed + ? 'dismissed' + : `` + } +
+ `; } catch (error) { - console.error('Bulk update error:', error); - showToast('❌ Error updating episodes', 'error'); + listEl.innerHTML = '

Failed to load unresolved lookups.

'; } } -// ==================== Database Population Functions ==================== +async function dismissUnresolvedLookup(id) { + try { + await apiCall(`/api/unresolved-lookups/${id}/dismiss`, { method: 'POST' }); + loadUnresolvedLookups(); + } catch (error) { + // apiCall already surfaces a toast on failure + } +} -let populatePollingInterval = null; +async function dismissAllUnresolvedLookups() { + if (!confirm('Dismiss every unresolved lookup currently shown? Any that miss again later will resurface.')) { + return; + } + try { + const result = await apiCall('/api/unresolved-lookups/dismiss-all', { method: 'POST' }); + showToast(`✅ Dismissed ${result.dismissed_count || 0} lookups`, 'success'); + loadUnresolvedLookups(); + } catch (error) { + // apiCall already surfaces a toast on failure + } +} async function handlePopulateDatabase(event) { event.preventDefault(); const mediaType = document.getElementById('populate-media-type').value; - const submitButton = event.target.querySelector('button[type="submit"]'); - const originalText = submitButton.innerHTML; + const instanceSelect = document.getElementById('populate-instance'); + const instance = instanceSelect ? instanceSelect.value : 'all'; - // Confirm action - const confirmMsg = mediaType === 'both' - ? 'This will populate the database with ALL movies and TV episodes from Radarr/Sonarr. Continue?' - : mediaType === 'movies' - ? 'This will populate the database with ALL movies from Radarr. Continue?' - : 'This will populate the database with ALL TV episodes from Sonarr. Continue?'; + // Validate input + if (!mediaType) { + showToast('❌ Please select media type', 'error'); + return; + } + // Confirm with user + const target = instance !== 'all' ? `instance '${instance}'` : `${mediaType}`; + const confirmMsg = `Are you sure you want to populate the database with ${target}? This will query Radarr/Sonarr and may take several minutes.`; if (!confirm(confirmMsg)) { return; } - // Disable button and show loading - submitButton.disabled = true; - submitButton.innerHTML = ' Starting...'; - try { - const response = await fetch('/admin/populate-database', { + // Show populate status + showPopulateStatus(); + + // Start the population + showToast('🚀 Starting database population...', 'info'); + const response = await fetch(`/admin/populate-database?media_type=${mediaType}&instance=${encodeURIComponent(instance)}`, { method: 'POST', - headers: { - 'Content-Type': 'application/json', - }, - body: JSON.stringify({ media_type: mediaType }) + credentials: 'include' }); if (!response.ok) { - throw new Error(`HTTP error! status: ${response.status}`); + throw new Error(`HTTP ${response.status}: ${response.statusText}`); } - const data = await response.json(); + const result = await response.json(); - if (data.status === 'started') { - showPopulateStatus(); + if (result.status === 'started') { + showToast('✅ Population started successfully', 'success'); + // Start polling for status startPopulatePolling(); } else { - throw new Error('Failed to start population'); + showToast(`ℹ️ ${result.message || 'Population completed'}`, 'info'); + hidePopulateStatus(); } } catch (error) { - console.error('Error starting population:', error); - showToast('❌ Failed to start database population', 'error'); - submitButton.disabled = false; - submitButton.innerHTML = originalText; + console.error('Database population failed:', error); + showToast(`❌ Population failed: ${error.message}`, 'error'); + hidePopulateStatus(); } } function showPopulateStatus() { - const statusDiv = document.getElementById('populate-status'); - const resultsDiv = document.getElementById('populate-results'); + const populateStatus = document.getElementById('populate-status'); const progressBar = document.getElementById('populate-progress-bar'); + const operationText = document.getElementById('populate-current-operation'); const progressText = document.getElementById('populate-progress-text'); + const resultsDiv = document.getElementById('populate-results'); - if (statusDiv) { - statusDiv.style.display = 'block'; - } - - if (progressBar) { - progressBar.style.width = '0%'; - } - - if (progressText) { - progressText.textContent = 'Starting...'; - } - - if (resultsDiv) { - resultsDiv.style.display = 'none'; - } + populateStatus.style.display = 'block'; + progressBar.style.width = '0%'; + operationText.textContent = 'Initializing...'; + progressText.textContent = '0%'; + resultsDiv.innerHTML = ''; } function hidePopulateStatus() { - const statusDiv = document.getElementById('populate-status'); - if (statusDiv) { - statusDiv.style.display = 'none'; + const populateStatus = document.getElementById('populate-status'); + if (populateStatus) { + populateStatus.style.display = 'none'; } } function startPopulatePolling() { - // Clear any existing interval - if (populatePollingInterval) { - clearInterval(populatePollingInterval); - } - - // Poll every 2 seconds - populatePollingInterval = setInterval(async () => { + // Poll every 2 seconds for populate status + window.populatePollingInterval = setInterval(async () => { try { const response = await fetch('/api/populate/status'); if (!response.ok) { - throw new Error(`HTTP error! status: ${response.status}`); + throw new Error('Failed to get populate status'); } const status = await response.json(); updatePopulateProgress(status); - // Stop polling if complete or error (API returns "completed": true/false and "error": string) - if (status.completed || status.error) { + // Stop polling if population is complete + if (!status.running && status.completed) { stopPopulatePolling(); - - // Re-enable submit button - const submitButton = document.querySelector('#populate-form button[type="submit"]'); - if (submitButton) { - submitButton.disabled = false; - submitButton.innerHTML = ' Start Population'; - } + showToast('✅ Database population completed!', 'success'); } } catch (error) { - console.error('Error polling populate status:', error); + console.error('Failed to poll populate status:', error); + // Don't show error toast repeatedly, just stop polling stopPopulatePolling(); - - // Re-enable submit button - const submitButton = document.querySelector('#populate-form button[type="submit"]'); - if (submitButton) { - submitButton.disabled = false; - submitButton.innerHTML = ' Start Population'; - } } }, 2000); } function stopPopulatePolling() { - if (populatePollingInterval) { - clearInterval(populatePollingInterval); - populatePollingInterval = null; + if (window.populatePollingInterval) { + clearInterval(window.populatePollingInterval); + window.populatePollingInterval = null; } } +// Renders a collapsed-by-default
list of populate-run items — +// used for both added_items and skipped_items, which can run into the +// thousands on a full library sync, so this is never expanded by default. +// Item shape tells movie apart from episode: episodes carry `season`. +function renderPopulateItemsList(items, label) { + if (!items || items.length === 0) return ''; + + const rows = items.map(item => { + if ('season' in item) { + const ep = `S${String(item.season).padStart(2, '0')}E${String(item.episode).padStart(2, '0')}`; + const extra = item.reason ? escapeHtml(item.reason) : escapeHtml(item.source || ''); + return `${escapeHtml(item.title || 'Unknown')} ${ep} (${escapeHtml(item.episode_title || 'Unknown')}) — ${extra}`; + } + const extra = item.reason ? escapeHtml(item.reason) : escapeHtml(item.source || ''); + return `${escapeHtml(item.title || 'Unknown')} (${item.year || 'N/A'}) [${escapeHtml(item.imdb_id || '')}] — ${extra}`; + }); + + return ` +
+ ${label} (${items.length}) +
+ ${rows.map(r => `
${r}
`).join('')} +
+
+ `; +} + function updatePopulateProgress(status) { const progressBar = document.getElementById('populate-progress-bar'); + const operationText = document.getElementById('populate-current-operation'); const progressText = document.getElementById('populate-progress-text'); const resultsDiv = document.getElementById('populate-results'); - // Handle running status (API returns "running": true/false) - if (status.running && !status.completed) { - if (progressBar) { - // Show indeterminate progress - progressBar.style.width = '50%'; - } - if (progressText) { - progressText.textContent = 'Populating database...'; - } - } else if (status.completed) { - if (progressBar) { - progressBar.style.width = '100%'; - } - if (progressText) { - progressText.textContent = 'Complete!'; - } - - // Show results (API returns movies/tv with nested stats) - if (resultsDiv && (status.movies || status.tv)) { - let html = '

Population Results

'; - - // Movies - if (status.movies && status.movies.stats) { - const m = status.movies.stats; - html += '
'; - html += '
Movies
'; - html += '
    '; - html += `
  • Total found: ${m.total || 0}
    • `; - html += `
  • Added: ${m.added || 0}
    • `; - html += `
  • Skipped: ${m.skipped || 0}
    • `; - html += `
  • Errors: ${m.errors || 0}
    • `; - html += `
  • Duration: ${(m.duration || 0).toFixed(2)}s
    • `; - html += '
'; - // Show skipped items if any - if (m.skipped_items && m.skipped_items.length > 0) { - html += '
Skipped Movies (' + m.skipped_items.length + ')
    '; - m.skipped_items.forEach(item => { - html += `
  • ${item.title || 'Unknown'} (${item.year || 'N/A'}) [${item.imdb_id || 'No IMDb'}] - ${item.reason}
    • `; - }); - html += '
'; - } - html += '
'; - } + if (status.error) { + progressBar.style.width = '100%'; + progressBar.style.backgroundColor = '#e74c3c'; + operationText.textContent = 'Error occurred'; + progressText.textContent = 'Failed'; + resultsDiv.innerHTML = `

Error: ${status.error}

`; + return; + } - // TV Episodes - if (status.tv && status.tv.stats) { - const tv = status.tv.stats; - html += '
'; - html += '
TV Shows
'; - html += '
    '; - html += `
  • Series: ${tv.total_series || 0}
    • `; - html += `
  • Episodes: ${tv.total_episodes || 0}
    • `; - html += `
  • Added: ${tv.added || 0}
    • `; - html += `
  • Skipped: ${tv.skipped || 0}
    • `; - html += `
  • Errors: ${tv.errors || 0}
    • `; - html += `
  • Duration: ${(tv.duration || 0).toFixed(2)}s
    • `; - html += '
'; - // Show skipped items if any - if (tv.skipped_items && tv.skipped_items.length > 0) { - html += '
Skipped Episodes (' + tv.skipped_items.length + ')
    '; - tv.skipped_items.forEach(item => { - html += `
  • ${item.title || 'Unknown'} S${String(item.season).padStart(2,'0')}E${String(item.episode).padStart(2,'0')} - ${item.reason}
    • `; - }); - html += '
'; - } - html += '
'; - } + if (!status.running && status.completed) { + progressBar.style.width = '100%'; + operationText.textContent = 'Population completed'; + progressText.textContent = '100%'; - resultsDiv.innerHTML = html; - resultsDiv.style.display = 'block'; + // Display results + let resultsHTML = '

Population Results:

'; + + if (status.movies && status.movies.stats) { + const m = status.movies.stats; + resultsHTML += ` +
+ Movies:
+ Total: ${m.total || 0} | Added: ${m.added || 0} | Skipped: ${m.skipped || 0} | Errors: ${m.errors || 0}
+ Duration: ${m.duration ? m.duration.toFixed(2) : 0}s + ${renderPopulateItemsList(m.added_items, 'Added')} + ${renderPopulateItemsList(m.skipped_items, 'Skipped')} +
+ `; } - showToast('✅ Database population completed successfully', 'success'); - - } else if (status.status === 'error') { - if (progressFill && progressText) { - progressFill.style.width = '100%'; - progressFill.style.backgroundColor = '#dc3545'; - progressText.textContent = 'Error!'; + if (status.tv && status.tv.stats) { + const t = status.tv.stats; + resultsHTML += ` +
+ TV Shows:
+ Series: ${t.total_series || 0} | Episodes: ${t.total_episodes || 0}
+ Added: ${t.added || 0} | Skipped: ${t.skipped || 0} | Errors: ${t.errors || 0}
+ Duration: ${t.duration ? t.duration.toFixed(2) : 0}s + ${renderPopulateItemsList(t.added_items, 'Added')} + ${renderPopulateItemsList(t.skipped_items, 'Skipped')} +
+ `; } - const errorMsg = status.error || 'Unknown error occurred'; - showToast(`❌ Database population failed: ${errorMsg}`, 'error'); - - if (resultsDiv) { - resultsDiv.innerHTML = `

Error: ${errorMsg}

`; - resultsDiv.style.display = 'block'; - } + resultsDiv.innerHTML = resultsHTML; + return; } -} - -// ==================== Table Sorting Functions ==================== - -let sortDirections = {}; // Track sort direction for each table column -function sortTable(tableBodyId, columnIndex, dataType) { - const tbody = document.getElementById(tableBodyId); - if (!tbody) return; - - const sortKey = `${tableBodyId}-${columnIndex}`; + // Update progress based on status + let totalProgress = 0; + let progressDetails = ''; - // Toggle sort direction - if (!sortDirections[sortKey]) { - sortDirections[sortKey] = 'asc'; - } else { - sortDirections[sortKey] = sortDirections[sortKey] === 'asc' ? 'desc' : 'asc'; + if (status.movies && status.movies.status === 'running') { + totalProgress = 50; + progressDetails = 'Processing movies...'; + } else if (status.movies && status.movies.status === 'completed') { + totalProgress = 50; + progressDetails = 'Movies completed, processing TV...'; } - const rows = Array.from(tbody.querySelectorAll('tr')); - - rows.sort((a, b) => { - const aCell = a.cells[columnIndex]; - const bCell = b.cells[columnIndex]; - - if (!aCell || !bCell) return 0; - - let aValue = aCell.textContent.trim(); - let bValue = bCell.textContent.trim(); - - // Handle MISSING values - always sort to bottom - if (aValue === 'MISSING') return 1; - if (bValue === 'MISSING') return -1; - - // Handle different data types - if (dataType === 'date') { - // Parse dates for comparison - aValue = aValue === '-' ? '' : aValue; - bValue = bValue === '-' ? '' : bValue; - - if (!aValue && !bValue) return 0; - if (!aValue) return 1; - if (!bValue) return -1; - - const aDate = new Date(aValue); - const bDate = new Date(bValue); - - if (sortDirections[sortKey] === 'asc') { - return aDate - bDate; - } else { - return bDate - aDate; - } - } else if (dataType === 'number') { - const aNum = parseFloat(aValue) || 0; - const bNum = parseFloat(bValue) || 0; - - if (sortDirections[sortKey] === 'asc') { - return aNum - bNum; - } else { - return bNum - aNum; - } - } else { - // Text comparison - if (sortDirections[sortKey] === 'asc') { - return aValue.localeCompare(bValue); - } else { - return bValue.localeCompare(aValue); - } - } - }); - - // Re-append sorted rows - rows.forEach(row => tbody.appendChild(row)); - - // Update sort icons - updateSortIcons(tableBodyId, columnIndex, sortDirections[sortKey]); -} - -function updateSortIcons(tableBodyId, activeColumn, direction) { - // Find the table and update icons - const tbody = document.getElementById(tableBodyId); - if (!tbody) return; - - const table = tbody.closest('table'); - if (!table) return; - - const headers = table.querySelectorAll('th.sortable'); - headers.forEach((header, index) => { - const icon = header.querySelector('i'); - if (!icon) return; + if (status.tv && status.tv.status === 'running') { + totalProgress = 75; + progressDetails = 'Processing TV shows...'; + } else if (status.tv && status.tv.status === 'completed') { + totalProgress = 100; + progressDetails = 'Completed'; + } - // +1 to account for checkbox column - if (index + 1 === activeColumn) { - icon.className = direction === 'asc' ? 'fas fa-sort-up' : 'fas fa-sort-down'; - } else { - icon.className = 'fas fa-sort'; - } - }); + progressBar.style.width = `${totalProgress}%`; + operationText.textContent = progressDetails; + progressText.textContent = `${totalProgress}%`; } diff --git a/clients/radarr_client.py b/clients/radarr_client.py index 71becaf..c83c13f 100644 --- a/clients/radarr_client.py +++ b/clients/radarr_client.py @@ -10,7 +10,7 @@ from urllib.request import Request as UrlRequest, urlopen from urllib.error import URLError, HTTPError -from core.logging import _log +from core.logging import _log as _log_raw # Import path mapper for proper path handling try: @@ -55,11 +55,12 @@ class RadarrClient: 'usenet', 'torrent', 'radarr', 'completed', 'processing' ] - def __init__(self, base_url: str, api_key: str, timeout: int = 45, retries: int = 3): + def __init__(self, base_url: str, api_key: str, timeout: int = 45, retries: int = 3, instance_name: str = ""): self.base_url = base_url.rstrip("/") self.api_key = api_key self.timeout = timeout self.retries = max(0, retries) + self.instance_name = instance_name # Initialize database client - REQUIRED for operation self.db_client = None @@ -67,14 +68,22 @@ def __init__(self, base_url: str, api_key: str, timeout: int = 45, retries: int try: self.db_client = RadarrDbClient.from_env() if self.db_client: - _log("INFO", "✅ DATABASE ONLY MODE: Direct database access enabled") + self._log("INFO", "✅ DATABASE ONLY MODE: Direct database access enabled") else: - _log("ERROR", "❌ DATABASE ONLY MODE: Database configuration required - API mode disabled") + self._log("ERROR", "❌ DATABASE ONLY MODE: Database configuration required - API mode disabled") except Exception as e: - _log("ERROR", f"❌ DATABASE ONLY MODE: Failed to initialize database client: {e}") + self._log("ERROR", f"❌ DATABASE ONLY MODE: Failed to initialize database client: {e}") self.db_client = None else: - _log("ERROR", "❌ DATABASE ONLY MODE: RadarrDbClient not available - check dependencies") + self._log("ERROR", "❌ DATABASE ONLY MODE: RadarrDbClient not available - check dependencies") + + def _log(self, level: str, message: str) -> None: + """Log with this client's instance name prefixed, so a log line is + traceable back to which Radarr/Sonarr instance it came from — matters + as soon as there's more than one of the same type configured. + """ + prefix = f"[{self.instance_name}] " if self.instance_name else "" + _log_raw(level, f"{prefix}{message}") def _get(self, path: str, params: Dict[str, Any] = None) -> Optional[Any]: """Make GET request to Radarr API with retries""" @@ -93,7 +102,7 @@ def _get(self, path: str, params: Dict[str, Any] = None) -> Optional[Any]: if params: url = url + ("&" if "?" in url else "?") + urlencode(params) - _log("DEBUG", f"Radarr API Request: {url}") + self._log("DEBUG", f"Radarr API Request: {url}") req = UrlRequest(url, headers={"Accept": "application/json"}) with urlopen(req, timeout=self.timeout) as resp: @@ -103,34 +112,34 @@ def _get(self, path: str, params: Dict[str, Any] = None) -> Optional[Any]: except (URLError, HTTPError, json.JSONDecodeError) as e: last_err = e - _log("DEBUG", f"Radarr API attempt {attempt + 1} failed: {e}") + self._log("DEBUG", f"Radarr API attempt {attempt + 1} failed: {e}") time.sleep(min(2 ** attempt, 5)) # Exponential backoff attempt += 1 - _log("WARNING", f"Radarr GET {path} failed after {self.retries + 1} attempts: {last_err}") + self._log("WARNING", f"Radarr GET {path} failed after {self.retries + 1} attempts: {last_err}") return None def movie_by_imdb(self, imdb_id: str) -> Optional[Dict[str, Any]]: """Find movie by IMDb ID - DATABASE ONLY mode""" imdb_id = imdb_id if imdb_id.startswith("tt") else f"tt{imdb_id}" - _log("DEBUG", f"Looking up movie by IMDb ID: {imdb_id}") + self._log("DEBUG", f"Looking up movie by IMDb ID: {imdb_id}") # Database required - no API fallback if self.db_client: try: movie = self.db_client.get_movie_by_imdb(imdb_id) if movie: - _log("INFO", f"✅ Found via database: {movie.get('title')} (ID: {movie.get('id')})") + self._log("INFO", f"✅ Found via database: {movie.get('title')} (ID: {movie.get('id')})") return movie else: - _log("WARNING", f"Movie not found in database for IMDb ID: {imdb_id}") + self._log("WARNING", f"Movie not found in database for IMDb ID: {imdb_id}") return None except Exception as e: - _log("ERROR", f"Database lookup failed: {e}") + self._log("ERROR", f"Database lookup failed: {e}") return None # No database client available - _log("ERROR", "Database client required for movie lookup - API mode disabled") + self._log("ERROR", "Database client required for movie lookup - API mode disabled") return None def _analyze_event_for_import(self, event: Dict[str, Any], movie_info: Dict[str, Any] = None) -> Tuple[bool, str, Optional[str]]: @@ -202,15 +211,15 @@ def _analyze_event_for_import(self, event: Dict[str, Any], movie_info: Dict[str, # Check if both title and year are in the source if movie_title and movie_year: if movie_title in source_clean and movie_year in source_clean: - _log("DEBUG", f"✅ Match found - Title: {movie_title}, Year: {movie_year}") + self._log("DEBUG", f"✅ Match found - Title: {movie_title}, Year: {movie_year}") return True, "matched_title_and_year", date_iso # Also check for downloads path as secondary validation if path_mapper.is_download_path(source): - _log("DEBUG", f"Source is from downloads: {source}") + self._log("DEBUG", f"Source is from downloads: {source}") return True, "from_downloads_path", date_iso - _log("DEBUG", f"⚠️ No match found in sources: {source_items}") + self._log("DEBUG", f"⚠️ No match found in sources: {source_items}") return False, "no_title_year_match", date_iso # Fallback to basic path validation if no movie info @@ -225,12 +234,12 @@ def earliest_import_event_optimized(self, movie_id: int) -> Optional[str]: Find earliest real import event with optimized querying. Stops as soon as we find valid import events instead of loading everything. """ - _log("INFO", f"Finding earliest import for movie_id {movie_id}") + self._log("INFO", f"Finding earliest import for movie_id {movie_id}") # Get movie info for path validation movie_info = self._get(f"/api/v3/movie/{movie_id}") if not movie_info or not isinstance(movie_info, dict): - _log("ERROR", f"Could not get movie info for ID {movie_id}") + self._log("ERROR", f"Could not get movie info for ID {movie_id}") return None earliest_real_import = None @@ -256,7 +265,7 @@ def earliest_import_event_optimized(self, movie_id: int) -> Optional[str]: if not items: break - _log("DEBUG", f"Page {page}: Processing {len(items)} events") + self._log("DEBUG", f"Page {page}: Processing {len(items)} events") for event in items: total_processed += 1 @@ -280,7 +289,7 @@ def earliest_import_event_optimized(self, movie_id: int) -> Optional[str]: else: event_type = int(event_type) except (ValueError, TypeError): - _log("DEBUG", f"Unknown event type: {event_type}") + self._log("DEBUG", f"Unknown event type: {event_type}") continue # Check for grab events (type 1) - but validate it's a real download @@ -302,9 +311,9 @@ def earliest_import_event_optimized(self, movie_id: int) -> Optional[str]: # Only count grabs that have actual download metadata if source_title or indexer: first_grab = datetime.fromisoformat(event["date"].replace("Z", "+00:00")).astimezone(timezone.utc).isoformat(timespec="seconds") - _log("DEBUG", f"Found real grab event with source '{source_title}' from '{indexer}' at {first_grab}") + self._log("DEBUG", f"Found real grab event with source '{source_title}' from '{indexer}' at {first_grab}") else: - _log("DEBUG", f"Skipping grab event without download info at {event.get('date')}") + self._log("DEBUG", f"Skipping grab event without download info at {event.get('date')}") except Exception: pass @@ -321,7 +330,7 @@ def earliest_import_event_optimized(self, movie_id: int) -> Optional[str]: try: event_data = json.loads(event_data) except (json.JSONDecodeError, AttributeError) as e: - _log("DEBUG", f"Failed to parse event data JSON: {e}") + self._log("DEBUG", f"Failed to parse event data JSON: {e}") continue elif not isinstance(event_data, dict): continue @@ -343,9 +352,9 @@ def earliest_import_event_optimized(self, movie_id: int) -> Optional[str]: f"[{movie_imdb}]" in imported_path or movie_imdb in imported_path ): - _log("INFO", f"Found potential IMDb match in {event_type} event: {imported_path}") + self._log("INFO", f"Found potential IMDb match in {event_type} event: {imported_path}") date_iso = datetime.fromisoformat(event["date"].replace("Z", "+00:00")).astimezone(timezone.utc).isoformat(timespec="seconds") - _log("INFO", f"✅ FOUND IMPORT: exact IMDb match at {date_iso}") + self._log("INFO", f"✅ FOUND IMPORT: exact IMDb match at {date_iso}") earliest_real_import = date_iso break @@ -358,8 +367,8 @@ def earliest_import_event_optimized(self, movie_id: int) -> Optional[str]: # Look for both title and year in the path if clean_title in clean_path and movie_year in clean_path: date_iso = datetime.fromisoformat(event["date"].replace("Z", "+00:00")).astimezone(timezone.utc).isoformat(timespec="seconds") - _log("INFO", f"Found potential title/year match for event type {event_type}: {clean_title} ({movie_year})") - _log("INFO", f"✅ FOUND IMPORT at {date_iso}") + self._log("INFO", f"Found potential title/year match for event type {event_type}: {clean_title} ({movie_year})") + self._log("INFO", f"✅ FOUND IMPORT at {date_iso}") earliest_real_import = date_iso break @@ -380,7 +389,7 @@ def earliest_import_event_optimized(self, movie_id: int) -> Optional[str]: f"[{movie_imdb}]" in source_path or movie_imdb in source_path ): - _log("INFO", f"✅ FOUND IMPORT: IMDb match in path at {date_iso}") + self._log("INFO", f"✅ FOUND IMPORT: IMDb match in path at {date_iso}") earliest_real_import = date_iso break @@ -388,11 +397,11 @@ def earliest_import_event_optimized(self, movie_id: int) -> Optional[str]: movie_title = (movie_info.get("title", "") or "").lower().replace(":", ".").replace(" ", ".") movie_year = str(movie_info.get("year", "")) if movie_title and movie_year and movie_title in source_path and movie_year in source_path: - _log("INFO", f"✅ FOUND IMPORT: Title/year match at {date_iso}") + self._log("INFO", f"✅ FOUND IMPORT: Title/year match at {date_iso}") earliest_real_import = date_iso break elif event_type == 3: - _log("DEBUG", f"⚠️ Skipped import event: {reason}") + self._log("DEBUG", f"⚠️ Skipped import event: {reason}") # If we found a real import, no need to continue if earliest_real_import: @@ -404,27 +413,27 @@ def earliest_import_event_optimized(self, movie_id: int) -> Optional[str]: page += 1 - _log("INFO", f"Processed {total_processed} events across {page-1} pages") + self._log("INFO", f"Processed {total_processed} events across {page-1} pages") if earliest_real_import: - _log("INFO", f"✅ Using earliest real import: {earliest_real_import}") + self._log("INFO", f"✅ Using earliest real import: {earliest_real_import}") return earliest_real_import if first_grab: - _log("WARNING", f"⚠️ No real imports found, using grab date: {first_grab}") + self._log("WARNING", f"⚠️ No real imports found, using grab date: {first_grab}") return first_grab - _log("ERROR", f"❌ No import or grab events found for movie_id {movie_id}") + self._log("ERROR", f"❌ No import or grab events found for movie_id {movie_id}") return None def movie_files(self, movie_id: int) -> List[Dict[str, Any]]: """Get movie files for a movie - DATABASE ONLY mode""" if self.db_client: - _log("INFO", "Using database for movie files lookup") + self._log("INFO", "Using database for movie files lookup") # Database handles this internally in get_movie_file_date() return [] - _log("ERROR", "Database client required for movie files - API mode disabled") + self._log("ERROR", "Database client required for movie files - API mode disabled") return [] def earliest_file_dateadded(self, movie_id: int) -> Optional[str]: @@ -433,10 +442,10 @@ def earliest_file_dateadded(self, movie_id: int) -> Optional[str]: try: return self.db_client.get_movie_file_date(movie_id) except Exception as e: - _log("ERROR", f"Database file date query failed: {e}") + self._log("ERROR", f"Database file date query failed: {e}") return None - _log("ERROR", "Database client required for file dates - API mode disabled") + self._log("ERROR", "Database client required for file dates - API mode disabled") return None def get_movie_import_date(self, movie_id: int, fallback_to_file_date: bool = True) -> Tuple[Optional[str], str]: @@ -453,19 +462,19 @@ def get_movie_import_date(self, movie_id: int, fallback_to_file_date: bool = Tru if date_iso: return date_iso, source else: - _log("WARNING", f"No import date found in database for movie_id {movie_id}") + self._log("WARNING", f"No import date found in database for movie_id {movie_id}") return None, "radarr:db.no_date_found" except Exception as e: - _log("ERROR", f"Database import date query failed: {e}") + self._log("ERROR", f"Database import date query failed: {e}") return None, "radarr:db.error" # No database client available - _log("ERROR", "Database client required for import date detection - API mode disabled") + self._log("ERROR", "Database client required for import date detection - API mode disabled") return None, "radarr:db.not_configured" def _get_earliest_import_date(self, movie_id: int, movie_info: Dict) -> Optional[str]: """Get the earliest import date from Radarr history.""" - _log("INFO", f"Finding earliest import for movie_id {movie_id}") + self._log("INFO", f"Finding earliest import for movie_id {movie_id}") earliest_real_import = None earliest_grab_date = None @@ -492,7 +501,7 @@ def _get_earliest_import_date(self, movie_id: int, movie_info: Dict) -> Optional # Track earliest grab date as fallback (EventType 1) if event_type == 1 and not earliest_grab_date: earliest_grab_date = event_date - _log("DEBUG", f"Found first grab event at {earliest_grab_date}") + self._log("DEBUG", f"Found first grab event at {earliest_grab_date}") continue # Look for import events (EventType 3) @@ -500,7 +509,7 @@ def _get_earliest_import_date(self, movie_id: int, movie_info: Dict) -> Optional try: data = json.loads(event.get("data", "{}")) if data.get("importedPath"): - _log("INFO", f"✅ FOUND IMPORT at {event_date}") + self._log("INFO", f"✅ FOUND IMPORT at {event_date}") earliest_real_import = event_date break except (json.JSONDecodeError, AttributeError): @@ -513,12 +522,12 @@ def _get_earliest_import_date(self, movie_id: int, movie_info: Dict) -> Optional total_events += len(history_data) page += 1 - _log("INFO", f"Processed {total_events} events across {page}") + self._log("INFO", f"Processed {total_events} events across {page}") if earliest_real_import: return earliest_real_import if earliest_grab_date: - _log("WARNING", f"⚠️ No EventType 3 (import) found, using grab date: {earliest_grab_date}") + self._log("WARNING", f"⚠️ No EventType 3 (import) found, using grab date: {earliest_grab_date}") return earliest_grab_date return None diff --git a/clients/radarr_db_client.py b/clients/radarr_db_client.py index 077dc4c..1f298fe 100644 --- a/clients/radarr_db_client.py +++ b/clients/radarr_db_client.py @@ -13,7 +13,7 @@ from typing import Dict, Any, List, Optional, Tuple, Union from urllib.parse import urlparse -from core.logging import _log +from core.logging import _log as _log_raw class RadarrDbClient: @@ -26,7 +26,8 @@ def __init__(self, db_port: Optional[int] = None, db_name: Optional[str] = None, db_user: Optional[str] = None, - db_password: Optional[str] = None): + db_password: Optional[str] = None, + instance_name: str = ""): """ Initialize Radarr database client @@ -38,6 +39,8 @@ def __init__(self, db_name: PostgreSQL database name db_user: PostgreSQL username db_password: PostgreSQL password + instance_name: label prefixed onto every log line from this client + (e.g. "radarr_4k") — leave blank for the unlabeled default instance """ self.db_type = db_type.lower() self.db_path = db_path @@ -46,7 +49,8 @@ def __init__(self, self.db_name = db_name self.db_user = db_user self.db_password = db_password - + self.instance_name = instance_name + self._test_connection() @classmethod @@ -60,10 +64,10 @@ def from_env(cls) -> Optional['RadarrDbClient']: if db_type == "sqlite": db_path = os.environ.get("RADARR_DB_PATH") if not db_path or not Path(db_path).exists(): - _log("WARNING", f"RADARR_DB_PATH not found or invalid: {db_path}") + _log_raw("WARNING", f"RADARR_DB_PATH not found or invalid: {db_path}") return None - return cls(db_type="sqlite", db_path=db_path) - + return cls(db_type="sqlite", db_path=db_path, instance_name="radarr") + elif db_type == "postgresql": # Support both individual vars and connection string db_url = os.environ.get("RADARR_DB_URL") @@ -75,7 +79,8 @@ def from_env(cls) -> Optional['RadarrDbClient']: db_port=parsed.port or 5432, db_name=parsed.path.lstrip('/'), db_user=parsed.username, - db_password=parsed.password + db_password=parsed.password, + instance_name="radarr", ) else: return cls( @@ -84,28 +89,44 @@ def from_env(cls) -> Optional['RadarrDbClient']: db_port=int(os.environ.get("RADARR_DB_PORT", "5432")), db_name=os.environ.get("RADARR_DB_NAME"), db_user=os.environ.get("RADARR_DB_USER"), - db_password=os.environ.get("RADARR_DB_PASSWORD") + db_password=os.environ.get("RADARR_DB_PASSWORD"), + instance_name="radarr", ) else: - _log("ERROR", f"Unsupported database type: {db_type}") + _log_raw("ERROR", f"Unsupported database type: {db_type}") return None + def _log(self, level: str, message: str) -> None: + """Log with this client's instance name prefixed, so a log line is + traceable back to which Radarr/Sonarr instance it came from — matters + as soon as there's more than one of the same type configured. + """ + prefix = f"[{self.instance_name}] " if self.instance_name else "" + _log_raw(level, f"{prefix}{message}") + def _test_connection(self) -> None: """Test database connection on initialization""" try: conn = self._get_connection() if conn: conn.close() - _log("INFO", f"Connected to Radarr {self.db_type} database successfully") + self._log("INFO", f"Connected to Radarr {self.db_type} database successfully") else: raise Exception("Failed to create connection") except Exception as e: - _log("ERROR", f"Failed to connect to Radarr database: {e}") + self._log("ERROR", f"Failed to connect to Radarr database: {e}") raise def _get_connection(self) -> Union[sqlite3.Connection, psycopg2.extensions.connection]: """Get database connection""" if self.db_type == "sqlite": + # sqlite3.connect() silently creates an empty file at db_path if it + # doesn't exist — a missing/wrong volume mount would otherwise look + # like a successful connection to an empty database instead of failing. + if not self.db_path or not Path(self.db_path).exists(): + raise FileNotFoundError( + f"Radarr SQLite database not found at '{self.db_path}' — check volume mounts" + ) conn = sqlite3.connect(self.db_path) conn.row_factory = sqlite3.Row return conn @@ -162,7 +183,7 @@ def get_movie_by_imdb(self, imdb_id: str) -> Optional[Dict[str, Any]]: return dict(row) if self.db_type == "sqlite" else row except Exception as e: - _log("ERROR", f"Database query error for IMDb {imdb_id}: {e}") + self._log("ERROR", f"Database query error for IMDb {imdb_id}: {e}") return None @@ -219,7 +240,7 @@ def get_all_movies(self) -> List[Dict[str, Any]]: return [] except Exception as e: - _log("ERROR", f"Database query error getting all movies: {e}") + self._log("ERROR", f"Database query error getting all movies: {e}") return [] def get_earliest_import_date(self, movie_id: int) -> Tuple[Optional[str], str]: @@ -234,7 +255,7 @@ def get_earliest_import_date(self, movie_id: int) -> Tuple[Optional[str], str]: """ # If first event is rename, all subsequent imports are upgrades - skip them if self.is_first_event_rename_based(movie_id): - _log("INFO", f"Movie {movie_id} has rename-first history - all imports are upgrades, skipping") + self._log("INFO", f"Movie {movie_id} has rename-first history - all imports are upgrades, skipping") return None, "radarr:db.upgrade_imports_skipped" # Query for earliest import event - PostgreSQL uses INTEGER EventType (3 = import) @@ -288,7 +309,7 @@ def get_earliest_import_date(self, movie_id: int) -> Tuple[Optional[str], str]: dt = event_date.replace(tzinfo=timezone.utc) date_iso = dt.astimezone(timezone.utc).isoformat(timespec="seconds") - _log("INFO", f"✅ Found import event ({event_type}) for movie {movie_id} at {date_iso}") + self._log("INFO", f"✅ Found import event ({event_type}) for movie {movie_id} at {date_iso}") return date_iso, "radarr:db.history.import" # Fallback to grab events @@ -304,11 +325,11 @@ def get_earliest_import_date(self, movie_id: int) -> Tuple[Optional[str], str]: dt = event_date.replace(tzinfo=timezone.utc) date_iso = dt.astimezone(timezone.utc).isoformat(timespec="seconds") - _log("WARNING", f"⚠️ Using grab event ({event_type}) for movie {movie_id} at {date_iso}") + self._log("WARNING", f"⚠️ Using grab event ({event_type}) for movie {movie_id} at {date_iso}") return date_iso, "radarr:db.history.grab" except Exception as e: - _log("ERROR", f"Database query error for movie {movie_id}: {e}") + self._log("ERROR", f"Database query error for movie {movie_id}: {e}") return None, "radarr:db.no_date_found" @@ -344,27 +365,27 @@ def is_first_event_rename_based(self, movie_id: int) -> bool: rows = cursor.fetchall() if rows: - _log("INFO", f"Movie {movie_id} history debug - first 5 events:") + self._log("INFO", f"Movie {movie_id} history debug - first 5 events:") for i, row in enumerate(rows): event_type = row['event_type'] if self.db_type == "postgresql" else row[0] event_date = row['event_date'] if self.db_type == "postgresql" else row[1] - _log("INFO", f" Event {i+1}: Type={event_type}, Date={event_date}") + self._log("INFO", f" Event {i+1}: Type={event_type}, Date={event_date}") first_event_type = rows[0]['event_type'] if self.db_type == "postgresql" else rows[0][0] # EventType 8 = movieFileRenamed # Also check for EventType 7 = movieFileRenamed in some Radarr versions is_rename_first = first_event_type in [7, 8] - _log("INFO", f"Movie {movie_id}: First event type={first_event_type}, is_rename_first={is_rename_first}") + self._log("INFO", f"Movie {movie_id}: First event type={first_event_type}, is_rename_first={is_rename_first}") if is_rename_first: - _log("INFO", f"🎯 Movie {movie_id} detected as rename-first scenario - will prefer release dates over import dates") + self._log("INFO", f"🎯 Movie {movie_id} detected as rename-first scenario - will prefer release dates over import dates") return is_rename_first else: - _log("WARNING", f"Movie {movie_id}: No history events found - this could indicate missing data") + self._log("WARNING", f"Movie {movie_id}: No history events found - this could indicate missing data") except Exception as e: - _log("ERROR", f"Error checking first event type for movie {movie_id}: {e}") + self._log("ERROR", f"Error checking first event type for movie {movie_id}: {e}") return False @@ -408,7 +429,7 @@ def get_movie_file_date(self, movie_id: int) -> Optional[str]: return dt.astimezone(timezone.utc).isoformat(timespec="seconds") except Exception as e: - _log("ERROR", f"Database query error for movie file date {movie_id}: {e}") + self._log("ERROR", f"Database query error for movie file date {movie_id}: {e}") return None @@ -430,14 +451,14 @@ def get_movie_import_date_optimized(self, movie_id: int, fallback_to_file_date: # Check if we skipped upgrades and should prefer release dates if source == "radarr:db.upgrade_imports_skipped": - _log("INFO", f"Movie {movie_id} upgrade scenario detected - signaling to prefer release dates") + self._log("INFO", f"Movie {movie_id} upgrade scenario detected - signaling to prefer release dates") return None, "radarr:db.prefer_release_dates" # Fallback to file date if requested if fallback_to_file_date: file_date = self.get_movie_file_date(movie_id) if file_date: - _log("WARNING", f"Using file dateAdded as fallback for movie_id {movie_id}") + self._log("WARNING", f"Using file dateAdded as fallback for movie_id {movie_id}") return file_date, "radarr:db.file.dateAdded" return None, "radarr:db.no_date_found" @@ -510,7 +531,7 @@ def bulk_import_dates(self, imdb_ids: List[str]) -> Dict[str, Tuple[Optional[str results[imdb_id] = (None, "radarr:db.bulk.no_import") except Exception as e: - _log("ERROR", f"Bulk query error: {e}") + self._log("ERROR", f"Bulk query error: {e}") # Return empty results for failed queries for imdb_id in clean_imdb_ids: if imdb_id not in results: @@ -540,7 +561,7 @@ def get_database_stats(self) -> Dict[str, Any]: stats[stat_name] = result[0] if result else 0 except Exception as e: - _log("ERROR", f"Stats query error: {e}") + self._log("ERROR", f"Stats query error: {e}") stats["error"] = str(e) return stats @@ -662,7 +683,7 @@ def health_check(self) -> Dict[str, Any]: health["status"] = "error" health["connection"] = "failed" health["issues"].append(f"Connection failed: {e}") - _log("ERROR", f"Database health check failed: {e}") + self._log("ERROR", f"Database health check failed: {e}") # Overall status determination if health["issues"]: diff --git a/clients/sonarr_client.py b/clients/sonarr_client.py index b149eed..03abe71 100644 --- a/clients/sonarr_client.py +++ b/clients/sonarr_client.py @@ -10,18 +10,27 @@ from urllib.request import Request as UrlRequest, urlopen from urllib.error import URLError, HTTPError -from core.logging import _log +from core.logging import _log as _log_raw class SonarrClient: """Enhanced Sonarr API client for TV series and episode management""" - def __init__(self, base_url: str, api_key: str, timeout: int = 45, retries: int = 3): + def __init__(self, base_url: str, api_key: str, timeout: int = 45, retries: int = 3, instance_name: str = ""): self.base_url = base_url.rstrip("/") self.api_key = api_key self.timeout = timeout self.retries = max(0, retries) self.enabled = bool(self.base_url and self.api_key) + self.instance_name = instance_name + + def _log(self, level: str, message: str) -> None: + """Log with this client's instance name prefixed, so a log line is + traceable back to which Radarr/Sonarr instance it came from — matters + as soon as there's more than one of the same type configured. + """ + prefix = f"[{self.instance_name}] " if self.instance_name else "" + _log_raw(level, f"{prefix}{message}") def _get(self, path: str, params: Dict[str, Any] = None) -> Optional[Any]: """Make GET request to Sonarr API with retries""" @@ -36,7 +45,7 @@ def _get(self, path: str, params: Dict[str, Any] = None) -> Optional[Any]: for attempt in range(self.retries): try: - _log("DEBUG", f"Sonarr API Request: {url}") + self._log("DEBUG", f"Sonarr API Request: {url}") req = UrlRequest(url, headers=headers) with urlopen(req, timeout=self.timeout) as resp: @@ -46,71 +55,71 @@ def _get(self, path: str, params: Dict[str, Any] = None) -> Optional[Any]: except HTTPError as e: if e.code == 401: - _log("ERROR", "Sonarr authentication failed - check API key") + self._log("ERROR", "Sonarr authentication failed - check API key") return None elif e.code == 429: wait_time = (attempt + 1) * 2 - _log("WARNING", f"Sonarr rate limited, waiting {wait_time}s (attempt {attempt+1}/{self.retries})") + self._log("WARNING", f"Sonarr rate limited, waiting {wait_time}s (attempt {attempt+1}/{self.retries})") time.sleep(wait_time) else: - _log("WARNING", f"Sonarr HTTP {e.code} error on attempt {attempt+1}/{self.retries}: {e.reason}") + self._log("WARNING", f"Sonarr HTTP {e.code} error on attempt {attempt+1}/{self.retries}: {e.reason}") except Exception as e: - _log("WARNING", f"Sonarr API attempt {attempt+1}/{self.retries} failed: {e}") + self._log("WARNING", f"Sonarr API attempt {attempt+1}/{self.retries} failed: {e}") if attempt < self.retries - 1: time.sleep(0.5 * (attempt + 1)) - _log("ERROR", f"Sonarr API failed after {self.retries} attempts: {url}") + self._log("ERROR", f"Sonarr API failed after {self.retries} attempts: {url}") return None def series_by_imdb(self, imdb_id: str) -> Optional[Dict[str, Any]]: """Find series by IMDb ID using lookup endpoint""" search_term = f"imdbid:{imdb_id}" - _log("DEBUG", f"Searching Sonarr with term: {search_term}") + self._log("DEBUG", f"Searching Sonarr with term: {search_term}") result = self._get("/series/lookup", {"term": search_term}) if not result: - _log("WARNING", f"No results from Sonarr lookup for: {search_term}") + self._log("WARNING", f"No results from Sonarr lookup for: {search_term}") return None - _log("DEBUG", f"Sonarr lookup returned {len(result)} results") + self._log("DEBUG", f"Sonarr lookup returned {len(result)} results") # Log all results for debugging for i, series in enumerate(result): series_imdb = series.get("imdbId", "") series_title = series.get("title", "") series_id = series.get("id", "") - _log("DEBUG", f"Result {i+1}: Title='{series_title}', IMDb='{series_imdb}', ID={series_id}") + self._log("DEBUG", f"Result {i+1}: Title='{series_title}', IMDb='{series_imdb}', ID={series_id}") # Find exact IMDb match (case insensitive) target_imdb = imdb_id.lower() for series in result: series_imdb = (series.get("imdbId") or "").lower() if series_imdb == target_imdb: - _log("INFO", f"Found exact IMDb match: {series.get('title')} (ID: {series.get('id')})") + self._log("INFO", f"Found exact IMDb match: {series.get('title')} (ID: {series.get('id')})") return series # Try partial match as fallback for series in result: series_imdb = (series.get("imdbId") or "").lower() if target_imdb in series_imdb or series_imdb in target_imdb: - _log("WARNING", f"Found partial IMDb match: {series.get('title')} (Expected: {imdb_id}, Found: {series.get('imdbId')})") + self._log("WARNING", f"Found partial IMDb match: {series.get('title')} (Expected: {imdb_id}, Found: {series.get('imdbId')})") return series - _log("WARNING", f"No IMDb match found in {len(result)} results for {imdb_id}") + self._log("WARNING", f"No IMDb match found in {len(result)} results for {imdb_id}") return None def series_by_title(self, title: str) -> Optional[Dict[str, Any]]: """Search for series by title as fallback when IMDb lookup fails""" - _log("DEBUG", f"Searching Sonarr by title: {title}") + self._log("DEBUG", f"Searching Sonarr by title: {title}") result = self._get("/series/lookup", {"term": title}) if not result: - _log("WARNING", f"No results from Sonarr title search for: {title}") + self._log("WARNING", f"No results from Sonarr title search for: {title}") return None - _log("DEBUG", f"Sonarr title search returned {len(result)} results") + self._log("DEBUG", f"Sonarr title search returned {len(result)} results") title_lower = title.lower() @@ -118,17 +127,17 @@ def series_by_title(self, title: str) -> Optional[Dict[str, Any]]: for series in result: series_title = (series.get("title") or "").lower() if series_title == title_lower: - _log("INFO", f"Found exact title match: {series.get('title')} (ID: {series.get('id')})") + self._log("INFO", f"Found exact title match: {series.get('title')} (ID: {series.get('id')})") return series # Look for partial title match for series in result: series_title = (series.get("title") or "").lower() if title_lower in series_title or series_title in title_lower: - _log("INFO", f"Found partial title match: '{series.get('title')}' for search '{title}' (ID: {series.get('id')})") + self._log("INFO", f"Found partial title match: '{series.get('title')}' for search '{title}' (ID: {series.get('id')})") return series - _log("WARNING", f"No title match found for: {title}") + self._log("WARNING", f"No title match found for: {title}") return None def get_all_series(self) -> List[Dict[str, Any]]: @@ -137,17 +146,17 @@ def get_all_series(self) -> List[Dict[str, Any]]: def series_by_imdb_direct(self, imdb_id: str) -> Optional[Dict[str, Any]]: """Find series by scanning all series for IMDb match (slower but more reliable)""" - _log("DEBUG", f"Direct series lookup for IMDb: {imdb_id}") + self._log("DEBUG", f"Direct series lookup for IMDb: {imdb_id}") all_series = self.get_all_series() target_imdb = imdb_id.lower() for series in all_series: series_imdb = (series.get("imdbId") or "").lower() if series_imdb == target_imdb: - _log("INFO", f"Found series via direct lookup: {series.get('title')} (ID: {series.get('id')})") + self._log("INFO", f"Found series via direct lookup: {series.get('title')} (ID: {series.get('id')})") return series - _log("WARNING", f"No series found with IMDb ID via direct lookup: {imdb_id}") + self._log("WARNING", f"No series found with IMDb ID via direct lookup: {imdb_id}") return None def get_series_by_id(self, series_id: int) -> Optional[Dict[str, Any]]: @@ -197,7 +206,7 @@ def get_episode_import_history(self, episode_id: int) -> Optional[str]: if page > 10: # Safety valve break - _log("DEBUG", f"Got {len(all_records)} history records for episode {episode_id}") + self._log("DEBUG", f"Got {len(all_records)} history records for episode {episode_id}") # Categorize events import_events = [] @@ -211,7 +220,7 @@ def get_episode_import_history(self, episode_id: int) -> Optional[str]: if not date: continue - _log("DEBUG", f"History event: {event_type} at {date}") + self._log("DEBUG", f"History event: {event_type} at {date}") if event_type == "downloadfolderimported": import_events.append({"date": date, "event": event}) @@ -224,7 +233,7 @@ def get_episode_import_history(self, episode_id: int) -> Optional[str]: if import_events: earliest_import = min(import_events, key=lambda x: x["date"]) import_date = earliest_import["date"] - _log("INFO", f"Found import date: {import_date} for episode {episode_id}") + self._log("INFO", f"Found import date: {import_date} for episode {episode_id}") # Check chronological order of events if rename_events: @@ -237,26 +246,26 @@ def get_episode_import_history(self, episode_id: int) -> Optional[str]: # If import happened BEFORE rename, it's valid original import if import_dt <= rename_dt: - _log("INFO", f"Import {import_date} happened before/during rename {rename_date} - using import date") + self._log("INFO", f"Import {import_date} happened before/during rename {rename_date} - using import date") return import_date # If rename happened BEFORE import - always use aired date fallback else: - _log("WARNING", f"Rename {rename_date} happened before import {import_date} - using aired date fallback") + self._log("WARNING", f"Rename {rename_date} happened before import {import_date} - using aired date fallback") return None # Trigger aired date fallback except Exception as e: - _log("DEBUG", f"Error comparing dates: {e}") + self._log("DEBUG", f"Error comparing dates: {e}") return import_date # Fallback to grab event if grabbed_events: earliest_grab = min(grabbed_events, key=lambda x: x["date"]) - _log("WARNING", f"No import events, using grab date: {earliest_grab['date']} for episode {episode_id}") + self._log("WARNING", f"No import events, using grab date: {earliest_grab['date']} for episode {episode_id}") return earliest_grab["date"] - _log("WARNING", f"No reliable import events found for episode {episode_id} - should use air date instead") + self._log("WARNING", f"No reliable import events found for episode {episode_id} - should use air date instead") return None diff --git a/clients/sonarr_db_client.py b/clients/sonarr_db_client.py index 3200f4b..8cc54af 100644 --- a/clients/sonarr_db_client.py +++ b/clients/sonarr_db_client.py @@ -13,7 +13,7 @@ from typing import Dict, Any, List, Optional, Tuple, Union from urllib.parse import urlparse -from core.logging import _log +from core.logging import _log as _log_raw class SonarrDbClient: @@ -26,7 +26,8 @@ def __init__(self, db_port: Optional[int] = None, db_name: Optional[str] = None, db_user: Optional[str] = None, - db_password: Optional[str] = None): + db_password: Optional[str] = None, + instance_name: str = ""): """ Initialize Sonarr database client @@ -38,6 +39,8 @@ def __init__(self, db_name: PostgreSQL database name db_user: PostgreSQL username db_password: PostgreSQL password + instance_name: label prefixed onto every log line from this client + (e.g. "sonarr_strm") — leave blank for the unlabeled default instance """ self.db_type = db_type.lower() self.db_path = db_path @@ -46,6 +49,7 @@ def __init__(self, self.db_name = db_name self.db_user = db_user self.db_password = db_password + self.instance_name = instance_name self._test_connection() @@ -60,9 +64,9 @@ def from_env(cls) -> Optional['SonarrDbClient']: if db_type == "sqlite": db_path = os.environ.get("SONARR_DB_PATH") if not db_path or not Path(db_path).exists(): - _log("WARNING", f"SONARR_DB_PATH not found or invalid: {db_path}") + _log_raw("WARNING", f"SONARR_DB_PATH not found or invalid: {db_path}") return None - return cls(db_type="sqlite", db_path=db_path) + return cls(db_type="sqlite", db_path=db_path, instance_name="sonarr") elif db_type == "postgresql": # Support both individual vars and connection string @@ -75,7 +79,8 @@ def from_env(cls) -> Optional['SonarrDbClient']: db_port=parsed.port or 5432, db_name=parsed.path.lstrip('/'), db_user=parsed.username, - db_password=parsed.password + db_password=parsed.password, + instance_name="sonarr", ) else: return cls( @@ -84,28 +89,44 @@ def from_env(cls) -> Optional['SonarrDbClient']: db_port=int(os.environ.get("SONARR_DB_PORT", "5432")), db_name=os.environ.get("SONARR_DB_NAME"), db_user=os.environ.get("SONARR_DB_USER"), - db_password=os.environ.get("SONARR_DB_PASSWORD") + db_password=os.environ.get("SONARR_DB_PASSWORD"), + instance_name="sonarr", ) else: - _log("ERROR", f"Unsupported database type: {db_type}") + _log_raw("ERROR", f"Unsupported database type: {db_type}") return None + def _log(self, level: str, message: str) -> None: + """Log with this client's instance name prefixed, so a log line is + traceable back to which Radarr/Sonarr instance it came from — matters + as soon as there's more than one of the same type configured. + """ + prefix = f"[{self.instance_name}] " if self.instance_name else "" + _log_raw(level, f"{prefix}{message}") + def _test_connection(self) -> None: """Test database connection on initialization""" try: conn = self._get_connection() if conn: conn.close() - _log("INFO", f"Connected to Sonarr {self.db_type} database successfully") + self._log("INFO", f"Connected to Sonarr {self.db_type} database successfully") else: raise Exception("Failed to create connection") except Exception as e: - _log("ERROR", f"Failed to connect to Sonarr database: {e}") + self._log("ERROR", f"Failed to connect to Sonarr database: {e}") raise def _get_connection(self) -> Union[sqlite3.Connection, psycopg2.extensions.connection]: """Get database connection""" if self.db_type == "sqlite": + # sqlite3.connect() silently creates an empty file at db_path if it + # doesn't exist — a missing/wrong volume mount would otherwise look + # like a successful connection to an empty database instead of failing. + if not self.db_path or not Path(self.db_path).exists(): + raise FileNotFoundError( + f"Sonarr SQLite database not found at '{self.db_path}' — check volume mounts" + ) conn = sqlite3.connect(self.db_path) conn.row_factory = sqlite3.Row return conn @@ -159,7 +180,7 @@ def get_series_by_imdb(self, imdb_id: str) -> Optional[Dict[str, Any]]: return dict(row) if self.db_type == "sqlite" else row except Exception as e: - _log("ERROR", f"Database query error for IMDb {imdb_id}: {e}") + self._log("ERROR", f"Database query error for IMDb {imdb_id}: {e}") return None @@ -198,7 +219,7 @@ def get_all_series(self) -> List[Dict[str, Any]]: return rows except Exception as e: - _log("ERROR", f"Database query error getting all series: {e}") + self._log("ERROR", f"Database query error getting all series: {e}") return [] def get_all_episodes_for_series(self, series_id: int) -> List[Dict[str, Any]]: @@ -246,7 +267,7 @@ def get_all_episodes_for_series(self, series_id: int) -> List[Dict[str, Any]]: return rows except Exception as e: - _log("ERROR", f"Database query error for series {series_id}: {e}") + self._log("ERROR", f"Database query error for series {series_id}: {e}") return [] def get_episode_import_date(self, episode_id: int) -> Tuple[Optional[str], str]: @@ -296,7 +317,7 @@ def get_episode_import_date(self, episode_id: int) -> Tuple[Optional[str], str]: return date_iso, "sonarr:db.history.import" except Exception as e: - _log("ERROR", f"Database query error for episode {episode_id}: {e}") + self._log("ERROR", f"Database query error for episode {episode_id}: {e}") return None, "sonarr:db.no_import_found" @@ -361,7 +382,7 @@ def get_episode_file_date(self, series_id: int, season: int, episode: int) -> Op return dt.astimezone(timezone.utc).isoformat(timespec="seconds") except Exception as e: - _log("ERROR", f"Database query error for episode file: {e}") + self._log("ERROR", f"Database query error for episode file: {e}") return None @@ -421,7 +442,7 @@ def bulk_import_dates_for_series(self, series_id: int) -> Dict[Tuple[int, int], results[(season, episode)] = (None, "sonarr:db.bulk.no_import") except Exception as e: - _log("ERROR", f"Bulk query error for series {series_id}: {e}") + self._log("ERROR", f"Bulk query error for series {series_id}: {e}") return results @@ -448,7 +469,7 @@ def get_database_stats(self) -> Dict[str, Any]: stats[stat_name] = result[0] if result else 0 except Exception as e: - _log("ERROR", f"Stats query error: {e}") + self._log("ERROR", f"Stats query error: {e}") stats["error"] = str(e) return stats @@ -571,7 +592,7 @@ def health_check(self) -> Dict[str, Any]: health["status"] = "error" health["connection"] = "failed" health["issues"].append(f"Connection failed: {e}") - _log("ERROR", f"Database health check failed: {e}") + self._log("ERROR", f"Database health check failed: {e}") # Overall status if health["issues"]: diff --git a/config/env_writer.py b/config/env_writer.py new file mode 100644 index 0000000..17fb718 --- /dev/null +++ b/config/env_writer.py @@ -0,0 +1,278 @@ +""" +Env file writer for the setup wizard. + +Everything the wizard adds goes through here — turning a form submission +into env var names, and writing those into .env / .env.secrets a few keys +at a time without disturbing anything else already in either file. Nothing +in this module talks to the network or a database; it's just the +file-writing half of "add an instance". The actual connection testing and +name-collision checks against the live registry happen in the route +handler, before build_env_updates()/upsert_env_file() are ever called — +by the time we're writing, everything should already be validated. +""" +import json +import re +from datetime import datetime, timezone +from pathlib import Path +from typing import Dict, List, Optional, Tuple + + +# Env var suffixes that are secrets and always belong in .env.secrets, +# never .env. Keep this in sync with what _load_radarr_instance / +# _load_sonarr_instance in config/settings.py actually read — if a new +# secret-shaped field gets added there, it needs to be added here too. +SECRET_SUFFIXES = ("API_KEY", "DB_PASSWORD") + +# Same reserved segments settings.py already refuses to treat as instance +# names (RADARR_DB_* and RADARR_WEBHOOK_* aren't instances called "DB" or +# "WEBHOOK"). Duplicated here rather than imported so this module has no +# dependency on settings.py loading environment variables at import time. +RESERVED_NAME_SEGMENTS = {"DB", "WEBHOOK"} + +# Letters, digits, underscores only — no hyphens. This becomes part of an +# env var name and a URL path segment (the webhook route), so it has to be +# shell- and URL-safe. Same rule the multi-instance docs already spell out +# for people naming instances by hand. +_NAME_SEGMENT_RE = re.compile(r"^[A-Za-z0-9_]+$") + + +class InstanceNameError(ValueError): + """A user-supplied instance name isn't safe to use as an env var segment.""" + + +def validate_name_segment(raw_name: str, existing_names: set, media_type: str, require_exists: bool = False) -> str: + """Turn a user-typed instance name into a validated env var name segment. + + Uppercases it (env vars are conventionally upper-case), then checks the + character set, the reserved-word list, and whether it collides with an + instance that's already running. + + existing_names should come from the live InstanceRegistry, not just + whatever's currently in .env — someone may have hand-edited the file + since the last restart, and the registry is what's actually in use. + Those are full instance names (e.g. "sonarr_strm"), not bare segments + (e.g. "strm") — media_type is what lets this function build the same + full name to compare against, the way instance_name is built everywhere + else in the wizard (f"{media_type}_{segment.lower()}"). + + require_exists flips the collision check: normally a name must NOT + already exist (adding a new instance is the default assumption); with + require_exists=True it must ALREADY exist instead — used when editing + or deleting a specific instance, where the opposite mistake (a typo'd + name matching nothing) is the one worth catching. + """ + name_segment = raw_name.strip().upper() + + if not name_segment: + raise InstanceNameError("Instance name can't be empty") + + if not _NAME_SEGMENT_RE.match(name_segment): + raise InstanceNameError( + "Instance name can only contain letters, numbers, and underscores — " + "no hyphens or spaces. This becomes part of an env var name and a " + "webhook URL, so it has to stay simple." + ) + + if name_segment in RESERVED_NAME_SEGMENTS: + raise InstanceNameError(f"'{name_segment}' is a reserved word and can't be used as an instance name") + + full_name = f"{media_type}_{name_segment.lower()}" + exists = full_name in existing_names + if require_exists and not exists: + raise InstanceNameError(f"No instance named '{full_name}' exists to edit or delete") + if not require_exists and exists: + raise InstanceNameError(f"An instance named '{full_name}' already exists") + + return name_segment + + +def build_env_updates( + media_type: str, name_segment: str, fields: Dict[str, object] +) -> Tuple[Dict[str, str], Dict[str, str]]: + """Turn a wizard form submission into the env vars it becomes. + + media_type is "radarr" or "sonarr". fields is whatever the form + collected — only the known field names below are ever read, so a stray + key in the request body can't sneak an arbitrary env var into either + file. name_segment == "" means the default instance (RADARR_URL rather + than RADARR_4K_URL). + + Returns (env_updates, secret_updates), two plain {KEY: value} dicts + ready to hand to upsert_env_file() — one per file. + """ + prefix = f"{media_type.upper()}_{name_segment}_" if name_segment else f"{media_type.upper()}_" + + # Radarr and Sonarr each only have one of these — asking for both would + # be a caller bug, not something worth silently tolerating. + path_field = "movie_paths" if media_type == "radarr" else "tv_paths" + path_var = "MOVIE_PATHS" if media_type == "radarr" else "TV_PATHS" + + field_to_suffix = { + "url": "URL", + "api_key": "API_KEY", + "root_folders": "ROOT_FOLDERS", + path_field: path_var, + "db_type": "DB_TYPE", + "db_host": "DB_HOST", + "db_port": "DB_PORT", + "db_name": "DB_NAME", + "db_user": "DB_USER", + "db_password": "DB_PASSWORD", + "db_path": "DB_PATH", + } + + env_updates: Dict[str, str] = {} + secret_updates: Dict[str, str] = {} + + for field_name, suffix in field_to_suffix.items(): + value = fields.get(field_name) + if value in (None, ""): + continue + if isinstance(value, list): + value = ",".join(str(v).strip() for v in value if str(v).strip()) + if not value: + continue + key = f"{prefix}{suffix}" + target = secret_updates if suffix in SECRET_SUFFIXES else env_updates + target[key] = str(value) + + return env_updates, secret_updates + + +def upsert_env_file(path: Path, updates: Dict[str, str], instance_label: str = "") -> bool: + """Write `updates` into the env file at `path`, touching only those keys. + + An existing KEY=value line gets its value replaced in place — every + comment, blank line, and unrelated var is left exactly as it was. Keys + that don't already exist are appended at the end under a small header + comment, so it's obvious later which lines the wizard added versus + what was hand-written. + + Returns True if the file was created or changed, False if every + requested value already matched what was on disk. + """ + if not updates: + return False + + remaining = dict(updates) # don't mutate the caller's dict as we consume it + lines: List[str] = path.read_text().splitlines() if path.exists() else [] + changed = False + + for i, line in enumerate(lines): + stripped = line.strip() + if not stripped or stripped.startswith("#") or "=" not in line: + continue + key = line.split("=", 1)[0].strip() + if key in remaining: + new_line = f"{key}={remaining.pop(key)}" + if new_line != line: + lines[i] = new_line + changed = True + + # Anything still left in `remaining` wasn't in the file at all — append it. + if remaining: + if lines and lines[-1].strip(): + lines.append("") + if instance_label: + lines.append(f"# --- {instance_label} (added via setup wizard) ---") + for key, value in remaining.items(): + lines.append(f"{key}={value}") + changed = True + + if changed: + path.write_text("\n".join(lines) + "\n") + + return changed + + +def remove_instance_keys(path: Path, prefix: str, instance_label: str = "") -> bool: + """Remove every KEY=value line whose key starts with `prefix` from the file. + + This is the delete half of the wizard — the mirror of upsert_env_file(). + `prefix` is the same "SONARR_STRM_" shape build_env_updates() already + builds keys with, so a delete removes exactly what an add would have + written, no more. Also drops the wizard's own "# --- name (added via + setup wizard) ---" header line for this instance if present — anything + else in the file, including other comments, is left untouched. + + Returns True if anything was actually removed, False if the file had + nothing matching (deleting an instance that was never in this file, or + was hand-written under a different naming convention). + """ + if not path.exists(): + return False + + lines = path.read_text().splitlines() + kept: List[str] = [] + changed = False + header_marker = f"# --- {instance_label} (" if instance_label else None + + for line in lines: + stripped = line.strip() + if header_marker and stripped.startswith(header_marker): + changed = True + continue + if stripped and not stripped.startswith("#") and "=" in line: + key = line.split("=", 1)[0].strip() + if key.startswith(prefix): + changed = True + continue + kept.append(line) + + if changed: + path.write_text("\n".join(kept) + ("\n" if kept else "")) + + return changed + + +def read_env_files(env_path: Path, secrets_path: Path) -> Dict[str, str]: + """Read both files' raw text, for a backup. A missing file comes back as "". + + Deliberately just the raw text, not parsed key/value pairs — a backup + should round-trip exactly, comments and formatting included, not just + the values. + """ + return { + "env": env_path.read_text() if env_path.exists() else "", + "env_secrets": secrets_path.read_text() if secrets_path.exists() else "", + } + + +def write_env_files(env_path: Path, secrets_path: Path, env_content: str, secrets_content: str) -> None: + """Overwrite both files verbatim — this is what restoring a backup does. + + Unlike upsert_env_file(), nothing is merged here: whatever text is + passed in becomes the entire file. Call backup_env_files() first if + the current content is worth keeping, which the wizard's restore + endpoint always does. + """ + env_path.write_text(env_content) + secrets_path.write_text(secrets_content) + + +def backup_env_files(env_path: Path, secrets_path: Path, backups_dir: Path) -> Optional[Path]: + """Snapshot both files' current content into backups_dir, before something overwrites them. + + Same JSON shape a manual backup download uses, so a snapshot taken here + can be fed straight back into a restore if needed. Returns the path to + the snapshot, or None if neither file exists yet — nothing to back up + on a fresh install. + """ + if not env_path.exists() and not secrets_path.exists(): + return None + + backups_dir.mkdir(parents=True, exist_ok=True) + timestamp = datetime.now(timezone.utc).strftime("%Y%m%d-%H%M%S") + snapshot_path = backups_dir / f"env-backup-{timestamp}.json" + + # Two snapshots requested in the same second would collide — add a + # counter suffix rather than silently overwriting an earlier one. + counter = 1 + while snapshot_path.exists(): + snapshot_path = backups_dir / f"env-backup-{timestamp}-{counter}.json" + counter += 1 + + snapshot = {"exported_at": datetime.now(timezone.utc).isoformat(), **read_env_files(env_path, secrets_path)} + snapshot_path.write_text(json.dumps(snapshot, indent=2)) + + return snapshot_path diff --git a/config/settings.py b/config/settings.py index 86ae966..bbe3093 100644 --- a/config/settings.py +++ b/config/settings.py @@ -5,6 +5,7 @@ import os import sys import logging +from dataclasses import dataclass, field from pathlib import Path from typing import List, Optional, Dict, Any @@ -14,6 +15,47 @@ logger = logging.getLogger(__name__) +# Reserved env var segments that are NOT instance names +_RADARR_RESERVED = {"DB", "WEBHOOK"} +_SONARR_RESERVED = {"DB", "WEBHOOK"} + + +@dataclass +class RadarrInstance: + """Configuration for one Radarr instance""" + name: str # "radarr" for default, "radarr_4k" for RADARR_4K_* + url: str + api_key: str + root_folders: List[str] + movie_paths: List[str] + webhook_path: str # e.g. "/radarr/webhook" or "/radarr_4k/webhook" + db_type: str = "" # "postgresql", "sqlite", or "" (API-only) + db_host: str = "" + db_port: int = 5432 + db_name: str = "" + db_user: str = "" + db_password: str = "" + db_path: str = "" # sqlite only + + +@dataclass +class SonarrInstance: + """Configuration for one Sonarr instance""" + name: str # "sonarr" for default, "sonarr_4k" for SONARR_4K_* + url: str + api_key: str + root_folders: List[str] + tv_paths: List[str] + webhook_path: str # e.g. "/sonarr/webhook" or "/sonarr_4k/webhook" + db_type: str = "" + db_host: str = "" + db_port: int = 5432 + db_name: str = "" + db_user: str = "" + db_password: str = "" + db_path: str = "" # sqlite only + + def _bool_env(name: str, default: bool) -> bool: """Convert environment variable to boolean""" v = os.environ.get(name) @@ -77,7 +119,10 @@ def _load_configuration(self) -> None: # External connections self._load_external_connections() - + + # Warn if any discovered instance has no paths at all + self._warn_missing_instance_paths() + # Movie processing self._load_movie_settings() @@ -88,39 +133,21 @@ def _load_configuration(self) -> None: self._load_auth_settings() def _load_paths(self) -> None: - """Load and validate path configuration""" - tv_paths_env = os.environ.get("TV_PATHS", "") + """Load global path fallbacks. + + MOVIE_PATHS and TV_PATHS are optional global fallbacks used when an + instance does not define its own per-instance paths variable + (RADARR_{NAME}_MOVIE_PATHS / SONARR_{NAME}_TV_PATHS). + + For single-instance setups these remain the simplest approach. + For multi-instance setups, define paths per-instance so each block + is fully self-contained and there is no risk of one definition + silently overriding another (Docker env_file last-definition-wins). + """ movie_paths_env = os.environ.get("MOVIE_PATHS", "") - - if not tv_paths_env: - raise ConfigurationError( - setting="TV_PATHS", - reason="TV_PATHS environment variable is required but not set" - ) - - if not movie_paths_env: - raise ConfigurationError( - setting="MOVIE_PATHS", - reason="MOVIE_PATHS environment variable is required but not set" - ) - - # Parse paths - self.tv_paths = [Path(p.strip()) for p in tv_paths_env.split(",") if p.strip()] + tv_paths_env = os.environ.get("TV_PATHS", "") self.movie_paths = [Path(p.strip()) for p in movie_paths_env.split(",") if p.strip()] - - if not self.tv_paths: - raise ConfigurationError( - setting="TV_PATHS", - reason="No valid TV paths found after parsing", - current_value=tv_paths_env - ) - - if not self.movie_paths: - raise ConfigurationError( - setting="MOVIE_PATHS", - reason="No valid movie paths found after parsing", - current_value=movie_paths_env - ) + self.tv_paths = [Path(p.strip()) for p in tv_paths_env.split(",") if p.strip()] def _load_server_settings(self) -> None: """Load server configuration""" @@ -134,21 +161,198 @@ def _load_server_settings(self) -> None: def _load_external_connections(self) -> None: """Load external API and database connection settings""" - # API URLs - self.radarr_url = os.environ.get("RADARR_URL", "") - self.sonarr_url = os.environ.get("SONARR_URL", "") + # Discover all Radarr and Sonarr instances from env + self.radarr_instances: List[RadarrInstance] = self._discover_radarr_instances() + self.sonarr_instances: List[SonarrInstance] = self._discover_sonarr_instances() + + # Backward-compat shims — point at the first (default) instance if present + self.radarr_url = self.radarr_instances[0].url if self.radarr_instances else "" + self.sonarr_url = self.sonarr_instances[0].url if self.sonarr_instances else "" + self.radarr_db_type = self.radarr_instances[0].db_type if self.radarr_instances else "" + self.jellyseerr_url = os.environ.get("JELLYSEERR_URL", "") - - # Radarr database settings - self.radarr_db_type = os.environ.get("RADARR_DB_TYPE", "").lower() - self.radarr_db_host = os.environ.get("RADARR_DB_HOST", "") - self.radarr_db_port = self._get_int_env("RADARR_DB_PORT", 5432, 1, 65535) - self.radarr_db_name = os.environ.get("RADARR_DB_NAME", "") - self.radarr_db_user = os.environ.get("RADARR_DB_USER", "") - + # Timeout settings self.timeout_seconds = self._get_int_env("TIMEOUT_SECONDS", 45, 10, 300) - + + # ------------------------------------------------------------------ + # Instance discovery helpers + # ------------------------------------------------------------------ + + def _load_radarr_instance(self, name_segment: str, url: str) -> RadarrInstance: + """Build a RadarrInstance from env vars for the given name segment. + + name_segment is the part between RADARR_ and _URL, e.g. "4K" for + RADARR_4K_URL. Empty string means the default (RADARR_URL) instance. + """ + prefix = f"RADARR_{name_segment}_" if name_segment else "RADARR_" + instance_name = f"radarr_{name_segment.lower()}" if name_segment else "radarr" + webhook_path = f"/{instance_name}/webhook" + + root_folders = [ + p.strip() + for p in os.environ.get(f"{prefix}ROOT_FOLDERS", "").split(",") + if p.strip() + ] + movie_paths = [ + p.strip() + for p in os.environ.get(f"{prefix}MOVIE_PATHS", + os.environ.get("MOVIE_PATHS", "")).split(",") + if p.strip() + ] + + db_type = os.environ.get(f"{prefix}DB_TYPE", "").lower() + db_port_str = os.environ.get(f"{prefix}DB_PORT", "5432") + try: + db_port = int(db_port_str) + except ValueError: + db_port = 5432 + + return RadarrInstance( + name=instance_name, + url=url, + api_key=os.environ.get(f"{prefix}API_KEY", ""), + root_folders=root_folders, + movie_paths=movie_paths, + webhook_path=webhook_path, + db_type=db_type, + db_host=os.environ.get(f"{prefix}DB_HOST", ""), + db_port=db_port, + db_name=os.environ.get(f"{prefix}DB_NAME", ""), + db_user=os.environ.get(f"{prefix}DB_USER", ""), + db_password=os.environ.get(f"{prefix}DB_PASSWORD", ""), + db_path=os.environ.get(f"{prefix}DB_PATH", ""), + ) + + def _discover_radarr_instances(self) -> List[RadarrInstance]: + """Discover all configured Radarr instances from environment variables. + + Looks for RADARR_URL (default instance) and RADARR_{NAME}_URL (named + instances). The default instance is always first in the returned list. + """ + instances = [] + + # Default instance + default_url = os.environ.get("RADARR_URL", "") + if default_url: + instances.append(self._load_radarr_instance("", default_url)) + + # Named instances — scan for RADARR_*_URL + seen = set() + for key in sorted(os.environ.keys()): + if not key.startswith("RADARR_") or not key.endswith("_URL"): + continue + if key == "RADARR_URL": + continue + name_segment = key[len("RADARR_"):-len("_URL")] + # Skip reserved segments (DB, WEBHOOK) and duplicates + if name_segment in _RADARR_RESERVED or name_segment in seen: + continue + seen.add(name_segment) + url = os.environ[key] + if url: + instances.append(self._load_radarr_instance(name_segment, url)) + + return instances + + def _load_sonarr_instance(self, name_segment: str, url: str) -> SonarrInstance: + """Build a SonarrInstance from env vars for the given name segment.""" + prefix = f"SONARR_{name_segment}_" if name_segment else "SONARR_" + instance_name = f"sonarr_{name_segment.lower()}" if name_segment else "sonarr" + webhook_path = f"/{instance_name}/webhook" + + root_folders = [ + p.strip() + for p in os.environ.get(f"{prefix}ROOT_FOLDERS", "").split(",") + if p.strip() + ] + tv_paths = [ + p.strip() + for p in os.environ.get(f"{prefix}TV_PATHS", + os.environ.get("TV_PATHS", "")).split(",") + if p.strip() + ] + + db_type = os.environ.get(f"{prefix}DB_TYPE", "").lower() + db_port_str = os.environ.get(f"{prefix}DB_PORT", "5432") + try: + db_port = int(db_port_str) + except ValueError: + db_port = 5432 + + return SonarrInstance( + name=instance_name, + url=url, + api_key=os.environ.get(f"{prefix}API_KEY", ""), + root_folders=root_folders, + tv_paths=tv_paths, + webhook_path=webhook_path, + db_type=db_type, + db_host=os.environ.get(f"{prefix}DB_HOST", ""), + db_port=db_port, + db_name=os.environ.get(f"{prefix}DB_NAME", ""), + db_user=os.environ.get(f"{prefix}DB_USER", ""), + db_password=os.environ.get(f"{prefix}DB_PASSWORD", ""), + db_path=os.environ.get(f"{prefix}DB_PATH", ""), + ) + + def _discover_sonarr_instances(self) -> List[SonarrInstance]: + """Discover all configured Sonarr instances from environment variables.""" + instances = [] + + default_url = os.environ.get("SONARR_URL", "") + if default_url: + instances.append(self._load_sonarr_instance("", default_url)) + + seen = set() + for key in sorted(os.environ.keys()): + if not key.startswith("SONARR_") or not key.endswith("_URL"): + continue + if key == "SONARR_URL": + continue + name_segment = key[len("SONARR_"):-len("_URL")] + if name_segment in _SONARR_RESERVED or name_segment in seen: + continue + seen.add(name_segment) + url = os.environ[key] + if url: + instances.append(self._load_sonarr_instance(name_segment, url)) + + return instances + + def _warn_missing_instance_paths(self) -> None: + """Warn at startup if any configured instance has no paths. + + An instance with empty movie_paths / tv_paths cannot match file + paths to media items — date assignment from the DB will still work, + but any path-based lookup will silently find nothing. + + Each instance should define its own paths variable: + RADARR_{NAME}_MOVIE_PATHS (or RADARR_MOVIE_PATHS for the default) + SONARR_{NAME}_TV_PATHS (or SONARR_TV_PATHS for the default) + + MOVIE_PATHS / TV_PATHS act as a global fallback when no per-instance + variable is set. + """ + for inst in self.radarr_instances: + if not inst.movie_paths: + logger.warning( + "Radarr instance '%s' has no movie paths configured. " + "Set %s_MOVIE_PATHS in your .env (or MOVIE_PATHS as a " + "global fallback). Path matching will not work for this instance.", + inst.name, + inst.name.upper(), + ) + for inst in self.sonarr_instances: + if not inst.tv_paths: + logger.warning( + "Sonarr instance '%s' has no TV paths configured. " + "Set %s_TV_PATHS in your .env (or TV_PATHS as a " + "global fallback). Path matching will not work for this instance.", + inst.name, + inst.name.upper(), + ) + def _load_movie_settings(self) -> None: """Load movie processing settings""" self.movie_priority = os.environ.get("MOVIE_PRIORITY", "import_then_digital").lower() diff --git a/core/database.py b/core/database.py index 0049c7b..704266a 100644 --- a/core/database.py +++ b/core/database.py @@ -4,6 +4,7 @@ Handles database operations for tracking media dates and processing history """ import json +import os import threading from datetime import datetime from typing import Optional, Dict, List, Any @@ -16,12 +17,6 @@ class ChronarrDatabase: """PostgreSQL database manager for Chronarr media tracking and processing history""" def __init__(self, config): - """ - Initialize PostgreSQL database connection - - Args: - config: Configuration object with database settings - """ if not config: raise ValueError("PostgreSQL configuration is required") self.db_host = config.db_host @@ -72,32 +67,29 @@ def get_connection(self): raise def _init_database(self): - """Initialize PostgreSQL database tables""" with self.get_connection() as conn: cursor = conn.cursor() self._init_postgresql_tables(cursor) - - # Test the connection works and verify autocommit - cursor.execute("SELECT 1") - print(f"✅ PostgreSQL database initialized and connection verified") - print(f"🔍 Autocommit status: {conn.autocommit}") def _init_postgresql_tables(self, cursor): - """Initialize database tables""" - # Series table + # Series — instance is part of the PK so two different Sonarr instances + # can track the same show independently. cursor.execute(""" CREATE TABLE IF NOT EXISTS series ( - imdb_id VARCHAR(20) PRIMARY KEY, + imdb_id VARCHAR(20) NOT NULL, + instance VARCHAR(100) NOT NULL DEFAULT 'sonarr', path TEXT NOT NULL, last_updated TIMESTAMP NOT NULL, - metadata JSONB + metadata JSONB, + missing_from_source_since TIMESTAMP DEFAULT NULL, + PRIMARY KEY (imdb_id, instance) ) """) - - # Episodes table + cursor.execute(""" CREATE TABLE IF NOT EXISTS episodes ( imdb_id VARCHAR(20) NOT NULL, + instance VARCHAR(100) NOT NULL DEFAULT 'sonarr', season INTEGER NOT NULL, episode INTEGER NOT NULL, aired DATE, @@ -105,69 +97,70 @@ def _init_postgresql_tables(self, cursor): source VARCHAR(100), last_updated TIMESTAMP NOT NULL, has_video_file BOOLEAN DEFAULT FALSE, - PRIMARY KEY (imdb_id, season, episode), - FOREIGN KEY (imdb_id) REFERENCES series(imdb_id) + skipped BOOLEAN DEFAULT FALSE, + skip_reason TEXT, + PRIMARY KEY (imdb_id, season, episode, instance), + FOREIGN KEY (imdb_id, instance) REFERENCES series(imdb_id, instance) ) """) - - # Movies table + cursor.execute(""" CREATE TABLE IF NOT EXISTS movies ( - imdb_id VARCHAR(20) PRIMARY KEY, + imdb_id VARCHAR(20) NOT NULL, + instance VARCHAR(100) NOT NULL DEFAULT 'radarr', title TEXT, year INTEGER, - path TEXT NOT NULL, + path TEXT NOT NULL DEFAULT 'unknown', released DATE, dateadded TIMESTAMP, source VARCHAR(100), last_updated TIMESTAMP NOT NULL, - has_video_file BOOLEAN DEFAULT FALSE + has_video_file BOOLEAN DEFAULT FALSE, + skipped BOOLEAN DEFAULT FALSE, + skip_reason TEXT, + missing_from_source_since TIMESTAMP DEFAULT NULL, + PRIMARY KEY (imdb_id, instance) ) """) - # Add title and year columns if they don't exist (migration for existing databases) + # Migrate existing single-instance databases to the composite-PK schema. + # Runs only when the instance column is absent (first upgrade to v3). cursor.execute(""" DO $$ BEGIN + -- Series: drop the old FK from episodes before touching the series PK. IF NOT EXISTS (SELECT 1 FROM information_schema.columns - WHERE table_name='movies' AND column_name='title') THEN - ALTER TABLE movies ADD COLUMN title TEXT; + WHERE table_name='series' AND column_name='instance') THEN + ALTER TABLE episodes DROP CONSTRAINT IF EXISTS episodes_imdb_id_fkey; + ALTER TABLE series ADD COLUMN instance VARCHAR(100) NOT NULL DEFAULT 'sonarr'; + ALTER TABLE series ADD COLUMN IF NOT EXISTS missing_from_source_since TIMESTAMP DEFAULT NULL; + ALTER TABLE series DROP CONSTRAINT series_pkey; + ALTER TABLE series ADD PRIMARY KEY (imdb_id, instance); END IF; - IF NOT EXISTS (SELECT 1 FROM information_schema.columns - WHERE table_name='movies' AND column_name='year') THEN - ALTER TABLE movies ADD COLUMN year INTEGER; - END IF; - END $$; - """) - # Add skipped and skip_reason columns if they don't exist (migration for skip tracking) - cursor.execute(""" - DO $$ - BEGIN + -- Movies: independent of series. IF NOT EXISTS (SELECT 1 FROM information_schema.columns - WHERE table_name='movies' AND column_name='skipped') THEN - ALTER TABLE movies ADD COLUMN skipped BOOLEAN DEFAULT FALSE; - END IF; - IF NOT EXISTS (SELECT 1 FROM information_schema.columns - WHERE table_name='movies' AND column_name='skip_reason') THEN - ALTER TABLE movies ADD COLUMN skip_reason TEXT; - END IF; - IF NOT EXISTS (SELECT 1 FROM information_schema.columns - WHERE table_name='episodes' AND column_name='skipped') THEN - ALTER TABLE episodes ADD COLUMN skipped BOOLEAN DEFAULT FALSE; - END IF; - IF NOT EXISTS (SELECT 1 FROM information_schema.columns - WHERE table_name='episodes' AND column_name='skip_reason') THEN - ALTER TABLE episodes ADD COLUMN skip_reason TEXT; - END IF; - -- Library sync: track when items were first noticed missing from Radarr/Sonarr - IF NOT EXISTS (SELECT 1 FROM information_schema.columns - WHERE table_name='movies' AND column_name='missing_from_source_since') THEN - ALTER TABLE movies ADD COLUMN missing_from_source_since TIMESTAMP DEFAULT NULL; + WHERE table_name='movies' AND column_name='instance') THEN + ALTER TABLE movies ADD COLUMN instance VARCHAR(100) NOT NULL DEFAULT 'radarr'; + ALTER TABLE movies ADD COLUMN IF NOT EXISTS title TEXT; + ALTER TABLE movies ADD COLUMN IF NOT EXISTS year INTEGER; + ALTER TABLE movies ADD COLUMN IF NOT EXISTS skipped BOOLEAN DEFAULT FALSE; + ALTER TABLE movies ADD COLUMN IF NOT EXISTS skip_reason TEXT; + ALTER TABLE movies ADD COLUMN IF NOT EXISTS missing_from_source_since TIMESTAMP DEFAULT NULL; + ALTER TABLE movies DROP CONSTRAINT movies_pkey; + ALTER TABLE movies ADD PRIMARY KEY (imdb_id, instance); END IF; + + -- Episodes: needs series to have its composite PK in place first. IF NOT EXISTS (SELECT 1 FROM information_schema.columns - WHERE table_name='series' AND column_name='missing_from_source_since') THEN - ALTER TABLE series ADD COLUMN missing_from_source_since TIMESTAMP DEFAULT NULL; + WHERE table_name='episodes' AND column_name='instance') THEN + ALTER TABLE episodes ADD COLUMN instance VARCHAR(100) NOT NULL DEFAULT 'sonarr'; + ALTER TABLE episodes ADD COLUMN IF NOT EXISTS skipped BOOLEAN DEFAULT FALSE; + ALTER TABLE episodes ADD COLUMN IF NOT EXISTS skip_reason TEXT; + ALTER TABLE episodes DROP CONSTRAINT episodes_pkey; + ALTER TABLE episodes ADD PRIMARY KEY (imdb_id, season, episode, instance); + ALTER TABLE episodes ADD CONSTRAINT episodes_series_fk + FOREIGN KEY (imdb_id, instance) REFERENCES series(imdb_id, instance); END IF; END $$; """) @@ -201,7 +194,34 @@ def _init_postgresql_tables(self, cursor): resolved_imdb_id VARCHAR(20) ) """) - + + # Plugin lookup misses — a persisted record of "not found" responses + # from /api/lookup/movie and /api/lookup/episode (the Emby/Jellyfin + # plugin endpoints), so they're reviewable in the web UI instead of + # only existing as a line in chronarr.log that scrolls past during a + # full-library scan. season/episode default to 0 (not NULL) so the + # UNIQUE constraint actually dedupes movie rows — Postgres treats + # each NULL as distinct, which would let every movie miss insert a + # new row instead of upserting one. + cursor.execute(""" + CREATE TABLE IF NOT EXISTS unresolved_lookups ( + id SERIAL PRIMARY KEY, + imdb_id VARCHAR(20) NOT NULL, + media_type VARCHAR(20) NOT NULL, + season INTEGER NOT NULL DEFAULT 0, + episode INTEGER NOT NULL DEFAULT 0, + instance VARCHAR(100), + title TEXT, + reason VARCHAR(30) NOT NULL, + first_seen TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP, + last_seen TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP, + miss_count INTEGER DEFAULT 1, + dismissed BOOLEAN DEFAULT FALSE, + dismissed_at TIMESTAMP, + UNIQUE (imdb_id, media_type, season, episode) + ) + """) + # Scheduled scans table cursor.execute(""" CREATE TABLE IF NOT EXISTS scheduled_scans ( @@ -293,6 +313,8 @@ def _init_postgresql_tables(self, cursor): cursor.execute("CREATE INDEX IF NOT EXISTS idx_missing_imdb_type ON missing_imdb(media_type)") cursor.execute("CREATE INDEX IF NOT EXISTS idx_missing_imdb_resolved ON missing_imdb(resolved)") cursor.execute("CREATE INDEX IF NOT EXISTS idx_missing_imdb_path ON missing_imdb(file_path)") + cursor.execute("CREATE INDEX IF NOT EXISTS idx_unresolved_lookups_dismissed ON unresolved_lookups(dismissed)") + cursor.execute("CREATE INDEX IF NOT EXISTS idx_unresolved_lookups_type ON unresolved_lookups(media_type)") cursor.execute("CREATE INDEX IF NOT EXISTS idx_scheduled_scans_enabled ON scheduled_scans(enabled)") cursor.execute("CREATE INDEX IF NOT EXISTS idx_scheduled_scans_next_run ON scheduled_scans(next_run_at)") cursor.execute("CREATE INDEX IF NOT EXISTS idx_schedule_executions_schedule ON schedule_executions(schedule_id)") @@ -303,73 +325,107 @@ def _init_postgresql_tables(self, cursor): cursor.execute("CREATE INDEX IF NOT EXISTS idx_cleanup_executions_schedule ON cleanup_executions(schedule_id)") cursor.execute("CREATE INDEX IF NOT EXISTS idx_cleanup_executions_status ON cleanup_executions(status)") cursor.execute("CREATE INDEX IF NOT EXISTS idx_cleanup_executions_started ON cleanup_executions(started_at)") - def upsert_series(self, imdb_id: str, path: str, metadata: Optional[Dict] = None): - """Insert or update series record""" + def upsert_series(self, imdb_id: str, path: str, instance: str = 'sonarr', metadata: Optional[Dict] = None): with self.get_connection() as conn: cursor = conn.cursor() + self._auto_migrate_series_on_path_match(cursor, imdb_id, path, instance) timestamp = datetime.utcnow() - cursor.execute(""" - INSERT INTO series (imdb_id, path, last_updated, metadata) - VALUES (%s, %s, %s, %s) - ON CONFLICT (imdb_id) DO UPDATE SET + INSERT INTO series (imdb_id, instance, path, last_updated, metadata) + VALUES (%s, %s, %s, %s, %s) + ON CONFLICT (imdb_id, instance) DO UPDATE SET path = EXCLUDED.path, last_updated = EXCLUDED.last_updated, metadata = EXCLUDED.metadata - """, (imdb_id, path, timestamp, json.dumps(metadata) if metadata else None)) + """, (imdb_id, instance, path, timestamp, json.dumps(metadata) if metadata else None)) + + def _auto_migrate_series_on_path_match(self, cursor, new_imdb_id: str, path: str, instance: str): + """Detect Sonarr silently re-mapping a series' IMDb ID and merge instead of duplicating. + + Common for very new/upcoming titles whose metadata hasn't settled on a + canonical IMDb ID yet - the next sync reports a different imdb_id for + the exact same show. series' PK is (imdb_id, instance), so without + this the upsert below would just create a second row for the "new" ID + and silently fork the episode history between the two. The series + path Sonarr hands us is the stable signal here (it doesn't change + just because a metadata ID got corrected), so a path match under the + same instance but a different imdb_id is treated as proof it's the + same show and merged via the same logic migrate_series_imdb_id() uses + manually - episodes move over, any season/episode that already exists + under the new ID (a genuine collision between the two, not just + happenstance) is dropped rather than left orphaned under a dead ID. + """ + if not path: + return + cursor.execute( + "SELECT imdb_id FROM series WHERE instance = %s AND path = %s AND imdb_id != %s", + (instance, path, new_imdb_id) + ) + row = cursor.fetchone() + if not row: + return + old_imdb_id = row['imdb_id'] + _log("INFO", f"[{instance}] Series IMDb ID changed: {old_imdb_id} -> {new_imdb_id} (same path: {path}) — auto-migrating episode history") + + cursor.execute(""" + UPDATE episodes SET imdb_id = %s, skipped = FALSE, skip_reason = NULL + WHERE imdb_id = %s AND instance = %s + AND NOT EXISTS ( + SELECT 1 FROM episodes e2 + WHERE e2.imdb_id = %s AND e2.instance = %s + AND e2.season = episodes.season AND e2.episode = episodes.episode + ) + """, (new_imdb_id, old_imdb_id, instance, new_imdb_id, instance)) + + # Whatever's left under the old ID is a real season/episode collision + # with the new ID — can't move it without violating the PK, and the + # actively-syncing new ID's data is the one to trust. + cursor.execute("DELETE FROM episodes WHERE imdb_id = %s AND instance = %s", (old_imdb_id, instance)) + cursor.execute("DELETE FROM series WHERE imdb_id = %s AND instance = %s", (old_imdb_id, instance)) - def upsert_episode_date(self, imdb_id: str, season: int, episode: int, - aired: Optional[str], dateadded: Optional[str], - source: str, has_video_file: bool = False): - """Insert or update episode date record""" + def upsert_episode_date(self, imdb_id: str, season: int, episode: int, + aired: Optional[str], dateadded: Optional[str], + source: str, has_video_file: bool = False, instance: str = 'sonarr'): with self.get_connection() as conn: cursor = conn.cursor() timestamp = datetime.utcnow() - cursor.execute(""" - INSERT INTO episodes - (imdb_id, season, episode, aired, dateadded, source, has_video_file, last_updated) - VALUES (%s, %s, %s, %s, %s, %s, %s, %s) - ON CONFLICT (imdb_id, season, episode) DO UPDATE SET + INSERT INTO episodes + (imdb_id, instance, season, episode, aired, dateadded, source, has_video_file, last_updated) + VALUES (%s, %s, %s, %s, %s, %s, %s, %s, %s) + ON CONFLICT (imdb_id, season, episode, instance) DO UPDATE SET aired = COALESCE(EXCLUDED.aired, episodes.aired), dateadded = COALESCE(EXCLUDED.dateadded, episodes.dateadded), source = COALESCE(EXCLUDED.source, episodes.source), has_video_file = EXCLUDED.has_video_file, last_updated = EXCLUDED.last_updated - """, (imdb_id, season, episode, aired, dateadded, source, has_video_file, timestamp)) - import os - if os.environ.get("DEBUG", "false").lower() == "true": - print(f"🔍 DEBUG: PostgreSQL upsert executed for {imdb_id} S{season:02d}E{episode:02d}, rows affected: {cursor.rowcount}") + """, (imdb_id, instance, season, episode, aired, dateadded, source, has_video_file, timestamp)) - def upsert_movie(self, imdb_id: str, path: str): - """Insert or update movie record""" + def upsert_movie(self, imdb_id: str, path: str, instance: str = 'radarr'): with self.get_connection() as conn: cursor = conn.cursor() timestamp = datetime.utcnow() - cursor.execute(""" - INSERT INTO movies (imdb_id, path, last_updated) - VALUES (%s, %s, %s) - ON CONFLICT (imdb_id) DO UPDATE SET + INSERT INTO movies (imdb_id, instance, path, last_updated) + VALUES (%s, %s, %s, %s) + ON CONFLICT (imdb_id, instance) DO UPDATE SET path = EXCLUDED.path, last_updated = EXCLUDED.last_updated - """, (imdb_id, path, timestamp)) + """, (imdb_id, instance, path, timestamp)) def upsert_movie_dates(self, imdb_id: str, released: Optional[str], dateadded: Optional[str], source: str, has_video_file: bool = False, - title: Optional[str] = None, year: Optional[int] = None): - """Insert or update movie date record""" - import os - if os.environ.get("DEBUG", "false").lower() == "true": - print(f"🔍 DATABASE UPSERT: imdb_id={imdb_id}, title={title}, dateadded={dateadded}, source={source}") + title: Optional[str] = None, year: Optional[int] = None, + instance: str = 'radarr'): with self.get_connection() as conn: cursor = conn.cursor() timestamp = datetime.utcnow() - cursor.execute(""" - INSERT INTO movies (imdb_id, title, year, path, released, dateadded, source, has_video_file, last_updated) - VALUES (%s, %s, %s, COALESCE((SELECT path FROM movies WHERE imdb_id = %s), 'unknown'), %s, %s, %s, %s, %s) - ON CONFLICT (imdb_id) DO UPDATE SET + INSERT INTO movies (imdb_id, instance, title, year, path, released, dateadded, source, has_video_file, last_updated) + VALUES (%s, %s, %s, %s, + COALESCE((SELECT path FROM movies WHERE imdb_id = %s AND instance = %s), 'unknown'), + %s, %s, %s, %s, %s) + ON CONFLICT (imdb_id, instance) DO UPDATE SET title = COALESCE(EXCLUDED.title, movies.title), year = COALESCE(EXCLUDED.year, movies.year), released = COALESCE(EXCLUDED.released, movies.released), @@ -377,117 +433,161 @@ def upsert_movie_dates(self, imdb_id: str, released: Optional[str], source = COALESCE(EXCLUDED.source, movies.source), has_video_file = EXCLUDED.has_video_file, last_updated = EXCLUDED.last_updated - """, (imdb_id, title, year, imdb_id, released, dateadded, source, has_video_file, timestamp)) - - # Debug: Check what was actually saved - cursor.execute("SELECT dateadded, source FROM movies WHERE imdb_id = %s", (imdb_id,)) - result = cursor.fetchone() - import os - if os.environ.get("DEBUG", "false").lower() == "true": - print(f"🔍 DATABASE VERIFY: After upsert, found dateadded={result['dateadded'] if result else 'NOT_FOUND'}, source={result['source'] if result else 'NOT_FOUND'}") + """, (imdb_id, instance, title, year, imdb_id, instance, released, dateadded, source, has_video_file, timestamp)) - def mark_movie_skipped(self, imdb_id: str, title: str, year: int, path: str, reason: str): - """Mark a movie as skipped with reason""" + def mark_movie_skipped(self, imdb_id: str, title: str, year: int, path: str, reason: str, instance: str = 'radarr'): with self.get_connection() as conn: cursor = conn.cursor() timestamp = datetime.utcnow() cursor.execute(""" - INSERT INTO movies (imdb_id, title, year, path, skipped, skip_reason, has_video_file, last_updated) - VALUES (%s, %s, %s, %s, TRUE, %s, FALSE, %s) - ON CONFLICT (imdb_id) DO UPDATE SET + INSERT INTO movies (imdb_id, instance, title, year, path, skipped, skip_reason, has_video_file, last_updated) + VALUES (%s, %s, %s, %s, %s, TRUE, %s, FALSE, %s) + ON CONFLICT (imdb_id, instance) DO UPDATE SET title = EXCLUDED.title, year = EXCLUDED.year, path = EXCLUDED.path, skipped = TRUE, skip_reason = EXCLUDED.skip_reason, last_updated = EXCLUDED.last_updated - """, (imdb_id, title, year, path, reason, timestamp)) + """, (imdb_id, instance, title, year, path, reason, timestamp)) - def mark_episode_skipped(self, imdb_id: str, season: int, episode: int, reason: str): - """Mark an episode as skipped with reason""" + def mark_episode_skipped(self, imdb_id: str, season: int, episode: int, reason: str, instance: str = 'sonarr'): with self.get_connection() as conn: cursor = conn.cursor() timestamp = datetime.utcnow() cursor.execute(""" - INSERT INTO episodes (imdb_id, season, episode, skipped, skip_reason, has_video_file, last_updated) - VALUES (%s, %s, %s, TRUE, %s, FALSE, %s) - ON CONFLICT (imdb_id, season, episode) DO UPDATE SET + INSERT INTO episodes (imdb_id, instance, season, episode, skipped, skip_reason, has_video_file, last_updated) + VALUES (%s, %s, %s, %s, TRUE, %s, FALSE, %s) + ON CONFLICT (imdb_id, season, episode, instance) DO UPDATE SET skipped = TRUE, skip_reason = EXCLUDED.skip_reason, last_updated = EXCLUDED.last_updated - """, (imdb_id, season, episode, reason, timestamp)) + """, (imdb_id, instance, season, episode, reason, timestamp)) - def clear_movie_skipped(self, imdb_id: str): - """Clear skipped flag for a movie""" + def clear_movie_skipped(self, imdb_id: str, instance: str = 'radarr'): with self.get_connection() as conn: cursor = conn.cursor() cursor.execute(""" UPDATE movies SET skipped = FALSE, skip_reason = NULL - WHERE imdb_id = %s - """, (imdb_id,)) + WHERE imdb_id = %s AND instance = %s + """, (imdb_id, instance)) - def clear_episode_skipped(self, imdb_id: str, season: int, episode: int): - """Clear skipped flag for an episode""" + def clear_episode_skipped(self, imdb_id: str, season: int, episode: int, instance: str = 'sonarr'): with self.get_connection() as conn: cursor = conn.cursor() cursor.execute(""" UPDATE episodes SET skipped = FALSE, skip_reason = NULL - WHERE imdb_id = %s AND season = %s AND episode = %s - """, (imdb_id, season, episode)) + WHERE imdb_id = %s AND season = %s AND episode = %s AND instance = %s + """, (imdb_id, season, episode, instance)) def get_skipped_counts(self) -> Dict: - """Get counts of skipped movies and episodes""" + """Total skipped counts across all instances — for dashboard summary.""" with self.get_connection() as conn: cursor = conn.cursor() - - # Count skipped movies cursor.execute("SELECT COUNT(*) as count FROM movies WHERE skipped = TRUE") skipped_movies = cursor.fetchone()['count'] - - # Count skipped episodes cursor.execute("SELECT COUNT(*) as count FROM episodes WHERE skipped = TRUE") skipped_episodes = cursor.fetchone()['count'] - return { 'movies': skipped_movies, 'episodes': skipped_episodes, 'total': skipped_movies + skipped_episodes } - def get_series_episodes(self, imdb_id: str, has_video_file_only: bool = False) -> List[Dict]: - """Get all episodes for a series""" + def get_series_episodes(self, imdb_id: str, instance: str = 'sonarr', has_video_file_only: bool = False) -> List[Dict]: with self.get_connection() as conn: cursor = conn.cursor() - - query = "SELECT * FROM episodes WHERE imdb_id = %s" - params = [imdb_id] + query = "SELECT * FROM episodes WHERE imdb_id = %s AND instance = %s" + params = [imdb_id, instance] if has_video_file_only: query += " AND has_video_file = TRUE" - cursor.execute(query, params) return [dict(row) for row in cursor.fetchall()] - - def get_episode_date(self, imdb_id: str, season: int, episode: int) -> Optional[Dict]: - """Get episode date record""" + + def get_episode_date(self, imdb_id: str, season: int, episode: int, instance: str = 'sonarr') -> Optional[Dict]: with self.get_connection() as conn: cursor = conn.cursor() cursor.execute(""" - SELECT * FROM episodes + SELECT * FROM episodes + WHERE imdb_id = %s AND season = %s AND episode = %s AND instance = %s + """, (imdb_id, season, episode, instance)) + row = cursor.fetchone() + return dict(row) if row else None + + def get_episode_date_any_instance(self, imdb_id: str, season: int, episode: int) -> Optional[Dict]: + """Look up an episode's date without knowing which instance owns it. + + For callers that only have (imdb_id, season, episode) — no instance — + e.g. the Emby/Jellyfin plugin lookup endpoints, which predate + multi-instance and have no instance in their URL. The same IMDb ID + can have independent rows under multiple Sonarr instances (a full + back-catalog under the default instance, a separate pickup under a + named one covering different seasons), so defaulting to 'sonarr' + alone would silently miss any row that only exists under a named + instance. Prefers a row that actually has a dateadded set; among + those, picks deterministically (ordered by instance name) rather + than arbitrarily, so behavior doesn't flap between calls. + """ + with self.get_connection() as conn: + cursor = conn.cursor() + cursor.execute(""" + SELECT * FROM episodes WHERE imdb_id = %s AND season = %s AND episode = %s + ORDER BY (dateadded IS NULL), instance + LIMIT 1 """, (imdb_id, season, episode)) - row = cursor.fetchone() return dict(row) if row else None - - def get_movie_dates(self, imdb_id: str) -> Optional[Dict]: - """Get movie date record""" + + def get_movie_dates(self, imdb_id: str, instance: str = 'radarr') -> Optional[Dict]: with self.get_connection() as conn: cursor = conn.cursor() - cursor.execute("SELECT * FROM movies WHERE imdb_id = %s", (imdb_id,)) - + cursor.execute("SELECT * FROM movies WHERE imdb_id = %s AND instance = %s", (imdb_id, instance)) row = cursor.fetchone() return dict(row) if row else None - + + def get_movie_dates_any_instance(self, imdb_id: str) -> Optional[Dict]: + """Look up a movie's date without knowing which instance owns it. + + Same reasoning as get_episode_date_any_instance() — see there. + """ + with self.get_connection() as conn: + cursor = conn.cursor() + cursor.execute(""" + SELECT * FROM movies + WHERE imdb_id = %s + ORDER BY (dateadded IS NULL), instance + LIMIT 1 + """, (imdb_id,)) + row = cursor.fetchone() + return dict(row) if row else None + + def get_series_title_any_instance(self, imdb_id: str) -> Optional[str]: + """Look up a series' title without knowing which instance owns it. + + series has no title column, and its `metadata` JSONB column — despite + the name suggesting otherwise — is never actually populated; every + upsert_series() call site omits it, so it's always NULL in practice. + (Confirmed live: production logs showed every episode lookup missing + its title even on a "found" result.) The only title-shaped thing + Chronarr actually has on hand is the series directory name, which + follows the same " [imdb-ttXXXXXXX]" convention the directory + scan in find_media_path_by_imdb_and_title() already depends on — so + derive it from `path` instead. + """ + from utils.file_utils import extract_title_from_directory_name + from pathlib import Path + + with self.get_connection() as conn: + cursor = conn.cursor() + cursor.execute(""" + SELECT path FROM series WHERE imdb_id = %s ORDER BY instance LIMIT 1 + """, (imdb_id,)) + row = cursor.fetchone() + if not row or not row.get('path'): + return None + return extract_title_from_directory_name(Path(row['path']).name) + def add_processing_history(self, imdb_id: str, media_type: str, event_type: str, details: Optional[Dict] = None): """Add processing history entry""" with self.get_connection() as conn: @@ -498,79 +598,65 @@ def add_processing_history(self, imdb_id: str, media_type: str, event_type: str, """, (imdb_id, media_type, event_type, datetime.utcnow().isoformat(), json.dumps(details) if details else None)) - def migrate_movie_imdb_id(self, old_imdb_id: str, new_imdb_id: str) -> bool: - """Migrate a movie from placeholder IMDb ID to real IMDb ID""" + def migrate_movie_imdb_id(self, old_imdb_id: str, new_imdb_id: str, instance: str = 'radarr') -> bool: + """Replace a placeholder IMDb ID with the real one, preserving all other data.""" with self.get_connection() as conn: cursor = conn.cursor() - # Check if old record exists - cursor.execute("SELECT * FROM movies WHERE imdb_id = %s", (old_imdb_id,)) + cursor.execute("SELECT * FROM movies WHERE imdb_id = %s AND instance = %s", (old_imdb_id, instance)) old_record = cursor.fetchone() if not old_record: return False old_data = dict(old_record) - # Check if new IMDb ID already exists - cursor.execute("SELECT * FROM movies WHERE imdb_id = %s", (new_imdb_id,)) + cursor.execute("SELECT * FROM movies WHERE imdb_id = %s AND instance = %s", (new_imdb_id, instance)) if cursor.fetchone(): - # New IMDb ID already exists, just delete the old one - cursor.execute("DELETE FROM movies WHERE imdb_id = %s", (old_imdb_id,)) + cursor.execute("DELETE FROM movies WHERE imdb_id = %s AND instance = %s", (old_imdb_id, instance)) return True - # Create new record with correct IMDb ID cursor.execute(""" - INSERT INTO movies (imdb_id, title, year, path, released, dateadded, source, + INSERT INTO movies (imdb_id, instance, title, year, path, released, dateadded, source, has_video_file, last_updated, skipped, skip_reason) - VALUES (%s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s) - """, (new_imdb_id, old_data.get('title'), old_data.get('year'), + VALUES (%s, %s, %s, %s, %s, %s, %s, %s, %s, %s, FALSE, NULL) + """, (new_imdb_id, instance, old_data.get('title'), old_data.get('year'), old_data.get('path'), old_data.get('released'), old_data.get('dateadded'), - old_data.get('source'), old_data.get('has_video_file'), - datetime.utcnow(), False, None)) # Clear skipped status + old_data.get('source'), old_data.get('has_video_file'), datetime.utcnow())) - # Delete old placeholder record - cursor.execute("DELETE FROM movies WHERE imdb_id = %s", (old_imdb_id,)) + cursor.execute("DELETE FROM movies WHERE imdb_id = %s AND instance = %s", (old_imdb_id, instance)) return True - def migrate_series_imdb_id(self, old_imdb_id: str, new_imdb_id: str) -> bool: - """Migrate a series and all its episodes from placeholder IMDb ID to real IMDb ID""" + def migrate_series_imdb_id(self, old_imdb_id: str, new_imdb_id: str, instance: str = 'sonarr') -> bool: + """Replace a placeholder series IMDb ID with the real one, migrating all episodes.""" with self.get_connection() as conn: cursor = conn.cursor() - # Check if old series exists - cursor.execute("SELECT * FROM series WHERE imdb_id = %s", (old_imdb_id,)) + cursor.execute("SELECT * FROM series WHERE imdb_id = %s AND instance = %s", (old_imdb_id, instance)) old_series = cursor.fetchone() if not old_series: return False old_series_data = dict(old_series) - # Check if new series IMDb ID already exists - cursor.execute("SELECT * FROM series WHERE imdb_id = %s", (new_imdb_id,)) + cursor.execute("SELECT * FROM series WHERE imdb_id = %s AND instance = %s", (new_imdb_id, instance)) if cursor.fetchone(): - # New series already exists, migrate episodes and delete old series - cursor.execute(""" - UPDATE episodes SET imdb_id = %s WHERE imdb_id = %s - """, (new_imdb_id, old_imdb_id)) - cursor.execute("DELETE FROM series WHERE imdb_id = %s", (old_imdb_id,)) + cursor.execute("UPDATE episodes SET imdb_id = %s WHERE imdb_id = %s AND instance = %s", + (new_imdb_id, old_imdb_id, instance)) + cursor.execute("DELETE FROM series WHERE imdb_id = %s AND instance = %s", (old_imdb_id, instance)) return True - # Create new series record cursor.execute(""" - INSERT INTO series (imdb_id, path, last_updated, metadata) - VALUES (%s, %s, %s, %s) - """, (new_imdb_id, old_series_data.get('path'), + INSERT INTO series (imdb_id, instance, path, last_updated, metadata) + VALUES (%s, %s, %s, %s, %s) + """, (new_imdb_id, instance, old_series_data.get('path'), datetime.utcnow(), old_series_data.get('metadata'))) - # Migrate all episodes to new series IMDb ID and clear skipped status cursor.execute(""" - UPDATE episodes - SET imdb_id = %s, skipped = FALSE, skip_reason = NULL - WHERE imdb_id = %s - """, (new_imdb_id, old_imdb_id)) + UPDATE episodes SET imdb_id = %s, skipped = FALSE, skip_reason = NULL + WHERE imdb_id = %s AND instance = %s + """, (new_imdb_id, old_imdb_id, instance)) - # Delete old placeholder series - cursor.execute("DELETE FROM series WHERE imdb_id = %s", (old_imdb_id,)) + cursor.execute("DELETE FROM series WHERE imdb_id = %s AND instance = %s", (old_imdb_id, instance)) return True def get_stats(self) -> Dict[str, Any]: @@ -616,182 +702,99 @@ def get_stats(self) -> Dict[str, Any]: "database_type": "postgresql" } - def delete_episode(self, imdb_id: str, season: int, episode: int) -> bool: - """ - Delete a specific episode from the database - - Args: - imdb_id: Series IMDb ID - season: Season number - episode: Episode number - - Returns: - True if episode was deleted, False if not found - """ + def delete_episode(self, imdb_id: str, season: int, episode: int, instance: str = 'sonarr') -> bool: with self.get_connection() as conn: cursor = conn.cursor() - cursor.execute(""" - DELETE FROM episodes - WHERE imdb_id = %s AND season = %s AND episode = %s - """, (imdb_id, season, episode)) - + DELETE FROM episodes + WHERE imdb_id = %s AND season = %s AND episode = %s AND instance = %s + """, (imdb_id, season, episode, instance)) deleted_count = cursor.rowcount conn.commit() - return deleted_count > 0 - - def delete_series_episodes(self, imdb_id: str) -> int: - """ - Delete all episodes for a series from the database - - Args: - imdb_id: Series IMDb ID - - Returns: - Number of episodes deleted - """ + + def delete_series_episodes(self, imdb_id: str, instance: str = 'sonarr') -> int: with self.get_connection() as conn: cursor = conn.cursor() - - cursor.execute(""" - DELETE FROM episodes - WHERE imdb_id = %s - """, (imdb_id,)) - + cursor.execute("DELETE FROM episodes WHERE imdb_id = %s AND instance = %s", (imdb_id, instance)) deleted_count = cursor.rowcount conn.commit() - return deleted_count def delete_orphaned_episodes(self) -> List[Dict]: - """ - Find and delete episodes that don't have corresponding video files on disk - This requires checking filesystem for each episode, so use carefully - - Returns: - List of deleted episodes with their details + """Delete DB episode rows that have no matching file on disk. Checks filesystem. + + Scoped per (imdb_id, instance): the same IMDb ID can have independent + series/episode rows under multiple Sonarr instances (e.g. a full + back-catalog under the default instance and a separate pickup under + a named one). Without filtering the episode SELECT/DELETE by + instance too, checking one instance's directory listing would delete + another instance's still-present episodes just because they share an + IMDb ID. """ from utils.file_utils import find_episodes_on_disk from pathlib import Path - + deleted_episodes = [] - + with self.get_connection() as conn: cursor = conn.cursor() - - # Get all series with their paths - cursor.execute(""" - SELECT DISTINCT imdb_id, path FROM series - """) - + cursor.execute("SELECT DISTINCT imdb_id, instance, path FROM series") series_list = cursor.fetchall() - + for series in series_list: imdb_id = series['imdb_id'] + instance = series['instance'] series_path = Path(series['path']) - if not series_path.exists(): continue - - # Get episodes on disk + disk_episodes = find_episodes_on_disk(series_path) disk_episode_keys = set(disk_episodes.keys()) - - # Get episodes in database - cursor.execute(""" - SELECT season, episode, dateadded, source - FROM episodes - WHERE imdb_id = %s - """, (imdb_id,)) - - db_episodes = cursor.fetchall() - - # Find orphaned episodes (in DB but not on disk) - for db_episode in db_episodes: - season = db_episode['season'] - episode = db_episode['episode'] - episode_key = (season, episode) - - if episode_key not in disk_episode_keys: - # Episode is orphaned - delete it - cursor.execute(""" - DELETE FROM episodes - WHERE imdb_id = %s AND season = %s AND episode = %s - """, (imdb_id, season, episode)) - + + cursor.execute( + "SELECT season, episode, dateadded, source FROM episodes WHERE imdb_id = %s AND instance = %s", + (imdb_id, instance) + ) + for ep in cursor.fetchall(): + season, episode = ep['season'], ep['episode'] + if (season, episode) not in disk_episode_keys: + cursor.execute( + "DELETE FROM episodes WHERE imdb_id = %s AND instance = %s AND season = %s AND episode = %s", + (imdb_id, instance, season, episode) + ) deleted_episodes.append({ 'imdb_id': imdb_id, + 'instance': instance, 'season': season, 'episode': episode, - 'dateadded': db_episode['dateadded'], - 'source': db_episode['source'], + 'dateadded': ep['dateadded'], + 'source': ep['source'], 'series_path': str(series_path) }) - + conn.commit() - + return deleted_episodes - def delete_movie(self, imdb_id: str) -> bool: - """ - Delete a specific movie from the database - - Args: - imdb_id: Movie IMDb ID - - Returns: - True if movie was deleted, False if not found - """ + def delete_movie(self, imdb_id: str, instance: str = 'radarr') -> bool: with self.get_connection() as conn: cursor = conn.cursor() - - cursor.execute(""" - DELETE FROM movies - WHERE imdb_id = %s - """, (imdb_id,)) - + cursor.execute("DELETE FROM movies WHERE imdb_id = %s AND instance = %s", (imdb_id, instance)) deleted_count = cursor.rowcount conn.commit() - return deleted_count > 0 - - def delete_series(self, imdb_id: str) -> bool: - """ - Delete a specific series from the database - - Args: - imdb_id: Series IMDb ID - - Returns: - True if series was deleted, False if not found - """ + + def delete_series(self, imdb_id: str, instance: str = 'sonarr') -> bool: with self.get_connection() as conn: cursor = conn.cursor() - - cursor.execute(""" - DELETE FROM series - WHERE imdb_id = %s - """, (imdb_id,)) - + cursor.execute("DELETE FROM series WHERE imdb_id = %s AND instance = %s", (imdb_id, instance)) deleted_count = cursor.rowcount conn.commit() - return deleted_count > 0 def update_movie_file_info(self, imdb_id: str, path: str, has_video_file: bool = True) -> bool: - """ - Update path and video file status for an existing movie - Used when population finds a video file for a manually-added movie - - Args: - imdb_id: Movie IMDb ID - path: File path to the video file - has_video_file: Whether a video file exists (default True) - - Returns: - True if movie was updated, False if not found - """ + """Update path and file status — used when a population scan finds a video for a queued movie.""" with self.get_connection() as conn: cursor = conn.cursor() @@ -842,24 +845,22 @@ def update_episode_file_info(self, imdb_id: str, season: int, episode: int, # ── Library sync helpers ────────────────────────────────────────────────── def get_all_movie_records(self) -> List[Dict]: - """Return all movies with id, title, path, and missing_from_source_since.""" + """Return all movie records including instance — used by library sync.""" with self.get_connection() as conn: cursor = conn.cursor() cursor.execute( - "SELECT imdb_id, title, path, missing_from_source_since FROM movies" + "SELECT imdb_id, instance, title, path, missing_from_source_since FROM movies" ) - rows = cursor.fetchall() - return [dict(r) for r in rows] + return [dict(r) for r in cursor.fetchall()] def get_all_series_records(self) -> List[Dict]: - """Return all series with imdb_id, path, metadata, and missing_from_source_since.""" + """Return all series records including instance — used by library sync.""" with self.get_connection() as conn: cursor = conn.cursor() cursor.execute( - "SELECT imdb_id, path, metadata, missing_from_source_since FROM series" + "SELECT imdb_id, instance, path, metadata, missing_from_source_since FROM series" ) - rows = cursor.fetchall() - return [dict(r) for r in rows] + return [dict(r) for r in cursor.fetchall()] def mark_movies_missing_from_source(self, imdb_ids: List[str], timestamp) -> None: """Set missing_from_source_since for movies not yet marked.""" @@ -938,122 +939,84 @@ def get_series_missing_before(self, cutoff) -> List[Dict]: return [dict(r) for r in cursor.fetchall()] def delete_orphaned_movies(self) -> List[Dict]: - """ - Find and delete movies that don't have corresponding video files on disk - This requires checking filesystem for each movie, so use carefully - - Returns: - List of deleted movies with their details + """Delete DB movie rows whose directory or video files no longer exist on disk. + + Scoped per (imdb_id, instance) — see delete_orphaned_episodes for why: the same + IMDb ID can have independent rows under multiple Radarr instances, and deleting + by imdb_id alone would remove another instance's still-valid row too. """ from pathlib import Path - + deleted_movies = [] - + video_exts = (".mkv", ".mp4", ".avi", ".mov", ".m4v") + with self.get_connection() as conn: cursor = conn.cursor() - - # Get all movies with their paths - cursor.execute(""" - SELECT imdb_id, path, dateadded, source - FROM movies - """) - - movies_list = cursor.fetchall() - - for movie in movies_list: + cursor.execute("SELECT imdb_id, instance, path, dateadded, source FROM movies") + + for movie in cursor.fetchall(): imdb_id = movie['imdb_id'] + instance = movie['instance'] movie_path = Path(movie['path']) - + if not movie_path.exists(): - # Movie directory doesn't exist - delete it - cursor.execute(""" - DELETE FROM movies - WHERE imdb_id = %s - """, (imdb_id,)) - + cursor.execute("DELETE FROM movies WHERE imdb_id = %s AND instance = %s", (imdb_id, instance)) deleted_movies.append({ - 'imdb_id': imdb_id, - 'reason': 'directory_not_found', - 'path': str(movie_path), - 'dateadded': movie['dateadded'], + 'imdb_id': imdb_id, 'instance': instance, 'reason': 'directory_not_found', + 'path': str(movie_path), 'dateadded': movie['dateadded'], 'source': movie['source'] }) continue - - # Check for video files - video_exts = (".mkv", ".mp4", ".avi", ".mov", ".m4v") - has_video = any(f.is_file() and f.suffix.lower() in video_exts - for f in movie_path.iterdir() if f.is_file()) - + + has_video = any( + f.is_file() and f.suffix.lower() in video_exts + for f in movie_path.iterdir() if f.is_file() + ) if not has_video: - # No video files found - delete this movie - cursor.execute(""" - DELETE FROM movies - WHERE imdb_id = %s - """, (imdb_id,)) - + cursor.execute("DELETE FROM movies WHERE imdb_id = %s AND instance = %s", (imdb_id, instance)) deleted_movies.append({ - 'imdb_id': imdb_id, - 'reason': 'no_video_files', - 'path': str(movie_path), - 'dateadded': movie['dateadded'], + 'imdb_id': imdb_id, 'instance': instance, 'reason': 'no_video_files', + 'path': str(movie_path), 'dateadded': movie['dateadded'], 'source': movie['source'] }) - + conn.commit() - + return deleted_movies - + def delete_orphaned_series(self) -> List[Dict]: - """ - Find and delete TV series that don't have corresponding directories on disk - This requires checking filesystem for each series, so use carefully - - Returns: - List of deleted series with their details + """Delete DB series (and all their episodes) whose directory no longer exists on disk. + + Scoped per (imdb_id, instance) — see delete_orphaned_episodes for why. """ from pathlib import Path - + deleted_series = [] - + with self.get_connection() as conn: cursor = conn.cursor() - - # Get all series with their paths - cursor.execute(""" - SELECT imdb_id, path, last_updated, metadata - FROM series - """) - - series_list = cursor.fetchall() - - for series in series_list: + cursor.execute("SELECT imdb_id, instance, path, last_updated, metadata FROM series") + + for series in cursor.fetchall(): imdb_id = series['imdb_id'] + instance = series['instance'] series_path = Path(series['path']) - + if not series_path.exists(): - # Series directory doesn't exist - delete the series and all its episodes - cursor.execute(""" - DELETE FROM episodes - WHERE imdb_id = %s - """, (imdb_id,)) + cursor.execute("DELETE FROM episodes WHERE imdb_id = %s AND instance = %s", (imdb_id, instance)) episodes_deleted = cursor.rowcount - - cursor.execute(""" - DELETE FROM series - WHERE imdb_id = %s - """, (imdb_id,)) - + cursor.execute("DELETE FROM series WHERE imdb_id = %s AND instance = %s", (imdb_id, instance)) deleted_series.append({ 'imdb_id': imdb_id, + 'instance': instance, 'reason': 'directory_not_found', 'path': str(series_path), 'last_updated': series['last_updated'], 'episodes_deleted': episodes_deleted }) - + conn.commit() - + return deleted_series def add_missing_imdb(self, file_path: str, media_type: str, folder_name: str = None, filename: str = None, notes: str = None): @@ -1124,7 +1087,89 @@ def delete_missing_imdb(self, file_path: str) -> bool: conn.commit() return deleted_count > 0 - + + # Unresolved Plugin Lookups Methods + + def record_lookup_miss(self, imdb_id: str, media_type: str, reason: str, + instance: str = None, title: str = None, + season: int = 0, episode: int = 0): + """Record (or bump) a "not found" plugin lookup. + + Upserts on (imdb_id, media_type, season, episode) — a repeat miss + (the common case: a full-library scan re-checks everything every + run) just bumps miss_count/last_seen rather than piling up rows. + Also un-dismisses the row: if something was dismissed as "checked, + nothing to do" and it's still missing on a later scan, that's worth + surfacing again rather than staying silently hidden forever. + """ + with self.get_connection() as conn: + cursor = conn.cursor() + cursor.execute(""" + INSERT INTO unresolved_lookups + (imdb_id, media_type, season, episode, instance, title, reason) + VALUES (%s, %s, %s, %s, %s, %s, %s) + ON CONFLICT (imdb_id, media_type, season, episode) DO UPDATE SET + last_seen = CURRENT_TIMESTAMP, + miss_count = unresolved_lookups.miss_count + 1, + instance = EXCLUDED.instance, + title = EXCLUDED.title, + reason = EXCLUDED.reason, + dismissed = FALSE, + dismissed_at = NULL + """, (imdb_id, media_type, season, episode, instance, title, reason)) + conn.commit() + + def clear_lookup_miss(self, imdb_id: str, media_type: str, season: int = 0, episode: int = 0): + """Remove a miss record once the same lookup succeeds — a fixed item should + just disappear from the list rather than linger as a stale "resolved" row.""" + with self.get_connection() as conn: + cursor = conn.cursor() + cursor.execute(""" + DELETE FROM unresolved_lookups + WHERE imdb_id = %s AND media_type = %s AND season = %s AND episode = %s + """, (imdb_id, media_type, season, episode)) + conn.commit() + + def get_unresolved_lookups(self, include_dismissed: bool = False) -> List[Dict]: + """Get plugin lookup misses, newest-seen first.""" + with self.get_connection() as conn: + cursor = conn.cursor() + query = """ + SELECT id, imdb_id, media_type, season, episode, instance, title, + reason, first_seen, last_seen, miss_count, dismissed, dismissed_at + FROM unresolved_lookups + """ + if not include_dismissed: + query += " WHERE dismissed = FALSE" + query += " ORDER BY last_seen DESC" + cursor.execute(query) + return cursor.fetchall() + + def dismiss_unresolved_lookup(self, lookup_id: int) -> bool: + """Mark a lookup miss as dismissed (snoozed — reappears if it misses again).""" + with self.get_connection() as conn: + cursor = conn.cursor() + cursor.execute(""" + UPDATE unresolved_lookups + SET dismissed = TRUE, dismissed_at = CURRENT_TIMESTAMP + WHERE id = %s + """, (lookup_id,)) + conn.commit() + return cursor.rowcount > 0 + + def dismiss_all_unresolved_lookups(self) -> int: + """Dismiss every currently-active unresolved lookup in one go. Returns the count dismissed.""" + with self.get_connection() as conn: + cursor = conn.cursor() + cursor.execute(""" + UPDATE unresolved_lookups + SET dismissed = TRUE, dismissed_at = CURRENT_TIMESTAMP + WHERE dismissed = FALSE + """) + count = cursor.rowcount + conn.commit() + return count + # Scheduled Scans Methods def create_scheduled_scan(self, name: str, description: str, cron_expression: str, diff --git a/core/database_populator.py b/core/database_populator.py index ec3bbbd..f1515d0 100644 --- a/core/database_populator.py +++ b/core/database_populator.py @@ -23,7 +23,16 @@ class DatabasePopulator: """Populates Chronarr database from Radarr/Sonarr sources""" - def __init__(self, db: ChronarrDatabase, radarr_client: RadarrClient = None, sonarr_client: SonarrClient = None): + def __init__(self, db: ChronarrDatabase, radarr_client: RadarrClient = None, + sonarr_client: SonarrClient = None, + _radarr_db_override=None, _sonarr_db_override=None): + """ + Build a DatabasePopulator. + + Normal callers pass nothing (uses env vars) or pass API client fallbacks. + Per-instance constructors use _radarr_db_override / _sonarr_db_override to + inject a pre-built DB or API client directly, bypassing from_env() discovery. + """ self.db = db # Try database clients first, fall back to API clients @@ -35,57 +44,139 @@ def __init__(self, db: ChronarrDatabase, radarr_client: RadarrClient = None, son self.using_sonarr_db = False # Radarr setup - try: - self.radarr_db = RadarrDbClient.from_env() - if self.radarr_db: - _log("INFO", "DatabasePopulator: Using Radarr direct database access") - self.radarr = self.radarr_db + if _radarr_db_override is not None: + # Pre-built client from from_radarr_instance() — skip env discovery + if isinstance(_radarr_db_override, RadarrDbClient): + self.radarr_db = _radarr_db_override + self.radarr = _radarr_db_override self.using_radarr_db = True + _log("INFO", "DatabasePopulator: Using pre-built Radarr DB client") else: - raise Exception("Database not configured") - except Exception: - self.radarr_api = radarr_client if radarr_client else RadarrClient( - os.environ.get("RADARR_URL", ""), - os.environ.get("RADARR_API_KEY", "") - ) - self.radarr = self.radarr_api - _log("INFO", "DatabasePopulator: Using Radarr API client") + self.radarr_api = _radarr_db_override + self.radarr = _radarr_db_override + _log("INFO", "DatabasePopulator: Using pre-built Radarr API client") + else: + try: + self.radarr_db = RadarrDbClient.from_env() + if self.radarr_db: + _log("INFO", "DatabasePopulator: Using Radarr direct database access") + self.radarr = self.radarr_db + self.using_radarr_db = True + else: + raise Exception("Database not configured") + except Exception: + self.radarr_api = radarr_client if radarr_client else RadarrClient( + os.environ.get("RADARR_URL", ""), + os.environ.get("RADARR_API_KEY", ""), + instance_name="radarr", + ) + self.radarr = self.radarr_api + _log("INFO", "DatabasePopulator: Using Radarr API client") # Sonarr setup - try: - self.sonarr_db = SonarrDbClient.from_env() - if self.sonarr_db: - _log("INFO", "DatabasePopulator: Using Sonarr direct database access") - self.sonarr = self.sonarr_db + if _sonarr_db_override is not None: + # Pre-built client from from_sonarr_instance() — skip env discovery + if isinstance(_sonarr_db_override, SonarrDbClient): + self.sonarr_db = _sonarr_db_override + self.sonarr = _sonarr_db_override self.using_sonarr_db = True + _log("INFO", "DatabasePopulator: Using pre-built Sonarr DB client") else: - raise Exception("Database not configured") - except Exception: - self.sonarr_api = sonarr_client if sonarr_client else SonarrClient( - os.environ.get("SONARR_URL", ""), - os.environ.get("SONARR_API_KEY", "") + self.sonarr_api = _sonarr_db_override + self.sonarr = _sonarr_db_override + _log("INFO", "DatabasePopulator: Using pre-built Sonarr API client") + else: + try: + self.sonarr_db = SonarrDbClient.from_env() + if self.sonarr_db: + _log("INFO", "DatabasePopulator: Using Sonarr direct database access") + self.sonarr = self.sonarr_db + self.using_sonarr_db = True + else: + raise Exception("Database not configured") + except Exception: + self.sonarr_api = sonarr_client if sonarr_client else SonarrClient( + os.environ.get("SONARR_URL", ""), + os.environ.get("SONARR_API_KEY", ""), + instance_name="sonarr", + ) + self.sonarr = self.sonarr_api + _log("INFO", "DatabasePopulator: Using Sonarr API client") + + @classmethod + def from_radarr_instance(cls, inst, db: ChronarrDatabase) -> 'DatabasePopulator': + """Build a populator wired to one specific RadarrInstance. + + If db_type is explicitly configured, DB access is required — a broken + connection (e.g. a misconfigured or unmounted SQLite path) raises here + instead of silently falling back to the API client. Falling back would + degrade every date to a digital_fallback with no indication anything + was wrong. Only instances with no db_type at all use the API client. + """ + if inst.db_type: + client = RadarrDbClient( + db_type=inst.db_type, + db_path=inst.db_path or None, + db_host=inst.db_host or None, + db_port=inst.db_port or None, + db_name=inst.db_name or None, + db_user=inst.db_user or None, + db_password=inst.db_password or None, + instance_name=inst.name, + ) + _log("INFO", f"DatabasePopulator: DB access configured for Radarr instance '{inst.name}'") + return cls(db, _radarr_db_override=client) + client = RadarrClient(inst.url, inst.api_key, instance_name=inst.name) + return cls(db, _radarr_db_override=client) + + @classmethod + def from_sonarr_instance(cls, inst, db: ChronarrDatabase) -> 'DatabasePopulator': + """Build a populator wired to one specific SonarrInstance. + + Same DB-required contract as from_radarr_instance — see its docstring. + """ + if inst.db_type: + client = SonarrDbClient( + db_type=inst.db_type, + db_path=inst.db_path or None, + db_host=inst.db_host or None, + db_port=inst.db_port or None, + db_name=inst.db_name or None, + db_user=inst.db_user or None, + db_password=inst.db_password or None, + instance_name=inst.name, ) - self.sonarr = self.sonarr_api - _log("INFO", "DatabasePopulator: Using Sonarr API client") + _log("INFO", f"DatabasePopulator: DB access configured for Sonarr instance '{inst.name}'") + return cls(db, _sonarr_db_override=client) + client = SonarrClient(inst.url, inst.api_key, instance_name=inst.name) + return cls(db, _sonarr_db_override=client) - def get_episode_import_history(self, episode_id: int) -> Optional[str]: + def get_episode_import_history(self, episode_id: int) -> Tuple[Optional[str], Optional[str]]: """ - Get episode import history from either database or API - Wraps both SonarrDbClient.get_episode_import_date and SonarrClient.get_episode_import_history + Get episode import history from either database or API. + Wraps both SonarrDbClient.get_episode_import_date and SonarrClient.get_episode_import_history. + + Always returns (date_iso, source) now — this used to discard the DB + client's real source string ("sonarr:db.history.import") and let the + caller hardcode "sonarr:api.import_history" regardless of which path + actually ran, mislabeling every DB-sourced date as API-sourced. """ if self.using_sonarr_db and self.sonarr_db: - # Database client returns (date_iso, source) - date_iso, source = self.sonarr_db.get_episode_import_date(episode_id) - return date_iso + # Database client already returns (date_iso, source) + return self.sonarr_db.get_episode_import_date(episode_id) elif self.sonarr_api: - # API client returns Optional[str] - return self.sonarr_api.get_episode_import_history(episode_id) + # API client returns just the date — the source is always the same for it + date_iso = self.sonarr_api.get_episode_import_history(episode_id) + return date_iso, ('sonarr:api.import_history' if date_iso else None) else: - return None + return None, None - def populate_movies(self) -> Dict[str, any]: + def populate_movies(self, instance: str = 'radarr') -> Dict[str, any]: """ - Populate movies from Radarr database/API + Populate movies from Radarr database/API. + + Args: + instance: Instance name to tag records with (e.g. 'radarr', 'radarr_4k'). Returns: Dictionary with statistics: { @@ -97,7 +188,7 @@ def populate_movies(self) -> Dict[str, any]: 'duration': float } """ - _log("INFO", "Starting movie population from Radarr") + _log("INFO", f"Starting movie population from Radarr instance '{instance}'") start_time = time.time() stats = { @@ -107,7 +198,8 @@ def populate_movies(self) -> Dict[str, any]: 'skipped': 0, 'errors': 0, 'duration': 0.0, - 'skipped_items': [] # Track what was skipped and why + 'skipped_items': [], # Track what was skipped and why + 'added_items': [] # Track what was newly added } try: @@ -118,15 +210,15 @@ def populate_movies(self) -> Dict[str, any]: # Legacy API client with db_client attribute movies = self.radarr.db_client.get_all_movies() else: - _log("ERROR", "Radarr database/API client not available - cannot populate movies") + _log("ERROR", f"[{instance}] Radarr database/API client not available - cannot populate movies") stats['errors'] += 1 return stats if not movies: - _log("WARNING", "No movies found in Radarr database") + _log("WARNING", f"[{instance}] No movies found in Radarr database") return stats stats['total'] = len(movies) - _log("INFO", f"Found {stats['total']} movies in Radarr") + _log("INFO", f"[{instance}] Found {stats['total']} movies in Radarr") # Process each movie for movie in movies: @@ -141,7 +233,7 @@ def populate_movies(self) -> Dict[str, any]: if not imdb_id and path: imdb_id = parse_imdb_from_path(Path(path)) if imdb_id: - _log("DEBUG", f"Extracted IMDb ID {imdb_id} from path for: {movie.get('title')}") + _log("DEBUG", f"[{instance}] Extracted IMDb ID {imdb_id} from path for: {movie.get('title')}") if not imdb_id: # Generate placeholder IMDb ID using hash of path @@ -156,7 +248,7 @@ def populate_movies(self) -> Dict[str, any]: 'reason': skip_reason } stats['skipped_items'].append(skip_info) - _log("DEBUG", f"Movie without IMDb ID: {movie.get('title')} (path: {path}), using placeholder {imdb_id}") + _log("DEBUG", f"[{instance}] Movie without IMDb ID: {movie.get('title')} (path: {path}), using placeholder {imdb_id}") # Mark as skipped in database with placeholder IMDb ID self.db.mark_movie_skipped( @@ -164,18 +256,19 @@ def populate_movies(self) -> Dict[str, any]: title=movie.get('title', 'Unknown'), year=movie.get('year', 0), path=path, - reason=skip_reason + reason=skip_reason, + instance=instance, ) stats['skipped'] += 1 continue # Check if movie already exists in database - existing = self.db.get_movie_dates(imdb_id) + existing = self.db.get_movie_dates(imdb_id, instance=instance) if existing and existing.get('dateadded'): # Already in database - update file path and video status if needed existing_path = existing.get('path') if not existing_path or existing_path == 'unknown' or existing_path != path: - _log("INFO", f"Movie {imdb_id} exists but updating file info: {path}") + _log("INFO", f"[{instance}] Movie \"{movie.get('title', 'Unknown')}\" {imdb_id} exists but updating file info: {path}") self.db.update_movie_file_info(imdb_id, path, has_video_file=True) # Add to processing history @@ -187,11 +280,11 @@ def populate_movies(self) -> Dict[str, any]: details={'path': path} ) except Exception as e: - _log("WARNING", f"Failed to add processing history for {imdb_id}: {e}") + _log("WARNING", f"[{instance}] Failed to add processing history for {imdb_id}: {e}") stats['updated'] += 1 else: - _log("DEBUG", f"Movie {imdb_id} already in database with correct path, skipping") + _log("DEBUG", f"[{instance}] Movie {imdb_id} already in database with correct path, skipping") continue # Get release date @@ -234,7 +327,7 @@ def populate_movies(self) -> Dict[str, any]: 'reason': skip_reason } stats['skipped_items'].append(skip_info) - _log("DEBUG", f"No date available for movie {imdb_id}, skipping") + _log("DEBUG", f"[{instance}] No date available for movie {imdb_id}, skipping") # Mark as skipped in database for troubleshooting self.db.mark_movie_skipped( @@ -242,7 +335,8 @@ def populate_movies(self) -> Dict[str, any]: title=movie.get('title', 'Unknown'), year=movie.get('year', 0), path=path or 'unknown', - reason=skip_reason + reason=skip_reason, + instance=instance, ) stats['skipped'] += 1 continue @@ -259,7 +353,7 @@ def populate_movies(self) -> Dict[str, any]: 'reason': skip_reason } stats['skipped_items'].append(skip_info) - _log("DEBUG", f"No date available for movie {imdb_id}, skipping") + _log("DEBUG", f"[{instance}] No date available for movie {imdb_id}, skipping") # Mark as skipped in database for troubleshooting self.db.mark_movie_skipped( @@ -267,7 +361,8 @@ def populate_movies(self) -> Dict[str, any]: title=movie.get('title', 'Unknown'), year=movie.get('year', 0), path=path or 'unknown', - reason=skip_reason + reason=skip_reason, + instance=instance, ) stats['skipped'] += 1 continue @@ -277,7 +372,8 @@ def populate_movies(self) -> Dict[str, any]: year = movie.get('year') self.db.upsert_movie_dates( imdb_id, released, dateadded, source, - has_video_file=True, title=title, year=year + has_video_file=True, title=title, year=year, + instance=instance, ) # Add to processing history @@ -289,34 +385,53 @@ def populate_movies(self) -> Dict[str, any]: details={'source': source, 'title': title} ) except Exception as e: - _log("WARNING", f"Failed to add processing history for {imdb_id}: {e}") + _log("WARNING", f"[{instance}] Failed to add processing history for {imdb_id}: {e}") stats['added'] += 1 - _log("DEBUG", f"Added movie {imdb_id}: {title} ({year}) (source: {source})") + stats['added_items'].append({ + 'title': title or 'Unknown', + 'year': year, + 'imdb_id': imdb_id, + 'source': source, + }) + _log("DEBUG", f"[{instance}] Added movie {imdb_id}: {title} ({year}) (source: {source})") except Exception as e: - _log("ERROR", f"Error processing movie {movie.get('title', 'unknown')}: {e}") + _log("ERROR", f"[{instance}] Error processing movie {movie.get('title', 'unknown')}: {e}") stats['errors'] += 1 continue except Exception as e: - _log("ERROR", f"Error during movie population: {e}") + _log("ERROR", f"[{instance}] Error during movie population: {e}") stats['errors'] += 1 stats['duration'] = time.time() - start_time - _log("INFO", f"Movie population complete: {stats['added']} added, {stats['skipped']} skipped, {stats['errors']} errors in {stats['duration']:.2f}s") + _log("INFO", f"[{instance}] Movie population complete: {stats['added']} added, {stats['skipped']} skipped, {stats['errors']} errors in {stats['duration']:.2f}s") # Log details of skipped items if stats['skipped_items']: - _log("INFO", f"Skipped items details ({len(stats['skipped_items'])} total):") + _log("INFO", f"[{instance}] Skipped items details ({len(stats['skipped_items'])} total):") for item in stats['skipped_items']: - _log("INFO", f" - {item['title']} ({item.get('year', 'N/A')}) [{item.get('imdb_id', 'No IMDb')}]: {item['reason']}") + _log("INFO", f"[{instance}] - {item['title']} ({item.get('year', 'N/A')}) [{item.get('imdb_id', 'No IMDb')}]: {item['reason']}") + + # Log details of added items — same convention as skipped items above, + # capped in the log (the full list is still in stats['added_items'] + # for the web interface) since a full library sync can add thousands. + if stats['added_items']: + _log("INFO", f"[{instance}] Added items details ({len(stats['added_items'])} total):") + for item in stats['added_items'][:20]: + _log("INFO", f"[{instance}] + {item['title']} ({item.get('year', 'N/A')}) [{item.get('imdb_id', 'No IMDb')}] (source: {item.get('source', 'unknown')})") + if len(stats['added_items']) > 20: + _log("INFO", f"[{instance}] ... and {len(stats['added_items']) - 20} more (see web interface for full list)") return stats - def populate_tv_episodes(self) -> Dict[str, any]: + def populate_tv_episodes(self, instance: str = 'sonarr') -> Dict[str, any]: """ - Populate TV episodes from Sonarr API + Populate TV episodes from Sonarr database/API. + + Args: + instance: Instance name to tag records with (e.g. 'sonarr', 'sonarr_4k'). Returns: Dictionary with statistics: { @@ -329,7 +444,7 @@ def populate_tv_episodes(self) -> Dict[str, any]: 'duration': float } """ - _log("INFO", "Starting TV episode population from Sonarr") + _log("INFO", f"[{instance}] Starting TV episode population from Sonarr") start_time = time.time() stats = { @@ -340,18 +455,19 @@ def populate_tv_episodes(self) -> Dict[str, any]: 'skipped': 0, 'errors': 0, 'duration': 0.0, - 'skipped_items': [] # Track what was skipped and why + 'skipped_items': [], # Track what was skipped and why + 'added_items': [] # Track what was newly added } try: # Get all series from Sonarr all_series = self.sonarr.get_all_series() if not all_series: - _log("WARNING", "No series found in Sonarr") + _log("WARNING", f"[{instance}] No series found in Sonarr") return stats stats['total_series'] = len(all_series) - _log("INFO", f"Found {stats['total_series']} series in Sonarr") + _log("INFO", f"[{instance}] Found {stats['total_series']} series in Sonarr") # Process each series for series in all_series: @@ -366,27 +482,27 @@ def populate_tv_episodes(self) -> Dict[str, any]: # Try to extract from path first imdb_id = parse_imdb_from_path(Path(series_path)) if imdb_id: - _log("DEBUG", f"Extracted IMDb ID {imdb_id} from path for {series_title}") + _log("DEBUG", f"[{instance}] Extracted IMDb ID {imdb_id} from path for {series_title}") if not imdb_id: # Generate placeholder IMDb ID using hash of path path_hash = hashlib.md5(series_path.encode()).hexdigest()[:12] imdb_id = f"missing-{path_hash}" - _log("DEBUG", f"Series without IMDb ID: {series_title} (path: {series_path}), using placeholder {imdb_id}") + _log("DEBUG", f"[{instance}] Series without IMDb ID: {series_title} (path: {series_path}), using placeholder {imdb_id}") # Update series record - self.db.upsert_series(imdb_id, series_path) + self.db.upsert_series(imdb_id, series_path, instance=instance) # Try high-performance database bulk query first bulk_import_dates = {} if self.using_sonarr_db and self.sonarr_db: try: - _log("DEBUG", f"Using DB bulk query for {series_title}") + _log("DEBUG", f"[{instance}] Using DB bulk query for {series_title}") bulk_import_dates = self.sonarr_db.bulk_import_dates_for_series(series_id) - _log("DEBUG", f"✅ Got {len(bulk_import_dates)} import dates from DB for {series_title}") + _log("DEBUG", f"[{instance}] ✅ Got {len(bulk_import_dates)} import dates from DB for {series_title}") except Exception as e: - _log("WARNING", f"DB bulk query failed for {series_title}, falling back to API: {e}") + _log("WARNING", f"[{instance}] DB bulk query failed for {series_title}, falling back to API: {e}") # Get all episodes for this series if self.using_sonarr_db and self.sonarr_db: @@ -396,7 +512,7 @@ def populate_tv_episodes(self) -> Dict[str, any]: if not episodes: continue - _log("DEBUG", f"Processing {len(episodes)} episodes for {series_title}") + _log("DEBUG", f"[{instance}] Processing {len(episodes)} episodes for {series_title}") # Process each episode for episode in episodes: @@ -412,13 +528,13 @@ def populate_tv_episodes(self) -> Dict[str, any]: stats['total_episodes'] += 1 # Check if episode already exists - existing = self.db.get_episode_date(imdb_id, season_num, episode_num) + existing = self.db.get_episode_date(imdb_id, season_num, episode_num, instance=instance) if existing and existing.get('dateadded'): # Already in database - update file path and video status if needed existing_path = existing.get('path') episode_path = episode.get('path', 'unknown') if not existing_path or existing_path == 'unknown' or existing_path != episode_path: - _log("INFO", f"Episode {imdb_id} S{season_num:02d}E{episode_num:02d} exists but updating file info: {episode_path}") + _log("INFO", f"[{instance}] Episode \"{series_title}\" {imdb_id} S{season_num:02d}E{episode_num:02d} exists but updating file info: {episode_path}") self.db.update_episode_file_info(imdb_id, season_num, episode_num, episode_path, has_video_file=True) # Add to processing history @@ -430,7 +546,7 @@ def populate_tv_episodes(self) -> Dict[str, any]: details={'season': season_num, 'episode': episode_num, 'path': episode_path} ) except Exception as e: - _log("WARNING", f"Failed to add processing history for {imdb_id} S{season_num:02d}E{episode_num:02d}: {e}") + _log("WARNING", f"[{instance}] Failed to add processing history for {imdb_id} S{season_num:02d}E{episode_num:02d}: {e}") stats['updated'] += 1 continue @@ -458,10 +574,10 @@ def populate_tv_episodes(self) -> Dict[str, any]: else: episode_id = episode.get('id') if episode_id: - import_date = self.get_episode_import_history(episode_id) + import_date, import_source = self.get_episode_import_history(episode_id) if import_date: dateadded = import_date - source = 'sonarr:api.import_history' + source = import_source or 'sonarr:api.import_history' # Fallback to air date if no import date if not dateadded and aired: @@ -476,7 +592,7 @@ def populate_tv_episodes(self) -> Dict[str, any]: if file_date: dateadded = file_date source = 'sonarr:db.file.dateAdded' - _log("INFO", f"Using file date for {series_title} S{season_num:02d}E{episode_num:02d}: {file_date}") + _log("INFO", f"[{instance}] Using file date for {series_title} S{season_num:02d}E{episode_num:02d}: {file_date}") if not dateadded: # No date available @@ -495,13 +611,14 @@ def populate_tv_episodes(self) -> Dict[str, any]: imdb_id=imdb_id, season=season_num, episode=episode_num, - reason=skip_reason + reason=skip_reason, + instance=instance, ) stats['skipped'] += 1 continue # Insert into database - self.db.upsert_episode_date(imdb_id, season_num, episode_num, aired, dateadded, source, has_file) + self.db.upsert_episode_date(imdb_id, season_num, episode_num, aired, dateadded, source, has_file, instance=instance) # Add to processing history try: @@ -512,34 +629,50 @@ def populate_tv_episodes(self) -> Dict[str, any]: details={'season': season_num, 'episode': episode_num, 'source': source, 'title': episode_title} ) except Exception as e: - _log("WARNING", f"Failed to add processing history for {imdb_id} S{season_num:02d}E{episode_num:02d}: {e}") + _log("WARNING", f"[{instance}] Failed to add processing history for {imdb_id} S{season_num:02d}E{episode_num:02d}: {e}") stats['added'] += 1 + stats['added_items'].append({ + 'title': series_title, + 'episode_title': episode_title, + 'season': season_num, + 'episode': episode_num, + 'source': source, + }) except Exception as e: - _log("ERROR", f"Error processing episode S{season_num:02d}E{episode_num:02d} of {series_title}: {e}") + _log("ERROR", f"[{instance}] Error processing episode S{season_num:02d}E{episode_num:02d} of {series_title}: {e}") stats['errors'] += 1 continue except Exception as e: - _log("ERROR", f"Error processing series {series.get('title', 'unknown')}: {e}") + _log("ERROR", f"[{instance}] Error processing series {series.get('title', 'unknown')}: {e}") stats['errors'] += 1 continue except Exception as e: - _log("ERROR", f"Error during TV episode population: {e}") + _log("ERROR", f"[{instance}] Error during TV episode population: {e}") stats['errors'] += 1 stats['duration'] = time.time() - start_time - _log("INFO", f"TV episode population complete: {stats['added']} added, {stats['skipped']} skipped, {stats['errors']} errors in {stats['duration']:.2f}s") + _log("INFO", f"[{instance}] TV episode population complete: {stats['added']} added, {stats['skipped']} skipped, {stats['errors']} errors in {stats['duration']:.2f}s") # Log details of skipped items if stats['skipped_items']: - _log("INFO", f"Skipped episodes details ({len(stats['skipped_items'])} total):") + _log("INFO", f"[{instance}] Skipped episodes details ({len(stats['skipped_items'])} total):") for item in stats['skipped_items'][:20]: # Only log first 20 to avoid spam - _log("INFO", f" - {item['title']} S{str(item['season']).zfill(2)}E{str(item['episode']).zfill(2)} ({item.get('episode_title', 'Unknown')}): {item['reason']}") + _log("INFO", f"[{instance}] - {item['title']} S{str(item['season']).zfill(2)}E{str(item['episode']).zfill(2)} ({item.get('episode_title', 'Unknown')}): {item['reason']}") if len(stats['skipped_items']) > 20: - _log("INFO", f" ... and {len(stats['skipped_items']) - 20} more (see web interface for full list)") + _log("INFO", f"[{instance}] ... and {len(stats['skipped_items']) - 20} more (see web interface for full list)") + + # Log details of added episodes — see populate_movies() for why this + # is capped in the log but not in stats['added_items'] itself. + if stats['added_items']: + _log("INFO", f"[{instance}] Added episodes details ({len(stats['added_items'])} total):") + for item in stats['added_items'][:20]: + _log("INFO", f"[{instance}] + {item['title']} S{str(item['season']).zfill(2)}E{str(item['episode']).zfill(2)} ({item.get('episode_title', 'Unknown')}) (source: {item.get('source', 'unknown')})") + if len(stats['added_items']) > 20: + _log("INFO", f"[{instance}] ... and {len(stats['added_items']) - 20} more (see web interface for full list)") return stats diff --git a/core/instance_registry.py b/core/instance_registry.py new file mode 100644 index 0000000..226f434 --- /dev/null +++ b/core/instance_registry.py @@ -0,0 +1,192 @@ +""" +Instance registry for Radarr and Sonarr clients. + +Builds one client and one PathMapper per configured instance at startup. +Processors and webhook handlers resolve the right client/mapper from here +rather than each constructing their own from env vars. +""" +from typing import Dict, Optional, Union + +from clients.radarr_client import RadarrClient +from clients.radarr_db_client import RadarrDbClient +from clients.sonarr_client import SonarrClient +from clients.sonarr_db_client import SonarrDbClient +from config.settings import RadarrInstance, SonarrInstance +from core.logging import _log +from core.path_mapper import PathMapper + +# Type aliases +AnyRadarrClient = Union[RadarrClient, RadarrDbClient] +AnySonarrClient = Union[SonarrClient, SonarrDbClient] + + +def _build_radarr_client(instance: RadarrInstance) -> Optional[AnyRadarrClient]: + """Return the best available client for a Radarr instance. + + Tries DB client first (faster, no API rate limits). Falls back to API + client if no DB is configured or the connection fails. + """ + if instance.db_type: + try: + if instance.db_type == "sqlite": + client = RadarrDbClient( + db_type="sqlite", + db_path=instance.db_path or None, + instance_name=instance.name, + ) + else: + client = RadarrDbClient( + db_type=instance.db_type, + db_host=instance.db_host or None, + db_port=instance.db_port, + db_name=instance.db_name or None, + db_user=instance.db_user or None, + db_password=instance.db_password or None, + instance_name=instance.name, + ) + _log("INFO", f"[{instance.name}] Using Radarr direct database access") + return client + except Exception as e: + _log("WARNING", f"[{instance.name}] Radarr DB connection failed, falling back to API: {e}") + + if instance.url and instance.api_key: + _log("INFO", f"[{instance.name}] Using Radarr API client") + return RadarrClient( + base_url=instance.url, + api_key=instance.api_key, + instance_name=instance.name, + ) + + _log("WARNING", f"[{instance.name}] No Radarr client available — no DB or API configured") + return None + + +def _build_sonarr_client(instance: SonarrInstance) -> Optional[AnySonarrClient]: + """Return the best available client for a Sonarr instance.""" + if instance.db_type: + try: + if instance.db_type == "sqlite": + client = SonarrDbClient( + db_type="sqlite", + db_path=instance.db_path or None, + instance_name=instance.name, + ) + else: + client = SonarrDbClient( + db_type=instance.db_type, + db_host=instance.db_host or None, + db_port=instance.db_port, + db_name=instance.db_name or None, + db_user=instance.db_user or None, + db_password=instance.db_password or None, + instance_name=instance.name, + ) + _log("INFO", f"[{instance.name}] Using Sonarr direct database access") + return client + except Exception as e: + _log("WARNING", f"[{instance.name}] Sonarr DB connection failed, falling back to API: {e}") + + if instance.url and instance.api_key: + _log("INFO", f"[{instance.name}] Using Sonarr API client") + return SonarrClient( + base_url=instance.url, + api_key=instance.api_key, + instance_name=instance.name, + ) + + _log("WARNING", f"[{instance.name}] No Sonarr client available — no DB or API configured") + return None + + +class InstanceRegistry: + """Central store of all Radarr and Sonarr clients and path mappers, keyed by instance name.""" + + def __init__(self, radarr_instances, sonarr_instances): + self._radarr: Dict[str, AnyRadarrClient] = {} + self._sonarr: Dict[str, AnySonarrClient] = {} + self._radarr_mappers: Dict[str, PathMapper] = {} + self._sonarr_mappers: Dict[str, PathMapper] = {} + # Connection status keyed by instance name — used by /setup and startup reporting. + # {"connected": True, "method": "direct_db"|"api"} or {"connected": False} + self._radarr_status: Dict[str, dict] = {} + self._sonarr_status: Dict[str, dict] = {} + + for inst in radarr_instances: + client = _build_radarr_client(inst) + if client: + self._radarr[inst.name] = client + method = "direct_db" if isinstance(client, RadarrDbClient) else "api" + self._radarr_status[inst.name] = {"connected": True, "method": method} + else: + self._radarr_status[inst.name] = {"connected": False} + self._radarr_mappers[inst.name] = PathMapper( + root_folders=inst.root_folders, + container_paths=inst.movie_paths, + ) + + for inst in sonarr_instances: + client = _build_sonarr_client(inst) + if client: + self._sonarr[inst.name] = client + method = "direct_db" if isinstance(client, SonarrDbClient) else "api" + self._sonarr_status[inst.name] = {"connected": True, "method": method} + else: + self._sonarr_status[inst.name] = {"connected": False} + self._sonarr_mappers[inst.name] = PathMapper( + root_folders=inst.root_folders, + container_paths=inst.tv_paths, + ) + + _log("INFO", f"Instance registry: {len(self._radarr)} Radarr, {len(self._sonarr)} Sonarr") + + def radarr(self, name: str = "radarr") -> Optional[AnyRadarrClient]: + """Look up a Radarr client by instance name.""" + return self._radarr.get(name) + + def sonarr(self, name: str = "sonarr") -> Optional[AnySonarrClient]: + """Look up a Sonarr client by instance name.""" + return self._sonarr.get(name) + + def radarr_mapper(self, name: str = "radarr") -> Optional[PathMapper]: + """Look up the PathMapper for a Radarr instance.""" + return self._radarr_mappers.get(name) + + def sonarr_mapper(self, name: str = "sonarr") -> Optional[PathMapper]: + """Look up the PathMapper for a Sonarr instance.""" + return self._sonarr_mappers.get(name) + + def radarr_status(self, name: str = "radarr") -> dict: + """Return connection status for a Radarr instance by name. + + Returns {"connected": True, "method": "direct_db"|"api"} or {"connected": False}. + """ + return self._radarr_status.get(name, {"connected": False}) + + def sonarr_status(self, name: str = "sonarr") -> dict: + """Return connection status for a Sonarr instance by name.""" + return self._sonarr_status.get(name, {"connected": False}) + + def all_radarr_statuses(self) -> Dict[str, dict]: + return dict(self._radarr_status) + + def all_sonarr_statuses(self) -> Dict[str, dict]: + return dict(self._sonarr_status) + + def all_radarr(self) -> Dict[str, AnyRadarrClient]: + return dict(self._radarr) + + def all_sonarr(self) -> Dict[str, AnySonarrClient]: + return dict(self._sonarr) + + @property + def radarr_names(self): + return list(self._radarr.keys()) + + @property + def sonarr_names(self): + return list(self._sonarr.keys()) + + +def build_registry(config) -> InstanceRegistry: + """Build the instance registry from a ChronarrConfig object.""" + return InstanceRegistry(config.radarr_instances, config.sonarr_instances) diff --git a/core/path_mapper.py b/core/path_mapper.py index b7567ae..9224c8a 100644 --- a/core/path_mapper.py +++ b/core/path_mapper.py @@ -1,120 +1,49 @@ -#!/usr/bin/env python3 -""" -Path mapping utilities for Chronarr -Handles conversion between external service paths and container paths -""" -import os -import re from pathlib import Path -class PathMapper: - """Handles path mapping between different environments""" - - def __init__(self, config): - """Initialize path mapper with configuration""" - # Use environment variables directly since config attribute names are unclear - import os - - radarr_roots_str = os.getenv('RADARR_ROOT_FOLDERS', '') - sonarr_roots_str = os.getenv('SONARR_ROOT_FOLDERS', '') - movie_paths_str = os.getenv('MOVIE_PATHS', '') - tv_paths_str = os.getenv('TV_PATHS', '') - - self.radarr_roots = [path.strip() for path in radarr_roots_str.split(',') if path.strip()] - self.sonarr_roots = [path.strip() for path in sonarr_roots_str.split(',') if path.strip()] - self.movie_paths = [path.strip() for path in movie_paths_str.split(',') if path.strip()] - self.tv_paths = [path.strip() for path in tv_paths_str.split(',') if path.strip()] - - # Check if path debugging is enabled - self.path_debug = os.getenv('PATH_DEBUG', 'false').lower() == 'true' - - if self.path_debug: - print(f"PATH_DEBUG: PathMapper initialized with:") - print(f"PATH_DEBUG: radarr_roots: {self.radarr_roots}") - print(f"PATH_DEBUG: sonarr_roots: {self.sonarr_roots}") - print(f"PATH_DEBUG: movie_paths: {self.movie_paths}") - print(f"PATH_DEBUG: tv_paths: {self.tv_paths}") - @staticmethod - def _normalize_separators(path: str) -> str: - """Normalize path separators to forward slashes — handles UNC paths from Windows/Radarr""" - return path.replace('\\', '/') +class PathMapper: + """Maps filesystem paths between what Radarr/Sonarr report and what the container sees. - def sonarr_path_to_container_path(self, sonarr_path: str) -> str: - """Convert Sonarr path to container path using environment mappings""" - # Normalize separators so UNC paths (\\server\share\...) match correctly - normalized_path = self._normalize_separators(sonarr_path) + One PathMapper is created per configured instance at startup, built from + that instance's root_folders and container_paths. The mapping logic is + identical for Radarr and Sonarr — only the data differs. + """ - if self.path_debug: - print(f"PATH_DEBUG: sonarr_path_to_container_path input: {sonarr_path}") - print(f"PATH_DEBUG: normalized input: {normalized_path}") - print(f"PATH_DEBUG: sonarr_roots: {self.sonarr_roots}") - print(f"PATH_DEBUG: tv_paths: {self.tv_paths}") + def __init__(self, root_folders: list, container_paths: list, debug: bool = False): + self.root_folders = root_folders + self.container_paths = container_paths + self.debug = debug - # Sort roots by length (longest first) to avoid substring matching issues - indexed_roots = [(i, root) for i, root in enumerate(self.sonarr_roots)] - indexed_roots.sort(key=lambda x: len(x[1]), reverse=True) + @staticmethod + def _normalize(path: str) -> str: + """Backslash to forward slash — handles UNC paths from Windows/Radarr.""" + return path.replace('\\', '/') - # Try to match against configured Sonarr root folders (longest first) - for original_index, sonarr_root in indexed_roots: - normalized_root = self._normalize_separators(sonarr_root) - if self.path_debug: - print(f"PATH_DEBUG: Checking sonarr_root[{original_index}]: {normalized_root}") - if normalized_path.startswith(normalized_root + '/') or normalized_path == normalized_root: - if self.path_debug: - print(f"PATH_DEBUG: Match found! Index {original_index}") - # Map to corresponding TV path - if original_index < len(self.tv_paths): - container_root = self.tv_paths[original_index] - relative_path = normalized_path[len(normalized_root):].lstrip('/') - result = str(Path(container_root) / relative_path) if relative_path else container_root - if self.path_debug: - print(f"PATH_DEBUG: Mapped to: {result}") + def map(self, path: str) -> str: + """Translate an external path to its container equivalent. + + Tries each configured root folder longest-first to avoid prefix collisions + (e.g. /movies matching before /movies/4k). Returns the original path + unchanged if nothing matches — let the caller decide what to do. + """ + normalized = self._normalize(path) + roots = sorted(enumerate(self.root_folders), key=lambda x: len(x[1]), reverse=True) + for idx, root in roots: + norm_root = self._normalize(root) + if normalized.startswith(norm_root + '/') or normalized == norm_root: + if idx < len(self.container_paths): + rel = normalized[len(norm_root):].lstrip('/') + result = str(Path(self.container_paths[idx]) / rel) if rel else self.container_paths[idx] + if self.debug: + print(f"[path_mapper] {path!r} -> {result!r}") return result + if self.debug: + print(f"[path_mapper] no match for {path!r}, returning as-is") + return path - if self.path_debug: - print(f"PATH_DEBUG: No match found, returning original: {sonarr_path}") - # No fallback - if path mapping fails, return original and let validation catch it - return sonarr_path - - def radarr_path_to_container_path(self, radarr_path: str) -> str: - """Convert Radarr path to container path using environment mappings""" - # Normalize separators so UNC paths (\\server\share\...) match correctly - normalized_path = self._normalize_separators(radarr_path) - - if self.path_debug: - print(f"PATH_DEBUG: radarr_path_to_container_path input: {radarr_path}") - print(f"PATH_DEBUG: normalized input: {normalized_path}") - print(f"PATH_DEBUG: radarr_roots: {self.radarr_roots}") - print(f"PATH_DEBUG: movie_paths: {self.movie_paths}") - - # Sort roots by length (longest first) to avoid substring matching issues - indexed_roots = [(i, root) for i, root in enumerate(self.radarr_roots)] - indexed_roots.sort(key=lambda x: len(x[1]), reverse=True) - - # Try to match against configured Radarr root folders (longest first) - for original_index, radarr_root in indexed_roots: - normalized_root = self._normalize_separators(radarr_root) - if self.path_debug: - print(f"PATH_DEBUG: Checking radarr_root[{original_index}]: {normalized_root}") - if normalized_path.startswith(normalized_root + '/') or normalized_path == normalized_root: - if self.path_debug: - print(f"PATH_DEBUG: Match found! Index {original_index}") - # Map to corresponding movie path - if original_index < len(self.movie_paths): - container_root = self.movie_paths[original_index] - relative_path = normalized_path[len(normalized_root):].lstrip('/') - result = str(Path(container_root) / relative_path) if relative_path else container_root - if self.path_debug: - print(f"PATH_DEBUG: Mapped to: {result}") - return result + # Backward-compat aliases — existing call sites use these names. + def radarr_path_to_container_path(self, path: str) -> str: + return self.map(path) - if self.path_debug: - print(f"PATH_DEBUG: No match found, returning original: {radarr_path}") - # No fallback - if path mapping fails, return original and let validation catch it - return radarr_path - - def container_path_to_host_path(self, container_path: str) -> str: - """Convert container path back to host path if needed""" - # This might be needed for file operations - return container_path \ No newline at end of file + def sonarr_path_to_container_path(self, path: str) -> str: + return self.map(path) diff --git a/docker-compose.yml.example b/docker-compose.yml.example index 0b359b6..81f8558 100644 --- a/docker-compose.yml.example +++ b/docker-compose.yml.example @@ -67,12 +67,34 @@ services: - chronarr_logs:/app/data/logs # Optional: Radarr SQLite database (read-only access) # Required if using RADARR_DB_TYPE=sqlite in config - # - /path/to/radarr/config:/radarr-config:ro - # Then set RADARR_DB_PATH=/radarr-config/radarr.db in .env + # - /path/to/radarr/config:/radarr-data:ro + # Then set RADARR_DB_PATH=/radarr-data/radarr.db in .env + # + # Additional Radarr instances — one mount per instance: + # - /path/to/radarr-4k/config:/radarr-4k-data:ro + # Then set RADARR_4K_DB_PATH=/radarr-4k-data/radarr.db in .env + # + # Media paths — one mount per instance if libraries differ: + # - /path/to/movies:/media/movies:ro + # - /path/to/movies-4k:/media/movies-4k:ro + # Then set RADARR_MOVIE_PATHS=/media/movies and + # RADARR_4K_MOVIE_PATHS=/media/movies-4k in .env + # # Optional: Sonarr SQLite database (read-only access) # Required if using SONARR_DB_TYPE=sqlite in config - # - /path/to/sonarr/config:/sonarr-config:ro - # Then set SONARR_DB_PATH=/sonarr-config/sonarr.db in .env + # - /path/to/sonarr/config:/sonarr-data:ro + # Then set SONARR_DB_PATH=/sonarr-data/sonarr.db in .env + # + # Additional Sonarr instances: + # - /path/to/sonarr-anime/config:/sonarr-anime-data:ro + # Then set SONARR_ANIME_DB_PATH=/sonarr-anime-data/sonarr.db in .env + # + # Media paths — one mount per instance if libraries differ: + # - /path/to/tv:/media/tv:ro + # - /path/to/anime:/media/anime:ro + # Then set SONARR_TV_PATHS=/media/tv and + # SONARR_ANIME_TV_PATHS=/media/anime in .env + # # Optional: Emby plugin deployment # - /path/to/emby/plugins:/emby-plugins ports: @@ -158,7 +180,7 @@ networks: # 4. Access Web Interface: # http://your-server:8081 # -# Then click Admin → Populate Database +# Then open the sidebar → Tools → Populate Database # # ======================================== # Configuration Notes @@ -176,20 +198,25 @@ networks: # # SQLite Database Access (for Radarr/Sonarr): # - If using SQLite databases, you MUST mount them read-only -# - Radarr example: -# 1. Uncomment: - /path/to/radarr/config:/radarr-config:ro -# 2. Update path to your Radarr config directory -# 3. In ./config/.env set: RADARR_DB_TYPE=sqlite -# 4. In ./config/.env set: RADARR_DB_PATH=/radarr-config/radarr.db +# - Each instance needs its own volume mount and its own DB_PATH variable +# - Radarr (default instance) example: +# 1. Add volume: - /path/to/radarr/config:/radarr-data:ro +# 2. In ./config/.env set: RADARR_DB_TYPE=sqlite +# 3. In ./config/.env set: RADARR_DB_PATH=/radarr-data/radarr.db +# - Radarr 4K instance example: +# 1. Add volume: - /path/to/radarr-4k/config:/radarr-4k-data:ro +# 2. In ./config/.env set: RADARR_4K_DB_TYPE=sqlite +# 3. In ./config/.env set: RADARR_4K_DB_PATH=/radarr-4k-data/radarr.db # - Sonarr example: -# 1. Uncomment: - /path/to/sonarr/config:/sonarr-config:ro -# 2. Update path to your Sonarr config directory -# 3. In ./config/.env set: SONARR_DB_TYPE=sqlite -# 4. In ./config/.env set: SONARR_DB_PATH=/sonarr-config/sonarr.db -# - Common paths: -# - Docker: /path/to/radarr/config (where radarr.db lives) -# - Windows: C:/ProgramData/Radarr or C:/ProgramData/Sonarr -# - Linux: /home/user/.config/Radarr or /var/lib/radarr +# 1. Add volume: - /path/to/sonarr/config:/sonarr-data:ro +# 2. In ./config/.env set: SONARR_DB_TYPE=sqlite +# 3. In ./config/.env set: SONARR_DB_PATH=/sonarr-data/sonarr.db +# - The radarr.db file is usually directly inside the Radarr config folder. +# If not, browse the folder on your host and find it, then adjust DB_PATH. +# - Common config locations: +# - Docker (LSIO/Hotio): the config directory you mapped to /config in Radarr +# - Windows (bare metal): C:/ProgramData/Radarr +# - Linux (bare metal): /home/user/.config/Radarr or /var/lib/radarr # # Emby Plugin Deployment: # - Uncomment the emby-plugins volume mount diff --git a/main.py b/main.py index c7c184b..75fb0fa 100644 --- a/main.py +++ b/main.py @@ -1,9 +1,5 @@ #!/usr/bin/env python3 -""" -Chronarr Core - Automated NFO file management and processing engine -Core processing container with webhooks, scanning, and database management -Web interface separated to chronarr-web container -""" +"""Chronarr core — webhook processor, scanner, and scheduling engine.""" import os import sys import signal @@ -14,22 +10,23 @@ import uvicorn from fastapi import FastAPI -# Import configuration first -from config.settings import config - -# Authentication removed - handled by separate web container +# utils.logging has to be imported before config.settings — importing it is +# what actually loads .env/.env.secrets into the process (a side effect at +# the bottom of that module). config.settings builds its module-level +# `config` singleton, including instance discovery, the moment it's +# imported — if that happens first, any instance whose env vars only live +# in the file (not already in the container's OS environment from Docker's +# own env_file injection at container creation) gets silently missed. from utils.logging import _log +# Import configuration — after logging, see above +from config.settings import config + # Import core components from core.database import ChronarrDatabase -# from core.nfo_manager import NFOManager # Phase 3: Removed - no longer needed +from core.instance_registry import build_registry from core.path_mapper import PathMapper -# Import clients -from clients.external_clients import ExternalClientManager -from clients.radarr_db_client import RadarrDbClient -from clients.sonarr_db_client import SonarrDbClient - # Import processors from processors.tv_processor import TVProcessor from processors.movie_processor import MovieProcessor @@ -87,45 +84,48 @@ async def lifespan(app: FastAPI): return app -def initialize_components(): - """Initialize all application components""" +def _noop_mapper() -> PathMapper: + """Return an empty PathMapper — used when a default instance isn't configured.""" + return PathMapper(root_folders=[], container_paths=[]) + + +def initialize_components(registry=None): start_time = datetime.now(timezone.utc) - # Initialize core components db = ChronarrDatabase(config=config) - # nfo_manager = NFOManager(config.manager_brand, config.debug) # Phase 3: Removed - path_mapper = PathMapper(config) - # Initialize processors (nfo_manager=None for backward compatibility) - tv_processor = TVProcessor(db, None, path_mapper) - movie_processor = MovieProcessor(db, None, path_mapper) + # Use the registry built at startup if passed in; otherwise build it now. + if registry is None: + registry = build_registry(config) + + # Processors are constructed with the default instance's client and mapper + # (used as a fallback when no registry is available, e.g. in tests), but + # also get the InstanceRegistry itself — every per-call `instance` param + # they take is resolved against it, so a named instance actually gets its + # own client and path mapper instead of silently falling back to whatever + # was wired in here. + default_radarr_mapper = registry.radarr_mapper("radarr") + default_sonarr_mapper = registry.sonarr_mapper("sonarr") + + tv_processor = TVProcessor( + db, None, + default_sonarr_mapper or _noop_mapper(), + sonarr_client=registry.sonarr("sonarr"), + registry=registry, + ) + movie_processor = MovieProcessor( + db, None, + default_radarr_mapper or _noop_mapper(), + radarr_client=registry.radarr("radarr"), + registry=registry, + ) - # Initialize webhook batcher (no longer needs nfo_manager - Phase 3) batcher = WebhookBatcher(nfo_manager=None) batcher.set_processors(tv_processor, movie_processor) - # Initialize optional Radarr/Sonarr database clients for orphaned record cleanup - radarr_db_client = None - sonarr_db_client = None - - try: - radarr_db_client = RadarrDbClient.from_env() - if radarr_db_client: - _log("INFO", "Radarr database client initialized for orphaned record cleanup") - except Exception as e: - _log("WARNING", f"Could not initialize Radarr database client: {e}") - - try: - sonarr_db_client = SonarrDbClient.from_env() - if sonarr_db_client: - _log("INFO", "Sonarr database client initialized for orphaned record cleanup") - except Exception as e: - _log("WARNING", f"Could not initialize Sonarr database client: {e}") - return { "db": db, - # "nfo_manager": nfo_manager, # Phase 3: Removed - "path_mapper": path_mapper, + "registry": registry, "tv_processor": tv_processor, "movie_processor": movie_processor, "batcher": batcher, @@ -133,8 +133,6 @@ def initialize_components(): "config": config, "version": get_version(), "shutdown_event": shutdown_event, - "radarr_db_client": radarr_db_client, - "sonarr_db_client": sonarr_db_client } @@ -181,171 +179,82 @@ def force_exit(): sys.exit(0) -def test_database_connections(): - """Test and report all database connections at startup with actual connection tests""" +def test_database_connections(registry=None): + """Report all database connection statuses at startup.""" import psycopg2 import sqlite3 - from pathlib import Path print("\n" + "="*70) print(" DATABASE CONNECTION STATUS") print("="*70) - # Test Chronarr internal database + # Chronarr's own DB — always present print(f"\n Chronarr Database:") if config.db_type == "postgresql": - print(f" Type: PostgreSQL") - print(f" Host: {config.db_host}:{config.db_port}") - print(f" Database: {config.db_name}") - print(f" User: {config.db_user}") - + print(f" Type: PostgreSQL Host: {config.db_host}:{config.db_port} Database: {config.db_name}") try: - # Attempt actual connection conn = psycopg2.connect( - host=config.db_host, - port=config.db_port, - database=config.db_name, - user=config.db_user, - password=config.db_password + host=config.db_host, port=config.db_port, + database=config.db_name, user=config.db_user, password=config.db_password ) - cursor = conn.cursor() - cursor.execute("SELECT 1") - cursor.close() + conn.cursor().execute("SELECT 1") conn.close() print(f" Status: ✅ CONNECTED") except Exception as e: - print(f" Status: ❌ ERROR - {str(e)[:50]}") + print(f" Status: ❌ ERROR - {str(e)[:60]}") else: - print(f" Type: SQLite") - print(f" Path: {config.db_path}") + print(f" Type: SQLite Path: {config.db_path}") try: if Path(config.db_path).exists(): conn = sqlite3.connect(config.db_path) - cursor = conn.cursor() - cursor.execute("SELECT 1") - cursor.close() + conn.cursor().execute("SELECT 1") conn.close() print(f" Status: ✅ CONNECTED") else: - print(f" Status: ⚠️ Database file will be created on first use") + print(f" Status: ⚠️ Will be created on first use") except Exception as e: - print(f" Status: ❌ ERROR - {str(e)[:50]}") - - # Test Radarr database - print(f"\n Radarr Database:") - radarr_db_type = os.environ.get("RADARR_DB_TYPE", "").lower() - - if radarr_db_type == "postgresql": - radarr_db_host = os.environ.get("RADARR_DB_HOST", "") - radarr_db_port = os.environ.get("RADARR_DB_PORT", "5432") - radarr_db_name = os.environ.get("RADARR_DB_NAME", "") - radarr_db_user = os.environ.get("RADARR_DB_USER", "") - radarr_db_password = os.environ.get("RADARR_DB_PASSWORD", "") - - print(f" Type: PostgreSQL") - print(f" Host: {radarr_db_host}:{radarr_db_port}") - print(f" Database: {radarr_db_name}") - print(f" User: {radarr_db_user}") - - if not radarr_db_host or not radarr_db_name: - print(f" Status: ⚠️ NOT CONFIGURED (missing host or database name)") - else: - try: - conn = psycopg2.connect( - host=radarr_db_host, - port=int(radarr_db_port), - database=radarr_db_name, - user=radarr_db_user, - password=radarr_db_password - ) - cursor = conn.cursor() - cursor.execute("SELECT 1") - cursor.close() - conn.close() - print(f" Status: ✅ CONNECTED - Using direct database access") - except Exception as e: - print(f" Status: ❌ ERROR - {str(e)[:50]}") - - elif radarr_db_type == "sqlite": - radarr_db_path = os.environ.get("RADARR_DB_PATH", "") - print(f" Type: SQLite") - print(f" Path: {radarr_db_path}") - - if not radarr_db_path: - print(f" Status: ⚠️ NOT CONFIGURED (missing database path)") - elif not Path(radarr_db_path).exists(): - print(f" Status: ❌ ERROR - Database file not found") - else: - try: - conn = sqlite3.connect(radarr_db_path) - cursor = conn.cursor() - cursor.execute("SELECT 1") - cursor.close() - conn.close() - print(f" Status: ✅ CONNECTED - Using direct database access") - except Exception as e: - print(f" Status: ❌ ERROR - {str(e)[:50]}") + print(f" Status: ❌ ERROR - {str(e)[:60]}") + + if not registry: + print("\n" + "="*70 + "\n") + return + + # Radarr instances — one line each + print(f"\n Radarr:") + if not config.radarr_instances: + print(f" No Radarr instances configured") else: - print(f" Type: Not configured") - print(f" Status: ⚠️ Will use Radarr API instead of direct database access") - - # Test Sonarr database - print(f"\n Sonarr Database:") - sonarr_db_type = os.environ.get("SONARR_DB_TYPE", "").lower() - - if sonarr_db_type == "postgresql": - sonarr_db_host = os.environ.get("SONARR_DB_HOST", "") - sonarr_db_port = os.environ.get("SONARR_DB_PORT", "5432") - sonarr_db_name = os.environ.get("SONARR_DB_NAME", "") - sonarr_db_user = os.environ.get("SONARR_DB_USER", "") - sonarr_db_password = os.environ.get("SONARR_DB_PASSWORD", "") - - print(f" Type: PostgreSQL") - print(f" Host: {sonarr_db_host}:{sonarr_db_port}") - print(f" Database: {sonarr_db_name}") - print(f" User: {sonarr_db_user}") - - if not sonarr_db_host or not sonarr_db_name: - print(f" Status: ⚠️ NOT CONFIGURED (missing host or database name)") - else: - try: - conn = psycopg2.connect( - host=sonarr_db_host, - port=int(sonarr_db_port), - database=sonarr_db_name, - user=sonarr_db_user, - password=sonarr_db_password - ) - cursor = conn.cursor() - cursor.execute("SELECT 1") - cursor.close() - conn.close() - print(f" Status: ✅ CONNECTED - Using direct database access") - except Exception as e: - print(f" Status: ❌ ERROR - {str(e)[:50]}") - - elif sonarr_db_type == "sqlite": - sonarr_db_path = os.environ.get("SONARR_DB_PATH", "") - print(f" Type: SQLite") - print(f" Path: {sonarr_db_path}") - - if not sonarr_db_path: - print(f" Status: ⚠️ NOT CONFIGURED (missing database path)") - elif not Path(sonarr_db_path).exists(): - print(f" Status: ❌ ERROR - Database file not found") - else: - try: - conn = sqlite3.connect(sonarr_db_path) - cursor = conn.cursor() - cursor.execute("SELECT 1") - cursor.close() - conn.close() - print(f" Status: ✅ CONNECTED - Using direct database access") - except Exception as e: - print(f" Status: ❌ ERROR - {str(e)[:50]}") + for inst in config.radarr_instances: + status = registry.radarr_status(inst.name) + if not status["connected"]: + print(f" [{inst.name}] ⚠️ No client — check URL, API key, and DB settings in .env") + elif status["method"] == "direct_db": + print(f" [{inst.name}] ✅ CONNECTED (direct DB)") + else: + print(f" [{inst.name}] ✅ CONNECTED (API)") + + # Sonarr instances — one line each + print(f"\n Sonarr:") + if not config.sonarr_instances: + print(f" No Sonarr instances configured") else: - print(f" Type: Not configured") - print(f" Status: ⚠️ Will use Sonarr API instead of direct database access") + for inst in config.sonarr_instances: + status = registry.sonarr_status(inst.name) + if not status["connected"]: + print(f" [{inst.name}] ⚠️ No client — check URL, API key, and DB settings in .env") + elif status["method"] == "direct_db": + print(f" [{inst.name}] ✅ CONNECTED (direct DB)") + else: + print(f" [{inst.name}] ✅ CONNECTED (API)") + + # Summary warning — flag any instance without a working client + no_client = ( + [n for n, s in registry.all_radarr_statuses().items() if not s["connected"]] + + [n for n, s in registry.all_sonarr_statuses().items() if not s["connected"]] + ) + if no_client: + print(f"\n ⚠️ {len(no_client)} instance(s) have no client: {', '.join(no_client)}") + print(f" Webhooks received for these instances will be ignored until resolved.") print("\n" + "="*70 + "\n") @@ -370,14 +279,17 @@ def main(): _log("INFO", f"Config: manage_nfo={config.manage_nfo}, fix_mtimes={config.fix_dir_mtimes}") _log("INFO", f"Movie priority: {config.movie_priority}") + # Build registry once — used for connection status display and component init + registry = build_registry(config) + # Test and display all database connections - test_database_connections() - + test_database_connections(registry) + # Create FastAPI app app = create_app() - + # Initialize components - dependencies = initialize_components() + dependencies = initialize_components(registry=registry) # Note: Authentication and web interface handled by separate chronarr-web container _log("INFO", "Core API: Authentication handled by separate web container") diff --git a/processors/movie_processor.py b/processors/movie_processor.py index 9a1c685..ef1e157 100644 --- a/processors/movie_processor.py +++ b/processors/movie_processor.py @@ -1,7 +1,4 @@ -""" -Movie Processor for Chronarr -Handles movie processing and metadata management -""" +"""Movie processing — date discovery and DB writes for Radarr-managed movies.""" import os import re import xml.etree.ElementTree as ET @@ -18,7 +15,7 @@ from config.settings import config from utils.logging import _log from utils.imdb_utils import find_imdb_in_directory # Phase 3: Replaced NFOManager -from utils.file_utils import find_media_path_by_imdb_and_title +from utils.file_utils import find_media_path_by_imdb_and_title, list_video_files_with_retry def _get_local_timezone(): @@ -67,111 +64,97 @@ def convert_utc_to_local(utc_iso_string: str) -> str: class MovieProcessor: - """Handles movie processing""" - def __init__(self, db: ChronarrDatabase, nfo_manager, path_mapper: PathMapper): - # nfo_manager parameter kept for backward compatibility but no longer used (Phase 3) + def __init__(self, db: ChronarrDatabase, nfo_manager, path_mapper: PathMapper, radarr_client=None, registry=None): + # nfo_manager kept for call-site compat but is unused self.db = db self.path_mapper = path_mapper + # InstanceRegistry — lets per-call `instance` params resolve the right + # client/mapper instead of always using the default instance below. + # None in the legacy single-instance/test construction path. + self.registry = registry - # Try database client first, fall back to API client - self.radarr_db = None - self.radarr_api = None - self.using_db = False - - try: - self.radarr_db = RadarrDbClient.from_env() - if self.radarr_db: - _log("INFO", "Using Radarr direct database access") - self.radarr = self.radarr_db # Primary client + if radarr_client: + # Pre-built client from InstanceRegistry (preferred path) + self.radarr = radarr_client + self.using_db = isinstance(radarr_client, RadarrDbClient) + else: + # Fallback: construct from env vars (single-instance legacy path) + try: + self.radarr = RadarrDbClient.from_env() + if not self.radarr: + raise Exception("Database not configured") self.using_db = True - else: - raise Exception("Database not configured") - except Exception: - # Fall back to API client - self.radarr_api = RadarrClient( - os.environ.get("RADARR_URL", ""), - os.environ.get("RADARR_API_KEY", "") - ) - self.radarr = self.radarr_api # Primary client - _log("INFO", "Using Radarr API client (database not configured)") + _log("INFO", "Using Radarr direct database access") + except Exception: + self.radarr = RadarrClient( + os.environ.get("RADARR_URL", ""), + os.environ.get("RADARR_API_KEY", "") + ) + self.using_db = False + _log("INFO", "Using Radarr API client (database not configured)") self.external_clients = ExternalClientManager() - - def find_movie_path(self, movie_title: str, imdb_id: str, radarr_path: str = None) -> Optional[Path]: + + def _resolve_radarr(self, instance: str): + """Return (client, using_db, path_mapper) for a named instance. + + Looks the instance up in the InstanceRegistry so per-call `instance` + params actually pick the right Radarr server instead of every call + silently using whichever instance was wired in at construction time. + Falls back to the default-instance attributes when there's no + registry (legacy/test construction) or the instance isn't found. + """ + if self.registry: + client = self.registry.radarr(instance) + if client is not None: + mapper = self.registry.radarr_mapper(instance) or self.path_mapper + return client, isinstance(client, RadarrDbClient), mapper + _log("WARNING", f"[{instance}] No Radarr client in registry — falling back to default instance") + return self.radarr, self.using_db, self.path_mapper + + def find_movie_path(self, movie_title: str, imdb_id: str, radarr_path: str = None, instance: str = 'radarr') -> Optional[Path]: """Find movie directory path using unified file utilities""" + _, _, path_mapper = self._resolve_radarr(instance) + # Scope the fallback directory scan to this instance's own configured + # paths, not every instance's (config.movie_paths) — see + # TVProcessor.find_series_path for why (an unrelated instance's + # unreadable path shouldn't be able to crash this one's lookup). + instance_movie_paths = [Path(p) for p in path_mapper.container_paths] if path_mapper.container_paths else config.movie_paths return find_media_path_by_imdb_and_title( title=movie_title, imdb_id=imdb_id, - search_paths=config.movie_paths, + search_paths=instance_movie_paths, webhook_path=radarr_path, - path_mapper=self.path_mapper + path_mapper=path_mapper ) - def should_skip_movie(self, imdb_id: str, movie_name: str = "") -> Tuple[bool, str]: - """ - Determine if we should skip processing this movie based on completion status - - Args: - imdb_id: Movie IMDb ID - movie_name: Movie name for logging - - Returns: - (should_skip: bool, reason: str) - """ + def should_skip_movie(self, imdb_id: str, movie_name: str = "", instance: str = 'radarr') -> Tuple[bool, str]: + """Return (should_skip, reason) — skip when date, source, and video file are all present.""" try: - with self.db.get_connection() as conn: - cursor = conn.cursor() - - if self.db.db_type == "postgresql": - cursor.execute(""" - SELECT dateadded, source, has_video_file - FROM movies - WHERE imdb_id = %s - """, (imdb_id,)) - else: - cursor.execute(""" - SELECT dateadded, source, has_video_file - FROM movies - WHERE imdb_id = ? - """, (imdb_id,)) - - result = cursor.fetchone() - if not result: - return False, "No database record found" - - if self.db.db_type == "postgresql": - dateadded = result['dateadded'] - source = result['source'] - has_video_file = result['has_video_file'] - else: - dateadded = result[0] if result[0] else None - source = result[1] if result[1] else None - has_video_file = result[2] if result[2] else False - - # Skip if: - # 1. Movie has a valid dateadded timestamp - # 2. Source is valid (not 'unknown' or 'no_valid_date_source') - # 3. Has video file on disk - if (dateadded and - source and - source not in ['unknown', 'no_valid_date_source'] and - has_video_file): - return True, f"Complete: Has valid date '{dateadded}' from source '{source}'" - elif not dateadded: - return False, "Missing dateadded" - elif not source or source in ['unknown', 'no_valid_date_source']: - return False, f"Invalid source: '{source}'" - elif not has_video_file: - return False, "No video file detected" - else: - return False, "Incomplete movie data" - + result = self.db.get_movie_dates(imdb_id, instance) + if not result: + return False, "No database record found" + + dateadded = result.get('dateadded') + source = result.get('source') + has_video_file = result.get('has_video_file', False) + + if dateadded and source and source not in ('unknown', 'no_valid_date_source') and has_video_file: + return True, f"Complete: Has valid date '{dateadded}' from source '{source}'" + if not dateadded: + return False, "Missing dateadded" + if not source or source in ('unknown', 'no_valid_date_source'): + return False, f"Invalid source: '{source}'" + if not has_video_file: + return False, "No video file detected" + return False, "Incomplete movie data" + except Exception as e: _log("ERROR", f"Error checking movie completion for {imdb_id}: {e}") return False, f"Error checking completion: {e}" - def process_movie(self, movie_path: Path, webhook_mode: bool = False, force_scan: bool = False, scan_mode: str = "smart", shutdown_event=None, imdb_id: str = None) -> str: + def process_movie(self, movie_path: Path, webhook_mode: bool = False, force_scan: bool = False, scan_mode: str = "smart", shutdown_event=None, imdb_id: str = None, instance: str = 'radarr') -> str: """Process a movie directory""" # Prefer the IMDb ID passed in (e.g. from webhook payload) over filesystem detection. # Filesystem detection only works when the ID is embedded in the folder/file name, @@ -179,68 +162,67 @@ def process_movie(self, movie_path: Path, webhook_mode: bool = False, force_scan if not imdb_id: imdb_id = find_imdb_in_directory(movie_path) if not imdb_id: - _log("ERROR", f"No IMDb ID found in movie directory, filenames, or NFO file: {movie_path}") + _log("ERROR", f"[{instance}] No IMDb ID found in movie directory, filenames, or NFO file: {movie_path}") return "error" # Handle TMDB ID fallback case is_tmdb_fallback = imdb_id.startswith("tmdb-") if is_tmdb_fallback: - _log("INFO", f"Processing movie: {movie_path.name} (TMDB: {imdb_id})") + _log("INFO", f"[{instance}] Processing movie: {movie_path.name} (TMDB: {imdb_id})") else: - _log("INFO", f"Processing movie: {movie_path.name} (IMDb: {imdb_id})") + _log("INFO", f"[{instance}] Processing movie: {movie_path.name} (IMDb: {imdb_id})") # Check if we should skip this movie (unless forced, webhook mode, or incomplete mode) # Skip database optimization for incomplete mode since we need to check NFO files first if not force_scan and not webhook_mode and scan_mode != "incomplete": - should_skip, reason = self.should_skip_movie(imdb_id, movie_path.name) + should_skip, reason = self.should_skip_movie(imdb_id, movie_path.name, instance=instance) if should_skip: - _log("INFO", f"⏭️ SKIPPING MOVIE: {movie_path.name} [{imdb_id}] - {reason}") - # Still update the movie record to track that we've seen it - self.db.upsert_movie(imdb_id, str(movie_path)) + _log("INFO", f"[{instance}] ⏭️ SKIPPING MOVIE: {movie_path.name} [{imdb_id}] - {reason}") + self.db.upsert_movie(imdb_id, str(movie_path), instance=instance) return "skipped" else: - _log("INFO", f"🎬 PROCESSING MOVIE: {movie_path.name} [{imdb_id}] - {reason}") + _log("INFO", f"[{instance}] 🎬 PROCESSING MOVIE: {movie_path.name} [{imdb_id}] - {reason}") elif force_scan: - _log("INFO", f"🔄 FORCE PROCESSING MOVIE: {movie_path.name} [{imdb_id}] - Force scan enabled") + _log("INFO", f"[{instance}] 🔄 FORCE PROCESSING MOVIE: {movie_path.name} [{imdb_id}] - Force scan enabled") else: - _log("INFO", f"📥 WEBHOOK PROCESSING MOVIE: {movie_path.name} [{imdb_id}] - Webhook mode") + _log("INFO", f"[{instance}] 📥 WEBHOOK PROCESSING MOVIE: {movie_path.name} [{imdb_id}] - Webhook mode") # Check for shutdown signal early in processing if shutdown_event and shutdown_event.is_set(): - _log("INFO", f"⚠️ SHUTDOWN SIGNAL RECEIVED - Stopping movie processing: {movie_path.name}") + _log("INFO", f"[{instance}] ⚠️ SHUTDOWN SIGNAL RECEIVED - Stopping movie processing: {movie_path.name}") return "shutdown" # Update database - self.db.upsert_movie(imdb_id, str(movie_path)) - - # Check for video files - video_exts = (".mkv", ".mp4", ".avi", ".mov", ".m4v") - has_video = any(f.is_file() and f.suffix.lower() in video_exts for f in movie_path.iterdir()) + self.db.upsert_movie(imdb_id, str(movie_path), instance=instance) + # Check for video files — retries internally on a transient OSError + # (e.g. a network/FUSE mount reporting ENOTCONN for a just-created + # file) instead of failing the whole webhook on a one-off blip. + has_video = len(list_video_files_with_retry(movie_path)) > 0 + if not has_video: - _log("WARNING", f"No video files found in: {movie_path} - skipping database entry") + _log("WARNING", f"[{instance}] No video files found in: {movie_path} - skipping database entry") return "no_video_files" - # For incomplete mode: Start with NFO check to find missing dateadded elements if scan_mode == "incomplete": - return self._process_movie_nfo_first(movie_path, imdb_id, shutdown_event) + return self._process_movie_nfo_first(movie_path, imdb_id, shutdown_event, instance=instance) # For smart/full modes: Use database-first optimization # TIER 1: Check database first (fastest - local lookup) - existing = self.db.get_movie_dates(imdb_id) - _log("DEBUG", f"Database lookup for {imdb_id}: {existing}") + existing = self.db.get_movie_dates(imdb_id, instance) + _log("DEBUG", f"[{instance}] Database lookup for {imdb_id}: {existing}") # Enhanced debug for database state if existing: has_dateadded = bool(existing.get("dateadded")) source_value = existing.get("source") - _log("INFO", f"🔍 TIER 1 DEBUG - {imdb_id}: has_dateadded={has_dateadded}, source='{source_value}', dateadded='{existing.get('dateadded')}'") + _log("INFO", f"[{instance}] 🔍 TIER 1 DEBUG - {imdb_id}: has_dateadded={has_dateadded}, source='{source_value}', dateadded='{existing.get('dateadded')}'") else: - _log("INFO", f"🔍 TIER 1 DEBUG - {imdb_id}: No database record found") + _log("INFO", f"[{instance}] 🔍 TIER 1 DEBUG - {imdb_id}: No database record found") # If we have complete data in database, use it and skip all other checks if existing and existing.get("dateadded") and existing.get("source") != "no_valid_date_source": - _log("INFO", f"✅ TIER 1 - Using complete database data for {imdb_id}: {existing['dateadded']} (source: {existing['source']})") + _log("INFO", f"[{instance}] ✅ TIER 1 - Using complete database data for {imdb_id}: {existing['dateadded']} (source: {existing['source']})") dateadded, source, released = existing["dateadded"], existing["source"], existing.get("released") # Convert datetime objects to strings for NFO manager @@ -252,43 +234,44 @@ def process_movie(self, movie_path: Path, webhook_mode: bool = False, force_scan # NFO file operations removed - database is now the single source of truth # (Phase 1: Remove NFO file write operations) - _log("INFO", f"Completed processing movie: {movie_path.name} (source: {source}) [database-cached]") + _log("INFO", f"[{instance}] Completed processing movie: {movie_path.name} (source: {source}) [database-cached]") return "processed" else: - _log("INFO", f"🔍 TIER 1 SKIP - {imdb_id}: Database incomplete, proceeding to Tier 2") + _log("INFO", f"[{instance}] 🔍 TIER 1 SKIP - {imdb_id}: Database incomplete, proceeding to Tier 2") # TIER 2: Query external APIs directly (NFO layer removed in Phase 2) - _log("INFO", f"🔍 TIER 2 - No database cache, querying external APIs") + _log("INFO", f"[{instance}] 🔍 TIER 2 - No database cache, querying external APIs") # Fetch title/year from Radarr now so we can store them alongside dates - radarr_meta = self.radarr.movie_by_imdb(imdb_id) if self.radarr else None + radarr_client, _, _ = self._resolve_radarr(instance) + radarr_meta = radarr_client.movie_by_imdb(imdb_id) if radarr_client else None title = radarr_meta.get("title") if radarr_meta else None year = radarr_meta.get("year") if radarr_meta else None # Check for shutdown signal before expensive API operations if shutdown_event and shutdown_event.is_set(): - _log("INFO", f"⚠️ SHUTDOWN SIGNAL RECEIVED - Stopping movie processing before API calls: {movie_path.name}") + _log("INFO", f"[{instance}] ⚠️ SHUTDOWN SIGNAL RECEIVED - Stopping movie processing before API calls: {movie_path.name}") return "shutdown" # TIER 3: No cached data found - determine if we should query APIs if webhook_mode: - _log("INFO", f"Webhook processing - no cached data found, using full date decision logic") + _log("INFO", f"[{instance}] Webhook processing - no cached data found, using full date decision logic") should_query = True # Always query for webhooks when no cached data exists else: # Manual scan mode - determine if we should query APIs should_query = config.movie_poll_mode == "always" - _log("DEBUG", f"Movie {imdb_id}: should_query={should_query}, poll_mode={config.movie_poll_mode}") + _log("DEBUG", f"[{instance}] Movie {imdb_id}: should_query={should_query}, poll_mode={config.movie_poll_mode}") # Use existing movie date decision logic # Pass NFO fallback data if available for cases where external APIs don't have import history nfo_fallback = locals().get('nfo_fallback_data', None) - dateadded, source, released = self._decide_movie_dates(imdb_id, movie_path, should_query, nfo_fallback) + dateadded, source, released = self._decide_movie_dates(imdb_id, movie_path, should_query, nfo_fallback, instance=instance) # Webhook fallback: if ALL date sources fail, use current timestamp if webhook_mode and dateadded is None: local_tz = _get_local_timezone() current_time = datetime.now(local_tz).isoformat(timespec="seconds") - _log("INFO", f"Webhook processing - all date sources failed, using current timestamp as last resort: {current_time}") + _log("INFO", f"[{instance}] Webhook processing - all date sources failed, using current timestamp as last resort: {current_time}") dateadded, source = current_time, "webhook:fallback_timestamp" # If we don't have an import/download date but we have a release date, use it as dateadded @@ -299,57 +282,54 @@ def process_movie(self, movie_path: Path, webhook_mode: bool = False, force_scan if dateadded is None and released is not None: final_dateadded = released final_source = f"{source}_as_dateadded" if source else "release_date_fallback" - _log("INFO", f"Using release date as dateadded: {final_dateadded} (source: {final_source})") + _log("INFO", f"[{instance}] Using release date as dateadded: {final_dateadded} (source: {final_source})") # NFO file operations removed - database is now the single source of truth # (Phase 1: Remove NFO file write operations) # Skip remaining processing if no valid date found and file dates disabled if final_dateadded is None: - _log("WARNING", f"Movie {movie_path.name} - no valid date source available, but NFO was still processed") - self.db.upsert_movie_dates(imdb_id, released, None, source, True, title=title, year=year) + _log("WARNING", f"[{instance}] Movie {movie_path.name} - no valid date source available, but NFO was still processed") + self.db.upsert_movie_dates(imdb_id, released, None, source, True, title=title, year=year, instance=instance) return "processed" # Update dateadded and source for the rest of processing dateadded = final_dateadded source = final_source - _log("DEBUG", f"Movie {movie_path.name} proceeding to save: dateadded={dateadded}, source={source}") + _log("DEBUG", f"[{instance}] Movie {movie_path.name} proceeding to save: dateadded={dateadded}, source={source}") # File mtime operations removed - database is now the single source of truth # (Phase 1: Remove NFO file write operations) - _log("DEBUG", f"Movie processing reached file mtime section: fix_dir_mtimes={config.fix_dir_mtimes}, dateadded={dateadded}") + _log("DEBUG", f"[{instance}] Movie processing reached file mtime section: fix_dir_mtimes={config.fix_dir_mtimes}, dateadded={dateadded}") # Save to database - _log("DEBUG", f"About to save to database: imdb_id={imdb_id}, dateadded={dateadded}") + _log("DEBUG", f"[{instance}] About to save to database: imdb_id={imdb_id}, dateadded={dateadded}") try: - self.db.upsert_movie_dates(imdb_id, released, dateadded, source, True, title=title, year=year) - _log("DEBUG", f"Database save completed for {imdb_id}") + self.db.upsert_movie_dates(imdb_id, released, dateadded, source, True, title=title, year=year, instance=instance) + _log("DEBUG", f"[{instance}] Database save completed for {imdb_id}") except Exception as e: - _log("ERROR", f"Database save failed for {imdb_id}: {e}") + _log("ERROR", f"[{instance}] Database save failed for {imdb_id}: {e}") raise - _log("INFO", f"Completed processing movie: {movie_path.name} (source: {source})") + _log("INFO", f"[{instance}] Completed processing movie: {movie_path.name} (source: {source})") return "processed" - def _process_movie_nfo_first(self, movie_path: Path, imdb_id: str, shutdown_event=None) -> str: + def _process_movie_nfo_first(self, movie_path: Path, imdb_id: str, shutdown_event=None, instance: str = 'radarr') -> str: """Process movie for incomplete mode: Database-first then API (NFO checks removed in Phase 2)""" - _log("INFO", f"🔍 INCOMPLETE MODE: Checking movie for missing data: {movie_path.name}") + _log("INFO", f"[{instance}] 🔍 INCOMPLETE MODE: Checking movie for missing data: {movie_path.name}") - # Check for shutdown signal if shutdown_event and shutdown_event.is_set(): - _log("INFO", f"⚠️ SHUTDOWN SIGNAL RECEIVED - Stopping movie processing: {movie_path.name}") + _log("INFO", f"[{instance}] ⚠️ SHUTDOWN SIGNAL RECEIVED - Stopping movie processing: {movie_path.name}") return "shutdown" - # STEP 1: Check database for existing data (Phase 2: NFO check removed) - _log("DEBUG", f"STEP 1 - Checking database for existing data") - existing = self.db.get_movie_dates(imdb_id) + existing = self.db.get_movie_dates(imdb_id, instance) if existing and existing.get("dateadded") and existing.get("source") != "no_valid_date_source": # Found in database - data is complete - _log("INFO", f"✅ Database has dateadded={existing['dateadded']}") + _log("INFO", f"[{instance}] ✅ Database has dateadded={existing['dateadded']}") dateadded, source, released = existing["dateadded"], existing["source"], existing.get("released") # Convert datetime objects to strings @@ -358,15 +338,15 @@ def _process_movie_nfo_first(self, movie_path: Path, imdb_id: str, shutdown_even if released and hasattr(released, 'isoformat'): released = released.isoformat() - _log("INFO", f"Completed processing movie: {movie_path.name} (source: {source}) [database-cached]") + _log("INFO", f"[{instance}] Completed processing movie: {movie_path.name} (source: {source}) [database-cached]") return "processed" # STEP 2: Database incomplete or missing, query APIs - _log("DEBUG", f"STEP 2 - Querying APIs for missing data") + _log("DEBUG", f"[{instance}] STEP 2 - Querying APIs for missing data") # Check for shutdown signal before API calls if shutdown_event and shutdown_event.is_set(): - _log("INFO", f"⚠️ SHUTDOWN SIGNAL RECEIVED - Stopping before API calls: {movie_path.name}") + _log("INFO", f"[{instance}] ⚠️ SHUTDOWN SIGNAL RECEIVED - Stopping before API calls: {movie_path.name}") return "shutdown" # Handle TMDB ID fallback case @@ -374,9 +354,9 @@ def _process_movie_nfo_first(self, movie_path: Path, imdb_id: str, shutdown_even if is_tmdb_fallback: # TMDB fallback processing - use file modification time - _log("INFO", f"🔍 TMDB fallback processing for {imdb_id}") + _log("INFO", f"[{instance}] 🔍 TMDB fallback processing for {imdb_id}") dateadded, source, released = self._get_file_mtime_date(movie_path) - _log("INFO", f"Using file mtime for TMDB movie: {dateadded}") + _log("INFO", f"[{instance}] Using file mtime for TMDB movie: {dateadded}") else: # Standard IMDb processing # Try to get digital release date from external APIs @@ -386,39 +366,41 @@ def _process_movie_nfo_first(self, movie_path: Path, imdb_id: str, shutdown_even dateadded = digital_date source = digital_source released = digital_date # For movies, digital release is often the key date - _log("INFO", f"Got digital release date from APIs: {dateadded} (source: {source})") + _log("INFO", f"[{instance}] Got digital release date from APIs: {dateadded} (source: {source})") else: # Last resort: file modification time dateadded, source, released = self._get_file_mtime_date(movie_path) - _log("INFO", f"Using file mtime as fallback: {dateadded}") + _log("INFO", f"[{instance}] Using file mtime as fallback: {dateadded}") - # Save to database only (NFO operations removed in Phase 1) if dateadded: - radarr_meta = self.radarr.movie_by_imdb(imdb_id) if self.radarr else None + radarr_client, _, _ = self._resolve_radarr(instance) + radarr_meta = radarr_client.movie_by_imdb(imdb_id) if radarr_client else None title = radarr_meta.get("title") if radarr_meta else None year = radarr_meta.get("year") if radarr_meta else None - self.db.upsert_movie_dates(imdb_id, released, dateadded, source, True, title=title, year=year) + self.db.upsert_movie_dates(imdb_id, released, dateadded, source, True, title=title, year=year, instance=instance) - _log("INFO", f"🔍 INCOMPLETE MODE COMPLETE: {movie_path.name} (source: {source})") + _log("INFO", f"[{instance}] 🔍 INCOMPLETE MODE COMPLETE: {movie_path.name} (source: {source})") return "processed" else: - _log("WARNING", f"Could not determine dateadded for movie: {movie_path.name}") + _log("WARNING", f"[{instance}] Could not determine dateadded for movie: {movie_path.name}") return "error" # NFO helper methods removed in Phase 2 - database is the single source of truth - def _decide_movie_dates(self, imdb_id: str, movie_path: Path, should_query: bool, existing: Optional[Dict]) -> Tuple[str, str, Optional[str]]: + def _decide_movie_dates(self, imdb_id: str, movie_path: Path, should_query: bool, existing: Optional[Dict], instance: str = 'radarr') -> Tuple[str, str, Optional[str]]: """Decide movie dates based on configuration and available data""" - _log("DEBUG", f"_decide_movie_dates for {imdb_id}: should_query={should_query}, existing={existing}") - + _log("DEBUG", f"[{instance}] _decide_movie_dates for {imdb_id}: should_query={should_query}, existing={existing}") + if not should_query and existing: - _log("DEBUG", f"Using existing data without querying: dateadded={existing.get('dateadded')}, source={existing.get('source')}") + _log("DEBUG", f"[{instance}] Using existing data without querying: dateadded={existing.get('dateadded')}, source={existing.get('source')}") return existing["dateadded"], existing["source"], existing.get("released") - + + radarr_client, _, _ = self._resolve_radarr(instance) + # Query Radarr for movie info (database or API client) radarr_movie = None - if should_query and self.radarr: - radarr_movie = self.radarr.movie_by_imdb(imdb_id) + if should_query and radarr_client: + radarr_movie = radarr_client.movie_by_imdb(imdb_id) released = None if radarr_movie: @@ -430,50 +412,50 @@ def _decide_movie_dates(self, imdb_id: str, movie_path: Path, should_query: bool if radarr_movie: movie_id = radarr_movie.get("id") if movie_id: - import_date, import_source = self.radarr.get_movie_import_date(movie_id, fallback_to_file_date=config.allow_file_date_fallback) - _log("INFO", f"Movie {imdb_id}: Radarr import result: date={import_date}, source={import_source}") + import_date, import_source = radarr_client.get_movie_import_date(movie_id, fallback_to_file_date=config.allow_file_date_fallback) + _log("INFO", f"[{instance}] Movie {imdb_id}: Radarr import result: date={import_date}, source={import_source}") # Check for special case: rename-first scenario (should prefer release dates) if import_source == "radarr:db.prefer_release_dates": - _log("INFO", f"🎯 Movie {imdb_id} has rename-first history - skipping import, preferring release dates") + _log("INFO", f"[{instance}] 🎯 Movie {imdb_id} has rename-first history - skipping import, preferring release dates") # Fall through to release date logic below # Check if we got a real import date or just file date fallback elif import_date and import_source != "radarr:db.file.dateAdded": # Convert import date to local timezone for NFO files local_import_date = convert_utc_to_local(import_date) - _log("INFO", f"✅ Movie {imdb_id}: Using import date {local_import_date} from {import_source}") + _log("INFO", f"[{instance}] ✅ Movie {imdb_id}: Using import date {local_import_date} from {import_source}") return local_import_date, import_source, released # Get digital release date for comparison/fallback - _log("INFO", f"🔍 Movie {imdb_id}: Trying digital release date fallback...") + _log("INFO", f"[{instance}] 🔍 Movie {imdb_id}: Trying digital release date fallback...") digital_date, digital_source = self._get_digital_release_date(imdb_id) - _log("INFO", f"Movie {imdb_id}: Digital release result: date={digital_date}, source={digital_source}") + _log("INFO", f"[{instance}] Movie {imdb_id}: Digital release result: date={digital_date}, source={digital_source}") # If we only have file date and release date exists, prefer it if reasonable and enabled if import_date and import_source == "radarr:db.file.dateAdded" and digital_date and config.prefer_release_dates_over_file_dates: # Compare dates - prefer release date if it's reasonable if self._should_prefer_release_over_file_date(digital_date, digital_source, released, imdb_id): - _log("INFO", f"✅ Movie {imdb_id}: Preferring digital release date {digital_date} over file date") + _log("INFO", f"[{instance}] ✅ Movie {imdb_id}: Preferring digital release date {digital_date} over file date") # When using digital release date, store it as both dateadded and released return digital_date, digital_source, digital_date else: # Convert file date to local timezone for NFO files local_file_date = convert_utc_to_local(import_date) - _log("INFO", f"✅ Movie {imdb_id}: Keeping file date {local_file_date} - digital date not reasonable") + _log("INFO", f"[{instance}] ✅ Movie {imdb_id}: Keeping file date {local_file_date} - digital date not reasonable") return local_file_date, import_source, released # Use whichever we have if import_date: # Convert import date to local timezone for NFO files local_import_date = convert_utc_to_local(import_date) - _log("INFO", f"✅ Movie {imdb_id}: Using import date {local_import_date} from {import_source}") + _log("INFO", f"[{instance}] ✅ Movie {imdb_id}: Using import date {local_import_date} from {import_source}") return local_import_date, import_source, released elif digital_date: - _log("INFO", f"✅ Movie {imdb_id}: Using digital release date {digital_date} from {digital_source}") + _log("INFO", f"[{instance}] ✅ Movie {imdb_id}: Using digital release date {digital_date} from {digital_source}") # When using digital release date, store it as both dateadded and released return digital_date, digital_source, digital_date else: - _log("WARNING", f"⚠️ Movie {imdb_id}: No import date OR digital release date found") + _log("WARNING", f"[{instance}] ⚠️ Movie {imdb_id}: No import date OR digital release date found") else: # digital_then_import # Try digital release first @@ -486,7 +468,7 @@ def _decide_movie_dates(self, imdb_id: str, movie_path: Path, should_query: bool if radarr_movie: movie_id = radarr_movie.get("id") if movie_id: - import_date, import_source = self.radarr.get_movie_import_date(movie_id, fallback_to_file_date=config.allow_file_date_fallback) + import_date, import_source = radarr_client.get_movie_import_date(movie_id, fallback_to_file_date=config.allow_file_date_fallback) if import_date: # Convert import date to local timezone for NFO files local_import_date = convert_utc_to_local(import_date) @@ -494,14 +476,14 @@ def _decide_movie_dates(self, imdb_id: str, movie_path: Path, should_query: bool # Last resort: check if we have NFO fallback data (when external APIs don't have import history) if existing and existing.get('dateadded'): - _log("INFO", f"✅ Movie {imdb_id}: External APIs don't have import history, using NFO fallback date: {existing['dateadded']} (source: {existing['source']})") + _log("INFO", f"[{instance}] ✅ Movie {imdb_id}: External APIs don't have import history, using NFO fallback date: {existing['dateadded']} (source: {existing['source']})") return existing["dateadded"], f"nfo_fallback:{existing['source']}", existing.get("released") # Last resort: file mtime (if allowed) if config.allow_file_date_fallback: return self._get_file_mtime_date(movie_path) else: - _log("INFO", f"No valid dates found for {imdb_id} and file date fallback disabled - skipping NFO creation") + _log("INFO", f"[{instance}] No valid dates found for {imdb_id} and file date fallback disabled - skipping NFO creation") # Log to failed movies debug file for troubleshooting self._log_failed_movie(movie_path, imdb_id, "No import date, no release date, file date fallback disabled") diff --git a/processors/tv_processor.py b/processors/tv_processor.py index ca9c76c..f0b4d56 100644 --- a/processors/tv_processor.py +++ b/processors/tv_processor.py @@ -1,7 +1,4 @@ -""" -TV Series Processor for Chronarr -Handles TV series processing and episode management with async I/O support -""" +"""TV series processing — episode date discovery and DB writes for Sonarr-managed series.""" import os import re import time @@ -21,7 +18,8 @@ from utils.file_utils import ( find_media_path_by_imdb_and_title, find_episodes_on_disk, - extract_title_from_directory_name + extract_title_from_directory_name, + list_video_files_with_retry ) from utils.async_file_utils import ( async_find_episodes_on_disk, @@ -30,155 +28,138 @@ class TVProcessor: - """Handles TV series processing""" - def __init__(self, db: ChronarrDatabase, nfo_manager, path_mapper: PathMapper): - # nfo_manager parameter kept for backward compatibility but no longer used (Phase 3) + def __init__(self, db: ChronarrDatabase, nfo_manager, path_mapper: PathMapper, sonarr_client=None, registry=None): + # nfo_manager kept for call-site compat but is unused self.db = db self.path_mapper = path_mapper + # InstanceRegistry — lets per-call `instance` params resolve the right + # client/mapper instead of always using the default instance below. + # None in the legacy single-instance/test construction path. + self.registry = registry - # Try database client first, fall back to API client - self.sonarr_db = None - self.sonarr_api = None - self.using_db = False - - try: - self.sonarr_db = SonarrDbClient.from_env() - if self.sonarr_db: - _log("INFO", "Using Sonarr direct database access") - self.sonarr = self.sonarr_db # Primary client + if sonarr_client: + # Pre-built client from InstanceRegistry (preferred path) + self.sonarr = sonarr_client + self.sonarr_db = sonarr_client if isinstance(sonarr_client, SonarrDbClient) else None + self.sonarr_api = sonarr_client if isinstance(sonarr_client, SonarrClient) else None + self.using_db = isinstance(sonarr_client, SonarrDbClient) + else: + # Fallback: construct from env vars (single-instance legacy path) + self.sonarr_db = None + self.sonarr_api = None + self.using_db = False + try: + self.sonarr_db = SonarrDbClient.from_env() + if not self.sonarr_db: + raise Exception("Database not configured") + self.sonarr = self.sonarr_db self.using_db = True - else: - raise Exception("Database not configured") - except Exception: - # Fall back to API client - self.sonarr_api = SonarrClient( - os.environ.get("SONARR_URL", ""), - os.environ.get("SONARR_API_KEY", "") - ) - self.sonarr = self.sonarr_api # Primary client - _log("INFO", "Using Sonarr API client (database not configured)") + _log("INFO", "Using Sonarr direct database access") + except Exception: + self.sonarr_api = SonarrClient( + os.environ.get("SONARR_URL", ""), + os.environ.get("SONARR_API_KEY", "") + ) + self.sonarr = self.sonarr_api + _log("INFO", "Using Sonarr API client (database not configured)") self.external_clients = ExternalClientManager() - def get_episode_import_history(self, episode_id: int) -> Optional[str]: + def _resolve_sonarr(self, instance: str): + """Return (client, using_db, path_mapper) for a named instance. + + Looks the instance up in the InstanceRegistry so per-call `instance` + params actually pick the right Sonarr server instead of every call + silently using whichever instance was wired in at construction time. + Falls back to the default-instance attributes when there's no + registry (legacy/test construction) or the instance isn't found. + """ + if self.registry: + client = self.registry.sonarr(instance) + if client is not None: + mapper = self.registry.sonarr_mapper(instance) or self.path_mapper + return client, isinstance(client, SonarrDbClient), mapper + _log("WARNING", f"[{instance}] No Sonarr client in registry — falling back to default instance") + return self.sonarr, self.using_db, self.path_mapper + + def get_episode_import_history(self, episode_id: int, instance: str = 'sonarr') -> Optional[str]: """ Get episode import history from either database or API Wraps both SonarrDbClient.get_episode_import_date and SonarrClient.get_episode_import_history """ - if self.using_db and self.sonarr_db: + client, using_db, _ = self._resolve_sonarr(instance) + if using_db and client: # Database client returns (date_iso, source) - date_iso, source = self.sonarr_db.get_episode_import_date(episode_id) + date_iso, source = client.get_episode_import_date(episode_id) return date_iso - elif self.sonarr_api: + elif client: # API client returns Optional[str] - return self.sonarr_api.get_episode_import_history(episode_id) + return client.get_episode_import_history(episode_id) else: return None - def find_series_path(self, series_title: str, imdb_id: str, sonarr_path: str = None) -> Optional[Path]: + def find_series_path(self, series_title: str, imdb_id: str, sonarr_path: str = None, instance: str = 'sonarr') -> Optional[Path]: """Find series directory path using unified file utilities""" + _, _, path_mapper = self._resolve_sonarr(instance) + # Scope the fallback directory scan to this instance's own configured + # paths, not every instance's (config.tv_paths). Otherwise a webhook + # for one instance can be crashed by a completely unrelated instance's + # path being unreadable (e.g. a stale/disconnected mount) — the scan + # would still walk into it while looking for this series. + instance_tv_paths = [Path(p) for p in path_mapper.container_paths] if path_mapper.container_paths else config.tv_paths return find_media_path_by_imdb_and_title( title=series_title, imdb_id=imdb_id, - search_paths=config.tv_paths, + search_paths=instance_tv_paths, webhook_path=sonarr_path, - path_mapper=self.path_mapper + path_mapper=path_mapper ) - def should_skip_series_fast(self, imdb_id: str, series_name: str = "") -> Tuple[bool, str, int]: - """ - Fast preliminary check to skip series without filesystem scan - - Args: - imdb_id: Series IMDb ID - series_name: Series name for logging - - Returns: - (should_skip: bool, reason: str, episodes_in_db: int) - """ + def _episode_completion_counts(self, imdb_id: str, instance: str) -> Tuple[int, int]: + """Return (total_in_db, complete_episodes) for an (imdb_id, instance) pair.""" + with self.db.get_connection() as conn: + cursor = conn.cursor() + cursor.execute(""" + SELECT + COUNT(*) AS total_in_db, + COUNT(CASE WHEN dateadded IS NOT NULL AND source IS NOT NULL + AND source NOT IN ('unknown', 'no_valid_date_source') THEN 1 END) AS complete_episodes + FROM episodes + WHERE imdb_id = %s AND instance = %s + """, (imdb_id, instance)) + row = cursor.fetchone() + if not row: + return 0, 0 + return row['total_in_db'], row['complete_episodes'] + + def should_skip_series_fast(self, imdb_id: str, series_name: str = "", instance: str = 'sonarr') -> Tuple[bool, str, int]: + """Prelim skip check without a filesystem scan — returns (skip, reason, count_in_db).""" try: - with self.db.get_connection() as conn: - cursor = conn.cursor() - - # Check if we have complete episodes in database - cursor.execute(""" - SELECT - COUNT(*) as total_in_db, - COUNT(CASE WHEN dateadded IS NOT NULL AND source IS NOT NULL AND source != 'unknown' AND source != 'no_valid_date_source' THEN 1 END) as complete_episodes - FROM episodes - WHERE imdb_id = %s - """, (imdb_id,)) - - result = cursor.fetchone() - if not result: - return False, "No database records found", 0 - - total_in_db = result['total_in_db'] - complete_episodes = result['complete_episodes'] - - # Skip if we have episodes and all are complete - # We'll verify disk count later if needed - if total_in_db > 0 and complete_episodes == total_in_db: - return True, f"Likely complete: {complete_episodes} episodes in DB all have valid dates", total_in_db - else: - return False, f"Needs checking: {complete_episodes}/{total_in_db} episodes complete in DB", total_in_db - + total_in_db, complete_episodes = self._episode_completion_counts(imdb_id, instance) + if total_in_db > 0 and complete_episodes == total_in_db: + return True, f"Likely complete: {complete_episodes} episodes in DB all have valid dates", total_in_db + return False, f"Needs checking: {complete_episodes}/{total_in_db} episodes complete in DB", total_in_db except Exception as e: _log("ERROR", f"Error in fast series check for {imdb_id}: {e}") return False, f"Error in fast check: {e}", 0 - def should_skip_series(self, imdb_id: str, episodes_on_disk: int, series_name: str = "") -> Tuple[bool, str]: - """ - Determine if we should skip processing this series based on completion status - - Args: - imdb_id: Series IMDb ID - episodes_on_disk: Number of episodes found on disk - series_name: Series name for logging - - Returns: - (should_skip: bool, reason: str) - """ + def should_skip_series(self, imdb_id: str, episodes_on_disk: int, series_name: str = "", instance: str = 'sonarr') -> Tuple[bool, str]: + """Return (should_skip, reason) — skip when DB count, disk count, and date completeness all match.""" try: - with self.db.get_connection() as conn: - cursor = conn.cursor() - - # PostgreSQL-only query - cursor.execute(""" - SELECT - COUNT(*) as total_in_db, - COUNT(CASE WHEN dateadded IS NOT NULL AND source IS NOT NULL AND source != 'unknown' AND source != 'no_valid_date_source' THEN 1 END) as complete_episodes - FROM episodes - WHERE imdb_id = %s - """, (imdb_id,)) - - result = cursor.fetchone() - if not result: - return False, "No database records found" - - # PostgreSQL RealDictCursor returns dict-like objects - total_in_db = result['total_in_db'] - complete_episodes = result['complete_episodes'] - - # Skip if: - # 1. We have episodes in database - # 2. Database count matches disk count (no missing episodes) - # 3. All episodes have valid dates and sources - if total_in_db > 0 and total_in_db == episodes_on_disk and complete_episodes == episodes_on_disk: - return True, f"Complete: {complete_episodes}/{episodes_on_disk} episodes have valid dates" - elif total_in_db == 0: - return False, f"New series: No episodes in database" - elif total_in_db != episodes_on_disk: - return False, f"Disk mismatch: {total_in_db} in DB vs {episodes_on_disk} on disk" - else: - return False, f"Incomplete: {complete_episodes}/{episodes_on_disk} episodes have valid dates" - + total_in_db, complete_episodes = self._episode_completion_counts(imdb_id, instance) + if total_in_db > 0 and total_in_db == episodes_on_disk and complete_episodes == episodes_on_disk: + return True, f"Complete: {complete_episodes}/{episodes_on_disk} episodes have valid dates" + if total_in_db == 0: + return False, "New series: No episodes in database" + if total_in_db != episodes_on_disk: + return False, f"Disk mismatch: {total_in_db} in DB vs {episodes_on_disk} on disk" + return False, f"Incomplete: {complete_episodes}/{episodes_on_disk} episodes have valid dates" except Exception as e: _log("ERROR", f"Error checking series completion for {imdb_id}: {e}") return False, f"Error checking completion: {e}" - def process_series(self, series_path: Path, force_scan: bool = False, scan_mode: str = "smart", imdb_id: str = None) -> str: + def process_series(self, series_path: Path, force_scan: bool = False, scan_mode: str = "smart", imdb_id: str = None, instance: str = 'sonarr') -> str: """Process a TV series directory""" if not imdb_id: imdb_id = parse_imdb_from_path(series_path) @@ -191,52 +172,39 @@ def process_series(self, series_path: Path, force_scan: bool = False, scan_mode: # Fast check first - avoid expensive filesystem scan if possible # Skip fast optimization for incomplete mode since we need to check NFO files first if not force_scan and scan_mode != "incomplete": - should_skip_fast, reason_fast, episodes_in_db = self.should_skip_series_fast(imdb_id, series_path.name) + should_skip_fast, reason_fast, episodes_in_db = self.should_skip_series_fast(imdb_id, series_path.name, instance=instance) if should_skip_fast: _log("INFO", f"⚡ FAST SKIP: {series_path.name} [{imdb_id}] - {reason_fast}") - # Still update the series record to track that we've seen it - self.db.upsert_series(imdb_id, str(series_path)) + self.db.upsert_series(imdb_id, str(series_path), instance=instance) return "skipped" - - # Need filesystem scan - either force_scan=True or series not complete in DB + disk_episodes = find_episodes_on_disk(series_path) _log("INFO", f"Found {len(disk_episodes)} episodes on disk") - - # Final skip check with actual episode count (unless forced) + if not force_scan: - should_skip, reason = self.should_skip_series(imdb_id, len(disk_episodes), series_path.name) + should_skip, reason = self.should_skip_series(imdb_id, len(disk_episodes), series_path.name, instance=instance) if should_skip: _log("INFO", f"⏭️ SKIPPING SERIES: {series_path.name} [{imdb_id}] - {reason}") - # Still update the series record to track that we've seen it - self.db.upsert_series(imdb_id, str(series_path)) + self.db.upsert_series(imdb_id, str(series_path), instance=instance) return "skipped" else: _log("INFO", f"📺 PROCESSING SERIES: {series_path.name} [{imdb_id}] - {reason}") else: _log("INFO", f"🔄 FORCE PROCESSING SERIES: {series_path.name} [{imdb_id}] - Force scan enabled") - - # Update database - self.db.upsert_series(imdb_id, str(series_path)) - - # Get episode dates - episode_dates = self._gather_episode_dates(series_path, imdb_id, disk_episodes) - - # Process episodes with periodic yielding for non-blocking operation + + self.db.upsert_series(imdb_id, str(series_path), instance=instance) + + episode_dates = self._gather_episode_dates(series_path, imdb_id, disk_episodes, instance=instance) + episode_count = 0 for (season, episode), (aired, dateadded, source) in episode_dates.items(): if (season, episode) in disk_episodes: episode_count += 1 - - # NFO file operations removed - database is now the single source of truth - # (Phase 1: Remove NFO file write operations) - - # Save to database try: - self.db.upsert_episode_date(imdb_id, season, episode, aired, dateadded, source, True) + self.db.upsert_episode_date(imdb_id, season, episode, aired, dateadded, source, True, instance=instance) _log("DEBUG", f"S{season:02d}E{episode:02d}: Database record saved successfully") except Exception as e: _log("ERROR", f"S{season:02d}E{episode:02d}: Database write failed: {e}") - # Continue processing other episodes # Skip season.nfo and tvshow.nfo creation - focus only on episode NFOs @@ -250,7 +218,7 @@ def _extract_series_title_from_path(self, series_path: Path) -> Optional[str]: return extract_title_from_directory_name(series_path.name) - def _gather_episode_dates(self, series_path: Path, imdb_id: str, disk_episodes: Dict[Tuple[int, int], List[Path]], scan_mode: str = "smart") -> Dict[Tuple[int, int], Tuple[Optional[str], Optional[str], str]]: + def _gather_episode_dates(self, series_path: Path, imdb_id: str, disk_episodes: Dict[Tuple[int, int], List[Path]], scan_mode: str = "smart", instance: str = 'sonarr') -> Dict[Tuple[int, int], Tuple[Optional[str], Optional[str], str]]: """Gather episode air dates and date added information with optimization based on scan mode""" _log("INFO", f"🎯 GATHERING EPISODE DATES for {imdb_id}: {len(disk_episodes)} episodes on disk (mode: {scan_mode})") episode_dates = {} @@ -258,7 +226,7 @@ def _gather_episode_dates(self, series_path: Path, imdb_id: str, disk_episodes: # For incomplete mode: Start with NFO check to find missing dateadded elements if scan_mode == "incomplete": - return self._gather_episode_dates_nfo_first(series_path, imdb_id, disk_episodes) + return self._gather_episode_dates_nfo_first(series_path, imdb_id, disk_episodes, instance=instance) # For smart/full modes: Use database-first optimization # TIER 1: Check database first for existing dates (fastest) @@ -267,8 +235,7 @@ def _gather_episode_dates(self, series_path: Path, imdb_id: str, disk_episodes: episodes_needing_nfo_check = [] for (season, episode) in disk_episodes: - # Try database first - this is much faster than API calls - db_result = self.db.get_episode_date(imdb_id, season, episode) + db_result = self.db.get_episode_date(imdb_id, season, episode, instance) if db_result and db_result.get('dateadded'): # Found in database - use cached data @@ -288,7 +255,7 @@ def _gather_episode_dates(self, series_path: Path, imdb_id: str, disk_episodes: episodes_needing_lookup = episodes_needing_nfo_check # Renamed for clarity if episodes_needing_lookup: _log("DEBUG", f"TIER 2 - Querying Sonarr for {len(episodes_needing_lookup)} episodes missing from database") - sonarr_episodes = self._get_sonarr_episodes(imdb_id, episodes_needing_lookup) + sonarr_episodes = self._get_sonarr_episodes(imdb_id, episodes_needing_lookup, instance=instance) # Process episodes that needed lookup for (season, episode) in episodes_needing_lookup: @@ -355,7 +322,7 @@ def _gather_episode_dates(self, series_path: Path, imdb_id: str, disk_episodes: return episode_dates - def _gather_episode_dates_nfo_first(self, series_path: Path, imdb_id: str, disk_episodes: Dict[Tuple[int, int], List[Path]]) -> Dict[Tuple[int, int], Tuple[Optional[str], Optional[str], str]]: + def _gather_episode_dates_nfo_first(self, series_path: Path, imdb_id: str, disk_episodes: Dict[Tuple[int, int], List[Path]], instance: str = 'sonarr') -> Dict[Tuple[int, int], Tuple[Optional[str], Optional[str], str]]: """Gather episode dates for incomplete mode: Database-first then API (NFO checks removed in Phase 2)""" _log("INFO", f"🔍 INCOMPLETE MODE: Checking {len(disk_episodes)} episodes for missing data") episode_dates = {} @@ -366,10 +333,9 @@ def _gather_episode_dates_nfo_first(self, series_path: Path, imdb_id: str, disk_ db_hits = 0 for (season, episode) in disk_episodes: - db_result = self.db.get_episode_date(imdb_id, season, episode) + db_result = self.db.get_episode_date(imdb_id, season, episode, instance) if db_result and db_result.get('dateadded'): - # Found in database - use cached data aired = db_result.get('aired') dateadded = db_result.get('dateadded') source = db_result.get('source', 'database_cache') @@ -377,7 +343,6 @@ def _gather_episode_dates_nfo_first(self, series_path: Path, imdb_id: str, disk_ db_hits += 1 _log("DEBUG", f"S{season:02d}E{episode:02d}: Database has dateadded={dateadded}") else: - # Not in database or incomplete - needs API lookup episodes_needing_api_lookup.append((season, episode)) _log("INFO", f"Database hits: {db_hits}/{len(disk_episodes)} episodes. Need API lookup: {len(episodes_needing_api_lookup)}") @@ -385,7 +350,7 @@ def _gather_episode_dates_nfo_first(self, series_path: Path, imdb_id: str, disk_ # STEP 2: For episodes missing from database, query Sonarr if episodes_needing_api_lookup: _log("DEBUG", f"STEP 2 - Querying Sonarr for {len(episodes_needing_api_lookup)} episodes missing from database") - sonarr_episodes = self._get_sonarr_episodes(imdb_id, episodes_needing_api_lookup) + sonarr_episodes = self._get_sonarr_episodes(imdb_id, episodes_needing_api_lookup, instance=instance) for (season, episode) in episodes_needing_api_lookup: aired = None @@ -426,9 +391,8 @@ def _gather_episode_dates_nfo_first(self, series_path: Path, imdb_id: str, disk_ source = f"{source}_fallback" if source != "unknown" else "aired_fallback" _log("DEBUG", f"S{season:02d}E{episode:02d}: Using aired date as dateadded fallback: {dateadded}") - # Save to database for future lookups if dateadded or aired: - self.db.upsert_episode_date(imdb_id, season, episode, aired, dateadded, source, True) + self.db.upsert_episode_date(imdb_id, season, episode, aired, dateadded, source, True, instance=instance) episode_dates[(season, episode)] = (aired, dateadded, source) @@ -438,24 +402,23 @@ def _gather_episode_dates_nfo_first(self, series_path: Path, imdb_id: str, disk_ return episode_dates - def _get_sonarr_episodes(self, imdb_id: str, episodes_filter: List[Tuple[int, int]] = None) -> Dict[Tuple[int, int], Dict[str, Any]]: + def _get_sonarr_episodes(self, imdb_id: str, episodes_filter: List[Tuple[int, int]] = None, instance: str = 'sonarr') -> Dict[Tuple[int, int], Dict[str, Any]]: """Get episode information from Sonarr including import history - optimized to only fetch needed episodes""" try: + client, using_db, _ = self._resolve_sonarr(instance) + # Handle different method names for DB vs API client - if self.using_db: - series_data = self.sonarr.get_series_by_imdb(imdb_id) + if using_db: + series_data = client.get_series_by_imdb(imdb_id) else: - series_data = self.sonarr.series_by_imdb(imdb_id) + series_data = client.series_by_imdb(imdb_id) if not series_data: # Try fuzzy matching if exact IMDb lookup fails _log("DEBUG", f"Exact IMDb lookup failed for {imdb_id}, trying fuzzy matching") # Get all series and try fuzzy matching - if self.using_db: - all_series = self.sonarr.get_all_series() - else: - all_series = self.sonarr.get_all_series() + all_series = client.get_all_series() if all_series: _log("DEBUG", f"Found {len(all_series)} total series in Sonarr") @@ -489,11 +452,11 @@ def _get_sonarr_episodes(self, imdb_id: str, episodes_filter: List[Tuple[int, in return {} # Handle different method names for DB vs API client - if self.using_db: - episodes = self.sonarr.get_all_episodes_for_series(series_id) + if using_db: + episodes = client.get_all_episodes_for_series(series_id) else: - episodes = self.sonarr.episodes_for_series(series_id) - + episodes = client.episodes_for_series(series_id) + # Convert episodes_filter to set for faster lookup filter_set = set(episodes_filter) if episodes_filter else None @@ -526,7 +489,7 @@ def _get_sonarr_episodes(self, imdb_id: str, episodes_filter: List[Tuple[int, in # First try to get import date from history (more accurate) episode_id = episode.get('id') if episode_id and episode.get('hasFile'): - import_date = self.get_episode_import_history(episode_id) + import_date = self.get_episode_import_history(episode_id, instance=instance) api_calls_made += 1 if import_date: episode_data['dateAdded'] = import_date @@ -552,58 +515,48 @@ def _get_sonarr_episodes(self, imdb_id: str, episodes_filter: List[Tuple[int, in _log("ERROR", f"Failed to get Sonarr episodes for {imdb_id}: {e}") return {} - def process_season(self, series_path: str, season_name: str) -> Dict[str, Any]: + def process_season(self, series_path: str, season_name: str, instance: str = 'sonarr') -> Dict[str, Any]: """Process a specific season""" series_path_obj = Path(series_path) if not series_path_obj.exists(): raise FileNotFoundError(f"Series path not found: {series_path}") - + season_path = series_path_obj / season_name if not season_path.exists(): raise FileNotFoundError(f"Season directory not found: {season_path}") - - # Extract season number from directory name + season_match = re.search(r'(\d+)', season_name) if not season_match: raise ValueError(f"Could not extract season number from: {season_name}") - + season_num = int(season_match.group(1)) - - # Get series IMDb ID - imdb_id = parse_imdb_from_path(series_path_obj) # Phase 3: Using imdb_utils + + imdb_id = parse_imdb_from_path(series_path_obj) if not imdb_id: raise ValueError(f"No IMDb ID found in series path: {series_path}") _log("INFO", f"Processing season {season_num} of series: {series_path_obj.name}") - - # Find episodes in this season + disk_episodes = find_episodes_on_disk(series_path_obj) season_episodes = {k: v for k, v in disk_episodes.items() if k[0] == season_num} - + if not season_episodes: return {"status": "no_episodes", "season": season_num, "episodes_found": 0} - - # Get episode dates - episode_dates = self._gather_episode_dates(series_path_obj, imdb_id, season_episodes) - - # Process episodes + + episode_dates = self._gather_episode_dates(series_path_obj, imdb_id, season_episodes, instance=instance) + processed_count = 0 for (season, episode), (aired, dateadded, source) in episode_dates.items(): if (season, episode) in season_episodes: - # NFO file operations removed - database is now the single source of truth - # (Phase 1: Remove NFO file write operations) - - # Save to database try: - self.db.upsert_episode_date(imdb_id, season, episode, aired, dateadded, source, True) + self.db.upsert_episode_date(imdb_id, season, episode, aired, dateadded, source, True, instance=instance) _log("DEBUG", f"S{season:02d}E{episode:02d}: Database record saved successfully") except Exception as e: _log("ERROR", f"S{season:02d}E{episode:02d}: Database write failed: {e}") - # Continue processing other episodes processed_count += 1 - + _log("INFO", f"Processed {processed_count} episodes in season {season_num}") - + return { "status": "success", "season": season_num, @@ -611,63 +564,56 @@ def process_season(self, series_path: str, season_name: str) -> Dict[str, Any]: "episodes_processed": processed_count } - def process_episode(self, series_path: str, season_name: str, episode_name: str) -> Dict[str, Any]: + def process_episode(self, series_path: str, season_name: str, episode_name: str, instance: str = 'sonarr') -> Dict[str, Any]: """Process a specific episode""" series_path_obj = Path(series_path) if not series_path_obj.exists(): raise FileNotFoundError(f"Series path not found: {series_path}") - + season_path = series_path_obj / season_name if not season_path.exists(): raise FileNotFoundError(f"Season directory not found: {season_path}") - + episode_path = season_path / episode_name if not episode_path.exists(): raise FileNotFoundError(f"Episode file not found: {episode_path}") - - # Extract season and episode numbers + season_match = re.search(r'(\d+)', season_name) episode_match = re.search(r'[sS](\d+)[eE](\d+)|(\d+)x(\d+)', episode_name) - + if not season_match: raise ValueError(f"Could not extract season number from: {season_name}") - + if not episode_match: raise ValueError(f"Could not extract episode number from: {episode_name}") - + season_num = int(season_match.group(1)) - - if episode_match.group(1) and episode_match.group(2): # SxxExx format + + if episode_match.group(1) and episode_match.group(2): episode_num = int(episode_match.group(2)) - elif episode_match.group(3) and episode_match.group(4): # NxNN format + elif episode_match.group(3) and episode_match.group(4): episode_num = int(episode_match.group(4)) else: raise ValueError(f"Could not parse episode number from: {episode_name}") - - # Get series IMDb ID - imdb_id = parse_imdb_from_path(series_path_obj) # Phase 3: Using imdb_utils + + imdb_id = parse_imdb_from_path(series_path_obj) if not imdb_id: raise ValueError(f"No IMDb ID found in series path: {series_path}") _log("INFO", f"Processing episode S{season_num:02d}E{episode_num:02d} of series: {series_path_obj.name}") - - # Get episode data + disk_episodes = {(season_num, episode_num): [episode_path]} - episode_dates = self._gather_episode_dates(series_path_obj, imdb_id, disk_episodes) - + episode_dates = self._gather_episode_dates(series_path_obj, imdb_id, disk_episodes, instance=instance) + if (season_num, episode_num) not in episode_dates: return {"status": "no_data", "season": season_num, "episode": episode_num} - + aired, dateadded, source = episode_dates[(season_num, episode_num)] - - # NFO file operations removed - database is now the single source of truth - # (Phase 1: Remove NFO file write operations) - - # Save to database - self.db.upsert_episode_date(imdb_id, season_num, episode_num, aired, dateadded, source, True) - + + self.db.upsert_episode_date(imdb_id, season_num, episode_num, aired, dateadded, source, True, instance=instance) + _log("INFO", f"Processed episode S{season_num:02d}E{episode_num:02d}") - + return { "status": "success", "season": season_num, @@ -679,61 +625,39 @@ def process_episode(self, series_path: str, season_name: str, episode_name: str) # ===== ASYNC METHODS ===== - async def async_process_series(self, series_path: Path) -> Dict[str, Any]: - """ - Async process a TV series directory with concurrent episode processing - - Args: - series_path: Path to series directory - - Returns: - Dictionary with processing results - """ - imdb_id = parse_imdb_from_path(series_path) # Phase 3: Using imdb_utils + async def async_process_series(self, series_path: Path, instance: str = 'sonarr') -> Dict[str, Any]: + """Async process a TV series directory with concurrent episode processing.""" + imdb_id = parse_imdb_from_path(series_path) if not imdb_id: return {"status": "error", "reason": f"No IMDb ID found in series path: {series_path}"} - + _log("INFO", f"Async processing TV series: {series_path.name}") - - # Update database - self.db.upsert_series(imdb_id, str(series_path)) - - # Find video files asynchronously + + self.db.upsert_series(imdb_id, str(series_path), instance=instance) + disk_episodes = await async_find_episodes_on_disk(series_path) _log("INFO", f"Found {len(disk_episodes)} episodes on disk") - - # Get episode dates (sync for now, could be made async later) - episode_dates = self._gather_episode_dates(series_path, imdb_id, disk_episodes) - - # Prepare episode data for concurrent processing - episode_data_list = [] - mtime_operations = [] - + + # sync for now — could be made async if episode date gathering becomes a bottleneck + episode_dates = self._gather_episode_dates(series_path, imdb_id, disk_episodes, instance=instance) + + processed_count = 0 for (season, episode), (aired, dateadded, source) in episode_dates.items(): if (season, episode) in disk_episodes: - # NFO file operations removed - database is now the single source of truth - # (Phase 1: Remove NFO file write operations) - - # Save to database try: - self.db.upsert_episode_date(imdb_id, season, episode, aired, dateadded, source, True) + self.db.upsert_episode_date(imdb_id, season, episode, aired, dateadded, source, True, instance=instance) _log("DEBUG", f"S{season:02d}E{episode:02d}: Database record saved successfully") + processed_count += 1 except Exception as e: _log("ERROR", f"S{season:02d}E{episode:02d}: Database write failed: {e}") - # Continue processing other episodes - - # NFO and mtime operations removed - database is now the single source of truth - # (Phase 1: Remove NFO file write operations) - results = {} - + _log("INFO", f"Completed async processing TV series: {series_path.name}") - + return { "status": "success", "imdb_id": imdb_id, "episodes_found": len(disk_episodes), - "episodes_processed": len(episode_data_list), - "results": results + "episodes_processed": processed_count, } async def async_process_multiple_series( @@ -780,26 +704,25 @@ async def _process_series_with_semaphore(series_path: Path) -> Dict[str, Any]: return processed_results - def process_webhook_episodes(self, series_path: Path, webhook_episodes: List[Dict[str, Any]], imdb_id: str = None) -> None: - """Process only the specific episodes mentioned in a webhook (targeted mode)""" + def process_webhook_episodes(self, series_path: Path, webhook_episodes: List[Dict[str, Any]], imdb_id: str = None, instance: str = 'sonarr') -> None: + """Process only the specific episodes mentioned in a webhook (targeted mode).""" if not imdb_id: imdb_id = parse_imdb_from_path(series_path) if not imdb_id: - _log("ERROR", f"No IMDb ID found in series path: {series_path}") + _log("ERROR", f"[{instance}] No IMDb ID found in series path: {series_path}") return - + if not webhook_episodes: - _log("WARNING", f"No episodes in webhook, falling back to series processing: {series_path}") - self.process_series(series_path) + _log("WARNING", f"[{instance}] No episodes in webhook, falling back to series processing: {series_path}") + self.process_series(series_path, instance=instance) return - - _log("INFO", f"Processing {len(webhook_episodes)} webhook episodes for: {series_path.name} (IMDb: {imdb_id})") - - # Update database - self.db.upsert_series(imdb_id, str(series_path)) + + _log("INFO", f"[{instance}] Processing {len(webhook_episodes)} webhook episodes for: {series_path.name} (IMDb: {imdb_id})") + + self.db.upsert_series(imdb_id, str(series_path), instance=instance) # Get enhanced metadata from Sonarr - series_metadata = self._get_sonarr_series_metadata(imdb_id) + series_metadata = self._get_sonarr_series_metadata(imdb_id, instance=instance) episodes_processed = 0 for webhook_episode in webhook_episodes: @@ -807,45 +730,44 @@ def process_webhook_episodes(self, series_path: Path, webhook_episodes: List[Dic episode_num = webhook_episode.get("episodeNumber") if not season_num or not episode_num: - _log("WARNING", f"Invalid episode data in webhook: {webhook_episode}") + _log("WARNING", f"[{instance}] Invalid episode data in webhook: {webhook_episode}") continue - + # Check if episode file exists on disk season_dir = series_path / config.get_season_dir_name(season_num) if not season_dir.exists(): - _log("WARNING", f"Season directory not found: {season_dir}") + _log("WARNING", f"[{instance}] Season directory not found: {season_dir}") continue - - # Find matching episode files + + # Find matching episode files — the listing itself retries internally on + # a transient OSError (e.g. a network/FUSE mount reporting ENOTCONN for + # a just-created file) instead of failing the whole webhook on a blip. episode_files = [] - for file_path in season_dir.iterdir(): - if file_path.is_file() and file_path.suffix.lower() in ('.mkv', '.mp4', '.avi', '.mov', '.m4v'): - parsed = self._parse_episode_from_filename(file_path.name) - if parsed and parsed == (season_num, episode_num): - episode_files.append(file_path) - + for file_path in list_video_files_with_retry(season_dir): + parsed = self._parse_episode_from_filename(file_path.name) + if parsed and parsed == (season_num, episode_num): + episode_files.append(file_path) + if not episode_files: - _log("WARNING", f"No video files found for S{season_num:02d}E{episode_num:02d}") + _log("WARNING", f"[{instance}] No video files found for S{season_num:02d}E{episode_num:02d}") continue - + # Get episode date information - webhook processing prioritizes existing DB entries - _log("DEBUG", f"Processing webhook episode: IMDb={imdb_id}, S{season_num:02d}E{episode_num:02d}") - aired, dateadded, source = self._get_webhook_episode_date(imdb_id, season_num, episode_num, series_metadata, webhook_episode) - enhanced_metadata = self._get_episode_metadata(series_metadata, season_num, episode_num, season_dir) if series_metadata else self._get_episode_metadata(None, season_num, episode_num, season_dir) - + _log("DEBUG", f"[{instance}] Processing webhook episode: IMDb={imdb_id}, S{season_num:02d}E{episode_num:02d}") + aired, dateadded, source = self._get_webhook_episode_date(imdb_id, season_num, episode_num, series_metadata, webhook_episode, instance=instance) + enhanced_metadata = self._get_episode_metadata(series_metadata, season_num, episode_num, season_dir, instance=instance) if series_metadata else self._get_episode_metadata(None, season_num, episode_num, season_dir, instance=instance) + # NFO file operations removed - database is now the single source of truth # (Phase 1: Remove NFO file write operations) - - # Save to database - self.db.upsert_episode_date(imdb_id, season_num, episode_num, aired, dateadded, source, True) - - # Verify database entry was saved (debug) - verification = self.db.get_episode_date(imdb_id, season_num, episode_num) + + self.db.upsert_episode_date(imdb_id, season_num, episode_num, aired, dateadded, source, True, instance=instance) + + verification = self.db.get_episode_date(imdb_id, season_num, episode_num, instance) if verification: - _log("DEBUG", f"Verified database entry saved: S{season_num:02d}E{episode_num:02d} -> {verification['dateadded']}") + _log("DEBUG", f"[{instance}] Verified database entry saved: S{season_num:02d}E{episode_num:02d} -> {verification['dateadded']}") else: - _log("ERROR", f"Failed to save episode to database: S{season_num:02d}E{episode_num:02d}") - + _log("ERROR", f"[{instance}] Failed to save episode to database: S{season_num:02d}E{episode_num:02d}") + episodes_processed += 1 # DISABLED: Skip creating season.nfo and tvshow.nfo files (user only wants episode NFOs) @@ -863,7 +785,7 @@ def process_webhook_episodes(self, series_path: Path, webhook_episodes: List[Dic # tvdb_id = self.external_clients.get_tvdb_series_id(imdb_id) # self.nfo_manager.create_tvshow_nfo(series_path, imdb_id, tvdb_id) - _log("INFO", f"Completed targeted processing: {episodes_processed}/{len(webhook_episodes)} episodes processed") + _log("INFO", f"[{instance}] Completed targeted processing: {episodes_processed}/{len(webhook_episodes)} episodes processed") def _parse_episode_from_filename(self, filename: str) -> Optional[Tuple[int, int]]: """Parse season and episode numbers from filename""" @@ -879,17 +801,18 @@ def _parse_episode_from_filename(self, filename: str) -> Optional[Tuple[int, int return None - def _get_sonarr_series_metadata(self, imdb_id: str) -> Optional[Dict[str, Any]]: + def _get_sonarr_series_metadata(self, imdb_id: str, instance: str = 'sonarr') -> Optional[Dict[str, Any]]: """Get enhanced series metadata from Sonarr (database or API)""" try: - if not self.sonarr: + client, using_db, _ = self._resolve_sonarr(instance) + if not client: return None # Handle different method names for DB vs API client - if self.using_db: - series_data = self.sonarr.get_series_by_imdb(imdb_id) + if using_db: + series_data = client.get_series_by_imdb(imdb_id) else: - series_data = self.sonarr.series_by_imdb(imdb_id) + series_data = client.series_by_imdb(imdb_id) if not series_data: return None @@ -899,10 +822,10 @@ def _get_sonarr_series_metadata(self, imdb_id: str) -> Optional[Dict[str, Any]]: return None # Get all episodes for this series - if self.using_db: - episodes = self.sonarr.get_all_episodes_for_series(series_id) + if using_db: + episodes = client.get_all_episodes_for_series(series_id) else: - episodes = self.sonarr.episodes_for_series(series_id) + episodes = client.episodes_for_series(series_id) # Organize episodes by season/episode episode_map = {} @@ -919,15 +842,15 @@ def _get_sonarr_series_metadata(self, imdb_id: str) -> Optional[Dict[str, Any]]: } except Exception as e: - _log("ERROR", f"Failed to get Sonarr series metadata for {imdb_id}: {e}") + _log("ERROR", f"[{instance}] Failed to get Sonarr series metadata for {imdb_id}: {e}") return None - - def _get_episode_metadata(self, series_metadata: Optional[Dict[str, Any]], season_num: int, episode_num: int, season_dir: Optional[Path] = None) -> Optional[Dict[str, Any]]: + + def _get_episode_metadata(self, series_metadata: Optional[Dict[str, Any]], season_num: int, episode_num: int, season_dir: Optional[Path] = None, instance: str = 'sonarr') -> Optional[Dict[str, Any]]: """Get enhanced episode metadata including title extraction from filename""" - _log("DEBUG", f"Getting episode metadata for S{season_num:02d}E{episode_num:02d}, season_dir: {season_dir}") - + _log("DEBUG", f"[{instance}] Getting episode metadata for S{season_num:02d}E{episode_num:02d}, season_dir: {season_dir}") + metadata = {} - + # Try to get title from Sonarr first if series_metadata and 'episodes' in series_metadata: episode_data = series_metadata['episodes'].get((season_num, episode_num)) @@ -935,27 +858,27 @@ def _get_episode_metadata(self, series_metadata: Optional[Dict[str, Any]], seaso title = episode_data.get('title') if title and title != 'TBA': metadata['title'] = title - _log("DEBUG", f"Got title from Sonarr for S{season_num:02d}E{episode_num:02d}: {title}") - + _log("DEBUG", f"[{instance}] Got title from Sonarr for S{season_num:02d}E{episode_num:02d}: {title}") + # If no title from Sonarr, try to extract from filename if 'title' not in metadata and season_dir: - title = self._extract_title_from_filename(season_num, episode_num, season_dir) + title = self._extract_title_from_filename(season_num, episode_num, season_dir, instance=instance) if title: metadata['title'] = title - _log("DEBUG", f"Extracted title from filename for S{season_num:02d}E{episode_num:02d}: {title}") - + _log("DEBUG", f"[{instance}] Extracted title from filename for S{season_num:02d}E{episode_num:02d}: {title}") + return metadata if metadata else None - - def _extract_title_from_filename(self, season_num: int, episode_num: int, season_dir: Path) -> Optional[str]: + + def _extract_title_from_filename(self, season_num: int, episode_num: int, season_dir: Path, instance: str = 'sonarr') -> Optional[str]: """Extract episode title from video filename using regex pattern""" season_pattern = f"S{season_num:02d}E{episode_num:02d}" - + try: # Look for video files in the season directory for file_path in season_dir.iterdir(): if file_path.is_file() and file_path.suffix.lower() in ('.mkv', '.mp4', '.avi', '.mov', '.m4v'): filename = file_path.name - + # Check if this file matches our season/episode if season_pattern in filename.upper(): # Extract title using regex pattern: S01E01-Title[WEBDL-1080p] @@ -965,15 +888,15 @@ def _extract_title_from_filename(self, season_num: int, episode_num: int, season # Clean up the title title = title.replace('-', ' ').strip() if title: - _log("DEBUG", f"Extracted title '{title}' from filename: {filename}") + _log("DEBUG", f"[{instance}] Extracted title '{title}' from filename: {filename}") return title - + except Exception as e: - _log("ERROR", f"Error extracting title from filename for S{season_num:02d}E{episode_num:02d}: {e}") - + _log("ERROR", f"[{instance}] Error extracting title from filename for S{season_num:02d}E{episode_num:02d}: {e}") + return None - def _get_webhook_episode_date(self, imdb_id: str, season_num: int, episode_num: int, series_metadata: Optional[Dict[str, Any]] = None, webhook_episode: Optional[Dict[str, Any]] = None) -> Tuple[Optional[str], Optional[str], str]: + def _get_webhook_episode_date(self, imdb_id: str, season_num: int, episode_num: int, series_metadata: Optional[Dict[str, Any]] = None, webhook_episode: Optional[Dict[str, Any]] = None, instance: str = 'sonarr') -> Tuple[Optional[str], Optional[str], str]: """ Get episode date for webhook processing - database-first approach. @@ -988,14 +911,14 @@ def _get_webhook_episode_date(self, imdb_id: str, season_num: int, episode_num: This prevents webhooks from overriding existing good data. """ - # STEP 1: Check Chronarr database first + # Database-first: use existing date to avoid re-processing existing_entry = None existing_date = None try: - existing_entry = self.db.get_episode_date(imdb_id, season_num, episode_num) + existing_entry = self.db.get_episode_date(imdb_id, season_num, episode_num, instance) if existing_entry and existing_entry.get('dateadded'): existing_date = existing_entry['dateadded'] - _log("INFO", f"Found existing date in database for S{season_num:02d}E{episode_num:02d}: {existing_date}") + _log("INFO", f"[{instance}] Found existing date in database for S{season_num:02d}E{episode_num:02d}: {existing_date}") # For webhook processing, use existing data (fast path) # Manual scans will validate below @@ -1009,10 +932,10 @@ def _get_webhook_episode_date(self, imdb_id: str, season_num: int, episode_num: return aired, str(existing_date), "database:existing" except Exception as e: - _log("DEBUG", f"Database check failed for S{season_num:02d}E{episode_num:02d}: {e}") - - _log("INFO", f"No existing date in database for S{season_num:02d}E{episode_num:02d}, checking Sonarr import history") - + _log("DEBUG", f"[{instance}] Database check failed for S{season_num:02d}E{episode_num:02d}: {e}") + + _log("INFO", f"[{instance}] No existing date in database for S{season_num:02d}E{episode_num:02d}, checking Sonarr import history") + # Get aired date and episode ID from Sonarr aired = None episode_id = None @@ -1021,100 +944,84 @@ def _get_webhook_episode_date(self, imdb_id: str, season_num: int, episode_num: if episode_data: aired = episode_data.get('airDate') episode_id = episode_data.get('id') - _log("DEBUG", f"Got aired date from Sonarr for S{season_num:02d}E{episode_num:02d}: {aired}") - + _log("DEBUG", f"[{instance}] Got aired date from Sonarr for S{season_num:02d}E{episode_num:02d}: {aired}") + # STEP 2: Check Sonarr import history (authoritative source) - _log("INFO", f"Checking Sonarr import history for S{season_num:02d}E{episode_num:02d}") - - if episode_id and hasattr(self, 'sonarr'): + _log("INFO", f"[{instance}] Checking Sonarr import history for S{season_num:02d}E{episode_num:02d}") + + client, _, _ = self._resolve_sonarr(instance) + if episode_id and client: try: - _log("DEBUG", f"Calling get_episode_import_history for episode_id: {episode_id}") - import_history = self.get_episode_import_history(episode_id) - _log("DEBUG", f"Import history result: {import_history}") - + _log("DEBUG", f"[{instance}] Calling get_episode_import_history for episode_id: {episode_id}") + import_history = self.get_episode_import_history(episode_id, instance=instance) + _log("DEBUG", f"[{instance}] Import history result: {import_history}") + if import_history: # Found actual import event from Sonarr - _log("INFO", f"Found Sonarr import event for S{season_num:02d}E{episode_num:02d}: {import_history}") + _log("INFO", f"[{instance}] Found Sonarr import event for S{season_num:02d}E{episode_num:02d}: {import_history}") return aired, import_history, "sonarr:import_history" else: # No import events found - this means only renames/moves exist in history # The episode was already in Sonarr, just being managed/renamed - _log("INFO", f"No import events found for S{season_num:02d}E{episode_num:02d} - only renames/moves in history") - + _log("INFO", f"[{instance}] No import events found for S{season_num:02d}E{episode_num:02d} - only renames/moves in history") + if aired: - _log("INFO", f"Using air date for existing episode (rename-only history): {aired}") + _log("INFO", f"[{instance}] Using air date for existing episode (rename-only history): {aired}") return aired, aired + "T20:00:00", "airdate" else: - _log("DEBUG", f"No air date available for rename-only episode S{season_num:02d}E{episode_num:02d}") - + _log("DEBUG", f"[{instance}] No air date available for rename-only episode S{season_num:02d}E{episode_num:02d}") + except Exception as e: - _log("ERROR", f"Error checking Sonarr import history for S{season_num:02d}E{episode_num:02d}: {e}") + _log("ERROR", f"[{instance}] Error checking Sonarr import history for S{season_num:02d}E{episode_num:02d}: {e}") import traceback _log("ERROR", traceback.format_exc()) else: if not episode_id: - _log("DEBUG", f"No episode_id found for S{season_num:02d}E{episode_num:02d}") - if not hasattr(self, 'sonarr'): - _log("DEBUG", f"No sonarr client available") - - # STEP 2: No import history found - this is likely a genuinely new show + _log("DEBUG", f"[{instance}] No episode_id found for S{season_num:02d}E{episode_num:02d}") + if not client: + _log("DEBUG", f"[{instance}] No sonarr client available") + # Check our database to avoid duplicates - existing = self.db.get_episode_date(imdb_id, season_num, episode_num) + existing = self.db.get_episode_date(imdb_id, season_num, episode_num, instance) if existing and existing.get('dateadded'): - _log("INFO", f"Episode S{season_num:02d}E{episode_num:02d} already exists in our database: {existing['dateadded']}") + _log("INFO", f"[{instance}] Episode S{season_num:02d}E{episode_num:02d} already exists in our database: {existing['dateadded']}") return existing.get('aired'), existing.get('dateadded'), existing.get('source', 'chronarr:database') - + # STEP 3: Truly new episode - use webhook date dateadded = datetime.now().isoformat() source = "sonarr:webhook" - - _log("INFO", f"No import history and not in database - using webhook date for genuinely new episode S{season_num:02d}E{episode_num:02d}: {dateadded}") + + _log("INFO", f"[{instance}] No import history and not in database - using webhook date for genuinely new episode S{season_num:02d}E{episode_num:02d}: {dateadded}") return aired, dateadded, source async def async_batch_episode_processing( self, episodes_data: List[Dict[str, Any]], - max_concurrent: int = 5 + max_concurrent: int = 5, + instance: str = 'sonarr', ) -> Dict[str, Any]: - """ - Process episodes from webhook data concurrently - - Args: - episodes_data: List of episode data from webhooks - max_concurrent: Maximum concurrent episode processing - - Returns: - Processing results summary - """ + """Process episodes from webhook data concurrently.""" async def _process_single_episode(episode_data: Dict[str, Any]) -> Dict[str, Any]: try: - # Extract episode information series_path = Path(episode_data.get('series_path')) season = episode_data.get('season') episode = episode_data.get('episode') aired = episode_data.get('aired') dateadded = episode_data.get('dateadded') - - # Get IMDb ID - imdb_id = parse_imdb_from_path(series_path) # Phase 3: Using imdb_utils + + imdb_id = parse_imdb_from_path(series_path) if not imdb_id: return {"status": "error", "reason": "No IMDb ID found"} - - # NFO file operations removed - database is now the single source of truth - # (Phase 1: Remove NFO file write operations) - nfo_success = True # Always True since we're not creating NFOs anymore - - # Update database - self.db.upsert_episode_date(imdb_id, season, episode, aired, dateadded, "webhook", True) - + + self.db.upsert_episode_date(imdb_id, season, episode, aired, dateadded, "webhook", True, instance=instance) + return { "status": "success", "season": season, "episode": episode, - "nfo_created": nfo_success } - + except Exception as e: return { "status": "error", diff --git a/scheduler/cleanup_scheduler.py b/scheduler/cleanup_scheduler.py index 6058b10..e3c2de9 100644 --- a/scheduler/cleanup_scheduler.py +++ b/scheduler/cleanup_scheduler.py @@ -215,14 +215,16 @@ async def _run_orphaned_cleanup(self, cleanup: Dict[str, Any], execution_id: int from utils.orphaned_cleanup import OrphanedRecordCleaner db = self.dependencies.get("db") - radarr_db_client = self.dependencies.get("radarr_db_client") - sonarr_db_client = self.dependencies.get("sonarr_db_client") + registry = self.dependencies.get("registry") - # Initialize the cleaner + # Initialize the cleaner — registry lets it resolve the right + # Radarr/Sonarr client per row's own instance instead of a single + # fixed client (this dict never actually had radarr_db_client/ + # sonarr_db_client keys, so check_database was silently inert + # before this). cleaner = OrphanedRecordCleaner( chronarr_db=db, - radarr_db_client=radarr_db_client, - sonarr_db_client=sonarr_db_client + registry=registry ) # Run cleanup with configured options diff --git a/start_web.py b/start_web.py index 4719c03..66d3dd6 100644 --- a/start_web.py +++ b/start_web.py @@ -11,6 +11,12 @@ from fastapi.staticfiles import StaticFiles from fastapi.responses import FileResponse +# utils.logging has to be imported before config.settings — importing it is +# what actually loads .env/.env.secrets into the process (a side effect at +# the bottom of that module). See the same note in main.py for the full +# explanation of why this ordering matters. +from utils.logging import _log + # Import existing configuration (keep using core config for simplicity) from config.settings import config diff --git a/static/css/styles.css b/static/css/styles.css index 66f41c0..5dbd73d 100644 --- a/static/css/styles.css +++ b/static/css/styles.css @@ -30,120 +30,257 @@ body { .app-container { min-height: 100vh; display: flex; - flex-direction: column; -} - -/* Header */ -.app-header { - background: linear-gradient(135deg, #667eea 0%, #764ba2 100%); - color: white; - padding: 1rem 0; - box-shadow: var(--shadow-lg); - position: relative; + flex-direction: row; + align-items: stretch; } -.header-content { - max-width: 1200px; - margin: 0 auto; - padding: 0 1rem; - text-align: center; -} - -.header-content h1 { - font-size: 2rem; - font-weight: 300; - margin-bottom: 0.5rem; +/* Sidebar */ +.sidebar { + width: 220px; + min-width: 220px; + background: #1a1d23; + color: #8b95a1; + display: flex; + flex-direction: column; + min-height: 100vh; + position: sticky; + top: 0; + height: 100vh; + overflow-y: auto; + flex-shrink: 0; } -.header-content h1 i { - margin-right: 0.5rem; +.sidebar-brand { + padding: 1.125rem 1rem; + display: flex; + align-items: center; + gap: 0.625rem; + color: #ffffff; + font-size: 1.1rem; + font-weight: 600; + border-bottom: 1px solid #2d3139; + text-decoration: none; } -.header-content p { - opacity: 0.9; - font-size: 1rem; +.sidebar-brand i { + color: #0096c7; + font-size: 1.2rem; } -/* Authentication Status */ -.auth-status { - position: absolute; - top: 1rem; - right: 1rem; +/* Auth block in sidebar */ +.sidebar-auth { + padding: 0.625rem 1rem; + border-bottom: 1px solid #2d3139; display: flex; - align-items: center; - gap: 1rem; - color: white; - font-size: 0.9rem; + flex-direction: column; + gap: 0.375rem; + font-size: 0.8rem; + color: #8b95a1; } .auth-user { display: flex; align-items: center; - gap: 0.5rem; - opacity: 0.9; + gap: 0.375rem; + opacity: 0.85; } .auth-logout { - background: rgba(255, 255, 255, 0.2); - color: white; - border: 1px solid rgba(255, 255, 255, 0.3); - padding: 0.5rem 1rem; + background: rgba(255, 255, 255, 0.08); + color: #8b95a1; + border: 1px solid #3a3f4a; + padding: 0.3rem 0.625rem; border-radius: 0.25rem; cursor: pointer; - font-size: 0.85rem; + font-size: 0.775rem; display: flex; align-items: center; - gap: 0.5rem; + gap: 0.375rem; transition: all 0.2s ease; + width: fit-content; } .auth-logout:hover { - background: rgba(255, 255, 255, 0.3); - border-color: rgba(255, 255, 255, 0.5); - transform: translateY(-1px); + background: rgba(255, 255, 255, 0.14); + color: #c9d1d9; } -.nav-tabs { - max-width: 1200px; - margin: 1rem auto 0; - padding: 0 1rem; +/* Sidebar nav */ +.sidebar-nav { + flex: 1; + padding: 0.5rem 0 1rem; display: flex; - gap: 0.5rem; - flex-wrap: wrap; - justify-content: center; + flex-direction: column; } -.nav-tab { - background: rgba(255, 255, 255, 0.1); +.nav-section-label { + padding: 0.875rem 1rem 0.25rem; + font-size: 0.65rem; + font-weight: 700; + letter-spacing: 0.08em; + text-transform: uppercase; + color: #4a5260; +} + +.sidebar-item { + display: flex; + align-items: center; + gap: 0.625rem; + padding: 0.45rem 0.75rem; + margin: 0.1rem 0.5rem; + width: calc(100% - 1rem); + background: none; border: none; - color: white; - padding: 0.75rem 1.5rem; - border-radius: 0.5rem; + color: #8b95a1; cursor: pointer; - transition: all 0.3s ease; - font-size: 0.9rem; + font-size: 0.875rem; + text-align: left; + text-decoration: none; + border-radius: 0.375rem; + transition: background 0.15s, color 0.15s; + font-family: inherit; +} + +.sidebar-item i { + width: 1.1rem; + text-align: center; + font-size: 0.85rem; + flex-shrink: 0; +} + +.sidebar-item:hover { + background: #252930; + color: #c9d1d9; +} + +.sidebar-item.active { + background: rgba(0, 150, 199, 0.14); + color: #0096c7; +} + +/* Expandable group */ +.sidebar-group { + margin: 0.1rem 0; +} + +.sidebar-group-toggle { + display: flex; + align-items: center; + justify-content: space-between; + padding: 0.45rem 0.75rem; + margin: 0 0.5rem; + width: calc(100% - 1rem); + background: none; + border: none; + color: #8b95a1; + cursor: pointer; + font-size: 0.875rem; + border-radius: 0.375rem; + transition: background 0.15s, color 0.15s; + font-family: inherit; +} + +.sidebar-group-toggle:hover { + background: #252930; + color: #c9d1d9; +} + +.toggle-content { + display: flex; + align-items: center; + gap: 0.625rem; +} + +.toggle-content i { + width: 1.1rem; + text-align: center; + font-size: 0.85rem; +} + +.toggle-chevron { + font-size: 0.65rem; + transition: transform 0.2s ease; + opacity: 0.5; +} + +.sidebar-group-toggle[aria-expanded="true"] .toggle-chevron { + transform: rotate(180deg); +} + +/* Sub-items (collapsed by default, expand via .expanded) */ +.sidebar-sub-items { + overflow: hidden; + max-height: 0; + transition: max-height 0.2s ease; +} + +.sidebar-sub-items.expanded { + max-height: 400px; +} + +.sidebar-sub-item { display: flex; align-items: center; gap: 0.5rem; + padding: 0.35rem 0.75rem 0.35rem 2.5rem; + width: 100%; + background: none; + border: none; + color: #626c7a; + cursor: pointer; + font-size: 0.825rem; + text-align: left; + transition: color 0.15s, background 0.15s; + font-family: inherit; } -.nav-tab:hover { - background: rgba(255, 255, 255, 0.2); - transform: translateY(-1px); +.sidebar-sub-item:hover { + color: #c9d1d9; + background: #202328; } -.nav-tab.active { - background: rgba(255, 255, 255, 0.9); - color: var(--dark-color); +.sidebar-sub-item.active { + color: #0096c7; +} + +.instance-dot { + width: 6px; + height: 6px; + border-radius: 50%; + flex-shrink: 0; + display: inline-block; +} + +.sidebar-divider { + height: 1px; + background: #2d3139; + margin: 0.625rem 0.75rem; +} + +/* Instance badge in table cells */ +.instance-badge { + padding: 0.2rem 0.5rem; + border-radius: 0.25rem; + font-size: 0.75rem; + font-weight: 500; + border: 1px solid transparent; + display: inline-block; + white-space: nowrap; +} + +/* badge-primary (used in source type display) */ +.badge-primary { + background-color: #cfe2ff; + color: #084298; } /* Main Content */ .main-content { flex: 1; - max-width: 1200px; - margin: 0 auto; - padding: 2rem 1rem; - width: 100%; + padding: 1.75rem 2rem; + overflow-y: auto; + min-height: 100vh; + background: #f5f5f5; } .tab-content { @@ -187,6 +324,7 @@ body { .stat-icon.tv { background: linear-gradient(135deg, #f093fb, #f5576c); } .stat-icon.missing { background: linear-gradient(135deg, #ffecd2, #fcb69f); } .stat-icon.activity { background: linear-gradient(135deg, #a8edea, #fed6e3); } +.stat-icon.skipped { background: linear-gradient(135deg, #f7971e, #ffd200); } .stat-info h3 { font-size: 2rem; @@ -223,7 +361,7 @@ body { } .chart-container { - height: 200px; + min-height: 200px; display: flex; align-items: center; justify-content: center; @@ -232,6 +370,33 @@ body { color: var(--text-muted); } +.simple-chart { + width: 100%; + display: flex; + flex-direction: column; + gap: 0.4rem; + padding: 0.75rem; +} + +.chart-item { + display: flex; + justify-content: space-between; + align-items: center; + padding: 0.4rem 0.75rem; + border-radius: 0.25rem; + font-size: 0.875rem; +} + +.chart-label { + font-weight: 500; + color: var(--dark-color); +} + +.chart-value { + color: var(--text-muted); + font-variant-numeric: tabular-nums; +} + /* Content Header */ .content-header { display: flex; @@ -589,26 +754,22 @@ body { color: var(--dark-color); } -/* Tools */ -.tools-grid { - display: grid; - grid-template-columns: repeat(auto-fit, minmax(300px, 1fr)); - gap: 1.5rem; -} - -.tool-card { +/* Tools — each tool is its own full page now (sidebar dropdown), not a + shared grid of cards, so a five-line form and a full log viewer don't + have to fight each other for space. */ +.tool-page { background: white; border-radius: 0.5rem; padding: 1.5rem; box-shadow: var(--shadow); + max-width: 640px; } -.tool-card h3 { - margin-bottom: 0.5rem; - color: var(--dark-color); +.tool-page.tool-page-wide { + max-width: none; } -.tool-card p { +.tool-page-desc { margin-bottom: 1.5rem; color: var(--text-muted); } @@ -793,40 +954,63 @@ body { } /* Responsive */ -@media (max-width: 768px) { +@media (max-width: 900px) { + .sidebar { + width: 180px; + min-width: 180px; + } +} + +@media (max-width: 640px) { + .app-container { + flex-direction: column; + } + + .sidebar { + width: 100%; + min-width: unset; + height: auto; + min-height: unset; + position: static; + } + + .sidebar-sub-items.expanded { + max-height: 600px; + } + + .main-content { + min-height: unset; + padding: 1rem; + } + .content-header { flex-direction: column; align-items: stretch; } - + .content-controls { justify-content: center; } - + .search-box input { width: 200px; } - - .nav-tabs { - flex-direction: column; - gap: 0.25rem; - } - + .data-table { font-size: 0.8rem; } - + .data-table th, .data-table td { padding: 0.5rem 0.25rem; } - + .dashboard-grid { grid-template-columns: 1fr; } - - .tools-grid { - grid-template-columns: 1fr; + + .tool-page { + max-width: none; } } diff --git a/static/index.html b/static/index.html index b99933f..76ae1b3 100644 --- a/static/index.html +++ b/static/index.html @@ -4,18 +4,19 @@ <meta charset="UTF-8"> <meta name="viewport" content="width=device-width, initial-scale=1.0"> <title>Chronarr - Database Management - +
- -
-
-

Chronarr

-

Database Management & Reporting

+ +
+
@@ -57,7 +118,7 @@

-

- with dates
- +
@@ -68,7 +129,7 @@

-

- episodes
- +
@@ -79,7 +140,7 @@

-

- no valid source
- +
@@ -90,6 +151,17 @@

-

Last 7 days
+ +
+
+ +
+
+

-

+

Skipped Items

+ - movies, - episodes +
+
@@ -134,7 +206,7 @@

Movies Database

- +
@@ -146,17 +218,18 @@

Movies Database

+ - +
Source Date Type Video FileInstance Actions
Loading movies...Loading movies...
- + @@ -191,7 +264,7 @@

TV Series Database

- +
@@ -201,17 +274,18 @@

TV Series Database

+ - +
Episodes With Dates With VideoInstance Actions
Loading series...Loading series...
- + @@ -287,134 +361,210 @@

Episodes Missing Dates

- -
+ +
-

Database Tools

+

Bulk Source Update

+
+
+

Change source for multiple items at once

+
+
+ + +
+
+ + +
+
+ + +
+ +
+
-
-
-

Bulk Source Update

-

Change source for multiple items at once

-
-
- - -
-
- - + +
+
+

Manual Scan

+
+
+

Scan specific folders or perform full library scans

+ +
+ + +
+
+ + +
+
+ + + Leave empty to scan entire library +
+ + + +
-
-

Manual Scan

-

Scan specific folders or perform full library scans

-
-
- - -
-
- - + +
+
+

Database Statistics

+
+
+

View detailed database information

+
+

Click refresh to load detailed statistics

+
+ +
+
+ + +
+
+

Populate Database

+
+
+

Bulk import data from Radarr/Sonarr into Chronarr database

+ +
+ + +
+
+ + +

+ Picking a specific instance populates only that one and sets Media Type for you (a Radarr instance is always movies, a Sonarr instance always TV). +

+
+ + + -
-

Database Statistics

-

View detailed database information

-
-

Click refresh to load detailed statistics

-
- + +
+
+

Log Files

+
+
+

View recent activity or download the current log and its rotated backups

+
+

Loading…

-
-

Populate Database

-

Bulk import data from Radarr/Sonarr into Chronarr database

-
-
- - -
- -
-
+ 
Select a file above and click Refresh.
+
+
+ + +
+
+

Unresolved Lookups

+
+
+

Movies and episodes the Emby/Jellyfin plugin asked about that Chronarr answered "not found" for — persists across scans so these don't have to be caught live in the logs. Clears itself automatically once a lookup for the same item succeeds.

+
+ + +
+
+

Loading…

+
@@ -451,13 +601,14 @@ - + +
Leave empty to clear date
- +
- +
@@ -482,6 +633,6 @@
- + - \ No newline at end of file + diff --git a/static/js/app.js b/static/js/app.js index 15e2f54..1b61b82 100644 --- a/static/js/app.js +++ b/static/js/app.js @@ -5,57 +5,134 @@ let currentTab = 'dashboard'; let currentMoviesPage = 1; let currentSeriesPage = 1; let dashboardData = null; +let currentMovieInstance = ''; +let currentTvInstance = ''; + +// Instance badge color palette — assigned in order as instances are discovered +const instanceColorMap = {}; +const instanceColors = ['#3b82f6', '#8b5cf6', '#10b981', '#f59e0b', '#ef4444']; +let instanceColorIndex = 0; + +function getInstanceColor(name) { + if (!name) return '#6b7280'; + if (!instanceColorMap[name]) { + instanceColorMap[name] = instanceColors[instanceColorIndex++ % instanceColors.length]; + } + return instanceColorMap[name]; +} + +function instanceBadge(name) { + if (!name) return '-'; + const c = getInstanceColor(name); + return `${escapeHtml(name)}`; +} // Initialize app document.addEventListener('DOMContentLoaded', function() { - initializeTabs(); initializeEventListeners(); - checkAuthStatus(); // Check authentication status on page load + checkAuthStatus(); loadDashboard(); loadSeriesSources(); + buildSidebarInstances(); }); // Tab management -function initializeTabs() { - const tabButtons = document.querySelectorAll('.nav-tab'); - const tabContents = document.querySelectorAll('.tab-content'); - - tabButtons.forEach(button => { - button.addEventListener('click', function() { - const tabName = this.dataset.tab; - switchTab(tabName); - }); - }); -} - function switchTab(tabName) { - // Update button states - document.querySelectorAll('.nav-tab').forEach(btn => btn.classList.remove('active')); - document.querySelector(`[data-tab="${tabName}"]`).classList.add('active'); - + // Update sidebar item active states + document.querySelectorAll('.sidebar-item[data-tab]').forEach(btn => btn.classList.remove('active')); + const activeBtn = document.querySelector(`.sidebar-item[data-tab="${tabName}"]`); + if (activeBtn) activeBtn.classList.add('active'); + // Update content document.querySelectorAll('.tab-content').forEach(content => content.classList.remove('active')); document.getElementById(tabName).classList.add('active'); - + currentTab = tabName; - - // Load tab-specific data + + if (tabName !== 'tool-logs') { + // Don't keep polling the log tail in the background once the user + // has navigated away from the page that shows it. + stopLogTailAutoRefresh(); + } + switch(tabName) { - case 'dashboard': - loadDashboard(); - break; - case 'movies': - loadMovies(); - break; - case 'tv': - loadSeries(); - break; - case 'reports': - loadReport(); - break; - case 'tools': - loadDetailedStats(); - break; + case 'dashboard': loadDashboard(); break; + case 'movies': loadMovies(); break; + case 'tv': loadSeries(); break; + case 'reports': loadReport(); break; + case 'tool-stats': loadDetailedStats(); break; + case 'tool-populate': loadPopulateInstanceOptions(); break; + case 'tool-logs': loadLogFiles(); break; + case 'tool-unresolved': loadUnresolvedLookups(); break; + } +} + +// Sidebar instance navigation +function toggleSidebarGroup(subId, tabName) { + const sub = document.getElementById(subId); + const isExpanded = sub.classList.toggle('expanded'); + const toggle = sub.closest('.sidebar-group').querySelector('.sidebar-group-toggle'); + toggle.setAttribute('aria-expanded', isExpanded ? 'true' : 'false'); + if (tabName) switchTab(tabName); +} + +function selectToolsPage(page) { + document.querySelectorAll('#tools-sub .sidebar-sub-item').forEach(btn => btn.classList.remove('active')); + const target = document.getElementById(`sub-${page}`); + if (target) target.classList.add('active'); + switchTab(page); +} + +function selectMovieInstance(name) { + currentMovieInstance = name; + currentMoviesPage = 1; + document.querySelectorAll('#movies-sub .sidebar-sub-item').forEach(btn => btn.classList.remove('active')); + const target = document.getElementById(name ? `sub-movies-${name}` : 'sub-movies-all'); + if (target) target.classList.add('active'); + switchTab('movies'); +} + +function selectTvInstance(name) { + currentTvInstance = name; + currentSeriesPage = 1; + document.querySelectorAll('#tv-sub .sidebar-sub-item').forEach(btn => btn.classList.remove('active')); + const target = document.getElementById(name ? `sub-tv-${name}` : 'sub-tv-all'); + if (target) target.classList.add('active'); + switchTab('tv'); +} + +async function buildSidebarInstances() { + try { + const data = await apiCall('/api/instances'); + const radarrNames = (data.radarr || []).map(i => i.name); + const sonarrNames = (data.sonarr || []).map(i => i.name); + + // Pre-assign colors so badges match sidebar dots + [...radarrNames, ...sonarrNames].forEach(n => getInstanceColor(n)); + + const moviesSub = document.getElementById('movies-sub'); + radarrNames.forEach(name => { + const color = getInstanceColor(name); + const btn = document.createElement('button'); + btn.className = 'sidebar-sub-item'; + btn.id = `sub-movies-${name}`; + btn.onclick = () => selectMovieInstance(name); + btn.innerHTML = `${escapeHtml(name)}`; + moviesSub.appendChild(btn); + }); + + const tvSub = document.getElementById('tv-sub'); + sonarrNames.forEach(name => { + const color = getInstanceColor(name); + const btn = document.createElement('button'); + btn.className = 'sidebar-sub-item'; + btn.id = `sub-tv-${name}`; + btn.onclick = () => selectTvInstance(name); + btn.innerHTML = `${escapeHtml(name)}`; + tvSub.appendChild(btn); + }); + } catch (error) { + console.error('Failed to build sidebar instances:', error); } } @@ -78,6 +155,10 @@ function initializeEventListeners() { document.getElementById('bulk-update-form').addEventListener('submit', handleBulkUpdate); document.getElementById('manual-scan-form').addEventListener('submit', handleManualScan); document.getElementById('populate-form').addEventListener('submit', handlePopulateDatabase); + const populateInstanceSelect = document.getElementById('populate-instance'); + if (populateInstanceSelect) { + populateInstanceSelect.addEventListener('change', syncPopulateMediaTypeToInstance); + } } // API calls @@ -141,6 +222,11 @@ function updateDashboardStats() { document.getElementById('no-valid-source-total').textContent = `${moviesWithoutDates} movies, ${episodesWithoutDates} episodes without dates`; document.getElementById('recent-activity').textContent = dashboardData.recent_activity_count || 0; + + const moviesSkipped = dashboardData.movies_skipped || 0; + const episodesSkipped = dashboardData.episodes_skipped || 0; + document.getElementById('skipped-total').textContent = dashboardData.total_skipped || (moviesSkipped + episodesSkipped); + document.getElementById('skipped-breakdown').textContent = `${moviesSkipped} movies, ${episodesSkipped} episodes`; } function updateDashboardCharts() { @@ -198,19 +284,21 @@ async function loadMovies(page = 1) { const imdbSearch = document.getElementById('movies-imdb-search').value; const hasDate = document.getElementById('movies-filter-date').value; const sourceFilter = document.getElementById('movies-filter-source').value; - + const instanceFilter = currentMovieInstance; + const skip = (page - 1) * 100; console.log(`DEBUG: loadMovies called with page=${page}, calculated skip=${skip}`); - + const params = new URLSearchParams({ skip: skip, limit: 100 }); - + if (search) params.append('search', search); if (imdbSearch) params.append('imdb_search', imdbSearch); if (hasDate) params.append('has_date', hasDate); if (sourceFilter) params.append('source_filter', sourceFilter); + if (instanceFilter) params.append('instance', instanceFilter); try { const data = await apiCall(`/api/movies?${params}`); @@ -227,7 +315,7 @@ function updateMoviesTable(data) { const tbody = document.getElementById('movies-tbody'); if (!data.movies || data.movies.length === 0) { - tbody.innerHTML = 'No movies found'; + tbody.innerHTML = 'No movies found'; return; } @@ -285,14 +373,15 @@ function updateMoviesTable(data) { ${movie.source_description || movie.source || 'Unknown'} ${dateType} ${hasVideoBadge} + ${instanceBadge(movie.instance)} - - - @@ -360,6 +449,7 @@ async function loadSeriesSources() { } } + function refreshMovies() { loadMovies(isNaN(currentMoviesPage) ? 1 : currentMoviesPage); } @@ -375,19 +465,21 @@ async function loadSeries(page = 1) { const imdbSearch = document.getElementById('series-imdb-search').value; const dateFilter = document.getElementById('series-filter-date').value; const sourceFilter = document.getElementById('series-filter-source').value; - + const instanceFilter = currentTvInstance; + const skip = (page - 1) * 50; console.log(`DEBUG: loadSeries called with page=${page}, calculated skip=${skip}`); - + const params = new URLSearchParams({ skip: skip, limit: 50 }); - + if (search) params.append('search', search); if (imdbSearch) params.append('imdb_search', imdbSearch); if (dateFilter) params.append('date_filter', dateFilter); if (sourceFilter) params.append('source_filter', sourceFilter); + if (instanceFilter) params.append('instance', instanceFilter); try { const data = await apiCall(`/api/series?${params}`); @@ -403,14 +495,14 @@ function updateSeriesTable(data) { const tbody = document.getElementById('series-tbody'); if (!data.series || data.series.length === 0) { - tbody.innerHTML = 'No series found'; + tbody.innerHTML = 'No series found'; return; } - + tbody.innerHTML = data.series.map(series => { - const progressPercent = series.total_episodes > 0 ? + const progressPercent = series.total_episodes > 0 ? ((series.episodes_with_dates / series.total_episodes) * 100).toFixed(1) : 0; - + return ` ${escapeHtml(series.title)} @@ -421,10 +513,14 @@ function updateSeriesTable(data) { (${progressPercent}%) ${series.episodes_with_video} + ${instanceBadge(series.instance)} - + `; @@ -462,9 +558,9 @@ function refreshSeries() { loadSeries(isNaN(currentSeriesPage) ? 1 : currentSeriesPage); } -async function viewSeriesEpisodes(imdbId) { +async function viewSeriesEpisodes(imdbId, instance = 'sonarr') { try { - const data = await apiCall(`/api/series/${imdbId}/episodes`); + const data = await apiCall(`/api/series/${imdbId}/episodes?instance=${encodeURIComponent(instance)}`); showEpisodesModal(data); } catch (error) { console.error('Failed to load episodes:', error); @@ -542,7 +638,7 @@ function showEpisodesModal(data) { `${dateadded}`; return ` - + @@ -552,10 +648,10 @@ function showEpisodesModal(data) { ${episode.source_description || episode.source || 'Unknown'} ${hasVideoBadge} - - @@ -635,7 +731,7 @@ function updateReportTables(data) { ${movie.released || '-'} ${movie.source_description || movie.source || 'Unknown'} - @@ -656,7 +752,7 @@ function updateReportTables(data) { ${episode.aired || '-'} ${episode.source_description || episode.source || 'Unknown'} - @@ -670,36 +766,39 @@ function refreshReport() { } // Smart fix functions -async function smartFixMovie(imdbId) { +async function smartFixMovie(imdbId, instance) { + instance = instance || 'radarr'; try { - console.log('🔍 SMART FIX: Loading options for movie', imdbId); - const options = await apiCall(`/api/movies/${imdbId}/date-options`); + console.log('🔍 SMART FIX: Loading options for movie', imdbId, 'instance', instance); + const options = await apiCall(`/api/movies/${imdbId}/date-options?instance=${encodeURIComponent(instance)}`); console.log('🔍 SMART FIX: Received options:', options); - showSmartFixModal('movie', options); + showSmartFixModal('movie', options, instance); } catch (error) { console.error('Failed to load movie options:', error); showToast('Failed to load movie options', 'error'); } } -async function smartFixEpisode(imdbId, season, episode) { +async function smartFixEpisode(imdbId, season, episode, instance) { // Validate parameters if (!imdbId || season === undefined || season === null || episode === undefined || episode === null) { console.error('smartFixEpisode: Invalid parameters:', {imdbId, season, episode}); showToast('Invalid episode parameters', 'error'); return; } - + + instance = instance || 'sonarr'; try { - const options = await apiCall(`/api/episodes/${imdbId}/${season}/${episode}/date-options`); - showSmartFixModal('episode', options); + const options = await apiCall(`/api/episodes/${imdbId}/${season}/${episode}/date-options?instance=${encodeURIComponent(instance)}`); + showSmartFixModal('episode', options, instance); } catch (error) { console.error('Failed to load episode options:', error); showToast('Failed to load episode options', 'error'); } } -function showSmartFixModal(mediaType, options) { +function showSmartFixModal(mediaType, options, instance) { + instance = instance || (mediaType === 'movie' ? 'radarr' : 'sonarr'); console.log('🔍 SMART FIX: Showing modal for', mediaType, 'with options:', options); const modal = document.getElementById('smart-fix-modal'); @@ -751,7 +850,7 @@ function showSmartFixModal(mediaType, options) { optionsHtml += `
-
@@ -765,7 +864,8 @@ function closeSmartFixModal() { document.getElementById('smart-fix-modal').classList.remove('active'); } -async function applySmartFix(mediaType, options) { +async function applySmartFix(mediaType, options, instance) { + instance = instance || (mediaType === 'movie' ? 'radarr' : 'sonarr'); const selectedRadio = document.querySelector('input[name="date-option"]:checked'); if (!selectedRadio) { showToast('Please select a date option', 'warning'); @@ -827,9 +927,9 @@ async function applySmartFix(mediaType, options) { try { if (mediaType === 'movie') { - await updateMovieDate(options.imdb_id, dateadded, source); + await updateMovieDate(options.imdb_id, dateadded, source, instance); } else { - await updateEpisodeDate(options.imdb_id, options.season, options.episode, dateadded, source); + await updateEpisodeDate(options.imdb_id, options.season, options.episode, dateadded, source, instance); } closeSmartFixModal(); } catch (error) { @@ -916,19 +1016,21 @@ async function handleBulkUpdate(event) { } // Edit modal functions -async function editMovie(imdbId, dateadded, source) { +async function editMovie(imdbId, dateadded, source, instance) { + instance = instance || 'radarr'; try { // Load movie options to populate available dates - const options = await apiCall(`/api/movies/${imdbId}/date-options`); - showEnhancedEditModal('movie', options, dateadded, source); + const options = await apiCall(`/api/movies/${imdbId}/date-options?instance=${encodeURIComponent(instance)}`); + showEnhancedEditModal('movie', options, dateadded, source, instance); } catch (error) { console.error('Failed to load movie options for edit:', error); // Fallback to basic edit modal - showBasicEditModal('movie', imdbId, dateadded, source); + showBasicEditModal('movie', imdbId, dateadded, source, null, null, instance); } } -function showEnhancedEditModal(mediaType, options, currentDateadded, currentSource) { +function showEnhancedEditModal(mediaType, options, currentDateadded, currentSource, instance) { + instance = instance || (mediaType === 'movie' ? 'radarr' : 'sonarr'); const modal = document.getElementById('edit-modal'); const title = document.getElementById('modal-title'); const modalBody = document.querySelector('#edit-modal .modal-body'); @@ -946,6 +1048,7 @@ function showEnhancedEditModal(mediaType, options, currentDateadded, currentSour let formHtml = ` + ${mediaType === 'episode' ? ` @@ -1028,11 +1131,13 @@ function showEnhancedEditModal(mediaType, options, currentDateadded, currentSour modal.classList.add('active'); } -function showBasicEditModal(mediaType, imdbId, dateadded, source) { +function showBasicEditModal(mediaType, imdbId, dateadded, source, season, episode, instance) { // Fallback to original basic edit modal + instance = instance || (mediaType === 'movie' ? 'radarr' : 'sonarr'); document.getElementById('modal-title').textContent = `Edit ${mediaType}: ${imdbId}`; document.getElementById('edit-imdb-id').value = imdbId; document.getElementById('edit-media-type').value = mediaType; + document.getElementById('edit-instance').value = instance; if (dateadded && dateadded !== '-') { try { @@ -1086,11 +1191,12 @@ function updateEditDateFromOption(optionIndex, option) { async function handleEnhancedEditSubmit(event) { event.preventDefault(); - + const modal = document.getElementById('edit-modal'); const options = JSON.parse(modal.dataset.options); const imdbId = options.imdb_id; const mediaType = document.getElementById('edit-media-type').value; + const instance = document.getElementById('edit-instance')?.value || (mediaType === 'movie' ? 'radarr' : 'sonarr'); const dateadded = document.getElementById('edit-dateadded').value; const source = document.getElementById('edit-source').value; @@ -1110,11 +1216,11 @@ async function handleEnhancedEditSubmit(event) { try { if (mediaType === 'movie') { - await updateMovieDate(imdbId, isoDateadded, source); + await updateMovieDate(imdbId, isoDateadded, source, instance); } else { - await updateEpisodeDate(imdbId, options.season, options.episode, isoDateadded, source); + await updateEpisodeDate(imdbId, options.season, options.episode, isoDateadded, source, instance); } - + closeModal(); } catch (error) { console.error('Enhanced edit failed:', error); @@ -1122,22 +1228,23 @@ async function handleEnhancedEditSubmit(event) { } } -async function editEpisode(imdbId, season, episode, dateadded, source) { +async function editEpisode(imdbId, season, episode, dateadded, source, instance) { // Validate parameters if (!imdbId || season === undefined || season === null || episode === undefined || episode === null) { console.error('editEpisode: Invalid parameters:', {imdbId, season, episode}); showToast('Invalid episode parameters', 'error'); return; } - + + instance = instance || 'sonarr'; try { // Load episode options to populate available dates - const options = await apiCall(`/api/episodes/${imdbId}/${season}/${episode}/date-options`); - showEnhancedEditModal('episode', options, dateadded, source); + const options = await apiCall(`/api/episodes/${imdbId}/${season}/${episode}/date-options?instance=${encodeURIComponent(instance)}`); + showEnhancedEditModal('episode', options, dateadded, source, instance); } catch (error) { console.error('Failed to load episode options for edit:', error); // Fallback to basic edit modal - showBasicEditModal('episode', imdbId, dateadded, source, season, episode); + showBasicEditModal('episode', imdbId, dateadded, source, season, episode, instance); } } @@ -1147,24 +1254,25 @@ function closeModal() { async function handleEditSubmit(event) { event.preventDefault(); - + const imdbId = document.getElementById('edit-imdb-id').value; const mediaType = document.getElementById('edit-media-type').value; + const instance = document.getElementById('edit-instance')?.value || (mediaType === 'movie' ? 'radarr' : 'sonarr'); const season = document.getElementById('edit-season').value; const episode = document.getElementById('edit-episode').value; const dateadded = document.getElementById('edit-dateadded').value; const source = document.getElementById('edit-source').value; - + // Convert datetime-local to ISO string const isoDateadded = dateadded ? new Date(dateadded).toISOString() : null; - + try { if (mediaType === 'movie') { - await updateMovieDate(imdbId, isoDateadded, source); + await updateMovieDate(imdbId, isoDateadded, source, instance); } else { - await updateEpisodeDate(imdbId, parseInt(season), parseInt(episode), isoDateadded, source); + await updateEpisodeDate(imdbId, parseInt(season), parseInt(episode), isoDateadded, source, instance); } - + closeModal(); } catch (error) { console.error('Update failed:', error); @@ -1172,13 +1280,15 @@ async function handleEditSubmit(event) { } // Update functions -async function updateMovieDate(imdbId, dateadded, source) { +async function updateMovieDate(imdbId, dateadded, source, instance) { + instance = instance || 'radarr'; try { const result = await apiCall(`/api/movies/${imdbId}`, { method: 'PUT', body: JSON.stringify({ dateadded: dateadded, - source: source + source: source, + instance: instance }) }); @@ -1194,13 +1304,15 @@ async function updateMovieDate(imdbId, dateadded, source) { } } -async function updateEpisodeDate(imdbId, season, episode, dateadded, source) { +async function updateEpisodeDate(imdbId, season, episode, dateadded, source, instance) { + instance = instance || 'sonarr'; try { const result = await apiCall(`/api/episodes/${imdbId}/${season}/${episode}`, { method: 'PUT', body: JSON.stringify({ dateadded: dateadded, - source: source + source: source, + instance: instance }) }); @@ -1215,7 +1327,7 @@ async function updateEpisodeDate(imdbId, season, episode, dateadded, source) { const episodesModal = document.getElementById('episodes-modal'); if (episodesModal) { closeEpisodesModal(); - setTimeout(() => viewSeriesEpisodes(imdbId), 100); + setTimeout(() => viewSeriesEpisodes(imdbId, instance), 100); } } catch (error) { @@ -1279,9 +1391,9 @@ function showToast(message, type = 'info') { } // Debug function -async function debugMovie(imdbId) { +async function debugMovie(imdbId, instance = 'radarr') { try { - const data = await apiCall(`/api/debug/movie/${imdbId}/raw`); + const data = await apiCall(`/api/debug/movie/${imdbId}/raw?instance=${encodeURIComponent(instance)}`); const debugInfo = ` DEBUG INFO for ${imdbId}: @@ -1311,23 +1423,23 @@ Analysis: } // Episode deletion functionality -async function deleteEpisode(imdbId, season, episode) { +async function deleteEpisode(imdbId, season, episode, instance = 'sonarr') { // Validate parameters if (!imdbId || season === undefined || season === null || episode === undefined || episode === null) { console.error('deleteEpisode: Invalid parameters:', {imdbId, season, episode}); showToast('Invalid episode parameters', 'error'); return; } - + const episodeStr = `S${season.toString().padStart(2, '0')}E${episode.toString().padStart(2, '0')}`; - + // Confirmation dialog if (!confirm(`⚠️ Delete Episode ${episodeStr}?\n\nThis will permanently remove the episode from the database.\n\nAre you sure you want to continue?`)) { return; } - + try { - const response = await fetch(`/api/episodes/${imdbId}/${season}/${episode}`, { + const response = await fetch(`/api/episodes/${imdbId}/${season}/${episode}?instance=${encodeURIComponent(instance)}`, { method: 'DELETE', headers: { 'Content-Type': 'application/json' @@ -1363,14 +1475,14 @@ async function deleteEpisode(imdbId, season, episode) { } // Movie deletion functionality -async function deleteMovie(imdbId) { +async function deleteMovie(imdbId, instance = 'radarr') { // Confirmation dialog if (!confirm(`⚠️ Delete Movie?\n\nThis will permanently remove the movie (${imdbId}) from the database.\n\nAre you sure you want to continue?`)) { return; } - + try { - const response = await fetch(`/api/movies/${imdbId}`, { + const response = await fetch(`/api/movies/${imdbId}?instance=${encodeURIComponent(instance)}`, { method: 'DELETE', headers: { 'Content-Type': 'application/json' @@ -1396,6 +1508,33 @@ async function deleteMovie(imdbId) { } } +async function deleteSeries(imdbId, instance, title) { + if (!confirm(`⚠️ Delete Series?\n\n"${title}"\n\nThis will permanently remove the series and ALL its episodes from the database.\n\nAre you sure you want to continue?`)) { + return; + } + + try { + const response = await fetch(`/api/series/${imdbId}?instance=${encodeURIComponent(instance)}`, { + method: 'DELETE', + headers: { 'Content-Type': 'application/json' } + }); + + const result = await response.json(); + + if (response.ok && result.success) { + showToast(`✅ Series deleted (${result.episodes_deleted} episode(s) removed)`, 'success'); + loadSeries(currentSeriesPage); + } else { + const errorMsg = result.message || result.detail || result.error || 'Unknown error'; + showToast(`❌ Failed to delete series: ${errorMsg}`, 'error'); + } + + } catch (error) { + console.error('Delete series failed:', error); + showToast(`❌ Delete failed: ${error.message}`, 'error'); + } +} + // Update episode counts in modal after deletion function updateEpisodeModalCounts() { const remainingRows = document.querySelectorAll('#episodes-table-body tr'); @@ -1706,9 +1845,10 @@ async function bulkDeleteSelected() { const imdbId = row.getAttribute('data-imdb'); const season = parseInt(row.getAttribute('data-season')); const episode = parseInt(row.getAttribute('data-episode')); - + const instance = row.getAttribute('data-instance') || 'sonarr'; + try { - const response = await apiCall(`/api/episodes/${imdbId}/${season}/${episode}`, { + const response = await apiCall(`/api/episodes/${imdbId}/${season}/${episode}?instance=${encodeURIComponent(instance)}`, { method: 'DELETE' }); @@ -1748,10 +1888,279 @@ async function bulkDeleteSelected() { // Database Population Functions // --------------------------- +// Fills the Instance dropdown on the Populate Database card from the same +// /api/instances data the sidebar already uses — "All Instances" plus one +// entry per configured Radarr/Sonarr instance, grouped by type so it's +// obvious which is which once there's more than a couple. +async function loadPopulateInstanceOptions() { + const select = document.getElementById('populate-instance'); + if (!select) return; + + try { + const data = await apiCall('/api/instances'); + const radarrNames = (data.radarr || []).map(i => i.name); + const sonarrNames = (data.sonarr || []).map(i => i.name); + + // Keep "All Instances", drop everything else and rebuild — this + // gets called every time the Tools tab is opened, so it has to be + // safe to run repeatedly without piling up duplicate options. + select.innerHTML = ''; + + if (radarrNames.length) { + const group = document.createElement('optgroup'); + group.label = 'Radarr'; + radarrNames.forEach(name => { + const opt = document.createElement('option'); + opt.value = name; + opt.textContent = name; + opt.dataset.mediaType = 'movies'; + group.appendChild(opt); + }); + select.appendChild(group); + } + + if (sonarrNames.length) { + const group = document.createElement('optgroup'); + group.label = 'Sonarr'; + sonarrNames.forEach(name => { + const opt = document.createElement('option'); + opt.value = name; + opt.textContent = name; + opt.dataset.mediaType = 'tv'; + group.appendChild(opt); + }); + select.appendChild(group); + } + + // Reset in case the last selection here no longer exists (e.g. an + // instance was deleted since this was last loaded). + syncPopulateMediaTypeToInstance(); + } catch (error) { + console.error('Failed to load instances for populate dropdown:', error); + // Leave just "All Instances" — populate still works, just without + // the ability to target a single instance until this loads. + } +} + +function syncPopulateMediaTypeToInstance() { + const instanceSelect = document.getElementById('populate-instance'); + const mediaTypeSelect = document.getElementById('populate-media-type'); + if (!instanceSelect || !mediaTypeSelect) return; + + const selectedOption = instanceSelect.options[instanceSelect.selectedIndex]; + const mediaType = selectedOption ? selectedOption.dataset.mediaType : null; + + if (instanceSelect.value !== 'all' && mediaType) { + // A specific instance can only ever be one media type — a Radarr + // instance is movies, a Sonarr instance is TV. Lock the Media Type + // dropdown to match instead of making the user keep the two in sync + // by hand (picking the wrong one used to silently populate nothing). + mediaTypeSelect.value = mediaType; + mediaTypeSelect.disabled = true; + } else { + mediaTypeSelect.disabled = false; + } +} + +// --- Log Files (Tools tab) --- +let logTailAutoRefreshTimer = null; + +function formatBytes(bytes) { + if (!bytes) return '0 B'; + const units = ['B', 'KB', 'MB', 'GB']; + const i = Math.min(units.length - 1, Math.floor(Math.log(bytes) / Math.log(1024))); + return `${(bytes / Math.pow(1024, i)).toFixed(i === 0 ? 0 : 1)} ${units[i]}`; +} + +async function loadLogFiles() { + const listEl = document.getElementById('log-files-list'); + const fileSelect = document.getElementById('log-tail-file'); + if (!listEl || !fileSelect) return; + + try { + const data = await apiCall('/api/logs'); + const files = data.files || []; + + if (files.length === 0) { + listEl.innerHTML = '

No log files found.

'; + fileSelect.innerHTML = ''; + return; + } + + listEl.innerHTML = ` + + + + + + ${files.map(f => ` + + + + + + + `).join('')} + +
FileSizeModifiedActions
${escapeHtml(f.filename)}${f.is_current ? ' current' : ''}${formatBytes(f.size_bytes)}${formatDateTime(f.modified_at)} + + Download + +
+ `; + + // Preserve the current tail-file selection across refreshes (this is + // called every time the Tools tab is opened) if it still exists. + const previousSelection = fileSelect.value; + fileSelect.innerHTML = files.map(f => + `` + ).join(''); + if (files.some(f => f.filename === previousSelection)) { + fileSelect.value = previousSelection; + } + } catch (error) { + listEl.innerHTML = '

Failed to load log files.

'; + } +} + +async function refreshLogTail() { + const fileSelect = document.getElementById('log-tail-file'); + const linesSelect = document.getElementById('log-tail-lines'); + const output = document.getElementById('log-tail-output'); + if (!fileSelect || !fileSelect.value || !output) return; + + // Only follow to the bottom if the viewer was already there (or close to + // it) before this refresh. Otherwise every 5s auto-refresh yanks anyone + // who scrolled up to read older lines straight back down again. + const nearBottomTolerancePx = 24; + const wasNearBottom = output.scrollHeight - output.clientHeight - output.scrollTop <= nearBottomTolerancePx; + + try { + const data = await apiCall(`/api/logs/${encodeURIComponent(fileSelect.value)}/tail?lines=${linesSelect.value}`); + output.textContent = (data.lines || []).join('\n') || '(empty)'; + if (wasNearBottom) { + output.scrollTop = output.scrollHeight; + } + } catch (error) { + output.textContent = 'Failed to load log tail.'; + } +} + +function stopLogTailAutoRefresh() { + if (logTailAutoRefreshTimer) { + clearInterval(logTailAutoRefreshTimer); + logTailAutoRefreshTimer = null; + } + const checkbox = document.getElementById('log-tail-auto-refresh'); + if (checkbox) checkbox.checked = false; +} + +function toggleLogTailAutoRefresh() { + const checkbox = document.getElementById('log-tail-auto-refresh'); + if (logTailAutoRefreshTimer) { + clearInterval(logTailAutoRefreshTimer); + logTailAutoRefreshTimer = null; + } + if (checkbox && checkbox.checked) { + refreshLogTail(); + logTailAutoRefreshTimer = setInterval(refreshLogTail, 5000); + } +} + +// --- Unresolved Lookups (Tools tab) --- + +const UNRESOLVED_REASON_LABELS = { + no_db_record: 'No DB record', + no_resolved_date: 'In DB, no date yet' +}; + +async function loadUnresolvedLookups() { + const listEl = document.getElementById('unresolved-lookups-list'); + const showDismissed = document.getElementById('unresolved-show-dismissed'); + if (!listEl) return; + + try { + const includeDismissed = showDismissed && showDismissed.checked; + const data = await apiCall(`/api/unresolved-lookups?include_dismissed=${includeDismissed ? 'true' : 'false'}`); + const lookups = data.lookups || []; + + if (lookups.length === 0) { + listEl.innerHTML = '

Nothing unresolved right now.

'; + return; + } + + listEl.innerHTML = ` + + + + + + + + + + + + + + + ${lookups.map(l => { + const isEpisode = l.media_type === 'episode'; + const episodeTag = isEpisode ? ` S${String(l.season).padStart(2, '0')}E${String(l.episode).padStart(2, '0')}` : ''; + return ` + + + + + + + + + + + `; + }).join('')} + +
TypeTitleIMDb IDReasonInstanceMissesLast SeenActions
${isEpisode ? 'Episode' : 'Movie'}${l.title ? escapeHtml(l.title) + episodeTag : 'unknown'}${escapeHtml(l.imdb_id)}${escapeHtml(UNRESOLVED_REASON_LABELS[l.reason] || l.reason)}${escapeHtml(l.instance || '')}${l.miss_count}${formatDateTime(l.last_seen)} + ${l.dismissed + ? 'dismissed' + : `` + } +
+ `; + } catch (error) { + listEl.innerHTML = '

Failed to load unresolved lookups.

'; + } +} + +async function dismissUnresolvedLookup(id) { + try { + await apiCall(`/api/unresolved-lookups/${id}/dismiss`, { method: 'POST' }); + loadUnresolvedLookups(); + } catch (error) { + // apiCall already surfaces a toast on failure + } +} + +async function dismissAllUnresolvedLookups() { + if (!confirm('Dismiss every unresolved lookup currently shown? Any that miss again later will resurface.')) { + return; + } + try { + const result = await apiCall('/api/unresolved-lookups/dismiss-all', { method: 'POST' }); + showToast(`✅ Dismissed ${result.dismissed_count || 0} lookups`, 'success'); + loadUnresolvedLookups(); + } catch (error) { + // apiCall already surfaces a toast on failure + } +} + async function handlePopulateDatabase(event) { event.preventDefault(); const mediaType = document.getElementById('populate-media-type').value; + const instanceSelect = document.getElementById('populate-instance'); + const instance = instanceSelect ? instanceSelect.value : 'all'; // Validate input if (!mediaType) { @@ -1760,7 +2169,8 @@ async function handlePopulateDatabase(event) { } // Confirm with user - const confirmMsg = `Are you sure you want to populate the database with ${mediaType}? This will query Radarr/Sonarr and may take several minutes.`; + const target = instance !== 'all' ? `instance '${instance}'` : `${mediaType}`; + const confirmMsg = `Are you sure you want to populate the database with ${target}? This will query Radarr/Sonarr and may take several minutes.`; if (!confirm(confirmMsg)) { return; } @@ -1771,7 +2181,7 @@ async function handlePopulateDatabase(event) { // Start the population showToast('🚀 Starting database population...', 'info'); - const response = await fetch(`/admin/populate-database?media_type=${mediaType}`, { + const response = await fetch(`/admin/populate-database?media_type=${mediaType}&instance=${encodeURIComponent(instance)}`, { method: 'POST', credentials: 'include' }); @@ -1852,6 +2262,33 @@ function stopPopulatePolling() { } } +// Renders a collapsed-by-default
list of populate-run items — +// used for both added_items and skipped_items, which can run into the +// thousands on a full library sync, so this is never expanded by default. +// Item shape tells movie apart from episode: episodes carry `season`. +function renderPopulateItemsList(items, label) { + if (!items || items.length === 0) return ''; + + const rows = items.map(item => { + if ('season' in item) { + const ep = `S${String(item.season).padStart(2, '0')}E${String(item.episode).padStart(2, '0')}`; + const extra = item.reason ? escapeHtml(item.reason) : escapeHtml(item.source || ''); + return `${escapeHtml(item.title || 'Unknown')} ${ep} (${escapeHtml(item.episode_title || 'Unknown')}) — ${extra}`; + } + const extra = item.reason ? escapeHtml(item.reason) : escapeHtml(item.source || ''); + return `${escapeHtml(item.title || 'Unknown')} (${item.year || 'N/A'}) [${escapeHtml(item.imdb_id || '')}] — ${extra}`; + }); + + return ` +
+ ${label} (${items.length}) +
+ ${rows.map(r => `
${r}
`).join('')} +
+
+ `; +} + function updatePopulateProgress(status) { const progressBar = document.getElementById('populate-progress-bar'); const operationText = document.getElementById('populate-current-operation'); @@ -1882,6 +2319,8 @@ function updatePopulateProgress(status) { Movies:
Total: ${m.total || 0} | Added: ${m.added || 0} | Skipped: ${m.skipped || 0} | Errors: ${m.errors || 0}
Duration: ${m.duration ? m.duration.toFixed(2) : 0}s + ${renderPopulateItemsList(m.added_items, 'Added')} + ${renderPopulateItemsList(m.skipped_items, 'Skipped')}
`; } @@ -1894,6 +2333,8 @@ function updatePopulateProgress(status) { Series: ${t.total_series || 0} | Episodes: ${t.total_episodes || 0}
Added: ${t.added || 0} | Skipped: ${t.skipped || 0} | Errors: ${t.errors || 0}
Duration: ${t.duration ? t.duration.toFixed(2) : 0}s + ${renderPopulateItemsList(t.added_items, 'Added')} + ${renderPopulateItemsList(t.skipped_items, 'Skipped')}
`; } diff --git a/static/setup.html b/static/setup.html new file mode 100644 index 0000000..9a32010 --- /dev/null +++ b/static/setup.html @@ -0,0 +1,1105 @@ + + + + + + Chronarr — Setup + + + + + +
+
+
+

Chronarr

+

Setup & Webhook Configuration

+
+
+ +
+ + Back to Dashboard + + + +
+

Chronarr Core URL

+
+ + + +
+

+ This is the address Radarr and Sonarr will use to reach Chronarr's core container. + Defaults to the address you're viewing this page from, but that's often wrong: if Radarr/Sonarr + run as Docker containers on the same network as Chronarr, use the Docker + container or service name instead (e.g. http://chronarr-core:8080, + not this page's IP) — container names resolve between containers on a shared network even when + the host IP doesn't. Edit it once here and all webhook URLs below update automatically; your + change is remembered in this browser so it won't reset on the next visit. +

+
+ + +
+

Radarr Instances

+
+ Loading… +
+
+ + +
+

Sonarr Instances

+
+ Loading… +
+
+ + +
+

Add Instance

+ +
+
+ + +
+

Backup & Restore Config

+

+ A snapshot of .env and .env.secrets exactly as they are right now — + every comment and setting, byte for byte. The downloaded file contains your real API keys and + database passwords in plain text, so store it the same way you'd store either of those files. + Every wizard save above also takes an automatic snapshot first, so a bad save is never a dead end. +

+
+ + Download Backup + + + +
+
+
+
+
+ + + + diff --git a/utils/file_utils.py b/utils/file_utils.py index 115d4b5..71f71bb 100644 --- a/utils/file_utils.py +++ b/utils/file_utils.py @@ -1,74 +1,49 @@ -""" -File utility functions for Chronarr -Common file operations to eliminate code duplication -""" +"""File utilities — path resolution, video file discovery, episode parsing.""" import glob import re +import time from pathlib import Path from typing import Optional, List, Dict, Tuple, Union from utils.logging import _log -# Video file extensions used throughout the application VIDEO_EXTENSIONS = {'.mkv', '.mp4', '.avi', '.m4v', '.mov', '.ts'} -# Episode pattern for TV series files EPISODE_PATTERN = re.compile( r'.*[sS](\d{1,2})[eE](\d{1,3}).*|.*(\d{1,2})x(\d{1,3}).*' ) def find_media_path_by_imdb_and_title( - title: str, - imdb_id: str, - search_paths: List[Path], + title: str, + imdb_id: str, + search_paths: List[Path], webhook_path: Optional[str] = None, - path_mapper = None + path_mapper=None ) -> Optional[Path]: - """ - Unified media path finder for both TV series and movies - - Args: - title: Media title to search for - imdb_id: IMDb ID to search for - search_paths: List of paths to search in (tv_paths or movie_paths) - webhook_path: Optional webhook path to try first - path_mapper: Optional path mapper for webhook path conversion - - Returns: - Path to media directory if found, None otherwise - """ - # Try webhook path first if provided + """Find a media directory by trying the webhook path first, then searching configured paths.""" + # The webhook payload often carries the exact path — try it before scanning directories. if webhook_path and path_mapper: try: - if hasattr(path_mapper, 'sonarr_path_to_container_path'): - container_path = path_mapper.sonarr_path_to_container_path(webhook_path) - elif hasattr(path_mapper, 'radarr_path_to_container_path'): - container_path = path_mapper.radarr_path_to_container_path(webhook_path) - else: - container_path = webhook_path - + container_path = path_mapper.map(webhook_path) path_obj = Path(container_path) if path_obj.exists(): return path_obj except Exception as e: _log("WARNING", f"Failed to process webhook path {webhook_path}: {e}") - # Search by IMDb ID or title in configured paths for media_path in search_paths: if not media_path.exists(): continue - - # Search by IMDb ID first (more reliable) + if imdb_id: - # Use proper glob pattern - escape brackets to match literal [imdb-ID] + # Escape brackets so glob treats them as literals, not character classes. pattern = str(media_path / f"*\\[imdb-{imdb_id}\\]*") matches = glob.glob(pattern) if matches: return Path(matches[0]) - - # Search by title as fallback + if title: title_clean = clean_title_for_search(title) for item in media_path.iterdir(): @@ -81,34 +56,16 @@ def find_media_path_by_imdb_and_title( def clean_title_for_search(title: str) -> str: - """ - Clean title for fuzzy matching - - Args: - title: Raw title string - - Returns: - Cleaned title for comparison - """ + """Strip spaces, dashes, and dots for fuzzy directory name matching.""" return title.lower().replace(" ", "").replace("-", "").replace(".", "") def find_video_files(directory: Path, recursive: bool = True) -> List[Path]: - """ - Find all video files in a directory - - Args: - directory: Directory to search - recursive: Whether to search recursively - - Returns: - List of video file paths - """ if not directory.exists(): return [] - + video_files = [] - + if recursive: for item in directory.rglob('*'): if item.is_file() and item.suffix.lower() in VIDEO_EXTENSIONS: @@ -117,20 +74,52 @@ def find_video_files(directory: Path, recursive: bool = True) -> List[Path]: for item in directory.iterdir(): if item.is_file() and item.suffix.lower() in VIDEO_EXTENSIONS: video_files.append(item) - + return video_files -def extract_episode_info(filename: str) -> Optional[Tuple[int, int]]: - """ - Extract season and episode numbers from filename - - Args: - filename: Video filename to parse - - Returns: - Tuple of (season, episode) if found, None otherwise +# Some network/FUSE-backed mounts (e.g. decypharr's DFS backend for debrid/usenet +# libraries) can report a just-created file as briefly unreadable — ENOTCONN or +# similar — for a few seconds right after it's symlinked in, while the mount's +# own backing downloader for that file finishes initializing. That's a timing +# race in the mount layer, not a real "file is missing" condition, so retrying +# a few times rides it out instead of failing the whole webhook on a one-off +# blip. Starting point: 5 attempts, 3s apart (~15s of patience before giving +# up) — tune these two constants if that's not enough (or is too much) in +# practice. +TRANSIENT_FS_RETRIES = 5 +TRANSIENT_FS_RETRY_DELAY = 3.0 + + +def list_video_files_with_retry( + directory: Path, + retries: int = TRANSIENT_FS_RETRIES, + delay: float = TRANSIENT_FS_RETRY_DELAY, +) -> List[Path]: + """Return video files directly under `directory` (non-recursive), retrying + the whole listing+stat pass on a transient OSError (e.g. ENOTCONN) instead + of letting it propagate and fail the caller immediately. + + Re-raises the last OSError once every attempt is exhausted, so a genuinely + broken mount still surfaces loudly rather than being silently treated as + "no video files found". """ + last_exc: Optional[OSError] = None + for attempt in range(1, retries + 1): + try: + return [ + item for item in directory.iterdir() + if item.is_file() and item.suffix.lower() in VIDEO_EXTENSIONS + ] + except OSError as e: + last_exc = e + if attempt < retries: + _log("WARNING", f"Transient error listing {directory} (attempt {attempt}/{retries}): {e} — retrying in {delay}s") + time.sleep(delay) + raise last_exc + + +def extract_episode_info(filename: str) -> Optional[Tuple[int, int]]: match = EPISODE_PATTERN.match(filename) if not match: return None @@ -148,15 +137,7 @@ def extract_episode_info(filename: str) -> Optional[Tuple[int, int]]: def find_episodes_on_disk(series_path: Path) -> Dict[Tuple[int, int], List[Path]]: - """ - Find all episodes on disk and return mapping of (season, episode) -> [video_files] - - Args: - series_path: Path to series directory - - Returns: - Dictionary mapping (season, episode) tuples to lists of video files - """ + """Map (season, episode) tuples to their video files for a series directory.""" episodes = {} if not series_path.exists(): diff --git a/utils/logging.py b/utils/logging.py index 8ca97c3..ca4eadc 100644 --- a/utils/logging.py +++ b/utils/logging.py @@ -10,6 +10,26 @@ from zoneinfo import ZoneInfo +_LEVEL_VALUES = { + "DEBUG": logging.DEBUG, + "INFO": logging.INFO, + "WARNING": logging.WARNING, + "ERROR": logging.ERROR, + "CRITICAL": logging.CRITICAL, +} + + +def _configured_log_level() -> int: + """Minimum level that actually gets written, to both console and file. + + Defaults to INFO — DEBUG lines (the bulk of the volume: per-file webhook + tracing, tier-by-tier date-decision detail, etc.) are still available by + setting LOG_LEVEL=DEBUG, they're just not the default anymore. + """ + name = os.environ.get("LOG_LEVEL", "INFO").upper() + return _LEVEL_VALUES.get(name, logging.INFO) + + class SafeRotatingFileHandler(logging.handlers.RotatingFileHandler): """A RotatingFileHandler that handles missing backup files gracefully""" @@ -91,7 +111,7 @@ def _setup_file_logging(): log_dir.mkdir(parents=True, exist_ok=True) logger = logging.getLogger("Chronarr") - logger.setLevel(logging.DEBUG) + logger.setLevel(_configured_log_level()) # Clear any existing handlers to avoid duplicates logger.handlers.clear() @@ -178,11 +198,20 @@ def _get_local_timezone(): def _log(level: str, msg: str): - """Enhanced logging that writes to both console and file with sensitive data masking""" + """Enhanced logging that writes to both console and file with sensitive data masking. + + Below-threshold calls (see _configured_log_level()) are dropped before the + print() below, which is otherwise unconditional and is what actually shows + up in `docker compose logs` — the file logger's own level check alone + doesn't gate console output. + """ + if _LEVEL_VALUES.get(level.upper(), logging.INFO) < _configured_log_level(): + return + masked_msg = _mask_sensitive_data(msg) tz = _get_local_timezone() print(f"[{datetime.now(tz).isoformat(timespec='seconds')}] {level}: {masked_msg}") - + try: file_logger = _setup_file_logging() getattr(file_logger, level.lower(), file_logger.info)(masked_msg) diff --git a/utils/orphaned_cleanup.py b/utils/orphaned_cleanup.py index d10838f..a3dbc5c 100644 --- a/utils/orphaned_cleanup.py +++ b/utils/orphaned_cleanup.py @@ -8,24 +8,69 @@ from datetime import datetime from core.logging import _log +from clients.radarr_db_client import RadarrDbClient +from clients.sonarr_db_client import SonarrDbClient class OrphanedRecordCleaner: - """Clean up orphaned records from Chronarr database""" + """Clean up orphaned records from Chronarr database, per (imdb_id, instance). - def __init__(self, chronarr_db, radarr_db_client=None, sonarr_db_client=None): + The same IMDb ID can have independent rows under multiple Radarr/Sonarr + instances (a full back-catalog under the default instance, a separate + smaller pickup under a named one). Every check and delete here is scoped + to one row's own instance — resolved from the InstanceRegistry — so + checking or removing one instance's row never touches another instance's + still-valid data sharing the same IMDb ID. + """ + + def __init__(self, chronarr_db, registry=None, radarr_db_client=None, sonarr_db_client=None): """ Initialize cleanup utility Args: chronarr_db: ChronarrDatabase instance - radarr_db_client: Optional RadarrDbClient instance - sonarr_db_client: Optional SonarrDbClient instance + registry: InstanceRegistry — resolves the right Radarr/Sonarr client + per row's own instance. Required for check_database to work + correctly across more than the default instance. + radarr_db_client, sonarr_db_client: fallback single clients, used only + when registry is None or doesn't have a client for a row's instance + (legacy/test construction path — same pattern as TVProcessor/MovieProcessor). """ self.chronarr_db = chronarr_db + self.registry = registry self.radarr_db = radarr_db_client self.sonarr_db = sonarr_db_client + def _resolve_radarr(self, instance: str): + """Return a Radarr client for this instance, or the fallback default.""" + if self.registry: + client = self.registry.radarr(instance) + if client is not None: + return client + return self.radarr_db + + def _resolve_sonarr(self, instance: str): + """Return a Sonarr client for this instance, or the fallback default.""" + if self.registry: + client = self.registry.sonarr(instance) + if client is not None: + return client + return self.sonarr_db + + @staticmethod + def _radarr_movie_by_imdb(client, imdb_id: str) -> Optional[Dict[str, Any]]: + """Call whichever lookup method this client type actually has.""" + if isinstance(client, RadarrDbClient): + return client.get_movie_by_imdb(imdb_id) + return client.movie_by_imdb(imdb_id) + + @staticmethod + def _sonarr_series_by_imdb(client, imdb_id: str) -> Optional[Dict[str, Any]]: + """Call whichever lookup method this client type actually has.""" + if isinstance(client, SonarrDbClient): + return client.get_series_by_imdb(imdb_id) + return client.series_by_imdb(imdb_id) + def find_orphaned_movies(self, check_filesystem: bool = True, check_database: bool = True) -> List[Dict[str, Any]]: """ Find orphaned movie records @@ -43,7 +88,7 @@ def find_orphaned_movies(self, check_filesystem: bool = True, check_database: bo with self.chronarr_db.get_connection() as conn: cursor = conn.cursor() cursor.execute(""" - SELECT imdb_id, title, path, dateadded + SELECT imdb_id, instance, title, path, dateadded FROM movies ORDER BY title """) @@ -53,6 +98,7 @@ def find_orphaned_movies(self, check_filesystem: bool = True, check_database: bo for movie in movies: imdb_id = movie['imdb_id'] + instance = movie['instance'] title = movie['title'] file_path = movie.get('path') @@ -66,15 +112,19 @@ def find_orphaned_movies(self, check_filesystem: bool = True, check_database: bo filesystem_missing = True reasons.append(f"File not found: {file_path}") - # Check 2: Radarr database - if check_database and self.radarr_db: - try: - radarr_movie = self.radarr_db.get_movie_by_imdb(imdb_id) - if not radarr_movie: - database_missing = True - reasons.append("Not found in Radarr database") - except Exception as e: - _log("WARNING", f"Error checking Radarr DB for {imdb_id}: {e}") + # Check 2: this row's own Radarr instance's database + if check_database: + radarr_client = self._resolve_radarr(instance) + if radarr_client: + try: + radarr_movie = self._radarr_movie_by_imdb(radarr_client, imdb_id) + if not radarr_movie: + database_missing = True + reasons.append(f"Not found in Radarr database (instance: {instance})") + except Exception as e: + _log("WARNING", f"[{instance}] Error checking Radarr DB for {imdb_id}: {e}") + else: + _log("WARNING", f"[{instance}] No Radarr client available to verify {imdb_id} — skipping database check for this row") # Orphaned if BOTH checks fail (hybrid approach) if check_filesystem and check_database: @@ -89,6 +139,7 @@ def find_orphaned_movies(self, check_filesystem: bool = True, check_database: bo if is_orphaned and reasons: orphaned.append({ 'imdb_id': imdb_id, + 'instance': instance, 'title': title, 'file_path': file_path, 'dateadded': movie.get('dateadded'), @@ -116,7 +167,7 @@ def find_orphaned_series(self, check_filesystem: bool = True, check_database: bo with self.chronarr_db.get_connection() as conn: cursor = conn.cursor() cursor.execute(""" - SELECT imdb_id, path + SELECT imdb_id, instance, path FROM series ORDER BY path """) @@ -126,6 +177,7 @@ def find_orphaned_series(self, check_filesystem: bool = True, check_database: bo for series in series_list: imdb_id = series['imdb_id'] + instance = series['instance'] series_path = series.get('path') # Extract title from path for display purposes title = Path(series_path).name if series_path else imdb_id @@ -140,15 +192,19 @@ def find_orphaned_series(self, check_filesystem: bool = True, check_database: bo filesystem_missing = True reasons.append(f"Series path not found: {series_path}") - # Check 2: Sonarr database - if check_database and self.sonarr_db: - try: - sonarr_series = self.sonarr_db.get_series_by_imdb(imdb_id) - if not sonarr_series: - database_missing = True - reasons.append("Not found in Sonarr database") - except Exception as e: - _log("WARNING", f"Error checking Sonarr DB for {imdb_id}: {e}") + # Check 2: this row's own Sonarr instance's database + if check_database: + sonarr_client = self._resolve_sonarr(instance) + if sonarr_client: + try: + sonarr_series = self._sonarr_series_by_imdb(sonarr_client, imdb_id) + if not sonarr_series: + database_missing = True + reasons.append(f"Not found in Sonarr database (instance: {instance})") + except Exception as e: + _log("WARNING", f"[{instance}] Error checking Sonarr DB for {imdb_id}: {e}") + else: + _log("WARNING", f"[{instance}] No Sonarr client available to verify {imdb_id} — skipping database check for this row") # Orphaned if BOTH checks fail (hybrid approach) if check_filesystem and check_database: @@ -161,19 +217,20 @@ def find_orphaned_series(self, check_filesystem: bool = True, check_database: bo is_orphaned = False if is_orphaned and reasons: - # Count episodes for this series + # Count episodes for this series, scoped to the same instance with self.chronarr_db.get_connection() as conn: cursor = conn.cursor() cursor.execute(""" SELECT COUNT(*) as episode_count FROM episodes - WHERE imdb_id = %s - """, (imdb_id,)) + WHERE imdb_id = %s AND instance = %s + """, (imdb_id, instance)) result = cursor.fetchone() episode_count = result['episode_count'] if result else 0 orphaned.append({ 'imdb_id': imdb_id, + 'instance': instance, 'title': title, 'series_path': series_path, 'episode_count': episode_count, @@ -200,24 +257,25 @@ def remove_orphaned_movies(self, orphaned_movies: List[Dict[str, Any]], dry_run: for movie in orphaned_movies: imdb_id = movie['imdb_id'] + instance = movie.get('instance', 'radarr') title = movie['title'] reasons = ', '.join(movie['reasons']) if dry_run: - _log("INFO", f"[DRY RUN] Would remove movie: {title} ({imdb_id}) - Reasons: {reasons}") + _log("INFO", f"[DRY RUN] Would remove movie: {title} ({imdb_id}, instance: {instance}) - Reasons: {reasons}") removed_titles.append(f"{title} ({imdb_id})") removed_count += 1 else: try: with self.chronarr_db.get_connection() as conn: cursor = conn.cursor() - cursor.execute("DELETE FROM movies WHERE imdb_id = %s", (imdb_id,)) + cursor.execute("DELETE FROM movies WHERE imdb_id = %s AND instance = %s", (imdb_id, instance)) - _log("INFO", f"Removed orphaned movie: {title} ({imdb_id}) - Reasons: {reasons}") + _log("INFO", f"Removed orphaned movie: {title} ({imdb_id}, instance: {instance}) - Reasons: {reasons}") removed_titles.append(f"{title} ({imdb_id})") removed_count += 1 except Exception as e: - _log("ERROR", f"Failed to remove movie {imdb_id}: {e}") + _log("ERROR", f"[{instance}] Failed to remove movie {imdb_id}: {e}") return { 'removed_count': removed_count, @@ -242,12 +300,13 @@ def remove_orphaned_series(self, orphaned_series: List[Dict[str, Any]], dry_run: for series in orphaned_series: imdb_id = series['imdb_id'] + instance = series.get('instance', 'sonarr') title = series['title'] episode_count = series.get('episode_count', 0) reasons = ', '.join(series['reasons']) if dry_run: - _log("INFO", f"[DRY RUN] Would remove series: {title} ({imdb_id}) with {episode_count} episodes - Reasons: {reasons}") + _log("INFO", f"[DRY RUN] Would remove series: {title} ({imdb_id}, instance: {instance}) with {episode_count} episodes - Reasons: {reasons}") removed_titles.append(f"{title} ({imdb_id}) - {episode_count} episodes") removed_count += 1 removed_episodes += episode_count @@ -256,16 +315,16 @@ def remove_orphaned_series(self, orphaned_series: List[Dict[str, Any]], dry_run: with self.chronarr_db.get_connection() as conn: cursor = conn.cursor() # Remove episodes first - cursor.execute("DELETE FROM episodes WHERE imdb_id = %s", (imdb_id,)) + cursor.execute("DELETE FROM episodes WHERE imdb_id = %s AND instance = %s", (imdb_id, instance)) # Then remove series - cursor.execute("DELETE FROM series WHERE imdb_id = %s", (imdb_id,)) + cursor.execute("DELETE FROM series WHERE imdb_id = %s AND instance = %s", (imdb_id, instance)) - _log("INFO", f"Removed orphaned series: {title} ({imdb_id}) with {episode_count} episodes - Reasons: {reasons}") + _log("INFO", f"Removed orphaned series: {title} ({imdb_id}, instance: {instance}) with {episode_count} episodes - Reasons: {reasons}") removed_titles.append(f"{title} ({imdb_id}) - {episode_count} episodes") removed_count += 1 removed_episodes += episode_count except Exception as e: - _log("ERROR", f"Failed to remove series {imdb_id}: {e}") + _log("ERROR", f"[{instance}] Failed to remove series {imdb_id}: {e}") return { 'removed_count': removed_count, diff --git a/webhooks/webhook_batcher.py b/webhooks/webhook_batcher.py index 49d071e..68595bd 100644 --- a/webhooks/webhook_batcher.py +++ b/webhooks/webhook_batcher.py @@ -13,6 +13,14 @@ from utils.imdb_utils import find_imdb_in_directory, parse_imdb_from_path # Phase 3: Replaced NFOManager +def _tag(instance: str, req_id: str = None) -> str: + """Log-line prefix: 'instance' alone, or 'instance:req_id' when a request + id is available — lets related lines for one webhook be told apart from + others landing around the same time, without threading req_id through + every call in the processors.""" + return f"{instance}:{req_id}" if req_id else instance + + class WebhookBatcher: """Batches webhook events to avoid processing storms""" @@ -53,8 +61,10 @@ def add_webhook(self, key: str, webhook_data: Dict, media_type: str): webhook_data['episodes'] = existing_eps self.pending[key] = webhook_data - _log("INFO", f"Batched {media_type} webhook for {key} ({len(webhook_data.get('episodes', []))} episode(s) pending)") - _log("DEBUG", f"Batch added - key: {key}, media_type: {media_type}, timer scheduled for {config.batch_delay}s") + instance = webhook_data.get('instance', media_type) + tag = _tag(instance, webhook_data.get('req_id')) + _log("INFO", f"[{tag}] Batched {media_type} webhook for {key} ({len(webhook_data.get('episodes', []))} episode(s) pending)") + _log("DEBUG", f"[{tag}] Batch added - key: {key}, media_type: {media_type}, timer scheduled for {config.batch_delay}s") timer = threading.Timer(config.batch_delay, self._process_item, args=[key]) self.timers[key] = timer @@ -68,7 +78,9 @@ def _process_item(self, key: str): if key in self.processing: # Previous batch for this key is still running — re-schedule so accumulated # episode data isn't stranded with no timer and no processor to pick it up. - _log("DEBUG", f"Batch item {key} still processing, re-scheduling in {config.batch_delay}s") + instance = self.pending[key].get('instance', '?') + tag = _tag(instance, self.pending[key].get('req_id')) + _log("DEBUG", f"[{tag}] Batch item {key} still processing, re-scheduling in {config.batch_delay}s") timer = threading.Timer(config.batch_delay, self._process_item, args=[key]) self.timers[key] = timer timer.start() @@ -89,17 +101,20 @@ def _process_sync(self, key: str, webhook_data: Dict): try: media_type = webhook_data.get('media_type') path_str = webhook_data.get('path') - - _log("DEBUG", f"Processing batch item: key={key}, media_type={media_type}, path={path_str}") - + instance = webhook_data.get('instance', media_type or '?') + req_id = webhook_data.get('req_id') + tag = _tag(instance, req_id) + + _log("DEBUG", f"[{tag}] Processing batch item: key={key}, media_type={media_type}, path={path_str}") + if not path_str: - _log("ERROR", f"No path found for {media_type} {key}") + _log("ERROR", f"[{tag}] No path found for {media_type} {key}") return - + path_obj = Path(path_str) if not path_obj.exists(): - _log("ERROR", f"BATCH PROCESSING FAILED: Path does not exist: {path_obj}") - _log("ERROR", f"This indicates a path mapping issue - webhook rejected to prevent wrong processing") + _log("ERROR", f"[{tag}] BATCH PROCESSING FAILED: Path does not exist: {path_obj}") + _log("ERROR", f"[{tag}] This indicates a path mapping issue - webhook rejected to prevent wrong processing") return # Validate IMDb ID for movies — only reject if a conflicting ID is found. @@ -112,14 +127,14 @@ def _process_sync(self, key: str, webhook_data: Dict): if detected_imdb: # An ID was found — check it matches if detected_imdb == expected_imdb or detected_imdb.replace('tt', '') == expected_imdb.replace('tt', ''): - _log("DEBUG", f"Batch validation passed: IMDb {expected_imdb} confirmed in folder name") + _log("DEBUG", f"[{tag}] Batch validation passed: IMDb {expected_imdb} confirmed in folder name") else: - _log("ERROR", f"BATCH VALIDATION FAILED: folder contains {detected_imdb} but webhook expected {expected_imdb} in {path_str}") - _log("ERROR", f"This prevents processing the wrong movie due to a mismatched batch entry") + _log("ERROR", f"[{tag}] BATCH VALIDATION FAILED: folder contains {detected_imdb} but webhook expected {expected_imdb} in {path_str}") + _log("ERROR", f"[{tag}] This prevents processing the wrong movie due to a mismatched batch entry") return else: # No IMDb ID in folder/file names — standard naming, trust the webhook - _log("DEBUG", f"Batch validation: no IMDb in folder name for {path_str}, trusting webhook ID {expected_imdb}") + _log("DEBUG", f"[{tag}] Batch validation: no IMDb in folder name for {path_str}, trusting webhook ID {expected_imdb}") # Validate IMDb ID for TV shows — same logic: conflict = reject, absent = proceed. if media_type == 'tv': @@ -128,72 +143,72 @@ def _process_sync(self, key: str, webhook_data: Dict): detected_imdb = parse_imdb_from_path(path_obj) if detected_imdb: if detected_imdb == expected_imdb or detected_imdb.replace('tt', '') == expected_imdb.replace('tt', ''): - _log("DEBUG", f"TV batch validation passed: IMDb {expected_imdb} confirmed in folder name") + _log("DEBUG", f"[{tag}] TV batch validation passed: IMDb {expected_imdb} confirmed in folder name") else: - _log("ERROR", f"BATCH VALIDATION FAILED: folder contains {detected_imdb} but webhook expected {expected_imdb} in TV {path_str}") - _log("ERROR", f"This prevents processing the wrong series due to a mismatched batch entry") + _log("ERROR", f"[{tag}] BATCH VALIDATION FAILED: folder contains {detected_imdb} but webhook expected {expected_imdb} in TV {path_str}") + _log("ERROR", f"[{tag}] This prevents processing the wrong series due to a mismatched batch entry") return else: - _log("DEBUG", f"TV batch validation: no IMDb in folder name for {path_str}, trusting webhook ID {expected_imdb}") - + _log("DEBUG", f"[{tag}] TV batch validation: no IMDb in folder name for {path_str}, trusting webhook ID {expected_imdb}") + if not self.tv_processor: - _log("ERROR", "TV processor not available") + _log("ERROR", f"[{tag}] TV processor not available") return - - # Check processing mode for TV webhooks + processing_mode = webhook_data.get('processing_mode', config.tv_webhook_processing_mode) episodes_data = webhook_data.get('episodes', []) - + if processing_mode == 'targeted' and episodes_data: - _log("INFO", f"Using targeted episode processing for {len(episodes_data)} episodes") - - # Handle sequential processing for bulk downloads + _log("INFO", f"[{tag}] Using targeted episode processing for {len(episodes_data)} episodes") if len(episodes_data) > 1 and config.sequential_delay > 0: - _log("INFO", f"Processing {len(episodes_data)} episodes sequentially with {config.sequential_delay}s delay") - self._process_episodes_sequentially(path_obj, episodes_data) + _log("INFO", f"[{tag}] Processing {len(episodes_data)} episodes sequentially with {config.sequential_delay}s delay") + self._process_episodes_sequentially(path_obj, episodes_data, imdb_id=expected_imdb, instance=instance, req_id=req_id) else: - self.tv_processor.process_webhook_episodes(path_obj, episodes_data, imdb_id=expected_imdb) + self.tv_processor.process_webhook_episodes(path_obj, episodes_data, imdb_id=expected_imdb, instance=instance) else: - _log("INFO", f"Using series processing mode (fallback or configured)") - self.tv_processor.process_series(path_obj, imdb_id=expected_imdb) - + _log("INFO", f"[{tag}] Using series processing mode (fallback or configured)") + self.tv_processor.process_series(path_obj, imdb_id=expected_imdb, instance=instance) + elif media_type == 'movie': if not self.movie_processor: - _log("ERROR", "Movie processor not available") + _log("ERROR", f"[{tag}] Movie processor not available") return - - self.movie_processor.process_movie(path_obj, webhook_mode=True, imdb_id=expected_imdb) + + self.movie_processor.process_movie(path_obj, webhook_mode=True, imdb_id=expected_imdb, instance=instance) else: - _log("ERROR", f"Unknown media type: {media_type}") - + _log("ERROR", f"[{tag}] Unknown media type: {media_type}") + except Exception as e: - _log("ERROR", f"Error processing {media_type} {key}: {e}") + _log("ERROR", f"[{_tag(locals().get('instance', '?'), locals().get('req_id'))}] Error processing {media_type} {key}: {e}") finally: with self.lock: self.processing.discard(key) - - def _process_episodes_sequentially(self, path_obj: Path, episodes_data: list): - """Process episodes one by one with delays to avoid API spam""" + + def _process_episodes_sequentially(self, path_obj: Path, episodes_data: list, imdb_id: str = None, instance: str = 'sonarr', req_id: str = None): + """Process episodes one by one with delays to avoid Sonarr API spam. + + imdb_id is the ID the batch already validated (webhook-provided, + or confirmed against the folder name) — pass it through rather than + letting process_webhook_episodes() re-derive it from the path. + That fallback only works for ID-tagged folder names; a normal + "Gunsmoke" folder with no embedded IMDb tag has nothing to parse, + so every episode in the batch would fail outright without this. + """ + tag = _tag(instance, req_id) total_episodes = len(episodes_data) for i, episode in enumerate(episodes_data, 1): try: season = episode.get('seasonNumber', '?') episode_num = episode.get('episodeNumber', '?') - _log("INFO", f"Processing episode {i}/{total_episodes}: S{season:02d}E{episode_num:02d}") - - # Process single episode - self.tv_processor.process_webhook_episodes(path_obj, [episode]) - - # Add delay between episodes (except for the last one) + _log("INFO", f"[{tag}] Processing episode {i}/{total_episodes}: S{season:02d}E{episode_num:02d}") + self.tv_processor.process_webhook_episodes(path_obj, [episode], imdb_id=imdb_id, instance=instance) if i < total_episodes and config.sequential_delay > 0: - _log("INFO", f"Waiting {config.sequential_delay}s before next episode...") + _log("INFO", f"[{tag}] Waiting {config.sequential_delay}s before next episode...") time.sleep(config.sequential_delay) - except Exception as e: - _log("ERROR", f"Error processing episode {i}/{total_episodes}: {e}") - # Continue with next episode even if one fails - - _log("INFO", f"Completed sequential processing of {total_episodes} episodes") + _log("ERROR", f"[{tag}] Error processing episode {i}/{total_episodes}: {e}") + + _log("INFO", f"[{tag}] Completed sequential processing of {total_episodes} episodes") def get_status(self) -> Dict: """Get batch queue status"""