Text alignment is broken

[scalessec]

As mention in #53, if the title or message is shorter than the width of the wrapper view, it does not appear to be centered.

[shidelinFYH]

I think a method just change UIView+Toast.m line 237 expectedSizeTitle = CGSizeMake(MAX(maxSizeTitle.width, expectedSizeTitle.width), MIN(maxSizeTitle.height, expectedSizeTitle.height)); but i don't know whether it has a bad effect, you can try it.

Hi, has this been fixed? I've integrated toast using Pods, and title alignment does not seem to do anything. I've tried left, right and centre.

[funnel20]

I have solved this issue in version 4.0.0 in:
- (UIView *)toastViewForMessage:(NSString *)message title:(NSString *)title image:(UIImage *)image style:(CSToastStyle *)style;

The details of the change are in PR #118.

Example

I used the Example project to test the changes for DEMO button Make toast with an image.
I modified the test code in tableView;didSelectRowAtIndexPath: to:

        // Customise the Toast via a style:
        CSToastStyle *style = [[CSToastStyle alloc] initWithDefaultStyle];
        style.titleAlignment = NSTextAlignmentCenter;
        style.messageAlignment = NSTextAlignmentLeft;
        style.horizontalPadding = 10;
        style.maxWidthPercentage = 0.82;
        
        // Make toast with a title
        [self.navigationController.view makeToast:@"This is a piece of toast with a title"
                                         duration:20.0
                                         position:CSToastPositionTop
                                            title:@"Toast Title"
                                            image:nil
                                            style:style
                                       completion:nil];

Current situation

When running this in 4.0.0, despite setting style.titleAlignment = NSTextAlignmentCenter the title is not centred, but left aligned:

Solution

After my code fix, the title is centred correctly:

Bonus: this fixes more

My fix also solves a padding issue in version 4.0.0.
When changing style.horizontalPadding to 70 in the sample code from above, the wrapper clips over the display edges:

It definitely fails to comply to style.maxWidthPercentage. It should resize the title and message labels for the larger padding. Same sample code with my fix:

Validation

Here are examples of other settings for style.titleAlignment and style.messageAlignment:

With an image, both title and message right aligned and padding set to 30:

[funnel20]

@scalessec Hi, any reaction would be appreciated.

[funnel20]

@scalessec Dear Charles, not only didn't you provide any reaction to my proposed solution or pull request, you also totally neglected my contribution when you updated your repo to version 4.1.x.
The bottom line is that this issue is still present in your code after 6 years, and other users are forced to create their own custom fork and keep that in line with your changes.

Can you tell me what would be required to get this resolution in an official release?

[silje7]

https://github.com/funstory-ai/BabelDOC/actions/runs/13233092772