Skip to content

Extractor function does not use user specified parameters #39

@abahle

Description

@abahle

Hey, Im not sure if you guys are aware but it seems the extractor function effectively throws out the user specified config and gets defaults. After a long time of trying new parameters to no effect I finally looked at the code and saw this

function output = extractor(M, config)
% Wrapper for EXTRACT for processing large movies

%This warning is not required thanks to Hakan's implementation of the preprocessing module.
%dispfun('Warning: If the input movie is in dfof form, please make sure to add 1 to the whole movie before running EXTRACT. \n',1)


% Get start time
start_time = posixtime(datetime);
io_time = 0;

ABS_TOL = 1e-6;
SIGNAL_LOWER_THRESHOLD = 1e-6;
PARTITION_SIDE_LEN = 250;

% Update config with defaults
**config = get_defaults(config);**

Just letting you know since I doubt this is what you want. I would also draw your attention to the fact that many of the default values talked about in your readme deviate from what is actually produced by get_defaults

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentation

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions