Skip to content

Commit 96d14b4

Browse files
committed
Using physical_keycode instead of keycode for OS independence
1 parent b6c12f2 commit 96d14b4

2 files changed

Lines changed: 20 additions & 19 deletions

File tree

addons/scene_builder/scene_builder_commands.gd

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,15 @@ enum SceneCommands
2929
}
3030

3131
func _unhandled_input(event: InputEvent):
32+
3233
if config.disable_hotkeys:
3334
return
3435

3536
if event is InputEventKey:
3637
if event.is_pressed() and !event.is_echo():
37-
3838
if event.alt_pressed:
39-
match event.keycode:
39+
40+
match event.physical_keycode:
4041
config.alphabetize_nodes:
4142
alphabetize_nodes()
4243
config.change_places:
@@ -69,9 +70,9 @@ func _unhandled_input(event: InputEvent):
6970
temporary_debug()
7071

7172
elif event.ctrl_pressed:
72-
if event.keycode == KEY_RIGHT:
73+
if event.physical_keycode == KEY_RIGHT:
7374
select_children()
74-
elif event.keycode == KEY_LEFT:
75+
elif event.physical_keycode == KEY_LEFT:
7576
select_parents()
7677

7778
func _enter_tree():

addons/scene_builder/scene_builder_dock.gd

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -406,7 +406,7 @@ func forward_3d_gui_input(_camera: Camera3D, event: InputEvent) -> AfterGUIInput
406406

407407
if event.shift_pressed:
408408

409-
if event.keycode == KEY_1:
409+
if event.physical_keycode == KEY_1:
410410

411411
if is_transform_mode_enabled():
412412
if current_transform_mode == TransformMode.POSITION_X:
@@ -417,7 +417,7 @@ func forward_3d_gui_input(_camera: Camera3D, event: InputEvent) -> AfterGUIInput
417417
else:
418418
start_transform_mode(TransformMode.POSITION_X)
419419

420-
elif event.keycode == KEY_2:
420+
elif event.physical_keycode == KEY_2:
421421
if is_transform_mode_enabled():
422422
if current_transform_mode == TransformMode.POSITION_Y:
423423
end_transform_mode()
@@ -427,7 +427,7 @@ func forward_3d_gui_input(_camera: Camera3D, event: InputEvent) -> AfterGUIInput
427427
else:
428428
start_transform_mode(TransformMode.POSITION_Y)
429429

430-
elif event.keycode == KEY_3:
430+
elif event.physical_keycode == KEY_3:
431431
if is_transform_mode_enabled():
432432
if current_transform_mode == TransformMode.POSITION_Z:
433433
end_transform_mode()
@@ -439,7 +439,7 @@ func forward_3d_gui_input(_camera: Camera3D, event: InputEvent) -> AfterGUIInput
439439

440440
else:
441441

442-
if event.keycode == KEY_1:
442+
if event.physical_keycode == KEY_1:
443443
if is_transform_mode_enabled():
444444
if current_transform_mode == TransformMode.ROTATION_X:
445445
end_transform_mode()
@@ -449,7 +449,7 @@ func forward_3d_gui_input(_camera: Camera3D, event: InputEvent) -> AfterGUIInput
449449
else:
450450
start_transform_mode(TransformMode.ROTATION_X)
451451

452-
elif event.keycode == KEY_2:
452+
elif event.physical_keycode == KEY_2:
453453
if is_transform_mode_enabled():
454454
if current_transform_mode == TransformMode.ROTATION_Y:
455455
end_transform_mode()
@@ -459,7 +459,7 @@ func forward_3d_gui_input(_camera: Camera3D, event: InputEvent) -> AfterGUIInput
459459
else:
460460
start_transform_mode(TransformMode.ROTATION_Y)
461461

462-
elif event.keycode == KEY_3:
462+
elif event.physical_keycode == KEY_3:
463463
if is_transform_mode_enabled():
464464
if current_transform_mode == TransformMode.ROTATION_Z:
465465
end_transform_mode()
@@ -469,7 +469,7 @@ func forward_3d_gui_input(_camera: Camera3D, event: InputEvent) -> AfterGUIInput
469469
else:
470470
start_transform_mode(TransformMode.ROTATION_Z)
471471

472-
elif event.keycode == KEY_4:
472+
elif event.physical_keycode == KEY_4:
473473
if is_transform_mode_enabled():
474474
if current_transform_mode == TransformMode.SCALE:
475475
end_transform_mode()
@@ -479,32 +479,32 @@ func forward_3d_gui_input(_camera: Camera3D, event: InputEvent) -> AfterGUIInput
479479
else:
480480
start_transform_mode(TransformMode.SCALE)
481481

482-
elif event.keycode == KEY_5:
482+
elif event.physical_keycode == KEY_5:
483483
if is_transform_mode_enabled():
484484
end_transform_mode()
485485
reroll_preview_instance_transform()
486486

487-
if event.keycode == KEY_ESCAPE:
487+
if event.physical_keycode == KEY_ESCAPE:
488488
end_placement_mode()
489489

490490
if placement_mode_enabled:
491491

492492
if event.shift_pressed:
493-
if event.keycode == KEY_LEFT:
493+
if event.physical_keycode == KEY_LEFT:
494494
select_previous_item()
495-
elif event.keycode == KEY_RIGHT:
495+
elif event.physical_keycode == KEY_RIGHT:
496496
select_next_item()
497497

498498
if event.alt_pressed:
499-
if event.keycode == KEY_LEFT:
499+
if event.physical_keycode == KEY_LEFT:
500500
select_previous_collection()
501-
elif event.keycode == KEY_RIGHT:
501+
elif event.physical_keycode == KEY_RIGHT:
502502
select_next_collection()
503503

504-
elif event.keycode == KEY_BRACKETLEFT:
504+
elif event.physical_keycode == KEY_BRACKETLEFT:
505505
preview_instance.rotate_y(deg_to_rad(-90))
506506

507-
elif event.keycode == KEY_BRACKETRIGHT:
507+
elif event.physical_keycode == KEY_BRACKETRIGHT:
508508
preview_instance.rotate_y(deg_to_rad(90))
509509

510510
return EditorPlugin.AFTER_GUI_INPUT_PASS

0 commit comments

Comments
 (0)