From 7afa35698bba18e78901c7df6502e89ce4d94c25 Mon Sep 17 00:00:00 2001 From: pablo-gar Date: Wed, 27 Nov 2024 17:30:10 -0800 Subject: [PATCH 1/2] fix empty filter bug --- src/genomic_features/ensembl/ensembldb.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/genomic_features/ensembl/ensembldb.py b/src/genomic_features/ensembl/ensembldb.py index 82f420d..3d61ac7 100644 --- a/src/genomic_features/ensembl/ensembldb.py +++ b/src/genomic_features/ensembl/ensembldb.py @@ -309,7 +309,12 @@ def _build_query( else: query = self.db.table(table) # add filter - query = query.filter(filter.convert()).select(cols).order_by(cols) + + filter = filter.convert() + if filter is not None: + query = query.filter(filter) + + query = query.select(cols).order_by(cols) return query def _join_query( From 245cd1cd9b6d8452d7b915b504c6570ba2c3008d Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Thu, 28 Nov 2024 01:32:00 +0000 Subject: [PATCH 2/2] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- src/genomic_features/ensembl/ensembldb.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/genomic_features/ensembl/ensembldb.py b/src/genomic_features/ensembl/ensembldb.py index 3d61ac7..9ededfd 100644 --- a/src/genomic_features/ensembl/ensembldb.py +++ b/src/genomic_features/ensembl/ensembldb.py @@ -309,11 +309,11 @@ def _build_query( else: query = self.db.table(table) # add filter - + filter = filter.convert() if filter is not None: query = query.filter(filter) - + query = query.select(cols).order_by(cols) return query