Skip to content

Remove unnecessary semi-colon #347#512

Open
dezhanglee wants to merge 1 commit into
se-edu:masterfrom
dezhanglee:issue-#347
Open

Remove unnecessary semi-colon #347#512
dezhanglee wants to merge 1 commit into
se-edu:masterfrom
dezhanglee:issue-#347

Conversation

@dezhanglee

@dezhanglee dezhanglee commented Dec 15, 2019

Copy link
Copy Markdown
Contributor

Fixes #347

This PR removes a redundant ; from the Command class.

@canihasreview

canihasreview Bot commented Dec 15, 2019

Copy link
Copy Markdown

Click here to submit a new iteration when this PR is ready for review.

See this repository's contribution guide for more information.

@canihasreview

canihasreview Bot commented Dec 15, 2019

Copy link
Copy Markdown

v1

@dezhanglee submitted v1 for review.

(📚 Archive)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level2.git refs/pr/512/1/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

@j-lum j-lum changed the title Fixes issue #347 Remove unnecessary semi-colon #347 Dec 16, 2019
@j-lum

j-lum commented Dec 16, 2019

Copy link
Copy Markdown
Member

@dezhanglee You might want to check out the contributor's guide section on commit messages.
The subject line of the commit message should be written in the correct tense. The changes made in the commit should be obvious to the reader even if they are not on github.

You can look through previously merged PRs for examples.

@dezhanglee

Copy link
Copy Markdown
Contributor Author

hi @j-lum , is my commit message ok now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

command.java: Remove unnecessary ; at the end of function

2 participants