From a7d71cdb2a7f639b1c40de0889444c6c10e1cf88 Mon Sep 17 00:00:00 2001 From: Mohammad Saddam Hossain Date: Sat, 18 Jul 2026 11:58:03 +0530 Subject: [PATCH] chore: fix stale test count, javadoc escape, and baseline gitignore guard Follow-ups from a release-readiness test run of v3.1.1: - CLAUDE.md: correct "12 test classes" to "39 test classes, 480 tests". - DriverManager: escape unescaped `&` as `&` in a javadoc
  • . - .gitignore: guard src/test/resources/baselines/*.png so a failed VisualAssert cleanup can't dirty the tree or commit throwaway images. Co-Authored-By: Claude Opus 4.8 (1M context) --- .gitignore | 10 +++++++++- CLAUDE.md | 2 +- .../java/com/seleniumboot/driver/DriverManager.java | 2 +- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/.gitignore b/.gitignore index 0dd4e1f..071443a 100644 --- a/.gitignore +++ b/.gitignore @@ -51,4 +51,12 @@ docs-site/node_modules/ docs-site/.docusaurus/ docs-site/build/ -articles/* \ No newline at end of file +articles/* + +*.log +*.env + +### Test-generated visual baselines ### +# VisualAssert tests write throwaway timestamped baseline PNGs here during runs. +# Guard against a failed cleanup dirtying the tree or committing throwaway images. +src/test/resources/baselines/*.png \ No newline at end of file diff --git a/CLAUDE.md b/CLAUDE.md index 2aad2d8..3d6f4f8 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -85,7 +85,7 @@ Classes/methods annotated `@SeleniumBootApi` are the stable public surface. Avoi ## Tests -Unit tests are in `src/test/java/com/seleniumboot/unit/` (12 test classes). They use **TestNG + Mockito**. Tests mock Selenium/browser interactions — no real browser is required to run the test suite. +Unit tests are in `src/test/java/com/seleniumboot/unit/` (39 test classes, 480 tests). They use **TestNG + Mockito**. Tests mock Selenium/browser interactions — no real browser is required to run the test suite. ## Configuration Reference diff --git a/src/main/java/com/seleniumboot/driver/DriverManager.java b/src/main/java/com/seleniumboot/driver/DriverManager.java index eeff8bb..438e426 100644 --- a/src/main/java/com/seleniumboot/driver/DriverManager.java +++ b/src/main/java/com/seleniumboot/driver/DriverManager.java @@ -14,7 +14,7 @@ * Rules: *
  • One WebDriver per thread
    • *
  • ThreadLocal ownership
    • - *
  • Framework-managed creation & destruction only
    • + *
  • Framework-managed creation & destruction only
    • *
  • Session limit is enforced with a blocking Semaphore — tests wait for a slot * rather than failing fast, preventing spurious failures under parallel load
    • */