Error handle message

[jacoobes]

In this function, we should provide an error message for developers to understand WHY plugin installation failed.

cli/src/commands/plugins.ts

Lines 96 to 103 in 90fae47

	async function download(url: string) {
	const data = await fetch(url, { method: 'GET' })
	.then((res) => res.text())
	.catch(() => null);
	if (!data) throw new Error('Download failed! Kindly contact developers');
	return data;

[jacoobes]

@KrossaNoah, hey do you want to set up a pull request? I'lll review it for you!

[KrossaNoah]

Yes, I'll prepare the pull request and let you know once it’s ready. Thank you for reviewing it!

[jacoobes]

of course!

[Peter-MJ-Parker]

@jacoobes @SrIzan10
Would this be a good error handler? Or would there be a different type error occurrence? Also, I think res.text is what we are looking for here.

async function download(url: string) {
    try {
        const res = await fetch(url, { method: 'GET' });
        if (!res.ok) {
            throw new Error(`HTTP ${res.status} - ${res.statusText}`);
        }
        return await res.text();
    } catch (err) {
        console.error(`Failed to download plugin from: ${url}`);
        console.error('Possible reasons:');
        console.error('- Network connection issue');
        console.error('- Plugin URL is invalid or the plugin was removed');
        console.error('- GitHub or CDN is temporarily unavailable');
        console.error('How to fix:');
        console.error('- Check your internet connection');
        console.error('- Verify the plugin link is correct');
        console.error('- Try again in a few minutes');
        throw new Error(`Download failed: ${(err as Error).message}`);
    }
}

Although this would look a lot cleaner with a single console.error() :

async function download(url: string) {
    try {
        const res = await fetch(url, { method: 'GET' });
        if (!res.ok) {
            throw new Error(`HTTP ${res.status} - ${res.statusText}`);
        }
        return await res.text();
    } catch (err) {
        console.error(
            `Failed to download plugin from: ${url}\n` +
            'Possible reasons:\n' +
            '- Network connection issue\n' +
            '- Plugin URL is invalid or the plugin was removed\n' +
            '- GitHub or CDN is temporarily unavailable\n' +
            'How to fix:\n' +
            '- Check your internet connection\n' +
            '- Verify the plugin link is correct\n' +
            '- Try again in a few minutes'
        );
        throw new Error(`Download failed: ${(err as Error).message}`);
    }
}