Skip to content

Commit a5902cb

Browse files
committed
feat: support sdk-aware net9 and net10 surfaces
1 parent 943e93e commit a5902cb

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

src/BitNetSharp.App/BitNetSharp.App.csproj

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,12 @@
1919

2020
<PropertyGroup>
2121
<OutputType>Exe</OutputType>
22-
<TargetFramework>net10.0</TargetFramework>
22+
<TargetFramework Condition="$([MSBuild]::VersionGreaterThanOrEquals('$(NETCoreSdkVersion)', '10.0.100')) != 'True'">net9.0</TargetFramework>
23+
<TargetFrameworks Condition="$([MSBuild]::VersionGreaterThanOrEquals('$(NETCoreSdkVersion)', '10.0.100')) == 'True'">net9.0;net10.0</TargetFrameworks>
2324
<ImplicitUsings>enable</ImplicitUsings>
2425
<Nullable>enable</Nullable>
26+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
27+
<ManagePackageVersionsCentrally>false</ManagePackageVersionsCentrally>
2528
<PackAsTool>true</PackAsTool>
2629
<ToolCommandName>bitnetsharp</ToolCommandName>
2730
</PropertyGroup>

tests/BitNetSharp.Tests/BitNetSharp.Tests.csproj

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFramework>net10.0</TargetFramework>
4+
<TargetFramework Condition="$([MSBuild]::VersionGreaterThanOrEquals('$(NETCoreSdkVersion)', '10.0.100')) != 'True'">net9.0</TargetFramework>
5+
<TargetFrameworks Condition="$([MSBuild]::VersionGreaterThanOrEquals('$(NETCoreSdkVersion)', '10.0.100')) == 'True'">net9.0;net10.0</TargetFrameworks>
56
<ImplicitUsings>enable</ImplicitUsings>
67
<Nullable>enable</Nullable>
78
<IsPackable>false</IsPackable>
9+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
10+
<ManagePackageVersionsCentrally>false</ManagePackageVersionsCentrally>
811
</PropertyGroup>
912

1013
<ItemGroup>

tests/BitNetSharp.Tests/DataGenTests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,10 @@ public void ParseDataGenCommandOptionsSupportsExtendedPromptOptions()
3232
Assert.EndsWith(Path.Combine("data", "code-review.jsonl"), options.OutputPath, StringComparison.Ordinal);
3333
Assert.Equal("qa", options.TaskType);
3434
Assert.Equal(["Use American English", "Grounded", "Diverse"], options.Constraints);
35-
Assert.Equal("/tmp/seeds.json", options.SeedsPath);
35+
Assert.Equal(Path.GetFullPath("/tmp/seeds.json"), options.SeedsPath);
3636
Assert.Contains("\"instruction\"", options.OutputSchema, StringComparison.Ordinal);
3737
Assert.Equal("/tmp/template.json", options.TemplatePath);
38-
Assert.Equal("/tmp/domain-lora.bin", options.LoraPath);
38+
Assert.Equal(Path.GetFullPath("/tmp/domain-lora.bin"), options.LoraPath);
3939
Assert.Equal(5, options.CandidateCount);
4040
Assert.Equal(0.7d, options.MinimumQualityScore);
4141
Assert.Equal(64, options.MaxOutputTokens);
@@ -100,7 +100,7 @@ public async Task DataGenCommandWritesMergedPromptAndMetadata()
100100
Assert.Contains("Review", first.Prompt, StringComparison.Ordinal);
101101
Assert.Contains("Review null handling", first.GroundingContext);
102102
Assert.Contains("Review tests", first.GroundingContext);
103-
Assert.Equal("/tmp/code-review-lora.bin", first.LoraPath);
103+
Assert.Equal(Path.GetFullPath("/tmp/code-review-lora.bin"), first.LoraPath);
104104
Assert.False(string.IsNullOrWhiteSpace(first.SeedInstruction));
105105
Assert.False(string.IsNullOrWhiteSpace(first.SeedResponse));
106106
Assert.False(string.IsNullOrWhiteSpace(first.Variation));

0 commit comments

Comments
 (0)