Skip to content
This repository was archived by the owner on Apr 9, 2021. It is now read-only.
This repository was archived by the owner on Apr 9, 2021. It is now read-only.

Unify variable annotations through codebase #29

@grossmannmartin

Description

@grossmannmartin

What is happening

Currently, there is not exactly clear, what type of variable annotation is preferred and should be used to maintain uniformity.

Several types of annotating variables can be found (placed after/before variable, type/name first)
For example

/** @var \Shopsys\FrameworkBundle\Model\Cart\Watcher\CartWatcherService $cartWatcherService */
$cartWatcherService = $this->getContainer()->get(CartWatcherService::class); 

and

$cartWatcherService = $this->getContainer()->get(CartWatcherService::class);
/* @var $cartWatcherService \Shopsys\FrameworkBundle\Model\Cart\Watcher\CartWatcherService */

Expected result

We should agree on one style and force it. Even better, to have code style check for it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions