Harden contact trust and merge workflows

Author: sidmohan0

src/app/actions/contacts.ts

@@ -82,6 +82,7 @@ export async function updateContactAction(formData: FormData) {
 export async function mergeContactsAction(formData: FormData) {
   const sourceContactId = String(formData.get("sourceContactId") ?? "");
   const targetContactId = String(formData.get("targetContactId") ?? "");
+  const confirmed = String(formData.get("confirmMerge") ?? "") === "yes";
   const returnTo = getReturnTo(formData, "/contacts");
 
   if (!sourceContactId || !targetContactId) {
@@ -93,6 +94,7 @@ export async function mergeContactsAction(formData: FormData) {
   try {
     slug = await mergeContacts({
       actorUserId: await getAuditActorUserId(),
+      confirmed,
       sourceContactId,
       targetContactId,
     });
@@ -109,6 +111,7 @@ export async function mergeContactsAction(formData: FormData) {
 
 export async function splitContactAction(formData: FormData) {
   const sourceContactId = String(formData.get("sourceContactId") ?? "");
+  const confirmed = String(formData.get("confirmSplit") ?? "") === "yes";
   const returnTo = getReturnTo(formData, "/contacts");
   const identityIds = formData
     .getAll("identityIds")
@@ -129,6 +132,7 @@ export async function splitContactAction(formData: FormData) {
     const created = await splitContact({
       actorUserId: await getAuditActorUserId(),
       company: String(formData.get("company") ?? ""),
+      confirmed,
       displayName: String(formData.get("displayName") ?? ""),
       identityIds,
       primaryEmail: String(formData.get("primaryEmail") ?? ""),

src/app/actions/reviews.ts

@@ -35,10 +35,15 @@ export async function resolveMergeReviewAction(formData: FormData) {
   ) as Partial<
     Record<"company" | "displayName" | "primaryEmail" | "title", "current" | "proposed">
   >;
+  const bulkDecision = String(formData.get("bulkDecision") ?? "");
 
   try {
     await resolveMergeReview({
       actorUserId: await getAuditActorUserId(),
+      bulkDecision:
+        bulkDecision === "current" || bulkDecision === "proposed"
+          ? bulkDecision
+          : undefined,
       decisions,
       reviewId,
     });

src/components/app/contacts/contact-workspace-view.tsx

@@ -18,6 +18,7 @@ import { Badge } from "@/components/ui/badge";
 import { Button } from "@/components/ui/button";
 import {
   getContactBySlug,
+  getContactMergeImpact,
   listContactTimeline,
   listPotentialDuplicateContacts,
 } from "@/lib/contacts";
@@ -37,6 +38,9 @@ type AvailableSequence = Awaited<
 type DuplicateCandidate = Awaited<
   ReturnType<typeof listPotentialDuplicateContacts>
 >[number];
+type MergeImpact = NonNullable<
+  Awaited<ReturnType<typeof getContactMergeImpact>>
+>;
 type Enrollment = Awaited<
   ReturnType<typeof listContactSequenceEnrollments>
 >[number];
@@ -55,6 +59,10 @@ function confidenceVariant(confidence: DuplicateCandidate["confidence"]) {
   return "outline";
 }
 
+function impactPillLabel(label: string, value: number) {
+  return `${value} ${label}`;
+}
+
 function formatDueAt(value: Date | null) {
   if (!value) {
     return "No due date";
@@ -511,7 +519,10 @@ function ContactEnrollmentsPanel(props: {
 
 function DuplicateCandidatesPanel(props: {
   contact: ContactWorkspaceContact;
-  duplicateCandidates: DuplicateCandidate[];
+  duplicateCandidates: Array<{
+    candidate: DuplicateCandidate;
+    mergeImpact: MergeImpact | null;
+  }>;
 }) {
   return (
     <DashboardPanel>
@@ -526,7 +537,7 @@ function DuplicateCandidatesPanel(props: {
             No duplicate candidates detected for this contact right now.
           </p>
         ) : (
-          props.duplicateCandidates.map((candidate) => (
+          props.duplicateCandidates.map(({ candidate, mergeImpact }) => (
             <div
               key={candidate.id}
               className="rounded-2xl border border-border/85 bg-background/75 px-4 py-4"
@@ -556,6 +567,25 @@ function DuplicateCandidatesPanel(props: {
                   ))}
                 </div>
               </div>
+              {mergeImpact ? (
+                <div className="mt-3 flex flex-wrap gap-2">
+                  <Badge variant="secondary">
+                    {impactPillLabel("identities", mergeImpact.source.impact.identities)}
+                  </Badge>
+                  <Badge variant="secondary">
+                    {impactPillLabel("sources", mergeImpact.source.impact.sources)}
+                  </Badge>
+                  <Badge variant="secondary">
+                    {impactPillLabel("tasks", mergeImpact.source.impact.tasks)}
+                  </Badge>
+                  <Badge variant="secondary">
+                    {impactPillLabel(
+                      "enrollments",
+                      mergeImpact.source.impact.enrollments,
+                    )}
+                  </Badge>
+                </div>
+              ) : null}
               <div className="mt-3 flex flex-wrap gap-3">
                 <form action={mergeContactsAction}>
                   <input
@@ -573,6 +603,10 @@ function DuplicateCandidatesPanel(props: {
                     name="targetContactId"
                     value={props.contact.id}
                   />
+                  <label className="mb-3 flex items-center gap-2 text-sm text-muted-foreground">
+                    <input type="checkbox" name="confirmMerge" value="yes" />
+                    Confirm merge and move linked history into this contact
+                  </label>
                   <Button type="submit" variant="outline">
                     Merge into this contact
                   </Button>
@@ -873,6 +907,15 @@ function ContactSplitPanel(props: { contact: ContactWorkspaceContact }) {
           </div>
         </div>
 
+        <p className="text-sm text-muted-foreground">
+          Safety rule: the source contact must keep at least one identity or source
+          anchor after the split.
+        </p>
+
+        <label className="flex items-center gap-2 text-sm text-muted-foreground">
+          <input type="checkbox" name="confirmSplit" value="yes" />
+          Confirm split and move the selected identities and sources
+        </label>
         <Button type="submit" variant="outline">
           Create split contact
         </Button>
@@ -939,6 +982,15 @@ export async function ContactWorkspaceView(props: {
       listReplySignalsForContact(contact.id),
       listContactTimeline(contact.id),
     ]);
+  const duplicateCandidatesWithImpact = await Promise.all(
+    duplicateCandidates.map(async (candidate) => ({
+      candidate,
+      mergeImpact: await getContactMergeImpact({
+        sourceContactId: candidate.id,
+        targetContactId: contact.id,
+      }),
+    })),
+  );
 
   return (
     <div className="space-y-6">
@@ -961,10 +1013,10 @@ export async function ContactWorkspaceView(props: {
             contactSlug={contact.slug}
             enrollments={enrollments}
           />
-          <DuplicateCandidatesPanel
-            contact={contact}
-            duplicateCandidates={duplicateCandidates}
-          />
+        <DuplicateCandidatesPanel
+          contact={contact}
+          duplicateCandidates={duplicateCandidatesWithImpact}
+        />
           <ReplyHistoryPanel replyHistory={replyHistory} />
           <MergeReviewsPanel contact={contact} />
           <FollowUpTasksPanel contact={contact} />

src/components/app/reviews/reviews-page-view.tsx

@@ -321,6 +321,9 @@ function MergeReviewsPanel(props: {
                   <p className="text-sm text-muted-foreground">
                     {review.contact?.primaryEmail ?? "No primary email"}
                   </p>
+                  <p className="text-sm text-muted-foreground">
+                    {review.sourceLabel ?? review.sourceRef}
+                  </p>
                 </div>
                 <p className="text-sm text-muted-foreground">
                   Last seen {review.lastSeenAt.toLocaleString()}
@@ -383,6 +386,22 @@ function MergeReviewsPanel(props: {
 
                 <div className="flex flex-wrap gap-3">
                   <Button type="submit">Resolve review</Button>
+                  <Button
+                    type="submit"
+                    name="bulkDecision"
+                    value="proposed"
+                    variant="outline"
+                  >
+                    Use proposed for all
+                  </Button>
+                  <Button
+                    type="submit"
+                    name="bulkDecision"
+                    value="current"
+                    variant="outline"
+                  >
+                    Keep current for all
+                  </Button>
                   {review.contact?.slug ? (
                     <Button
                       render={<Link href={`/contacts/${review.contact.slug}`} />}