From 2595039821098aa80d106ab6b4e23641b30e228a Mon Sep 17 00:00:00 2001 From: megahirt Date: Thu, 30 Apr 2026 20:25:15 -0400 Subject: [PATCH] fix: self-assignment no-ops in PARUSERSYNC merge and mutable default arg in score() --- python/lib/ptxprint/usfmerge.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/python/lib/ptxprint/usfmerge.py b/python/lib/ptxprint/usfmerge.py index c82a69105..81eca92e7 100755 --- a/python/lib/ptxprint/usfmerge.py +++ b/python/lib/ptxprint/usfmerge.py @@ -585,8 +585,8 @@ def reorder(self): if bi is None: bi=i-1 logger.log(7, f"Merge.5b: {self.acc[bi].position} , {self.acc[i].position}?") - self.acc[i].verse = self.acc[i].verse - self.acc[i].pnum = self.acc[i].pnum + self.acc[i].verse = self.acc[bi].verse + self.acc[i].pnum = self.acc[bi].pnum self.acc[i].insert(0,self.acc[bi][0]) #self.acc[bi].syncp = self.acc[i].syncp #self.acc[bi].type = ChunkType.USERSYNC @@ -651,7 +651,9 @@ def reorder(self): else: logger.log(7, f"r: {i}, '-//-', {self.acc[i].type=}, {self.acc[i]=}") - def score(self,results={}): + def score(self, results=None): + if results is None: + results = {} """Calculate the scores for each chunk, returning an array of non-zero scores (potential break points) If the results parameter is given, then the return value is a summation """