From f0752d42e5ecf1698c8ecd68e83881c3237fcfe1 Mon Sep 17 00:00:00 2001 From: Bunyanuch Saengnet Date: Mon, 2 Sep 2019 17:50:31 +0000 Subject: [PATCH 1/7] update-renderer is now suspending, when bumping version using npm issue #79 --- source/index.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/source/index.js b/source/index.js index d6cc80c5..2befc718 100644 --- a/source/index.js +++ b/source/index.js @@ -171,7 +171,8 @@ module.exports = async (input = 'patch', options) => { { title: 'Bumping version using npm', enabled: () => options.yarn === false, - task: () => exec('npm', ['version', input]) + task: () => exec('npm', ['version', input]), + options: {suspendUpdateRenderer: true} } ]); From d5f6e15d6493663954d16b6fe7ab00134b133650 Mon Sep 17 00:00:00 2001 From: Sindre Sorhus Date: Fri, 13 Sep 2019 16:32:18 +0700 Subject: [PATCH 2/7] Update index.js --- source/index.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/source/index.js b/source/index.js index 2befc718..122ee467 100644 --- a/source/index.js +++ b/source/index.js @@ -172,7 +172,9 @@ module.exports = async (input = 'patch', options) => { title: 'Bumping version using npm', enabled: () => options.yarn === false, task: () => exec('npm', ['version', input]), - options: {suspendUpdateRenderer: true} + options: { + suspendUpdateRenderer: true + } } ]); From 79a15562a35e8383ca0dfa5306ae20ee879a8dd0 Mon Sep 17 00:00:00 2001 From: Bunyanuch Saengnet Date: Sat, 14 Sep 2019 07:47:24 +0000 Subject: [PATCH 3/7] added suspending flag for task Bumping version using yarn --- source/index.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/source/index.js b/source/index.js index 2befc718..48fd072e 100644 --- a/source/index.js +++ b/source/index.js @@ -166,7 +166,8 @@ module.exports = async (input = 'patch', options) => { { title: 'Bumping version using Yarn', enabled: () => options.yarn === true, - task: () => exec('yarn', ['version', '--new-version', input]) + task: () => exec('yarn', ['version', '--new-version', input]), + options: {suspendUpdateRenderer: true} }, { title: 'Bumping version using npm', From d6ea94ea8b31259c1e7ff371a7485d4007d9b592 Mon Sep 17 00:00:00 2001 From: Bunyanuch Saengnet Date: Sat, 14 Sep 2019 07:50:53 +0000 Subject: [PATCH 4/7] fixed coding-style --- source/index.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/source/index.js b/source/index.js index 35099836..773810c6 100644 --- a/source/index.js +++ b/source/index.js @@ -167,7 +167,9 @@ module.exports = async (input = 'patch', options) => { title: 'Bumping version using Yarn', enabled: () => options.yarn === true, task: () => exec('yarn', ['version', '--new-version', input]), - options: {suspendUpdateRenderer: true} + options: { + suspendUpdateRenderer: true + } }, { title: 'Bumping version using npm', From 1b78cc6e53b094c58833301c56eeab4cb3d1038a Mon Sep 17 00:00:00 2001 From: Sindre Sorhus Date: Sat, 14 Sep 2019 14:58:50 +0700 Subject: [PATCH 5/7] Update index.js --- source/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/index.js b/source/index.js index 773810c6..af3f8f95 100644 --- a/source/index.js +++ b/source/index.js @@ -167,7 +167,7 @@ module.exports = async (input = 'patch', options) => { title: 'Bumping version using Yarn', enabled: () => options.yarn === true, task: () => exec('yarn', ['version', '--new-version', input]), - options: { + options: { suspendUpdateRenderer: true } }, From b8cc87885ea36fb56f442c50279a9839892cf166 Mon Sep 17 00:00:00 2001 From: Bunyanuch Saengnet Date: Sat, 14 Sep 2019 07:59:01 +0000 Subject: [PATCH 6/7] fixed indentation in line 174 --- source/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/index.js b/source/index.js index 773810c6..af3f8f95 100644 --- a/source/index.js +++ b/source/index.js @@ -167,7 +167,7 @@ module.exports = async (input = 'patch', options) => { title: 'Bumping version using Yarn', enabled: () => options.yarn === true, task: () => exec('yarn', ['version', '--new-version', input]), - options: { + options: { suspendUpdateRenderer: true } }, From 2224b72175a272ac009fb5eeb0b8b623c5c79547 Mon Sep 17 00:00:00 2001 From: Bunyanuch Saengnet Date: Sat, 18 Jul 2020 07:04:38 +0000 Subject: [PATCH 7/7] readme: mention GPG password prompts --- readme.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/readme.md b/readme.md index 4c2d2330..f9151ec0 100644 --- a/readme.md +++ b/readme.md @@ -183,6 +183,8 @@ Or set the [`version-sign-git-tag`](https://yarnpkg.com/lang/en/docs/cli/version $ yarn config set version-sign-git-tag true ``` +`np` supports all kinds of GPG password prompts (console or GUI prompt). + ### Private packages