`skip export` fails to include SkipKeychain.aar

[piercifani]

Given this (simplified) package structure:

Foo -> Bar -> SkipKeychain

When you do skip export Foo, the output folder doesn't contain SkipKeychain and will fail at runtime when executing the Android app.

[marcprux]

Note that in this scenario, Foo uses the skipstone plugin, but Bar does not. So from Skip's perspective, SkipKeychain is not reachable, and so the generated Gradle project for Foo will not have a reference to SkipKeychain. Thus, the bridged Kotlin classes are not included in the output of the Foo build.

[piercifani]

This morning I added SkipKeychain to the main app target, but behind a TargetDependencyCondition.when(platforms: [.android]) and skip export did not generate the .aar for the Keychain

That's when I realized i'm doing the same thing here:

https://github.com/theleftbit/BSWFoundation/pull/156/files#diff-f913940c58e8744a2af1c68b909bb6383e49007e6c5a12fb03104a9006ae677eR37

Perhaps this is the culprit? And if so, why would SkipKeychain would be needed to be included when building for Apple platforms?

[marcprux]

Perhaps this is the culprit?

Yes, that is likely. The gradle project graph that the Skip plugin builds is based on the dependency graph of the Swift Package Manager project, which is evaluated for the host target.

If you remove that condition check, do you find that skip export results in SkipKeychain being included in the output?

[piercifani]

which is evaluated for the host target

Why not the target platform instead of the host platform?

[marcprux]

Why not the target platform instead of the host platform?

That's just how the Swift build plugin API works. We can't change it, but we might be able to figure something else out. I'll ponder it.