fix(test): remove unnecessary app.Before() calls that overwrite test DB config

TestShell_BeforeNode and TestShell_RunNode_WithBeforeNode called
app.Before(c) before BeforeNode(c). The Before hook unconditionally
creates a fresh config with the default pgx driver, overwriting the
test's txdb-wrapped config. This caused BeforeNode to open real DB
connections that leaked state between tests, exhausting the
connection pool.

BeforeNode only needs Config and Logger — both already set by the
test. The app.Before() call was unnecessary. Other tests in the same
file (lines 258, 342, 420) correctly call BeforeNode directly
without app.Before().

Fixes: CORE-2388

Author: Fletch153

core/cmd/shell_local_test.go

@@ -543,15 +543,7 @@ func TestShell_BeforeNode(t *testing.T) {
 
 			c := cli.NewContext(nil, set, nil)
 
-			// Create full CLI app and run the Before hook first
-			app := cmd.NewApp(&shell)
-			err := app.Before(c)
-			if err != nil && test.wantUnlocked {
-				t.Fatalf("CLI Before hook failed: %v", err)
-			}
-
-			// Run before hook to initialize components with authentication
-			err = shell.BeforeNode(c)
+			err := shell.BeforeNode(c)
 
 			if test.wantUnlocked {
 				require.NoError(t, err)
@@ -641,12 +633,7 @@ func TestShell_RunNode_WithBeforeNode(t *testing.T) {
 
 			c := cli.NewContext(nil, set, nil)
 
-			// First initialize components (this includes authentication)
-			cliApp := cmd.NewApp(&shell)
-			err := cliApp.Before(c)
-			require.NoError(t, err)
-
-			err = shell.BeforeNode(c)
+			err := shell.BeforeNode(c)
 
 			if test.expectStart {
 				require.NoError(t, err, "BeforeNode should succeed")