Skip to content

Preview omitting leading $ of PHP variables and arguments #97

@HalibutGitWiz

Description

@HalibutGitWiz

Did you check the Readme and existing issues?

  • I have read the Readme of inc-rename.nvim
  • I have updated the plugin to the latest version before submitting this issue
  • I have searched the existing issues of inc-rename.nvim

Neovim version (output of nvim -v)

NVIM v0.12.1

Operating system / version

EndeavourOS (rolling release)

Output of :LspInfo

This command does not exist in my setup (LazyVim)

Describe the bug

First of all, thanks for making this really nice plugin.

I noticed a small annoyance when working with PHP files (and paid version of Intelephense LSP server). While typing the new name, the preview omits the starting $ of all PHP variables and function/method arguments.

The result is correct in the end (probably because Intelephense is performing the actual code modification), but it took me some time to realize that. I almost ditched this plugin because I thought I had to add the $ manually every time ! 😲

Steps to reproduce

Image

Expected behavior

Same as above except during preview, the argument name should be $new and not new

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions