CODE-QUALITY: Assignment in if condition - commands.c:1348

[smooge]

Bug Type

CODE-QUALITY - Assignment in conditional expression

Severity

Low

Phase Discovered

Phase 4: Warning Elimination - commands.c modernization

Files Affected

• commands.c:1348

Description

Line 1348 uses assignment within if condition: if((i = get_country())==(-1))
This relies on side effects and reduces code readability.

Code Location

commands.c:1348

Impact Assessment

• No functional impact - code works correctly
• Readability concern - assignment mixed with condition test
• Maintenance risk - harder to debug and understand

Recommended Resolution

Separate assignment from conditional test:

// Current (problematic):
if((i = get_country())==(-1)) {

// Recommended:
i = get_country();
if(i == (-1)) {

Session History

• Discovered during Phase 4 warning elimination session (commands.c)
• Similar patterns found in Issues CODE-QUALITY: Assignment in if condition - move.c:143 #3, CODE-QUALITY: Assignment in if condition - commands.c:447 #4, CODE-QUALITY: Assignment in if condition - commands.c:1295 #5
• Noted for post-modernization cleanup