diff --git a/package.json b/package.json index b9ea218..7881ec2 100644 --- a/package.json +++ b/package.json @@ -41,7 +41,7 @@ "fmt": "oxfmt", "fmt:check": "oxfmt --check", "typecheck": "bun run build:framework && bun run --filter '@bb-kit/*' --parallel typecheck && bun run --filter '@smsunarto/bb-plugin-*' --parallel typecheck", - "test": "bun test scripts/*.test.ts && bun run --filter '@bb-kit/*' --parallel test && bun run --filter '@smsunarto/bb-plugin-*' --parallel test", + "test": "bun run build:framework && bun test scripts/*.test.ts && bun run --filter '@bb-kit/*' --parallel test && bun run --filter '@smsunarto/bb-plugin-*' --parallel test", "compatibility:inspect": "bun packages/bb-kit-cli/src/cli.ts compatibility inspect", "compatibility:check": "bun packages/bb-kit-cli/src/cli.ts compatibility check", "compatibility:upgrade": "bun packages/bb-kit-cli/src/cli.ts compatibility upgrade", diff --git a/plugins/agent-proxy/assets/icon.svg b/plugins/agent-proxy/assets/icon.svg index 5a7d93b..e44c0f9 100644 --- a/plugins/agent-proxy/assets/icon.svg +++ b/plugins/agent-proxy/assets/icon.svg @@ -1,4 +1,4 @@ - + diff --git a/plugins/agentation/assets/icon.svg b/plugins/agentation/assets/icon.svg index 55cd6ff..20cde19 100644 --- a/plugins/agentation/assets/icon.svg +++ b/plugins/agentation/assets/icon.svg @@ -1,4 +1,4 @@ - + diff --git a/plugins/amp/assets/icon.svg b/plugins/amp/assets/icon.svg index f21ad92..3b2780f 100644 --- a/plugins/amp/assets/icon.svg +++ b/plugins/amp/assets/icon.svg @@ -1,4 +1,4 @@ - + diff --git a/plugins/dotfiles/assets/icon.svg b/plugins/dotfiles/assets/icon.svg index 08ee3f1..b706d5c 100644 --- a/plugins/dotfiles/assets/icon.svg +++ b/plugins/dotfiles/assets/icon.svg @@ -1,4 +1,4 @@ - + diff --git a/plugins/gh-stack/assets/icon.svg b/plugins/gh-stack/assets/icon.svg index ec07490..788d587 100644 --- a/plugins/gh-stack/assets/icon.svg +++ b/plugins/gh-stack/assets/icon.svg @@ -1,4 +1,4 @@ - + diff --git a/plugins/gtd-sidebar/assets/icon.svg b/plugins/gtd-sidebar/assets/icon.svg index 61ccfa7..9458f3f 100644 --- a/plugins/gtd-sidebar/assets/icon.svg +++ b/plugins/gtd-sidebar/assets/icon.svg @@ -1,4 +1,4 @@ - + diff --git a/plugins/monokai/assets/icon.svg b/plugins/monokai/assets/icon.svg index 40ee47b..96d03f9 100644 --- a/plugins/monokai/assets/icon.svg +++ b/plugins/monokai/assets/icon.svg @@ -1,4 +1,4 @@ - + diff --git a/plugins/notify/assets/icon.svg b/plugins/notify/assets/icon.svg index d3d1425..87ceea7 100644 --- a/plugins/notify/assets/icon.svg +++ b/plugins/notify/assets/icon.svg @@ -1,4 +1,4 @@ - + diff --git a/plugins/pr-walkthrough/assets/icon.svg b/plugins/pr-walkthrough/assets/icon.svg index 7f2665d..67ff20e 100644 --- a/plugins/pr-walkthrough/assets/icon.svg +++ b/plugins/pr-walkthrough/assets/icon.svg @@ -1,4 +1,4 @@ - + diff --git a/scripts/plugin-icons.ts b/scripts/plugin-icons.ts index 8696f3e..016c29f 100644 --- a/scripts/plugin-icons.ts +++ b/scripts/plugin-icons.ts @@ -28,6 +28,10 @@ const themeColors = { light: "oklch(44% 0 0)", dark: "oklch(78% 0 0)", } as const; +// BB paints installed compact assets as currentColor masks, and bb 0.40 does +// the same for marketplace SVGs. BB 0.39 renders marketplace SVGs as images, +// so use a neutral fallback that stays visible on both light and dark cards. +const compactFallbackColor = "#767676"; // A filled brand mark needs flat hex, not the stroked glyphs' currentColor. const brandColors = { light: "#666666", dark: "#B8B8B8" } as const; @@ -202,14 +206,14 @@ async function expectedFiles(plugin: CustomPlugin): Promise> if (entry.brand !== undefined) { const { brand } = entry; return new Map([ - [join(directory, "icon.svg"), brandSvg(brand, "#000")], + [join(directory, "icon.svg"), brandSvg(brand, compactFallbackColor)], [join(directory, "logo.svg"), brandSvg(brand, brandColors.light)], [join(directory, "logo-dark.svg"), brandSvg(brand, brandColors.dark)], ]); } const nodes = entry.nodes as readonly IconNode[]; return new Map([ - [join(directory, "icon.svg"), svg(nodes, "#000", false)], + [join(directory, "icon.svg"), svg(nodes, compactFallbackColor, false)], [join(directory, "logo.svg"), svg(nodes, themeColors.light, true)], [join(directory, "logo-dark.svg"), svg(nodes, themeColors.dark, true)], ]);