From 79a44bde5d07c878e960b37547df295de0b089c0 Mon Sep 17 00:00:00 2001 From: Zac Date: Tue, 24 Feb 2026 23:44:31 -0700 Subject: [PATCH 1/2] fix links not preventing default --- package.json | 3 ++- src/lib/router/impl/webRouter.svelte.ts | 1 + src/lib/router/router.svelte.ts | 3 ++- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 6cacfa4..657c89b 100644 --- a/package.json +++ b/package.json @@ -59,5 +59,6 @@ "typescript-eslint": "^8.0.0", "vite": "^6.0.0", "vitest": "^2.0.4" - } + }, + "packageManager": "pnpm@10.30.2+sha512.36cdc707e7b7940a988c9c1ecf88d084f8514b5c3f085f53a2e244c2921d3b2545bc20dd4ebe1fc245feec463bb298aecea7a63ed1f7680b877dc6379d8d0cb4" } diff --git a/src/lib/router/impl/webRouter.svelte.ts b/src/lib/router/impl/webRouter.svelte.ts index cc5812c..a7ad5e5 100644 --- a/src/lib/router/impl/webRouter.svelte.ts +++ b/src/lib/router/impl/webRouter.svelte.ts @@ -42,6 +42,7 @@ class WebRouter implements Router { this.options = Object.freeze(options); // we want to listen to popstate events to update the current route // in this router + // TODO THIS SHOULD NOT BE HERE window.addEventListener('popstate', async (ev) => { ev.preventDefault(); this.switchTo(window.location.pathname + window.location.search, {}, false); diff --git a/src/lib/router/router.svelte.ts b/src/lib/router/router.svelte.ts index 464fc94..09ead33 100644 --- a/src/lib/router/router.svelte.ts +++ b/src/lib/router/router.svelte.ts @@ -300,7 +300,8 @@ export function getRouteContainer(): RouteContainer { export const href = (href: string): Attachment => { const router = getRouter(); return (element) => { - const handler = () => { + const handler = (ev: Event) => { + ev.preventDefault() router.switchTo(href) } element.href = href; From 4f529acfedace4a7492b2b25371e27f7950a5258 Mon Sep 17 00:00:00 2001 From: Zac Date: Tue, 24 Feb 2026 23:46:17 -0700 Subject: [PATCH 2/2] remove packageManager field from package.json --- package.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/package.json b/package.json index 657c89b..6cacfa4 100644 --- a/package.json +++ b/package.json @@ -59,6 +59,5 @@ "typescript-eslint": "^8.0.0", "vite": "^6.0.0", "vitest": "^2.0.4" - }, - "packageManager": "pnpm@10.30.2+sha512.36cdc707e7b7940a988c9c1ecf88d084f8514b5c3f085f53a2e244c2921d3b2545bc20dd4ebe1fc245feec463bb298aecea7a63ed1f7680b877dc6379d8d0cb4" + } }