Skip to content
This repository was archived by the owner on Oct 18, 2021. It is now read-only.
This repository was archived by the owner on Oct 18, 2021. It is now read-only.

compression flag not properly queried #17

Description

@levigroker

In BLIPMessage.m _receivedFrameWithFlags: body: line 365:

if( self.compressed && encodedLength>0 ) {

self.compressed refers to _flags which has not been updated with the flags passed into the method and therefore self.compressed will return NO even if the given flags suggest the body is compressed. This causes the body data to not be decompressed and confuses consumers of the message.

I'm not sure what the proper fix is since I don't quite understand the relationship between _flags and flags, but the method seems to use them in an inconsistent way throughout. It would seem _flags needs to be properly updated by the passed in flags parameter...

As a workaround (which reflects from previous revisions), one can replace line 365 with:

if( flags & kBLIP_Compressed && encodedLength>0 ) {

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions