[bug] number_format none type

[LaniakeaS]

version: 0.2.0
python: 3.11

xls2xlsx.py: line 280 elif number_format.endswith('/d/yy'):

sometime the number_format is None, which cause the exception None type has no attribute endswith.

[LaniakeaS]

probably can be solved if i change line278
if number_format == 'General':
to
if number_format is None or number_format == 'General':

[siruku6]

I also encountered a similar issue like this:

TypeError: <class 'openpyxl.styles.numbers.NumberFormat'>.formatCode should be <class 'str'> but value is <class 'NoneType'>

dependencies

• version: 0.2.0
• python: 3.11

Error

File /working_dir/src/infrastructure/file_converters/excel.py:44, in convert_from_xls(xls_path)
     41 outfile: str = f"{xls_path.rstrip('.xls')}.xlsx".split("/")[-1]
     43 x2x = XLS2XLSX(xls_path)
---> 44 x2x.to_xlsx(outfile)
     45 return outfile

File /usr/local/lib/python3.11/site-packages/xls2xlsx/xls2xlsx.py:333, in XLS2XLSX.to_xlsx(self, filename)
    330     ws = None
    332 if filename:
--> 333     wb.save(filename=filename)
    334     return filename
    335 return wb

File /usr/local/lib/python3.11/site-packages/openpyxl/workbook/workbook.py:386, in Workbook.save(self, filename)
    384 if self.write_only and not self.worksheets:
    385     self.create_sheet()
--> 386 save_workbook(self, filename)

File /usr/local/lib/python3.11/site-packages/openpyxl/writer/excel.py:294, in save_workbook(workbook, filename)
    292 workbook.properties.modified = datetime.datetime.now(tz=datetime.timezone.utc).replace(tzinfo=None)
    293 writer = ExcelWriter(workbook, archive)
--> 294 writer.save()
    295 return True

File /usr/local/lib/python3.11/site-packages/openpyxl/writer/excel.py:275, in ExcelWriter.save(self)
    273 def save(self):
    274     """Write data into the archive."""
--> 275     self.write_data()
    276     self._archive.close()

File /usr/local/lib/python3.11/site-packages/openpyxl/writer/excel.py:84, in ExcelWriter.write_data(self)
     80 self._write_charts()
     82 self._write_external_links()
---> 84 stylesheet = write_stylesheet(self.workbook)
     85 archive.writestr(ARC_STYLE, tostring(stylesheet))
     87 writer = WorkbookWriter(self.workbook)

File /usr/local/lib/python3.11/site-packages/openpyxl/styles/stylesheet.py:254, in write_stylesheet(wb)
    252 fmts = []
    253 for idx, code in enumerate(wb._number_formats, BUILTIN_FORMATS_MAX_SIZE):
--> 254     fmt = NumberFormat(idx, code)
    255     fmts.append(fmt)
    257 stylesheet.numFmts.numFmt = fmts

File /usr/local/lib/python3.11/site-packages/openpyxl/styles/numbers.py:176, in NumberFormat.__init__(self, numFmtId, formatCode)
    171 def __init__(self,
    172              numFmtId=None,
    173              formatCode=None,
    174             ):
    175     self.numFmtId = numFmtId
--> 176     self.formatCode = formatCode

File /usr/local/lib/python3.11/site-packages/openpyxl/descriptors/base.py:46, in Typed.__set__(self, instance, value)
     44         if DEBUG:
     45             msg = f"{instance.__class__}.{self.name} should be {self.expected_type} but {value} is {type(value)}"
---> 46         raise TypeError(msg)
     47 super().__set__(instance, value)

TypeError: <class 'openpyxl.styles.numbers.NumberFormat'>.formatCode should be <class 'str'> but value is <class 'NoneType'>

But, I can't find out why this issue happens...

Moreover, openpyxl has already been archived.