Skip to content

MemoryMonitor behavior with maximum_size_limit #3

Description

@gsar

It appears that MemoryMonitor sends a SIGINT to the worker immediately, which currently doesn't provide any time for the in-flight requests to finish. Is it feasible to:

  1. trigger GC for configurable amount of time (default: one interval cycle), and then do the worker termination?
  2. when terminating, stop accepting new connections, but wait a configurable amount of time for in-flight requests to drain (default: one interval).
  3. anything still incomplete after that can be forcefully terminated.

I recognize these are technically not things that MemoryMonitor can do (GC and graceful draining of connections need to happen in worker) but adding it here since I expect MemoryMonitor to participate in the phased approach to worker termination.

Thanks!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions