NH-103815: update the default resource attributes#185
Conversation
| RESOURCE_ATTRIBUTE = 'RESOURCE_ATTRIBUTE' | ||
|
|
There was a problem hiding this comment.
Was this meant to go from plural to singular ?
There was a problem hiding this comment.
I was just creating some name for in-code configuration, but I can change to plural (e.g. RESOURCE_ATTRIBUTES = 'RESOURCE_ATTRIBUTES')
| require 'socket' | ||
| require 'securerandom' | ||
| require 'opentelemetry/resource/detector/azure' | ||
| require 'opentelemetry/resource/detector/aws/ec2' if RUBY_VERSION >= '3.1.0' |
There was a problem hiding this comment.
@xuan-cao-swi does the latest release https://github.com/open-telemetry/opentelemetry-ruby-contrib/releases/tag/opentelemetry-resource-detector-aws%2Fv0.3.0 mean we can remove this special casing for ruby 3.1.0 here and in the test_gems.gemfile file? If not, mind putting in a comment on why this is needed?
There was a problem hiding this comment.
This gem require ruby version >= 3.1.0 (include its v0.1.0), so anyone who wants to use the aws resource detector has to use ruby >= 3.1.0
There was a problem hiding this comment.
Added comments.
cheempz
left a comment
cheempz
left a comment
There was a problem hiding this comment.
LGTM, thanks @xuan-cao-swi!
3 participants
Description
Test (if applicable)
Azure platform; EC2; ContianerID