NH-110595: update readme.#195
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| puts "\n=== install required dependencies ===\n" | ||
| system('bundle install --without development --without test') | ||
| system('bundle install') |
Contributor
There was a problem hiding this comment.
The .md file changes are generally good and it seems ok to also update .gitignore in this PR. But Rakefile and config.rb changes could be out of scope for a PR to only update Readme. Could the Description or ticket please be updated?
Contributor
Author
There was a problem hiding this comment.
Thanks, I have reduced the scope not include these changes.
Contributor
There was a problem hiding this comment.
Could we also leave this .rb file removal out of this PR?
Contributor
Author
There was a problem hiding this comment.
Added back all .rb file.
| if defined?(SolarWindsAPM::Config) | ||
|
|
||
| # :service_key, :hostname_alias, :http_proxy, and :debug_level | ||
| # :service_key, :debug_level |
Contributor
There was a problem hiding this comment.
We're still editing this .rb file but it's removal of comments, so I think this i ok.
Co-authored-by: Tammy Baylis <96076570+tammy-baylis-swi@users.noreply.github.com>
tammy-baylis-swi
approved these changes
Jun 12, 2025
Contributor
tammy-baylis-swi
left a comment
tammy-baylis-swi
left a comment
There was a problem hiding this comment.
Thank you! Lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test (if applicable)