pre-release change for working with ruby 3.0.0#196
Merged
Conversation
cleverchuk
approved these changes
Jun 10, 2025
| file.each_line do |line| | ||
| line = line.strip | ||
| # Look for container ID (64 chars) at the end of the line | ||
| return line[-CONTAINER_ID_LENGTH..] if line.length > CONTAINER_ID_LENGTH |
There was a problem hiding this comment.
is it guaranteed that the first line that satisfies this constraint is actually a container id?
Contributor
Author
There was a problem hiding this comment.
This upstream code was copied from otel-js. I can't guarantee first line that satisfies this constraint is actually a container id since I didn't do any test myself.
There was a problem hiding this comment.
it looks like a follow-on PR to validate that it's indeed a container id might be worth a shot?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The change is for pre-release solarwinds_apm ruby 7.0.0.prev1
Test (if applicable)
Tested on workflow: verify_install and ad-hoc test from testbed.