From 3345fadad465f7910641fc8b9a545a9d9461c581 Mon Sep 17 00:00:00 2001 From: martascorreia Date: Wed, 18 Mar 2026 15:12:14 +0000 Subject: [PATCH 01/12] fix: combobox story in mobile --- packages/components/src/components/combobox/combobox.ts | 2 +- packages/docs/src/stories/components/combobox.stories.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/components/src/components/combobox/combobox.ts b/packages/components/src/components/combobox/combobox.ts index 7aec2df86e..c4b71d26d6 100644 --- a/packages/components/src/components/combobox/combobox.ts +++ b/packages/components/src/components/combobox/combobox.ts @@ -1319,7 +1319,7 @@ export default class SdCombobox extends SolidElement implements SolidFormControl part="combobox" class=${cx( 'relative w-full px-4 flex flex-row items-center rounded-default transition-colors hover:duration-fast ease-in-out', - this.visuallyDisabled || this.disabled ? 'hover:bg-transparent' : 'hover:bg-neutral-200', + !this.disabled && !this.visuallyDisabled ? 'hover:bg-neutral-200' : '', this.open && 'shadow transition-shadow duration-medium ease-in-out', ['invalid', 'activeInvalid'].includes(selectState) && 'form-control--invalid-color-background', { diff --git a/packages/docs/src/stories/components/combobox.stories.ts b/packages/docs/src/stories/components/combobox.stories.ts index 9e95cdb139..f02a58b478 100644 --- a/packages/docs/src/stories/components/combobox.stories.ts +++ b/packages/docs/src/stories/components/combobox.stories.ts @@ -85,7 +85,7 @@ export const Default = { delete args['getOption']; delete args['getOption-attr']; - return html`
${generateTemplate({ args })}
`; + return html`
${generateTemplate({ args })}
`; } }; From 8bdeaeccef48aa41aa220f12a48eb38b38a6b881 Mon Sep 17 00:00:00 2001 From: martascorreia Date: Thu, 19 Mar 2026 11:43:37 +0000 Subject: [PATCH 02/12] fix: grey background when selected in mobile --- packages/components/src/components/combobox/combobox.ts | 4 +++- packages/components/src/components/input/input.ts | 4 +++- packages/components/src/components/select/select.ts | 4 +++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/packages/components/src/components/combobox/combobox.ts b/packages/components/src/components/combobox/combobox.ts index c4b71d26d6..b20ce3397f 100644 --- a/packages/components/src/components/combobox/combobox.ts +++ b/packages/components/src/components/combobox/combobox.ts @@ -1319,7 +1319,9 @@ export default class SdCombobox extends SolidElement implements SolidFormControl part="combobox" class=${cx( 'relative w-full px-4 flex flex-row items-center rounded-default transition-colors hover:duration-fast ease-in-out', - !this.disabled && !this.visuallyDisabled ? 'hover:bg-neutral-200' : '', + this.visuallyDisabled || this.disabled + ? 'hover:bg-transparent' + : 'hover:[@media(hover:hover)]:bg-neutral-200', this.open && 'shadow transition-shadow duration-medium ease-in-out', ['invalid', 'activeInvalid'].includes(selectState) && 'form-control--invalid-color-background', { diff --git a/packages/components/src/components/input/input.ts b/packages/components/src/components/input/input.ts index 689584a779..bb0679a7fc 100644 --- a/packages/components/src/components/input/input.ts +++ b/packages/components/src/components/input/input.ts @@ -635,7 +635,9 @@ export default class SdInput extends SolidElement implements SolidFormControl { 'px-4 flex flex-row items-center rounded-default transition-colors ease-in-out duration-medium hover:duration-fast', this.floatingLabel && 'has-floating-label', // States - !this.disabled && !this.readonly && !this.visuallyDisabled ? 'hover:bg-neutral-200' : '', + !this.disabled && !this.readonly && !this.visuallyDisabled + ? 'hover:[@media(hover:hover)]:bg-neutral-200' + : '', this.readonly ? 'bg-neutral-100' : 'bg-white', ['disabled', 'visuallyDisabled'].includes(inputState) ? 'text-neutral-500' : 'form-control-color-text', ['invalid', 'activeInvalid'].includes(inputState) && 'form-control--invalid-color-background', diff --git a/packages/components/src/components/select/select.ts b/packages/components/src/components/select/select.ts index 15e7ea425f..e8147831ad 100644 --- a/packages/components/src/components/select/select.ts +++ b/packages/components/src/components/select/select.ts @@ -1050,7 +1050,9 @@ export default class SdSelect extends SolidElement implements SolidFormControl {
Date: Thu, 19 Mar 2026 11:50:16 +0000 Subject: [PATCH 03/12] fix: fixed grey background for the remaining form components --- packages/components/src/components/datepicker/datepicker.ts | 4 +++- packages/components/src/components/textarea/textarea.ts | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/components/src/components/datepicker/datepicker.ts b/packages/components/src/components/datepicker/datepicker.ts index 74861a3a94..5a25fba835 100644 --- a/packages/components/src/components/datepicker/datepicker.ts +++ b/packages/components/src/components/datepicker/datepicker.ts @@ -2024,7 +2024,9 @@ export default class SdDatepicker extends SolidElement implements SolidFormContr part="base" class=${cx( 'px-4 flex flex-row items-center rounded-default transition-colors ease-in-out duration-medium hover:duration-fast w-full', - !this.disabled && !this.readonly && !this.visuallyDisabled ? 'hover:bg-neutral-200' : '', + !this.disabled && !this.readonly && !this.visuallyDisabled + ? 'hover:[@media(hover:hover)]:bg-neutral-200' + : '', this.readonly ? 'bg-neutral-100' : 'bg-white', inputState === 'disabled' || inputState === 'visuallyDisabled' ? 'text-neutral-500' : 'text-black' )} diff --git a/packages/components/src/components/textarea/textarea.ts b/packages/components/src/components/textarea/textarea.ts index 88a62fc022..290874fc21 100644 --- a/packages/components/src/components/textarea/textarea.ts +++ b/packages/components/src/components/textarea/textarea.ts @@ -447,7 +447,9 @@ export default class SdTextarea extends SolidElement implements SolidFormControl md: 'textarea-md', lg: 'textarea-lg' }[this.size], - !this.disabled && !this.readonly && !this.visuallyDisabled ? 'hover:bg-neutral-200' : '', + !this.disabled && !this.readonly && !this.visuallyDisabled + ? 'hover:[@media(hover:hover)]:bg-neutral-200' + : '', this.readonly ? 'bg-neutral-100' : 'bg-white', textareaState === 'disabled' || textareaState === 'visuallyDisabled' ? 'text-neutral-500' From 4e28ba9fa36d5471f26229b79624b6d18e1537e4 Mon Sep 17 00:00:00 2001 From: martascorreia Date: Thu, 19 Mar 2026 11:51:42 +0000 Subject: [PATCH 04/12] chore: adding changeset --- .changeset/quiet-bugs-trade.md | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 .changeset/quiet-bugs-trade.md diff --git a/.changeset/quiet-bugs-trade.md b/.changeset/quiet-bugs-trade.md new file mode 100644 index 0000000000..cebe6fe3c6 --- /dev/null +++ b/.changeset/quiet-bugs-trade.md @@ -0,0 +1,7 @@ +--- +'@solid-design-system/components': minor +'@solid-design-system/docs': minor +--- + +- Fixed the mobile clipping for the `sd-combobox` stories in the Documentation. +- Fixed the mobile background when focused for the components `sd-combobox`, `sd-input`, `sd-select`, `sd-datepicker` and `sd-textarea`. \ No newline at end of file From 8d8e322e6677f7533401ff94ee5897b92a34906e Mon Sep 17 00:00:00 2001 From: martascorreia Date: Thu, 19 Mar 2026 13:22:44 +0000 Subject: [PATCH 05/12] fix: fixing all the other stories --- .../stories/components/combobox.stories.ts | 154 ++++++++++-------- 1 file changed, 90 insertions(+), 64 deletions(-) diff --git a/packages/docs/src/stories/components/combobox.stories.ts b/packages/docs/src/stories/components/combobox.stories.ts index f02a58b478..91fb483f94 100644 --- a/packages/docs/src/stories/components/combobox.stories.ts +++ b/packages/docs/src/stories/components/combobox.stories.ts @@ -100,30 +100,34 @@ export const Default = { export const Size = { render: () => html` -
- - Option 1 - Option 2 - Option 3 - Option 4 - Option 5 - - - - Option 1 - Option 2 - Option 3 - Option 4 - Option 5 - - - - Option 1 - Option 2 - Option 3 - Option 4 - Option 5 - +
+
+ + Option 1 + Option 2 + Option 3 + Option 4 + Option 5 + +
+
+ + Option 1 + Option 2 + Option 3 + Option 4 + Option 5 + +
+
+ + Option 1 + Option 2 + Option 3 + Option 4 + Option 5 + +
` }; @@ -135,16 +139,21 @@ export const Size = { */ export const Placement = { render: () => html` -
- +
+ Option 1 Option 2 Option 3 Option 4 Option 5 - - + Option 1 Option 2 Option 3 @@ -162,23 +171,26 @@ export const Placement = { */ export const Label = { render: () => html` -
- - Option 1 - Option 2 - Option 3 - Option 4 - Option 5 - - - -
Label slot
- Option 1 - Option 2 - Option 3 - Option 4 - Option 5 -
+
+
+ + Option 1 + Option 2 + Option 3 + Option 4 + Option 5 + +
+
+ +
Label slot
+ Option 1 + Option 2 + Option 3 + Option 4 + Option 5 +
+
` }; @@ -190,7 +202,7 @@ export const Label = { */ export const FloatingLabel = { render: () => html` -
+
Option 1 Option 2 @@ -207,7 +219,7 @@ export const FloatingLabel = { */ export const Placeholder = { render: () => html` -
+
Option 1 Option 2 @@ -224,7 +236,7 @@ export const Placeholder = { */ export const Disabled = { render: () => html` -
+
Option 1 Option 2 @@ -245,7 +257,7 @@ export const Disabled = { */ export const VisuallyDisabled = { render: () => html` -
+
html` -
- +
+ Option 1 Option 2 Option 3 @@ -282,7 +301,13 @@ export const HelpText = { Option 5 - +
Help text slot
Option 1 Option 2 @@ -303,7 +328,7 @@ export const Focus = { elm?.focus(); }, render: () => html` -
+
Option 1 Option 2 @@ -318,7 +343,7 @@ export const Focus = { */ export const SuggestionContainerHeight = { render: () => html` -
+