From d6014a93990de82e4b7f9212a0ceb6e0da85d83d Mon Sep 17 00:00:00 2001 From: Martin Meyerhoff Date: Fri, 2 May 2025 14:09:37 +0200 Subject: [PATCH 1/2] Rubocop config: Use plugins for rubocop-rails and rubocop-performance Since Rubocop 1.72, we have to use plugins instead of require. --- lib/solidus_dev_support/rubocop/config.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/solidus_dev_support/rubocop/config.yml b/lib/solidus_dev_support/rubocop/config.yml index ed66061f..5216288e 100644 --- a/lib/solidus_dev_support/rubocop/config.yml +++ b/lib/solidus_dev_support/rubocop/config.yml @@ -1,4 +1,7 @@ -require: ["rubocop-rspec", "rubocop-rails", "rubocop-performance"] +plugins: + - rubocop-performance + - rubocop-rails + - rubocop-rspec AllCops: {TargetRubyVersion: 2.5, Exclude: ["spec/dummy/**/*", "sandbox/**/*", "vendor/**/*"]} From 902e88681bd2fd7bfdc9df59f41d12f17eaccc04 Mon Sep 17 00:00:00 2001 From: Martin Meyerhoff Date: Fri, 2 May 2025 14:13:54 +0200 Subject: [PATCH 2/2] Bump TargetRubyVersion to 3.0 2.5 is really, really old. --- lib/solidus_dev_support/rubocop/config.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/solidus_dev_support/rubocop/config.yml b/lib/solidus_dev_support/rubocop/config.yml index 5216288e..291a638b 100644 --- a/lib/solidus_dev_support/rubocop/config.yml +++ b/lib/solidus_dev_support/rubocop/config.yml @@ -3,7 +3,9 @@ plugins: - rubocop-rails - rubocop-rspec -AllCops: {TargetRubyVersion: 2.5, Exclude: ["spec/dummy/**/*", "sandbox/**/*", "vendor/**/*"]} +AllCops: + TargetRubyVersion: 3.0 + Exclude: ["spec/dummy/**/*", "sandbox/**/*", "vendor/**/*"]} Layout/ArgumentAlignment: {EnforcedStyle: with_fixed_indentation} Layout/DotPosition: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#layoutdotposition"}