Skip to content

PayPal Controllers are always installed #431

@jarednorman

Description

@jarednorman

Solidus Version:

This affects anyone using the current version of solidus_starter_frontend.

To Reproduce

  1. Generate a new store with solidus_starter_frontend
  2. Look at the code

Current behavior

PayPal stuff is installed.

Expected behavior

Unless you selected it, PayPal stuff should not be installed.

Additional context

@jimryan reported this in a private repo:

Just tried on main and definitely did not choose paypal (I chose Stripe) and got the same result, I think it's because:

  1. The solidus:install generator applies the starter frontend template (source)
  2. That template executes the starter frontend template.rb from github (source)
  3. That copies the entire starter frontend template app folder to the host app (source)
  4. That contains the paypal controllers (source

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions