fix: address TheWitness review feedback on PR Cacti#290

- Remove redundant locales/index.php and locales/LC_MESSAGES/index.php
- Revert database.php optional null param (single connection per script)
- Replace json_encode with __esc() for JS string output in setup.php

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

Author: somethingwithproof

database.php

@@ -174,12 +174,9 @@ function syslog_db_fetch_assoc_prepared($sql, $params = array(), $log = TRUE) {
  *
  * @return the id of the last auto incriment row that was created
  */
-function syslog_db_fetch_insert_id($syslog_cnn = null) {
-	if ($syslog_cnn === null) {
-		global $syslog_cnn;
-	}
-
-	return db_fetch_insert_id($syslog_cnn);
+function syslog_db_fetch_insert_id() {
+	global $syslog_cnn;
+	return  db_fetch_insert_id($syslog_cnn);
 }
 
 /**

locales/LC_MESSAGES/index.php

@@ -23,5 +23,4 @@
 */
 
 header('Location:../index.php');
-exit;
 

locales/index.php

@@ -23,5 +23,4 @@
 */
 
 header('Location:../index.php');
-exit;
 

setup.php

@@ -1652,21 +1652,21 @@ function syslog_utilities_list() {
 			$(function() {
 				$('#syslog_purge_hosts').on('click', function() {
 					$('#syslog_purge_dialog').dialog({
-						title: <?php print json_encode(__('Confirm Purge', 'syslog'), JSON_HEX_TAG | JSON_HEX_AMP | JSON_HEX_APOS | JSON_HEX_QUOT);?>,
+						title: <?php print "'" . __esc('Confirm Purge', 'syslog') . "'";?>,
 						minHeight: 80,
 						minWidth: 400,
 						resizable: false,
 						draggable: true,
 						buttons: {
 							'Cancel': {
-								text: <?php print json_encode(__('Cancel', 'syslog'), JSON_HEX_TAG | JSON_HEX_AMP | JSON_HEX_APOS | JSON_HEX_QUOT);?>,
+								text: <?php print "'" . __esc('Cancel', 'syslog') . "'";?>,
 								id: 'btnPurgeCancel',
 								click: function() {
 									$(this).dialog('close');
 								}
 							},
 							'Continue': {
-								text: <?php print json_encode(__('Continue', 'syslog'), JSON_HEX_TAG | JSON_HEX_AMP | JSON_HEX_APOS | JSON_HEX_QUOT);?>,
+								text: <?php print "'" . __esc('Continue', 'syslog') . "'";?>,
 								id: 'btnPurgeContinue',
 								click: function() {
 									$(this).dialog('close');