Commit-message Editor-window is missing OK button, opens on other monitor

[goran-w]

Follow-up to #2096 - there is no longer any button (OK or similar) visible at the bottom of the (Merge-)commit message Editor window? (The window can be closed with the X close-button in its upper right corner, but it's unclear to the user whether this is supposed to mean "OK" or "Cancel"/"Abort"...)

Also, related to #2100 - this Editor window appears on another (the primary) monitor, but it would be much better if this (sub-)window appeared at the center of the current main window.

[love-linger]

This is by design. I think that since directly closing the window (by clicking the close button or pressing ESC) applies the changes, there is no need for an OK button.

[goran-w]

I find it rather confusing, since basically all other dialogs/windows use OK / Cancel when closing them will cause side-effects.

What if we at this point discover (for example, by reading the commented / suggested merge-message lines) that we forgot something or we don't really want to proceed with committing the merge? It's frustrating to have this as a "point of no return", where we are "pausing" to give more input, but still we aren't able to Cancel / Abort the Merge action.

Also, pressing the 'X' Close button in many other programs means Cancel rather than OK (whenever there's a choice), often with a warning "You have unsaved changes. Do you really want to abandon these?" or similar...

Therefore, for consistency, I think this window should be a "dialog" (although possibly a resizeable one) without a 'X' Close button and instead with OK & Cancel buttons.

---

Finally, I don't suppose opening this window on another monitor is also "by design"? 😉

[love-linger]

Therefore, for consistency, I think this window should be a "dialog" (although possibly a resizeable one) without a 'X' Close button and instead with OK & Cancel buttons.

I do not think without X button means 'consistency'. I do not want to discuss this any longer. Commit ceea4a1 has been reverted.

Finally, I don't suppose opening this window on another monitor is also "by design"?

This is because the Commit Message Editor window is opened by another git process (via core.editor configuration) while merging, not by SourceGit (it is not a sub-window of SourceGit)

[goran-w]

This is because the Commit Message Editor window is opened by another git process (via core.editor configuration) while merging, not by SourceGit (it is not a sub-window of SourceGit)

I see, but couldn't this Window somehow locate/receive info about the main SourceGit window, so as to position itself relative to that?