[to test AI review bots] Add editor app for editing blogs and job posts (#880)#3
Open
brendanator wants to merge 1 commit into
Conversation
Author
|
This is a benchmark review for experiment This pull request was cloned from Experiment configurationreview_config:
# User configuration for the review
# - benchmark - use the user config from the benchmark reviews
# - <value> - use the value directly
user_review_config:
enable_ai_review: true
enable_rule_comments: false
enable_complexity_comments: benchmark
enable_security_comments: benchmark
enable_tests_comments: benchmark
enable_comment_suggestions: benchmark
enable_pull_request_summary: benchmark
enable_review_guide: benchmark
enable_approvals: true
ai_review_config:
# The model responses to use for the experiment
# - benchmark - use the model responses from the benchmark reviews
# - llm - call the language model to generate responses
model_responses:
comments_model: benchmark
comment_validation_model: benchmark
comment_suggestion_model: benchmark
complexity_model: benchmark
security_model: benchmark
tests_model: benchmark
pull_request_summary_model: benchmark
review_guide_model: benchmark
overall_comments_model: benchmark
# The pull request dataset to run the experiment on
pull_request_dataset:
- https://github.com/bluedotimpact/bluedot/pull/909
# Questions to ask to label the review comments
review_comment_labels: []
# - label: correct
# question: Is this comment correct?
# Benchmark reviews generated by running
# python -m scripts.experiment benchmark <experiment_name>
benchmark_reviews: []
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to f7c59e6 in 2 minutes and 24 seconds. Click for details.
- Reviewed
1450lines of code in40files - Skipped
2files when reviewing. - Skipped posting
13draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. apps/editor/src/lib/api/makeApiRoute.ts:5
- Draft comment:
Consider extracting this configuration into a shared utility that both apps can use. - functionmakeApiRoute(makeApiRoute.ts) - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 30% vs. threshold = 50% The suggestion is reasonable since it would reduce code duplication. However, this is a new file being added, and the comment requires knowledge of another file in a different app to understand the duplication. The comment also doesn't provide clear guidance on where/how to make this shared utility. The duplication might be intentional to keep apps decoupled. Also, the shared code is very small (3 lines) so the benefit of extracting it might not justify the added complexity. While keeping apps decoupled is important, they already share dependencies (@bluedot/ui). The suggestion could help maintain consistency across apps. Delete the comment. While the suggestion has merit, it requires cross-file context and the benefit is debatable given the small amount of duplicated code.
2. apps/editor/.env.local.template:1
- Draft comment:
Consider adding example placeholder values or additional documentation for required env variables. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%None
3. apps/editor/.env.test:1
- Draft comment:
Verify that test tokens (e.g., FAKE_TOKEN) do not accidentally leak into production configurations. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%None
4. apps/editor/Dockerfile:20
- Draft comment:
Ensure that the COPY directives correctly reference the build output; confirm permissions and paths. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
5. apps/editor/src/components/MarkdownEditor.tsx:166
- Draft comment:
Uploader resolves file 'name' as an empty string. Consider using file.name to preserve the original filename. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50% The code is new/changed in this PR. The name field is part of the UploaderData type from tiptap-starter-kit. Looking at how the data is used, it appears this name field could be useful for accessibility or file management purposes. However, I don't see where this name field is actually used in the visible code. The final output just uses the URL in an Embed tag. I might be missing some important use case for the filename in the tiptap library internals. The name field exists in the type for a reason. While the name field might have uses, without clear evidence that it's needed or used, suggesting this change could be premature optimization. Since we can't see clear evidence that the name field is used or important, and the code works fine with an empty string, this comment should be removed.
6. apps/editor/src/pages/api/jobs/[slug]/index.ts:55
- Draft comment:
In the PUT case, the response key is incorrectly set as 'blog' instead of 'job'. - Reason this comment was not posted:
Marked as duplicate.
7. apps/editor/README.md:11
- Draft comment:
Minor typographical error: Consider capitalizing 'docker' to 'Docker' in the deployment description (line 11) for consistency with the official branding. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% While technically correct about Docker's official capitalization, this is an extremely minor documentation issue. The meaning is perfectly clear either way. The rules specifically say not to make purely informative comments and to avoid unimportant changes. This seems like exactly the kind of nitpicky comment we should remove. Docker's official branding guidelines do specify capitalization, so this isn't technically wrong. Documentation consistency can be important for professionalism. While correct, this is too minor to warrant a comment. It doesn't affect functionality or clarity, and the rules explicitly say to avoid unimportant changes. Delete this comment as it's too minor and purely informative, not suggesting any meaningful code change.
8. apps/editor/src/components/BodyEditor.tsx:94
- Draft comment:
It looks like "text-size-sm" on line 94 might be a typographical error. In many styling frameworks (e.g., Tailwind CSS), the class is typically "text-sm". Please double-check if "text-size-sm" is intentional or if it should be renamed for consistency. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 0% vs. threshold = 50% The rules explicitly state "Do NOT comment on any pure frontend UI or styling changes, only logic. Assume that if the author changed the UI, they did it correctly." This is purely a UI styling suggestion about CSS class names. Even if the suggestion might be correct, we should trust the author's UI decisions. The class name does look non-standard for Tailwind, so maybe this really is a typo that could cause styling issues? No - the rules are very clear about trusting UI decisions. The class could be custom-defined in their CSS system. We don't have enough context about their styling framework to make this call. This comment should be removed as it violates the rule about not commenting on UI and styling changes.
9. apps/editor/src/components/MarkdownEditor.tsx:106
- Draft comment:
It appears that the Tailwind CSS class 'text-size-xs' on the heading button may be a typographical error. Typically, Tailwind uses 'text-xs' for extra small text. Please verify if this is intentional or update it to 'text-xs' for consistency. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
10. apps/editor/src/pages/api/jobs/[slug]/index.ts:56
- Draft comment:
Typographical error: In the PUT case, the returned object uses the key 'blog' instead of 'job'. Please update the property name to 'job' to match the API response schema and ensure consistency with the GET route. - Reason this comment was not posted:
Marked as duplicate.
11. libraries/ui/src/default-config/tailwind.css:6
- Draft comment:
Missing semicolon after@apply text-inherit. Please add a semicolon at the end of this rule for consistency with the rest of the file. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
12. libraries/ui/src/default-config/tailwind.css:19
- Draft comment:
Missing semicolon after@apply not-italicwithin the blockquote styling. Please append a semicolon for proper CSS syntax. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
13. libraries/ui/src/default-config/tailwind.css:33
- Draft comment:
Missing semicolon after@apply hover:text-color-primary-accentin the link hover styling block. Please add a semicolon to complete the syntax. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_xaOpFlH7unhHj3jl
You can customize 
| }); | ||
| return { | ||
| type: 'success' as const, | ||
| blog: updatedJob, |
There was a problem hiding this comment.
Returned field is labeled 'blog' instead of 'job' in the PUT branch. Likely a bug.
Suggested change
| blog: updatedJob, | |
| job: updatedJob, |
| useEffect(() => { | ||
| const handleBeforeUnload = (e: BeforeUnloadEvent) => { | ||
| if (hasUnsavedChanges) { | ||
| e.preventDefault(); |
There was a problem hiding this comment.
Consider setting e.returnValue (e.g., e.returnValue = '') in the beforeunload event handler for broader browser support of unsaved changes warnings.
Suggested change
| e.preventDefault(); | |
| e.preventDefault(); e.returnValue = ''; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Important
Add
editorapp for managing blogs and job posts with Markdown editing, Airtable integration, and deployment configuration.editorapp for managing blogs and job posts with Markdown editing and image upload (MarkdownEditor.tsx,BodyEditor.tsx).index.ts,[slug]/index.ts).presigned-upload.ts).Dockerfile,serviceDefinitions.ts)..env.local.template,.env.test).tailwind.css,globals.css).MarkdownEditor(MarkdownEditor.test.tsx,MarkdownEditor.stories.tsx).status.test.ts).README.md).package.json).This description was created by
for f7c59e6. You can customize this summary. It will automatically update as commits are pushed.
CodeAnt-AI Description
editorapp for managing and editing blogs and job postings, including all core pages, API routes, and components.This PR introduces a full-featured editor app for BlueDot staff to manage content, including a custom Markdown editor with image upload, Airtable integration, and all necessary infrastructure for deployment and testing. It also improves code sharing and styling consistency across the codebase.
Changes walkthrough
23 files
MarkdownEditor.tsx
Add image upload and embed support to MarkdownEditor componentapps/editor/src/components/MarkdownEditor.tsx
uploadFileprop.MarkdownEditorPropstype.BodyEditor.tsx
Add BodyEditor component with file upload and save logicapps/editor/src/components/BodyEditor.tsx
BodyEditorcomponent for editing and saving markdowncontent.
BaseLayout.tsx
Add BaseLayout component with navigationapps/editor/src/components/BaseLayout.tsx
postings.
index.ts
Add API route for listing blog postsapps/editor/src/pages/api/blogs/index.ts
index.ts
Add API route for fetching and updating single blog postapps/editor/src/pages/api/blogs/[slug]/index.ts
index.ts
Add API route for listing job postingsapps/editor/src/pages/api/jobs/index.ts
index.ts
Add API route for fetching and updating single job postingapps/editor/src/pages/api/jobs/[slug]/index.ts
presigned-upload.ts
Add presigned S3 upload API route for file uploadsapps/editor/src/pages/api/presigned-upload.ts
uploads.
status.ts
Add status API endpointapps/editor/src/pages/api/status.ts
index.tsx
Add blog posts listing page with edit linksapps/editor/src/pages/blogs/index.tsx
[slug].tsx
Add blog post editor pageapps/editor/src/pages/blogs/[slug].tsx
index.tsx
Add job postings listing page with edit linksapps/editor/src/pages/jobs/index.tsx
[slug].tsx
Add job posting editor pageapps/editor/src/pages/jobs/[slug].tsx
index.tsx
Add home page redirect to blogsapps/editor/src/pages/index.tsx
index.tsx
Add login redirect pageapps/editor/src/pages/login/index.tsx
oauth-callback.tsx
Add OAuth callback page for loginapps/editor/src/pages/login/oauth-callback.tsx
index.ts
Add AirtableTs database instanceapps/editor/src/lib/api/db/index.ts
tables.ts
Define Airtable schemas for blogs and job postingsapps/editor/src/lib/api/db/tables.ts
env.ts
Add environment variable validation for APIapps/editor/src/lib/api/env.ts
secrets.
makeApiRoute.ts
Add helper for authenticated API routesapps/editor/src/lib/api/makeApiRoute.ts
token verification.
_app.tsx
Add custom App component with layout and SSR configapps/editor/src/pages/_app.tsx
tailwind.css
Move prose utility styles to shared UI librarylibraries/ui/src/default-config/tailwind.css
globals.css
Remove prose utility styles from website globalsapps/website/src/globals.css
3 files
MarkdownEditor.test.tsx
Add unit tests for MarkdownEditor componentapps/editor/src/components/MarkdownEditor.test.tsx
actions.
MarkdownEditor.stories.tsx
Add Storybook stories for MarkdownEditor componentapps/editor/src/components/MarkdownEditor.stories.tsx
content.
status.test.ts
Add test for status API endpointapps/editor/src/pages/api/status.test.ts
12 files
next.config.js
Add Next.js configuration fileapps/editor/next.config.js
postcss.config.js
Add PostCSS configuration for Tailwind CSSapps/editor/postcss.config.js
globals.css
Add global CSS imports for Tailwind and typographyapps/editor/src/globals.css
package.json
Add package.json for editor app dependencies and scriptsapps/editor/package.json
the editor app.
tsconfig.json
Add TypeScript configuration for editor appapps/editor/tsconfig.json
vitest.config.mjs
Add Vitest configuration for editor appapps/editor/vitest.config.mjs
tiptap-starter-kit.
Dockerfile
Add Dockerfile for editor app deploymentapps/editor/Dockerfile
production.
.env.local.template
Add .env.local.template for environment variablesapps/editor/.env.local.template
.env.test
Add .env.test for test environment variablesapps/editor/.env.test
next-env.d.ts
Add Next.js type definitionsapps/editor/next-env.d.ts
serviceDefinitions.ts
Add Kubernetes service definition for bluedot-editor appapps/infra/src/k8s/serviceDefinitions.ts
bluedot-editorapp in Kubernetes.vitest.config.mjs
Simplify Vitest config for website appapps/website/vitest.config.mjs
tiptap-starter-kit.
1 files
README.md
Add README for editor app setup and deploymentapps/editor/README.md
app.
1 files
package.json
Remove markdown editor dependencies from website package.jsonapps/website/package.json
package.json.
💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.
Summary by Sourcery
Create a new editor app for managing blogs and job posts, providing a comprehensive content management interface with Markdown editing, file uploads, and Airtable integration
New Features:
Enhancements:
Deployment:
Documentation:
Tests:
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Style
Chores
Refactor