Skip to content

CI runs only on pull_request — pushes to main are unvalidated #56

Description

@spaceshipmike

.github/workflows/check.yml triggers on pull_request: alone, so a direct or fast-forward push to main runs no CI.

Concrete failure: the packages/skills workspace (added in 494f778) landed via the prototype-driven-migration fast-forward with package-lock.json left out of sync, breaking npm ci on every subsequent PR. It stayed invisible because pushes to main aren't checked — only surfaced when #53 became the first PR after the migration. (Fixed in #53 via lockfile sync.)

Do: add a push: branches: [main] trigger to check.yml, and/or branch protection requiring PRs into main. Recorded as an Open tension in INVARIANTS.md.

Found during /close after #53.

Metadata

Metadata

Assignees

No one assigned

    Labels

    infraBuild, packaging, native deps, CI

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions